[jira] [Comment Edited] (KAFKA-8612) Broker removes consumers from CG, Streams app gets stuck

2020-05-05 Thread Prashant Waykar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100479#comment-17100479 ] Prashant Waykar edited comment on KAFKA-8612 at 5/6/20, 6:45 AM: --

[jira] [Commented] (KAFKA-9948) Gradle Issue

2020-05-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100512#comment-17100512 ] Chia-Ping Tsai commented on KAFKA-9948: --- It would be better to use gradle wrapper r

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-05 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r420568190 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,27 @@ private boolean dependsOnSpecificNode

[jira] [Comment Edited] (KAFKA-8612) Broker removes consumers from CG, Streams app gets stuck

2020-05-05 Thread Prashant Waykar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100479#comment-17100479 ] Prashant Waykar edited comment on KAFKA-8612 at 5/6/20, 6:12 AM: --

[GitHub] [kafka] gharris1727 commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-05 Thread GitBox
gharris1727 commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r420541836 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -246,15 +251,16 @@ public boolean startConnector(

[GitHub] [kafka] showuon commented on pull request #8611: MINOR: Format the notation content for better readability

2020-05-05 Thread GitBox
showuon commented on pull request #8611: URL: https://github.com/apache/kafka/pull/8611#issuecomment-624455001 Hi @ijuma , would you please review this small PR? Thanks. This is an automated message from the Apache Git Servi

[jira] [Commented] (KAFKA-8612) Broker removes consumers from CG, Streams app gets stuck

2020-05-05 Thread Prashant Waykar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100479#comment-17100479 ] Prashant Waykar commented on KAFKA-8612: I am seeing the same exception {noformat

[GitHub] [kafka] ijuma commented on pull request #8538: MINOR: Pass `-release 8` to scalac and upgrade to Gradle 6.4

2020-05-05 Thread GitBox
ijuma commented on pull request #8538: URL: https://github.com/apache/kafka/pull/8538#issuecomment-624440379 2 jobs passed and 1 failed with unrelated flaky failures: > kafka.api.TransactionsTest.testBumpTransactionalEpoch > org.apache.kafka.streams.integration.QueryableStateInteg

[jira] [Updated] (KAFKA-9961) Brokers may be left in an inconsistent state after reassignment

2020-05-05 Thread Dhruvil Shah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhruvil Shah updated KAFKA-9961: Description: When completing a reassignment, the controller sends StopReplicaRequest to replicas t

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r420535358 ## File path: docs/security.html ## @@ -609,7 +609,7 @@ 7.3 Authentication using SASL KafkaServer section in the JAAS file tells the broker w

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r420535358 ## File path: docs/security.html ## @@ -609,7 +609,7 @@ 7.3 Authentication using SASL KafkaServer section in the JAAS file tells the broker w

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r420535358 ## File path: docs/security.html ## @@ -609,7 +609,7 @@ 7.3 Authentication using SASL KafkaServer section in the JAAS file tells the broker w

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r420535358 ## File path: docs/security.html ## @@ -609,7 +609,7 @@ 7.3 Authentication using SASL KafkaServer section in the JAAS file tells the broker w

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r420534565 ## File path: docs/security.html ## @@ -398,7 +398,7 @@ Host Name Verification ssl.keystore.password=test1234 ssl.key.password=tes

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r420534465 ## File path: docs/security.html ## @@ -361,9 +361,9 @@ Host Name Verification The JRE/JDK will have a default pseudo-random nu

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r420534465 ## File path: docs/security.html ## @@ -361,9 +361,9 @@ Host Name Verification The JRE/JDK will have a default pseudo-random nu

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r420533735 ## File path: docs/security.html ## @@ -240,7 +240,7 @@ Host Name Verification Note: If you configure the Kafka brokers to requi

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r42050 ## File path: docs/ops.html ## @@ -477,16 +477,20 @@ Limiting Bandwidth Usage during Da Throttle was removed. The administrator can also validate t

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r420533200 ## File path: docs/ops.html ## @@ -477,16 +477,20 @@ Limiting Bandwidth Usage during Da Throttle was removed. The administrator can also validate t

[GitHub] [kafka] showuon commented on a change in pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8623: URL: https://github.com/apache/kafka/pull/8623#discussion_r420533008 ## File path: docs/ops.html ## @@ -477,16 +477,20 @@ Limiting Bandwidth Usage during Da Throttle was removed. The administrator can also validate t

[GitHub] [kafka] showuon opened a new pull request #8623: MINOR: Update the documentations

2020-05-05 Thread GitBox
showuon opened a new pull request #8623: URL: https://github.com/apache/kafka/pull/8623 1. fix broken links 2. remove redundant sentences 3. fix content format issue ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify

[GitHub] [kafka] showuon commented on a change in pull request #8622: update stream documentation

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8622: URL: https://github.com/apache/kafka/pull/8622#discussion_r420527021 ## File path: docs/streams/upgrade-guide.html ## @@ -688,7 +688,7 @@ Streams API If you are monitoring on task level or processor-node / state stor

[GitHub] [kafka] showuon commented on a change in pull request #8622: update stream documentation

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8622: URL: https://github.com/apache/kafka/pull/8622#discussion_r420526581 ## File path: docs/streams/upgrade-guide.html ## @@ -77,7 +77,7 @@ Streams API We add a new cogroup() operator (via https://cwiki.apache.org/conflu

[GitHub] [kafka] showuon commented on a change in pull request #8622: update stream documentation

2020-05-05 Thread GitBox
showuon commented on a change in pull request #8622: URL: https://github.com/apache/kafka/pull/8622#discussion_r420526237 ## File path: docs/streams/upgrade-guide.html ## @@ -35,7 +35,7 @@ Upgrade Guide and API Changes Upgrading from any older version to {{full

[GitHub] [kafka] showuon opened a new pull request #8622: update stream documentation

2020-05-05 Thread GitBox
showuon opened a new pull request #8622: URL: https://github.com/apache/kafka/pull/8622 1. fix broken links 2. rephrase a sentence 3. update the version number ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] jiameixie commented on pull request #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm

2020-05-05 Thread GitBox
jiameixie commented on pull request #8489: URL: https://github.com/apache/kafka/pull/8489#issuecomment-624422363 @cmccabe I got some failures by running "bash tests/docker/run_tests.sh" on ARM, but most of it can be run successfully after some modification, except some tests related to ver

[GitHub] [kafka] d8tltanc commented on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-05 Thread GitBox
d8tltanc commented on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624421790 I think `ClientQuotaEntity` is only used in client quota alternation. But the description doesn't use that. This

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-05-05 Thread GitBox
ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-624414054 @vvcephei Just pinging. I looked into the flakies, and it turns out they were different test failures for each build. So its the equivalent of an all green.

[GitHub] [kafka] abbccdda commented on a change in pull request #8621: KAFKA-9466: Update Kafka Streams docs for KIP-447

2020-05-05 Thread GitBox
abbccdda commented on a change in pull request #8621: URL: https://github.com/apache/kafka/pull/8621#discussion_r420514826 ## File path: docs/streams/upgrade-guide.html ## @@ -52,6 +52,20 @@ Upgrade Guide and API Changes restart all new ({{fullDotVersion}}) applicatio

[jira] [Resolved] (KAFKA-9946) KAFKA-9539/StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9946. Resolution: Fixed > KAFKA-9539/StopReplicaRequest deletePartition changes may cause prematu

[jira] [Updated] (KAFKA-9946) KAFKA-9539/StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-9946: --- Affects Version/s: (was: 2.6.0) > KAFKA-9539/StopReplicaRequest deletePartition changes m

[GitHub] [kafka] mjsax opened a new pull request #8621: KAFKA-9466: Update Kafka Streams docs for KIP-447

2020-05-05 Thread GitBox
mjsax opened a new pull request #8621: URL: https://github.com/apache/kafka/pull/8621 Call for review @abbccdda @guozhangwang This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-05 Thread GitBox
feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-624403133 @abbccdda Thanks a lot for the review, will update soon. This is an automated message from the Apache Git Servi

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-05-05 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-624399781 hi @bseenu @thspinto I updated the PR to handle both cases: (1) new consumer (2) new topic/partition in existing consumer. Please go ahead if you want to test it out sooner.

[GitHub] [kafka] jiameixie commented on pull request #8489: KAFKA-9857:Failed to build image ducker-ak-openjdk-8 on arm

2020-05-05 Thread GitBox
jiameixie commented on pull request #8489: URL: https://github.com/apache/kafka/pull/8489#issuecomment-624394985 @cmccabe I run it on arm, it works fine. This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (KAFKA-9961) Brokers may be left in an inconsistent state after reassignment

2020-05-05 Thread Dhruvil Shah (Jira)
Dhruvil Shah created KAFKA-9961: --- Summary: Brokers may be left in an inconsistent state after reassignment Key: KAFKA-9961 URL: https://issues.apache.org/jira/browse/KAFKA-9961 Project: Kafka

[jira] [Commented] (KAFKA-9957) Kafka Controller doesn't failover during hardware failure

2020-05-05 Thread Eric Ward (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100359#comment-17100359 ] Eric Ward commented on KAFKA-9957: -- We are using the default configuration (30 seconds)

[GitHub] [kafka] cmccabe edited a comment on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-05 Thread GitBox
cmccabe edited a comment on pull request #8615: URL: https://github.com/apache/kafka/pull/8615#issuecomment-624370846 Please add a junit test This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] cmccabe commented on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-05 Thread GitBox
cmccabe commented on pull request #8615: URL: https://github.com/apache/kafka/pull/8615#issuecomment-624370846 Please add a unit test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mjsax commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-05 Thread GitBox
mjsax commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-624368767 Thanks for back porting @ableegoldman! This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] mjsax commented on pull request #8603: MINOR: Fix ProcessorContext JavaDocs

2020-05-05 Thread GitBox
mjsax commented on pull request #8603: URL: https://github.com/apache/kafka/pull/8603#issuecomment-624367644 @vvcephei Updates this. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (KAFKA-9960) Metrics Reporter should support additional context tags

2020-05-05 Thread Jira
Xavier Léauté created KAFKA-9960: Summary: Metrics Reporter should support additional context tags Key: KAFKA-9960 URL: https://issues.apache.org/jira/browse/KAFKA-9960 Project: Kafka Issue T

[GitHub] [kafka] mjsax commented on a change in pull request #8603: MINOR: Fix ProcessorContext JavaDocs

2020-05-05 Thread GitBox
mjsax commented on a change in pull request #8603: URL: https://github.com/apache/kafka/pull/8603#discussion_r420463508 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -209,49 +211,52 @@ Cancellable schedule(final Duration int

[GitHub] [kafka] rhauch commented on a change in pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

2020-05-05 Thread GitBox
rhauch commented on a change in pull request #8620: URL: https://github.com/apache/kafka/pull/8620#discussion_r420464820 ## File path: checkstyle/checkstyle.xml ## @@ -132,7 +132,7 @@ - + Review comment: Why change the setting instead of

[GitHub] [kafka] mjsax commented on a change in pull request #8603: MINOR: Fix ProcessorContext JavaDocs

2020-05-05 Thread GitBox
mjsax commented on a change in pull request #8603: URL: https://github.com/apache/kafka/pull/8603#discussion_r420463508 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -209,49 +211,52 @@ Cancellable schedule(final Duration int

[GitHub] [kafka] jeffhuang26 opened a new pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

2020-05-05 Thread GitBox
jeffhuang26 opened a new pull request #8620: URL: https://github.com/apache/kafka/pull/8620 Added supporting customized HTTP Response Headers for Kafka Connect REST server. This is an automated message from the Apache Git S

[jira] [Updated] (KAFKA-9959) leastLoadedNode() does not provide a node fairly

2020-05-05 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9959: - Issue Type: Improvement (was: Bug) > leastLoadedNode() does not provide a node fairly >

[jira] [Updated] (KAFKA-9959) leastLoadedNode() does not provide a node fairly

2020-05-05 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9959: - Description: Currently, leastLoadedNode() provides a node with the following criteria: # Provide the con

[GitHub] [kafka] bbejeck commented on pull request #8619: MINOR: Improve TopologyTestDriver JavaDocs

2020-05-05 Thread GitBox
bbejeck commented on pull request #8619: URL: https://github.com/apache/kafka/pull/8619#issuecomment-624338625 only javadoc is update, so merging this. This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (KAFKA-9929) Support reverse iterator on WindowStore

2020-05-05 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100291#comment-17100291 ] Jorge Esteban Quilcate Otoya commented on KAFKA-9929: - Thanks [~guozh

[jira] [Assigned] (KAFKA-9959) leastLoadedNode() does not provide a node fairly

2020-05-05 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan reassigned KAFKA-9959: Assignee: Cheng Tan > leastLoadedNode() does not provide a node fairly > -

[jira] [Created] (KAFKA-9959) leastLoadedNode() does not provide a node fairly

2020-05-05 Thread Cheng Tan (Jira)
Cheng Tan created KAFKA-9959: Summary: leastLoadedNode() does not provide a node fairly Key: KAFKA-9959 URL: https://issues.apache.org/jira/browse/KAFKA-9959 Project: Kafka Issue Type: Bug

[GitHub] [kafka] ambroff commented on a change in pull request #4540: KAFKA-6469 Batch ISR change notifications

2020-05-05 Thread GitBox
ambroff commented on a change in pull request #4540: URL: https://github.com/apache/kafka/pull/4540#discussion_r420434068 ## File path: core/src/test/scala/integration/kafka/server/ReplicaManagerTest.scala ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ambroff commented on a change in pull request #4540: KAFKA-6469 Batch ISR change notifications

2020-05-05 Thread GitBox
ambroff commented on a change in pull request #4540: URL: https://github.com/apache/kafka/pull/4540#discussion_r420430926 ## File path: core/src/test/scala/integration/kafka/server/ReplicaManagerTest.scala ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ambroff commented on a change in pull request #4540: KAFKA-6469 Batch ISR change notifications

2020-05-05 Thread GitBox
ambroff commented on a change in pull request #4540: URL: https://github.com/apache/kafka/pull/4540#discussion_r420430926 ## File path: core/src/test/scala/integration/kafka/server/ReplicaManagerTest.scala ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ambroff commented on a change in pull request #4540: KAFKA-6469 Batch ISR change notifications

2020-05-05 Thread GitBox
ambroff commented on a change in pull request #4540: URL: https://github.com/apache/kafka/pull/4540#discussion_r420431031 ## File path: core/src/test/scala/integration/kafka/server/ReplicaManagerTest.scala ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] bdbyrne commented on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-05 Thread GitBox
bdbyrne commented on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624318905 > > Hi @bdbyrne , thanks for the comment. The link seems not working. I guess you mean this part we should replace the empty string "" by null? > > > ``` > > > private[admin]

[GitHub] [kafka] bdbyrne commented on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-05 Thread GitBox
bdbyrne commented on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624318293 > Hi @bdbyrne , thanks for the comment. The link seems not working. I guess you mean this part we should replace the empty string "" by null? > > > ``` > > private[admin]

[jira] [Updated] (KAFKA-9718) Don't log passwords for AlterConfigs requests in request logs

2020-05-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-9718: Fix Version/s: 2.5.1 > Don't log passwords for AlterConfigs requests in request logs >

[jira] [Updated] (KAFKA-9625) Unable to Describe broker configurations that have been set via IncrementalAlterConfigs

2020-05-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-9625: Fix Version/s: 2.5.1 > Unable to Describe broker configurations that have been set via > Increment

[GitHub] [kafka] cmccabe commented on pull request #8260: KAFKA-9625: Fixing IncrementalAlterConfigs with respect to Broker Configs

2020-05-05 Thread GitBox
cmccabe commented on pull request #8260: URL: https://github.com/apache/kafka/pull/8260#issuecomment-624312027 backported to 2.5.x This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] cmccabe commented on pull request #8294: KAFKA-9718; Don't log passwords for AlterConfigs in request logs

2020-05-05 Thread GitBox
cmccabe commented on pull request #8294: URL: https://github.com/apache/kafka/pull/8294#issuecomment-624309696 backported to 2.5.x This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] d8tltanc commented on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-05 Thread GitBox
d8tltanc commented on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624308593 Hi @bdbyrne , thanks for the comment. The link seems not working. I guess you mean this part we should replace the empty string "" by null? `private[admin] def entityNames(

[GitHub] [kafka] d8tltanc edited a comment on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-05 Thread GitBox
d8tltanc edited a comment on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624308593 Hi @bdbyrne , thanks for the comment. The link seems not working. I guess you mean this part we should replace the empty string "" by null? private[admin] def entity

[GitHub] [kafka] d8tltanc edited a comment on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-05 Thread GitBox
d8tltanc edited a comment on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624308593 Hi @bdbyrne , thanks for the comment. The link seems not working. I guess you mean this part we should replace the empty string "" by null? > private[admin] def

[jira] [Commented] (KAFKA-7472) Implement KIP-145 transformations

2020-05-05 Thread Loic DIVAD (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100228#comment-17100228 ] Loic DIVAD commented on KAFKA-7472: --- Thank you [~rhauch]! :) > Implement KIP-145 trans

[GitHub] [kafka] guozhangwang commented on pull request #8600: KAFKA-9928: Fix flaky GlobalKTableEOSIntegrationTest

2020-05-05 Thread GitBox
guozhangwang commented on pull request #8600: URL: https://github.com/apache/kafka/pull/8600#issuecomment-624284868 I still see the following issue locally: ``` java.lang.AssertionError: Condition not met within timeout 3. waiting for final values expected: {a=1+F, b=2+G,

[jira] [Created] (KAFKA-9958) Add a new method to AuthorizerServerInfo Interface

2020-05-05 Thread Jeff Huang (Jira)
Jeff Huang created KAFKA-9958: - Summary: Add a new method to AuthorizerServerInfo Interface Key: KAFKA-9958 URL: https://issues.apache.org/jira/browse/KAFKA-9958 Project: Kafka Issue Type: Improv

[GitHub] [kafka] vvcephei commented on a change in pull request #8603: MINOR: Fix ProcessorContext JavaDocs

2020-05-05 Thread GitBox
vvcephei commented on a change in pull request #8603: URL: https://github.com/apache/kafka/pull/8603#discussion_r420377361 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -209,49 +211,52 @@ Cancellable schedule(final Duration

[GitHub] [kafka] vvcephei commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

2020-05-05 Thread GitBox
vvcephei commented on pull request #8616: URL: https://github.com/apache/kafka/pull/8616#issuecomment-624270869 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-05 Thread GitBox
vvcephei commented on pull request #8613: URL: https://github.com/apache/kafka/pull/8613#issuecomment-624270635 Thanks @cadonna , Let's see how those tests play out. This is an automated message from the Apache Git Service. T

[GitHub] [kafka] cadonna commented on pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-05 Thread GitBox
cadonna commented on pull request #8613: URL: https://github.com/apache/kafka/pull/8613#issuecomment-624258204 Just in case, I re-run the system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3929/

[GitHub] [kafka] mjsax opened a new pull request #8619: MINOR: Improve TopologyTestDriver JavaDocs

2020-05-05 Thread GitBox
mjsax opened a new pull request #8619: URL: https://github.com/apache/kafka/pull/8619 Call for review @bbejeck This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] abbccdda commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-05 Thread GitBox
abbccdda commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r418108095 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3621,24 +3641,37 @@ public RemoveMembersFromConsumerGroupR

[GitHub] [kafka] scott-hendricks commented on pull request #8434: KAFKA-7599: Don't throttle in Trogdor when targetMessagesPerSec is 0

2020-05-05 Thread GitBox
scott-hendricks commented on pull request #8434: URL: https://github.com/apache/kafka/pull/8434#issuecomment-624246201 > `0` to mean `infinite` is a bit confusing. Maybe we can use `-1` instead? This is anything 0 or less though. I would prefer 0 because our current clients do calcu

[jira] [Commented] (KAFKA-9909) Kafka Streams : offset control to Streams API

2020-05-05 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100186#comment-17100186 ] Guozhang Wang commented on KAFKA-9909: -- I think the reason here is that you catch th

[jira] [Commented] (KAFKA-9798) Flaky test: org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldAllowConcurrentAccesses

2020-05-05 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100179#comment-17100179 ] Guozhang Wang commented on KAFKA-9798: -- This is due to a known issue which is fixed

[GitHub] [kafka] ijuma commented on pull request #8434: KAFKA-7599: Don't throttle in Trogdor when targetMessagesPerSec is 0

2020-05-05 Thread GitBox
ijuma commented on pull request #8434: URL: https://github.com/apache/kafka/pull/8434#issuecomment-624230380 `0` to mean `infinite` is a bit confusing. Maybe we can use `-1` instead? This is an automated message from the Apac

[GitHub] [kafka] hachikuji commented on a change in pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-05 Thread GitBox
hachikuji commented on a change in pull request #8609: URL: https://github.com/apache/kafka/pull/8609#discussion_r420319459 ## File path: core/src/main/scala/kafka/controller/ControllerChannelManager.scala ## @@ -550,6 +550,22 @@ abstract class AbstractControllerBrokerRequestB

[GitHub] [kafka] bdbyrne edited a comment on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-05 Thread GitBox
bdbyrne edited a comment on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624225725 So I believe the error to be here: https://github.com/apache/kafka/pull/8610/files#diff-faf8cea6a3a0fab5e056ad5fee22ff3eR369-R375 (In case the link doesn't work,

[GitHub] [kafka] bdbyrne commented on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-05 Thread GitBox
bdbyrne commented on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624225725 So I believe the error to be here: https://github.com/apache/kafka/pull/8610/files#diff-faf8cea6a3a0fab5e056ad5fee22ff3eR369-R375 It should be translating the default e

[GitHub] [kafka] hachikuji commented on pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-05 Thread GitBox
hachikuji commented on pull request #8609: URL: https://github.com/apache/kafka/pull/8609#issuecomment-62436 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-05 Thread GitBox
hachikuji commented on pull request #8609: URL: https://github.com/apache/kafka/pull/8609#issuecomment-624221761 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-05-05 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100156#comment-17100156 ] Boyang Chen commented on KAFKA-9891: [~mateuszjadczyk] Lol, no worry, thanks a lot fo

[GitHub] [kafka] vvcephei commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

2020-05-05 Thread GitBox
vvcephei commented on pull request #8616: URL: https://github.com/apache/kafka/pull/8616#issuecomment-624218152 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

2020-05-05 Thread GitBox
vvcephei commented on pull request #8616: URL: https://github.com/apache/kafka/pull/8616#issuecomment-624218222 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on a change in pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-05 Thread GitBox
vvcephei commented on a change in pull request #8613: URL: https://github.com/apache/kafka/pull/8613#discussion_r420306701 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter, current_gener

[GitHub] [kafka] vvcephei commented on pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-05 Thread GitBox
vvcephei commented on pull request #8613: URL: https://github.com/apache/kafka/pull/8613#issuecomment-624218014 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Assigned] (KAFKA-4696) Streams standby task assignment should be state-store aware

2020-05-05 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-4696: -- Fix Version/s: 2.6.0 Assignee: Sophie Blee-Goldman (was: Richard Yu)

[GitHub] [kafka] gharris1727 commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-05 Thread GitBox
gharris1727 commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420298081 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -193,13 +194,11 @@ public void transitionTo(Targ

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-05-05 Thread Mateusz Jadczyk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100135#comment-17100135 ] Mateusz Jadczyk commented on KAFKA-9891: I don't think I have enough knowledge to

[GitHub] [kafka] vvcephei commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

2020-05-05 Thread GitBox
vvcephei commented on pull request #8616: URL: https://github.com/apache/kafka/pull/8616#issuecomment-624208471 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] ncliang commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-05 Thread GitBox
ncliang commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420288853 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -193,13 +194,11 @@ public void transitionTo(TargetSt

[GitHub] [kafka] mjsax commented on pull request #8600: KAFKA-9928: Fix flaky GlobalKTableEOSIntegrationTest

2020-05-05 Thread GitBox
mjsax commented on pull request #8600: URL: https://github.com/apache/kafka/pull/8600#issuecomment-624199715 Java 14 passed. Java 8: ``` org.apache.kafka.streams.integration.EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once] org.apache.kafka.streams.int

[jira] [Commented] (KAFKA-9949) Flaky Test GlobalKTableIntegrationTest#shouldKStreamGlobalKTableLeftJoin

2020-05-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100110#comment-17100110 ] Matthias J. Sax commented on KAFKA-9949: [https://builds.apache.org/job/kafka-pr-

[jira] [Comment Edited] (KAFKA-9798) Flaky test: org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldAllowConcurrentAccesses

2020-05-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100107#comment-17100107 ] Matthias J. Sax edited comment on KAFKA-9798 at 5/5/20, 5:31 PM: --

[jira] [Commented] (KAFKA-9831) Failing test: EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once_beta]

2020-05-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100108#comment-17100108 ] Matthias J. Sax commented on KAFKA-9831: [https://builds.apache.org/job/kafka-pr-

[jira] [Commented] (KAFKA-9798) Flaky test: org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldAllowConcurrentAccesses

2020-05-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100107#comment-17100107 ] Matthias J. Sax commented on KAFKA-9798: Failed again:  [https://builds.apache.or

[GitHub] [kafka] gharris1727 commented on pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-05 Thread GitBox
gharris1727 commented on pull request #8618: URL: https://github.com/apache/kafka/pull/8618#issuecomment-624196656 @rhauch @kkonstantine This is ready for committer review. Thanks for taking a look! This is an automated mess

[GitHub] [kafka] tombentley commented on pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-05-05 Thread GitBox
tombentley commented on pull request #8311: URL: https://github.com/apache/kafka/pull/8311#issuecomment-624187386 @dajac sure. I added tests for the create and delete topics cases too. This is an automated message from the Ap

  1   2   >