vvcephei commented on a change in pull request #8613:
URL: https://github.com/apache/kafka/pull/8613#discussion_r420306701



##########
File path: tests/kafkatest/tests/streams/streams_upgrade_test.py
##########
@@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter, 
current_generation):
                         log_monitor.wait_until("Sent a version 8 subscription 
and got version 7 assignment back (successful version probing). Downgrade 
subscription metadata to commonly supported version 7 and trigger new 
rebalance.",
                                                timeout_sec=60,
                                                err_msg="Could not detect 
'successful version probing' at upgrading node " + str(node.account))
-                    else:
-                        log_monitor.wait_until("Sent a version 8 subscription 
and got version 7 assignment back (successful version probing). Downgrade 
subscription metadata to commonly supported version 8 and trigger new 
rebalance.",
+                        log_monitor.wait_until("Detected that the assignor 
requested a rebalance. Rejoining the consumer group to trigger a new 
rebalance.",

Review comment:
       Thanks, all. This doesn't seem like the best way to verify what we're 
trying to verify, but it also seems about the same as before. I'm happy to 
leave this here for now.
   
   If/when the test breaks again, I'd prefer for us to put in a more reliable 
and direct mechanism.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to