[GitHub] [kafka] vvcephei commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
vvcephei commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441170578 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -235,7 +235,7 @@ public StateStore getSta

[jira] [Commented] (KAFKA-10151) Flaky Test StoreUpgradeIntegrationTest.shouldMigratePersistentKeyValueStoreToTimestampedKeyValueStoreUsingPapi

2020-06-16 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137956#comment-17137956 ] Sophie Blee-Goldman commented on KAFKA-10151: - Go for it. For some context,

[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441171975 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -235,7 +235,7 @@ public StateStore ge

[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441172228 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -160,18 +162,21 @@ public void postCommit() {

[GitHub] [kafka] vvcephei commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
vvcephei commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441169327 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -160,18 +162,21 @@ public void postCommit() {

[GitHub] [kafka] vvcephei commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
vvcephei commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441169062 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -235,7 +235,7 @@ public StateStore getSta

[GitHub] [kafka] vvcephei commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
vvcephei commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441169628 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -675,27 +670,6 @@ public static voi

[GitHub] [kafka] ableegoldman commented on pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-16 Thread GitBox
ableegoldman commented on pull request #8853: URL: https://github.com/apache/kafka/pull/8853#issuecomment-645040934 @rhauch is this ready to be merged? This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] ableegoldman commented on a change in pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
ableegoldman commented on a change in pull request #8882: URL: https://github.com/apache/kafka/pull/8882#discussion_r441175266 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java ## @@ -366,6 +369,37 @@ public void shouldThrowO

[GitHub] [kafka] ableegoldman commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-16 Thread GitBox
ableegoldman commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-645043278 Failures were all due to known-flaky/completely broken `ReassignPartitionsUnitTest.testModifyBrokerThrottles` (PR for that test is still waiting to be merged -- https://issue

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-16 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r441177055 ## File path: core/src/main/scala/kafka/server/DelayedOperation.scala ## @@ -100,40 +99,27 @@ abstract class DelayedOperation(override val delayMs: Long,

[GitHub] [kafka] mumrah commented on pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-16 Thread GitBox
mumrah commented on pull request #8841: URL: https://github.com/apache/kafka/pull/8841#issuecomment-645054474 Ran client system tests here, all passing except for one which looks flaky http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-06-16--0

[GitHub] [kafka] guozhangwang merged pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-16 Thread GitBox
guozhangwang merged pull request #8856: URL: https://github.com/apache/kafka/pull/8856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-16 Thread GitBox
guozhangwang commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-645062759 Cherry-picked to 2.6. This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Created] (KAFKA-10177) Replace/improve/remove Percentiles metric

2020-06-16 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10177: --- Summary: Replace/improve/remove Percentiles metric Key: KAFKA-10177 URL: https://issues.apache.org/jira/browse/KAFKA-10177 Project: Kafka Issue

[GitHub] [kafka] mjsax commented on pull request #8871: MINOR: code cleanup for inconsistent naming

2020-06-16 Thread GitBox
mjsax commented on pull request #8871: URL: https://github.com/apache/kafka/pull/8871#issuecomment-645090904 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] guozhangwang commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset 【WIP】

2020-06-16 Thread GitBox
guozhangwang commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r441229437 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -273,13 +273,13 @@ public boolean isRunning()

[GitHub] [kafka] ableegoldman commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-16 Thread GitBox
ableegoldman commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-645097409 Rebased on trunk and removed the TaskManager MethodLength suppression as well (yay 🥳 ), can you kick off tests again @mjsax ? ---

[GitHub] [kafka] abbccdda commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-16 Thread GitBox
abbccdda commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r441237199 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -564,8 +576,15 @@ private void restoreCha

[jira] [Commented] (KAFKA-10176) kafka-topics command requires --zookeeper for --alter --topic --config

2020-06-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138037#comment-17138037 ] Luke Chen commented on KAFKA-10176: --- hi [~psmolinski] , I think it is the issue in con

[GitHub] [kafka] mjsax commented on pull request #8883: KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest

2020-06-16 Thread GitBox
mjsax commented on pull request #8883: URL: https://github.com/apache/kafka/pull/8883#issuecomment-645113722 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8883: KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest

2020-06-16 Thread GitBox
mjsax commented on pull request #8883: URL: https://github.com/apache/kafka/pull/8883#issuecomment-645113814 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-16 Thread GitBox
mjsax commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r441249511 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -564,8 +576,15 @@ private void restoreChange

[GitHub] [kafka] mjsax commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-16 Thread GitBox
mjsax commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r441249855 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -564,8 +574,16 @@ private void restoreChange

[GitHub] [kafka] mjsax commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-16 Thread GitBox
mjsax commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r441252009 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -564,8 +576,15 @@ private void restoreChange

[GitHub] [kafka] mjsax commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-16 Thread GitBox
mjsax commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r441252894 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -564,8 +574,16 @@ private void restoreChange

[jira] [Assigned] (KAFKA-8264) Flaky Test PlaintextConsumerTest#testLowMaxFetchSizeForRequestAndPartition

2020-06-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-8264: Assignee: Luke Chen > Flaky Test PlaintextConsumerTest#testLowMaxFetchSizeForRequestAndPartition >

[GitHub] [kafka] showuon opened a new pull request #8885: KAFKA-8264: decrease the record size for flaky test

2020-06-16 Thread GitBox
showuon opened a new pull request #8885: URL: https://github.com/apache/kafka/pull/8885 This flaky test exists for a long time, and it happened more frequently recently. In KAFKA-8264 and KAFKA-8460, it described the issue for this test is that > Timed out before consuming expected 270

[jira] [Updated] (KAFKA-5636) Add Sliding-Window support for Aggregations

2020-06-16 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-5636: --- Labels: needs-kip (was: ) > Add Sliding-Window support for Aggregations > --

[jira] [Updated] (KAFKA-5636) Add Sliding-Window support for Aggregations

2020-06-16 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-5636: --- Priority: Major (was: Minor) > Add Sliding-Window support for Aggregations > ---

[jira] [Assigned] (KAFKA-8460) Flaky Test PlaintextConsumerTest#testLowMaxFetchSizeForRequestAndPartition

2020-06-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-8460: Assignee: Luke Chen > Flaky Test PlaintextConsumerTest#testLowMaxFetchSizeForRequestAndPartition

[GitHub] [kafka] vvcephei commented on pull request #8882: KAFKA-10165: Remove Percentiles from e2e metrics

2020-06-16 Thread GitBox
vvcephei commented on pull request #8882: URL: https://github.com/apache/kafka/pull/8882#issuecomment-645126850 Rebased on trunk. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] showuon commented on pull request #8885: KAFKA-8264: decrease the record size for flaky test

2020-06-16 Thread GitBox
showuon commented on pull request #8885: URL: https://github.com/apache/kafka/pull/8885#issuecomment-645126965 @nepal @mjsax @abbccdda , could you review this PR to fix flaky test? Thanks. This is an automated message from

[jira] [Commented] (KAFKA-10160) Kafka MM2 consumer configuration

2020-06-16 Thread sats (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138068#comment-17138068 ] sats commented on KAFKA-10160: -- Yes, It is hard-coded [here|[https://github.com/apache/kaf

[jira] [Comment Edited] (KAFKA-10160) Kafka MM2 consumer configuration

2020-06-16 Thread sats (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138068#comment-17138068 ] sats edited comment on KAFKA-10160 at 6/17/20, 3:36 AM: Yes, It

[jira] [Assigned] (KAFKA-8672) RebalanceSourceConnectorsIntegrationTest#testReconfigConnector

2020-06-16 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis reassigned KAFKA-8672: - Assignee: Konstantine Karantasis > RebalanceSourceConnectorsIntegrationT

[jira] [Resolved] (KAFKA-8672) RebalanceSourceConnectorsIntegrationTest#testReconfigConnector

2020-06-16 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-8672. --- Resolution: Fixed The tests have been fixed and reenabled with  [https://git

[jira] [Updated] (KAFKA-8672) RebalanceSourceConnectorsIntegrationTest#testReconfigConnector

2020-06-16 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-8672: -- Fix Version/s: 2.5.1 2.4.2 2.6.0

[jira] [Resolved] (KAFKA-8864) Kafka Producer deadlocked on flush call

2020-06-16 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-8864. Resolution: Duplicate Given the version, it looks like a duplicate of KAFKA-7709. > Kafka Producer

[jira] [Assigned] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-06-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9891: -- Assignee: Matthias J. Sax (was: Boyang Chen) > Invalid state store content after task

[GitHub] [kafka] mjsax opened a new pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

2020-06-16 Thread GitBox
mjsax opened a new pull request #8886: URL: https://github.com/apache/kafka/pull/8886 A StandbyTask must wipe its local state if EOS is enabled and no local checkpoint file is found. I left debug statement in on purpose to people can verify the test locally if they want. - whe

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-06-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138091#comment-17138091 ] Matthias J. Sax commented on KAFKA-9891: [~mateuszjadczyk] [~bchen225242]: I thin

[jira] [Commented] (KAFKA-10072) Kafkaconsumer is configured with different clientid parameters to obtain different results

2020-06-16 Thread sats (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138103#comment-17138103 ] sats commented on KAFKA-10072: -- [~qq619618919], kafka-console-consumer.sh --consumer-prope

[jira] [Commented] (KAFKA-9194) Missing documentation for replicaMaxWaitTimeMs config value

2020-06-16 Thread sats (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138106#comment-17138106 ] sats commented on KAFKA-9194: - [~tomasz.szlek], Its been a long time, looks the doc is not fi

[jira] [Commented] (KAFKA-9220) TimeoutException when using kafka-preferred-replica-election

2020-06-16 Thread sats (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138112#comment-17138112 ] sats commented on KAFKA-9220: - Yes for 'bin/kafka-leader-election.sh' this can be taken as a

[jira] [Comment Edited] (KAFKA-9220) TimeoutException when using kafka-preferred-replica-election

2020-06-16 Thread sats (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138112#comment-17138112 ] sats edited comment on KAFKA-9220 at 6/17/20, 5:23 AM: --- Yes for 'bi

[GitHub] [kafka] satishbellapu commented on pull request #8877: KAFKA-9194: Missing documentation for replicaMaxWaitTimeMs config value

2020-06-16 Thread GitBox
satishbellapu commented on pull request #8877: URL: https://github.com/apache/kafka/pull/8877#issuecomment-645159729 @mjsax can this be merged to trunk ? or need PR for any specific release ? This is an automated message from

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-16 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r441289689 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala ## @@ -307,8 +307,14 @@ class GroupCoordinatorConcurr

[GitHub] [kafka] kkonstantine commented on pull request #8859: MINOR: Upgrading jersey and jetty versions

2020-06-16 Thread GitBox
kkonstantine commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-645162774 Tests ran but didn't show up here. https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2984/ `org.apache.kafka.streams.integration.StoreUpgradeIntegrationTest.shouldM

[jira] [Commented] (KAFKA-10151) Flaky Test StoreUpgradeIntegrationTest.shouldMigratePersistentKeyValueStoreToTimestampedKeyValueStoreUsingPapi

2020-06-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138129#comment-17138129 ] Chia-Ping Tsai commented on KAFKA-10151: [~ableegoldman] I feel you have resolve

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-06-16 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138130#comment-17138130 ] jiamei xie commented on KAFKA-10136: [~chia7712] Hi, should a KIP be created for thi

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-06-16 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138150#comment-17138150 ] jiamei xie commented on KAFKA-10136: [~chia7712] ConsumerPerformance for Kafka 0.9.0

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-06-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138153#comment-17138153 ] Chia-Ping Tsai commented on KAFKA-10136: {quote} should a KIP be created for thi

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-06-16 Thread William Bottrell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136395#comment-17136395 ] William Bottrell commented on KAFKA-10062: -- [~mjsax] yes, this helps, thank you

[jira] [Commented] (KAFKA-9220) TimeoutException when using kafka-preferred-replica-election

2020-06-16 Thread sats (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136402#comment-17136402 ] sats commented on KAFKA-9220: - This requires KIP. The tool "kafka-preferred-replica-election

[GitHub] [kafka] tombentley commented on pull request #8839: MINOR: Documentation for KIP-585

2020-06-16 Thread GitBox
tombentley commented on pull request #8839: URL: https://github.com/apache/kafka/pull/8839#issuecomment-644606253 Thanks @kkonstantine! This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-06-16 Thread Piotr Smolinski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136432#comment-17136432 ] Piotr Smolinski commented on KAFKA-10062: - The motivation is to use the same sou

[GitHub] [kafka] dajac commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-06-16 Thread GitBox
dajac commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r440142597 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -302,21 +312,295 @@ class ConnectionQuotasTest { } // all

[GitHub] [kafka] dajac commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-16 Thread GitBox
dajac commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r440658796 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -678,7 +696,11 @@ public Node leastLoadedNode(long now) { }

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-06-16 Thread Piotr Smolinski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136446#comment-17136446 ] Piotr Smolinski commented on KAFKA-10062: - BTW, the SystemTime class might also

[jira] [Created] (KAFKA-10171) SslTransportLayerTest.testServerCipherDynamicUpdate failed for tlsv1.3

2020-06-16 Thread Wang Ge (Jira)
Wang Ge created KAFKA-10171: --- Summary: SslTransportLayerTest.testServerCipherDynamicUpdate failed for tlsv1.3 Key: KAFKA-10171 URL: https://issues.apache.org/jira/browse/KAFKA-10171 Project: Kafka

[jira] [Created] (KAFKA-10172) [Kafka connect] connectors, tasks metrics doubled

2020-06-16 Thread Viktor Utkin (Jira)
Viktor Utkin created KAFKA-10172: Summary: [Kafka connect] connectors, tasks metrics doubled Key: KAFKA-10172 URL: https://issues.apache.org/jira/browse/KAFKA-10172 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-10172) [Kafka connect] connectors, tasks metrics doubled

2020-06-16 Thread Viktor Utkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Utkin updated KAFKA-10172: - Description: After re-balance of connect cluster (4 nodes in total) we noticed that metrics * k

[jira] [Commented] (KAFKA-9332) change how to get joinGroupTimeoutMs

2020-06-16 Thread qianrui (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136585#comment-17136585 ] qianrui commented on KAFKA-9332: This problem has been solved > change how to get joinGr

[jira] [Commented] (KAFKA-9332) change how to get joinGroupTimeoutMs

2020-06-16 Thread qianrui (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136586#comment-17136586 ] qianrui commented on KAFKA-9332: [This problem has been solved  https://github.com/apach

[GitHub] [kafka] cadonna commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset 【WIP】

2020-06-16 Thread GitBox
cadonna commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r440801026 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -369,6 +369,7 @@ public static StreamThread create

[GitHub] [kafka] tombentley opened a new pull request #8878: MINOR: Generator config-specific HTML ids

2020-06-16 Thread GitBox
tombentley opened a new pull request #8878: URL: https://github.com/apache/kafka/pull/8878 Currently the docs have HTML ids for each config key. That doesn't work correctly for config keys like bootstrap.servers which occur across producer, consumer, admin configs: We generate duplicat

[GitHub] [kafka] tombentley commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-06-16 Thread GitBox
tombentley commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-644772529 @mimaison I know you added the per-config-key anchors. Please could you take a look at attempt to disambiguate the current situation with duplicated ids. -

[jira] [Created] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-16 Thread Karsten Schnitter (Jira)
Karsten Schnitter created KAFKA-10173: - Summary: BufferUnderflowException during Kafka Streams Upgrade Key: KAFKA-10173 URL: https://issues.apache.org/jira/browse/KAFKA-10173 Project: Kafka

[GitHub] [kafka] abbccdda commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset 【WIP】

2020-06-16 Thread GitBox
abbccdda commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r440545343 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -199,12 +204,19 @@ int bufferedLimitIndex

[GitHub] [kafka] guozhangwang commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset 【WIP】

2020-06-16 Thread GitBox
guozhangwang commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r440941715 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -369,6 +369,7 @@ public static StreamThread c

[jira] [Updated] (KAFKA-10171) SslTransportLayerTest.testServerCipherDynamicUpdate failed for tlsv1.3

2020-06-16 Thread Wang Ge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wang Ge updated KAFKA-10171: Description: (was: `SslTransportLayerTest.testServerCipherDynamicUpdate` in ce-kafka is failing for `

[jira] [Updated] (KAFKA-10171) Please ignore

2020-06-16 Thread Wang Ge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wang Ge updated KAFKA-10171: Summary: Please ignore (was: SslTransportLayerTest.testServerCipherDynamicUpdate failed for tlsv1.3) > P

[jira] [Resolved] (KAFKA-10171) Please ignore

2020-06-16 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-10171. --- Resolution: Invalid > Please ignore > - > > Key: KAFKA-10171 >

[jira] [Commented] (KAFKA-8770) Either switch to or add an option for emit-on-change

2020-06-16 Thread Richard Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136786#comment-17136786 ] Richard Yu commented on KAFKA-8770: --- [~gyammine] Thanks for the comment! I apologize fo

[jira] [Comment Edited] (KAFKA-8770) Either switch to or add an option for emit-on-change

2020-06-16 Thread Richard Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136786#comment-17136786 ] Richard Yu edited comment on KAFKA-8770 at 6/16/20, 4:25 PM: -

[jira] [Commented] (KAFKA-9220) TimeoutException when using kafka-preferred-replica-election

2020-06-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136787#comment-17136787 ] Matthias J. Sax commented on KAFKA-9220: I am not familiar with the details. Howe

[GitHub] [kafka] andrewegel opened a new pull request #8879: MINOR: Upgrade ducktape to 0.7.8

2020-06-16 Thread GitBox
andrewegel opened a new pull request #8879: URL: https://github.com/apache/kafka/pull/8879 Newer version of ducktape that updates some dependencies and adds some features. You can see that diff here: https://github.com/confluentinc/ducktape/compare/v0.7.7...v0.7.8 -

[GitHub] [kafka] hachikuji commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-16 Thread GitBox
hachikuji commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r440984705 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -675,36 +676,41 @@ private ListOffsetResult fetchOffs

[jira] [Updated] (KAFKA-10131) Minimize use of --zookeeper flag in ducktape tests

2020-06-16 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated KAFKA-10131: --- Description: Get the ducktape tests working without the --zookeeper flag (except for scram).

[jira] [Updated] (KAFKA-10131) Minimize use of --zookeeper flag in ducktape tests

2020-06-16 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated KAFKA-10131: --- Description: Get the ducktape tests working without the --zookeeper flag (except for scram).

[jira] [Commented] (KAFKA-10151) Flaky Test StoreUpgradeIntegrationTest.shouldMigratePersistentKeyValueStoreToTimestampedKeyValueStoreUsingPapi

2020-06-16 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136822#comment-17136822 ] Sophie Blee-Goldman commented on KAFKA-10151: - [https://builds.apache.org/jo

[jira] [Created] (KAFKA-10174) Prefer --bootstrap-server ducktape tests using kafka_configs.sh

2020-06-16 Thread Vinoth Chandar (Jira)
Vinoth Chandar created KAFKA-10174: -- Summary: Prefer --bootstrap-server ducktape tests using kafka_configs.sh Key: KAFKA-10174 URL: https://issues.apache.org/jira/browse/KAFKA-10174 Project: Kafka

[GitHub] [kafka] mumrah commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-16 Thread GitBox
mumrah commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r441007131 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -675,36 +676,41 @@ private ListOffsetResult fetchOffsets

[GitHub] [kafka] guozhangwang opened a new pull request #8880: KAFKA-10169: Error message when transit to Aborting / AbortableError / FatalError

2020-06-16 Thread GitBox
guozhangwang opened a new pull request #8880: URL: https://github.com/apache/kafka/pull/8880 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrad

[GitHub] [kafka] ConcurrencyPractitioner opened a new pull request #8881: KIP-557: Add emit on change support to Kafka Streams

2020-06-16 Thread GitBox
ConcurrencyPractitioner opened a new pull request #8881: URL: https://github.com/apache/kafka/pull/8881 This is a continuation of the previous PR #8254, and will move to implement emit on change support more extensively and cover most basic KTable operations. -

[GitHub] [kafka] guozhangwang commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-16 Thread GitBox
guozhangwang commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-644897139 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-16 Thread GitBox
guozhangwang commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-644897444 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

2020-06-16 Thread GitBox
guozhangwang commented on pull request #8646: URL: https://github.com/apache/kafka/pull/8646#issuecomment-644902264 Cherry-picked to 2.6. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] guozhangwang merged pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

2020-06-16 Thread GitBox
guozhangwang merged pull request #8646: URL: https://github.com/apache/kafka/pull/8646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-16 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10173: - Priority: Blocker (was: Major) > BufferUnderflowException during Kafka Streams Upgrade > --

[jira] [Updated] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-16 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10173: - Fix Version/s: 2.5.1 > BufferUnderflowException during Kafka Streams Upgrade > -

[jira] [Closed] (KAFKA-10171) Please ignore

2020-06-16 Thread Wang Ge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wang Ge closed KAFKA-10171. --- > Please ignore > - > > Key: KAFKA-10171 > URL: https://issues.apach

[jira] [Commented] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-16 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137089#comment-17137089 ] John Roesler commented on KAFKA-10173: -- Thanks for the report [~karsten.schnitter]

[GitHub] [kafka] guozhangwang merged pull request #8880: KAFKA-10169: Error message when transit to Aborting / AbortableError / FatalError

2020-06-16 Thread GitBox
guozhangwang merged pull request #8880: URL: https://github.com/apache/kafka/pull/8880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8881: KIP-557: Add emit on change support to Kafka Streams

2020-06-16 Thread GitBox
ConcurrencyPractitioner commented on pull request #8881: URL: https://github.com/apache/kafka/pull/8881#issuecomment-644904629 @vvcephei Just wanted to get your opinion on this. When adding emit-on-change support to ```KTableFilter```, I found that the old value was already available for u

[GitHub] [kafka] guozhangwang commented on pull request #8880: KAFKA-10169: Error message when transit to Aborting / AbortableError / FatalError

2020-06-16 Thread GitBox
guozhangwang commented on pull request #8880: URL: https://github.com/apache/kafka/pull/8880#issuecomment-644905498 Cherry-picked to 2.6. This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Assigned] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-16 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-10173: Assignee: John Roesler > BufferUnderflowException during Kafka Streams Upgrade >

[GitHub] [kafka] guozhangwang commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-16 Thread GitBox
guozhangwang commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r441026485 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -502,56 +494,24 @@ public void closeAndRecycleS

[jira] [Created] (KAFKA-10175) MetadataCache::getCluster returns null for offline replicas

2020-06-16 Thread Vikas Singh (Jira)
Vikas Singh created KAFKA-10175: --- Summary: MetadataCache::getCluster returns null for offline replicas Key: KAFKA-10175 URL: https://issues.apache.org/jira/browse/KAFKA-10175 Project: Kafka Is

  1   2   >