[GitHub] [kafka] highluck commented on pull request #8022: KAFKA 8382: Add TimestampedSessionStore

highluck commented on pull request #8022: URL: https://github.com/apache/kafka/pull/8022#issuecomment-647920759 @mjsax Let me know when you need it. thank you! This is an automated message from the Apache Git

[GitHub] [kafka] highluck commented on pull request #8912: KIP-446: Add changelog topic configuration to KTable suppress

highluck commented on pull request #8912: URL: https://github.com/apache/kafka/pull/8912#issuecomment-647920524 @mjsax Should I do it like this way? thank you! This is an automated message from the Apache Git Service.

[GitHub] [kafka] highluck opened a new pull request #8912: KIP-446: Add changelog topic configuration to KTable suppress

highluck opened a new pull request #8912: URL: https://github.com/apache/kafka/pull/8912 add KIP-446: Add changelog topic configuration to KTable suppress docs ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] kkonstantine commented on a change in pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

kkonstantine commented on a change in pull request #8604: URL: https://github.com/apache/kafka/pull/8604#discussion_r443970569 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -560,16 +561,15 @@ class LoggingMessageFormatter extends MessageFormatter

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443970898 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoff.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] kkonstantine commented on pull request #8894: KAFKA-9509: increase consume timeout to fix flaky test

kkonstantine commented on pull request #8894: URL: https://github.com/apache/kafka/pull/8894#issuecomment-647914019 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abbccdda commented on pull request #8901: MINOR: correct the doc of transaction.timeout.ms

abbccdda commented on pull request #8901: URL: https://github.com/apache/kafka/pull/8901#issuecomment-647905764 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] abbccdda commented on pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

abbccdda commented on pull request #8832: URL: https://github.com/apache/kafka/pull/8832#issuecomment-647905475 @feyman2016 Do you think we could have a fix for that? https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/metrics/ClassFanOutComplexityCheck.html

[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

abbccdda commented on pull request #8845: URL: https://github.com/apache/kafka/pull/8845#issuecomment-647904275 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

abbccdda commented on pull request #8845: URL: https://github.com/apache/kafka/pull/8845#issuecomment-647904244 Only one flaky test failed: ``` kafka.api.PlaintextAdminIntegrationTest.testConsumerGroups ``` This is

[GitHub] [kafka] abbccdda commented on pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

abbccdda commented on pull request #8585: URL: https://github.com/apache/kafka/pull/8585#issuecomment-647902462 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] highluck commented on pull request #8029: KAFKA-8147: Add changelog topic configuration to KTable suppress

highluck commented on pull request #8029: URL: https://github.com/apache/kafka/pull/8029#issuecomment-647899238 @mjsax thank you for comment!! This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest

[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142617#comment-17142617 ] Chia-Ping Tsai commented on KAFKA-10191: sorry for delayed response {quote} call

[jira] [Commented] (KAFKA-10068) Verify HighAvailabilityTaskAssignor performance with large clusters and topologies

[ https://issues.apache.org/jira/browse/KAFKA-10068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142613#comment-17142613 ] Sophie Blee-Goldman commented on KAFKA-10068: - Hey [~vvcephei], WDYT about demoting this now

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443950906 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -474,6 +492,7 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443950646 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java ## @@ -359,7 +359,9 @@ public void

[jira] [Updated] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] William Reynolds updated KAFKA-10105: - Environment: Kafka 2.4.1 on jre 11 on debian 9 in docker (was: Kafka 1.1.0 on jre 8 on

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142608#comment-17142608 ] William Reynolds commented on KAFKA-10105: -- [~gokul2411s]the reference to 1.1.0 was due to that

[GitHub] [kafka] showuon commented on pull request #8894: KAFKA-9509: increase consume timeout to fix flaky test

showuon commented on pull request #8894: URL: https://github.com/apache/kafka/pull/8894#issuecomment-647888991 Hi @ryannedolan @skaundinya15 , do you have any other comments? I think we should merge this PR soon since the tests fails today's test again. Thanks.

[jira] [Commented] (KAFKA-9509) Fix flaky test MirrorConnectorsIntegrationTest.testReplication

[ https://issues.apache.org/jira/browse/KAFKA-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142596#comment-17142596 ] Luke Chen commented on KAFKA-9509: --

[jira] [Assigned] (KAFKA-4996) Fix findbugs multithreaded correctness warnings for streams

[ https://issues.apache.org/jira/browse/KAFKA-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-4996: -- Assignee: Sophie Blee-Goldman > Fix findbugs multithreaded correctness

[jira] [Comment Edited] (KAFKA-4996) Fix findbugs multithreaded correctness warnings for streams

[ https://issues.apache.org/jira/browse/KAFKA-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142592#comment-17142592 ] Sophie Blee-Goldman edited comment on KAFKA-4996 at 6/23/20, 3:32 AM:

[jira] [Commented] (KAFKA-4996) Fix findbugs multithreaded correctness warnings for streams

[ https://issues.apache.org/jira/browse/KAFKA-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142592#comment-17142592 ] Sophie Blee-Goldman commented on KAFKA-4996: Took a quick look at removing the spotBugs rule

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-647885294 hi @abbccdda @ableegoldman , sorry, but this PR stays for a while, do you have other comments? Or should I find someone else to review? Thanks.

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443938725 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] michael-carter-instaclustr commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

michael-carter-instaclustr commented on a change in pull request #8844: URL: https://github.com/apache/kafka/pull/8844#discussion_r443935161 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -56,7 +56,7 @@ private static

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443935192 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -88,6 +88,8 @@ object Defaults { val MaxConnections: Int = Int.MaxValue val

[jira] [Commented] (KAFKA-8416) Improve Documentation for Enabling Optimizations

[ https://issues.apache.org/jira/browse/KAFKA-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142577#comment-17142577 ] Sophie Blee-Goldman commented on KAFKA-8416: Hey [~bbejeck], I saw that this is [documented

[jira] [Updated] (KAFKA-8416) Improve Documentation for Enabling Optimizations

[ https://issues.apache.org/jira/browse/KAFKA-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-8416: --- Labels: newbie (was: newbie,) > Improve Documentation for Enabling Optimizations >

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142578#comment-17142578 ] jiamei xie commented on KAFKA-10136: [~chia7712] Ok, thanks very much > Make option threads of

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443934101 ## File path: core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala ## @@ -205,6 +205,8 @@ object BrokerApiVersionsCommand { private object

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443933957 ## File path: clients/src/test/java/org/apache/kafka/common/utils/ExponentialBackoffTest.java ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] feyman2016 edited a comment on pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

feyman2016 edited a comment on pull request #8832: URL: https://github.com/apache/kafka/pull/8832#issuecomment-647876499 ``` [ant:checkstyle] [ERROR]

[GitHub] [kafka] feyman2016 commented on pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

feyman2016 commented on pull request #8832: URL: https://github.com/apache/kafka/pull/8832#issuecomment-647876499 ``` [ant:checkstyle] [ERROR]

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142569#comment-17142569 ] Chia-Ping Tsai commented on KAFKA-10136: > and no one response to this. Is there something

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142565#comment-17142565 ] Chia-Ping Tsai commented on KAFKA-10136: [~adally] Please post you KIP to 

[jira] [Updated] (KAFKA-10191) fix flaky StreamsOptimizedTest

[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10191: Fix Version/s: (was: 2.6.0) > fix flaky StreamsOptimizedTest >

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest

[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142567#comment-17142567 ] Sophie Blee-Goldman commented on KAFKA-10191: - Awesome! That said, I want to qualify my

[jira] [Updated] (KAFKA-10191) fix flaky StreamsOptimizedTest

[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10191: Priority: Major (was: Blocker) > fix flaky StreamsOptimizedTest >

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest

[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142542#comment-17142542 ] Chia-Ping Tsai commented on KAFKA-10191:   {quote}Did you want to submit a fix for this 

[jira] [Commented] (KAFKA-10136) Make option threads of ConsumerPerformance work

[ https://issues.apache.org/jira/browse/KAFKA-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142534#comment-17142534 ] jiamei xie commented on KAFKA-10136: [~chia7712] Hi, I have written a [KIP

[GitHub] [kafka] feyman2016 commented on pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

feyman2016 commented on pull request #8887: URL: https://github.com/apache/kafka/pull/8887#issuecomment-647856516 @abbccdda @mjsax Thanks a lot! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443891445 ## File path: clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java ## @@ -321,4 +325,37 @@ public void

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443903361 ## File path: clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java ## @@ -321,4 +325,37 @@ public void

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443903133 ## File path: clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java ## @@ -321,4 +325,37 @@ public void

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443891445 ## File path: clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java ## @@ -321,4 +325,37 @@ public void

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443890115 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoff.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443888648 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoff.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443877830 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443875108 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443875108 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] guozhangwang commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

guozhangwang commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443873843 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142478#comment-17142478 ] Sophie Blee-Goldman commented on KAFKA-10105: - It's possible. If you're able to reproduce

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443871959 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -542,7 +542,12 @@ private void close(final boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443871712 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] abbccdda commented on pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

abbccdda commented on pull request #8832: URL: https://github.com/apache/kafka/pull/8832#issuecomment-647809159 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abbccdda merged pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

abbccdda merged pull request #8887: URL: https://github.com/apache/kafka/pull/8887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142467#comment-17142467 ] Gokul Ramanan Subramanian commented on KAFKA-10105: --- [~ableegoldman] could this issue

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443864310 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[jira] [Commented] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142460#comment-17142460 ] John Roesler commented on KAFKA-10173: -- Wow, thanks for that great information,

[jira] [Updated] (KAFKA-10193) Add preemption for controller events that have callbacks

[ https://issues.apache.org/jira/browse/KAFKA-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10193: - Summary: Add preemption for controller events that have callbacks (was: Add preemption for

[jira] [Commented] (KAFKA-10055) Add shared internal utility class for Streams module

[ https://issues.apache.org/jira/browse/KAFKA-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142451#comment-17142451 ] Vito Jeng commented on KAFKA-10055: --- [~bchen225242] Got it. > Add shared internal utility class for

[jira] [Created] (KAFKA-10193) Add preemption for ControllerEvent that have callbacks

Jeff Kim created KAFKA-10193: Summary: Add preemption for ControllerEvent that have callbacks Key: KAFKA-10193 URL: https://issues.apache.org/jira/browse/KAFKA-10193 Project: Kafka Issue Type:

[GitHub] [kafka] abbccdda commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

abbccdda commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443855731 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -250,10 +250,26 @@ public void flush() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443855976 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -203,6 +208,34 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443854750 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -203,6 +208,34 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443854106 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -203,6 +208,34 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443852676 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443852154 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443851041 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -542,7 +542,12 @@ private void close(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443850536 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void

[GitHub] [kafka] guozhangwang commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

guozhangwang commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443849945 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[GitHub] [kafka] guozhangwang commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

guozhangwang commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443847867 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -69,7 +68,6 @@ private final

[GitHub] [kafka] abbccdda commented on pull request #8174: KAFKA-9439: add KafkaProducer API unit tests

abbccdda commented on pull request #8174: URL: https://github.com/apache/kafka/pull/8174#issuecomment-647782852 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-10055) Add shared internal utility class for Streams module

[ https://issues.apache.org/jira/browse/KAFKA-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142429#comment-17142429 ] Boyang Chen commented on KAFKA-10055: - Need to move to the shared utility class as well > Add

[jira] [Comment Edited] (KAFKA-10055) Add shared internal utility class for Streams module

[ https://issues.apache.org/jira/browse/KAFKA-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142429#comment-17142429 ] Boyang Chen edited comment on KAFKA-10055 at 6/22/20, 9:32 PM: --- Need to

[GitHub] [kafka] abbccdda commented on a change in pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

abbccdda commented on a change in pull request #8887: URL: https://github.com/apache/kafka/pull/8887#discussion_r443837837 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1048,4 +1042,28 @@ public String toString(final

[jira] [Created] (KAFKA-10192) Flaky test BlockingConnectorTest#testBlockInConnectorStop

Boyang Chen created KAFKA-10192: --- Summary: Flaky test BlockingConnectorTest#testBlockInConnectorStop Key: KAFKA-10192 URL: https://issues.apache.org/jira/browse/KAFKA-10192 Project: Kafka

[GitHub] [kafka] abbccdda commented on pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

abbccdda commented on pull request #8887: URL: https://github.com/apache/kafka/pull/8887#issuecomment-647778576 Only one flaky test failed: ``` org.apache.kafka.connect.integration.BlockingConnectorTest.testBlockInConnectorStop ```

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric

[jira] [Updated] (KAFKA-10189) Reset metric EventQueueTimeMs

[ https://issues.apache.org/jira/browse/KAFKA-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-10189: - Description: The metric

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142419#comment-17142419 ] Gokul Ramanan Subramanian commented on KAFKA-10105: --- [~william_reynolds] is this

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443828344 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close()

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443809040 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -69,7 +68,6 @@ private final

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443809040 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -69,7 +68,6 @@ private final

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443808226 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -522,7 +522,7 @@ private void close(final

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443807553 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -771,7 +794,7 @@ private void processDisconnection(List responses,

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443806341 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -185,4 +191,9 @@ public static void

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443794598 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -103,6 +103,12 @@

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443793290 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +345,37 @@ private NodeConnectionState

[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

abbccdda commented on pull request #8845: URL: https://github.com/apache/kafka/pull/8845#issuecomment-647739314 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443785134 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443785134 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443785134 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r443785134 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +398,36 @@ private NodeConnectionState

[GitHub] [kafka] abbccdda closed pull request #8725: KAFKA-9608: Transaction Event Simulation Test

abbccdda closed pull request #8725: URL: https://github.com/apache/kafka/pull/8725 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   >