[GitHub] [kafka] akatona84 edited a comment on pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

akatona84 edited a comment on pull request #8992: URL: https://github.com/apache/kafka/pull/8992#issuecomment-655925569 @gcsaba2, here's my PR regarding the test fix, thx for the tip for quietly closing consumers This is an

[GitHub] [kafka] akatona84 commented on pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

akatona84 commented on pull request #8992: URL: https://github.com/apache/kafka/pull/8992#issuecomment-655925569 @gcsaba2, here's my PR regarding the test fix This is an automated message from the Apache Git Service. To respo

[GitHub] [kafka] omkreddy commented on pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

omkreddy commented on pull request #8808: URL: https://github.com/apache/kafka/pull/8808#issuecomment-655879846 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451945495 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -224,6 +224,9 @@ void initializeStor

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451939499 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1140,4 +1166,12 @@ public static void executeAndM

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451939231 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -766,6 +769,24 @@ void runOnce() { retur

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451939108 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -137,7 +138,7 @@ STARTING(2, 3, 5),

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451938891 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -95,7 +96,7 @@ * | | Assigned

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451938167 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -193,6 +197,28 @@ private void closeAndRevive(fina

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451938104 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -193,6 +197,28 @@ private void closeAndRevive(fina

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451937935 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -766,6 +769,24 @@ void runOnce() { retur

[GitHub] [kafka] apovzner commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

apovzner commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r451937131 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] apovzner commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

apovzner commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r451932855 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] apovzner commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

apovzner commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r451932855 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] apovzner commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

apovzner commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r451932855 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] apovzner commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

apovzner commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r451932855 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] apovzner commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

apovzner commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r451932855 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] mjsax commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

mjsax commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451928170 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java ## @@ -784,7 +784,7 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

mjsax commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451927714 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -104,17 +104,16 @@ static void closeStateManager

[GitHub] [kafka] mjsax commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

mjsax commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451927097 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -224,6 +224,9 @@ void initializeStoreOffset

[GitHub] [kafka] mjsax commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

mjsax commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451926665 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -224,6 +224,9 @@ void initializeStoreOffset

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451925626 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -104,17 +104,16 @@ static void closeState

[GitHub] [kafka] ableegoldman commented on a change in pull request #8997: MINOR: Improve log4j for per-consumer assignment

ableegoldman commented on a change in pull request #8997: URL: https://github.com/apache/kafka/pull/8997#discussion_r451915598 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -725,8 +725,10 @@ private boolean

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451922421 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java ## @@ -784,7 +784,7 @@ public void clo

[GitHub] [kafka] ableegoldman commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

ableegoldman commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451922040 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -224,6 +224,9 @@ void initializeStor

[jira] [Commented] (KAFKA-8940) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154113#comment-17154113 ] Sophie Blee-Goldman commented on KAFKA-8940: Failed again: h3. Error Message

[GitHub] [kafka] guozhangwang commented on a change in pull request #8997: MINOR: Improve log4j for per-consumer assignment

guozhangwang commented on a change in pull request #8997: URL: https://github.com/apache/kafka/pull/8997#discussion_r451912298 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -66,32 +72,17 @@ public ClientState

[GitHub] [kafka] guozhangwang commented on pull request #8997: MINOR: Improve log4j for per-consumer assignment

guozhangwang commented on pull request #8997: URL: https://github.com/apache/kafka/pull/8997#issuecomment-655841394 @ableegoldman @abbccdda This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] guozhangwang opened a new pull request #8997: MINOR: Improve log4j for per-consumer assignment

guozhangwang opened a new pull request #8997: URL: https://github.com/apache/kafka/pull/8997 Add log4j entry summarizing the assignment (prev owned and assigned) at the consumer level. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[jira] [Commented] (KAFKA-10251) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupMetadata

[ https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154110#comment-17154110 ] Sophie Blee-Goldman commented on KAFKA-10251: - cc [~bchen225242] –  [https:/

[jira] [Created] (KAFKA-10251) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupMetadata

Sophie Blee-Goldman created KAFKA-10251: --- Summary: Flaky Test kafka.api.TransactionsBounceTest.testWithGroupMetadata Key: KAFKA-10251 URL: https://issues.apache.org/jira/browse/KAFKA-10251 Proje

[GitHub] [kafka] mjsax closed pull request #8855: DO NOT MERGE

mjsax closed pull request #8855: URL: https://github.com/apache/kafka/pull/8855 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

mjsax commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r451903126 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,24 +45,23 @@ protected Processo

[GitHub] [kafka] mjsax commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

mjsax commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451902131 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java ## @@ -813,6 +813,62 @@ public void shouldTh

[GitHub] [kafka] mjsax commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

mjsax commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451901975 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java ## @@ -784,7 +784,7 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

mjsax commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451900686 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -224,6 +224,9 @@ void initializeStoreOffset

[GitHub] [kafka] mjsax commented on a change in pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

mjsax commented on a change in pull request #8996: URL: https://github.com/apache/kafka/pull/8996#discussion_r451899726 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -224,6 +224,9 @@ void initializeStoreOffset

[GitHub] [kafka] chia7712 commented on a change in pull request #8981: KAFKA-10235 Fix flaky transactions_test.py

chia7712 commented on a change in pull request #8981: URL: https://github.com/apache/kafka/pull/8981#discussion_r451898731 ## File path: tests/kafkatest/tests/core/transactions_test.py ## @@ -47,7 +47,10 @@ def __init__(self, test_context): self.num_output_partitions =

[GitHub] [kafka] mjsax commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

mjsax commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451895176 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -193,6 +197,28 @@ private void closeAndRevive(final M

[GitHub] [kafka] ableegoldman commented on pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

ableegoldman commented on pull request #8996: URL: https://github.com/apache/kafka/pull/8996#issuecomment-655825204 Two failures: `TransactionsBounceTest.testWithGroupMetadata` `SmokeTestDriverIntegrationTest.shouldWorkWithRebalance` The `shouldWorkWithRebalance` failure is actu

[GitHub] [kafka] ableegoldman commented on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

ableegoldman commented on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-655815316 Hey @vvcephei , do you think we should ask about cherrypicking this back to 2.6 to help stabilize the release? I thought failing system tests (or regularly failing tests of a

[GitHub] [kafka] ableegoldman commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

ableegoldman commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451884449 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -95,7 +96,7 @@ * | | Assi

[GitHub] [kafka] apovzner commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

apovzner commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r451871529 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java ## @@ -97,7 +97,25 @@ public static RecordingLevel forName(String name) {

[GitHub] [kafka] vvcephei commented on pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei commented on pull request #8994: URL: https://github.com/apache/kafka/pull/8994#issuecomment-655792712 Ok, @abbccdda and @mjsax , I think this is ready for a review now. I'm not very happy with the logic to reset to the last committed offset. Can you think of a better way to do it

[GitHub] [kafka] ableegoldman commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

ableegoldman commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451862588 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -766,6 +769,24 @@ void runOnce() { r

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r451860750 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -766,6 +769,24 @@ void runOnce() { retur

[GitHub] [kafka] rhauch commented on a change in pull request #8864: KAFKA-9274: Mark `retries` config as deprecated and add new `task.timeout.ms` config

rhauch commented on a change in pull request #8864: URL: https://github.com/apache/kafka/pull/8864#discussion_r451856474 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java ## @@ -148,6 +148,7 @@ public KafkaStatusBackingSt

[jira] [Comment Edited] (KAFKA-10250) Kafka broker shrinks the ISRs and disconnects from other brokers for few seconds

[ https://issues.apache.org/jira/browse/KAFKA-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154043#comment-17154043 ] Rishank Chandra Puram edited comment on KAFKA-10250 at 7/8/20, 10:09 PM: -

[GitHub] [kafka] mjsax commented on pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

mjsax commented on pull request #8996: URL: https://github.com/apache/kafka/pull/8996#issuecomment-655783477 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Updated] (KAFKA-10250) Kafka broker shrinks the ISRs and disconnects from other brokers for few seconds

[ https://issues.apache.org/jira/browse/KAFKA-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishank Chandra Puram updated KAFKA-10250: -- Description: The following the summary/overview of the whole issue. Can you pl

[jira] [Commented] (KAFKA-10250) Kafka broker shrinks the ISRs and disconnects from other brokers for few seconds

[ https://issues.apache.org/jira/browse/KAFKA-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154043#comment-17154043 ] Rishank Chandra Puram commented on KAFKA-10250: --- 1. When the issue occurs,

[GitHub] [kafka] ableegoldman opened a new pull request #8996: KAFKA-10249: don't try to read un-checkpointed offsets of in-memory stores

ableegoldman opened a new pull request #8996: URL: https://github.com/apache/kafka/pull/8996 We have this asymmetry in how the ProcessorStateManager handles in-memory stores: we explicitly skip over them when writing offsets to the checkpoint file, but don't do the same when reading from t

[jira] [Created] (KAFKA-10250) Kafka broker shrinks the ISRs and disconnects from other brokers for few seconds

Rishank Chandra Puram created KAFKA-10250: - Summary: Kafka broker shrinks the ISRs and disconnects from other brokers for few seconds Key: KAFKA-10250 URL: https://issues.apache.org/jira/browse/KAFKA-10250

[GitHub] [kafka] kkonstantine commented on pull request #8928: KAFKA-10192: Wait for REST API to become available before testing blocked connectors

kkonstantine commented on pull request #8928: URL: https://github.com/apache/kafka/pull/8928#issuecomment-655764773 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] kkonstantine commented on a change in pull request #8928: KAFKA-10192: Wait for REST API to become available before testing blocked connectors

kkonstantine commented on a change in pull request #8928: URL: https://github.com/apache/kafka/pull/8928#discussion_r451832657 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java ## @@ -76,6 +78,15 @@ public void setup()

[jira] [Created] (KAFKA-10249) In-memory stores are skipped when checkpointing but not skipped when reading the checkpoint

Sophie Blee-Goldman created KAFKA-10249: --- Summary: In-memory stores are skipped when checkpointing but not skipped when reading the checkpoint Key: KAFKA-10249 URL: https://issues.apache.org/jira/browse/KAFK

[GitHub] [kafka] JimGalasyn commented on a change in pull request #8995: Restore stream-table duality description

JimGalasyn commented on a change in pull request #8995: URL: https://github.com/apache/kafka/pull/8995#discussion_r451809936 ## File path: docs/streams/core-concepts.html ## @@ -170,13 +150,59 @@ Duality of or to run interactive queries against your application's

[GitHub] [kafka] junrao commented on pull request #8981: KAFKA-10235 Fix flaky transactions_test.py

junrao commented on pull request #8981: URL: https://github.com/apache/kafka/pull/8981#issuecomment-655737852 triggered a system test run This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] junrao commented on a change in pull request #8981: KAFKA-10235 Fix flaky transactions_test.py

junrao commented on a change in pull request #8981: URL: https://github.com/apache/kafka/pull/8981#discussion_r451224908 ## File path: tests/kafkatest/tests/core/transactions_test.py ## @@ -47,7 +47,10 @@ def __init__(self, test_context): self.num_output_partitions = 3

[jira] [Resolved] (KAFKA-10225) Increase default zk session timeout for system tests

[ https://issues.apache.org/jira/browse/KAFKA-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10225. - Fix Version/s: 2.7.0 Resolution: Fixed merged the PR to trunk > Increase default zk session time

[GitHub] [kafka] junrao merged pull request #8974: KAFKA-10225 Increase default zk session timeout for system tests

junrao merged pull request #8974: URL: https://github.com/apache/kafka/pull/8974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] junrao commented on pull request #8974: KAFKA-10225 Increase default zk session timeout for system tests

junrao commented on pull request #8974: URL: https://github.com/apache/kafka/pull/8974#issuecomment-655734288 System test results. All 9 failures seem unrelated to this PR. http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-07--001.1594186925--chia7

[GitHub] [kafka] mjsax commented on a change in pull request #8995: Restore stream-table duality description

mjsax commented on a change in pull request #8995: URL: https://github.com/apache/kafka/pull/8995#discussion_r451796320 ## File path: docs/streams/core-concepts.html ## @@ -170,13 +150,59 @@ Duality of or to run interactive queries against your application's late

[jira] [Commented] (KAFKA-8770) Either switch to or add an option for emit-on-change

[ https://issues.apache.org/jira/browse/KAFKA-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153977#comment-17153977 ] John Roesler commented on KAFKA-8770: - Ok, I created (and resolved) a subtask, which

[jira] [Resolved] (KAFKA-10248) Drop idempotent KTable source updates

[ https://issues.apache.org/jira/browse/KAFKA-10248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10248. -- Resolution: Fixed > Drop idempotent KTable source updates > --

[jira] [Commented] (KAFKA-10248) Drop idempotent KTable source updates

[ https://issues.apache.org/jira/browse/KAFKA-10248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153976#comment-17153976 ] John Roesler commented on KAFKA-10248: -- This was implemented in this commit: {code:

[jira] [Updated] (KAFKA-10248) Drop idempotent KTable source updates

[ https://issues.apache.org/jira/browse/KAFKA-10248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10248: - Fix Version/s: 2.6.0 > Drop idempotent KTable source updates > -

[jira] [Created] (KAFKA-10248) Drop idempotent KTable source updates

John Roesler created KAFKA-10248: Summary: Drop idempotent KTable source updates Key: KAFKA-10248 URL: https://issues.apache.org/jira/browse/KAFKA-10248 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-8770) Either switch to or add an option for emit-on-change

[ https://issues.apache.org/jira/browse/KAFKA-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153975#comment-17153975 ] John Roesler commented on KAFKA-8770: - Hi [~davispw] , That's a good idea. I'll spli

[GitHub] [kafka] vvcephei commented on pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei commented on pull request #8994: URL: https://github.com/apache/kafka/pull/8994#issuecomment-655721490 Hey @abbccdda and @mjsax , thanks for taking a look! The PR is not complete yet. I'll let you know when it's ready for review. --

[jira] [Commented] (KAFKA-10218) DistributedHerder's canReadConfigs field is never reset to true

[ https://issues.apache.org/jira/browse/KAFKA-10218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153936#comment-17153936 ] Chris Egerton commented on KAFKA-10218: --- [~rhauch] The primary impact here is that

[GitHub] [kafka] cmccabe merged pull request #8985: MINOR; KafkaAdminClient#alterReplicaLogDirs should not fail all the futures when only one call fails

cmccabe merged pull request #8985: URL: https://github.com/apache/kafka/pull/8985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] JimGalasyn opened a new pull request #8995: Restore stream-table duality description

JimGalasyn opened a new pull request #8995: URL: https://github.com/apache/kafka/pull/8995 The stream-table duality section was dropped inadvertently sometime after version 0.11.0, so this PR restores it. This is an automate

[GitHub] [kafka] mjsax commented on pull request #8994: KAFKA-10247: Skip processing if task isn't running

mjsax commented on pull request #8994: URL: https://github.com/apache/kafka/pull/8994#issuecomment-655701085 It seem the root cause of the issue is that we don't cleanup internal data structures correctly when closing a task dirty? Should the task not be removed from the list of active tas

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153862#comment-17153862 ] Guozhang Wang commented on KAFKA-10134: --- cc 2.5.1 release manager [~vvcephei] I'm

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153861#comment-17153861 ] Guozhang Wang commented on KAFKA-10134: --- Thanks for the confirmation! I'm resolvin

[jira] [Resolved] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10134. --- Resolution: Fixed > High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153852#comment-17153852 ] Neo Wu commented on KAFKA-10134: Hi, [~guozhang] Your latest change fixed all my issues

[jira] [Updated] (KAFKA-10247) Streams may attempt to process after closing a task

[ https://issues.apache.org/jira/browse/KAFKA-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10247: - Priority: Blocker (was: Major) > Streams may attempt to process after closing a task >

[GitHub] [kafka] vvcephei opened a new pull request #8994: KAFKA-10247: Skip processing if task isn't running

vvcephei opened a new pull request #8994: URL: https://github.com/apache/kafka/pull/8994 The definition of `Task#process` allows for returning `false` if the task isn't "processable" right now. We can conveniently resolve KAFKA-10247 by simply considering a task not processable when

[jira] [Created] (KAFKA-10247) Streams may attempt to process after closing a task

John Roesler created KAFKA-10247: Summary: Streams may attempt to process after closing a task Key: KAFKA-10247 URL: https://issues.apache.org/jira/browse/KAFKA-10247 Project: Kafka Issue Typ

[GitHub] [kafka] vvcephei commented on a change in pull request #8993: KAFKA-10173: Use SmokeTest for upgrade system tests (#8938)

vvcephei commented on a change in pull request #8993: URL: https://github.com/apache/kafka/pull/8993#discussion_r451712293 ## File path: tests/kafkatest/tests/streams/streams_application_upgrade_test.py ## @@ -0,0 +1,297 @@ +# Licensed to the Apache Software Foundation (ASF) un

[jira] [Comment Edited] (KAFKA-10226) KStream without SASL information should return error in confluent cloud

[ https://issues.apache.org/jira/browse/KAFKA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153768#comment-17153768 ] Werner Daehn edited comment on KAFKA-10226 at 7/8/20, 5:26 PM: ---

[GitHub] [kafka] omkreddy commented on pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

omkreddy commented on pull request #8808: URL: https://github.com/apache/kafka/pull/8808#issuecomment-655651164 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

vvcephei commented on pull request #8902: URL: https://github.com/apache/kafka/pull/8902#issuecomment-655648704 Failure was unrelated: kafka.api.SaslMultiMechanismConsumerTest.testCoordinatorFailover This is an automated mes

[jira] [Commented] (KAFKA-10226) KStream without SASL information should return error in confluent cloud

[ https://issues.apache.org/jira/browse/KAFKA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153768#comment-17153768 ] Werner Daehn commented on KAFKA-10226: -- Here is my verdict after testing: Producer

[GitHub] [kafka] tombentley commented on pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

tombentley commented on pull request #8808: URL: https://github.com/apache/kafka/pull/8808#issuecomment-655641999 @omkreddy, sorry about that, now fixed. This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153757#comment-17153757 ] Guozhang Wang commented on KAFKA-10134: --- I've merged the PR and would like [~seang

[GitHub] [kafka] guozhangwang commented on pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

guozhangwang commented on pull request #8934: URL: https://github.com/apache/kafka/pull/8934#issuecomment-655636676 Cherry-picked to 2.6. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] guozhangwang merged pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

guozhangwang merged pull request #8934: URL: https://github.com/apache/kafka/pull/8934 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] hachikuji commented on a change in pull request #8864: KAFKA-9274: Mark `retries` config as deprecated and add new `task.timeout.ms` config

hachikuji commented on a change in pull request #8864: URL: https://github.com/apache/kafka/pull/8864#discussion_r451682470 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -1447,6 +1451,7 @@ public void testListConsumerGroups

[GitHub] [kafka] omkreddy commented on a change in pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

omkreddy commented on a change in pull request #8808: URL: https://github.com/apache/kafka/pull/8808#discussion_r451674847 ## File path: core/src/test/scala/unit/kafka/admin/AclCommandTest.scala ## @@ -127,25 +131,53 @@ class AclCommandTest extends ZooKeeperTestHarness with Lo

[jira] [Updated] (KAFKA-9144) Early expiration of producer state can cause coordinator epoch to regress

[ https://issues.apache.org/jira/browse/KAFKA-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-9144: --- Affects Version/s: 2.0.1 2.1.1 2.2.2

[jira] [Updated] (KAFKA-9144) Early expiration of producer state can cause coordinator epoch to regress

[ https://issues.apache.org/jira/browse/KAFKA-9144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-9144: --- Fix Version/s: 2.3.2 2.2.3 > Early expiration of producer state can cause

[GitHub] [kafka] tombentley commented on pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

tombentley commented on pull request #8808: URL: https://github.com/apache/kafka/pull/8808#issuecomment-655617244 @omkreddy done This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8993: KAFKA-10173: Use SmokeTest for upgrade system tests (#8938)

vvcephei commented on pull request #8993: URL: https://github.com/apache/kafka/pull/8993#issuecomment-655605721 Started the new test: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4015/ And all streams tests: https://jenkins.confluent.io/job/system-test-kafka-branch-

[GitHub] [kafka] vvcephei commented on a change in pull request #8993: KAFKA-10173: Use SmokeTest for upgrade system tests (#8938)

vvcephei commented on a change in pull request #8993: URL: https://github.com/apache/kafka/pull/8993#discussion_r451634562 ## File path: build.gradle ## @@ -1508,6 +1508,18 @@ project(':streams:upgrade-system-tests-24') { } } +project(':streams:upgrade-system-tests-25') {

[GitHub] [kafka] omkreddy commented on a change in pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

omkreddy commented on a change in pull request #8808: URL: https://github.com/apache/kafka/pull/8808#discussion_r451626581 ## File path: core/src/test/scala/unit/kafka/admin/AclCommandTest.scala ## @@ -161,10 +193,34 @@ class AclCommandTest extends ZooKeeperTestHarness with Lo

[GitHub] [kafka] vvcephei opened a new pull request #8993: KAFKA-10173: Use SmokeTest for upgrade system tests (#8938)

vvcephei opened a new pull request #8993: URL: https://github.com/apache/kafka/pull/8993 Replaces the previous upgrade test's trivial Streams app with the commonly used SmokeTest, exercising many more features. Also adjust the test matrix to test upgrading from each released version

[jira] [Commented] (KAFKA-10226) KStream without SASL information should return error in confluent cloud

[ https://issues.apache.org/jira/browse/KAFKA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153667#comment-17153667 ] John Roesler commented on KAFKA-10226: -- Sounds good :) > KStream without SASL info

  1   2   >