vitojeng commented on pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#issuecomment-660422567
Sorry, should not rebase...
I'll force-push again!
This is an automated message from the Apache Git Service.
vitojeng commented on a change in pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#discussion_r456745965
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/InvalidStateStoreException.java
##
@@ -18,13 +18,11 @@
/**
- * Indicates that
vitojeng commented on a change in pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#discussion_r456745766
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/StateStoreMigratedException.java
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache
vitojeng commented on a change in pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#discussion_r456745210
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/InvalidStateStoreException.java
##
@@ -18,13 +18,11 @@
/**
- * Indicates that
[
https://issues.apache.org/jira/browse/KAFKA-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160310#comment-17160310
]
Ismael Juma commented on KAFKA-10282:
-
Have we considered removing the metrics when the log is
mumrah commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-660399783
Recent test failures are due to removal of the static `parse` method on
FetchRequest (it's only used via serialization in a test, so IntelliJ "usages"
didn't catch it).
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456730580
##
File path:
generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java
##
@@ -2397,6 +2460,9 @@ private String fieldDefault(FieldSpec
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456727715
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160216#comment-17160216
]
Boyang Chen edited comment on KAFKA-10284 at 7/17/20, 10:28 PM:
If we
ijuma commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456692033
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software
ijuma commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456692033
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-9126:
---
Description:
In 2.4.0 release, we introduced `StreamJoined` configuration object via KIP-479
ableegoldman commented on pull request #9027:
URL: https://github.com/apache/kafka/pull/9027#issuecomment-660349266
One flaky
`MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutorOffsetSync1`
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160225#comment-17160225
]
Guozhang Wang commented on KAFKA-10284:
---
Fair enough. So it seems not a correctness breaking issue
[
https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160216#comment-17160216
]
Boyang Chen commented on KAFKA-10284:
-
If we have a combined scenario like below:
# A static
hachikuji commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456662850
##
File path:
generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java
##
@@ -2397,6 +2460,9 @@ private String fieldDefault(FieldSpec
hachikuji commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456660379
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##
@@ -492,74 +327,51 @@ public int maxBytes() {
}
[
https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10284:
Description:
For known static members rejoin, we would update its corresponding member.id
soarez commented on pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#issuecomment-660299315
@mjsax yes, if we can continue the current work here, then we should close
it. I don’t think I’m able to add commits to the original PR.
mjsax commented on a change in pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#discussion_r456623483
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/InvalidStateStorePartitionException.java
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/KAFKA-10284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160152#comment-17160152
]
Guozhang Wang commented on KAFKA-10284:
---
[~bchen225242] Thanks for the find. Just trying to
rajinisivaram merged pull request #8979:
URL: https://github.com/apache/kafka/pull/8979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
guozhangwang merged pull request #8997:
URL: https://github.com/apache/kafka/pull/8997
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rajinisivaram commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-660286395
@ijuma @hachikuji @bob-barrett Thanks for the reviews, merging to trunk and
2.6.
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160146#comment-17160146
]
Guozhang Wang commented on KAFKA-10134:
---
[~zhowei] [~seanguo] I tried to reproduce your high CPU
mjsax commented on pull request #9017:
URL: https://github.com/apache/kafka/pull/9017#issuecomment-660283323
@piddubnyi Thanks for the PR -- it seems this PR includes public API changes
and thus requires a KIP:
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
mjsax commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r456616494
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##
@@ -265,7 +265,7 @@ public void
mjsax commented on pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#issuecomment-660280418
@soarez Is this PR a replacement of #8752 and we should close the other PR?
This is an automated message from the
ableegoldman commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r456615189
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##
@@ -265,7 +265,7 @@ public void
mjsax commented on pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#issuecomment-660278609
Some follow up nits: The method `add10InputElements` does not throw any
exception and we should remove the `throws` statement. Also in
`AbstractResetIntegrationTest` in L283 we use
mjsax commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r456611805
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##
@@ -265,7 +265,7 @@ public void
lct45 opened a new pull request #9039:
URL: https://github.com/apache/kafka/pull/9039
Updating basic classes for SlidingWindows implementation, WIP and POC,
things will shift as KIP discussion continues.
### Committer Checklist (excluded from commit message)
- [ ] Verify design
ableegoldman commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r456609785
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##
@@ -265,7 +265,7 @@ public void
mjsax commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r456608124
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##
@@ -265,7 +265,7 @@ public void
hachikuji merged pull request #9033:
URL: https://github.com/apache/kafka/pull/9033
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
guozhangwang opened a new pull request #9038:
URL: https://github.com/apache/kafka/pull/9038
This patch is only for trouble shooting purposes.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
hachikuji commented on pull request #9033:
URL: https://github.com/apache/kafka/pull/9033#issuecomment-660263724
Here's a link to passing tests:
vvcephei commented on pull request #9027:
URL: https://github.com/apache/kafka/pull/9027#issuecomment-660257582
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
abbccdda commented on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-660241065
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10254:
-
Summary: 100% cpu usage by kafkaConsumer poll , when broker can't be
connect (was: 100% cpu
[
https://issues.apache.org/jira/browse/KAFKA-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brian Byrne resolved KAFKA-10278.
-
Resolution: Won't Fix
Hi Kaushik,
The command is set to only return modified (non-default)
leonardge opened a new pull request #9037:
URL: https://github.com/apache/kafka/pull/9037
Improved code quality for various files.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
-
vvcephei merged pull request #9035:
URL: https://github.com/apache/kafka/pull/9035
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vvcephei commented on pull request #9035:
URL: https://github.com/apache/kafka/pull/9035#issuecomment-660208347
The build works for me locally, and I'll certainly run all the tests again
once the RC is cut, so I'll just merge this now.
[
https://issues.apache.org/jira/browse/KAFKA-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-10254.
--
Resolution: Fixed
Changing resolution to "fixed", since the linked duplicate is fixed.
>
[
https://issues.apache.org/jira/browse/KAFKA-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler reopened KAFKA-10254:
--
> 100% cpu usage by kafkaConsumer poll , when broker can‘t be connect
>
[
https://issues.apache.org/jira/browse/KAFKA-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-9763.
-
Resolution: Fixed
> Recent changes to Connect's InsertField will fail to inject field on key of
[
https://issues.apache.org/jira/browse/KAFKA-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160043#comment-17160043
]
John Roesler commented on KAFKA-9763:
-
Changed the resolution to "Fixed" so that I can run release.py
[
https://issues.apache.org/jira/browse/KAFKA-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler reopened KAFKA-9763:
-
> Recent changes to Connect's InsertField will fail to inject field on key of
> tombstone record
>
vvcephei commented on pull request #9035:
URL: https://github.com/apache/kafka/pull/9035#issuecomment-660198682
Thanks @mumrah (and no problem, no one complained! )
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/KAFKA-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram updated KAFKA-7740:
--
Fix Version/s: (was: 2.5.0)
2.6.0
> Kafka Admin Client should be able
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456539488
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-9861:
Fix Version/s: (was: 2.5.1)
2.5.2
> Process Simplification - Community
[
https://issues.apache.org/jira/browse/KAFKA-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160028#comment-17160028
]
John Roesler commented on KAFKA-9861:
-
Hi [~iekpo] , I'm bumping the fix version to 2.5.2, since the
[
https://issues.apache.org/jira/browse/KAFKA-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-10254.
--
Resolution: Duplicate
Hey [~xiaotong.wang] , thanks for the report! It looks like a duplicate
leonardge commented on pull request #8922:
URL: https://github.com/apache/kafka/pull/8922#issuecomment-660192852
Hi @omkreddy , will be great if you can have a look at this small change.
This is an automated message from the
leonardge commented on pull request #8922:
URL: https://github.com/apache/kafka/pull/8922#issuecomment-660192697
Hi @omkreddy , will be great if you can have a look at this small change.
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160024#comment-17160024
]
John Roesler commented on KAFKA-10271:
--
Bumped to 2.5.2, as the 2.5.1 release is already in
[
https://issues.apache.org/jira/browse/KAFKA-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10271:
-
Fix Version/s: (was: 2.5.1)
2.5.2
> Performance degradation while
dajac opened a new pull request #9036:
URL: https://github.com/apache/kafka/pull/9036
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
vvcephei opened a new pull request #9035:
URL: https://github.com/apache/kafka/pull/9035
Getting ready for the 2.5.1 RC.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify
soarez commented on pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#issuecomment-660178140
@mjsax can something be done to move this forward?
This is an automated message from the Apache Git Service.
To
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456518529
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software
rajinisivaram commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456501251
##
File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala
##
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software
rajinisivaram commented on a change in pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#discussion_r456470508
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/ReplicaNotAvailableException.java
##
@@ -16,7 +16,13 @@
*/
package
showuon commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-660131258
hi @ning2008wisc , thanks for your comments and suggestion! I've updated in
this commit:
showuon removed a comment on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-659865858
Thanks for your comments and suggestion! I've updated in this commit:
https://github.com/apache/kafka/pull/9029/commits/88400bf350b60684db33828d690cfa238d056781.
Thanks.
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456450107
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##
@@ -492,74 +327,51 @@ public int maxBytes() {
}
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456449035
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##
@@ -492,74 +327,51 @@ public int maxBytes() {
}
dajac commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456447554
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##
@@ -273,6 +99,28 @@ public boolean equals(Object o) {
}
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456444794
##
File path: clients/src/main/resources/common/message/FetchResponse.json
##
@@ -47,33 +47,35 @@
"about": "The top level response error code." },
ijuma commented on a change in pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#discussion_r456443495
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/ReplicaNotAvailableException.java
##
@@ -16,7 +16,13 @@
*/
package
dajac commented on pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#issuecomment-660106847
@rajinisivaram Thanks for your review. I have addressed all your comments
module the two regarding the naming of the type and the classes which are still
under discussions.
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456423986
##
File path: core/src/main/scala/kafka/server/ClientQuotaManager.scala
##
@@ -154,32 +180,40 @@ object ClientQuotaManager {
* @param config
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456415876
##
File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala
##
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456415576
##
File path: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java
##
@@ -97,7 +97,25 @@ public static RecordingLevel forName(String name) {
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456410896
##
File path:
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala
##
@@ -0,0 +1,361 @@
+/**
+ * Licensed under the Apache License,
[
https://issues.apache.org/jira/browse/KAFKA-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akshay Sharma updated KAFKA-10285:
--
Description:
Running single consumer(which is internally using confluent-kafka-go and
[
https://issues.apache.org/jira/browse/KAFKA-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akshay Sharma updated KAFKA-10285:
--
Priority: Critical (was: Major)
> consumer is not rejoining after restart of broker.
>
[
https://issues.apache.org/jira/browse/KAFKA-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akshay Sharma updated KAFKA-10285:
--
Description:
Running single consumer(which is internally using confluent-kafka-go and
Akshay Sharma created KAFKA-10285:
-
Summary: consumer is not rejoining after restart of broker.
Key: KAFKA-10285
URL: https://issues.apache.org/jira/browse/KAFKA-10285
Project: Kafka
Issue
rajinisivaram commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456378780
##
File path:
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala
##
@@ -0,0 +1,361 @@
+/**
+ * Licensed under the Apache
rajinisivaram commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456377172
##
File path: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java
##
@@ -97,7 +97,25 @@ public static RecordingLevel forName(String
rajinisivaram commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456371880
##
File path: core/src/main/scala/kafka/server/ClientQuotaManager.scala
##
@@ -154,32 +180,40 @@ object ClientQuotaManager {
* @param config
dima5rr commented on pull request #9020:
URL: https://github.com/apache/kafka/pull/9020#issuecomment-660038989
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please
rajinisivaram commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-660032381
@hachikuji @ijuma Thanks for the reviews. I have updated the docs and made
ReplicaNotAvailableException a subclass of InvalidMetadataException. Also moved
upgrade doc under
rajinisivaram commented on a change in pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#discussion_r456364045
##
File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
##
@@ -139,13 +139,15 @@
rajinisivaram commented on a change in pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#discussion_r456363700
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -58,8 +58,8 @@
*
* - {@link
AshishRoyJava opened a new pull request #9034:
URL: https://github.com/apache/kafka/pull/9034
AbstractProcessorContext topic() throws NullPointerException when modifying
a state store within the DSL from a punctuator
AshishRoyJava closed pull request #8633:
URL: https://github.com/apache/kafka/pull/8633
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
urbandan commented on pull request #8957:
URL: https://github.com/apache/kafka/pull/8957#issuecomment-659973853
@huxihx thanks for catching that, added the .bat.
Based on the discussion thread, also updated the usage to mention that only
authorized topics are listed.
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456307126
##
File path:
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala
##
@@ -0,0 +1,361 @@
+/**
+ * Licensed under the Apache License,
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456300213
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1777,7 +1787,7 @@ class KafkaApis(val requestChannel: RequestChannel,
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456295915
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1746,21 +1751,26 @@ class KafkaApis(val requestChannel: RequestChannel,
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456293121
##
File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala
##
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456279196
##
File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala
##
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456278039
##
File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala
##
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456276753
##
File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala
##
@@ -0,0 +1,205 @@
+/**
+ * Licensed to the Apache Software Foundation
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456273645
##
File path: core/src/main/scala/kafka/server/ClientQuotaManager.scala
##
@@ -234,55 +266,85 @@ class ClientQuotaManager(private val config:
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456273174
##
File path: core/src/main/scala/kafka/server/AdminManager.scala
##
@@ -295,34 +312,44 @@ class AdminManager(val config: KafkaConfig,
throw new
1 - 100 of 102 matches
Mail list logo
