mjsax edited a comment on pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#issuecomment-662818424
Triggered system tests:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4071/
This is an
[
https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10205:
Issue Type: Improvement (was: Bug)
> NullPointerException in StreamTask
>
omkreddy commented on pull request #9007:
URL: https://github.com/apache/kafka/pull/9007#issuecomment-662818802
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10205:
Labels: beginner newbie (was: )
> NullPointerException in StreamTask
>
omkreddy merged pull request #9036:
URL: https://github.com/apache/kafka/pull/9036
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax commented on pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#issuecomment-662818424
Triggered system tests:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4070/
This is an
omkreddy closed pull request #8885:
URL: https://github.com/apache/kafka/pull/8885
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163210#comment-17163210
]
John Roesler commented on KAFKA-10205:
--
Thanks, all. I’d just assigned it to myself in case it
[
https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler reassigned KAFKA-10205:
Assignee: (was: John Roesler)
> NullPointerException in StreamTask
>
mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r459206503
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java
##
@@ -71,21 +73,20 @@
private final
mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r459206759
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -154,27 +164,34 @@ public
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r459206661
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java
##
@@ -78,6 +78,7 @@
private
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r459206357
##
File path: streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
##
@@ -159,6 +159,7 @@ public void testGetGroupInstanceIdConfigs() {
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r459206391
##
File path: streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
##
@@ -190,6 +191,7 @@ public void
chia7712 commented on pull request #9059:
URL: https://github.com/apache/kafka/pull/9059#issuecomment-662810011
I have looped ```core/group_mode_transactions_test.py``` 10 times and it
works well.
@hachikuji @junrao Could you take a look?
mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r459206315
##
File path: streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
##
@@ -186,25 +183,9 @@ public void
mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r459206169
##
File path: streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
##
@@ -159,7 +159,6 @@ public void testGetGroupInstanceIdConfigs() {
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-662810186
> Could you rebase again? I will run the system tests after that. Thanks.
done. the known flaky ```group_mode_transactions_test.py``` is traced by
#9095
mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r459206092
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -46,33 +49,38 @@
"Please report at
[
https://issues.apache.org/jira/browse/KAFKA-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-10300:
---
Component/s: system tests
core
> fix flaky
mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r459205933
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1249,11 +1248,7 @@ public void cleanUp() {
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r459204783
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -55,6 +55,7 @@
private final int
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163204#comment-17163204
]
Guozhang Wang commented on KAFKA-8037:
--
Here's a wild thought following [~agavra]'s last comment:
mjsax opened a new pull request #9061:
URL: https://github.com/apache/kafka/pull/9061
Call for review @vvcephei
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mjsax opened a new pull request #9060:
URL: https://github.com/apache/kafka/pull/9060
- part of KIP-572
- replace `retries` in InternalTopicManager with infinite retires plus
a new timeout, based on consumer config MAX_POLL_INTERVAL_MS
Call for review @vvcephei
chia7712 commented on pull request #8660:
URL: https://github.com/apache/kafka/pull/8660#issuecomment-662807410
related doc error is fixed by #9055
This is an automated message from the Apache Git Service.
To respond to the
chia7712 closed pull request #8660:
URL: https://github.com/apache/kafka/pull/8660
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mumrah commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-662805571
Latest FetchResponse benchmark
trunk
```
Benchmark (partitionCount)
(topicCount) Mode Cnt Score Error Units
chia7712 opened a new pull request #9059:
URL: https://github.com/apache/kafka/pull/9059
the root cause is same to #9026 so I copy the approach of #9026 to resolve
```core/group_mode_transactions_test.py```
issue: https://issues.apache.org/jira/browse/KAFKA-10300
###
Chia-Ping Tsai created KAFKA-10300:
--
Summary: fix flaky core/group_mode_transactions_test.py
Key: KAFKA-10300
URL: https://issues.apache.org/jira/browse/KAFKA-10300
Project: Kafka
Issue
omkreddy commented on pull request #9016:
URL: https://github.com/apache/kafka/pull/9016#issuecomment-662802889
@zhangptang closing the PR. Please raise the PR against trunk branch.
This is an automated message from the
omkreddy closed pull request #9016:
URL: https://github.com/apache/kafka/pull/9016
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vitojeng commented on pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#issuecomment-662796672
> Looking forward to the next PR(s) -- it's best to continue doing multiple
smaller PRs (I leave it up to your judgment what the best way is to split the
work in chunks.)
mjsax commented on pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#issuecomment-662795038
Merged to `trunk`. Thanks for the PR and patience @vitojeng!
Looking forward to the next PR(s) -- it's best to continue doing multiple
smaller PRs (I leave it up to your
mjsax merged pull request #8200:
URL: https://github.com/apache/kafka/pull/8200
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mumrah commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-662794475
Thanks @cmccabe, great feedback. I've updated RecordsWriter to allocate a
single ByteBuffer based on a pre-calculated length (total message size - all
records size). This avoids
[
https://issues.apache.org/jira/browse/KAFKA-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163184#comment-17163184
]
Matthias J. Sax commented on KAFKA-10255:
-
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163142#comment-17163142
]
Sophie Blee-Goldman edited comment on KAFKA-8037 at 7/22/20, 11:54 PM:
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163142#comment-17163142
]
Sophie Blee-Goldman edited comment on KAFKA-8037 at 7/22/20, 11:52 PM:
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163142#comment-17163142
]
Sophie Blee-Goldman edited comment on KAFKA-8037 at 7/22/20, 11:52 PM:
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163142#comment-17163142
]
Sophie Blee-Goldman commented on KAFKA-8037:
Ah, thanks for bringing us back to the question
bob-barrett commented on a change in pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#discussion_r459142570
##
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##
@@ -563,4 +565,39 @@ class LogManagerTest {
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163135#comment-17163135
]
Almog Gavra commented on KAFKA-8037:
> That said...in my (admiteddly anecdotal) experience, the
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163135#comment-17163135
]
Almog Gavra edited comment on KAFKA-8037 at 7/22/20, 11:27 PM:
---
> That
cmccabe commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-662745982
Thanks for this, @mumrah. I took a look at the overall approach with the
`RecordsWriter` and it looks reasonable.
Do we need `RecordsReader`? Seems like we could just add
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163134#comment-17163134
]
Guozhang Wang edited comment on KAFKA-8037 at 7/22/20, 11:22 PM:
-
Great
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163134#comment-17163134
]
Guozhang Wang commented on KAFKA-8037:
--
Great comments from all of you, thank you so much!
I'd like
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163133#comment-17163133
]
Almog Gavra commented on KAFKA-8037:
> Can you give a specific example of how things would break due
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163126#comment-17163126
]
Matthias J. Sax commented on KAFKA-8037:
{quote}It is currently true that this is _only_ used to
[
https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163116#comment-17163116
]
Andrey Klochkov commented on KAFKA-10134:
-
Can somebody please clarify if this defect affects
mjsax commented on pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#issuecomment-662732812
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163096#comment-17163096
]
Sophie Blee-Goldman commented on KAFKA-8037:
By the way, I'm not trying to advocate strongly
soondenana commented on a change in pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#discussion_r459103347
##
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##
@@ -563,4 +565,39 @@ class LogManagerTest {
soondenana commented on a change in pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#discussion_r459102409
##
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##
@@ -563,4 +565,39 @@ class LogManagerTest {
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163090#comment-17163090
]
Sophie Blee-Goldman commented on KAFKA-8037:
[~vvcephei]I think you're referring to the
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163085#comment-17163085
]
Sophie Blee-Goldman commented on KAFKA-8037:
> many users might not even know if their serde
jlisam commented on pull request #8607:
URL: https://github.com/apache/kafka/pull/8607#issuecomment-662695001
@ijuma thanks for the prompt response. I think we should be able to upgrade
to 2.6.0 but ideally a backport would be better given that we have spent some
time validating the
vvcephei merged pull request #9053:
URL: https://github.com/apache/kafka/pull/9053
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vvcephei commented on pull request #9053:
URL: https://github.com/apache/kafka/pull/9053#issuecomment-662688918
Tests passed. Merging.
This is an automated message from the Apache Git Service.
To respond to the message,
rajinisivaram merged pull request #9055:
URL: https://github.com/apache/kafka/pull/9055
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rajinisivaram commented on pull request #9055:
URL: https://github.com/apache/kafka/pull/9055#issuecomment-662685402
@omkreddy Thanks for the review, merging to trunk
This is an automated message from the Apache Git Service.
ijuma commented on pull request #8607:
URL: https://github.com/apache/kafka/pull/8607#issuecomment-662685160
@jlisam It's too late to be included in 2.5.1 (currently in RC stage), but
it will be part of 2.6.0 (also at RC stage). Would you be able to upgrade to
2.6.0?
[
https://issues.apache.org/jira/browse/KAFKA-9731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163061#comment-17163061
]
Shane commented on KAFKA-9731:
--
Hey Apache team,
What are the odds of back-porting this to 2.5. I'm seeing
abbccdda commented on pull request #6700:
URL: https://github.com/apache/kafka/pull/6700#issuecomment-662673248
@rootex- Do you still want to continue on this feature?
This is an automated message from the Apache Git
ijuma commented on pull request #9058:
URL: https://github.com/apache/kafka/pull/9058#issuecomment-662659604
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
niteshmor commented on pull request #9058:
URL: https://github.com/apache/kafka/pull/9058#issuecomment-662656723
Local testing using `./gradlew test` resulted in 3 test failures. The
problematic tests passed when I reran those individually.
rajinisivaram merged pull request #9056:
URL: https://github.com/apache/kafka/pull/9056
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rajinisivaram commented on pull request #9056:
URL: https://github.com/apache/kafka/pull/9056#issuecomment-662653110
@ijuma Thanks for the review, merging to trunk and 2.6
This is an automated message from the Apache Git
jlisam commented on pull request #8607:
URL: https://github.com/apache/kafka/pull/8607#issuecomment-662649186
hello @ijuma, I was wondering if you knew when this fix would be backported.
We are currently on 2.5.0 and we are currently experiencing this issue. Thank
you
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-662642708
@chia7712 : I just merged #9026. Could you rebase again? I will run the
system tests after that. Thanks.
This is
[
https://issues.apache.org/jira/browse/KAFKA-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-10274.
-
Fix Version/s: 2.6.0
Resolution: Fixed
Merged this to trunk and 2.6 branch.
> Transaction
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163021#comment-17163021
]
Almog Gavra commented on KAFKA-8037:
There are lots of threads going on in this discussion, but re:
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163020#comment-17163020
]
John Roesler commented on KAFKA-8037:
-
Thanks [~ableegoldman] for the thoughts.
It seems like we're
junrao merged pull request #9026:
URL: https://github.com/apache/kafka/pull/9026
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jeffkbkim commented on a change in pull request #9050:
URL: https://github.com/apache/kafka/pull/9050#discussion_r459016030
##
File path:
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala
##
@@ -598,6 +603,86 @@ class ControllerIntegrationTest extends
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163012#comment-17163012
]
John Roesler commented on KAFKA-8037:
-
Thanks for the reply [~guozhang] . I think we're on the same
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163011#comment-17163011
]
Sophie Blee-Goldman edited comment on KAFKA-8037 at 7/22/20, 6:57 PM:
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163011#comment-17163011
]
Sophie Blee-Goldman commented on KAFKA-8037:
I'm tempted to agree with Matthias that
AshishRoyJava commented on pull request #9034:
URL: https://github.com/apache/kafka/pull/9034#issuecomment-662625368
Will add a unit test.
This is an automated message from the Apache Git Service.
To respond to the message,
niteshmor opened a new pull request #9058:
URL: https://github.com/apache/kafka/pull/9058
Jackson 2.10.5 is now available. This pull request is for updating the patch
from 2.10.**2** to 2.10.**5**.
This should also be cherry picked to older branches as well (at least 2.5
and above but
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163002#comment-17163002
]
Guozhang Wang commented on KAFKA-8037:
--
Hey guys thanks for your input.
I think [~vvcephei] has a
bob-barrett commented on a change in pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#discussion_r458994628
##
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##
@@ -563,4 +565,39 @@ class LogManagerTest {
bob-barrett commented on a change in pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#discussion_r458994628
##
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##
@@ -563,4 +565,39 @@ class LogManagerTest {
dhruvilshah3 commented on a change in pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#discussion_r458993555
##
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##
@@ -563,4 +565,39 @@ class LogManagerTest {
dhruvilshah3 commented on a change in pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#discussion_r458991075
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -978,6 +978,7 @@ class LogManager(logDirs: Seq[File],
[
https://issues.apache.org/jira/browse/KAFKA-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram resolved KAFKA-10164.
Fix Version/s: 2.7.0
Reviewer: Rajini Sivaram
Assignee: David Jacot
rajinisivaram merged pull request #8968:
URL: https://github.com/apache/kafka/pull/8968
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kkonstantine commented on pull request #9040:
URL: https://github.com/apache/kafka/pull/9040#issuecomment-662605383
Given this situation during startup, it makes sense. Thanks for the
additional details @gharris1727
This
jsancio commented on a change in pull request #9050:
URL: https://github.com/apache/kafka/pull/9050#discussion_r458979257
##
File path:
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala
##
@@ -598,6 +603,86 @@ class ControllerIntegrationTest extends
brbrown25 opened a new pull request #9057:
URL: https://github.com/apache/kafka/pull/9057
… of message key or value.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping
vvcephei commented on pull request #9053:
URL: https://github.com/apache/kafka/pull/9053#issuecomment-662594839
Thanks, all. I'll just revert (it's a cleaner way to unblock the release),
and if the test becomes flaky, then we'll deal with that separately.
rajinisivaram opened a new pull request #9056:
URL: https://github.com/apache/kafka/pull/9056
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
rajinisivaram opened a new pull request #9055:
URL: https://github.com/apache/kafka/pull/9055
Add description for return tags, remove link to internal `SslFactory` class.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
[
https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162968#comment-17162968
]
Paulo César commented on KAFKA-7025:
I my case i need min suporte in android 4.1(API 16) and 4.4(API
mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458965799
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -299,7 +318,17 @@ private void
chia7712 commented on pull request #9053:
URL: https://github.com/apache/kafka/pull/9053#issuecomment-662570081
It seems we have to set lower session timeout and then wait for group
expiration if the ```--force``` is not backport to 2.5. Or we can fix the
system test by calling
mjsax commented on a change in pull request #9052:
URL: https://github.com/apache/kafka/pull/9052#discussion_r458939593
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -412,6 +412,12 @@ private Topology
bob-barrett opened a new pull request #9054:
URL: https://github.com/apache/kafka/pull/9054
Currently, we remove the Log metrics when asynchronous deletion of the log
is triggered. However, we attempt to register the metrics immediately upon log
creation. If a Log object is re-created for
vvcephei commented on pull request #9053:
URL: https://github.com/apache/kafka/pull/9053#issuecomment-662558614
No worries, it wasn't your fault @chia7712 . It was mine, since I
cherry-picked it and didn't run the test again before pushing.
chia7712 commented on pull request #9053:
URL: https://github.com/apache/kafka/pull/9053#issuecomment-662558270
> I'm thinking we should just revert this commit to 2.5 to unblock the
release, and then @chia7712 can send a new PR targeted to 2.5 if he wants to.
+1 and sorry to use
1 - 100 of 125 matches
Mail list logo
