[
https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193444#comment-17193444
]
Akshesh Doshi commented on KAFKA-7870:
--
I have been observing similar logging for on
showuon commented on a change in pull request #9202:
URL: https://github.com/apache/kafka/pull/9202#discussion_r486159096
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -1401,24 +1401,20 @@ object GroupMetadataManager {
val ve
showuon commented on a change in pull request #9202:
URL: https://github.com/apache/kafka/pull/9202#discussion_r486161428
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
##
@@ -931,6 +932,42 @@ class GroupMetadataManagerTest {
showuon commented on a change in pull request #9202:
URL: https://github.com/apache/kafka/pull/9202#discussion_r486161428
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
##
@@ -931,6 +932,42 @@ class GroupMetadataManagerTest {
showuon commented on a change in pull request #9202:
URL: https://github.com/apache/kafka/pull/9202#discussion_r486162637
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
##
@@ -931,6 +932,42 @@ class GroupMetadataManagerTest {
showuon commented on pull request #9202:
URL: https://github.com/apache/kafka/pull/9202#issuecomment-690082467
@ijuma , thanks for your good comments/suggestions. I've updated in this
commit:
https://github.com/apache/kafka/pull/9202/commits/f01aaa643840c871d613c9e0af538b79519f2667.
Thank
[
https://issues.apache.org/jira/browse/KAFKA-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193467#comment-17193467
]
Justin Jack commented on KAFKA-7641:
This change will require a KIP as it is a public
[
https://issues.apache.org/jira/browse/KAFKA-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193467#comment-17193467
]
Justin Jack edited comment on KAFKA-7641 at 9/10/20, 8:44 AM:
-
showuon commented on a change in pull request #9202:
URL: https://github.com/apache/kafka/pull/9202#discussion_r486161428
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
##
@@ -931,6 +932,42 @@ class GroupMetadataManagerTest {
Bozhidar Bozhanov created KAFKA-10474:
-
Summary: Kafka Java client introduces CPU overhead when there are
many consumers
Key: KAFKA-10474
URL: https://issues.apache.org/jira/browse/KAFKA-10474
Pro
[
https://issues.apache.org/jira/browse/KAFKA-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bozhidar Bozhanov updated KAFKA-10474:
--
Description:
We are using the Kafka Java client (version 2.4.1) and we started noticin
[
https://issues.apache.org/jira/browse/KAFKA-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bozhidar Bozhanov updated KAFKA-10474:
--
Issue Type: Improvement (was: Bug)
> Kafka Java client introduces CPU overhead when t
[
https://issues.apache.org/jira/browse/KAFKA-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bozhidar Bozhanov updated KAFKA-10474:
--
Description:
We are using the Kafka Java client (version 2.4.1) and we started noticin
Saad Rasool created KAFKA-10475:
---
Summary: Using same key reports different count of records for
groupBy() and groupByKey() in Kafka Streaming Application
Key: KAFKA-10475
URL: https://issues.apache.org/jira/browse/
[
https://issues.apache.org/jira/browse/KAFKA-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Saad Rasool updated KAFKA-10475:
Description:
We are experiencing what amounts to “lost packets” in our stream processing
when
[
https://issues.apache.org/jira/browse/KAFKA-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Saad Rasool updated KAFKA-10475:
Description:
We are experiencing what amounts to “lost packets” in our stream processing
when
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486266547
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -354,12 +354,24 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486266701
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -354,12 +354,24 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486267744
##
File path: core/src/main/scala/kafka/server/checkpoints/CheckpointFile.scala
##
@@ -75,6 +75,17 @@ class CheckpointReadBuffer[T](location: String,
}
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-690200951
@junrao , thanks for your comments. I've updated in this commit:
https://github.com/apache/kafka/pull/9178/commits/5320318eec5cdb938cafd385f45525472370d359.
Thanks.
[
https://issues.apache.org/jira/browse/KAFKA-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Saad Rasool updated KAFKA-10475:
Description:
We are experiencing what amounts to “lost packets” in our stream processing
when
dongjinleekr commented on pull request #8117:
URL: https://github.com/apache/kafka/pull/8117#issuecomment-690303190
Rebased onto the latest trunk.
@vvcephei Could you have a look? It this implementation is okay, then I will
open the vote.
cc/ @mjsax @bbejeck
dongjinleekr commented on pull request #8150:
URL: https://github.com/apache/kafka/pull/8150#issuecomment-690305103
Rebased onto the latest trunk.
@bbejeck Could you kindly include this PR into the 2.7.0 plan?
This is
dongjinleekr commented on pull request #8130:
URL: https://github.com/apache/kafka/pull/8130#issuecomment-690310769
@mjsax Could this PR get it into 2.7? :smiley:
This is an automated message from the Apache Git Service.
To r
bbejeck commented on pull request #8117:
URL: https://github.com/apache/kafka/pull/8117#issuecomment-690354142
>@vvcephei Could you have a look? It this implementation is okay, then I
will open the vote.
@dongjinleekr you don't have the implementation completed to call for a
vote.
bbejeck commented on pull request #8117:
URL: https://github.com/apache/kafka/pull/8117#issuecomment-690354249
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log o
junrao merged pull request #9278:
URL: https://github.com/apache/kafka/pull/9278
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059076#comment-17059076
]
Matthias J. Sax edited comment on KAFKA-9584 at 9/10/20, 4:10 PM:
-
mjsax commented on a change in pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#discussion_r486466006
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -581,8 +580,8 @@ public void punctuate(final Processor
vvcephei commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-690520951
Hi all,
It seems like this KIP is relevant here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-634%3A+Complementary+support+for+headers+in+Kafka+Streams+DSL
-
mjsax commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-690523753
I don't see the connection to the KIP? The issue is with `punctuate` from my
understanding while the KIP is about the DSL?
-
junrao commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486454693
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -354,12 +354,30 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r486521810
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -255,6 +265,15 @@ class Partition(val topicPartition: TopicPartition,
def isAdding
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r486521810
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -255,6 +265,15 @@ class Partition(val topicPartition: TopicPartition,
def isAdding
MicahRam commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-690582299
I use the DSL almost exclusively so the KIP is written up from that
perspective but I agree the problem is with punctuate.
-
hachikuji commented on pull request #9275:
URL: https://github.com/apache/kafka/pull/9275#issuecomment-690583324
Note this patch includes #9277. I will rebase once it is merged.
This is an automated message from the Apache Gi
MicahRam edited a comment on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-690582299
I use the DSL almost exclusively and perform stateful transformations using
transform from process and punctuate so the KIP is written up from that
perspective but I agree
MicahRam removed a comment on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-690582299
I use the DSL almost exclusively and perform stateful transformations using
transform from process and punctuate so the KIP is written up from that
perspective but I agre
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r486535166
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1210,19 +1243,66 @@ class Partition(val topicPartition: TopicPartition,
}
}
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r486535166
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1210,19 +1243,66 @@ class Partition(val topicPartition: TopicPartition,
}
}
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r486535166
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1210,19 +1243,66 @@ class Partition(val topicPartition: TopicPartition,
}
}
mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r486535868
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1210,19 +1243,66 @@ class Partition(val topicPartition: TopicPartition,
}
}
cmccabe commented on pull request #9274:
URL: https://github.com/apache/kafka/pull/9274#issuecomment-690623624
Looks good. LGTM pending a system test run
This is an automated message from the Apache Git Service.
To respond t
vvcephei commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r486589243
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -242,7 +242,8 @@ public ByteBuffer su
dielhennr edited a comment on pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305
Hey @jsancio ,
I added some work in progress to this branch including new APIs for this
feature. Fitting user and client-id into the `DescribeConfigs` API was awkw
dielhennr edited a comment on pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305
Hey @jsancio ,
I added some work in progress to this branch including new APIs for this
feature. Fitting user and client-id into the `DescribeConfigs` API was awkw
hachikuji commented on pull request #9277:
URL: https://github.com/apache/kafka/pull/9277#issuecomment-690706923
One flaky failure which is fixed by #9091. Will merge to trunk.
This is an automated message from the Apache Git
hachikuji commented on pull request #9091:
URL: https://github.com/apache/kafka/pull/9091#issuecomment-690710072
I rebased and tested locally. Merging to trunk.
This is an automated message from the Apache Git Service.
To res
hachikuji merged pull request #9277:
URL: https://github.com/apache/kafka/pull/9277
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hachikuji merged pull request #9091:
URL: https://github.com/apache/kafka/pull/9091
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-10311.
-
Resolution: Fixed
> Flaky test KafkaAdminClientTest#testMetadataRetries
> --
hachikuji opened a new pull request #9279:
URL: https://github.com/apache/kafka/pull/9279
This patch fixes two problems in the use of common structs:
- `JsonConverterGenerator` does not account for common structs
- `SchemaGenerator` class generated inline structs before common stru
vvcephei commented on pull request #9267:
URL: https://github.com/apache/kafka/pull/9267#issuecomment-690717248
Test failures were unrelated:
```
Build / JDK 8 /
kafka.network.ConnectionQuotasTest.testNoConnectionLimitsByDefault
Build / JDK 8 /
kafka.network.ConnectionQuot
vvcephei merged pull request #9267:
URL: https://github.com/apache/kafka/pull/9267
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ableegoldman commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486619734
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -205,32 +221,67 @@ public void
guozhangwang merged pull request #8834:
URL: https://github.com/apache/kafka/pull/8834
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r486644110
##
File path: streams/src/main/resources/common/message/SubscriptionInfoData.json
##
@@ -48,6 +48,11 @@
"versions": "2+",
"type": "bytes"
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r486644110
##
File path: streams/src/main/resources/common/message/SubscriptionInfoData.json
##
@@ -48,6 +48,11 @@
"versions": "2+",
"type": "bytes"
lct45 commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486673070
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -78,16 +100,28 @@
public voi
[
https://issues.apache.org/jira/browse/KAFKA-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-9584:
--
Assignee: Micah Ramos
> Removing headers causes ConcurrentModificationException
>
mjsax commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-690777637
@MicahRam Are you still interested in fixing this issue? So we can throw an
informative exception that explains users that the call they try to make is not
allowed?
--
ijuma commented on pull request #9231:
URL: https://github.com/apache/kafka/pull/9231#issuecomment-690779853
Rebased to fix a trivial conflict. JDK 11 and JDK 8 builds passed, JDK 15
failed with 2 unrelated flaky test failures:
>
kafka.network.DynamicConnectionQuotaTest.testDynamicL
ijuma merged pull request #9231:
URL: https://github.com/apache/kafka/pull/9231
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ableegoldman commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486684145
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -78,16 +100,28 @@
pub
guozhangwang commented on pull request #9264:
URL: https://github.com/apache/kafka/pull/9264#issuecomment-690810621
LGTM!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
guozhangwang commented on pull request #8834:
URL: https://github.com/apache/kafka/pull/8834#issuecomment-690810983
Cherry-picked to 2.6
This is an automated message from the Apache Git Service.
To respond to the message, ple
vvcephei commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486742113
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -877,4 +1003,56 @@ private voi
vvcephei commented on pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#issuecomment-690843020
It looks like now that PR builds are working again, we can get back to
ignoring flaky tests ;)
```
Build / JDK 8 /
kafka.server.LeaderElectionTest.testLeaderElectio
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486747077
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -354,12 +354,30 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486747159
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -355,22 +355,28 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486747592
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -390,9 +396,9 @@ private[log] class LogCleanerManager(val logDirs: Seq[File],
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486747592
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -390,9 +396,9 @@ private[log] class LogCleanerManager(val logDirs: Seq[File],
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486749618
##
File path:
core/src/main/scala/kafka/server/checkpoints/LeaderEpochCheckpointFile.scala
##
@@ -52,8 +52,16 @@ object LeaderEpochCheckpointFile {
}
/
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486750612
##
File path: core/src/main/scala/kafka/log/LogCleaner.scala
##
@@ -203,16 +203,24 @@ class LogCleaner(initialConfig: CleanerConfig,
}
/**
- * Upd
ableegoldman commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486750661
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KGroupedStreamImplTest.java
##
@@ -239,52 +241,81 @@ private void doCou
ableegoldman commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486751006
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -78,16 +100,28 @@
pub
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486751134
##
File path: core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala
##
@@ -361,6 +366,93 @@ class LogCleanerManagerTest extends Logging {
asse
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486751046
##
File path: core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala
##
@@ -55,7 +59,8 @@ class LogCleanerManagerTest extends Logging {
clean
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486751738
##
File path: core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala
##
@@ -361,6 +366,93 @@ class LogCleanerManagerTest extends Logging {
asse
ableegoldman commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486753195
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SuppressScenarioTest.java
##
@@ -493,52 +494,59 @@ public void shouldSu
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486751738
##
File path: core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala
##
@@ -361,6 +366,93 @@ class LogCleanerManagerTest extends Logging {
asse
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399
@junrao , thanks for the good comments. I've updated in this commit:
https://github.com/apache/kafka/pull/9178/commits/c7f436292209f1778f9455421f67fd81eea81f21.
Thanks.
guozhangwang merged pull request #9264:
URL: https://github.com/apache/kafka/pull/9264
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193988#comment-17193988
]
Guozhang Wang commented on KAFKA-10465:
---
Hello [~manme...@gmail.com] what's docume
chia7712 commented on pull request #9223:
URL: https://github.com/apache/kafka/pull/9223#issuecomment-690883668
```
kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota
```
pass on my local.
--
chia7712 commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-690884676
```
Build / JDK 11 /
kafka.api.PlaintextConsumerTest.testLowMaxFetchSizeForRequestAndPartition
```
pass on my local
```
Build / JDK 15 /
org.apache.kafka.clien
xakassi commented on a change in pull request #9211:
URL: https://github.com/apache/kafka/pull/9211#discussion_r478325832
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##
@@ -733,10 +734,11 @@ public void onCompletion
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-690907900
@ryannedolan @mimaison when possible, very appreciated for your attentions
and feedback :) Thanks
This is an
[
https://issues.apache.org/jira/browse/KAFKA-10413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194047#comment-17194047
]
Florian Rossier commented on KAFKA-10413:
-
Hi,
We are also affected by this is
89 matches
Mail list logo
