vgvineet4 commented on pull request #9254:
URL: https://github.com/apache/kafka/pull/9254#issuecomment-691447099
@ijuma Please have a look
This is an automated message from the Apache Git Service.
To respond to the message,
nym3r0s commented on a change in pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#discussion_r487394821
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##
@@ -418,10 +419,14 @@ private boolean maybeSendAndPollTransa
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691464378
@ableegoldman - you're right. I've missed out the license header. I'll also
add the tests for the change. thank you 🙂
bbejeck merged pull request #9208:
URL: https://github.com/apache/kafka/pull/9208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
bbejeck commented on pull request #9208:
URL: https://github.com/apache/kafka/pull/9208#issuecomment-691477282
Thanks for the contribution @khaireddine120!
This is an automated message from the Apache Git Service.
To respond
bbejeck commented on pull request #9208:
URL: https://github.com/apache/kafka/pull/9208#issuecomment-691477247
This PR is minor changes for streams. I ran the tests locally, so I merging
this.
This is an automated message f
bbejeck commented on pull request #9209:
URL: https://github.com/apache/kafka/pull/9209#issuecomment-691479008
This is a minor PR fix, I ran the tests locally, all passed so I'm merging
this.
This is an automated message fro
bbejeck commented on pull request #9209:
URL: https://github.com/apache/kafka/pull/9209#issuecomment-691479180
Thanks @khaireddine120 for the clean-up!
This is an automated message from the Apache Git Service.
To respond to t
bbejeck merged pull request #9209:
URL: https://github.com/apache/kafka/pull/9209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
bbejeck merged pull request #9207:
URL: https://github.com/apache/kafka/pull/9207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481266
Minor cleanup, I ran the tests locally and all passed, merging this now.
This is an automated message from the Apa
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481426
Thanks for the cleanup @khaireddine120!
This is an automated message from the Apache Git Service.
To respond to th
showuon commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691495483
Merge the latest trunk to have auto test.
This is an automated message from the Apache Git Service.
To respond to
asdaraujo opened a new pull request #9281:
URL: https://github.com/apache/kafka/pull/9281
Remove the requirement for unique port numbers for the advertised.listener
parameters.
This restriction makes for the listeners parameter but there's not reason to
apply the
same logic for adver
DOJI45 commented on a change in pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#discussion_r487431539
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -662,4 +662,10 @@ public TopicPartition
r
DOJI45 commented on a change in pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#discussion_r487431637
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -332,6 +332,15 @@ public void resume() {
lct45 commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r487110043
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -131,14 +157,15 @@ public void te
xakassi commented on a change in pull request #9211:
URL: https://github.com/apache/kafka/pull/9211#discussion_r478325832
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##
@@ -733,10 +734,11 @@ public void onCompletion
vvcephei commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486742113
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -877,4 +1003,56 @@ private voi
showuon commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691495483
Merge the latest trunk to have auto test.
This is an automated message from the Apache Git Service.
To respond to
vvcephei merged pull request #9239:
URL: https://github.com/apache/kafka/pull/9239
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on pull request #9223:
URL: https://github.com/apache/kafka/pull/9223#issuecomment-690883668
```
kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota
```
pass on my local.
--
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691058386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
bbejeck merged pull request #9208:
URL: https://github.com/apache/kafka/pull/9208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ableegoldman commented on a change in pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#discussion_r487336115
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##
@@ -418,10 +419,14 @@ private boolean maybeSendAndPollT
ableegoldman commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691357934
Also, looks like there were checkstyle issues. Probably you just need to add
the license header to the new file
-
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
bbejeck merged pull request #9209:
URL: https://github.com/apache/kafka/pull/9209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
DOJI45 commented on a change in pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#discussion_r487431539
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -662,4 +662,10 @@ public TopicPartition
r
chia7712 commented on pull request #9271:
URL: https://github.com/apache/kafka/pull/9271#issuecomment-691397979
```
失敗
Build / JDK 8 /
org.apache.kafka.clients.admin.KafkaAdminClientTest.testMetadataRetries
```
it is already fixed by
https://github.com/apache/kafka/commit/e4eab
ableegoldman commented on pull request #8892:
URL: https://github.com/apache/kafka/pull/8892#issuecomment-691358663
Alright this should finally be ready for a final pass and merge @vvcephei
@cadonna -- sorry for leaving this hanging for so long.
After running a few different tests,
bbejeck commented on pull request #9209:
URL: https://github.com/apache/kafka/pull/9209#issuecomment-691479008
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
mjsax commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487166164
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableAggregate.java
##
@@ -47,8 +47,10 @@
}
@Override
-public
MicahRam commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691315131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
mjsax commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691339633
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
vvcephei commented on pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#issuecomment-690843020
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
guozhangwang commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691389142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
chia7712 commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-690884676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
ableegoldman commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486750661
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KGroupedStreamImplTest.java
##
@@ -239,52 +241,81 @@ private void doCou
guozhangwang merged pull request #9264:
URL: https://github.com/apache/kafka/pull/9264
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jeqo commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-691045209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
guozhangwang commented on pull request #8834:
URL: https://github.com/apache/kafka/pull/8834#issuecomment-690810983
Cherry-picked to 2.6
This is an automated message from the Apache Git Service.
To respond to the message, ple
bbejeck commented on pull request #9208:
URL: https://github.com/apache/kafka/pull/9208#issuecomment-691477247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
tombentley commented on pull request #9266:
URL: https://github.com/apache/kafka/pull/9266#issuecomment-690954007
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
MicahRam edited a comment on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691315131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
nym3r0s commented on a change in pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#discussion_r487394821
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##
@@ -418,10 +419,14 @@ private boolean maybeSendAndPollTransa
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487049443
##
File path:
clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java
##
@@ -17,11 +17,12 @@
package org.apache
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486747077
##
File path: core/src/main/scala/kafka/log/LogCleanerManager.scala
##
@@ -354,12 +354,30 @@ private[log] class LogCleanerManager(val logDirs:
Seq[File],
mjsax commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r487321249
##
File path: clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
##
@@ -784,4 +787,39 @@ public void testCloseAllQuietly() {
assertEq
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-690907900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
vgvineet4 commented on pull request #9254:
URL: https://github.com/apache/kafka/pull/9254#issuecomment-691447099
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bbejeck merged pull request #9207:
URL: https://github.com/apache/kafka/pull/9207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xakassi commented on a change in pull request #9211:
URL: https://github.com/apache/kafka/pull/9211#discussion_r478325832
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##
@@ -733,10 +734,11 @@ public void onCompletion
showuon commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691495483
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
vvcephei commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486742113
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -877,4 +1003,56 @@ private voi
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691058386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
chia7712 commented on pull request #9223:
URL: https://github.com/apache/kafka/pull/9223#issuecomment-690883668
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
bbejeck merged pull request #9208:
URL: https://github.com/apache/kafka/pull/9208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ableegoldman commented on pull request #8892:
URL: https://github.com/apache/kafka/pull/8892#issuecomment-691358663
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
ableegoldman commented on a change in pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#discussion_r487336115
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##
@@ -418,10 +419,14 @@ private boolean maybeSendAndPollT
ableegoldman commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691357934
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
showuon commented on pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#issuecomment-690856399
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
bbejeck merged pull request #9209:
URL: https://github.com/apache/kafka/pull/9209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on pull request #9271:
URL: https://github.com/apache/kafka/pull/9271#issuecomment-691397979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
DOJI45 commented on a change in pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#discussion_r487431539
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -662,4 +662,10 @@ public TopicPartition
r
bbejeck commented on pull request #9209:
URL: https://github.com/apache/kafka/pull/9209#issuecomment-691479008
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
mjsax commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487166164
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableAggregate.java
##
@@ -47,8 +47,10 @@
}
@Override
-public
MicahRam commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691315131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
tombentley commented on pull request #9266:
URL: https://github.com/apache/kafka/pull/9266#issuecomment-690954007
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
mjsax commented on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691339633
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ableegoldman commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486750661
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KGroupedStreamImplTest.java
##
@@ -239,52 +241,81 @@ private void doCou
chia7712 commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-690884676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
vvcephei commented on pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#issuecomment-691224736
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
guozhangwang commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691389142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
guozhangwang merged pull request #9264:
URL: https://github.com/apache/kafka/pull/9264
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jeqo commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-691045209
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
bbejeck commented on pull request #9208:
URL: https://github.com/apache/kafka/pull/9208#issuecomment-691477247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
MicahRam edited a comment on pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#issuecomment-691315131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
nym3r0s commented on a change in pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#discussion_r487394821
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
##
@@ -418,10 +419,14 @@ private boolean maybeSendAndPollTransa
big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487049443
##
File path:
clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java
##
@@ -17,11 +17,12 @@
package org.apache
mjsax commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r487321249
##
File path: clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
##
@@ -784,4 +787,39 @@ public void testCloseAllQuietly() {
assertEq
showuon commented on a change in pull request #9178:
URL: https://github.com/apache/kafka/pull/9178#discussion_r486750612
##
File path: core/src/main/scala/kafka/log/LogCleaner.scala
##
@@ -203,16 +203,24 @@ class LogCleaner(initialConfig: CleanerConfig,
}
/**
- * Upd
lct45 commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r487110043
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -131,14 +157,15 @@ public void te
xakassi commented on a change in pull request #9211:
URL: https://github.com/apache/kafka/pull/9211#discussion_r478325832
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##
@@ -733,10 +734,11 @@ public void onCompletion
vvcephei merged pull request #9239:
URL: https://github.com/apache/kafka/pull/9239
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vvcephei commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r487170646
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##
@@ -131,14 +157,15 @@ public void
showuon commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-691495483
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
ableegoldman commented on pull request #8892:
URL: https://github.com/apache/kafka/pull/8892#issuecomment-691358663
Alright this should finally be ready for a final pass and merge @vvcephei
@cadonna -- sorry for leaving this hanging for so long.
After running a few different tests,
chia7712 commented on pull request #9223:
URL: https://github.com/apache/kafka/pull/9223#issuecomment-690883668
```
kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota
```
pass on my local.
--
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691058386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
bbejeck merged pull request #9208:
URL: https://github.com/apache/kafka/pull/9208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-690907900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
bbejeck merged pull request #9207:
URL: https://github.com/apache/kafka/pull/9207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vgvineet4 commented on pull request #9254:
URL: https://github.com/apache/kafka/pull/9254#issuecomment-691447099
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on pull request #9250:
URL: https://github.com/apache/kafka/pull/9250#issuecomment-691600174
Could you add unit test?
This is an automated message from the Apache Git Service.
To respond to the message, ple
chia7712 commented on pull request #9250:
URL: https://github.com/apache/kafka/pull/9250#issuecomment-691601314
https://github.com/apache/kafka/blob/trunk/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java#L64
```
@Override
public
98 matches
Mail list logo