[GitHub] [kafka] hachikuji commented on a change in pull request #9579: KAFKA-9751: Forward CreateTopicsRequest for FindCoordinator/Metadata when topic creation is needed

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #9579: URL: https://github.com/apache/kafka/pull/9579#discussion_r571362924 ## File path: core/src/main/scala/kafka/server/AutoTopicCreationManager.scala ## @@ -169,6 +169,8 @@ class DefaultAutoTopicCreationManager( }

[GitHub] [kafka] showuon commented on pull request #10002: MINOR: remove the indent in security doc

2021-02-05 Thread GitBox
showuon commented on pull request #10002: URL: https://github.com/apache/kafka/pull/10002#issuecomment-774401866 @omkreddy , thanks for comments. I've updated. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] showuon commented on a change in pull request #10002: MINOR: remove the indent in security doc

2021-02-05 Thread GitBox
showuon commented on a change in pull request #10002: URL: https://github.com/apache/kafka/pull/10002#discussion_r571361102 ## File path: docs/security.html ## @@ -649,22 +649,22 @@ Configuring Kafka Brokers Add a suitably modified JAAS file similar

[GitHub] [kafka] C0urante opened a new pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

2021-02-05 Thread GitBox
C0urante opened a new pull request #10074: URL: https://github.com/apache/kafka/pull/10074 [Jira](https://issues.apache.org/jira/browse/KAFKA-12305) (Copied from Jira): The `Flatten` SMT fails for array types. A sophisticated approach that tries to flatten arrays might be

[jira] [Updated] (KAFKA-12305) Flatten SMT fails on arrays

2021-02-05 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-12305: -- Description: The {{Flatten}} SMT fails for array types. A sophisticated approach that tries

[jira] [Created] (KAFKA-12305) Flatten SMT fails on arrays

2021-02-05 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-12305: - Summary: Flatten SMT fails on arrays Key: KAFKA-12305 URL: https://issues.apache.org/jira/browse/KAFKA-12305 Project: Kafka Issue Type: Bug

[GitHub] [kafka] C0urante opened a new pull request #10073: KAFKA-12303: Fix handling of null values by Flatten SMT

2021-02-05 Thread GitBox
C0urante opened a new pull request #10073: URL: https://github.com/apache/kafka/pull/10073 [Jira](https://issues.apache.org/jira/browse/KAFKA-12303) Using `return` instead of `continue` when encountering null fields causes the remainder of the fields to be skipped. This PR addresses

[jira] [Created] (KAFKA-12304) Improve topic validation in auto topic creation

2021-02-05 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-12304: --- Summary: Improve topic validation in auto topic creation Key: KAFKA-12304 URL: https://issues.apache.org/jira/browse/KAFKA-12304 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-12303) Flatten SMT drops some fields when null values are present

2021-02-05 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-12303: -- Summary: Flatten SMT drops some fields when null values are present (was: Flatten SMT drops

[jira] [Created] (KAFKA-12303) Flatten SMT drops some nested fields

2021-02-05 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-12303: - Summary: Flatten SMT drops some nested fields Key: KAFKA-12303 URL: https://issues.apache.org/jira/browse/KAFKA-12303 Project: Kafka Issue Type: Bug

[GitHub] [kafka] mjsax merged pull request #10000: KAFKA-9274: handle TimeoutException on task reset

2021-02-05 Thread GitBox
mjsax merged pull request #1: URL: https://github.com/apache/kafka/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax commented on a change in pull request #10072: KAFKA-9274: Throw TaskCorruptedException instead of TimeoutException when TX commit times out

2021-02-05 Thread GitBox
mjsax commented on a change in pull request #10072: URL: https://github.com/apache/kafka/pull/10072#discussion_r571331549 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java ## @@ -32,6 +33,7 @@ public final int topicGroupId; /** The ID

[GitHub] [kafka] cmccabe merged pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
cmccabe merged pull request #10049: URL: https://github.com/apache/kafka/pull/10049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ableegoldman commented on a change in pull request #10000: KAFKA-9274: handle TimeoutException on task reset

2021-02-05 Thread GitBox
ableegoldman commented on a change in pull request #1: URL: https://github.com/apache/kafka/pull/1#discussion_r571317298 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -229,17 +231,22 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #10072: KAFKA-9274: Throw TaskCorruptedException instead of TimeoutException when TX commit times out

2021-02-05 Thread GitBox
ableegoldman commented on a change in pull request #10072: URL: https://github.com/apache/kafka/pull/10072#discussion_r571317046 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java ## @@ -32,6 +33,7 @@ public final int topicGroupId; /**

[jira] [Commented] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key

2021-02-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280044#comment-17280044 ] Matthias J. Sax commented on KAFKA-12213: - Works for me. Just wanted to point out, that

[GitHub] [kafka] mjsax opened a new pull request #10072: KAFKA-9274: Throw TaskCorruptedException instead of TimeoutException when TX commit times out

2021-02-05 Thread GitBox
mjsax opened a new pull request #10072: URL: https://github.com/apache/kafka/pull/10072 Part of KIP-572: follow up work to PR #9800. It's not save to retry a TX commit after a timeout, because it's unclear if the commit was successful or not, and thus on retry we might get an

[GitHub] [kafka] rondagostino commented on a change in pull request #10069: MINOR: Add RaftReplicaManager

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10069: URL: https://github.com/apache/kafka/pull/10069#discussion_r571309365 ## File path: core/src/main/scala/kafka/server/RaftReplicaManager.scala ## @@ -0,0 +1,538 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] rondagostino commented on a change in pull request #10069: MINOR: Add RaftReplicaManager

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10069: URL: https://github.com/apache/kafka/pull/10069#discussion_r571237871 ## File path: core/src/main/scala/kafka/server/RaftReplicaManager.scala ## @@ -0,0 +1,538 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Assigned] (KAFKA-9195) Use Randomized State Directory Names in Streams System Tests

2021-02-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9195: -- Assignee: Matthias J. Sax > Use Randomized State Directory Names in Streams System

[jira] [Comment Edited] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key

2021-02-05 Thread Piotr Fras (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280034#comment-17280034 ] Piotr Fras edited comment on KAFKA-12213 at 2/5/21, 11:09 PM: -- I am going

[jira] [Commented] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key

2021-02-05 Thread Piotr Fras (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280034#comment-17280034 ] Piotr Fras commented on KAFKA-12213: I am going to break down KIP-149 into five streams of work and

[jira] [Comment Edited] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key

2021-02-05 Thread Piotr Fras (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280034#comment-17280034 ] Piotr Fras edited comment on KAFKA-12213 at 2/5/21, 11:02 PM: -- I am going

[jira] [Resolved] (KAFKA-10678) Re-deploying Streams app causes rebalance and task migration

2021-02-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-10678. Assignee: A. Sophie Blee-Goldman Resolution: Fixed Resolved via

[jira] [Updated] (KAFKA-10678) Re-deploying Streams app causes rebalance and task migration

2021-02-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-10678: --- Fix Version/s: 2.6.2 2.7.1 2.8.0 >

[jira] [Commented] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key

2021-02-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280030#comment-17280030 ] Matthias J. Sax commented on KAFKA-12213: - It's totally fine to implement it incrementally

[jira] [Updated] (KAFKA-12288) Remove task-level filesystem locks

2021-02-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12288: Component/s: streams > Remove task-level filesystem locks >

[GitHub] [kafka] hachikuji commented on pull request #9579: KAFKA-9751: Forward CreateTopicsRequest for FindCoordinator/Metadata when topic creation is needed

2021-02-05 Thread GitBox
hachikuji commented on pull request #9579: URL: https://github.com/apache/kafka/pull/9579#issuecomment-774326674 @abbccdda Thanks for the updates. I opened a PR with a few fixes to speed this along since we're trying to get it checked in today: https://github.com/abbccdda/kafka/pull/6.

[GitHub] [kafka] rondagostino commented on a change in pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10039: URL: https://github.com/apache/kafka/pull/10039#discussion_r571283864 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -352,13 +348,15 @@ class LogManager(logDirs: Seq[File], val

[GitHub] [kafka] rondagostino commented on a change in pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10039: URL: https://github.com/apache/kafka/pull/10039#discussion_r571283864 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -352,13 +348,15 @@ class LogManager(logDirs: Seq[File], val

[GitHub] [kafka] rondagostino commented on a change in pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10039: URL: https://github.com/apache/kafka/pull/10039#discussion_r571278884 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -352,13 +348,15 @@ class LogManager(logDirs: Seq[File], val

[GitHub] [kafka] rondagostino commented on a change in pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10039: URL: https://github.com/apache/kafka/pull/10039#discussion_r571276941 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -403,7 +401,30 @@ class LogManager(logDirs: Seq[File], /** * Start the

[GitHub] [kafka] rondagostino commented on a change in pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10039: URL: https://github.com/apache/kafka/pull/10039#discussion_r571275654 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -403,7 +401,30 @@ class LogManager(logDirs: Seq[File], /** * Start the

[GitHub] [kafka] rondagostino commented on a change in pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10039: URL: https://github.com/apache/kafka/pull/10039#discussion_r571274481 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -403,7 +401,30 @@ class LogManager(logDirs: Seq[File], /** * Start the

[GitHub] [kafka] mumrah commented on a change in pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10039: URL: https://github.com/apache/kafka/pull/10039#discussion_r571268386 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -403,7 +401,30 @@ class LogManager(logDirs: Seq[File], /** * Start the

[jira] [Created] (KAFKA-12302) Flaky Test SaslApiVersionsRequestTest#testApiVersionsRequestWithUnsupportedVersion

2021-02-05 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12302: --- Summary: Flaky Test SaslApiVersionsRequestTest#testApiVersionsRequestWithUnsupportedVersion Key: KAFKA-12302 URL: https://issues.apache.org/jira/browse/KAFKA-12302

[jira] [Commented] (KAFKA-12284) Flaky Test MirrorConnectorsIntegrationSSLTest#testOneWayReplicationWithAutoOffsetSync

2021-02-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280008#comment-17280008 ] Matthias J. Sax commented on KAFKA-12284: - Failed again: 

[GitHub] [kafka] mumrah commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r571258754 ## File path: core/src/test/java/kafka/test/ClusterInstance.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a change in pull request #10069: MINOR: Add RaftReplicaManager

2021-02-05 Thread GitBox
ijuma commented on a change in pull request #10069: URL: https://github.com/apache/kafka/pull/10069#discussion_r571257684 ## File path: core/src/main/scala/kafka/server/DelayedDeleteRecords.scala ## @@ -84,7 +84,7 @@ class DelayedDeleteRecords(delayMs: Long,

[GitHub] [kafka] mumrah commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r571257075 ## File path: core/src/test/java/kafka/test/ClusterInstance.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571253465 ## File path: core/src/main/scala/kafka/server/metadata/RaftMetadataCache.scala ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-9527) Application Reset Tool Returns NPE when --to-datetime or --by-duration are run on --input-topics with empty partitions

2021-02-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1727#comment-1727 ] Matthias J. Sax commented on KAFKA-9527: Thanks everyone. I'll try to review the PR soon – but we

[GitHub] [kafka] cmccabe commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r571246502 ## File path: core/src/test/java/kafka/test/ClusterInstance.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] hachikuji merged pull request #10045: MINOR: Allow KafkaApis to be configured for Raft controller quorums

2021-02-05 Thread GitBox
hachikuji merged pull request #10045: URL: https://github.com/apache/kafka/pull/10045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] cmccabe commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r571245971 ## File path: core/src/test/java/kafka/test/ClusterInstance.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Created] (KAFKA-12301) Support for enum validation in configuration

2021-02-05 Thread Jeremy Custenborder (Jira)
Jeremy Custenborder created KAFKA-12301: --- Summary: Support for enum validation in configuration Key: KAFKA-12301 URL: https://issues.apache.org/jira/browse/KAFKA-12301 Project: Kafka

[GitHub] [kafka] cmccabe commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r571245403 ## File path: core/src/test/java/kafka/test/ClusterInstance.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan opened a new pull request #10071: KAFKA-12298: Create LeaderAndIsrRequestBenchmark

2021-02-05 Thread GitBox
jolshan opened a new pull request #10071: URL: https://github.com/apache/kafka/pull/10071 I thought it would be useful to check how the changes to LeaderAndIsrRequests (for KIP-516) affect the handling of the request. This benchmark builds a LeaderAndIsrRequest and calls

[GitHub] [kafka] cmccabe commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r571244427 ## File path: core/src/test/java/kafka/test/ClusterInstance.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r571242927 ## File path: core/src/test/java/kafka/test/ClusterConfig.java ## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r571241978 ## File path: core/src/test/java/kafka/test/annotation/Type.java ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Closed] (KAFKA-10716) Streams processId is unstable across restarts resulting in task mass migration

2021-02-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman closed KAFKA-10716. -- > Streams processId is unstable across restarts resulting in task mass migration

[GitHub] [kafka] ableegoldman commented on pull request #10060: KAFKA-10716: persist UUID in state directory for stable processId across restarts - 2.7

2021-02-05 Thread GitBox
ableegoldman commented on pull request #10060: URL: https://github.com/apache/kafka/pull/10060#issuecomment-774266721 Merged to 2.7 and cherrypicked to 2.6 This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] cmccabe commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571208259 ## File path: core/src/main/scala/kafka/server/metadata/MetadataBrokers.scala ## @@ -37,7 +36,15 @@ object MetadataBroker { endPoint.name() ->

[jira] [Created] (KAFKA-12300) Log source broker when handling metadata response

2021-02-05 Thread alex wang (Jira)
alex wang created KAFKA-12300: - Summary: Log source broker when handling metadata response Key: KAFKA-12300 URL: https://issues.apache.org/jira/browse/KAFKA-12300 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-9527) Application Reset Tool Returns NPE when --to-datetime or --by-duration are run on --input-topics with empty partitions

2021-02-05 Thread jbfletch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279941#comment-17279941 ] jbfletch commented on KAFKA-9527: - Thanks for taking this on [~marcolotz] > Application Reset Tool

[GitHub] [kafka] ableegoldman merged pull request #10060: KAFKA-10716: persist UUID in state directory for stable processId across restarts - 2.7

2021-02-05 Thread GitBox
ableegoldman merged pull request #10060: URL: https://github.com/apache/kafka/pull/10060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (KAFKA-12279) Kafka 2.7 stream app issue

2021-02-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-12279. Resolution: Not A Bug > Kafka 2.7 stream app issue >

[jira] [Commented] (KAFKA-12279) Kafka 2.7 stream app issue

2021-02-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279938#comment-17279938 ] A. Sophie Blee-Goldman commented on KAFKA-12279: Root cause: the source topic was

[GitHub] [kafka] rondagostino commented on a change in pull request #10045: MINOR: Allow KafkaApis to be configured for Raft controller quorums

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10045: URL: https://github.com/apache/kafka/pull/10045#discussion_r571174825 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3511,4 +3501,14 @@ object KafkaApis { FetchResponse.sizeOf(versionId,

[GitHub] [kafka] hachikuji commented on a change in pull request #10045: MINOR: Allow KafkaApis to be configured for Raft controller quorums

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10045: URL: https://github.com/apache/kafka/pull/10045#discussion_r571174163 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3511,4 +3501,14 @@ object KafkaApis { FetchResponse.sizeOf(versionId,

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571173703 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[jira] [Updated] (KAFKA-12299) Follow ups from MetadataCache changes

2021-02-05 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-12299: - Description: When merging the Raft MetadataCache changes for 2.8, we identified a few follow

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571173506 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[jira] [Created] (KAFKA-12299) Follow ups from MetadataCache changes

2021-02-05 Thread David Arthur (Jira)
David Arthur created KAFKA-12299: Summary: Follow ups from MetadataCache changes Key: KAFKA-12299 URL: https://issues.apache.org/jira/browse/KAFKA-12299 Project: Kafka Issue Type: Task

[GitHub] [kafka] cmccabe opened a new pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-05 Thread GitBox
cmccabe opened a new pull request #10070: URL: https://github.com/apache/kafka/pull/10070 The quorum controller stores metadata in the KIP-500 metadata log, not in Apache ZooKeeper. Each controller node is a voter in the metadata quorum. The leader of the quorum is the active

[GitHub] [kafka] hachikuji commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571169638 ## File path: core/src/main/scala/kafka/server/metadata/RaftMetadataCache.scala ## @@ -0,0 +1,389 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571163776 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -485,7 +494,7 @@ class MetadataCacheTest { @Test Review comment:

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571163226 ## File path: core/src/main/scala/kafka/server/metadata/MetadataBrokers.scala ## @@ -37,7 +36,15 @@ object MetadataBroker { endPoint.name() ->

[GitHub] [kafka] hachikuji commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571162641 ## File path: core/src/main/scala/kafka/server/metadata/RaftMetadataCache.scala ## @@ -0,0 +1,389 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571151499 ## File path: core/src/main/scala/kafka/server/metadata/MetadataImage.scala ## @@ -118,5 +118,10 @@ case class MetadataImage(partitions:

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571161027 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -16,20 +16,20 @@ */ package kafka.server +import

[GitHub] [kafka] hachikuji commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571149211 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[GitHub] [kafka] hachikuji commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571148172 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -16,20 +16,20 @@ */ package kafka.server +import

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571145320 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[GitHub] [kafka] hachikuji commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571142951 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571140218 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571139784 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[GitHub] [kafka] hachikuji commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571139392 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571138962 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -16,20 +16,20 @@ */ package kafka.server +import

[GitHub] [kafka] omkreddy commented on a change in pull request #10002: MINOR: remove the indent in security doc

2021-02-05 Thread GitBox
omkreddy commented on a change in pull request #10002: URL: https://github.com/apache/kafka/pull/10002#discussion_r571127207 ## File path: docs/security.html ## @@ -649,22 +649,22 @@ Configuring Kafka Brokers Add a suitably modified JAAS file similar

[GitHub] [kafka] rondagostino commented on a change in pull request #10045: MINOR: Allow KafkaApis to be configured for Raft controller quorums

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10045: URL: https://github.com/apache/kafka/pull/10045#discussion_r571124965 ## File path: core/src/main/scala/kafka/server/MetadataSupport.scala ## @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mumrah commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r571122210 ## File path: core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala ## @@ -16,83 +16,94 @@ */ package kafka.server +import

[GitHub] [kafka] cmccabe commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571119868 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -16,20 +16,20 @@ */ package kafka.server +import

[GitHub] [kafka] cmccabe commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571118214 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[GitHub] [kafka] cmccabe commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571116863 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[GitHub] [kafka] cmccabe commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r571116386 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -34,16 +34,69 @@ import

[GitHub] [kafka] cmccabe merged pull request #10008: MINOR: Remove ZK dependency for coordinator topics' partition counts

2021-02-05 Thread GitBox
cmccabe merged pull request #10008: URL: https://github.com/apache/kafka/pull/10008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 closed pull request #10050: MINOR: Don't assume number of dns results (stabilize ClusterConnectio…

2021-02-05 Thread GitBox
chia7712 closed pull request #10050: URL: https://github.com/apache/kafka/pull/10050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] chia7712 commented on pull request #10050: MINOR: Don't assume number of dns results (stabilize ClusterConnectio…

2021-02-05 Thread GitBox
chia7712 commented on pull request #10050: URL: https://github.com/apache/kafka/pull/10050#issuecomment-774149259 @mumrah Thanks for kind reminder. close this now. This is an automated message from the Apache Git Service. To

[jira] [Created] (KAFKA-12298) Create LeaderAndIsrRequestBenchmark

2021-02-05 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-12298: -- Summary: Create LeaderAndIsrRequestBenchmark Key: KAFKA-12298 URL: https://issues.apache.org/jira/browse/KAFKA-12298 Project: Kafka Issue Type: Task

[GitHub] [kafka] rondagostino opened a new pull request #10069: MINOR: Add RaftReplicaManager

2021-02-05 Thread GitBox
rondagostino opened a new pull request #10069: URL: https://github.com/apache/kafka/pull/10069 This adds the logic to apply partition metadata when consuming from the Raft-based metadata log. `RaftReplicaManager` extends `ReplicaManager` for now to minimize changes to existing code

[GitHub] [kafka] dajac commented on pull request #10068: MINOR: StopReplicaResp and StopReplicaReq Test should cover all available version

2021-02-05 Thread GitBox
dajac commented on pull request #10068: URL: https://github.com/apache/kafka/pull/10068#issuecomment-774140916 I've re-triggered Jenkins. I will merge once we have a clean run. This is an automated message from the Apache

[GitHub] [kafka] cmccabe commented on pull request #10008: MINOR: Remove ZK dependency for coordinator topics' partition counts

2021-02-05 Thread GitBox
cmccabe commented on pull request #10008: URL: https://github.com/apache/kafka/pull/10008#issuecomment-774136720 Failing tests are `org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testMultipleWorkersRejoining` and

[jira] [Updated] (KAFKA-12193) Re-resolve IPs when a client is disconnected

2021-02-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-12193: Fix Version/s: 2.6.2 > Re-resolve IPs when a client is disconnected >

[GitHub] [kafka] dajac commented on pull request #10061: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
dajac commented on pull request #10061: URL: https://github.com/apache/kafka/pull/10061#issuecomment-774097673 @ableegoldman FYI - We have backported this fix to 2.6. This is an automated message from the Apache Git Service.

[GitHub] [kafka] dajac merged pull request #10061: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
dajac merged pull request #10061: URL: https://github.com/apache/kafka/pull/10061 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-12274) Transactional operation fails when broker is replaced using the same broker ID.

2021-02-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Łukowicz updated KAFKA-12274: Description: Hello Team! One of our clusters is being used to: * process transactional

[GitHub] [kafka] mumrah commented on pull request #10050: MINOR: Don't assume number of dns results (stabilize ClusterConnectio…

2021-02-05 Thread GitBox
mumrah commented on pull request #10050: URL: https://github.com/apache/kafka/pull/10050#issuecomment-774082101 @chia7712 I think this got fixed yesterday on trunk with the addition of a new HostResolver interface. Now we can precisely control what IPs are resolved during testing.

[GitHub] [kafka] dajac commented on a change in pull request #9579: KAFKA-9751: Forward CreateTopicsRequest for FindCoordinator/Metadata when topic creation is needed

2021-02-05 Thread GitBox
dajac commented on a change in pull request #9579: URL: https://github.com/apache/kafka/pull/9579#discussion_r571004759 ## File path: core/src/main/scala/kafka/server/AutoTopicCreationManager.scala ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

  1   2   3   >