[jira] [Comment Edited] (KAFKA-12492) Formatting of example RocksDBConfigSetter is messed up

2021-04-01 Thread Ben Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313571#comment-17313571 ] Ben Chen edited comment on KAFKA-12492 at 4/2/21, 5:24 AM: --- We just need to

[jira] [Commented] (KAFKA-12492) Formatting of example RocksDBConfigSetter is messed up

2021-04-01 Thread Ben Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313571#comment-17313571 ] Ben Chen commented on KAFKA-12492: -- We just need to update the spaces within the section in that html.

[jira] [Commented] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

2021-04-01 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313560#comment-17313560 ] Konstantine Karantasis commented on KAFKA-12283: This is a corner case that appears

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313557#comment-17313557 ] Jamie Brandon commented on KAFKA-12594: --- This repros consistently on my laptop (nixos) and on

[GitHub] [kafka] ccding edited a comment on pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding edited a comment on pull request #10405: URL: https://github.com/apache/kafka/pull/10405#issuecomment-812293654 Ran `bin/kafka-producer-perf-test.sh` with default settings and 1KB record size. The result before applying this PR: ``` 1205625 records sent, 241125.0

[GitHub] [kafka] ccding commented on pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on pull request #10405: URL: https://github.com/apache/kafka/pull/10405#issuecomment-812293654 Ran `bin/kafka-producer-perf-test.sh` with default settings and 1KB record size. The result before applying this PR: ``` 1205625 records sent, 241125.0 records/sec

[jira] [Comment Edited] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313514#comment-17313514 ] Jamie Brandon edited comment on KAFKA-12594 at 4/2/21, 2:41 AM: I needed

[GitHub] [kafka] ccding edited a comment on pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding edited a comment on pull request #10405: URL: https://github.com/apache/kafka/pull/10405#issuecomment-812282452 Fixed comments from @junrao Also addressed the two problems we discussed offline: - flush the parent of new segments during its first flush: added the

[GitHub] [kafka] ccding commented on pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on pull request #10405: URL: https://github.com/apache/kafka/pull/10405#issuecomment-812282452 Fixed comments from @junrao Also addressed the two problems we discussed offline: - flush the parent of new segments during its first flush: added the

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r606040867 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -424,21 +439,22 @@ public static FileRecords open(File file,

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r606040591 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -95,6 +97,9 @@ class LogSegment private[log] (val log: FileRecords, /* the number of

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r606040360 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -59,7 +60,8 @@ class LogSegment private[log] (val log: FileRecords,

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r606040117 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -433,7 +440,8 @@ public static FileRecords open(File file,

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r606039773 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -95,6 +97,9 @@ class LogSegment private[log] (val log: FileRecords, /* the number of

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r606039455 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -657,17 +668,19 @@ class LogSegment private[log] (val log: FileRecords, object

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313518#comment-17313518 ] Jamie Brandon commented on KAFKA-12594: --- It seems like they both read the data. {code:bash}

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313514#comment-17313514 ] Jamie Brandon commented on KAFKA-12594: --- I needed `strace -f` - there was some wrapper script.

[GitHub] [kafka] hachikuji commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r606034496 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java ## @@ -181,20 +212,36 @@ public boolean isDone() {

[GitHub] [kafka] hachikuji commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r606034496 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java ## @@ -181,20 +212,36 @@ public boolean isDone() {

[jira] [Updated] (KAFKA-12606) Some improvements for produce record validation

2021-04-01 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12606: Labels: needs-kip (was: ) > Some improvements for produce record validation >

[jira] [Created] (KAFKA-12606) Some improvements for produce record validation

2021-04-01 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12606: --- Summary: Some improvements for produce record validation Key: KAFKA-12606 URL: https://issues.apache.org/jira/browse/KAFKA-12606 Project: Kafka Issue

[jira] [Comment Edited] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313505#comment-17313505 ] Jamie Brandon edited comment on KAFKA-12594 at 4/2/21, 1:54 AM:

[jira] [Comment Edited] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313505#comment-17313505 ] Jamie Brandon edited comment on KAFKA-12594 at 4/2/21, 1:50 AM:

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313505#comment-17313505 ] Jamie Brandon commented on KAFKA-12594: --- {code:bash} jamie@machine:~$ ps aux | grep java | grep

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313504#comment-17313504 ] Jamie Brandon commented on KAFKA-12594: --- Btw the repo at

[GitHub] [kafka] cmccabe merged pull request #10325: MINOR: Remove redudant LocalLogManager

2021-04-01 Thread GitBox
cmccabe merged pull request #10325: URL: https://github.com/apache/kafka/pull/10325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] cmccabe merged pull request #10456: MINOR: support ImplicitLinkedHashCollection#sort

2021-04-01 Thread GitBox
cmccabe merged pull request #10456: URL: https://github.com/apache/kafka/pull/10456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] cmccabe commented on a change in pull request #10456: MINOR: support ImplicitLinkedHashCollection#sort

2021-04-01 Thread GitBox
cmccabe commented on a change in pull request #10456: URL: https://github.com/apache/kafka/pull/10456#discussion_r606026209 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ImplicitLinkedHashCollection.java ## @@ -676,4 +678,18 @@ final int numSlots() {

[jira] [Comment Edited] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313497#comment-17313497 ] Jamie Brandon edited comment on KAFKA-12594 at 4/2/21, 1:19 AM: Actually

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313497#comment-17313497 ] Jamie Brandon commented on KAFKA-12594: --- Actually I see 998218 records in the

[GitHub] [kafka] junrao commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
junrao commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r606022097 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -59,7 +60,8 @@ class LogSegment private[log] (val log: FileRecords,

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313496#comment-17313496 ] Jamie Brandon commented on KAFKA-12594: --- Ok, here is the code I'm running now. {code:java}

[GitHub] [kafka] chia7712 commented on a change in pull request #10446: MINOR: [ConfigEntry.class] add 'type' to 'toString' and 'hashCode'

2021-04-01 Thread GitBox
chia7712 commented on a change in pull request #10446: URL: https://github.com/apache/kafka/pull/10446#discussion_r606022989 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java ## @@ -188,6 +188,7 @@ public int hashCode() { result =

[jira] [Resolved] (KAFKA-12587) Remove KafkaPrincipal#fromString for 3.0

2021-04-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12587. Resolution: Fixed > Remove KafkaPrincipal#fromString for 3.0 >

[GitHub] [kafka] chia7712 merged pull request #10447: KAFKA-12587 Remove KafkaPrincipal#fromString for 3.0

2021-04-01 Thread GitBox
chia7712 merged pull request #10447: URL: https://github.com/apache/kafka/pull/10447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] chia7712 commented on pull request #10447: KAFKA-12587 Remove KafkaPrincipal#fromString for 3.0

2021-04-01 Thread GitBox
chia7712 commented on pull request #10447: URL: https://github.com/apache/kafka/pull/10447#issuecomment-812259563 unrelated error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] cmccabe opened a new pull request #10463: MINOR: KRaft support for unclean.leader.election.enable

2021-04-01 Thread GitBox
cmccabe opened a new pull request #10463: URL: https://github.com/apache/kafka/pull/10463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Comment Edited] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313493#comment-17313493 ] Matthias J. Sax edited comment on KAFKA-12594 at 4/2/21, 12:53 AM: ---

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313493#comment-17313493 ] Matthias J. Sax commented on KAFKA-12594: - Can you maybe add a `stream().map((k,v) ->

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313489#comment-17313489 ] Jamie Brandon commented on KAFKA-12594: --- Specifically, the reason that I filed this as a bug is

[jira] [Commented] (KAFKA-9559) Change the default "default serde" from ByteArraySerde to null

2021-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313490#comment-17313490 ] Matthias J. Sax commented on KAFKA-9559: Thanks for looking into the code – I think a

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Jamie Brandon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313488#comment-17313488 ] Jamie Brandon commented on KAFKA-12594: --- The first example is a table-table join and the second

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313484#comment-17313484 ] Matthias J. Sax commented on KAFKA-12574: - I agree that "hot swapping" might be too aggressive.

[jira] [Commented] (KAFKA-12594) Self-join produces no ouput, and prevents other streams from producing output

2021-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313482#comment-17313482 ] Matthias J. Sax commented on KAFKA-12594: - The order of processing depends on the record

[jira] [Updated] (KAFKA-12593) Some Scala, Python, and Gradle files contain the wrong license header

2021-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12593: Labels: scala (was: ) > Some Scala, Python, and Gradle files contain the wrong license

[jira] [Updated] (KAFKA-12593) Some Scala, Python, and Gradle files contain the wrong license header

2021-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12593: Labels: (was: scala) > Some Scala, Python, and Gradle files contain the wrong license

[jira] [Updated] (KAFKA-12593) Some Scala, Python, and Gradle files contain the wrong license header

2021-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12593: Component/s: streams > Some Scala, Python, and Gradle files contain the wrong license

[jira] [Updated] (KAFKA-12593) Some Scala, Python, and Gradle files contain the wrong license header

2021-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12593: Component/s: (was: streams) > Some Scala, Python, and Gradle files contain the wrong

[jira] [Updated] (KAFKA-12605) kafka consumer churns through buffer memory iterating over records

2021-04-01 Thread radai rosenblatt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] radai rosenblatt updated KAFKA-12605: - Description: we recently conducted analysis on memory allocations by the kafka consumer

[jira] [Updated] (KAFKA-12605) kafka consumer churns through buffer memory iterating over records

2021-04-01 Thread radai rosenblatt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] radai rosenblatt updated KAFKA-12605: - Attachment: Screen Shot 2021-04-01 at 3.55.47 PM.png > kafka consumer churns through

[jira] [Created] (KAFKA-12605) kafka consumer churns through buffer memory iterating over records

2021-04-01 Thread radai rosenblatt (Jira)
radai rosenblatt created KAFKA-12605: Summary: kafka consumer churns through buffer memory iterating over records Key: KAFKA-12605 URL: https://issues.apache.org/jira/browse/KAFKA-12605 Project:

[GitHub] [kafka] hachikuji commented on a change in pull request #10142: KAFKA-12294: forward auto topic request within envelope on behalf of clients

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10142: URL: https://github.com/apache/kafka/pull/10142#discussion_r606008081 ## File path: core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala ## @@ -219,6 +225,146 @@ class AutoTopicCreationManagerTest {

[jira] [Commented] (KAFKA-12474) Worker can die if unable to write new session key

2021-04-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313476#comment-17313476 ] Randall Hauch commented on KAFKA-12474: --- Merged to the `trunk` branch after the `2.8` branch was

[jira] [Comment Edited] (KAFKA-12574) Deprecate eos-alpha

2021-04-01 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17312782#comment-17312782 ] Guozhang Wang edited comment on KAFKA-12574 at 4/1/21, 11:22 PM: - Okay,

[jira] [Updated] (KAFKA-12474) Worker can die if unable to write new session key

2021-04-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-12474: -- Fix Version/s: 2.8.0 > Worker can die if unable to write new session key >

[jira] [Commented] (KAFKA-12602) The LICENSE and NOTICE files don't list everything they should

2021-04-01 Thread Justin Mclean (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313467#comment-17313467 ] Justin Mclean commented on KAFKA-12602: --- JFYI - Some projects have different license and notice

[jira] [Resolved] (KAFKA-12426) Missing logic to create partition.metadata files in RaftReplicaManager

2021-04-01 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12426. - Fix Version/s: 3.0.0 Resolution: Fixed > Missing logic to create

[GitHub] [kafka] hachikuji merged pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-04-01 Thread GitBox
hachikuji merged pull request #10282: URL: https://github.com/apache/kafka/pull/10282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] guozhangwang commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
guozhangwang commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r605980981 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java ## @@ -181,20 +212,36 @@ public boolean isDone()

[GitHub] [kafka] guozhangwang commented on a change in pull request #10331: KAFKA-10847: Add a RocksDBTimeOrderedWindowStore to hold records using their timestamp as key prefix

2021-04-01 Thread GitBox
guozhangwang commented on a change in pull request #10331: URL: https://github.com/apache/kafka/pull/10331#discussion_r605943732 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/WindowKeySchemaTest.java ## @@ -242,7 +242,7 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r605971389 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java ## @@ -181,20 +212,36 @@ public boolean isDone() {

[GitHub] [kafka] hachikuji commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r605971389 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java ## @@ -181,20 +212,36 @@ public boolean isDone() {

[GitHub] [kafka] junrao commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
junrao commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r605955876 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -320,7 +320,7 @@ class Log(@volatile private var _dir: File, initializeLeaderEpochCache()

[GitHub] [kafka] ijuma commented on a change in pull request #10456: MINOR: support ImplicitLinkedHashCollection#sort

2021-04-01 Thread GitBox
ijuma commented on a change in pull request #10456: URL: https://github.com/apache/kafka/pull/10456#discussion_r605945706 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ImplicitLinkedHashCollection.java ## @@ -676,4 +678,18 @@ final int numSlots() {

[GitHub] [kafka] ijuma commented on a change in pull request #10456: MINOR: support ImplicitLinkedHashCollection#sort

2021-04-01 Thread GitBox
ijuma commented on a change in pull request #10456: URL: https://github.com/apache/kafka/pull/10456#discussion_r605945109 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ImplicitLinkedHashCollection.java ## @@ -676,4 +678,18 @@ final int numSlots() {

[jira] [Commented] (KAFKA-8314) Managing the doc field in case of schema projection - kafka connect

2021-04-01 Thread Karim Lamouri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313442#comment-17313442 ] Karim Lamouri commented on KAFKA-8314: -- We have the same problem on Kafka 2.5.1. Changing the doc

[jira] [Commented] (KAFKA-12468) Initial offsets are copied from source to target cluster

2021-04-01 Thread Alan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313426#comment-17313426 ] Alan commented on KAFKA-12468: -- > May i ask where did you run your MM2 (Strimzi MM2, EC2?) and about how

[jira] [Resolved] (KAFKA-12474) Worker can die if unable to write new session key

2021-04-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-12474. --- Fix Version/s: 2.6.2 2.7.1 2.5.2

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r605903207 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -848,6 +849,7 @@ class LogManager(logDirs: Seq[File], val dir = new

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r605902765 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -490,11 +490,14 @@ class LogSegment private[log] (val log: FileRecords, * Change

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r605902522 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -427,7 +442,7 @@ public static FileRecords open(File file,

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r605902276 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -195,6 +199,17 @@ public int append(MemoryRecords records)

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r605901984 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -195,6 +199,17 @@ public int append(MemoryRecords records)

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r605901483 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -249,6 +266,7 @@ public void renameTo(File f) throws IOException

[GitHub] [kafka] ccding commented on a change in pull request #10405: KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-04-01 Thread GitBox
ccding commented on a change in pull request #10405: URL: https://github.com/apache/kafka/pull/10405#discussion_r605901016 ## File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java ## @@ -427,7 +445,7 @@ public static FileRecords open(File file,

[GitHub] [kafka] hachikuji commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r605879590 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java ## @@ -689,30 +680,57 @@ private void

[GitHub] [kafka] guozhangwang commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
guozhangwang commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r605867393 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java ## @@ -181,20 +212,36 @@ public boolean isDone()

[GitHub] [kafka] spena opened a new pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-01 Thread GitBox
spena opened a new pull request #10462: URL: https://github.com/apache/kafka/pull/10462 Fixes the issue with https://issues.apache.org/jira/browse/KAFKA-10847. Note: - DO NOT review commit #1. This commit is being reviewed in https://github.com/apache/kafka/pull/10331 To

[jira] [Created] (KAFKA-12604) Remove envelope handling from broker

2021-04-01 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12604: --- Summary: Remove envelope handling from broker Key: KAFKA-12604 URL: https://issues.apache.org/jira/browse/KAFKA-12604 Project: Kafka Issue Type:

[GitHub] [kafka] cmccabe commented on pull request #10456: MINOR: support ImplicitLinkedHashCollection#sort

2021-04-01 Thread GitBox
cmccabe commented on pull request #10456: URL: https://github.com/apache/kafka/pull/10456#issuecomment-812085557 > Does this perform better than copying it to an array and using the standard library sort methods (that have been optimized over the years)? Good question. I wrote a

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-04-01 Thread GitBox
jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r605847062 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1369,7 +1377,10 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] hachikuji merged pull request #10422: MINOR: Improve reproducability of raft simulation tests

2021-04-01 Thread GitBox
hachikuji merged pull request #10422: URL: https://github.com/apache/kafka/pull/10422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (KAFKA-12251) Add topic ID support to StopReplica

2021-04-01 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313343#comment-17313343 ] Justine Olshan commented on KAFKA-12251: Hi [~dengziming] sorry for the late response. I think

[GitHub] [kafka] hachikuji commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r605822416 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -842,6 +842,20 @@ class LogManager(logDirs: Seq[File], log } +

[jira] [Updated] (KAFKA-10549) Add topic ID support to ListOffsets, OffsetForLeaders

2021-04-01 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-10549: --- Summary: Add topic ID support to ListOffsets, OffsetForLeaders (was: Add topic ID support

[jira] [Updated] (KAFKA-10549) Add topic ID support to ListOffsets, OffsetForLeaders

2021-04-01 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-10549: --- Description: ListOffsets, OffsetForLeaders, and StopReplica protocols will replace topic

[GitHub] [kafka] rhauch merged pull request #10396: KAFKA-12474: Handle failure to write new session keys gracefully

2021-04-01 Thread GitBox
rhauch merged pull request #10396: URL: https://github.com/apache/kafka/pull/10396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] hachikuji commented on a change in pull request #10393: KAFKA-12539: Refactor KafkaRaftCllient handleVoteRequest to reduce cyclomatic complexity

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10393: URL: https://github.com/apache/kafka/pull/10393#discussion_r605812919 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -592,44 +592,17 @@ private VoteResponseData handleVoteRequest(

[GitHub] [kafka] jolshan opened a new pull request #10461: KAFKA-12603: Add benchmarks for handleFetchRequest and FetchContext

2021-04-01 Thread GitBox
jolshan opened a new pull request #10461: URL: https://github.com/apache/kafka/pull/10461 Added benchmarks to help test https://github.com/apache/kafka/pull/9944. These benchmarks can be used to compare the handleFetchRequest path, FullFetchContext and IncrementalFetchContext.

[jira] [Created] (KAFKA-12603) Add benchmarks for handleFetchRequest and FetchContext

2021-04-01 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-12603: -- Summary: Add benchmarks for handleFetchRequest and FetchContext Key: KAFKA-12603 URL: https://issues.apache.org/jira/browse/KAFKA-12603 Project: Kafka

[jira] [Assigned] (KAFKA-12603) Add benchmarks for handleFetchRequest and FetchContext

2021-04-01 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-12603: -- Assignee: Justine Olshan > Add benchmarks for handleFetchRequest and FetchContext >

[jira] [Commented] (KAFKA-12468) Initial offsets are copied from source to target cluster

2021-04-01 Thread Angelos Kaltsikis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313268#comment-17313268 ] Angelos Kaltsikis commented on KAFKA-12468: --- By the way, may i ask how you were able to

[jira] [Resolved] (KAFKA-12593) Some Scala, Python, and Gradle files contain the wrong license header

2021-04-01 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-12593. -- Resolution: Fixed > Some Scala, Python, and Gradle files contain the wrong license header >

[jira] [Commented] (KAFKA-12593) Some Scala, Python, and Gradle files contain the wrong license header

2021-04-01 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313259#comment-17313259 ] John Roesler commented on KAFKA-12593: -- Thanks for the confirmation, [~jmclean] ! > Some Scala,

[jira] [Updated] (KAFKA-12593) Some Scala, Python, and Gradle files contain the wrong license header

2021-04-01 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-12593: - Summary: Some Scala, Python, and Gradle files contain the wrong license header (was: The

[GitHub] [kafka] vvcephei commented on pull request #10452: KAFKA-12593: Fix Apache License headers

2021-04-01 Thread GitBox
vvcephei commented on pull request #10452: URL: https://github.com/apache/kafka/pull/10452#issuecomment-81250 Cherry-picked to 2.8, 2.7, and 2.6. I doubt anyone's going to do another 2.5 patch release. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] cadonna commented on pull request #10460: KAFKA-10357: Use validate and setup during internal topics creation

2021-04-01 Thread GitBox
cadonna commented on pull request #10460: URL: https://github.com/apache/kafka/pull/10460#issuecomment-811995942 Call for review: @rodesai @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] cadonna opened a new pull request #10460: KAFKA-10357: Use validate and setup during internal topics creation

2021-04-01 Thread GitBox
cadonna opened a new pull request #10460: URL: https://github.com/apache/kafka/pull/10460 For KIP-698, we introduce new setup and validation methods for internal topics. This PR uses the newly added methods and removes the old methods. ### Committer Checklist (excluded from

[GitHub] [kafka] rhauch commented on pull request #10396: KAFKA-12474: Handle failure to write new session keys gracefully

2021-04-01 Thread GitBox
rhauch commented on pull request #10396: URL: https://github.com/apache/kafka/pull/10396#issuecomment-811994433 Not sure why the build results are not showing up, but the build passed on JDK 8 and ARM, and failed unrelated tests on JDK 15.

[GitHub] [kafka] vvcephei merged pull request #10452: KAFKA-12593: Fix Apache License headers

2021-04-01 Thread GitBox
vvcephei merged pull request #10452: URL: https://github.com/apache/kafka/pull/10452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

  1   2   >