[jira] [Commented] (KAFKA-12607) Allow votes to be granted in resigned state

2021-04-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317386#comment-17317386 ] Jason Gustafson commented on KAFKA-12607: - [~dengziming] Aha, that makes sense. I was wondering

[GitHub] [kafka] mumrah opened a new pull request #10504: KAFKA-12620 Allocate producer ids on the controller

2021-04-08 Thread GitBox
mumrah opened a new pull request #10504: URL: https://github.com/apache/kafka/pull/10504 This is part of the implementation for [KIP-730](https://cwiki.apache.org/confluence/display/KAFKA/KIP-730%3A+Producer+ID+generation+in+KRaft+mode) which is still under discussion. The details of the

[jira] [Updated] (KAFKA-12628) Enable dynamic update of client-side SSL in consumer or producer clients

2021-04-08 Thread raphael auv (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] raphael auv updated KAFKA-12628: Description: There is a dynamic update of SLL conf by the broker client

[GitHub] [kafka] mumrah merged pull request #10254: KAFKA-12406 Integrate client quotas with raft broker

2021-04-08 Thread GitBox
mumrah merged pull request #10254: URL: https://github.com/apache/kafka/pull/10254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (KAFKA-12628) Enable dynamic update of client-side SSL in consumer or producer clients

2021-04-08 Thread raphael auv (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] raphael auv updated KAFKA-12628: Summary: Enable dynamic update of client-side SSL in consumer or producer clients (was: SSL

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-08 Thread GitBox
mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r609948744 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +48,36 @@ private final String

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-08 Thread GitBox
mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r609954693 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -133,34 +141,37 @@ public void process(final

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-08 Thread GitBox
mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r609948744 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +48,36 @@ private final String

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-08 Thread GitBox
mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r609948744 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +48,36 @@ private final String

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-08 Thread GitBox
mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r609948744 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -38,20 +48,36 @@ private final String

[GitHub] [kafka] hachikuji merged pull request #10481: KAFKA-12619; Raft leader should expose hw only after committing LeaderChange

2021-04-08 Thread GitBox
hachikuji merged pull request #10481: URL: https://github.com/apache/kafka/pull/10481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] hachikuji commented on a change in pull request #10481: KAFKA-12619; Raft leader should expose hw only after committing LeaderChange

2021-04-08 Thread GitBox
hachikuji commented on a change in pull request #10481: URL: https://github.com/apache/kafka/pull/10481#discussion_r609943203 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -113,13 +113,18 @@ private boolean updateHighWatermark() {

[jira] [Assigned] (KAFKA-12555) Log reason for rolling a segment

2021-04-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-12555: --- Assignee: Alexander Daskalov > Log reason for rolling a segment >

[jira] [Assigned] (KAFKA-12555) Log reason for rolling a segment

2021-04-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-12555: --- Assignee: (was: Ryan Dielhenn) > Log reason for rolling a segment >

[jira] [Commented] (KAFKA-12555) Log reason for rolling a segment

2021-04-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317372#comment-17317372 ] Jason Gustafson commented on KAFKA-12555: - [~Comonut] Yeah, that is a good list. I assume you

[jira] [Resolved] (KAFKA-12457) Implications of KIP-516 for quorum controller

2021-04-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12457. - Resolution: Fixed > Implications of KIP-516 for quorum controller >

[GitHub] [kafka] hachikuji merged pull request #10492: KAFKA-12457: Add sentinel ID to metadata topic

2021-04-08 Thread GitBox
hachikuji merged pull request #10492: URL: https://github.com/apache/kafka/pull/10492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (KAFKA-9831) Failing test: EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once_beta]

2021-04-08 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317364#comment-17317364 ] Mickael Maison commented on KAFKA-9831: --- I saw it again today in the 2.7 build: {noformat}

[GitHub] [kafka] abbccdda commented on a change in pull request #10482: KAFKA-12499: add transaction timeout verification

2021-04-08 Thread GitBox
abbccdda commented on a change in pull request #10482: URL: https://github.com/apache/kafka/pull/10482#discussion_r609922102 ## File path: streams/examples/src/main/java/org/apache/kafka/streams/examples/pageview/PageViewTypedDemo.java ## @@ -181,7 +181,7 @@ public static

[GitHub] [kafka] C0urante commented on a change in pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during task shutdown

2021-04-08 Thread GitBox
C0urante commented on a change in pull request #10503: URL: https://github.com/apache/kafka/pull/10503#discussion_r609882468 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java ## @@ -185,8 +185,15 @@ private void doRun() throws

[GitHub] [kafka] abbccdda commented on a change in pull request #10482: KAFKA-12499: add transaction timeout verification

2021-04-08 Thread GitBox
abbccdda commented on a change in pull request #10482: URL: https://github.com/apache/kafka/pull/10482#discussion_r609920651 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1031,6 +1032,23 @@ protected StreamsConfig(final Map props,

[jira] [Commented] (KAFKA-12555) Log reason for rolling a segment

2021-04-08 Thread Alexander Daskalov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317351#comment-17317351 ] Alexander Daskalov commented on KAFKA-12555: I started looking into this issue, but I'm new

[GitHub] [kafka] mjsax commented on a change in pull request #10482: KAFKA-12499: add transaction timeout verification

2021-04-08 Thread GitBox
mjsax commented on a change in pull request #10482: URL: https://github.com/apache/kafka/pull/10482#discussion_r609907071 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1031,6 +1032,23 @@ protected StreamsConfig(final Map props,

[jira] [Assigned] (KAFKA-12555) Log reason for rolling a segment

2021-04-08 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn reassigned KAFKA-12555: - Assignee: Ryan Dielhenn > Log reason for rolling a segment >

[jira] [Commented] (KAFKA-12555) Log reason for rolling a segment

2021-04-08 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317341#comment-17317341 ] Stanislav Kozlovski commented on KAFKA-12555: - No, I don't know the reasons. I was hoping

[jira] [Commented] (KAFKA-12555) Log reason for rolling a segment

2021-04-08 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317339#comment-17317339 ] Jose Armando Garcia Sancio commented on KAFKA-12555: Thanks [~enether]. This is a

[jira] [Created] (KAFKA-12634) Should checkpoint after restore finished

2021-04-08 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12634: --- Summary: Should checkpoint after restore finished Key: KAFKA-12634 URL: https://issues.apache.org/jira/browse/KAFKA-12634 Project: Kafka Issue Type:

[GitHub] [kafka] junrao commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
junrao commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r609895193 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,309 @@ +/* + * Licensed

[jira] [Commented] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-04-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317327#comment-17317327 ] Matthias J. Sax commented on KAFKA-12453: - {quote}and why `builder.stream().toTable()` is

[jira] [Created] (KAFKA-12633) Remove deprecated "TopologyTestDriver#pipeInput / readOutput"

2021-04-08 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12633: - Summary: Remove deprecated "TopologyTestDriver#pipeInput / readOutput" Key: KAFKA-12633 URL: https://issues.apache.org/jira/browse/KAFKA-12633 Project: Kafka

[jira] [Resolved] (KAFKA-12630) Remove deprecated KafkaClientSupplier#getAdminClient

2021-04-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12630. --- Fix Version/s: 3.0.0 Resolution: Fixed > Remove deprecated

[GitHub] [kafka] guozhangwang merged pull request #10502: KAFKA-12630: Remove deprecated KafkaClientSupplier#getAdminClient in Streams

2021-04-08 Thread GitBox
guozhangwang merged pull request #10502: URL: https://github.com/apache/kafka/pull/10502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Comment Edited] (KAFKA-8295) Optimize count() using RocksDB merge operator

2021-04-08 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317116#comment-17317116 ] Sagar Rao edited comment on KAFKA-8295 at 4/8/21, 3:12 PM: --- hey

[GitHub] [kafka] dengziming commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-08 Thread GitBox
dengziming commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r609608513 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2235,6 +2233,7 @@ private Long append(int epoch, List records,

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

2021-04-08 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317116#comment-17317116 ] Sagar Rao commented on KAFKA-8295: -- hey [~ableegoldman], this is a very old ticket but i was looking at

[jira] [Resolved] (KAFKA-12623) Fix LICENSE in 2.7

2021-04-08 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-12623. Resolution: Fixed > Fix LICENSE in 2.7 > -- > > Key:

[GitHub] [kafka] dengziming commented on a change in pull request #10481: KAFKA-12619; Raft leader should expose hw only after committing LeaderChange

2021-04-08 Thread GitBox
dengziming commented on a change in pull request #10481: URL: https://github.com/apache/kafka/pull/10481#discussion_r609589579 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -113,13 +113,18 @@ private boolean updateHighWatermark() {

[jira] [Commented] (KAFKA-12623) Fix LICENSE in 2.7

2021-04-08 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317102#comment-17317102 ] Mickael Maison commented on KAFKA-12623: I cherry picked the commit from 2.8 and made the

[jira] [Commented] (KAFKA-12622) Automate LICENCSE file validation

2021-04-08 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317093#comment-17317093 ] Mickael Maison commented on KAFKA-12622: When following this process for 2.7, I used this

[GitHub] [kafka] g1geordie commented on pull request #10190: KAFKA-12336 Custom stream naming does not work while calling stream[K…

2021-04-08 Thread GitBox
g1geordie commented on pull request #10190: URL: https://github.com/apache/kafka/pull/10190#issuecomment-815594893 @bbejeck Thanks for your response !! I see the compatibility claim in NamedInternal. ``` String orElseGenerateWithPrefix(final InternalNameProvider provider,

[GitHub] [kafka] chia7712 merged pull request #10501: MINOR: Remove redundant test code

2021-04-08 Thread GitBox
chia7712 merged pull request #10501: URL: https://github.com/apache/kafka/pull/10501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] chia7712 merged pull request #10406: MINOR: Update testUpdate method with correct Crc32

2021-04-08 Thread GitBox
chia7712 merged pull request #10406: URL: https://github.com/apache/kafka/pull/10406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (KAFKA-12632) Exception may missed when source task failing

2021-04-08 Thread Jira
戈震 created KAFKA-12632: -- Summary: Exception may missed when source task failing Key: KAFKA-12632 URL: https://issues.apache.org/jira/browse/KAFKA-12632 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-04-08 Thread Patrick O'Keeffe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316930#comment-17316930 ] Patrick O'Keeffe commented on KAFKA-12453: -- Thanks the response [~mjsax], and apologies for not

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r609387061 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManagerTest.java ## @@ -0,0 +1,130 @@ +/* + *

[GitHub] [kafka] satishd commented on pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
satishd commented on pull request #10218: URL: https://github.com/apache/kafka/pull/10218#issuecomment-815513359 @junrao Thanks for your comments. Replied on comments and addressed them with the

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r608820288 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,305 @@ +/* + * Licensed

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r609372137 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCacheTest.java ## @@ -0,0 +1,379 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r609372257 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCacheTest.java ## @@ -0,0 +1,379 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r609369903 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCacheTest.java ## @@ -0,0 +1,379 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r609369434 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,310 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r609369185 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,160 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r609352593 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCacheTest.java ## @@ -0,0 +1,379 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-04-08 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r609351020 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteStorageManagerTest.java ## @@ -0,0 +1,246 @@ +/* + *

[jira] [Commented] (KAFKA-12607) Allow votes to be granted in resigned state

2021-04-08 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316889#comment-17316889 ] dengziming commented on KAFKA-12607: [~hachikuji] [~guozhang] I find it's unnecessary to fix this

<    1   2