dengziming commented on pull request #10701:
URL: https://github.com/apache/kafka/pull/10701#issuecomment-841594749
Hello @vvcephei, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
dengziming opened a new pull request #10701:
URL: https://github.com/apache/kafka/pull/10701
*More detailed description of your change*
It seems that #9396 leaves out a TODO, just fix it.
*Summary of testing strategy (including rationale)*
QA
### Committer Checklist (excl
zhaohaidao opened a new pull request #10700:
URL: https://github.com/apache/kafka/pull/10700
According to my understanding, the following paragraph looks like a stale
comments.
> public void handleSuccessfulResponse(RequestHeader requestHeader, long
now, MetadataResponse response) {
[
https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344958#comment-17344958
]
NEERAJ VAIDYA commented on KAFKA-12776:
---
[~ableegoldman], [~ijuma], [~tombentley]
[
https://issues.apache.org/jira/browse/KAFKA-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
HaiyuanZhao updated KAFKA-12789:
Description:
According to my understanding, the following paragraph looks like a stale
comments.
[
https://issues.apache.org/jira/browse/KAFKA-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
HaiyuanZhao updated KAFKA-12789:
Description:
According to my understanding, the following paragraph looks like a stale
comments.
[
https://issues.apache.org/jira/browse/KAFKA-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
HaiyuanZhao updated KAFKA-12789:
Description:
According to my understanding, the following paragraph looks like a stale
comments.
[
https://issues.apache.org/jira/browse/KAFKA-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
HaiyuanZhao updated KAFKA-12789:
Description:
According to my understanding, the following paragraph looks like a stale
comments?
HaiyuanZhao created KAFKA-12789:
---
Summary: Remove Stale comments for meta response handling logic
Key: KAFKA-12789
URL: https://issues.apache.org/jira/browse/KAFKA-12789
Project: Kafka
Issue Ty
ccding commented on pull request #10684:
URL: https://github.com/apache/kafka/pull/10684#issuecomment-841577947
LGTM
Thanks @kowshik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
junrao commented on a change in pull request #10494:
URL: https://github.com/apache/kafka/pull/10494#discussion_r632872729
##
File path:
metadata/src/test/java/org/apache/kafka/controller/StripedReplicaPlacerTest.java
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Softwar
dielhennr commented on a change in pull request #10572:
URL: https://github.com/apache/kafka/pull/10572#discussion_r632858915
##
File path: metadata/src/main/java/org/apache/kafka/controller/BrokersToIsrs.java
##
@@ -139,10 +140,16 @@ public TopicIdPartition next() {
* Pa
cmccabe commented on a change in pull request #10572:
URL: https://github.com/apache/kafka/pull/10572#discussion_r632857030
##
File path: metadata/src/main/java/org/apache/kafka/controller/BrokersToIsrs.java
##
@@ -139,10 +140,16 @@ public TopicIdPartition next() {
* Part
cmccabe opened a new pull request #10699:
URL: https://github.com/apache/kafka/pull/10699
This patch adds support for running the ZooKeeper-based
kafka.security.authorizer.AclAuthorizer with KRaft clusters. Set the
authorizer.class.name config as well as the zookeeper.connect config while
[
https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344914#comment-17344914
]
NEERAJ VAIDYA commented on KAFKA-12776:
---
[~tombentley]
Yes, this has been reprodu
rondagostino commented on pull request #10694:
URL: https://github.com/apache/kafka/pull/10694#issuecomment-841512146
Full system test output here:
https://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-05-14--001.1621023792--rondagostino--fix_TestSecurit
cmccabe commented on a change in pull request #10494:
URL: https://github.com/apache/kafka/pull/10494#discussion_r632806423
##
File path:
metadata/src/test/java/org/apache/kafka/controller/StripedReplicaPlacerTest.java
##
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Softwa
dejan2609 opened a new pull request #10698:
URL: https://github.com/apache/kafka/pull/10698
@ijuma please review this.
JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-12770
Related PR/comment:
https://github.com/apache/kafka/pull/10656#issuecomment-835809154
@r
cmccabe commented on a change in pull request #10494:
URL: https://github.com/apache/kafka/pull/10494#discussion_r632796785
##
File path:
metadata/src/main/java/org/apache/kafka/controller/StripedReplicaPlacer.java
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software F
[
https://issues.apache.org/jira/browse/KAFKA-12770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dejan Stojadinović updated KAFKA-12770:
---
Summary: Gradle build: allow the CheckStyle version to be specified via
parameter (
cmccabe commented on a change in pull request #10494:
URL: https://github.com/apache/kafka/pull/10494#discussion_r632796424
##
File path:
metadata/src/main/java/org/apache/kafka/controller/StripedReplicaPlacer.java
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software F
ableegoldman commented on a change in pull request #10690:
URL: https://github.com/apache/kafka/pull/10690#discussion_r632788590
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -247,9 +248,10 @@
public static final String EN
ableegoldman commented on a change in pull request #10690:
URL: https://github.com/apache/kafka/pull/10690#discussion_r632787843
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -201,7 +201,8 @@
public static final String MAX
[
https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walker Carlson closed KAFKA-12754.
--
> TaskMetadata endOffsets does not update when the offsets are read
>
[
https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344864#comment-17344864
]
Walker Carlson commented on KAFKA-12754:
Huh, I guess I was wrong. Sorry!
> Tas
[
https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walker Carlson updated KAFKA-12754:
---
Affects Version/s: (was: 2.8.0)
> TaskMetadata endOffsets does not update when the offse
[
https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344863#comment-17344863
]
A. Sophie Blee-Goldman commented on KAFKA-12754:
[~wcarlson5] are you su
cmccabe commented on a change in pull request #10494:
URL: https://github.com/apache/kafka/pull/10494#discussion_r632770796
##
File path:
metadata/src/test/java/org/apache/kafka/controller/StripedReplicaPlacerTest.java
##
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Softwa
cmccabe commented on a change in pull request #10494:
URL: https://github.com/apache/kafka/pull/10494#discussion_r632769701
##
File path:
metadata/src/test/java/org/apache/kafka/controller/StripedReplicaPlacerTest.java
##
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Softwa
[
https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344857#comment-17344857
]
Walker Carlson commented on KAFKA-12754:
[~ableegoldman] I think picking back to
[
https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walker Carlson updated KAFKA-12754:
---
Affects Version/s: 2.8.0
> TaskMetadata endOffsets does not update when the offsets are read
Colin McCabe created KAFKA-12788:
Summary: Improve KRaft replica placement
Key: KAFKA-12788
URL: https://issues.apache.org/jira/browse/KAFKA-12788
Project: Kafka
Issue Type: Improvement
cmccabe commented on pull request #10494:
URL: https://github.com/apache/kafka/pull/10494#issuecomment-841470406
> @cmccabe : Thanks for the PR. A few comments below. Also, we probably want
to associate a jira with the PR since it's a bit large.
Fair. I created KAFKA-12788 for this
[
https://issues.apache.org/jira/browse/KAFKA-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-12471.
--
Fix Version/s: 3.0.0
Resolution: Fixed
> Implement createPartitions in KIP-500 mode
> -
[
https://issues.apache.org/jira/browse/KAFKA-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-12334.
--
Fix Version/s: 2.8.0
Resolution: Fixed
Added in 2.8
> Add the KIP-631 metadata shell
>
[
https://issues.apache.org/jira/browse/KAFKA-12275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-12275.
--
Fix Version/s: 2.8.0
Assignee: Colin McCabe
Resolution: Fixed
DecomissionBroke
cmccabe merged pull request #10688:
URL: https://github.com/apache/kafka/pull/10688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
Jose Armando Garcia Sancio created KAFKA-12787:
--
Summary: Configure and integrate controller snapshot with the
RaftClient
Key: KAFKA-12787
URL: https://issues.apache.org/jira/browse/KAFKA-12787
[
https://issues.apache.org/jira/browse/KAFKA-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio reassigned KAFKA-12647:
--
Assignee: Colin McCabe (was: Jose Armando Garcia Sancio)
> I
[
https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-12754.
Fix Version/s: 3.0.0
Resolution: Fixed
> TaskMetadata endOffsets do
[
https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344835#comment-17344835
]
A. Sophie Blee-Goldman commented on KAFKA-12754:
[~wcarlson5] was this f
ableegoldman merged pull request #10634:
URL: https://github.com/apache/kafka/pull/10634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
ableegoldman commented on pull request #10634:
URL: https://github.com/apache/kafka/pull/10634#issuecomment-841450435
Looks like just the usual flaky test failures in the build:
`RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()`
and
`KTableKTableForeignKeyInnerJ
rondagostino commented on pull request #10697:
URL: https://github.com/apache/kafka/pull/10697#issuecomment-841448877
Tested locally to confirm that the added size is the correct one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rondagostino opened a new pull request #10697:
URL: https://github.com/apache/kafka/pull/10697
The StreamsNamedRepartitionTopicTest system tests did not have the
`@cluster` annotation and was therefore taking up the entire cluster. For
example, we see this in the log output:
`kafk
dejan2609 commented on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-841421148
Test result on Jenkins shows no failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
cmccabe commented on pull request #10688:
URL: https://github.com/apache/kafka/pull/10688#issuecomment-841410862
> Generally, I don't like that we need to explicitly extract the timeout
from the request and pass it into the controller call. It would nice if this
could be generalized or aut
mumrah opened a new pull request #10696:
URL: https://github.com/apache/kafka/pull/10696
Rather than using multiple optional class members to determine if we are in
ZK or KRaft mode, use inheritance. The factory method in
AutoTopicCreationManager now makes the decision about which mode we'
cmccabe commented on a change in pull request #10688:
URL: https://github.com/apache/kafka/pull/10688#discussion_r632697059
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -800,19 +800,44 @@ void handleBrokerUnfenced(int br
cmccabe commented on a change in pull request #10688:
URL: https://github.com/apache/kafka/pull/10688#discussion_r632696250
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1165,4 +1192,22 @@ public long curClaimEpoch() {
publi
cmccabe commented on a change in pull request #10688:
URL: https://github.com/apache/kafka/pull/10688#discussion_r632695450
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1030,17 +1050,24 @@ private QuorumController(LogContext log
cmccabe commented on a change in pull request #10688:
URL: https://github.com/apache/kafka/pull/10688#discussion_r632695254
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1002,7 +1013,13 @@ private QuorumController(LogContext logC
wcarlson5 commented on a change in pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#discussion_r632673138
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/SuppressedTest.java
##
@@ -46,13 +48,13 @@ public void bufferBuilderShouldBeConsis
cmccabe opened a new pull request #10695:
URL: https://github.com/apache/kafka/pull/10695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
rondagostino opened a new pull request #10694:
URL: https://github.com/apache/kafka/pull/10694
SecurityConfig for a Kafka cluster in a system test is cached due to
https://github.com/apache/kafka/pull/8917, but we mutate the security config
during some system tests, and those mutations wer
[
https://issues.apache.org/jira/browse/KAFKA-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344701#comment-17344701
]
Jun Rao commented on KAFKA-3968:
Merged the reworked PR [https://github.com/apache/kafka/
junrao merged pull request #10680:
URL: https://github.com/apache/kafka/pull/10680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/KAFKA-12761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12761:
Component/s: (was: streams)
> Consumer offsets are deleted 7 days after last offset co
wcarlson5 commented on pull request #10634:
URL: https://github.com/apache/kafka/pull/10634#issuecomment-841342581
@ableegoldman I think it ready :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wcarlson5 commented on a change in pull request #10634:
URL: https://github.com/apache/kafka/pull/10634#discussion_r632637377
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java
##
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the
mumrah commented on a change in pull request #10688:
URL: https://github.com/apache/kafka/pull/10688#discussion_r632616511
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1002,7 +1013,13 @@ private QuorumController(LogContext logCo
lbradstreet commented on a change in pull request #10620:
URL: https://github.com/apache/kafka/pull/10620#discussion_r632614924
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
##
@@ -710,8 +710,11 @@ private boolean append
dejan2609 commented on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-841303016
Bumped/force-pushed (I took the liberty to skipped local testing on my end
just to save some time).
--
This is an automated message from the Apache Git Service.
To respond t
ijuma commented on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-841294495
Let's bump it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
dejan2609 edited a comment on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-841291321
FYI/note: Gradle 7.0.2 hotfix is released few hours ago (it solves one
corner case on Alpine Linux):
https://github.com/gradle/gradle/releases/tag/v7.0.2
Let me
dejan2609 edited a comment on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-841291321
FYI/note: Gradle 7.0.2 hotfix is released few hours ago (it solves one
corner case on Alpine Linux):
https://github.com/gradle/gradle/releases/tag/v7.0.2
Let me
dejan2609 commented on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-841291321
FYI/note: Gradle 7.0.2 hotfix is released few hours ago (it solves one
corner case on Alpine Linux):
https://github.com/gradle/gradle/releases/tag/v7.0.2
Let me know if
kpatelatwork commented on a change in pull request #10528:
URL: https://github.com/apache/kafka/pull/10528#discussion_r632541366
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitter.java
##
@@ -105,6 +105,11 @@ public void remo
[
https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344595#comment-17344595
]
Tom Bentley commented on KAFKA-12776:
-
[~neeraj.vaidya] can you reproduce this witho
ijuma commented on a change in pull request #10690:
URL: https://github.com/apache/kafka/pull/10690#discussion_r632510173
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -247,9 +248,10 @@
public static final String ENABLE_ID
ijuma commented on a change in pull request #10690:
URL: https://github.com/apache/kafka/pull/10690#discussion_r632509174
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -201,7 +201,8 @@
public static final String MAX_IN_FLI
[
https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344517#comment-17344517
]
NEERAJ VAIDYA edited comment on KAFKA-12776 at 5/14/21, 12:51 PM:
[
https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344517#comment-17344517
]
NEERAJ VAIDYA edited comment on KAFKA-12776 at 5/14/21, 12:51 PM:
Sibelle created KAFKA-12786:
---
Summary: Getting SslTransportLayerTest error
Key: KAFKA-12786
URL: https://issues.apache.org/jira/browse/KAFKA-12786
Project: Kafka
Issue Type: Bug
Componen
AndroideRob commented on a change in pull request #10591:
URL: https://github.com/apache/kafka/pull/10591#discussion_r632489696
##
File path: docs/ops.html
##
@@ -78,7 +78,7 @@
auto.leader.rebalance.enable=true
You can also set this to false, but you will then need
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-841197433
Failures were https://issues.apache.org/jira/browse/KAFKA-9009 and
https://issues.apache.org/jira/browse/KAFKA-12629
--
This is an automated message from the Apache Git Service
[
https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344537#comment-17344537
]
Jørgen commented on KAFKA-12774:
It actually works as expected when throwing from select
jlprat commented on a change in pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#discussion_r632410626
##
File path: LICENSE-binary
##
@@ -243,7 +243,6 @@ netty-handler-4.1.59.Final
netty-resolver-4.1.59.Final
netty-transport-4.1.59.Final
netty-transport-
jlprat commented on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-841165081
@cadonna Would you like me to split this PR into several ones? One per file,
for example?
--
This is an automated message from the Apache Git Service.
To respond to the message
[
https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344517#comment-17344517
]
NEERAJ VAIDYA commented on KAFKA-12776:
---
Hi Tom
The topic has just 1 partition.
[
https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344516#comment-17344516
]
Omnia Ibrahim commented on KAFKA-10201:
---
[~xvrl] if you still need help with the r
jlprat commented on a change in pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#discussion_r632410626
##
File path: LICENSE-binary
##
@@ -243,7 +243,6 @@ netty-handler-4.1.59.Final
netty-resolver-4.1.59.Final
netty-transport-4.1.59.Final
netty-transport-
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-841123185
I would highly appreciate any hint on how to proceed for the dependencies
that do not include a notice file in their jar files but might include them in
their source code reposit
jlprat opened a new pull request #10693:
URL: https://github.com/apache/kafka/pull/10693
Adds new NOTICE-binary file and packages it in the binary release
This follows up the https://github.com/apache/kafka/pull/10474 pull where
LICENSE was fix.
Similarly as in that PR, I do not k
Trofimov created KAFKA-12784:
Summary: ssl kafka failed
Key: KAFKA-12784
URL: https://issues.apache.org/jira/browse/KAFKA-12784
Project: Kafka
Issue Type: Task
Components: config, consu
[
https://issues.apache.org/jira/browse/KAFKA-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Bentley updated KAFKA-6987:
---
Fix Version/s: 3.0.0
> Reimplement KafkaFuture with CompletableFuture
> -
mimaison commented on pull request #10660:
URL: https://github.com/apache/kafka/pull/10660#issuecomment-841103731
Thanks @mjsax, I can see the artifacts now. I've rekicked the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
cadonna commented on a change in pull request #10646:
URL: https://github.com/apache/kafka/pull/10646#discussion_r632371505
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -128,8 +129,7 @@ public void setGlobal
ableegoldman commented on pull request #10690:
URL: https://github.com/apache/kafka/pull/10690#issuecomment-841084469
Wow, all checks actually passed! That's the second completely green build
I've seen in 24 hours, must be my lucky day 😄
--
This is an automated message from the Apache G
ableegoldman commented on a change in pull request #10690:
URL: https://github.com/apache/kafka/pull/10690#discussion_r632355592
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -247,9 +248,10 @@
public static final String EN
[
https://issues.apache.org/jira/browse/KAFKA-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat reassigned KAFKA-12625:
--
Assignee: Josep Prat
> Fix the NOTICE file
> ---
>
> Key: KAF
[
https://issues.apache.org/jira/browse/KAFKA-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344377#comment-17344377
]
Josep Prat commented on KAFKA-12625:
[~vvcephei] As I see no assignee neither any PR
[
https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344376#comment-17344376
]
Tom Bentley commented on KAFKA-12776:
-
[~neeraj.vaidya] how many partitions does the
dejan2609 edited a comment on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-841055689
PR rebased, commits are squashed into one; tests on Jenkins are looking
good: it seems that only one unrelated test failed.
--
This is an automated message from the A
dejan2609 commented on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-841055689
It seems that only one unrelated test failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
95 matches
Mail list logo
