satishd commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r667427888
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
##
@@ -0,0 +1,432 @@
+/*
[
https://issues.apache.org/jira/browse/KAFKA-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378574#comment-17378574
]
dengziming commented on KAFKA-13042:
[~meher_crok] This is a bug of Scala 2.12 and f
showuon edited a comment on pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#issuecomment-877736694
@rondagostino , thanks for comments and many good catch! I've updated the
PR. Also update the PR description.
> The PR as currently written restricts describing con
showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r667417274
##
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##
@@ -236,9 +240,17 @@ object ConfigCommand extends Config {
}
}
- private d
showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r667417221
##
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##
@@ -236,9 +240,17 @@ object ConfigCommand extends Config {
}
}
- private d
showuon edited a comment on pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#issuecomment-877736694
@rondagostino , thanks for comments and many good catch! I've updated the
PR.
> The PR as currently written restricts describing configs via --zookeeper
to user a
showuon commented on pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#issuecomment-877736694
@rondagostino , thanks for comments and many good catch! I've updated the
PR.
> The PR as currently written restricts describing configs via --zookeeper
to user and brok
[
https://issues.apache.org/jira/browse/KAFKA-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming resolved KAFKA-13042.
Resolution: Fixed
> Flaky test KafkaMetadataLogTest.testDeleteSnapshots()
> --
cmccabe commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r667401789
##
File path:
metadata/src/main/resources/common/metadata/PartitionChangeRecord.json
##
@@ -29,6 +29,15 @@
"about": "null if the ISR didn't change
rondagostino commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r667389229
##
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##
@@ -133,13 +183,13 @@ class ConfigCommandTest extends ZooKeeperTestHarn
showuon edited a comment on pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#issuecomment-877717089
@ijuma , I've uploaded the PR. Please take a look again. Thanks.
Failed tests are unrelated.
```
Build / JDK 11 and Scala 2.13 /
kafka.api.ConsumerBounceT
showuon commented on pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#issuecomment-877717089
@ijuma , I've uploaded the PR. Please take a look again. Thanks.
Failed tests are unrelated.
```
Build / JDK 11 and Scala 2.13 /
kafka.api.ConsumerBounceTest
showuon commented on pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#issuecomment-877715816
@hachikuji , I've addressed your comments. Please take a look again.
Failed tests are unrelated. Thanks.
```
Build / JDK 11 and Scala 2.13 /
kafka.api.ConsumerBo
[
https://issues.apache.org/jira/browse/KAFKA-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378535#comment-17378535
]
meher ben ahmed edited comment on KAFKA-13042 at 7/10/21, 10:34 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378535#comment-17378535
]
meher ben ahmed edited comment on KAFKA-13042 at 7/10/21, 10:34 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378535#comment-17378535
]
meher ben ahmed commented on KAFKA-13042:
-
[~dengziming] so this the erro you ge
tchiotludo closed pull request #6067:
URL: https://github.com/apache/kafka/pull/6067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
[
https://issues.apache.org/jira/browse/KAFKA-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13056.
-
Fix Version/s: 3.0.0
Resolution: Fixed
> Broker should not generate snapshots whe
hachikuji merged pull request #11013:
URL: https://github.com/apache/kafka/pull/11013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
[
https://issues.apache.org/jira/browse/KAFKA-13057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13057.
-
Fix Version/s: 3.0.0
Resolution: Fixed
> Many broker RPCs are not enable in KRaft
[
https://issues.apache.org/jira/browse/KAFKA-13057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-13057:
Affects Version/s: (was: 3.0.0)
> Many broker RPCs are not enable in KRaft mode
>
hachikuji merged pull request #11012:
URL: https://github.com/apache/kafka/pull/11012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
dajac commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r667364123
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging {
formatter.confi
xvrl commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r667362757
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging {
formatter.config
xvrl commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r667362757
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging {
formatter.config
dajac commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r667361961
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging {
formatter.confi
chia7712 commented on a change in pull request #11017:
URL: https://github.com/apache/kafka/pull/11017#discussion_r667361897
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -246,10 +246,15 @@ State setState(final State n
wycc opened a new pull request #11017:
URL: https://github.com/apache/kafka/pull/11017
Development of EasyMock and PowerMock has stagnated while Mockito continues
to be actively developed. With the new Java cadence, it's a problem to depend
on libraries that do bytecode generation and
dajac opened a new pull request #11016:
URL: https://github.com/apache/kafka/pull/11016
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing s
xvrl commented on a change in pull request #11007:
URL: https://github.com/apache/kafka/pull/11007#discussion_r667359922
##
File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
##
@@ -89,11 +89,16 @@ object ReplicaVerificationTool extends Logging {
xvrl commented on a change in pull request #11007:
URL: https://github.com/apache/kafka/pull/11007#discussion_r667359994
##
File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
##
@@ -143,11 +152,11 @@ object ReplicaVerificationTool extends Logging {
}
xvrl commented on a change in pull request #11007:
URL: https://github.com/apache/kafka/pull/11007#discussion_r667359994
##
File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
##
@@ -143,11 +152,11 @@ object ReplicaVerificationTool extends Logging {
}
xvrl commented on a change in pull request #11007:
URL: https://github.com/apache/kafka/pull/11007#discussion_r667359994
##
File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
##
@@ -143,11 +152,11 @@ object ReplicaVerificationTool extends Logging {
}
xvrl commented on a change in pull request #11007:
URL: https://github.com/apache/kafka/pull/11007#discussion_r667359922
##
File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
##
@@ -89,11 +89,16 @@ object ReplicaVerificationTool extends Logging {
dajac commented on a change in pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#discussion_r667347765
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -136,21 +142,28 @@ private void ha
showuon commented on a change in pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#discussion_r667340973
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -136,21 +142,28 @@ private void
OmniaGM commented on pull request #11007:
URL: https://github.com/apache/kafka/pull/11007#issuecomment-877638062
Hi, @xvrl can you please have a look into this? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dajac commented on pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#issuecomment-877633235
@showuon Thanks for the patch. I have started to look at it. I have left a
comment which is not really related to your PR. I think that we got the error
handling wrong in some pla
dajac commented on a change in pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#discussion_r667335981
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##
@@ -136,21 +142,28 @@ private void ha
[
https://issues.apache.org/jira/browse/KAFKA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
HaiyuanZhao reassigned KAFKA-12461:
---
Assignee: HaiyuanZhao
> Extend LogManager to cover the metadata topic
> ---
zhaohaidao opened a new pull request #11015:
URL: https://github.com/apache/kafka/pull/11015
The original issue said both the MockLog and KafkaMetadataLog should only
allow appendAsLeader and appendAsFollower with monotonically increasing epochs.
However, interface method appendAsFollowe
[
https://issues.apache.org/jira/browse/KAFKA-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
HaiyuanZhao reassigned KAFKA-12333:
---
Assignee: HaiyuanZhao
> KafkaMetadataLog and MockLock should validate that appended epochs
showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r667309366
##
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##
@@ -850,22 +890,19 @@ class ConfigCommandTest extends ZooKeeperTestHarness w
showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r667309320
##
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##
@@ -290,14 +340,9 @@ class ConfigCommandTest extends ZooKeeperTestHarness wi
showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r667309254
##
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##
@@ -60,6 +59,48 @@ class ConfigCommandTest extends ZooKeeperTestHarness with
showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r667309248
##
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##
@@ -876,6 +872,11 @@ object ConfigCommand extends Config {
throw new Illegal
rajinisivaram merged pull request #11000:
URL: https://github.com/apache/kafka/pull/11000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-uns
rajinisivaram commented on pull request #11000:
URL: https://github.com/apache/kafka/pull/11000#issuecomment-877589134
Test failures not related, merging to trunk and 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
48 matches
Mail list logo
