[GitHub] [kafka] showuon opened a new pull request #11234: [WIP] KAFKA-13212: add support infinite query for session store

2021-08-18 Thread GitBox
showuon opened a new pull request #11234: URL: https://github.com/apache/kafka/pull/11234 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Commented] (KAFKA-10038) ConsumerPerformance.scala supports the setting of client.id

2021-08-18 Thread Yanwen Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401490#comment-17401490 ] Yanwen Lin commented on KAFKA-10038: Hi [~apompeev], are you still working on this one or I can take

[jira] [Assigned] (KAFKA-12766) Consider Disabling WAL-related Options in RocksDB

2021-08-18 Thread Tomer Wizman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomer Wizman reassigned KAFKA-12766: Assignee: Tomer Wizman > Consider Disabling WAL-related Options in RocksDB >

[GitHub] [kafka] kkonstantine merged pull request #11232: MINOR: Add missing licenses and update versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
kkonstantine merged pull request #11232: URL: https://github.com/apache/kafka/pull/11232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-18 Thread GitBox
rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r691775378 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsProducerTest.java ## @@ -1121,4 +1125,60 @@ public void

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-18 Thread GitBox
rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r691768579 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsThreadTotalBlockedTime.java ## @@ -0,0 +1,59 @@ +/* + * Licensed

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-18 Thread GitBox
rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r691767731 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -200,6 +201,30 @@ public

[jira] [Created] (KAFKA-13218) kafka deleted unexpired message unexpectedly

2021-08-18 Thread leiminghany (Jira)
leiminghany created KAFKA-13218: --- Summary: kafka deleted unexpired message unexpectedly Key: KAFKA-13218 URL: https://issues.apache.org/jira/browse/KAFKA-13218 Project: Kafka Issue Type: Bug

[GitHub] [kafka] rhauch commented on a change in pull request #11232: MINOR: Add missing licenses and update versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
rhauch commented on a change in pull request #11232: URL: https://github.com/apache/kafka/pull/11232#discussion_r691743181 ## File path: LICENSE-binary ## @@ -208,52 +208,52 @@ License Version 2.0: audience-annotations-0.5.0 commons-cli-1.4 commons-lang3-3.8.1

[GitHub] [kafka] mjsax opened a new pull request #11233: HOTIFX: Disable spurious left/outer stream-stream join fix

2021-08-18 Thread GitBox
mjsax opened a new pull request #11233: URL: https://github.com/apache/kafka/pull/11233 KAFKA-10847 improves stream-stream left/outer joins to avoid spurious left/outer join results. However, it introduces regression bug KAFKA-13216. This PR disables KAFKA-10847 by partially

[jira] [Commented] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

2021-08-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401433#comment-17401433 ] A. Sophie Blee-Goldman commented on KAFKA-13217: This is all the more important given

[jira] [Created] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

2021-08-18 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13217: -- Summary: Reconsider skipping the LeaveGroup on close() or add an overload that does so Key: KAFKA-13217 URL: https://issues.apache.org/jira/browse/KAFKA-13217

[jira] [Updated] (KAFKA-13204) wrong assignor selected if the assignor name is identical

2021-08-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13204: --- Fix Version/s: 3.1.0 > wrong assignor selected if the assignor name is

[GitHub] [kafka] kkonstantine edited a comment on pull request #11232: MINOR: Update package versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
kkonstantine edited a comment on pull request #11232: URL: https://github.com/apache/kafka/pull/11232#issuecomment-901540065 Hey @rhauch. I replied to the other comments inline. Regarding your question: > Do you plan to backport this, and if so to what branches? This was ran

[GitHub] [kafka] kkonstantine edited a comment on pull request #11232: MINOR: Update package versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
kkonstantine edited a comment on pull request #11232: URL: https://github.com/apache/kafka/pull/11232#issuecomment-901540065 Hey @rhauch. I replied to the other comments inline. Regarding your question: > Do you plan to backport this, and if so to what branches? This was ran

[GitHub] [kafka] kkonstantine commented on pull request #11232: MINOR: Update package versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
kkonstantine commented on pull request #11232: URL: https://github.com/apache/kafka/pull/11232#issuecomment-901540065 Hey @rhauch. I replied to the other comments inline. Regarding your question: > Do you plan to backport this, and if so to what branches? This was run

[GitHub] [kafka] kkonstantine commented on a change in pull request #11232: MINOR: Update package versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
kkonstantine commented on a change in pull request #11232: URL: https://github.com/apache/kafka/pull/11232#discussion_r691710928 ## File path: LICENSE-binary ## @@ -208,52 +208,52 @@ License Version 2.0: audience-annotations-0.5.0 commons-cli-1.4 commons-lang3-3.8.1

[GitHub] [kafka] kkonstantine commented on a change in pull request #11232: MINOR: Update package versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
kkonstantine commented on a change in pull request #11232: URL: https://github.com/apache/kafka/pull/11232#discussion_r691710720 ## File path: LICENSE-binary ## @@ -208,52 +208,52 @@ License Version 2.0: audience-annotations-0.5.0 commons-cli-1.4 commons-lang3-3.8.1

[GitHub] [kafka] kkonstantine commented on a change in pull request #11232: MINOR: Update package versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
kkonstantine commented on a change in pull request #11232: URL: https://github.com/apache/kafka/pull/11232#discussion_r691710309 ## File path: LICENSE-binary ## @@ -208,52 +208,52 @@ License Version 2.0: audience-annotations-0.5.0 commons-cli-1.4 commons-lang3-3.8.1

[GitHub] [kafka] kkonstantine commented on a change in pull request #11232: MINOR: Update package versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
kkonstantine commented on a change in pull request #11232: URL: https://github.com/apache/kafka/pull/11232#discussion_r691710309 ## File path: LICENSE-binary ## @@ -208,52 +208,52 @@ License Version 2.0: audience-annotations-0.5.0 commons-cli-1.4 commons-lang3-3.8.1

[GitHub] [kafka] rhauch commented on pull request #11232: MINOR: Update package versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
rhauch commented on pull request #11232: URL: https://github.com/apache/kafka/pull/11232#issuecomment-901534553 Do you plan to backport this, and if so to what branches? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] rhauch commented on a change in pull request #11232: MINOR: Update package versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
rhauch commented on a change in pull request #11232: URL: https://github.com/apache/kafka/pull/11232#discussion_r691705388 ## File path: LICENSE-binary ## @@ -208,52 +208,52 @@ License Version 2.0: audience-annotations-0.5.0 commons-cli-1.4 commons-lang3-3.8.1

[GitHub] [kafka] hachikuji commented on a change in pull request #11225: MINOR; Small optimizations in `ReplicaManager#becomeLeaderOrFollower`

2021-08-18 Thread GitBox
hachikuji commented on a change in pull request #11225: URL: https://github.com/apache/kafka/pull/11225#discussion_r691706079 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1436,17 +1438,15 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] hachikuji commented on a change in pull request #11225: MINOR; Small optimizations in `ReplicaManager#becomeLeaderOrFollower`

2021-08-18 Thread GitBox
hachikuji commented on a change in pull request #11225: URL: https://github.com/apache/kafka/pull/11225#discussion_r691703790 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1436,17 +1438,15 @@ class ReplicaManager(val config: KafkaConfig,

[jira] [Updated] (KAFKA-13216) Streams left/outer joins cause new internal changelog topic to grow unbounded

2021-08-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13216: Fix Version/s: 3.0.0 > Streams left/outer joins cause new internal changelog topic to

[jira] [Commented] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401410#comment-17401410 ] A. Sophie Blee-Goldman commented on KAFKA-12994: Hey guys, thanks for picking this up!

[GitHub] [kafka] kkonstantine opened a new pull request #11232: MINOR: Update package versions in LICENSE-binary for 3.0

2021-08-18 Thread GitBox
kkonstantine opened a new pull request #11232: URL: https://github.com/apache/kafka/pull/11232 One new dependency was missing a license entry [jline](https://github.com/jline/jline3) The rest of the changes correspond to updated package versions. No functional changes in the code

[GitHub] [kafka] hachikuji commented on a change in pull request #11229: KAFKA-12961; Verify group generation in `DelayedJoin`

2021-08-18 Thread GitBox
hachikuji commented on a change in pull request #11229: URL: https://github.com/apache/kafka/pull/11229#discussion_r691694091 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1391,78 +1392,92 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] ableegoldman merged pull request #11217: KAFKA-13204: assignor name conflict check

2021-08-18 Thread GitBox
ableegoldman merged pull request #11217: URL: https://github.com/apache/kafka/pull/11217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11217: KAFKA-13204: assignor name conflict check

2021-08-18 Thread GitBox
ableegoldman commented on pull request #11217: URL: https://github.com/apache/kafka/pull/11217#issuecomment-901516021 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman commented on pull request #11217: KAFKA-13204: assignor name conflict check

2021-08-18 Thread GitBox
ableegoldman commented on pull request #11217: URL: https://github.com/apache/kafka/pull/11217#issuecomment-901515775 Test failure is unrelated: `StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread` -- This is an automated message from the Apache Git Service.

[jira] [Commented] (KAFKA-12550) Introduce RESTORING state to the KafkaStreams FSM

2021-08-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401408#comment-17401408 ] A. Sophie Blee-Goldman commented on KAFKA-12550: Yeah, the RESTORING would be an

[GitHub] [kafka] ableegoldman merged pull request #11068: KAFKA-13081: detect doubly assigned parition (for v2.8)

2021-08-18 Thread GitBox
ableegoldman merged pull request #11068: URL: https://github.com/apache/kafka/pull/11068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on a change in pull request #11124: KAFKA-12839: Let SlidingWindows aggregation support window size of 0

2021-08-18 Thread GitBox
ableegoldman commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r691646220 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,78 @@

[jira] [Created] (KAFKA-13216) Streams left/outer joins cause new internal changelog topic to grow unbounded

2021-08-18 Thread Jira
Sergio Peña created KAFKA-13216: --- Summary: Streams left/outer joins cause new internal changelog topic to grow unbounded Key: KAFKA-13216 URL: https://issues.apache.org/jira/browse/KAFKA-13216 Project:

[GitHub] [kafka] guozhangwang commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-18 Thread GitBox
guozhangwang commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r691613659 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsProducerTest.java ## @@ -1121,4 +1125,60 @@ public void

[jira] [Commented] (KAFKA-13152) Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-08-18 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401318#comment-17401318 ] Guozhang Wang commented on KAFKA-13152: --- I think it's a good idea to continue our discussion on

[GitHub] [kafka] hachikuji commented on a change in pull request #11231: KAFKA-13214; Consumer should not reset state after retriable error in rebalance

2021-08-18 Thread GitBox
hachikuji commented on a change in pull request #11231: URL: https://github.com/apache/kafka/pull/11231#discussion_r691522435 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -476,7 +476,6 @@ boolean

[GitHub] [kafka] hachikuji commented on a change in pull request #11231: KAFKA-13214; Consumer should not reset state after retriable error in rebalance

2021-08-18 Thread GitBox
hachikuji commented on a change in pull request #11231: URL: https://github.com/apache/kafka/pull/11231#discussion_r691522435 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -476,7 +476,6 @@ boolean

[jira] [Commented] (KAFKA-13152) Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-08-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401302#comment-17401302 ] Matthias J. Sax commented on KAFKA-13152: - [~guozhang] – your proposal to only pause partitions

[GitHub] [kafka] hachikuji opened a new pull request #11231: KAFKA-13214; Consumer should not reset state after retriable error in rebalance

2021-08-18 Thread GitBox
hachikuji opened a new pull request #11231: URL: https://github.com/apache/kafka/pull/11231 Currently the consumer will reset state after any retriable error during a rebalance. This includes coordinator disconnects as well as coordinator changes. The impact of this is that rebalances get

[GitHub] [kafka] lbradstreet commented on a change in pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

2021-08-18 Thread GitBox
lbradstreet commented on a change in pull request #11230: URL: https://github.com/apache/kafka/pull/11230#discussion_r691487441 ## File path: core/src/main/scala/kafka/server/ConfigHandler.scala ## @@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,

[jira] [Commented] (KAFKA-12713) Report "REAL" follower/consumer fetch latency

2021-08-18 Thread Kai Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401270#comment-17401270 ] Kai Huang commented on KAFKA-12713: --- [~ijuma] Thanks for the pointer. I've bumped up the [discussion

[jira] [Assigned] (KAFKA-13214) Consumer should not reset group state after disconnect

2021-08-18 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-13214: --- Assignee: Jason Gustafson > Consumer should not reset group state after disconnect

[GitHub] [kafka] jsancio commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

2021-08-18 Thread GitBox
jsancio commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r690620725 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -113,7 +113,7 @@ class BrokerServer( var dynamicConfigHandlers: Map[String,

[GitHub] [kafka] junrao merged pull request #11216: KAFKA-13198: Stop replicas when reassigned

2021-08-18 Thread GitBox
junrao merged pull request #11216: URL: https://github.com/apache/kafka/pull/11216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] yangdaixai closed pull request #11185: KAFKA-13175; Better indicates for created topic is marked for deleti…

2021-08-18 Thread GitBox
yangdaixai closed pull request #11185: URL: https://github.com/apache/kafka/pull/11185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #11073: KAFKA-13092: Perf regression in LISR requests

2021-08-18 Thread GitBox
dajac commented on pull request #11073: URL: https://github.com/apache/kafka/pull/11073#issuecomment-901015825 @jolshan is it something that we must add to 2.8.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] jomach commented on pull request #9493: KAFKA-10640: Add recursive support to Connect Cast and ReplaceField transforms, and support for casting complex types to either a native or JSO

2021-08-18 Thread GitBox
jomach commented on pull request #9493: URL: https://github.com/apache/kafka/pull/9493#issuecomment-901121979 seems to be some conflicts. @joshuagrisham can you fix them please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] rajinisivaram commented on pull request #11221: KAFKA-13207: Skip truncation on fetch response with diverging epoch if partition removed from fetcher

2021-08-18 Thread GitBox
rajinisivaram commented on pull request #11221: URL: https://github.com/apache/kafka/pull/11221#issuecomment-900433010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] showuon commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-18 Thread GitBox
showuon commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r691052026 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java ## @@ -124,8 +124,8 @@

[GitHub] [kafka] vvcephei commented on a change in pull request #11213: KAFKA-13201: Convert KTable aggregations to new PAPI

2021-08-18 Thread GitBox
vvcephei commented on a change in pull request #11213: URL: https://github.com/apache/kafka/pull/11213#discussion_r690642563 ## File path: streams/src/test/java/org/apache/kafka/test/MockInternalNewProcessorContext.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-08-18 Thread GitBox
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-901030641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] Justinwins commented on a change in pull request #10652: KAFKA-9726 IdentityReplicationPolicy

2021-08-18 Thread GitBox
Justinwins commented on a change in pull request #10652: URL: https://github.com/apache/kafka/pull/10652#discussion_r684042834 ## File path: docs/upgrade.html ## @@ -83,7 +83,13 @@ Notable changes in 3 understood by brokers or version 2.5 or higher, so you must

[GitHub] [kafka] dajac commented on a change in pull request #11225: MINOR; Small optimizations in `ReplicaManager#becomeLeaderOrFollower`

2021-08-18 Thread GitBox
dajac commented on a change in pull request #11225: URL: https://github.com/apache/kafka/pull/11225#discussion_r691041467 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1436,17 +1438,15 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] dajac commented on pull request #11221: KAFKA-13207: Skip truncation on fetch response with diverging epoch if partition removed from fetcher

2021-08-18 Thread GitBox
dajac commented on pull request #11221: URL: https://github.com/apache/kafka/pull/11221#issuecomment-900541736 @rajinisivaram Should we also add it to 2.8 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] junrao commented on a change in pull request #11216: KAFKA-13198: Stop replicas when reassigned

2021-08-18 Thread GitBox
junrao commented on a change in pull request #11216: URL: https://github.com/apache/kafka/pull/11216#discussion_r690492221 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -113,7 +113,7 @@ class BrokerServer( var dynamicConfigHandlers: Map[String,

[GitHub] [kafka] guozhangwang merged pull request #11184: KAFKA-13172: Add downgrade guidance note for 3.0

2021-08-18 Thread GitBox
guozhangwang merged pull request #11184: URL: https://github.com/apache/kafka/pull/11184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] lbradstreet commented on a change in pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

2021-08-18 Thread GitBox
lbradstreet commented on a change in pull request #11230: URL: https://github.com/apache/kafka/pull/11230#discussion_r691368381 ## File path: core/src/main/scala/kafka/server/ConfigHandler.scala ## @@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,

[GitHub] [kafka] guozhangwang commented on a change in pull request #11184: KAFKA-13172: Add downgrade guidance note for 3.0

2021-08-18 Thread GitBox
guozhangwang commented on a change in pull request #11184: URL: https://github.com/apache/kafka/pull/11184#discussion_r690792216 ## File path: docs/streams/upgrade-guide.html ## @@ -52,6 +52,15 @@ Upgrade Guide and API Changes restart all new ({{fullDotVersion}})

[GitHub] [kafka] rajinisivaram merged pull request #11221: KAFKA-13207: Skip truncation on fetch response with diverging epoch if partition removed from fetcher

2021-08-18 Thread GitBox
rajinisivaram merged pull request #11221: URL: https://github.com/apache/kafka/pull/11221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on pull request #11073: KAFKA-13092: Perf regression in LISR requests

2021-08-18 Thread GitBox
jolshan commented on pull request #11073: URL: https://github.com/apache/kafka/pull/11073#issuecomment-901220052 Ah yes. I had a feeling I still had a pr open for this. I think I can clean it up a bit and it should be ready for review by tomorrow. -- This is an automated message from

[GitHub] [kafka] guozhangwang commented on pull request #11184: KAFKA-13172: Add downgrade guidance note for 3.0

2021-08-18 Thread GitBox
guozhangwang commented on pull request #11184: URL: https://github.com/apache/kafka/pull/11184#issuecomment-900710127 Cherry-picked to 3.0 to be included in the 3.0 docs cc @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cadonna commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-18 Thread GitBox
cadonna commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r691098389 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsThreadTotalBlockedTime.java ## @@ -0,0 +1,59 @@ +/* + * Licensed

[jira] [Updated] (KAFKA-13215) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectEndOffsetInformation

2021-08-18 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13215: --- Description: Integration test {{test

[GitHub] [kafka] omkreddy merged pull request #11224: KAFKA-13209: Upgrade jetty-server to fix CVE-2021-34429

2021-08-18 Thread GitBox
omkreddy merged pull request #11224: URL: https://github.com/apache/kafka/pull/11224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-18 Thread GitBox
dajac commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r690993461 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,

[jira] [Assigned] (KAFKA-13215) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectEndOffsetInformation

2021-08-18 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis reassigned KAFKA-13215: -- Assignee: (was: Walker Carlson) > Flaky test >

[jira] [Created] (KAFKA-13215) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectEndOffsetInformation

2021-08-18 Thread Konstantine Karantasis (Jira)
Konstantine Karantasis created KAFKA-13215: -- Summary: Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectEndOffsetInformation Key: KAFKA-13215 URL:

[jira] [Updated] (KAFKA-13215) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectEndOffsetInformation

2021-08-18 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13215: --- Reporter: Konstantine Karantasis (was: Bruno Cadonna) > Flaky test >

[GitHub] [kafka] rondagostino commented on pull request #6233: KAFKA-7902: Replace original loginContext if SASL/OAUTHBEARER refresh login fails

2021-08-18 Thread GitBox
rondagostino commented on pull request #6233: URL: https://github.com/apache/kafka/pull/6233#issuecomment-900456795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] jolshan commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-18 Thread GitBox
jolshan commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r691366479 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] venkatesh010 commented on pull request #6233: KAFKA-7902: Replace original loginContext if SASL/OAUTHBEARER refresh login fails

2021-08-18 Thread GitBox
venkatesh010 commented on pull request #6233: URL: https://github.com/apache/kafka/pull/6233#issuecomment-900514731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] dajac commented on a change in pull request #11173: MINOR: Support max timestamp in GetOffsetShell

2021-08-18 Thread GitBox
dajac commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r691375264 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -224,9 +227,14 @@ object GetOffsetShell { /** * Return the partition infos.

[GitHub] [kafka] dajac commented on a change in pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

2021-08-18 Thread GitBox
dajac commented on a change in pull request #11230: URL: https://github.com/apache/kafka/pull/11230#discussion_r691396770 ## File path: core/src/main/scala/kafka/server/ConfigHandler.scala ## @@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,

[jira] [Created] (KAFKA-13214) Consumer should not reset group state after disconnect

2021-08-18 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13214: --- Summary: Consumer should not reset group state after disconnect Key: KAFKA-13214 URL: https://issues.apache.org/jira/browse/KAFKA-13214 Project: Kafka

[GitHub] [kafka] dajac commented on a change in pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

2021-08-18 Thread GitBox
dajac commented on a change in pull request #11230: URL: https://github.com/apache/kafka/pull/11230#discussion_r691400434 ## File path: core/src/main/scala/kafka/server/ConfigHandler.scala ## @@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,

[GitHub] [kafka] dajac commented on a change in pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

2021-08-18 Thread GitBox
dajac commented on a change in pull request #11230: URL: https://github.com/apache/kafka/pull/11230#discussion_r691396770 ## File path: core/src/main/scala/kafka/server/ConfigHandler.scala ## @@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,

[GitHub] [kafka] dajac commented on a change in pull request #11173: MINOR: Support max timestamp in GetOffsetShell

2021-08-18 Thread GitBox
dajac commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r691375264 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -224,9 +227,14 @@ object GetOffsetShell { /** * Return the partition infos.

[GitHub] [kafka] jolshan commented on pull request #11073: KAFKA-13092: Perf regression in LISR requests

2021-08-18 Thread GitBox
jolshan commented on pull request #11073: URL: https://github.com/apache/kafka/pull/11073#issuecomment-901220052 Ah yes. I had a feeling I still had a pr open for this. I think I can clean it up a bit and it should be ready for review by tomorrow. -- This is an automated message from

[GitHub] [kafka] lbradstreet commented on a change in pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

2021-08-18 Thread GitBox
lbradstreet commented on a change in pull request #11230: URL: https://github.com/apache/kafka/pull/11230#discussion_r691368381 ## File path: core/src/main/scala/kafka/server/ConfigHandler.scala ## @@ -66,8 +66,13 @@ class TopicConfigHandler(private val logManager: LogManager,

[GitHub] [kafka] jolshan commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-18 Thread GitBox
jolshan commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r691366479 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] dajac opened a new pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

2021-08-18 Thread GitBox
dajac opened a new pull request #11230: URL: https://github.com/apache/kafka/pull/11230 When `compact` is removed from the `cleanup.policy` of a topic, the compactions of that topic should be aborted. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] cadonna commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-18 Thread GitBox
cadonna commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r691098389 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsThreadTotalBlockedTime.java ## @@ -0,0 +1,59 @@ +/* + * Licensed

[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-08-18 Thread GitBox
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-901123276 Test failure was https://issues.apache.org/jira/browse/KAFKA-8529 which was apparently resolved. I reopened the issue. I rebased this PR to the trunk of a couple of hours ago.

[GitHub] [kafka] jomach commented on pull request #9493: KAFKA-10640: Add recursive support to Connect Cast and ReplaceField transforms, and support for casting complex types to either a native or JSO

2021-08-18 Thread GitBox
jomach commented on pull request #9493: URL: https://github.com/apache/kafka/pull/9493#issuecomment-901121979 seems to be some conflicts. @joshuagrisham can you fix them please ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-8529) Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-08-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401062#comment-17401062 ] Josep Prat commented on KAFKA-8529: --- I'll reopen this issue as it happened again on a fresh PR:

[jira] [Reopened] (KAFKA-8529) Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-08-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reopened KAFKA-8529: --- > Flakey test ConsumerBounceTest#testCloseDuringRebalance >

[jira] [Commented] (KAFKA-8295) Add merge() operator to State Stores.

2021-08-18 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401043#comment-17401043 ] Sagar Rao commented on KAFKA-8295: -- I see. Is there a KIP for list append types for windowed joins? I

[jira] [Commented] (KAFKA-13152) Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-08-18 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401034#comment-17401034 ] Sagar Rao commented on KAFKA-13152: --- [~mjsax], [~guozhang] I had a slightly different thought whereby

[jira] [Created] (KAFKA-13213) StreamThread: State transition from PARTITIONS_ASSIGNED to PARTITIONS_ASSIGNED

2021-08-18 Thread Patrik Kleindl (Jira)
Patrik Kleindl created KAFKA-13213: -- Summary: StreamThread: State transition from PARTITIONS_ASSIGNED to PARTITIONS_ASSIGNED Key: KAFKA-13213 URL: https://issues.apache.org/jira/browse/KAFKA-13213

[GitHub] [kafka] dajac opened a new pull request #11229: KAFKA-12961; Verify group generation in `DelayedJoin`

2021-08-18 Thread GitBox
dajac opened a new pull request #11229: URL: https://github.com/apache/kafka/pull/11229 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-08-18 Thread GitBox
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-901030641 cc. @guozhangwang Feel free to review this PR and let me know if this is what you had in mind with https://issues.apache.org/jira/browse/KAFKA-12887 -- This is an automated

[GitHub] [kafka] jlprat opened a new pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-08-18 Thread GitBox
jlprat opened a new pull request #11228: URL: https://github.com/apache/kafka/pull/11228 Instead of letting all `RuntimeException`s go through and be processed by the uncaught exception handler, `IllegalStateException` and `IllegalArgumentException` are not passed through and fail

[GitHub] [kafka] dajac commented on pull request #11073: KAFKA-13092: Perf regression in LISR requests

2021-08-18 Thread GitBox
dajac commented on pull request #11073: URL: https://github.com/apache/kafka/pull/11073#issuecomment-901015825 @jolshan is it something that we must add to 2.8.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] showuon commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-18 Thread GitBox
showuon commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r691055719 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/SegmentIterator.java ## @@ -74,7 +74,7 @@ public boolean hasNext() {

[GitHub] [kafka] showuon commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-18 Thread GitBox
showuon commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r691053240 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java ## @@ -573,12 +573,14 @@ private void

[GitHub] [kafka] showuon commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-18 Thread GitBox
showuon commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r691052026 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java ## @@ -124,8 +124,8 @@

[GitHub] [kafka] showuon opened a new pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-18 Thread GitBox
showuon opened a new pull request #11227: URL: https://github.com/apache/kafka/pull/11227 Add support for infinite range query for WindowStore. Story JIRA: https://issues.apache.org/jira/browse/KAFKA-13210 ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] dajac commented on a change in pull request #11225: MINOR; Small optimizations in `ReplicaManager#becomeLeaderOrFollower`

2021-08-18 Thread GitBox
dajac commented on a change in pull request #11225: URL: https://github.com/apache/kafka/pull/11225#discussion_r691041467 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1436,17 +1438,15 @@ class ReplicaManager(val config: KafkaConfig,

  1   2   >