[GitHub] [kafka] YeonCheolGit opened a new pull request #11849: [Delete] unused field in Topic.java

2022-03-04 Thread GitBox
YeonCheolGit opened a new pull request #11849: URL: https://github.com/apache/kafka/pull/11849 Delete unused field in Topic.java ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [

[GitHub] [kafka] YeonCheolGit commented on a change in pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

2022-03-04 Thread GitBox
YeonCheolGit commented on a change in pull request #11848: URL: https://github.com/apache/kafka/pull/11848#discussion_r820060984 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java ## @@ -131,67 +129,56 @@ public void

[GitHub] [kafka] YeonCheolGit commented on a change in pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

2022-03-04 Thread GitBox
YeonCheolGit commented on a change in pull request #11848: URL: https://github.com/apache/kafka/pull/11848#discussion_r820060984 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java ## @@ -131,67 +129,56 @@ public void

[GitHub] [kafka] vvcephei opened a new pull request #11848: MINOR: Restructure ConsistencyVectorIntegrationTest

2022-03-04 Thread GitBox
vvcephei opened a new pull request #11848: URL: https://github.com/apache/kafka/pull/11848 The test experienced a flaky failure, but there were too many unknowns to determine the cause. This change restructures the test to make the cause more clear. ### Committer Checklist

[GitHub] [kafka] showuon commented on a change in pull request #11841: KAFKA-13705: CoreUtils.swallow uses logging parameter instead of Logger

2022-03-04 Thread GitBox
showuon commented on a change in pull request #11841: URL: https://github.com/apache/kafka/pull/11841#discussion_r820024434 ## File path: gradle/spotbugs-exclude.xml ## @@ -49,6 +49,7 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read

[GitHub] [kafka] showuon commented on a change in pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-04 Thread GitBox
showuon commented on a change in pull request #11775: URL: https://github.com/apache/kafka/pull/11775#discussion_r820022615 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected SourceConnectorContext

[GitHub] [kafka] showuon commented on a change in pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-04 Thread GitBox
showuon commented on a change in pull request #11775: URL: https://github.com/apache/kafka/pull/11775#discussion_r820022262 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected SourceConnectorContext

[GitHub] [kafka] Corlobin commented on pull request #11844: KAFKA#13702 - Connect RestClient overrides response status code on request failure

2022-03-04 Thread GitBox
Corlobin commented on pull request #11844: URL: https://github.com/apache/kafka/pull/11844#issuecomment-1059646232 Hi @showuon, could you review please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] suhas-satish commented on pull request #11820: [RFC][2/N] add restoration logic for RocksDBTimeOrderedWindowStore

2022-03-04 Thread GitBox
suhas-satish commented on pull request #11820: URL: https://github.com/apache/kafka/pull/11820#issuecomment-1059612004 @lihaosky , why is this not needed anymore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] jnh5y commented on a change in pull request #11802: [RFC][1/N]add new RocksDBTimeOrderedWindowStore

2022-03-04 Thread GitBox
jnh5y commented on a change in pull request #11802: URL: https://github.com/apache/kafka/pull/11802#discussion_r819982680 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java ## @@ -0,0 +1,267 @@ +/* +

[GitHub] [kafka] jolshan commented on a change in pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-04 Thread GitBox
jolshan commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r819975209 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -103,59 +104,76 @@ object GetOffsetShell { throw new

[GitHub] [kafka] jolshan commented on a change in pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-04 Thread GitBox
jolshan commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r819973628 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -189,22 +209,26 @@ object GetOffsetShell { val topicFilter =

[jira] [Updated] (KAFKA-13699) ProcessorContext does not expose Stream Time

2022-03-04 Thread Shay Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shay Lin updated KAFKA-13699: - Description: As a KS developer, I would like to leverage

[jira] [Commented] (KAFKA-13699) ProcessorContext does not expose Stream Time

2022-03-04 Thread Shay Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501571#comment-17501571 ] Shay Lin commented on KAFKA-13699: -- Hi team [~guozhang] [~mjsax] yes, as Matthias mentioned, the

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-04 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r818829273 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[jira] [Created] (KAFKA-13709) Document exactly-once support for source connectors

2022-03-04 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-13709: - Summary: Document exactly-once support for source connectors Key: KAFKA-13709 URL: https://issues.apache.org/jira/browse/KAFKA-13709 Project: Kafka Issue

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-04 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r819951647 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/TransactionContext.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a change in pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-04 Thread GitBox
C0urante commented on a change in pull request #11775: URL: https://github.com/apache/kafka/pull/11775#discussion_r819945829 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceTask.java ## @@ -16,17 +16,63 @@ */ package

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-04 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r819945019 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceTask.java ## @@ -16,17 +16,63 @@ */ package

[GitHub] [kafka] C0urante commented on a change in pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-04 Thread GitBox
C0urante commented on a change in pull request #11775: URL: https://github.com/apache/kafka/pull/11775#discussion_r819939810 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[GitHub] [kafka] C0urante commented on a change in pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-04 Thread GitBox
C0urante commented on a change in pull request #11775: URL: https://github.com/apache/kafka/pull/11775#discussion_r819937017 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[GitHub] [kafka] wcarlson5 commented on pull request #11847: KAFKA-12648: fix NPE due to race condtion between resetting offsets and removing a topology

2022-03-04 Thread GitBox
wcarlson5 commented on pull request #11847: URL: https://github.com/apache/kafka/pull/11847#issuecomment-1059530699 That is a lot of test failures and some of those seem relevant

[GitHub] [kafka] jeff303 commented on a change in pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-03-04 Thread GitBox
jeff303 commented on a change in pull request #11792: URL: https://github.com/apache/kafka/pull/11792#discussion_r819904687 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java ## @@ -917,6 +955,7 @@ public void

[GitHub] [kafka] Corlobin commented on pull request #11841: KAFKA-13705: CoreUtils.swallow uses logging parameter instead of Logger

2022-03-04 Thread GitBox
Corlobin commented on pull request #11841: URL: https://github.com/apache/kafka/pull/11841#issuecomment-1059516594 Hi @showuon, I believe that is a false-positive, running the spotbugsMain from trunk I receive 6 warnings as described below: https://github.com/spotbugs/spotbugs/issues/1963

[GitHub] [kafka] savinov edited a comment on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-04 Thread GitBox
savinov edited a comment on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1058005727 In my case follower doesn't update configuration because **changed** flag keeps **false** value. Neither task count has been changed nor task configs.

[GitHub] [kafka] philipnee commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-04 Thread GitBox
philipnee commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r819898973 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rhauch commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-04 Thread GitBox
rhauch commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r819884210 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-04 Thread GitBox
philipnee commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r819871715 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-04 Thread GitBox
philipnee commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r819863248 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] kirktrue commented on a change in pull request #11707: KAFKA-13607 Fix of the empty values to be treated as if they were absent

2022-03-04 Thread GitBox
kirktrue commented on a change in pull request #11707: URL: https://github.com/apache/kafka/pull/11707#discussion_r819858996 ## File path: clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java ## @@ -324,6 +332,22 @@ else if (password !=

[jira] [Commented] (KAFKA-13607) Cannot use PEM certificate coding when parent defined file-based

2022-03-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501498#comment-17501498 ] Kirk True commented on KAFKA-13607: --- [~psmolinski] - if you're working on this, can you assign the

[GitHub] [kafka] rhauch commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-04 Thread GitBox
rhauch commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r819851789 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-7480) GlobalThread should honor custom auto.offset.reset policy

2022-03-04 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-7480: - Labels: needs-kip new-streams-runtime-should-fix (was: needs-kip) > GlobalThread should honor

[GitHub] [kafka] guozhangwang commented on a change in pull request #11847: KAFKA-12648: fix NPE due to race condtion between resetting offsets and removing a topology

2022-03-04 Thread GitBox
guozhangwang commented on a change in pull request #11847: URL: https://github.com/apache/kafka/pull/11847#discussion_r819825757 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -978,24 +979,30 @@ private void

[GitHub] [kafka] guozhangwang merged pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.

2022-03-04 Thread GitBox
guozhangwang merged pull request #11830: URL: https://github.com/apache/kafka/pull/11830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.

2022-03-04 Thread GitBox
guozhangwang commented on pull request #11830: URL: https://github.com/apache/kafka/pull/11830#issuecomment-1059424145 Looked into the jenkins and they are irrelevant. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11847: KAFKA-12648: fix NPE due to race condtion between resetting offsets and removing a topology

2022-03-04 Thread GitBox
wcarlson5 commented on a change in pull request #11847: URL: https://github.com/apache/kafka/pull/11847#discussion_r819814891 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -1259,13 +1259,15 @@ public

[GitHub] [kafka] ableegoldman merged pull request #11827: MINOR: fix flaky shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing

2022-03-04 Thread GitBox
ableegoldman merged pull request #11827: URL: https://github.com/apache/kafka/pull/11827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11827: MINOR: fix flaky shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing

2022-03-04 Thread GitBox
ableegoldman commented on pull request #11827: URL: https://github.com/apache/kafka/pull/11827#issuecomment-1059415281 Note that one additional fix is required to completely mend this: https://github.com/apache/kafka/pull/11847 Once the above is merged though any new failure should be

[GitHub] [kafka] ableegoldman opened a new pull request #11847: KAFKA-12648: fix NPE due to race condtion between resetting offsets and removing a topology

2022-03-04 Thread GitBox
ableegoldman opened a new pull request #11847: URL: https://github.com/apache/kafka/pull/11847 While debugging the flaky `NamedTopologyIntegrationTest. shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing` test, I did discover one real bug. The problem was that we update the

[GitHub] [kafka] ableegoldman merged pull request #11813: KAFKA-12648: fix #add/removeNamedTopology blocking behavior when app is in CREATED

2022-03-04 Thread GitBox
ableegoldman merged pull request #11813: URL: https://github.com/apache/kafka/pull/11813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on pull request #11833: KAFKA-13671: Add ppc64le build stage

2022-03-04 Thread GitBox
mimaison commented on pull request #11833: URL: https://github.com/apache/kafka/pull/11833#issuecomment-1059384817 Thanks @mumrah! I've renamed the stage to `PowerPC`. Regarding supported platforms, I'm not aware of anybody testing recent builds on Solaris. I'll follow up with a small

[GitHub] [kafka] GauthamM-official removed a comment on pull request #11816: MINOR: Adding kafka-storage.bat file (similar to kafka-storage.sh) fo…

2022-03-04 Thread GitBox
GauthamM-official removed a comment on pull request #11816: URL: https://github.com/apache/kafka/pull/11816#issuecomment-1055242474 Hi @mumrah Could this be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] junrao merged pull request #11846: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

2022-03-04 Thread GitBox
junrao merged pull request #11846: URL: https://github.com/apache/kafka/pull/11846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-03-04 Thread GitBox
mimaison commented on pull request #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1059352526 Thanks for the PR @jeff303! Let me know when it is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mimaison commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-04 Thread GitBox
mimaison commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r819517322 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/TransactionContext.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] viktorsomogyi commented on a change in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-03-04 Thread GitBox
viktorsomogyi commented on a change in pull request #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r819715143 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java ## @@ -169,6 +172,7 @@ public String

[GitHub] [kafka] justinrlee opened a new pull request #11846: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

2022-03-04 Thread GitBox
justinrlee opened a new pull request #11846: URL: https://github.com/apache/kafka/pull/11846 Single-line change to build.gradle to render javadocs for new org.apache.kafka.common.security.oauthbearer.secured package (part of [KIP-768](https://issues.apache.org/jira/browse/KAFKA-13202))

[jira] [Commented] (KAFKA-13613) Kafka Connect has a hard dependency on KeyGenerator.HmacSHA256

2022-03-04 Thread Mike Millson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501355#comment-17501355 ] Mike Millson commented on KAFKA-13613: -- I think OpenJDK17 should work, as support for this type of

[jira] [Resolved] (KAFKA-13706) org.apache.kafka.test.MockSelector doesn't remove closed connections from its 'ready' field

2022-03-04 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13706. - Fix Version/s: 3.2.0 Reviewer: David Jacot Assignee: Vincent Jiang

[GitHub] [kafka] ijuma commented on a change in pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-03-04 Thread GitBox
ijuma commented on a change in pull request #11792: URL: https://github.com/apache/kafka/pull/11792#discussion_r819568938 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java ## @@ -917,6 +955,7 @@ public void

[GitHub] [kafka] savinov edited a comment on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-04 Thread GitBox
savinov edited a comment on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1058005727 In my case follower doesn't update configuration because **changed** flag keeps **false** value. Neither task count has been changed nor task configs.

[jira] [Updated] (KAFKA-13708) The metrics-core-2.2.0.jar on which kafka depends has the open-source vulnerability CVE-2022-20621

2022-03-04 Thread caoguangjie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caoguangjie updated KAFKA-13708: Summary: The metrics-core-2.2.0.jar on which kafka depends has the open-source vulnerability

[jira] [Updated] (KAFKA-13708) The metrics-core-2.2.0.jar on which kafka depends has the open-source vulnerability CVE-2022-20621.

2022-03-04 Thread caoguangjie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caoguangjie updated KAFKA-13708: Summary: The metrics-core-2.2.0.jar on which kafka depends has the open-source vulnerability

[jira] [Created] (KAFKA-13708) The metrics-core-2.2.0.jar on which Kafak depends has the open-source vulnerability CVE-2022-20621.

2022-03-04 Thread caoguangjie (Jira)
caoguangjie created KAFKA-13708: --- Summary: The metrics-core-2.2.0.jar on which Kafak depends has the open-source vulnerability CVE-2022-20621. Key: KAFKA-13708 URL: https://issues.apache.org/jira/browse/KAFKA-13708

[GitHub] [kafka] mimaison commented on a change in pull request #11817: KAFKA-13438: Replace EasyMock and PowerMock with Mockito in WorkerTest

2022-03-04 Thread GitBox
mimaison commented on a change in pull request #11817: URL: https://github.com/apache/kafka/pull/11817#discussion_r819461371 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java ## @@ -289,54 +314,60 @@ public void

[GitHub] [kafka] viktorsomogyi commented on pull request #10738: KAFKA-6945: KIP-373, allow users to create delegation token for others

2022-03-04 Thread GitBox
viktorsomogyi commented on pull request #10738: URL: https://github.com/apache/kafka/pull/10738#issuecomment-1059041824 @omkreddy I'm finished with rebasing the PR. There were a couple of test failures that I needed to fix but as I see the currently failing ones are flaky. -- This is an

[GitHub] [kafka] tombentley commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-04 Thread GitBox
tombentley commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r819434434 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[GitHub] [kafka] dengziming commented on a change in pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-04 Thread GitBox
dengziming commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r819404982 ## File path: core/src/test/scala/kafka/tools/GetOffsetShellTest.scala ## @@ -109,6 +111,46 @@ class GetOffsetShellTest extends KafkaServerTestHarness

[GitHub] [kafka] showuon commented on pull request #11845: MINOR: update the reassign-partition script results and argument

2022-03-04 Thread GitBox
showuon commented on pull request #11845: URL: https://github.com/apache/kafka/pull/11845#issuecomment-1058987784 @hachikuji @cmccabe , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] showuon commented on a change in pull request #11845: MINOR: update the reassign-partition script results and argument

2022-03-04 Thread GitBox
showuon commented on a change in pull request #11845: URL: https://github.com/apache/kafka/pull/11845#discussion_r819399684 ## File path: docs/ops.html ## @@ -382,12 +368,11 @@ $ bin/kafka-reassign-partitions.sh --bootstrap-server localhost:9092 --execute

[GitHub] [kafka] showuon commented on a change in pull request #11845: MINOR: update the reassign-partition script results and argument

2022-03-04 Thread GitBox
showuon commented on a change in pull request #11845: URL: https://github.com/apache/kafka/pull/11845#discussion_r819399318 ## File path: docs/ops.html ## @@ -329,20 +322,14 @@ + Successfully started partition reassignments for foo1-0,foo2-1 + The --verify option

[GitHub] [kafka] showuon commented on a change in pull request #11845: MINOR: update the reassign-partition script results and argument

2022-03-04 Thread GitBox
showuon commented on a change in pull request #11845: URL: https://github.com/apache/kafka/pull/11845#discussion_r819399008 ## File path: docs/ops.html ## @@ -258,58 +258,51 @@ The tool generates a candidate assignment that will move all partitions from topics

[GitHub] [kafka] showuon commented on a change in pull request #11845: MINOR: update the reassign-partition script results and argument

2022-03-04 Thread GitBox
showuon commented on a change in pull request #11845: URL: https://github.com/apache/kafka/pull/11845#discussion_r819398657 ## File path: docs/ops.html ## @@ -258,58 +258,51 @@ The tool generates a candidate assignment that will move all partitions from topics

[GitHub] [kafka] showuon commented on a change in pull request #11845: MINOR: update the reassign-partition script results and argument

2022-03-04 Thread GitBox
showuon commented on a change in pull request #11845: URL: https://github.com/apache/kafka/pull/11845#discussion_r819398181 ## File path: docs/ops.html ## @@ -258,58 +258,51 @@

[GitHub] [kafka] showuon commented on a change in pull request #11845: MINOR: update the reassign-partition script results and argument

2022-03-04 Thread GitBox
showuon commented on a change in pull request #11845: URL: https://github.com/apache/kafka/pull/11845#discussion_r819397379 ## File path: docs/ops.html ## @@ -258,58 +258,51 @@

[GitHub] [kafka] showuon opened a new pull request #11845: MINOR: update the reassign-partition script results and argument

2022-03-04 Thread GitBox
showuon opened a new pull request #11845: URL: https://github.com/apache/kafka/pull/11845 1. Remove `decommissioning brokers` section When reading `decommissioning brokers` section in document, it makes me confused:

[GitHub] [kafka] dajac merged pull request #11839: KAFKA-13706: remove closed connections from MockSelector.ready

2022-03-04 Thread GitBox
dajac merged pull request #11839: URL: https://github.com/apache/kafka/pull/11839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #11839: KAFKA-13706: remove closed connections from MockSelector.ready

2022-03-04 Thread GitBox
dajac commented on pull request #11839: URL: https://github.com/apache/kafka/pull/11839#issuecomment-1058962522 Failed tests are not related. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-6035) Avoid creating changelog topics for state stores that are directly piped to a sink topic

2022-03-04 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501214#comment-17501214 ] Bruno Cadonna commented on KAFKA-6035: -- In general, if you use `withLoggingDisabled` no changelog