YeonCheolGit opened a new pull request #11849:
URL: https://github.com/apache/kafka/pull/11849
Delete unused field in Topic.java
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
YeonCheolGit commented on a change in pull request #11848:
URL: https://github.com/apache/kafka/pull/11848#discussion_r820060984
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java
##
@@ -131,67 +129,56 @@ public void
YeonCheolGit commented on a change in pull request #11848:
URL: https://github.com/apache/kafka/pull/11848#discussion_r820060984
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java
##
@@ -131,67 +129,56 @@ public void
vvcephei opened a new pull request #11848:
URL: https://github.com/apache/kafka/pull/11848
The test experienced a flaky failure, but there were too many
unknowns to determine the cause. This change restructures the
test to make the cause more clear.
### Committer Checklist (excl
showuon commented on a change in pull request #11841:
URL: https://github.com/apache/kafka/pull/11841#discussion_r820024434
##
File path: gradle/spotbugs-exclude.xml
##
@@ -49,6 +49,7 @@ For a detailed description of spotbugs bug categories, see
https://spotbugs.read
showuon commented on a change in pull request #11775:
URL: https://github.com/apache/kafka/pull/11775#discussion_r820022615
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected SourceConnectorContext
showuon commented on a change in pull request #11775:
URL: https://github.com/apache/kafka/pull/11775#discussion_r820022262
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected SourceConnectorContext
Corlobin commented on pull request #11844:
URL: https://github.com/apache/kafka/pull/11844#issuecomment-1059646232
Hi @showuon, could you review please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
suhas-satish commented on pull request #11820:
URL: https://github.com/apache/kafka/pull/11820#issuecomment-1059612004
@lihaosky , why is this not needed anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
jnh5y commented on a change in pull request #11802:
URL: https://github.com/apache/kafka/pull/11802#discussion_r819982680
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java
##
@@ -0,0 +1,267 @@
+/*
+ *
jolshan commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r819975209
##
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##
@@ -103,59 +104,76 @@ object GetOffsetShell {
throw new IllegalArgumentExcept
jolshan commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r819973628
##
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##
@@ -189,22 +209,26 @@ object GetOffsetShell {
val topicFilter = IncludeList(gro
[
https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shay Lin updated KAFKA-13699:
-
Description:
As a KS developer, I would like to leverage
[KIP-622|https://cwiki.apache.org/confluence/d
[
https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501571#comment-17501571
]
Shay Lin commented on KAFKA-13699:
--
Hi team [~guozhang] [~mjsax] yes, as Matthias menti
C0urante commented on a change in pull request #11773:
URL: https://github.com/apache/kafka/pull/11773#discussion_r818829273
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected SourceConnectorContext
Chris Egerton created KAFKA-13709:
-
Summary: Document exactly-once support for source connectors
Key: KAFKA-13709
URL: https://issues.apache.org/jira/browse/KAFKA-13709
Project: Kafka
Issue T
C0urante commented on a change in pull request #11773:
URL: https://github.com/apache/kafka/pull/11773#discussion_r819951647
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/TransactionContext.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Softw
C0urante commented on a change in pull request #11775:
URL: https://github.com/apache/kafka/pull/11775#discussion_r819945829
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceTask.java
##
@@ -16,17 +16,63 @@
*/
package org.apache.kafka.connect.so
C0urante commented on a change in pull request #11773:
URL: https://github.com/apache/kafka/pull/11773#discussion_r819945019
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceTask.java
##
@@ -16,17 +16,63 @@
*/
package org.apache.kafka.connect.so
C0urante commented on a change in pull request #11775:
URL: https://github.com/apache/kafka/pull/11775#discussion_r819939810
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected SourceConnectorContext
C0urante commented on a change in pull request #11775:
URL: https://github.com/apache/kafka/pull/11775#discussion_r819937017
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected SourceConnectorContext
wcarlson5 commented on pull request #11847:
URL: https://github.com/apache/kafka/pull/11847#issuecomment-1059530699
That is a lot of test failures and some of those seem relevant
`org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnoth
jeff303 commented on a change in pull request #11792:
URL: https://github.com/apache/kafka/pull/11792#discussion_r819904687
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java
##
@@ -917,6 +955,7 @@ public void te
Corlobin commented on pull request #11841:
URL: https://github.com/apache/kafka/pull/11841#issuecomment-1059516594
Hi @showuon, I believe that is a false-positive, running the spotbugsMain
from trunk I receive 6 warnings as described below:
https://github.com/spotbugs/spotbugs/issues/1963
savinov edited a comment on pull request #8656:
URL: https://github.com/apache/kafka/pull/8656#issuecomment-1058005727
In my case follower doesn't update configuration because **changed** flag
keeps **false** value.
Neither task count has been changed nor task configs.
https://github
philipnee commented on a change in pull request #11797:
URL: https://github.com/apache/kafka/pull/11797#discussion_r819898973
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software F
rhauch commented on a change in pull request #11797:
URL: https://github.com/apache/kafka/pull/11797#discussion_r819884210
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foun
philipnee commented on a change in pull request #11797:
URL: https://github.com/apache/kafka/pull/11797#discussion_r819871715
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software F
philipnee commented on a change in pull request #11797:
URL: https://github.com/apache/kafka/pull/11797#discussion_r819863248
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software F
kirktrue commented on a change in pull request #11707:
URL: https://github.com/apache/kafka/pull/11707#discussion_r819858996
##
File path:
clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java
##
@@ -324,6 +332,22 @@ else if (password != null)
[
https://issues.apache.org/jira/browse/KAFKA-13607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501498#comment-17501498
]
Kirk True commented on KAFKA-13607:
---
[~psmolinski] - if you're working on this, can yo
rhauch commented on a change in pull request #11797:
URL: https://github.com/apache/kafka/pull/11797#discussion_r819851789
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foun
[
https://issues.apache.org/jira/browse/KAFKA-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-7480:
-
Labels: needs-kip new-streams-runtime-should-fix (was: needs-kip)
> GlobalThread should honor cu
guozhangwang commented on a change in pull request #11847:
URL: https://github.com/apache/kafka/pull/11847#discussion_r819825757
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -978,24 +979,30 @@ private void resetOffset
guozhangwang merged pull request #11830:
URL: https://github.com/apache/kafka/pull/11830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
guozhangwang commented on pull request #11830:
URL: https://github.com/apache/kafka/pull/11830#issuecomment-1059424145
Looked into the jenkins and they are irrelevant. Merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
wcarlson5 commented on a change in pull request #11847:
URL: https://github.com/apache/kafka/pull/11847#discussion_r819814891
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -1259,13 +1259,15 @@ public OffsetR
ableegoldman merged pull request #11827:
URL: https://github.com/apache/kafka/pull/11827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
ableegoldman commented on pull request #11827:
URL: https://github.com/apache/kafka/pull/11827#issuecomment-1059415281
Note that one additional fix is required to completely mend this:
https://github.com/apache/kafka/pull/11847
Once the above is merged though any new failure should be se
ableegoldman opened a new pull request #11847:
URL: https://github.com/apache/kafka/pull/11847
While debugging the flaky `NamedTopologyIntegrationTest.
shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing` test, I did
discover one real bug. The problem was that we update the Topolog
ableegoldman merged pull request #11813:
URL: https://github.com/apache/kafka/pull/11813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
mimaison commented on pull request #11833:
URL: https://github.com/apache/kafka/pull/11833#issuecomment-1059384817
Thanks @mumrah! I've renamed the stage to `PowerPC`.
Regarding supported platforms, I'm not aware of anybody testing recent
builds on Solaris. I'll follow up with a small d
GauthamM-official removed a comment on pull request #11816:
URL: https://github.com/apache/kafka/pull/11816#issuecomment-1055242474
Hi @mumrah Could this be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
junrao merged pull request #11846:
URL: https://github.com/apache/kafka/pull/11846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
mimaison commented on pull request #11792:
URL: https://github.com/apache/kafka/pull/11792#issuecomment-1059352526
Thanks for the PR @jeff303! Let me know when it is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mimaison commented on a change in pull request #11773:
URL: https://github.com/apache/kafka/pull/11773#discussion_r819517322
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/TransactionContext.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Softw
viktorsomogyi commented on a change in pull request #11748:
URL: https://github.com/apache/kafka/pull/11748#discussion_r819715143
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java
##
@@ -169,6 +172,7 @@ public String version()
justinrlee opened a new pull request #11846:
URL: https://github.com/apache/kafka/pull/11846
Single-line change to build.gradle to render javadocs for new
org.apache.kafka.common.security.oauthbearer.secured package (part of
[KIP-768](https://issues.apache.org/jira/browse/KAFKA-13202))
[
https://issues.apache.org/jira/browse/KAFKA-13613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501355#comment-17501355
]
Mike Millson commented on KAFKA-13613:
--
I think OpenJDK17 should work, as support f
[
https://issues.apache.org/jira/browse/KAFKA-13706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13706.
-
Fix Version/s: 3.2.0
Reviewer: David Jacot
Assignee: Vincent Jiang
Resol
ijuma commented on a change in pull request #11792:
URL: https://github.com/apache/kafka/pull/11792#discussion_r819568938
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java
##
@@ -917,6 +955,7 @@ public void test
savinov edited a comment on pull request #8656:
URL: https://github.com/apache/kafka/pull/8656#issuecomment-1058005727
In my case follower doesn't update configuration because **changed** flag
keeps **false** value.
Neither task count has been changed nor task configs.
https://github
[
https://issues.apache.org/jira/browse/KAFKA-13708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
caoguangjie updated KAFKA-13708:
Summary: The metrics-core-2.2.0.jar on which kafka depends has the
open-source vulnerability CVE-2
[
https://issues.apache.org/jira/browse/KAFKA-13708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
caoguangjie updated KAFKA-13708:
Summary: The metrics-core-2.2.0.jar on which kafka depends has the
open-source vulnerability CVE-2
caoguangjie created KAFKA-13708:
---
Summary: The metrics-core-2.2.0.jar on which Kafak depends has the
open-source vulnerability CVE-2022-20621.
Key: KAFKA-13708
URL: https://issues.apache.org/jira/browse/KAFKA-13708
mimaison commented on a change in pull request #11817:
URL: https://github.com/apache/kafka/pull/11817#discussion_r819461371
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java
##
@@ -289,54 +314,60 @@ public void testStartAndStopConnec
viktorsomogyi commented on pull request #10738:
URL: https://github.com/apache/kafka/pull/10738#issuecomment-1059041824
@omkreddy I'm finished with rebasing the PR. There were a couple of test
failures that I needed to fix but as I see the currently failing ones are flaky.
--
This is an
tombentley commented on a change in pull request #11773:
URL: https://github.com/apache/kafka/pull/11773#discussion_r819434434
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,46 @@
protected SourceConnectorConte
dengziming commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r819404982
##
File path: core/src/test/scala/kafka/tools/GetOffsetShellTest.scala
##
@@ -109,6 +111,46 @@ class GetOffsetShellTest extends KafkaServerTestHarness
showuon commented on pull request #11845:
URL: https://github.com/apache/kafka/pull/11845#issuecomment-1058987784
@hachikuji @cmccabe , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
showuon commented on a change in pull request #11845:
URL: https://github.com/apache/kafka/pull/11845#discussion_r819399684
##
File path: docs/ops.html
##
@@ -382,12 +368,11 @@ $ bin/kafka-reassign-partitions.sh
--bootstrap-server localhost:9092 --execute --reassignment-json-f
showuon commented on a change in pull request #11845:
URL: https://github.com/apache/kafka/pull/11845#discussion_r819399318
##
File path: docs/ops.html
##
@@ -329,20 +322,14 @@
+ Successfully started partition reassignments for foo1-0,foo2-1
+
The --verify option can
showuon commented on a change in pull request #11845:
URL: https://github.com/apache/kafka/pull/11845#discussion_r819399008
##
File path: docs/ops.html
##
@@ -258,58 +258,51 @@
The tool generates a candidate assignment that will move all partitions from
topics foo1,foo
showuon commented on a change in pull request #11845:
URL: https://github.com/apache/kafka/pull/11845#discussion_r819398657
##
File path: docs/ops.html
##
@@ -258,58 +258,51 @@
The tool generates a candidate assignment that will move all partitions from
topics foo1,foo
showuon commented on a change in pull request #11845:
URL: https://github.com/apache/kafka/pull/11845#discussion_r819398181
##
File path: docs/ops.html
##
@@ -258,58 +258,51 @@
showuon commented on a change in pull request #11845:
URL: https://github.com/apache/kafka/pull/11845#discussion_r819397379
##
File path: docs/ops.html
##
@@ -258,58 +258,51 @@
showuon opened a new pull request #11845:
URL: https://github.com/apache/kafka/pull/11845
1. Remove `decommissioning brokers` section
When reading `decommissioning brokers` section in document, it makes me
confused:
![image](https://user-images.githubusercontent.com/43372967/1567324
dajac merged pull request #11839:
URL: https://github.com/apache/kafka/pull/11839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac commented on pull request #11839:
URL: https://github.com/apache/kafka/pull/11839#issuecomment-1058962522
Failed tests are not related. Merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
[
https://issues.apache.org/jira/browse/KAFKA-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501214#comment-17501214
]
Bruno Cadonna commented on KAFKA-6035:
--
In general, if you use `withLoggingDisabled`
70 matches
Mail list logo