[
https://issues.apache.org/jira/browse/KAFKA-13909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539332#comment-17539332
]
Florian Blumenstein commented on KAFKA-13909:
-
[~andyg2] Yes, as you can see
[
https://issues.apache.org/jira/browse/KAFKA-13837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-13837.
-
Fix Version/s: 3.3.0
Resolution: Fixed
> Return error for Fetch requests from unr
hachikuji merged PR #12150:
URL: https://github.com/apache/kafka/pull/12150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
[
https://issues.apache.org/jira/browse/KAFKA-13914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539181#comment-17539181
]
Luke Chen commented on KAFKA-13914:
---
Nice team work! :)
> Implement kafka-metadata-qu
[
https://issues.apache.org/jira/browse/KAFKA-13909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13909:
-
Assignee: Luke Chen
> Restart Kafka in KRaft mode with ACLs ends in a RuntimeException
> --
showuon commented on PR #12167:
URL: https://github.com/apache/kafka/pull/12167#issuecomment-1131061627
> 1. When you say add some test for wrong & good configs, do you mean to
remove the particular unit tests and then add it to the TopicCommandTest.scala
instead? Or are you suggesting that
showuon commented on PR #11845:
URL: https://github.com/apache/kafka/pull/11845#issuecomment-1131045969
@hachikuji @dajac , please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
showuon merged PR #12178:
URL: https://github.com/apache/kafka/pull/12178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #12178:
URL: https://github.com/apache/kafka/pull/12178#issuecomment-1131032000
LGTM! Thanks for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539164#comment-17539164
]
Luke Chen commented on KAFKA-13718:
---
Thanks for the answers, [~dengziming] !
[~rjoerg
hachikuji commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r876492051
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1292,8 +1292,13 @@ public void handleResponse(AbstractResponse res
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539137#comment-17539137
]
dengziming commented on KAFKA-13718:
Hello [~rjoerger]
# this issue is enough to t
[
https://issues.apache.org/jira/browse/KAFKA-13914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539136#comment-17539136
]
dengziming commented on KAFKA-13914:
[~hachikuji] I'd love to take this after KIP-83
dengziming commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r876463234
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2143,11 +2144,17 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInt
bozhao12 opened a new pull request, #12178:
URL: https://github.com/apache/kafka/pull/12178
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
hachikuji commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r876448765
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2143,11 +2144,17 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInte
[
https://issues.apache.org/jira/browse/KAFKA-13914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539118#comment-17539118
]
Jason Gustafson commented on KAFKA-13914:
-
[~dengziming] I don't suppose you hav
Jason Gustafson created KAFKA-13914:
---
Summary: Implement kafka-metadata-quorum.sh
Key: KAFKA-13914
URL: https://issues.apache.org/jira/browse/KAFKA-13914
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539108#comment-17539108
]
Jose Armando Garcia Sancio commented on KAFKA-1930:
---
Hi [~aauradkar] ar
andymg3 commented on code in PR #12160:
URL: https://github.com/apache/kafka/pull/12160#discussion_r876396975
##
metadata/src/test/java/org/apache/kafka/image/AclsDeltaTest.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/KAFKA-13889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539088#comment-17539088
]
Jose Armando Garcia Sancio commented on KAFKA-13889:
> I'm wondering
[
https://issues.apache.org/jira/browse/KAFKA-13909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539086#comment-17539086
]
Andrew Grant commented on KAFKA-13909:
--
Thanks for the report [~fblumenstein]. Did
jsancio commented on code in PR #12160:
URL: https://github.com/apache/kafka/pull/12160#discussion_r876387974
##
metadata/src/main/java/org/apache/kafka/image/AclsDelta.java:
##
@@ -61,7 +61,13 @@ public void replay(AccessControlEntryRecord record) {
}
public void re
hachikuji merged PR #12176:
URL: https://github.com/apache/kafka/pull/12176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
[
https://issues.apache.org/jira/browse/KAFKA-13716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Richard Joerger reassigned KAFKA-13716:
---
Assignee: Richard Joerger (was: Shivanjal Arora)
> add tests for `DeleteRecordsCom
[
https://issues.apache.org/jira/browse/KAFKA-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13913:
-
Fix Version/s: 3.3.0
> Provide builders for KafkaProducer/KafkaConsumer and KafkaStreams
andymg3 commented on code in PR #12160:
URL: https://github.com/apache/kafka/pull/12160#discussion_r876312658
##
metadata/src/main/java/org/apache/kafka/image/AclsDelta.java:
##
@@ -61,7 +61,13 @@ public void replay(AccessControlEntryRecord record) {
}
public void re
cmccabe commented on code in PR #12177:
URL: https://github.com/apache/kafka/pull/12177#discussion_r876326240
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1735,17 +1742,38 @@ public CompletableFuture
updateFeatures(
ControllerRequ
[
https://issues.apache.org/jira/browse/KAFKA-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13913:
-
Description:
To have more flexibility, builders should be provided for the following obj
cmccabe commented on code in PR #12177:
URL: https://github.com/apache/kafka/pull/12177#discussion_r876325079
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1735,17 +1742,38 @@ public CompletableFuture
updateFeatures(
ControllerRequ
[
https://issues.apache.org/jira/browse/KAFKA-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13913:
-
Affects Version/s: 3.2.0
> Provide builders for KafkaProducer/KafkaConsumer and KafkaStr
[
https://issues.apache.org/jira/browse/KAFKA-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13913:
-
Description:
To have more flexibility, builders should be provided for the following obj
[
https://issues.apache.org/jira/browse/KAFKA-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13913:
-
Description:
To have more flexibility, builders should be provided for the following obj
François Rosière created KAFKA-13913:
Summary: Provide builders for KafkaProducer/KafkaConsumer and
KafkaStreams
Key: KAFKA-13913
URL: https://issues.apache.org/jira/browse/KAFKA-13913
Project: Ka
[
https://issues.apache.org/jira/browse/KAFKA-13889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539039#comment-17539039
]
Andrew Grant commented on KAFKA-13889:
--
[~jagsancio] With the solution [~cmccabe] s
[
https://issues.apache.org/jira/browse/KAFKA-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13830:
-
Labels: kip-500 (was: )
> Introduce metadata.version in KRaft
> ---
David Arthur created KAFKA-13912:
Summary: Generate metadata snapshot prior to metadata.version
change
Key: KAFKA-13912
URL: https://issues.apache.org/jira/browse/KAFKA-13912
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur resolved KAFKA-13830.
--
Resolution: Fixed
> Introduce metadata.version in KRaft
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13830:
-
Component/s: controller
> Introduce metadata.version in KRaft
>
cmccabe commented on PR #12050:
URL: https://github.com/apache/kafka/pull/12050#issuecomment-1130402525
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
cmccabe merged PR #12050:
URL: https://github.com/apache/kafka/pull/12050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
guozhangwang commented on PR #12121:
URL: https://github.com/apache/kafka/pull/12121#issuecomment-1130394986
> From a public API point of view, Metrics is in a gray area. It is not
officially part of our public API however we have a few interfaces leaking it.
That being said, we should be c
guozhangwang commented on code in PR #12121:
URL: https://github.com/apache/kafka/pull/12121#discussion_r876234679
##
clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java:
##
@@ -563,10 +615,15 @@ public synchronized void removeReporter(MetricsReporter
reporter) {
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r876238453
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -231,6 +252,10 @@ object StorageTool extends Logging {
val metaPropertiesPath = Paths.get(directory, "
hachikuji commented on PR #12124:
URL: https://github.com/apache/kafka/pull/12124#issuecomment-1130386383
@konL Thanks for the PR. I would probably count this as "not agree and not
fix". I think the renaming suggestion reads more awkwardly. Additionally, the
references have not been updated
hachikuji closed pull request #12124: rename isDone to hasComplete
URL: https://github.com/apache/kafka/pull/12124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
hachikuji merged PR #12134:
URL: https://github.com/apache/kafka/pull/12134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
hachikuji commented on PR #12172:
URL: https://github.com/apache/kafka/pull/12172#issuecomment-1130342534
Closing this since it appears to have been opened by mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
hachikuji closed pull request #12172: test12345
URL: https://github.com/apache/kafka/pull/12172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-uns
hachikuji closed pull request #12171: MINOR: Convert admin integration tests
URL: https://github.com/apache/kafka/pull/12171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
hachikuji commented on PR #12171:
URL: https://github.com/apache/kafka/pull/12171#issuecomment-1130341597
Closing this since I think it was covered by #12110.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
hachikuji opened a new pull request, #12176:
URL: https://github.com/apache/kafka/pull/12176
Enable support for KRaft in `TransactionsTest`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build sta
jsancio commented on code in PR #12160:
URL: https://github.com/apache/kafka/pull/12160#discussion_r876160871
##
metadata/src/main/java/org/apache/kafka/image/AclsDelta.java:
##
@@ -61,7 +61,13 @@ public void replay(AccessControlEntryRecord record) {
}
public void re
[
https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538975#comment-17538975
]
Richard Joerger commented on KAFKA-13718:
-
I'd love to help out on this particul
vamossagar12 commented on PR #12121:
URL: https://github.com/apache/kafka/pull/12121#issuecomment-1130289233
> Thanks for the PR. I left a few comments.
>
> From a public API point of view, Metrics is in a gray area. It is not
officially part of our public API however we have a few in
vamossagar12 commented on code in PR #12121:
URL: https://github.com/apache/kafka/pull/12121#discussion_r876159510
##
clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java:
##
@@ -524,6 +524,58 @@ public void addMetric(MetricName metricName,
MetricValueProvider met
vamossagar12 commented on code in PR #12121:
URL: https://github.com/apache/kafka/pull/12121#discussion_r876158002
##
clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java:
##
@@ -524,6 +524,58 @@ public void addMetric(MetricName metricName,
MetricValueProvider met
[
https://issues.apache.org/jira/browse/KAFKA-13889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538973#comment-17538973
]
Jose Armando Garcia Sancio commented on KAFKA-13889:
[~andyg2] in th
Boojapho commented on PR #11579:
URL: https://github.com/apache/kafka/pull/11579#issuecomment-1130260516
Gson library has another recent vulnerability:
https://nvd.nist.gov/vuln/detail/CVE-2022-25647. Gson library 2.8.9 fixes
this, which is included in Spotbugs 4.5.0 and higher.
--
Thi
hachikuji commented on code in PR #12150:
URL: https://github.com/apache/kafka/pull/12150#discussion_r876119320
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1133,16 +1131,95 @@ class Partition(val topicPartition: TopicPartition,
info.copy(leaderHwChange = if
hachikuji merged PR #12110:
URL: https://github.com/apache/kafka/pull/12110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
Divij Vaidya created KAFKA-13911:
Summary: Rate is calculated as NaN for minimum config values
Key: KAFKA-13911
URL: https://issues.apache.org/jira/browse/KAFKA-13911
Project: Kafka
Issue Typ
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875105840
##
metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java:
##
@@ -253,6 +263,14 @@ public void replay(RemoveTopicRecord record) {
public void replay(Feat
mumrah merged PR #12168:
URL: https://github.com/apache/kafka/pull/12168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah commented on PR #12168:
URL: https://github.com/apache/kafka/pull/12168#issuecomment-1130123042
Test failures are unrelated. Going ahead with the merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Moovlin commented on PR #12170:
URL: https://github.com/apache/kafka/pull/12170#issuecomment-1130018528
My understanding of the statement "so we'd better make it [the PR]
bug-compatible" means we should add back in the segment.bytes for the time
being while the we in the community figure ou
jnh5y commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r875834065
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##
@@ -463,7 +463,10 @@ public void restore(final Map tasks) {
dajac commented on code in PR #12150:
URL: https://github.com/apache/kafka/pull/12150#discussion_r875822488
##
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##
@@ -439,18 +545,33 @@ class PartitionTest extends AbstractPartitionTest {
val leaderEpoch = 5
v
cadonna commented on PR #12173:
URL: https://github.com/apache/kafka/pull/12173#issuecomment-1129936620
@dajac The system tests fail I think because the development version in
`tests/kafkatest/version.py` is `3.1.1-SNAPSHOT` instead of `3.1.2-SNAPSHOT`.
http://confluent-kafka-branch-
jnh5y commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r875817199
##
streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java:
##
@@ -0,0 +1,501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
cadonna commented on code in PR #12161:
URL: https://github.com/apache/kafka/pull/12161#discussion_r875647755
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1662,6 +1663,51 @@ public T store(final StoreQueryParameters
storeQueryParameters) {
dajac merged PR #12138:
URL: https://github.com/apache/kafka/pull/12138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
frosiere commented on PR #12125:
URL: https://github.com/apache/kafka/pull/12125#issuecomment-1129661166
As mentioned in the Jira ticket, KIP-832 won't be implemented and will be
replaced by KIP-839.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière resolved KAFKA-13864.
--
Resolution: Won't Do
> Change the visibility of a KafkaProducer and KafkaConsumer cons
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Labels: (was: needs-kip)
> Change the visibility of a KafkaProducer and KafkaConsumer
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière reassigned KAFKA-13864:
Assignee: François Rosière (was: lqjacklee)
> Change the visibility of a KafkaPr
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538617#comment-17538617
]
François Rosière commented on KAFKA-13864:
--
This issue won't be implemented as
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538612#comment-17538612
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on PR #410:
URL: ht
78 matches
Mail list logo
