[GitHub] [kafka] jiameixie closed pull request #8555: KAFKA-9920:Fix NetworkDegradeTest.test_rate test error

jiameixie closed pull request #8555: KAFKA-9920:Fix NetworkDegradeTest.test_rate test error URL: https://github.com/apache/kafka/pull/8555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jiameixie closed pull request #8446: KAFKA-9804:Extract consumer configs out of PerfConfig

jiameixie closed pull request #8446: KAFKA-9804:Extract consumer configs out of PerfConfig URL: https://github.com/apache/kafka/pull/8446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jiameixie closed pull request #8831: KAFKA-8657:Client-side automatic topic creation on Producer

jiameixie closed pull request #8831: KAFKA-8657:Client-side automatic topic creation on Producer URL: https://github.com/apache/kafka/pull/8831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jiameixie closed pull request #8943: KAFKA-10196: Add missing '--version' option to producer-performance

jiameixie closed pull request #8943: KAFKA-10196: Add missing '--version' option to producer-performance URL: https://github.com/apache/kafka/pull/8943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] C0urante commented on pull request #12191: KAFKA-12657: Increase timeouts in Connect integration tests

C0urante commented on PR #12191: URL: https://github.com/apache/kafka/pull/12191#issuecomment-1135346345 @cadonna It looks like the timeout increase yields some benefit, at least for the PR builder. Do you have any thoughts on other ways to test this before merging or do you think it's

[GitHub] [kafka] showuon commented on a diff in pull request #12159: Fix stuck SSL tests in case of authentication failure

showuon commented on code in PR #12159: URL: https://github.com/apache/kafka/pull/12159#discussion_r880005058 ## clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java: ## @@ -1138,20 +1130,18 @@ private KafkaChannel createConnectionWithPendingReceives(int

[GitHub] [kafka] dengziming commented on a diff in pull request #12185: MINOR: Fix buildResponseSend test cases for envelope responses

dengziming commented on code in PR #12185: URL: https://github.com/apache/kafka/pull/12185#discussion_r879998889 ## core/src/test/scala/unit/kafka/network/RequestChannelTest.scala: ## @@ -191,84 +194,66 @@ class RequestChannelTest {

[GitHub] [kafka] dengziming commented on a diff in pull request #12194: MINOR: Include listener name in SocketServer acceptor and processor log context

dengziming commented on code in PR #12194: URL: https://github.com/apache/kafka/pull/12194#discussion_r879997413 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -242,13 +241,14 @@ class SocketServer(val config: KafkaConfig, } private def endpoints =

[GitHub] [kafka] hachikuji commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

hachikuji commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r879971283 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2141,23 +2141,22 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] hachikuji commented on a diff in pull request #12181: KAFKA-13916; Fenced replicas should not be allowed to join the ISR in KRaft (KIP-841)

hachikuji commented on code in PR #12181: URL: https://github.com/apache/kafka/pull/12181#discussion_r879967287 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1574,6 +1586,13 @@ class Partition(val topicPartition: TopicPartition, debug(s"Failed to alter

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12169: MINOR: improve description of `commit.interval.ms` config

ableegoldman commented on code in PR #12169: URL: https://github.com/apache/kafka/pull/12169#discussion_r879960393 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -452,7 +452,9 @@ public class StreamsConfig extends AbstractConfig { /** {@code

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

guozhangwang commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r879910088 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

guozhangwang commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r879907429 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r879901701 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java: ## @@ -257,6 +260,35 @@ public void registerAndBuildNewTopology(final

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r879881895 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutionMetadata.java: ## @@ -35,21 +35,27 @@ public class TaskExecutionMetadata { private

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r879881585 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -897,7 +897,8 @@ private void initializeAndRestorePhase() { }

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r879881287 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -897,7 +897,8 @@ private void initializeAndRestorePhase() { }

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r879798075 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1662,6 +1663,51 @@ public T store(final StoreQueryParameters storeQueryParameters) {

[GitHub] [kafka] cadonna commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

cadonna commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r879825716 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

cadonna commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r879819649 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

cadonna commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r879818827 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

cadonna commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r879816734 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cadonna commented on a diff in pull request #12128: KAFKA-10199: Implement adding active tasks to the state updater

cadonna commented on code in PR #12128: URL: https://github.com/apache/kafka/pull/12128#discussion_r879812339 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -0,0 +1,373 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jnh5y commented on a diff in pull request #12161: KAFKA-13873 Add ability to Pause / Resume KafkaStreams Topologies

jnh5y commented on code in PR #12161: URL: https://github.com/apache/kafka/pull/12161#discussion_r879798075 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1662,6 +1663,51 @@ public T store(final StoreQueryParameters storeQueryParameters) {

[GitHub] [kafka] junrao commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

junrao commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r879714696 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[jira] [Assigned] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators

[ https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Bondarenko reassigned KAFKA-10409: Assignee: (was: Oleksandr Bondarenko) > Refactor Kafka Streams

[GitHub] [kafka] guozhangwang merged pull request #12035: KAFKA-13217: Reconsider skipping the LeaveGroup on close() or add an overload that does so

guozhangwang merged PR #12035: URL: https://github.com/apache/kafka/pull/12035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #12035: KAFKA-13217: Reconsider skipping the LeaveGroup on close() or add an overload that does so

guozhangwang commented on PR #12035: URL: https://github.com/apache/kafka/pull/12035#issuecomment-1134925935 I will also update the JIRA / KIP status. Huge thanks for your contribution @sayantanu-dey ! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] junrao commented on a diff in pull request #12136: KAFKA-13773: catch kafkaStorageException to avoid broker shutdown directly

junrao commented on code in PR #12136: URL: https://github.com/apache/kafka/pull/12136#discussion_r879690436 ## core/src/test/scala/unit/kafka/log/LogLoaderTest.scala: ## @@ -134,10 +154,29 @@ class LogLoaderTest { } } +def

[GitHub] [kafka] soarez opened a new pull request, #12198: MINOR: Avoid possibly resolvable name in tests

soarez opened a new pull request, #12198: URL: https://github.com/apache/kafka/pull/12198 There is a reasonable chance that the name `admin` might actually be resolvable in certain corporate development environments. *Summary of testing strategy* These two tests started passing.

[GitHub] [kafka] hachikuji commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

hachikuji commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r879681829 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2141,23 +2141,22 @@ class ReplicaManager(val config: KafkaConfig,

[jira] [Resolved] (KAFKA-13923) ZooKeeperAuthorizerTest should use standard authorizer for kraft

[ https://issues.apache.org/jira/browse/KAFKA-13923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13923. - Resolution: Fixed > ZooKeeperAuthorizerTest should use standard authorizer for kraft >

[GitHub] [kafka] hachikuji merged pull request #12190: KAFKA-13923; Generalize authorizer system test for kraft

hachikuji merged PR #12190: URL: https://github.com/apache/kafka/pull/12190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

dajac commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r879677034 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2141,23 +2141,22 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] hachikuji commented on a diff in pull request #12190: KAFKA-13923; Generalize authorizer system test for kraft

hachikuji commented on code in PR #12190: URL: https://github.com/apache/kafka/pull/12190#discussion_r879669643 ## tests/kafkatest/tests/core/authorizer_test.py: ## @@ -36,22 +36,30 @@ class ZooKeeperAuthorizerTest(Test): """ def __init__(self, test_context): -

[GitHub] [kafka] hachikuji commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

hachikuji commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r879668233 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2141,23 +2141,22 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] hachikuji commented on a diff in pull request #12185: MINOR: Fix buildResponseSend test cases for envelope responses

hachikuji commented on code in PR #12185: URL: https://github.com/apache/kafka/pull/12185#discussion_r879661710 ## core/src/test/scala/unit/kafka/network/RequestChannelTest.scala: ## @@ -191,84 +194,66 @@ class RequestChannelTest {

[GitHub] [kafka] hachikuji commented on a diff in pull request #12185: MINOR: Fix buildResponseSend test cases for envelope responses

hachikuji commented on code in PR #12185: URL: https://github.com/apache/kafka/pull/12185#discussion_r879659761 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -2195,22 +2193,18 @@ object TestUtils extends Logging { RequestHeader.parse(envelopeBuffer) -

[GitHub] [kafka] hachikuji commented on a diff in pull request #12185: MINOR: Fix buildResponseSend test cases for envelope responses

hachikuji commented on code in PR #12185: URL: https://github.com/apache/kafka/pull/12185#discussion_r879657858 ## core/src/test/scala/unit/kafka/network/RequestChannelTest.scala: ## @@ -191,84 +194,66 @@ class RequestChannelTest {

[jira] [Assigned] (KAFKA-13718) kafka-topics describe topic with default config will show `segment.bytes` overridden config

[ https://issues.apache.org/jira/browse/KAFKA-13718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Joerger reassigned KAFKA-13718: --- Assignee: Richard Joerger > kafka-topics describe topic with default config will

[GitHub] [kafka] hachikuji commented on a diff in pull request #12190: KAFKA-13923; Generalize authorizer system test for kraft

hachikuji commented on code in PR #12190: URL: https://github.com/apache/kafka/pull/12190#discussion_r879644296 ## tests/kafkatest/tests/core/authorizer_test.py: ## @@ -36,22 +36,30 @@ class ZooKeeperAuthorizerTest(Test): """ def __init__(self, test_context): -

[GitHub] [kafka] divijvaidya commented on pull request #12197: KAFKA-13929: Replace legacy File.createNewFile() with NIO.2 Files.createFile()

divijvaidya commented on PR #12197: URL: https://github.com/apache/kafka/pull/12197#issuecomment-1134867088 @hachikuji @mimaison perhaps you folks would be interested to look into this code improvement? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] Moovlin commented on pull request #12167: KAFKA-13716 Added the DeleteRecordsCommandTest to test the CLI front end of the D…

Moovlin commented on PR #12167: URL: https://github.com/apache/kafka/pull/12167#issuecomment-1134854139 @showuon I've gone ahead and added more tests as suggested. Happy to receive feedback on them! In addition, I opened the following jira as we agreed to to track integration tests:

[jira] [Created] (KAFKA-13931) Add Integration tests for the `DeleteRecordsCommand` class

Richard Joerger created KAFKA-13931: --- Summary: Add Integration tests for the `DeleteRecordsCommand` class Key: KAFKA-13931 URL: https://issues.apache.org/jira/browse/KAFKA-13931 Project: Kafka

[jira] [Commented] (KAFKA-12489) Flaky test ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir

[ https://issues.apache.org/jira/browse/KAFKA-12489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540939#comment-17540939 ] Divij Vaidya commented on KAFKA-12489: -- I have made some changes in

[GitHub] [kafka] divijvaidya commented on pull request #12184: KAFKA-13911: Fix the rate window size calculation for edge cases

divijvaidya commented on PR #12184: URL: https://github.com/apache/kafka/pull/12184#issuecomment-1134632044 @ijuma perhaps you might want to take a look at this? The test failures are unrelated to the changes and are known flaky failures. -- This is an automated message from the Apache

[GitHub] [kafka] dajac commented on a diff in pull request #12190: KAFKA-13923; Generalize authorizer system test for kraft

dajac commented on code in PR #12190: URL: https://github.com/apache/kafka/pull/12190#discussion_r879408851 ## tests/kafkatest/tests/core/authorizer_test.py: ## @@ -36,22 +36,30 @@ class ZooKeeperAuthorizerTest(Test): """ def __init__(self, test_context): -

[jira] [Updated] (KAFKA-13930) Add 3.2.0 to broker/client and streams upgrade/compatibility tests

[ https://issues.apache.org/jira/browse/KAFKA-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13930: -- Component/s: clients > Add 3.2.0 to broker/client and streams upgrade/compatibility tests >

[jira] [Updated] (KAFKA-13930) Add 3.2.0 to broker/client and streams upgrade/compatibility tests

[ https://issues.apache.org/jira/browse/KAFKA-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13930: -- Component/s: core > Add 3.2.0 to broker/client and streams upgrade/compatibility tests >

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12121: KAFKA-13846: Adding overloaded metricOrElseCreate method

vamossagar12 commented on code in PR #12121: URL: https://github.com/apache/kafka/pull/12121#discussion_r879408388 ## clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java: ## @@ -563,10 +586,11 @@ public synchronized void removeReporter(MetricsReporter reporter)

[jira] [Updated] (KAFKA-13930) Add 3.2.0 to broker/client and streams upgrade/compatibility tests

[ https://issues.apache.org/jira/browse/KAFKA-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13930: -- Description: Per the penultimate bullet on the [release

[jira] [Updated] (KAFKA-13930) Add 3.2.0 to broker/client and streams upgrade/compatibility tests

[ https://issues.apache.org/jira/browse/KAFKA-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13930: -- Reporter: Bruno Cadonna (was: Tom Bentley) > Add 3.2.0 to broker/client and streams

[jira] [Updated] (KAFKA-13930) Add 3.2.0 to broker/client and streams upgrade/compatibility tests

[ https://issues.apache.org/jira/browse/KAFKA-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13930: -- Fix Version/s: (was: 3.1.2) (was: 3.2.1) > Add 3.2.0 to

[GitHub] [kafka] vamossagar12 commented on pull request #12121: KAFKA-13846: Adding overloaded metricOrElseCreate method

vamossagar12 commented on PR #12121: URL: https://github.com/apache/kafka/pull/12121#issuecomment-1134624584 > > Do we also have concrete examples of usages of this new API? It would be helpful to update one or two metrics which would benefits from this change. This would be a good

[jira] [Created] (KAFKA-13930) Add 3.2.0 to broker/client and streams upgrade/compatibility tests

Bruno Cadonna created KAFKA-13930: - Summary: Add 3.2.0 to broker/client and streams upgrade/compatibility tests Key: KAFKA-13930 URL: https://issues.apache.org/jira/browse/KAFKA-13930 Project: Kafka

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12121: KAFKA-13846: Adding overloaded metricOrElseCreate method

vamossagar12 commented on code in PR #12121: URL: https://github.com/apache/kafka/pull/12121#discussion_r879402941 ## clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java: ## @@ -563,10 +615,15 @@ public synchronized void removeReporter(MetricsReporter reporter)

[GitHub] [kafka] soarez commented on a diff in pull request #12174: KAFKA-13907: Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable

soarez commented on code in PR #12174: URL: https://github.com/apache/kafka/pull/12174#discussion_r879394247 ## core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala: ## @@ -248,9 +248,11 @@ abstract class KafkaServerTestHarness extends QuorumTestHarness {

[jira] [Commented] (KAFKA-13888) KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag

[ https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540910#comment-17540910 ] lqjacklee commented on KAFKA-13888: --- [~Niket Goel] can I take the task ? I am working on this task.

[GitHub] [kafka] dengziming commented on a diff in pull request #12195: MINOR: imnplement BrokerRegistrationChangeRecord

dengziming commented on code in PR #12195: URL: https://github.com/apache/kafka/pull/12195#discussion_r879293533 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -153,7 +153,10 @@ public enum MetadataVersion { IBP_3_2_IV0(4, "3.2",

[GitHub] [kafka] divijvaidya opened a new pull request, #12197: KAFKA-13929: Replace legacy File.createNewFile() with NIO.2 Files.createFile()

divijvaidya opened a new pull request, #12197: URL: https://github.com/apache/kafka/pull/12197 `File.createNewFile()` returns a boolean signifying whether the file creation was successful or not. There are multiple places in the Kafka code base where we are not checking the value of the

[GitHub] [kafka] dengziming commented on a diff in pull request #12177: KAKFA-13410 Generate snapshot prior to metadata.version upgrade

dengziming commented on code in PR #12177: URL: https://github.com/apache/kafka/pull/12177#discussion_r879273738 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1735,17 +1742,38 @@ public CompletableFuture updateFeatures(

[jira] [Created] (KAFKA-13929) Replace File.createNewFile() with Files.createFile()

Divij Vaidya created KAFKA-13929: Summary: Replace File.createNewFile() with Files.createFile() Key: KAFKA-13929 URL: https://issues.apache.org/jira/browse/KAFKA-13929 Project: Kafka Issue

[jira] [Updated] (KAFKA-13928) Improve File I/O by using Java NIO.2

[ https://issues.apache.org/jira/browse/KAFKA-13928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-13928: - Description: Java NIO.2 APIs we launched in JDK 7:

[jira] [Created] (KAFKA-13928) Improve File I/O by using Java NIO.2

Divij Vaidya created KAFKA-13928: Summary: Improve File I/O by using Java NIO.2 Key: KAFKA-13928 URL: https://issues.apache.org/jira/browse/KAFKA-13928 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] dajac commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

dajac commented on code in PR #12187: URL: https://github.com/apache/kafka/pull/12187#discussion_r879162306 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2134,10 +2141,13 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] dengziming commented on a diff in pull request #12174: KAFKA-13907: Fix hanging ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable

dengziming commented on code in PR #12174: URL: https://github.com/apache/kafka/pull/12174#discussion_r879128740 ## core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala: ## @@ -248,9 +248,11 @@ abstract class KafkaServerTestHarness extends QuorumTestHarness

[GitHub] [kafka] dengziming commented on a diff in pull request #12185: MINOR: Fix buildResponseSend test cases for envelope responses

dengziming commented on code in PR #12185: URL: https://github.com/apache/kafka/pull/12185#discussion_r879103834 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -2195,22 +2193,18 @@ object TestUtils extends Logging { RequestHeader.parse(envelopeBuffer) -

[GitHub] [kafka] cadonna commented on a diff in pull request #12169: MINOR: improve description of `commit.interval.ms` config

cadonna commented on code in PR #12169: URL: https://github.com/apache/kafka/pull/12169#discussion_r879124836 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -452,7 +452,9 @@ public class StreamsConfig extends AbstractConfig { /** {@code