[GitHub] [kafka] mdedetrich commented on pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-08-18 Thread GitBox
mdedetrich commented on PR #12524: URL: https://github.com/apache/kafka/pull/12524#issuecomment-1219138597 PR has been rebased and pushed which fixes the problem described earlier, i.e. usage of `when(storeMetadata.offset()).thenReturn(null);` -- This is an automated message from the Apac

[GitHub] [kafka] dajac merged pull request #12526: MINOR: Log error when storing assignment fails

2022-08-18 Thread GitBox
dajac merged PR #12526: URL: https://github.com/apache/kafka/pull/12526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mimaison commented on a diff in pull request #12509: KAFKA-14133: Replace EasyMock with Mockito in WorkerCoordinatorTest and RootResourceTest

2022-08-18 Thread GitBox
mimaison commented on code in PR #12509: URL: https://github.com/apache/kafka/pull/12509#discussion_r948858351 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -432,30 +422,28 @@ public void testLeaderPerformAssignme

[GitHub] [kafka] mimaison merged pull request #12410: MINOR: Remove unused ShutdownableThread class and ineffective ThreadedTest classes

2022-08-18 Thread GitBox
mimaison merged PR #12410: URL: https://github.com/apache/kafka/pull/12410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mimaison commented on pull request #12375: what is Best Practices of kafka mirror maker 2

2022-08-18 Thread GitBox
mimaison commented on PR #12375: URL: https://github.com/apache/kafka/pull/12375#issuecomment-1219305270 Discussions should happen on the mailing lists, closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] mimaison closed pull request #12375: what is Best Practices of kafka mirror maker 2

2022-08-18 Thread GitBox
mimaison closed pull request #12375: what is Best Practices of kafka mirror maker 2 URL: https://github.com/apache/kafka/pull/12375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] dengziming commented on a diff in pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
dengziming commented on code in PR #12533: URL: https://github.com/apache/kafka/pull/12533#discussion_r948947569 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToIsrs.java: ## @@ -191,7 +191,7 @@ void update(Uuid topicId, int partitionId, int[] prevIsr, int[] next

[GitHub] [kafka] mimaison merged pull request #12471: MINOR; Use underscore for variable initialization in BrokerServer

2022-08-18 Thread GitBox
mimaison merged PR #12471: URL: https://github.com/apache/kafka/pull/12471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mimaison commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16

2022-08-18 Thread GitBox
mimaison commented on PR #12284: URL: https://github.com/apache/kafka/pull/12284#issuecomment-1219323255 Can you also update `bin/kafka-run-class.sh` and `bin/windows/kafka-run-class.bat`? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16

2022-08-18 Thread GitBox
mdedetrich commented on PR #12284: URL: https://github.com/apache/kafka/pull/12284#issuecomment-1219328536 @mimaison > Can you also update bin/kafka-run-class.sh and bin/windows/kafka-run-class.bat? I just checked those files and it seems that this is not necessary because we are

[GitHub] [kafka] mimaison commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16

2022-08-18 Thread GitBox
mimaison commented on PR #12284: URL: https://github.com/apache/kafka/pull/12284#issuecomment-1219339690 Ah yes, you're right! My bad -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mdedetrich opened a new pull request, #12534: MINOR; Use underscore for variable initialization in KafkaServer

2022-08-18 Thread GitBox
mdedetrich opened a new pull request, #12534: URL: https://github.com/apache/kafka/pull/12534 In Scala its standard practice to use _ whenever you are initializing variables. In regard to implementation, for object references _ initialization maps to null so there is no change in behavi

[GitHub] [kafka] mdedetrich commented on pull request #12534: MINOR; Use underscore for variable initialization in KafkaServer

2022-08-18 Thread GitBox
mdedetrich commented on PR #12534: URL: https://github.com/apache/kafka/pull/12534#issuecomment-1219341093 @mimaison Since you reviewed https://github.com/apache/kafka/pull/12471 can you have a look at this PR (once the CI is happy of course)? -- This is an automated message from the Apac

[jira] [Updated] (KAFKA-14171) mm2-offsets topic should be set retention.ms=1h or less as default

2022-08-18 Thread Justinwins (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justinwins updated KAFKA-14171: --- Description: - This seems a small bug (or improvment) ,but it really impacts perf of mm2. - When D

[jira] [Created] (KAFKA-14171) mm2-offsets topic should be set retention.ms=1h or less as default

2022-08-18 Thread Justinwins (Jira)
Justinwins created KAFKA-14171: -- Summary: mm2-offsets topic should be set retention.ms=1h or less as default Key: KAFKA-14171 URL: https://issues.apache.org/jira/browse/KAFKA-14171 Project: Kafka

[GitHub] [kafka] showuon commented on pull request #12525: MINOR: Remove spurious sleep in ConsumerCoordinatorTest

2022-08-18 Thread GitBox
showuon commented on PR #12525: URL: https://github.com/apache/kafka/pull/12525#issuecomment-1219445407 @ijuma @aiquestion , please take a look. Thanks. Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnector

[GitHub] [kafka] Gerrrr opened a new pull request, #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge opened a new pull request, #12535: URL: https://github.com/apache/kafka/pull/12535 This patch fixes another incorrect version check in the FK code and adds unit tests that would have caught this bug. ### Committer Checklist (excluded from commit message) - [ ] Verify design

[GitHub] [kafka] Gerrrr commented on pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on PR #12535: URL: https://github.com/apache/kafka/pull/12535#issuecomment-1219496131 @vvcephei Can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] mimaison opened a new pull request, #12536: KAFKA-14160: Streamline clusterId retrieval in Connect

2022-08-18 Thread GitBox
mimaison opened a new pull request, #12536: URL: https://github.com/apache/kafka/pull/12536 Cache the Kafka cluster Id once it has been retrieved to avoid creating many Admin clients at startup. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implemen

[GitHub] [kafka] dplavcic commented on pull request #12492: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-08-18 Thread GitBox
dplavcic commented on PR #12492: URL: https://github.com/apache/kafka/pull/12492#issuecomment-1219679741 > @cadonna and @dplavcic I hope that the new version has addressed all comments up to now. Thank you in advance for the review! LGTM! -- This is an automated message from the Ap

[GitHub] [kafka] cmccabe commented on a diff in pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12533: URL: https://github.com/apache/kafka/pull/12533#discussion_r949351073 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToIsrs.java: ## @@ -191,7 +191,7 @@ void update(Uuid topicId, int partitionId, int[] prevIsr, int[] nextIsr

[GitHub] [kafka] cmccabe commented on a diff in pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12533: URL: https://github.com/apache/kafka/pull/12533#discussion_r949351073 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToIsrs.java: ## @@ -191,7 +191,7 @@ void update(Uuid topicId, int partitionId, int[] prevIsr, int[] nextIsr

[GitHub] [kafka] cmccabe commented on a diff in pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12533: URL: https://github.com/apache/kafka/pull/12533#discussion_r949351947 ## core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala: ## @@ -173,11 +173,11 @@ abstract class KafkaServerTestHarness extends QuorumTestHarness {

[GitHub] [kafka] Gerrrr commented on pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on PR #12535: URL: https://github.com/apache/kafka/pull/12535#issuecomment-1219722137 Test failure: ``` [2022-08-18T14:24:17.527Z] FetchRequestTestDowngrade > testTopicIdIsRemovedFromFetcherWhenControllerDowngrades() STARTED [2022-08-18T14:24:17.527Z] integrati

[GitHub] [kafka] vvcephei commented on a diff in pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
vvcephei commented on code in PR #12535: URL: https://github.com/apache/kafka/pull/12535#discussion_r949388743 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionStoreReceiveProcessorSupplier.java: ## @@ -91,7 +91,7 @@ public void proc

[GitHub] [kafka] dplavcic commented on a diff in pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-08-18 Thread GitBox
dplavcic commented on code in PR #12505: URL: https://github.com/apache/kafka/pull/12505#discussion_r949392447 ## streams/src/test/java/org/apache/kafka/streams/state/internals/KeyValueStoreBuilderTest.java: ## @@ -126,27 +121,15 @@ public void shouldThrowNullPointerIfInnerIsNul

[GitHub] [kafka] Gerrrr commented on a diff in pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on code in PR #12535: URL: https://github.com/apache/kafka/pull/12535#discussion_r949396415 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionStoreReceiveProcessorSupplier.java: ## @@ -91,7 +91,7 @@ public void proces

[GitHub] [kafka] Gerrrr commented on a diff in pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on code in PR #12535: URL: https://github.com/apache/kafka/pull/12535#discussion_r949398138 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKey.java: ## @@ -38,8 +38,22 @@ public KP getPrimaryKey() { return pri

[GitHub] [kafka] Gerrrr commented on pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on PR #12535: URL: https://github.com/apache/kafka/pull/12535#issuecomment-1219734073 I added an upgrade test back in https://github.com/apache/kafka/pull/12122. Unfortunately, it didn't catch these version check bugs. I am going to figure out why and improve the test. I'd

[GitHub] [kafka] Gerrrr commented on a diff in pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
Ge commented on code in PR #12535: URL: https://github.com/apache/kafka/pull/12535#discussion_r949398138 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKey.java: ## @@ -38,8 +38,22 @@ public KP getPrimaryKey() { return pri

[GitHub] [kafka] mimaison commented on pull request #12534: MINOR; Use underscore for variable initialization in KafkaServer

2022-08-18 Thread GitBox
mimaison commented on PR #12534: URL: https://github.com/apache/kafka/pull/12534#issuecomment-1219749268 Thanks for the PR! I did a quick search and it looks like there are 200+ such instances across 40+ files. If you want to address them all, maybe let's group them in 1 or 2 PRs. --

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
akhileshchg commented on code in PR #12533: URL: https://github.com/apache/kafka/pull/12533#discussion_r949415430 ## metadata/src/main/java/org/apache/kafka/controller/BrokersToIsrs.java: ## @@ -191,7 +191,7 @@ void update(Uuid topicId, int partitionId, int[] prevIsr, int[] nex

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
akhileshchg commented on code in PR #12533: URL: https://github.com/apache/kafka/pull/12533#discussion_r949414831 ## core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala: ## @@ -173,11 +173,11 @@ abstract class KafkaServerTestHarness extends QuorumTestHarness

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
akhileshchg commented on code in PR #12533: URL: https://github.com/apache/kafka/pull/12533#discussion_r949419718 ## core/src/test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala: ## @@ -32,10 +32,45 @@ import org.apache.kafka.common.requests.MetadataResponse import org.j

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12479: MINOR; Convert some integration tests to run with the KRaft modes

2022-08-18 Thread GitBox
ahuang98 commented on code in PR #12479: URL: https://github.com/apache/kafka/pull/12479#discussion_r940527628 ## core/src/test/scala/integration/kafka/api/RackAwareAutoTopicCreationTest.scala: ## @@ -37,29 +43,57 @@ class RackAwareAutoTopicCreationTest extends KafkaServerTestH

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12479: MINOR; Convert some integration tests to run with the KRaft modes

2022-08-18 Thread GitBox
ahuang98 commented on code in PR #12479: URL: https://github.com/apache/kafka/pull/12479#discussion_r942970441 ## core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala: ## @@ -187,264 +220,337 @@ class DeleteTopicTest extends QuorumTestHarness { }.toSet } - @Test

[GitHub] [kafka] mdedetrich commented on pull request #12534: MINOR; Use underscore for variable initialization in KafkaServer

2022-08-18 Thread GitBox
mdedetrich commented on PR #12534: URL: https://github.com/apache/kafka/pull/12534#issuecomment-1219791330 Sure thing will do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] vvcephei commented on a diff in pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
vvcephei commented on code in PR #12535: URL: https://github.com/apache/kafka/pull/12535#discussion_r949454530 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionStoreReceiveProcessorSupplier.java: ## @@ -91,7 +91,7 @@ public void proc

[GitHub] [kafka] vvcephei commented on a diff in pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
vvcephei commented on code in PR #12535: URL: https://github.com/apache/kafka/pull/12535#discussion_r949454836 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKey.java: ## @@ -38,8 +38,22 @@ public KP getPrimaryKey() { return p

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
akhileshchg commented on code in PR #12533: URL: https://github.com/apache/kafka/pull/12533#discussion_r949455336 ## core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala: ## @@ -173,11 +173,11 @@ abstract class KafkaServerTestHarness extends QuorumTestHarness

[GitHub] [kafka] cmccabe commented on a diff in pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12533: URL: https://github.com/apache/kafka/pull/12533#discussion_r949455413 ## core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala: ## @@ -173,11 +173,11 @@ abstract class KafkaServerTestHarness extends QuorumTestHarness {

[GitHub] [kafka] vvcephei commented on pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
vvcephei commented on PR #12535: URL: https://github.com/apache/kafka/pull/12535#issuecomment-1219795362 Test failure was unrelated: ``` [Build / JDK 11 and Scala 2.13 / integration.kafka.server.FetchRequestTestDowngrade.testTopicIdIsRemovedFromFetcherWhenControllerDowngrades()](ht

[GitHub] [kafka] yashmayya commented on a diff in pull request #12509: KAFKA-14133: Replace EasyMock with Mockito in WorkerCoordinatorTest and RootResourceTest

2022-08-18 Thread GitBox
yashmayya commented on code in PR #12509: URL: https://github.com/apache/kafka/pull/12509#discussion_r949456092 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -432,30 +422,28 @@ public void testLeaderPerformAssignm

[GitHub] [kafka] vvcephei merged pull request #12535: KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier

2022-08-18 Thread GitBox
vvcephei merged PR #12535: URL: https://github.com/apache/kafka/pull/12535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] akhileshchg commented on pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
akhileshchg commented on PR #12533: URL: https://github.com/apache/kafka/pull/12533#issuecomment-1219803916 @dengziming @cmccabe I addressed your comments. I have question regarding KafkaTestHarness changes. Please let me know your thoughts. -- This is an automated message from the Apach

[GitHub] [kafka] guozhangwang opened a new pull request, #12537: MINOR: Improve KafkaProducer Javadocs

2022-08-18 Thread GitBox
guozhangwang opened a new pull request, #12537: URL: https://github.com/apache/kafka/pull/12537 While reviewing KIP-588 and KIP-691 I went through the exception throwing behavior and wanted to improve the related javadocs a little bit. ### Committer Checklist (excluded from commit mes

[GitHub] [kafka] hachikuji opened a new pull request, #12538: MINOR: Fix unexpected request error in kraft shutdown

2022-08-18 Thread GitBox
hachikuji opened a new pull request, #12538: URL: https://github.com/apache/kafka/pull/12538 We have been seeing a few exceptions like the following when running integration tests: ``` [2022-08-18 13:02:59,470] ERROR [ControllerApis nodeId=3000] Unexpected error handling request Reque

[GitHub] [kafka] cmccabe commented on a diff in pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12533: URL: https://github.com/apache/kafka/pull/12533#discussion_r949580181 ## core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala: ## @@ -173,11 +173,11 @@ abstract class KafkaServerTestHarness extends QuorumTestHarness {

[GitHub] [kafka] soarez commented on pull request #12198: MINOR: Avoid possibly resolvable name in tests

2022-08-18 Thread GitBox
soarez commented on PR #12198: URL: https://github.com/apache/kafka/pull/12198#issuecomment-1219955676 @dajac thanks for having a look and for the suggestion. `RFC2606.invalid` is a better choice, especially since we're already using it. -- This is an automated message from the Apache Git

[GitHub] [kafka] mdedetrich commented on pull request #12534: MINOR; Use underscore for variable initialization in Scala sources

2022-08-18 Thread GitBox
mdedetrich commented on PR #12534: URL: https://github.com/apache/kafka/pull/12534#issuecomment-1219980341 @mimaison PR has been updated as you wanted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] ijuma commented on a diff in pull request #12538: MINOR: Fix unexpected request error in kraft shutdown

2022-08-18 Thread GitBox
ijuma commented on code in PR #12538: URL: https://github.com/apache/kafka/pull/12538#discussion_r949628021 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -275,15 +275,15 @@ metaProperties, config, new MetadataRecordSerde(), metadataPartition, KafkaRaftS

[GitHub] [kafka] ijuma commented on a diff in pull request #12538: MINOR: Fix unexpected request error in kraft shutdown

2022-08-18 Thread GitBox
ijuma commented on code in PR #12538: URL: https://github.com/apache/kafka/pull/12538#discussion_r949628460 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -275,15 +275,15 @@ metaProperties, config, new MetadataRecordSerde(), metadataPartition, KafkaRaftS

[GitHub] [kafka] hachikuji commented on a diff in pull request #12538: MINOR: Fix unexpected request error in kraft shutdown

2022-08-18 Thread GitBox
hachikuji commented on code in PR #12538: URL: https://github.com/apache/kafka/pull/12538#discussion_r949654185 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -275,15 +275,15 @@ metaProperties, config, new MetadataRecordSerde(), metadataPartition, KafkaRaft

[GitHub] [kafka] hachikuji commented on a diff in pull request #12538: MINOR: Fix unexpected request error in kraft shutdown

2022-08-18 Thread GitBox
hachikuji commented on code in PR #12538: URL: https://github.com/apache/kafka/pull/12538#discussion_r949654185 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -275,15 +275,15 @@ metaProperties, config, new MetadataRecordSerde(), metadataPartition, KafkaRaft

[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949590579 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949665053 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949665682 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949666958 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949668350 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949670514 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949671940 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949674532 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] hachikuji commented on a diff in pull request #12538: MINOR: Fix unexpected request error in kraft shutdown

2022-08-18 Thread GitBox
hachikuji commented on code in PR #12538: URL: https://github.com/apache/kafka/pull/12538#discussion_r949676740 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -275,15 +275,15 @@ metaProperties, config, new MetadataRecordSerde(), metadataPartition, KafkaRaft

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949676920 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] hachikuji commented on a diff in pull request #12538: MINOR: Fix unexpected request error in kraft shutdown

2022-08-18 Thread GitBox
hachikuji commented on code in PR #12538: URL: https://github.com/apache/kafka/pull/12538#discussion_r949676740 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -275,15 +275,15 @@ metaProperties, config, new MetadataRecordSerde(), metadataPartition, KafkaRaft

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949678938 ## metadata/src/main/java/org/apache/kafka/metadata/util/BatchFileReader.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949679883 ## metadata/src/main/java/org/apache/kafka/metadata/util/BatchFileReader.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949680410 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1118,6 +1059,65 @@ private void updateWriteOffset(long offset) { } }

[jira] [Commented] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2022-08-18 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581574#comment-17581574 ] Guozhang Wang commented on KAFKA-10635: --- Hello [~nicktelford] Could you also paste

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949685089 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -188,12 +182,16 @@ private ApiError updateFeature( } } -

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949686749 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -72,20 +71,18 @@ import static org.junit.jupiter.api.Assertions.assertTrue

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949687350 ## metadata/src/main/java/org/apache/kafka/controller/LogReplayTracker.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949687749 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1142,15 +1142,19 @@ private void renounce() { purgatory.failAll(newNotCo

[GitHub] [kafka] guozhangwang commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()

2022-08-18 Thread GitBox
guozhangwang commented on PR #12512: URL: https://github.com/apache/kafka/pull/12512#issuecomment-1220094009 Hello @vamossagar12 thanks for the PR. I took another pass on KIP-691 and updated some exception cases in the wiki, and I think we need to thoroughly go through them before we

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949693026 ## metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java: ## @@ -222,52 +227,130 @@ public void testFeatureControlIterator() throws Exceptio

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949693026 ## metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java: ## @@ -222,52 +227,130 @@ public void testFeatureControlIterator() throws Exceptio

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949693455 ## metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java: ## @@ -222,52 +227,130 @@ public void testFeatureControlIterator() throws Exceptio

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949694015 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -952,6 +966,7 @@ public void testEarlyControllerResults() throws Throwable {

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949694015 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -952,6 +966,7 @@ public void testEarlyControllerResults() throws Throwable {

[GitHub] [kafka] cmccabe commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
cmccabe commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949693026 ## metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java: ## @@ -222,52 +227,130 @@ public void testFeatureControlIterator() throws Exceptio

[GitHub] [kafka] cmccabe merged pull request #12533: KAFKA-14170: Fix NPE in the deleteTopics() code path of KRaft Controller

2022-08-18 Thread GitBox
cmccabe merged PR #12533: URL: https://github.com/apache/kafka/pull/12533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] ijuma closed pull request #12500: MINOR: Remove spurious sleep in ConsumerCoordinatorTest

2022-08-18 Thread GitBox
ijuma closed pull request #12500: MINOR: Remove spurious sleep in ConsumerCoordinatorTest URL: https://github.com/apache/kafka/pull/12500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] showuon merged pull request #12525: MINOR: Remove spurious sleep in ConsumerCoordinatorTest

2022-08-18 Thread GitBox
showuon merged PR #12525: URL: https://github.com/apache/kafka/pull/12525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] vamossagar12 commented on pull request #12512: KAFKA-14138: Wrapping all non-fatal exceptions in KafkaException and throwing all fata exceptions directly for producer.send()

2022-08-18 Thread GitBox
vamossagar12 commented on PR #12512: URL: https://github.com/apache/kafka/pull/12512#issuecomment-1220313754 hello @guozhangwang Thanks for the note. I noticed that you had made some changes to the KIP. This PR, I kept the changes focussed on send method but the KIP covers all methods. Sure

[GitHub] [kafka] RivenSun2 opened a new pull request, #12539: MINOR: Modify the error log level in SaslChannelBuilder

2022-08-18 Thread GitBox
RivenSun2 opened a new pull request, #12539: URL: https://github.com/apache/kafka/pull/12539 Modify the error log level in SaslChannelBuilder ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build sta