[GitHub] [kafka] showuon commented on pull request #12658: KAFKA-14233: disable testReloadUpdatedFilesWithoutConfigChange

2022-09-19 Thread GitBox
showuon commented on PR #12658: URL: https://github.com/apache/kafka/pull/12658#issuecomment-1250648906 Finally got a build without red light ![image](https://user-images.githubusercontent.com/43372967/190966322-be85699a-f247-489d-b0ef-61a4870fcae8.png) -- This is an automated mess

[jira] [Comment Edited] (KAFKA-14043) The latest status of the task is overwritten by the old status

2022-09-19 Thread doupengwei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606402#comment-17606402 ] doupengwei edited comment on KAFKA-14043 at 9/19/22 7:58 AM: -

[GitHub] [kafka] tombentley opened a new pull request, #12661: MINOR: Update release versions for upgrade tests with 3.0.2, 3.1.2, 3.2.3 release

2022-09-19 Thread GitBox
tombentley opened a new pull request, #12661: URL: https://github.com/apache/kafka/pull/12661 Updates release versions in files that are used for upgrade test with the 3.0.2, 3.1.2, 3.2.3 release version. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] Gerrrr commented on pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

2022-09-19 Thread GitBox
Ge commented on PR #12393: URL: https://github.com/apache/kafka/pull/12393#issuecomment-1250710841 Hey @guozhangwang ! Yeah, I am still working on the PR - adding integration tests, running benchmarks, etc. I will ping you here and update the description once the PR is ready for

[jira] [Updated] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-19 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley updated KAFKA-14196: Fix Version/s: 3.2.3 (was: 3.2.2) > Duplicated consumption during rebalance

[jira] [Updated] (KAFKA-14208) KafkaConsumer#commitAsync throws unexpected WakeupException

2022-09-19 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley updated KAFKA-14208: Fix Version/s: 3.2.3 (was: 3.2.2) > KafkaConsumer#commitAsync throws unexpe

[GitHub] [kafka] fvaleri commented on pull request #12656: MINOR: Update offset.storage.topic description

2022-09-19 Thread GitBox
fvaleri commented on PR #12656: URL: https://github.com/apache/kafka/pull/12656#issuecomment-1250780273 @mimaison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

2022-09-19 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew de Detrich updated KAFKA-14132: --- Description: {color:#de350b}Some of the tests below use EasyMock as well. For those

[GitHub] [kafka] cadonna commented on a diff in pull request #12650: KAFKA-10199: Adapt restoration integration tests to state updater

2022-09-19 Thread GitBox
cadonna commented on code in PR #12650: URL: https://github.com/apache/kafka/pull/12650#discussion_r974112162 ## streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -291,8 +297,9 @@ public void shouldSuccessfullyStartWhenLoggingDisabled(

[GitHub] [kafka] omkreddy merged pull request #12661: MINOR: Update release versions for upgrade tests with 3.0.2, 3.1.2, 3.2.3 release

2022-09-19 Thread GitBox
omkreddy merged PR #12661: URL: https://github.com/apache/kafka/pull/12661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] C0urante commented on a diff in pull request #12656: MINOR: Update offset.storage.topic description

2022-09-19 Thread GitBox
C0urante commented on code in PR #12656: URL: https://github.com/apache/kafka/pull/12656#discussion_r974156910 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java: ## @@ -108,7 +108,7 @@ public class WorkerConfig extends AbstractConfig { pu

[GitHub] [kafka] C0urante commented on a diff in pull request #12656: MINOR: Update offset.storage.topic description

2022-09-19 Thread GitBox
C0urante commented on code in PR #12656: URL: https://github.com/apache/kafka/pull/12656#discussion_r974158439 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneConfig.java: ## @@ -28,7 +28,7 @@ public class StandaloneConfig extends WorkerCon

[GitHub] [kafka] C0urante commented on a diff in pull request #12656: MINOR: Update offset.storage.topic description

2022-09-19 Thread GitBox
C0urante commented on code in PR #12656: URL: https://github.com/apache/kafka/pull/12656#discussion_r974158739 ## docs/connect.html: ## @@ -53,7 +53,7 @@ Running Kafka ConnectThe important configuration options specific to standalone mode are: -offset.storage.file

[GitHub] [kafka] C0urante commented on pull request #12656: MINOR: Update offset.storage.topic description

2022-09-19 Thread GitBox
C0urante commented on PR #12656: URL: https://github.com/apache/kafka/pull/12656#issuecomment-1250915379 Thanks @fvaleri, this is a useful change. I've left a few small comments but it should be good to go after they're addressed. -- This is an automated message from the Apache Git Servic

[GitHub] [kafka] C0urante commented on a diff in pull request #12656: MINOR: Update offset.storage.topic description

2022-09-19 Thread GitBox
C0urante commented on code in PR #12656: URL: https://github.com/apache/kafka/pull/12656#discussion_r974156910 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java: ## @@ -108,7 +108,7 @@ public class WorkerConfig extends AbstractConfig { pu

[GitHub] [kafka] C0urante commented on a diff in pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-19 Thread GitBox
C0urante commented on code in PR #12632: URL: https://github.com/apache/kafka/pull/12632#discussion_r974169402 ## core/src/main/scala/kafka/tools/StreamsResetter.java: ## @@ -213,11 +217,16 @@ private void parseArguments(final String[] args) { .ofType(String.class)

[GitHub] [kafka] nizhikov commented on a diff in pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-19 Thread GitBox
nizhikov commented on code in PR #12632: URL: https://github.com/apache/kafka/pull/12632#discussion_r974176089 ## core/src/main/scala/kafka/tools/StreamsResetter.java: ## @@ -213,11 +217,16 @@ private void parseArguments(final String[] args) { .ofType(String.class)

[GitHub] [kafka] vvcephei commented on pull request #12594: MINOR: Include all hosts in metadata for topology

2022-09-19 Thread GitBox
vvcephei commented on PR #12594: URL: https://github.com/apache/kafka/pull/12594#issuecomment-1250971460 ``` [2022-09-07T15:38:17.417Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-12594/streams/src/test/java/org/apache/kafka/streams/integration/NamedTo

[GitHub] [kafka] C0urante commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-19 Thread GitBox
C0urante commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r974209237 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: ## @@ -517,13 +517,13 @@ public void testTaskAssign

[jira] (KAFKA-13927) Kafka Connect Sink Connector Success after RetriableException, no commit offset to remote.

2022-09-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13927 ] Chris Egerton deleted comment on KAFKA-13927: --- was (Author: chrisegerton): https://github.com/apache/kafka/pull/12566 > Kafka Connect Sink Connector Success after RetriableException, no co

[jira] [Assigned] (KAFKA-13927) Kafka Connect Sink Connector Success after RetriableException, no commit offset to remote.

2022-09-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-13927: - Assignee: Jordan Bull > Kafka Connect Sink Connector Success after RetriableException,

[jira] [Commented] (KAFKA-14239) Merge StateRestorationIntegrationTest into RestoreIntegrationTest

2022-09-19 Thread Ahmed Sobeh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606594#comment-17606594 ] Ahmed Sobeh commented on KAFKA-14239: - Hi! I'm a newbie and I'd like to work on this

[GitHub] [kafka] C0urante commented on a diff in pull request #12566: KAFKA-13927: Only clear origOffsets when clearing messageBatch

2022-09-19 Thread GitBox
C0urante commented on code in PR #12566: URL: https://github.com/apache/kafka/pull/12566#discussion_r974231345 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -435,6 +453,13 @@ public void testPollRedelivery() throws Exception {

[jira] [Comment Edited] (KAFKA-14239) Merge StateRestorationIntegrationTest into RestoreIntegrationTest

2022-09-19 Thread Ahmed Sobeh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606594#comment-17606594 ] Ahmed Sobeh edited comment on KAFKA-14239 at 9/19/22 2:11 PM:

[jira] [Assigned] (KAFKA-14239) Merge StateRestorationIntegrationTest into RestoreIntegrationTest

2022-09-19 Thread Ahmed Sobeh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Sobeh reassigned KAFKA-14239: --- Assignee: Ahmed Sobeh > Merge StateRestorationIntegrationTest into RestoreIntegrationTest >

[GitHub] [kafka] ijuma commented on pull request #12658: KAFKA-14233: disable testReloadUpdatedFilesWithoutConfigChange

2022-09-19 Thread GitBox
ijuma commented on PR #12658: URL: https://github.com/apache/kafka/pull/12658#issuecomment-1251084739 Thanks @showuon! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] fvaleri commented on a diff in pull request #12656: MINOR: Update offset.storage.topic description

2022-09-19 Thread GitBox
fvaleri commented on code in PR #12656: URL: https://github.com/apache/kafka/pull/12656#discussion_r974366092 ## docs/connect.html: ## @@ -53,7 +53,7 @@ Running Kafka ConnectThe important configuration options specific to standalone mode are: -offset.storage.file.

[GitHub] [kafka] fvaleri commented on pull request #12656: MINOR: Update offset.storage.topic description

2022-09-19 Thread GitBox
fvaleri commented on PR #12656: URL: https://github.com/apache/kafka/pull/12656#issuecomment-1251149885 Thanks @C0urante for the quick feedback. It should be good now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Updated] (KAFKA-14063) Kafka message parsing can cause ooms with small antagonistic payloads

2022-09-19 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-14063: -- Fix Version/s: 2.8.2 3.2.3 3.1.2 3.0.2 > Kafk

[jira] [Resolved] (KAFKA-14063) Kafka message parsing can cause ooms with small antagonistic payloads

2022-09-19 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-14063. --- Resolution: Fixed > Kafka message parsing can cause ooms with small antagonistic payloads >

[jira] [Comment Edited] (KAFKA-14241) Implement the snapshot cleanup policy

2022-09-19 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606669#comment-17606669 ] Jose Armando Garcia Sancio edited comment on KAFKA-14241 at 9/19/22 4:32 PM: -

[jira] [Commented] (KAFKA-14241) Implement the snapshot cleanup policy

2022-09-19 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606669#comment-17606669 ] Jose Armando Garcia Sancio commented on KAFKA-14241: Yes and those t

[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-19 Thread GitBox
nizhikov commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1251293104 @C0urante tests finished. It seems for me that failures unrelated but can you double check? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] C0urante commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-19 Thread GitBox
C0urante commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1251316903 Yep, looks good. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] C0urante merged pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-19 Thread GitBox
C0urante merged PR #12632: URL: https://github.com/apache/kafka/pull/12632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] C0urante merged pull request #12656: MINOR: Update offset.storage.topic description

2022-09-19 Thread GitBox
C0urante merged PR #12656: URL: https://github.com/apache/kafka/pull/12656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-12878) Support --bootstrap-server kafka-streams-application-reset

2022-09-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-12878. --- Fix Version/s: 3.4.0 Resolution: Done > Support --bootstrap-server kafka-streams-appl

[GitHub] [kafka] nizhikov commented on pull request #12632: KAFKA-12878 Support --bootstrap-server in kafka-streams-application-reset tool

2022-09-19 Thread GitBox
nizhikov commented on PR #12632: URL: https://github.com/apache/kafka/pull/12632#issuecomment-1251318220 @C0urante Thank you very much) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12650: KAFKA-10199: Adapt restoration integration tests to state updater

2022-09-19 Thread GitBox
guozhangwang commented on code in PR #12650: URL: https://github.com/apache/kafka/pull/12650#discussion_r974499005 ## streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -291,8 +297,9 @@ public void shouldSuccessfullyStartWhenLoggingDisa

[GitHub] [kafka] cadonna commented on pull request #12650: KAFKA-10199: Adapt restoration integration tests to state updater

2022-09-19 Thread GitBox
cadonna commented on PR #12650: URL: https://github.com/apache/kafka/pull/12650#issuecomment-1251322148 Build failures are unrelated: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.runtime.rest.RestServerTest.testDisableAdminEndpoint ``` -- This is an automated mess

[GitHub] [kafka] cadonna merged pull request #12650: KAFKA-10199: Adapt restoration integration tests to state updater

2022-09-19 Thread GitBox
cadonna merged PR #12650: URL: https://github.com/apache/kafka/pull/12650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12659: [DO NOT MERGE] KAFKA-10199: Integrate Topology Pause/Resume with StateUpdater

2022-09-19 Thread GitBox
guozhangwang commented on code in PR #12659: URL: https://github.com/apache/kafka/pull/12659#discussion_r974503648 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -785,6 +787,22 @@ private void addTasksToStateUpdater() { }

[GitHub] [kafka] jordanbull commented on a diff in pull request #12566: KAFKA-13927: Only clear origOffsets when clearing messageBatch

2022-09-19 Thread GitBox
jordanbull commented on code in PR #12566: URL: https://github.com/apache/kafka/pull/12566#discussion_r974544940 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java: ## @@ -763,6 +763,9 @@ private void onPartitionsRemoved(Collection partitions,

[GitHub] [kafka] jordanbull commented on a diff in pull request #12566: KAFKA-13927: Only clear origOffsets when clearing messageBatch

2022-09-19 Thread GitBox
jordanbull commented on code in PR #12566: URL: https://github.com/apache/kafka/pull/12566#discussion_r974545797 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java: ## @@ -435,6 +453,13 @@ public void testPollRedelivery() throws Exception {

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-19 Thread GitBox
vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r974548386 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: ## @@ -517,13 +517,13 @@ public void testTaskAs

[jira] [Commented] (KAFKA-10635) Streams application fails with OutOfOrderSequenceException after rolling restarts of brokers

2022-09-19 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606711#comment-17606711 ] Guozhang Wang commented on KAFKA-10635: --- >From the logs, I think the OOOSException

[GitHub] [kafka] hachikuji merged pull request #12653: KAFKA-14240; Validate kraft snapshot state on startup

2022-09-19 Thread GitBox
hachikuji merged PR #12653: URL: https://github.com/apache/kafka/pull/12653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Resolved] (KAFKA-14240) Ensure kraft metadata log dir is initialized with valid snapshot state

2022-09-19 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-14240. - Resolution: Fixed > Ensure kraft metadata log dir is initialized with valid snapshot sta

[jira] [Updated] (KAFKA-14207) Add a 6.10 section for KRaft

2022-09-19 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14207: --- Labels: documentation kraft (was: ) > Add a 6.10 section for KRaft

[jira] [Updated] (KAFKA-14207) Add a 6.10 section for KRaft

2022-09-19 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14207: --- Affects Version/s: 3.3.0 > Add a 6.10 section for KRaft > --

[jira] [Updated] (KAFKA-14207) Add a 6.10 section for KRaft

2022-09-19 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14207: --- Fix Version/s: (was: 3.3.0) > Add a 6.10 section for KRaft > ---

[jira] [Updated] (KAFKA-14174) Operation documentation for KRaft

2022-09-19 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14174: --- Fix Version/s: (was: 3.3.0) > Operation documentation for KRaft

[GitHub] [kafka] cmccabe opened a new pull request, #12662: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-19 Thread GitBox
cmccabe opened a new pull request, #12662: URL: https://github.com/apache/kafka/pull/12662 Convert StandardAuthorizer to use copy-on-write data structures. The issue with the concurrent skiplist was that because it was modified while in use by StandardAuthorizer#authorize, we could sometim

[GitHub] [kafka] cmccabe commented on pull request #12636: KAFKA-14214: Convert StandardAuthorizer to copy-on-write

2022-09-19 Thread GitBox
cmccabe commented on PR #12636: URL: https://github.com/apache/kafka/pull/12636#issuecomment-1251532201 I uploaded a new version at https://github.com/apache/kafka/pull/12662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12659: [DO NOT MERGE] KAFKA-10199: Integrate Topology Pause/Resume with StateUpdater

2022-09-19 Thread GitBox
guozhangwang commented on code in PR #12659: URL: https://github.com/apache/kafka/pull/12659#discussion_r974503648 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -785,6 +787,22 @@ private void addTasksToStateUpdater() { }

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12659: [DO NOT MERGE] KAFKA-10199: Integrate Topology Pause/Resume with StateUpdater

2022-09-19 Thread GitBox
guozhangwang commented on code in PR #12659: URL: https://github.com/apache/kafka/pull/12659#discussion_r974686659 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -785,6 +787,22 @@ private void addTasksToStateUpdater() { }

[GitHub] [kafka] philipnee opened a new pull request, #12663: [Consumer Refactor] Define event handler interface and events

2022-09-19 Thread GitBox
philipnee opened a new pull request, #12663: URL: https://github.com/apache/kafka/pull/12663 https://cwiki.apache.org/confluence/display/KAFKA/Proposal%3A+Consumer+Threading+Model+Refactor * We want to abstract away the Queue from the new KafkaConsumer using an EventHandler. - pol

[GitHub] [kafka] philipnee closed pull request #12633: [Consumer Refactor] Background thread skeleton

2022-09-19 Thread GitBox
philipnee closed pull request #12633: [Consumer Refactor] Background thread skeleton URL: https://github.com/apache/kafka/pull/12633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] ryan-burningham commented on pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-09-19 Thread GitBox
ryan-burningham commented on PR #11748: URL: https://github.com/apache/kafka/pull/11748#issuecomment-1251628710 Help me understand where we are at with this issue. @mimaison it appears you deleted the branch, but is this fixed in another branch or unreleased version of mirrormaker? I am s

[GitHub] [kafka] akhileshchg commented on pull request #12628: KAFKA-14214: Introduce read-write lock to StandardAuthorizer for consistent ACL reads.

2022-09-19 Thread GitBox
akhileshchg commented on PR #12628: URL: https://github.com/apache/kafka/pull/12628#issuecomment-1251672840 Reopened the PR. Moved the ReadWrite lock from StandardAuthorizerData scope to StandardAuthorizer. I'm fine with most of the methods. with moving the lock, but it seems loadSnapshot c

[GitHub] [kafka] philipnee commented on pull request #12663: [Consumer Refactor] Define event handler interface and events

2022-09-19 Thread GitBox
philipnee commented on PR #12663: URL: https://github.com/apache/kafka/pull/12663#issuecomment-1251684468 cc @guozhangwang @hachikuji @dajac for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-14243) Temporarily disable unsafe downgrade

2022-09-19 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-14243: - Summary: Temporarily disable unsafe downgrade (was: Disable unsafe downgrade in 3.3) > Tempora

[jira] [Created] (KAFKA-14243) Disable unsafe downgrade in 3.3

2022-09-19 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-14243: Summary: Disable unsafe downgrade in 3.3 Key: KAFKA-14243 URL: https://issues.apache.org/jira/browse/KAFKA-14243 Project: Kafka Issue Type: Bug R

[jira] [Updated] (KAFKA-14243) Temporarily disable unsafe downgrade

2022-09-19 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-14243: - Description: Temporarily disable unsafe downgrade since we haven't implemented reloading snapsho

[GitHub] [kafka] cmccabe opened a new pull request, #12664: KAFKA-14243: Temporarily disable unsafe downgrade

2022-09-19 Thread GitBox
cmccabe opened a new pull request, #12664: URL: https://github.com/apache/kafka/pull/12664 Temporarily disable unsafe downgrade until we can implement reloading snapshots on unsafe downgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] cmccabe commented on pull request #12628: KAFKA-14214: Introduce read-write lock to StandardAuthorizer for consistent ACL reads.

2022-09-19 Thread GitBox
cmccabe commented on PR #12628: URL: https://github.com/apache/kafka/pull/12628#issuecomment-1251690504 Thanks, @akhileshchg . Can you remove the AclAuthorizerBenchmark change from here? I can post a separate PR for this (which we don't need in 3.3...) -- This is an automated message from

[jira] [Commented] (KAFKA-5564) Fail to create topics with error 'While recording the replica LEO, the partition [topic2,0] hasn't been created'

2022-09-19 Thread Ahmed Toumi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606803#comment-17606803 ] Ahmed Toumi commented on KAFKA-5564: Same issue with kafka 2.3.4 infinit log like th

[jira] [Comment Edited] (KAFKA-5564) Fail to create topics with error 'While recording the replica LEO, the partition [topic2,0] hasn't been created'

2022-09-19 Thread Ahmed Toumi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606803#comment-17606803 ] Ahmed Toumi edited comment on KAFKA-5564 at 9/20/22 12:28 AM: -

[GitHub] [kafka] akhileshchg commented on pull request #12628: KAFKA-14214: Introduce read-write lock to StandardAuthorizer for consistent ACL reads.

2022-09-19 Thread GitBox
akhileshchg commented on PR #12628: URL: https://github.com/apache/kafka/pull/12628#issuecomment-1251763252 I reverted the benchmark changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] showuon commented on pull request #12628: KAFKA-14214: Introduce read-write lock to StandardAuthorizer for consistent ACL reads.

2022-09-19 Thread GitBox
showuon commented on PR #12628: URL: https://github.com/apache/kafka/pull/12628#issuecomment-1251787224 > Reopened the PR. Moved the ReadWrite lock from StandardAuthorizerData scope to StandardAuthorizer. I'm okay with most methods after moving the lock, but loadSnapshot can be pretty heavy

[GitHub] [kafka] akhileshchg commented on pull request #12628: KAFKA-14214: Introduce read-write lock to StandardAuthorizer for consistent ACL reads.

2022-09-19 Thread GitBox
akhileshchg commented on PR #12628: URL: https://github.com/apache/kafka/pull/12628#issuecomment-1251845966 > Reopened the PR. Moved the ReadWrite lock from StandardAuthorizerData scope to StandardAuthorizer. I'm okay with most methods after moving the lock, but loadSnapshot can be pretty h

[GitHub] [kafka] omkreddy commented on pull request #12039: KAFKA-13725: KIP-768 OAuth code mixes public and internal classes in same package

2022-09-19 Thread GitBox
omkreddy commented on PR #12039: URL: https://github.com/apache/kafka/pull/12039#issuecomment-1251902166 @kirktrue Can you fix checkStyle errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] omkreddy commented on pull request #12148: MINOR: Remove unnecessary log4j-appender dependency and tweak explicit log4j dependency

2022-09-19 Thread GitBox
omkreddy commented on PR #12148: URL: https://github.com/apache/kafka/pull/12148#issuecomment-1251901651 @ijuma sorry missed this. Can you rebase the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t