[jira] [Comment Edited] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-09-30 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611814#comment-17611814 ] Yu Wang edited comment on KAFKA-14266 at 10/1/22 3:56 AM: -- [~Ch

[jira] [Commented] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-09-30 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611814#comment-17611814 ] Yu Wang commented on KAFKA-14266: - [~ChrisEgerton] I am afraid monitoring lag now workin

[GitHub] [kafka] wcarlson5 closed pull request #11278: KAFKA-12648: Enforce size limits for each task's cache

2022-09-30 Thread GitBox
wcarlson5 closed pull request #11278: KAFKA-12648: Enforce size limits for each task's cache URL: https://github.com/apache/kafka/pull/11278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] wcarlson5 closed pull request #11862: MINOR: fix the query prefix to not have an extra hyphon

2022-09-30 Thread GitBox
wcarlson5 closed pull request #11862: MINOR: fix the query prefix to not have an extra hyphon URL: https://github.com/apache/kafka/pull/11862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] hachikuji commented on pull request #12674: KAFKA-14255: Fetching from follower should be disallowed if fetch from follower is disabled

2022-09-30 Thread GitBox
hachikuji commented on PR #12674: URL: https://github.com/apache/kafka/pull/12674#issuecomment-1264069768 @dajac Yeah, this is a tough one. I think one perspective we could take is that consumers which have not implemented the protocol should not be supported. So perhaps we should only chec

[jira] [Created] (KAFKA-14272) Consumer metrics being double emitted

2022-09-30 Thread Guilherme (Jira)
Guilherme created KAFKA-14272: - Summary: Consumer metrics being double emitted Key: KAFKA-14272 URL: https://issues.apache.org/jira/browse/KAFKA-14272 Project: Kafka Issue Type: Bug Com

[GitHub] [kafka] philipnee commented on a diff in pull request #12663: KAFKA-14247: Define event handler interface and events

2022-09-30 Thread GitBox
philipnee commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r984959163 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractPrototypeAsyncConsumer.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12663: KAFKA-14247: Define event handler interface and events

2022-09-30 Thread GitBox
hachikuji commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r984958755 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractPrototypeAsyncConsumer.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12663: KAFKA-14247: Define event handler interface and events

2022-09-30 Thread GitBox
hachikuji commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r984957644 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractPrototypeAsyncConsumer.java: ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hshi2022 commented on pull request #12634: KAFKA-14225: Fix deadlock caused by lazy val exemptSensor

2022-09-30 Thread GitBox
hshi2022 commented on PR #12634: URL: https://github.com/apache/kafka/pull/12634#issuecomment-1263980538 > @hshi2022 Yeah, we are often fighting some flaky tests. It should not block merging if they are unrelated. Can you take a look at the response above [#12634 (comment)](https://github.

[GitHub] [kafka] hshi2022 commented on pull request #12634: KAFKA-14225: Fix deadlock caused by lazy val exemptSensor

2022-09-30 Thread GitBox
hshi2022 commented on PR #12634: URL: https://github.com/apache/kafka/pull/12634#issuecomment-1263979492 > @hshi2022 Yeah, we are often fighting some flaky tests. It should not block merging if they are unrelated. Can you take a look at the response above [#12634 (comment)](https://github.

[GitHub] [kafka] hshi2022 commented on a diff in pull request #12634: KAFKA-14225: Fix deadlock caused by lazy val exemptSensor

2022-09-30 Thread GitBox
hshi2022 commented on code in PR #12634: URL: https://github.com/apache/kafka/pull/12634#discussion_r984918122 ## core/src/main/scala/kafka/server/ClientRequestQuotaManager.scala: ## @@ -30,6 +30,9 @@ import scala.jdk.CollectionConverters._ object ClientRequestQuotaManager {

[GitHub] [kafka] philipnee commented on pull request #12672: KAFKA-14252: Consumer background thread base implementation

2022-09-30 Thread GitBox
philipnee commented on PR #12672: URL: https://github.com/apache/kafka/pull/12672#issuecomment-1263913971 @mhowlett @kirktrue Mind reviewing this PR? This is actually stack on top of : https://github.com/apache/kafka/pull/12663 So some code might be outdated -- This is an automated messag

[GitHub] [kafka] hachikuji commented on pull request #12634: KAFKA-14225: Fix deadlock caused by lazy val exemptSensor

2022-09-30 Thread GitBox
hachikuji commented on PR #12634: URL: https://github.com/apache/kafka/pull/12634#issuecomment-1263855196 @hshi2022 Yeah, we are often fighting some flaky tests. It should not block merging if they are unrelated. Can you take a look at the response above https://github.com/apache/kafka/pull

[jira] [Comment Edited] (KAFKA-14271) Topic recreation fails in KRaft mode when topic contains collidable characters

2022-09-30 Thread Jeffrey Tolar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611698#comment-17611698 ] Jeffrey Tolar edited comment on KAFKA-14271 at 9/30/22 5:45 PM: --

[jira] [Commented] (KAFKA-14271) Topic recreation fails in KRaft mode when topic contains collidable characters

2022-09-30 Thread Jeffrey Tolar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611698#comment-17611698 ] Jeffrey Tolar commented on KAFKA-14271: --- It's possible this isn't specific to KRaf

[jira] [Created] (KAFKA-14271) Topic recreation fails in KRaft mode when topic contains collidable characters

2022-09-30 Thread Jeffrey Tolar (Jira)
Jeffrey Tolar created KAFKA-14271: - Summary: Topic recreation fails in KRaft mode when topic contains collidable characters Key: KAFKA-14271 URL: https://issues.apache.org/jira/browse/KAFKA-14271 Proj

[jira] [Updated] (KAFKA-14174) Operation documentation for KRaft

2022-09-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14174: --- Affects Version/s: (was: 3.3.0) > Operation documentation for KR

[jira] [Resolved] (KAFKA-14174) Operation documentation for KRaft

2022-09-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-14174. Resolution: Fixed > Operation documentation for KRaft > --

[GitHub] [kafka] dajac commented on pull request #12705: KAFKA-14269: client-side, add TopicRoundRobinAssignor as a possible partition assignment strategy

2022-09-30 Thread GitBox
dajac commented on PR #12705: URL: https://github.com/apache/kafka/pull/12705#issuecomment-1263778542 @mathieu-amblard Thanks for the explanation! That's an interesting approach. Is there a reason why you have multiple partitions per topic? That would be another way to provide the same guar

[GitHub] [kafka] vvcephei opened a new pull request, #12706: MINOR: Add TaskIdlingIntegrationTest

2022-09-30 Thread GitBox
vvcephei opened a new pull request, #12706: URL: https://github.com/apache/kafka/pull/12706 We got a mailing list report of task idling not working while reprocessing. This PR adds the exact scenario to attempt a repro. https://lists.apache.org/thread/qnow8hj7tvzfjkxr22x84cz0oby83k8o

[GitHub] [kafka] mathieu-amblard commented on pull request #12705: KAFKA-14269: client-side, add TopicRoundRobinAssignor as a possible partition assignment strategy

2022-09-30 Thread GitBox
mathieu-amblard commented on PR #12705: URL: https://github.com/apache/kafka/pull/12705#issuecomment-1263687207 @dajac Thanks for your reply and sorry if I was unclear in my description. I forgot to mention something very important in my description, I would like to be thread safe as

[GitHub] [kafka] blacktooth commented on pull request #10277: KAFKA-9914: Fix replication cycle detection

2022-09-30 Thread GitBox
blacktooth commented on PR #10277: URL: https://github.com/apache/kafka/pull/10277#issuecomment-1263643423 Is anyone still working on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #12695: KAFKA-14265: Prefix ACLs may shadow other prefix ACLs

2022-09-30 Thread GitBox
ijuma commented on PR #12695: URL: https://github.com/apache/kafka/pull/12695#issuecomment-1263617009 Looks like we didn't squash this PR before merging. Let's avoid that next time please. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] guozhangwang merged pull request #12704: Fix ByteBufferSerializer#serialize(String, ByteBuffer) not roundtrip input with ByteBufferDeserializer#deserialize(String, byte[])

2022-09-30 Thread GitBox
guozhangwang merged PR #12704: URL: https://github.com/apache/kafka/pull/12704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] guozhangwang commented on pull request #12704: Fix ByteBufferSerializer#serialize(String, ByteBuffer) not roundtrip input with ByteBufferDeserializer#deserialize(String, byte[])

2022-09-30 Thread GitBox
guozhangwang commented on PR #12704: URL: https://github.com/apache/kafka/pull/12704#issuecomment-1263596460 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Commented] (KAFKA-14266) MirrorSourceTask will stop mirroring when get corrupt record

2022-09-30 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611581#comment-17611581 ] Chris Egerton commented on KAFKA-14266: --- [~LucentWong] would monitoring the consum

[GitHub] [kafka] dajac commented on pull request #12705: KAFKA-14269: client-side, add TopicRoundRobinAssignor as a possible partition assignment strategy

2022-09-30 Thread GitBox
dajac commented on PR #12705: URL: https://github.com/apache/kafka/pull/12705#issuecomment-1263546176 @mathieu-amblard Thanks for the PR. Could you elaborate a bit more on the motivation for this new assignor? I am not sure that I get it at the moment. What are the benefits of doing this?

[GitHub] [kafka] mathieu-amblard opened a new pull request, #12705: KAFKA-14269: client-side, add TopicRoundRobinAssignor as a possible partition assignment strategy

2022-09-30 Thread GitBox
mathieu-amblard opened a new pull request, #12705: URL: https://github.com/apache/kafka/pull/12705 Add a new partition assignment strategy that assigns all partitions of a topic to exactly one consumer. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] cadonna commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

2022-09-30 Thread GitBox
cadonna commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r984479081 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1096,7 +1096,7 @@ private Optional removeStreamThread(final long timeoutMs) throws Timeout

[jira] [Updated] (KAFKA-14269) Partition Assignment Strategy - Topic Round Robin Assignor

2022-09-30 Thread Mathieu Amblard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Amblard updated KAFKA-14269: Component/s: clients > Partition Assignment Strategy - Topic Round Robin Assignor > --

[jira] [Updated] (KAFKA-14269) Partition Assignment Strategy - Topic Round Robin Assignor

2022-09-30 Thread Mathieu Amblard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Amblard updated KAFKA-14269: Description: *The context :* I have : * only one type of message per topic * the same n

[GitHub] [kafka] cadonna commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

2022-09-30 Thread GitBox
cadonna commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r984448633 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -1146,6 +1146,10 @@ private long advanceNowAndComputeLatency() { publ

[GitHub] [kafka] cadonna commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

2022-09-30 Thread GitBox
cadonna commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r984445451 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -1146,6 +1146,10 @@ private long advanceNowAndComputeLatency() { publ

[jira] [Created] (KAFKA-14270) Kafka Streams logs exception on startup

2022-09-30 Thread Oliver Eikemeier (Jira)
Oliver Eikemeier created KAFKA-14270: Summary: Kafka Streams logs exception on startup Key: KAFKA-14270 URL: https://issues.apache.org/jira/browse/KAFKA-14270 Project: Kafka Issue Type: B

[GitHub] [kafka] cadonna merged pull request #12527: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-30 Thread GitBox
cadonna merged PR #12527: URL: https://github.com/apache/kafka/pull/12527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] LinShunKang commented on pull request #12704: Fix ByteBufferSerializer#serialize(String, ByteBuffer) not roundtrip input with ByteBufferDeserializer#deserialize(String, byte[])

2022-09-30 Thread GitBox
LinShunKang commented on PR #12704: URL: https://github.com/apache/kafka/pull/12704#issuecomment-1263307752 @guozhangwang PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] LinShunKang opened a new pull request, #12704: Fix ByteBufferSerializer#serialize(String, ByteBuffer) not roundtrip input with ByteBufferDeserializer#deserialize(String, byte[])

2022-09-30 Thread GitBox
LinShunKang opened a new pull request, #12704: URL: https://github.com/apache/kafka/pull/12704 Fix not roundtrip input issue introduced in https://github.com/apache/kafka/pull/12683. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation -

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984369714 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -360,14 +333,8 @@ public void shouldRecycleStoreAndReregis

[GitHub] [kafka] mdedetrich commented on pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
mdedetrich commented on PR #12524: URL: https://github.com/apache/kafka/pull/12524#issuecomment-1263294566 @cadonna > https://github.com/apache/kafka/pull/12524/files#r984332259 This one is resolved now, I think I somehow missed that, apologies > https://github.com/apach

[jira] [Updated] (KAFKA-14269) Partition Assignment Strategy - Topic Round Robin Assignor

2022-09-30 Thread Mathieu Amblard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Amblard updated KAFKA-14269: Description: *The context :* I have only one type of message per topic, multiple consumer

[GitHub] [kafka] LinShunKang commented on pull request #12683: KAFKA-4852: Fix ByteBufferSerializer#serialize(String, ByteBuffer) not compatible with offsets

2022-09-30 Thread GitBox
LinShunKang commented on PR #12683: URL: https://github.com/apache/kafka/pull/12683#issuecomment-1263296958 > > I re-run the test case in trunk as well as in your branch locally with IDE, and both passes, so I think it's due to jenkins machines compute resource limit itself. > > But I go

[jira] [Updated] (KAFKA-14269) Partition Assignment Strategy - Topic Round Robin Assignor

2022-09-30 Thread Mathieu Amblard (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Amblard updated KAFKA-14269: Description: *The context :* I have only one type of message per topic, multiple consumer

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984359623 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984357130 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984354770 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] cadonna commented on pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
cadonna commented on PR #12524: URL: https://github.com/apache/kafka/pull/12524#issuecomment-1263273352 @mdedetrich I answered your question about `InOrder`. Sorry, I somehow missed that. Note that I unresolved other two comments: https://github.com/apache/kafka/pull/12524/files#r

[GitHub] [kafka] cadonna commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
cadonna commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984341403 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty() {

[jira] [Created] (KAFKA-14269) Partition Assignment Strategy - Topic Round Robin Assignor

2022-09-30 Thread Mathieu Amblard (Jira)
Mathieu Amblard created KAFKA-14269: --- Summary: Partition Assignment Strategy - Topic Round Robin Assignor Key: KAFKA-14269 URL: https://issues.apache.org/jira/browse/KAFKA-14269 Project: Kafka

[GitHub] [kafka] cadonna commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
cadonna commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984332259 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty() {

[GitHub] [kafka] cadonna commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
cadonna commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984332539 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty() {

[GitHub] [kafka] mdedetrich commented on pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
mdedetrich commented on PR #12524: URL: https://github.com/apache/kafka/pull/12524#issuecomment-1263241592 @cadonna Apologies, I must have missed the replies to the comments, will look at them today. Note that https://github.com/apache/kafka/pull/12524#discussion_r975464527 is still waitin

[GitHub] [kafka] cadonna commented on pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

2022-09-30 Thread GitBox
cadonna commented on PR #12524: URL: https://github.com/apache/kafka/pull/12524#issuecomment-1263238623 @mdedetrich Some of our discussions on this PR are still unresolved. Did you forget to push some commits? -- This is an automated message from the Apache Git Service. To respond to th