[GitHub] [kafka] showuon commented on a diff in pull request #12736: KAFKA-14292 controlledShutDownOffset should only be updated if set to -1

2022-10-13 Thread GitBox
showuon commented on code in PR #12736: URL: https://github.com/apache/kafka/pull/12736#discussion_r994226194 ## metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java: ## @@ -400,12 +412,13 @@ long lowestActiveOffset() { } /** - * Mark a

[jira] [Created] (KAFKA-14296) Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread David Jacot (Jira)
David Jacot created KAFKA-14296: --- Summary: Partition leaders are not demoted during kraft controlled shutdown Key: KAFKA-14296 URL: https://issues.apache.org/jira/browse/KAFKA-14296 Project: Kafka

[GitHub] [kafka] calmera opened a new pull request, #12740: Update of the PAPI testing classes to the latest implementation

2022-10-13 Thread GitBox
calmera opened a new pull request, #12740: URL: https://github.com/apache/kafka/pull/12740 The papi tests were still using the old PAPI classes. This makes it cumbersome to write tests for new PAPI functionality. @mjsax This is the split out of the functionality which was proposed by

[GitHub] [kafka] dajac opened a new pull request, #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
dajac opened a new pull request, #12741: URL: https://github.com/apache/kafka/pull/12741 When the `BrokerServer` starts its shutting down process, it transitions to `SHUTTING_DOWN` and sets `isShuttingDown` to `true`. With this state change, the follower state changes are short-cutted. This

[jira] [Updated] (KAFKA-14296) Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14296: Description: When the BrokerServer starts its shutting down process, it transitions to SHUTTING_DO

[jira] [Created] (KAFKA-14297) Automated protocol should support namespace

2022-10-13 Thread David Jacot (Jira)
David Jacot created KAFKA-14297: --- Summary: Automated protocol should support namespace Key: KAFKA-14297 URL: https://issues.apache.org/jira/browse/KAFKA-14297 Project: Kafka Issue Type: Sub-tas

[GitHub] [kafka] calmera opened a new pull request, #12742: KAFKA-10892: Shared Readonly State Stores ( revisited )

2022-10-13 Thread GitBox
calmera opened a new pull request, #12742: URL: https://github.com/apache/kafka/pull/12742 This PR implements KIP-813: support for shareable state stores. Tests were created to validate the structure of the resulting topology. Certain parts (MockProcessor eg.) have been migrated

[GitHub] [kafka] calmera commented on pull request #12188: KAFKA-10892: Shared Readonly State Stores

2022-10-13 Thread GitBox
calmera commented on PR #12188: URL: https://github.com/apache/kafka/pull/12188#issuecomment-1277295678 Split this PR into two new ones: - #12740 updating the PAPI test classes to the latest version - #12742 handling the Topology changes and read-only statestore introduction -- T

[GitHub] [kafka] calmera closed pull request #12188: KAFKA-10892: Shared Readonly State Stores

2022-10-13 Thread GitBox
calmera closed pull request #12188: KAFKA-10892: Shared Readonly State Stores URL: https://github.com/apache/kafka/pull/12188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (KAFKA-14294) Kafka Streams should commit transaction when no records are processed

2022-10-13 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-14294: -- Affects Version/s: 3.2.1 > Kafka Streams should commit transaction when no records are process

[jira] [Created] (KAFKA-14298) Getting null pointer exception

2022-10-13 Thread Ramakrishna (Jira)
Ramakrishna created KAFKA-14298: --- Summary: Getting null pointer exception Key: KAFKA-14298 URL: https://issues.apache.org/jira/browse/KAFKA-14298 Project: Kafka Issue Type: Bug Compon

[GitHub] [kafka] shekhar-rajak commented on a diff in pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-13 Thread GitBox
shekhar-rajak commented on code in PR #12739: URL: https://github.com/apache/kafka/pull/12739#discussion_r994446379 ## streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingPersistentWindowStoreTest.java: ## @@ -124,7 +129,8 @@ public static Collection

[GitHub] [kafka] tombentley commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-13 Thread GitBox
tombentley commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r994456452 ## clients/src/test/java/org/apache/kafka/clients/admin/FakeForwardingAdmin.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] shekhar-rajak commented on a diff in pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-13 Thread GitBox
shekhar-rajak commented on code in PR #12739: URL: https://github.com/apache/kafka/pull/12739#discussion_r994465503 ## streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingPersistentWindowStoreTest.java: ## @@ -138,51 +144,69 @@ public void setUp() {

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-13 Thread GitBox
mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r994551128 ## clients/src/main/java/org/apache/kafka/clients/admin/ForwardingAdmin.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-14281) Multi-level rack awareness

2022-10-13 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617017#comment-17617017 ] Viktor Somogyi-Vass commented on KAFKA-14281: - Thanks [~ottomata] for the li

[jira] [Created] (KAFKA-14299) Benchmark and stabilize state updater

2022-10-13 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-14299: -- Summary: Benchmark and stabilize state updater Key: KAFKA-14299 URL: https://issues.apache.org/jira/browse/KAFKA-14299 Project: Kafka Issue Type: Task

[GitHub] [kafka] lucasbru opened a new pull request, #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-13 Thread GitBox
lucasbru opened a new pull request, #12743: URL: https://github.com/apache/kafka/pull/12743 The original code path paused the main consumer for all tasks before entering the restoration section of the code, and then resumed all after restoration has finished. In the new state updat

[GitHub] [kafka] lucasbru commented on pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-13 Thread GitBox
lucasbru commented on PR #12743: URL: https://github.com/apache/kafka/pull/12743#issuecomment-1277573540 @guozhangwang @cadonna Could you have a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-10-13 Thread GitBox
vamossagar12 commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1277594018 > Hey @vamossagar12 , sorry for the seriously long silence on this -- it was important and I shouldn't have let it slip. Anyways I know you pointed me to a specific question about ch

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2022-10-13 Thread GitBox
vamossagar12 commented on PR #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-1277595143 Thanks @showuon ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] ijuma commented on a diff in pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
ijuma commented on code in PR #12741: URL: https://github.com/apache/kafka/pull/12741#discussion_r994646630 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2142,7 +2142,6 @@ class ReplicaManager(val config: KafkaConfig, ): Unit = { stateChangeLogger.info

[GitHub] [kafka] ijuma commented on a diff in pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
ijuma commented on code in PR #12741: URL: https://github.com/apache/kafka/pull/12741#discussion_r994648305 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2151,28 +2150,24 @@ class ReplicaManager(val config: KafkaConfig, try { followerTopicS

[GitHub] [kafka] ijuma commented on a diff in pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
ijuma commented on code in PR #12741: URL: https://github.com/apache/kafka/pull/12741#discussion_r994648305 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2151,28 +2150,24 @@ class ReplicaManager(val config: KafkaConfig, try { followerTopicS

[GitHub] [kafka] dajac commented on a diff in pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
dajac commented on code in PR #12741: URL: https://github.com/apache/kafka/pull/12741#discussion_r994688472 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2142,7 +2142,6 @@ class ReplicaManager(val config: KafkaConfig, ): Unit = { stateChangeLogger.info

[GitHub] [kafka] dajac commented on a diff in pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
dajac commented on code in PR #12741: URL: https://github.com/apache/kafka/pull/12741#discussion_r994698379 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2151,28 +2150,24 @@ class ReplicaManager(val config: KafkaConfig, try { followerTopicS

[GitHub] [kafka] C0urante commented on pull request #10528: KAFKA-12497: Skip periodic offset commits for failed source tasks

2022-10-13 Thread GitBox
C0urante commented on PR #10528: URL: https://github.com/apache/kafka/pull/10528#issuecomment-1277683731 Test failures are unrelated; going to merge this as-is. @vvcephei @tombentley Please let me know if you'd like to follow up on this at any point. -- This is an automated message from t

[GitHub] [kafka] C0urante merged pull request #10528: KAFKA-12497: Skip periodic offset commits for failed source tasks

2022-10-13 Thread GitBox
C0urante merged PR #10528: URL: https://github.com/apache/kafka/pull/10528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-13 Thread GitBox
OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r994785155 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java: ## @@ -92,6 +94,9 @@ public class MirrorConnectorConfig extends AbstractConfi

[GitHub] [kafka] guozhangwang opened a new pull request, #12744: Kafka Streams Threading P2: Skeleton TaskExecutor Impl

2022-10-13 Thread GitBox
guozhangwang opened a new pull request, #12744: URL: https://github.com/apache/kafka/pull/12744 0. Address comments from P1. 1. Add the DefaultTaskExecutor implementation class. 2. Related DefaultTaskExecutorTest. Pending in future PRs: a) exception handling, primarily to send th

[GitHub] [kafka] cadonna commented on a diff in pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-13 Thread GitBox
cadonna commented on code in PR #12743: URL: https://github.com/apache/kafka/pull/12743#discussion_r994752848 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1481,6 +1481,36 @@ public void shouldTryToLockValidTaskDirsAtRebalanc

[GitHub] [kafka] cadonna commented on pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-13 Thread GitBox
cadonna commented on PR #12743: URL: https://github.com/apache/kafka/pull/12743#issuecomment-1277831255 There are a lot of failures in the builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] philipnee commented on pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-13 Thread GitBox
philipnee commented on PR #12672: URL: https://github.com/apache/kafka/pull/12672#issuecomment-1277871998 cc John - @vvcephei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12736: KAFKA-14292 controlledShutDownOffset should only be updated if set to -1

2022-10-13 Thread GitBox
ahuang98 commented on code in PR #12736: URL: https://github.com/apache/kafka/pull/12736#discussion_r994871531 ## metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java: ## @@ -400,12 +412,13 @@ long lowestActiveOffset() { } /** - * Mark a

[GitHub] [kafka] hachikuji commented on a diff in pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
hachikuji commented on code in PR #12741: URL: https://github.com/apache/kafka/pull/12741#discussion_r994891612 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2210,7 +2210,8 @@ class ReplicaManagerTest { aliveBrokerIds: Seq[Int] = Seq(0, 1),

[GitHub] [kafka] jsancio merged pull request #12715: MINOR: Refactor KRaft image generation

2022-10-13 Thread GitBox
jsancio merged PR #12715: URL: https://github.com/apache/kafka/pull/12715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna opened a new pull request, #12745: HOTFIX: Revert "KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…"

2022-10-13 Thread GitBox
cadonna opened a new pull request, #12745: URL: https://github.com/apache/kafka/pull/12745 This reverts commit 07c10024890c0761ba47ccd4d6301e8101d8c8de which broke trunk. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify

[GitHub] [kafka] philipnee opened a new pull request, #12746: Consumer refactor async fetcher

2022-10-13 Thread GitBox
philipnee opened a new pull request, #12746: URL: https://github.com/apache/kafka/pull/12746 [KAFKA-14274](https://issues.apache.org/jira/browse/KAFKA-14274) We need to break the existing fetcher into three separated classes due to the async nature of the new implementation. Here we h

[GitHub] [kafka] cadonna commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

2022-10-13 Thread GitBox
cadonna commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r994922754 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1096,7 +1096,7 @@ private Optional removeStreamThread(final long timeoutMs) throws Timeout

[GitHub] [kafka] cadonna commented on pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-13 Thread GitBox
cadonna commented on PR #12743: URL: https://github.com/apache/kafka/pull/12743#issuecomment-1277943787 Nevermind about the failures. Trunk is currently broken: https://github.com/apache/kafka/pull/12745 -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] jolshan commented on pull request #12543: KAFKA-10149: Allow auto preferred leader election when there are ongoing partition reassignments

2022-10-13 Thread GitBox
jolshan commented on PR #12543: URL: https://github.com/apache/kafka/pull/12543#issuecomment-1277960339 > I believe it's valid to perform preferred leader election for topics even if they're currently undergoing reassignment Got it. I think the PR description here confused me then.

[GitHub] [kafka] dajac commented on pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
dajac commented on PR #12741: URL: https://github.com/apache/kafka/pull/12741#issuecomment-1277982773 Will merge it tomorrow to trunk and 3.3. I am waiting on getting a clean build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] C0urante commented on pull request #5876: KAFKA-7509: Avoid passing most non-applicable properties to producer, consumer, and admin client

2022-10-13 Thread GitBox
C0urante commented on PR #5876: URL: https://github.com/apache/kafka/pull/5876#issuecomment-1277990983 @szalapski Would you be willing to do a round of review on https://github.com/apache/kafka/pull/11986? It's grown out of date and I have to do a rebase on it, but the high-level idea shoul

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-10-13 Thread GitBox
vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r994977689 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: ## @@ -517,13 +517,13 @@ public void testTaskAs

[GitHub] [kafka] C0urante commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-10-13 Thread GitBox
C0urante commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r994980800 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: ## @@ -517,13 +517,13 @@ public void testTaskAssign

[GitHub] [kafka] niket-goel commented on a diff in pull request #12738: minor: Trying to fix some flakiness in KRaftClusterTest::testDescribeQuorumRequestToBrokers()

2022-10-13 Thread GitBox
niket-goel commented on code in PR #12738: URL: https://github.com/apache/kafka/pull/12738#discussion_r995000296 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -811,20 +811,29 @@ class KRaftClusterTest { assertTrue(cluster.controllers.asS

[GitHub] [kafka] niket-goel commented on a diff in pull request #12738: minor: Trying to fix some flakiness in KRaftClusterTest::testDescribeQuorumRequestToBrokers()

2022-10-13 Thread GitBox
niket-goel commented on code in PR #12738: URL: https://github.com/apache/kafka/pull/12738#discussion_r995002692 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -811,20 +811,29 @@ class KRaftClusterTest { assertTrue(cluster.controllers.asS

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

2022-10-13 Thread GitBox
wcarlson5 commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r995013622 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1096,7 +1096,7 @@ private Optional removeStreamThread(final long timeoutMs) throws Timeout

[jira] [Created] (KAFKA-14300) KRaft controller snapshot not trigger after resign

2022-10-13 Thread Jira
José Armando García Sancio created KAFKA-14300: -- Summary: KRaft controller snapshot not trigger after resign Key: KAFKA-14300 URL: https://issues.apache.org/jira/browse/KAFKA-14300 Project

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-13 Thread GitBox
guozhangwang commented on code in PR #12743: URL: https://github.com/apache/kafka/pull/12743#discussion_r995080928 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -177,6 +177,14 @@ void handleRebalanceComplete() { // before

[GitHub] [kafka] hachikuji merged pull request #12745: HOTFIX: Revert "KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…"

2022-10-13 Thread GitBox
hachikuji merged PR #12745: URL: https://github.com/apache/kafka/pull/12745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] hachikuji commented on pull request #12736: KAFKA-14292 controlledShutDownOffset should only be updated if set to -1

2022-10-13 Thread GitBox
hachikuji commented on PR #12736: URL: https://github.com/apache/kafka/pull/12736#issuecomment-127810 Test failures look like they are due to https://github.com/apache/kafka/pull/12745. I will go ahead and merge to trunk and 3.3. -- This is an automated message from the Apache Git Se

[GitHub] [kafka] hachikuji merged pull request #12736: KAFKA-14292 controlledShutDownOffset should only be updated if set to -1

2022-10-13 Thread GitBox
hachikuji merged PR #12736: URL: https://github.com/apache/kafka/pull/12736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] hachikuji closed pull request #12733: KAFKA-14275; KRaft Controllers should crash after failing to apply any metadata record (#12709)

2022-10-13 Thread GitBox
hachikuji closed pull request #12733: KAFKA-14275; KRaft Controllers should crash after failing to apply any metadata record (#12709) URL: https://github.com/apache/kafka/pull/12733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (KAFKA-14292) KRaft broker controlled shutdown can be delayed indefinitely

2022-10-13 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-14292. - Fix Version/s: 3.4.0 3.3.2 Resolution: Fixed > KRaft broker co

[GitHub] [kafka] szalapski commented on pull request #5876: KAFKA-7509: Avoid passing most non-applicable properties to producer, consumer, and admin client

2022-10-13 Thread GitBox
szalapski commented on PR #5876: URL: https://github.com/apache/kafka/pull/5876#issuecomment-1278150689 The changes seem good to me, however I am not familiar with this repo. May @vashu1 or @rhauch can help or suggest who can? Also it looks like the failing checks need to be addressed

[GitHub] [kafka] hachikuji commented on pull request #12733: KAFKA-14275; KRaft Controllers should crash after failing to apply any metadata record (#12709)

2022-10-13 Thread GitBox
hachikuji commented on PR #12733: URL: https://github.com/apache/kafka/pull/12733#issuecomment-1278150243 Closing since it looks like @cmccabe already picked this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] szalapski commented on a diff in pull request #11986: KAFKA-7509: Clean up incorrect warnings logged by Connect

2022-10-13 Thread GitBox
szalapski commented on code in PR #11986: URL: https://github.com/apache/kafka/pull/11986#discussion_r995105062 ## clients/src/main/java/org/apache/kafka/common/config/internals/RecordingMap.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] hachikuji commented on a diff in pull request #12734: KAFKA-14255; Return an empty record instead of an OffsetOutOfRangeException when fetching from a follower without a leader epoch

2022-10-13 Thread GitBox
hachikuji commented on code in PR #12734: URL: https://github.com/apache/kafka/pull/12734#discussion_r995118293 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1339,6 +1341,26 @@ class Partition(val topicPartition: TopicPartition, } } +// Fetching

[jira] [Assigned] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2022-10-13 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reassigned KAFKA-10228: -- Assignee: Philip Nee > producer: NETWORK_EXCEPTION is thrown instead of a request timeout > -

[jira] [Commented] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2022-10-13 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617326#comment-17617326 ] Philip Nee commented on KAFKA-10228: I think the current logging level has already b

[jira] [Created] (KAFKA-14301) Simulation validation that raft listener see NO_LEADER on leader

2022-10-13 Thread Jira
José Armando García Sancio created KAFKA-14301: -- Summary: Simulation validation that raft listener see NO_LEADER on leader Key: KAFKA-14301 URL: https://issues.apache.org/jira/browse/KAFKA-14301

[GitHub] [kafka] jsancio opened a new pull request, #12747: KAFKA-14300; Generate snapshot after repeated controller resign

2022-10-13 Thread GitBox
jsancio opened a new pull request, #12747: URL: https://github.com/apache/kafka/pull/12747 Setting the `committedBytesSinceLastSnapshot` to 0 when resigning can cause the controller to not generate a snapshot after `snapshotMaxNewRecordBytes` committed bytes have been replayed. This

[GitHub] [kafka] jsancio commented on a diff in pull request #12747: KAFKA-14300; Generate snapshot after repeated controller resign

2022-10-13 Thread GitBox
jsancio commented on code in PR #12747: URL: https://github.com/apache/kafka/pull/12747#discussion_r995216141 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -821,6 +821,73 @@ public void testSnapshotOnlyAfterConfiguredMinBytes() throws Th

[GitHub] [kafka] hachikuji merged pull request #12741: KAFKA-14296; Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread GitBox
hachikuji merged PR #12741: URL: https://github.com/apache/kafka/pull/12741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Resolved] (KAFKA-14296) Partition leaders are not demoted during kraft controlled shutdown

2022-10-13 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-14296. - Fix Version/s: 3.4.0 3.3.2 Resolution: Fixed > Partition leade

[jira] [Updated] (KAFKA-14286) Time based cluster metadata snapshots

2022-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14286: --- Fix Version/s: 3.4.0 > Time based cluster metadata snapshots > -

[jira] [Updated] (KAFKA-14301) Simulation validation that raft listener see NO_LEADER on leader

2022-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14301: --- Fix Version/s: 3.4.0 3.3.2 > Simulation validatio

[jira] [Updated] (KAFKA-14286) Time based cluster metadata snapshots

2022-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14286: --- Fix Version/s: (was: 3.4.0) > Time based cluster metadata snapsh

[jira] [Updated] (KAFKA-14301) Simulation validation that raft listener see NO_LEADER on leader

2022-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14301: --- Fix Version/s: (was: 3.4.0) (was: 3.3.2)

[jira] [Updated] (KAFKA-14300) KRaft controller snapshot not trigger after resign

2022-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14300: --- Fix Version/s: 3.4.0 3.3.2 > KRaft controller sna

[GitHub] [kafka] showuon commented on pull request #12745: HOTFIX: Revert "KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…"

2022-10-13 Thread GitBox
showuon commented on PR #12745: URL: https://github.com/apache/kafka/pull/12745#issuecomment-1278331438 @cadonna , thanks for help revert the change. Although the jenkins tests passed in the [PR](https://github.com/apache/kafka/pull/11211), it could be because the code base is not synced up

[GitHub] [kafka] jsancio merged pull request #12688: MINOR: Delete config/kraft/README.md

2022-10-13 Thread GitBox
jsancio merged PR #12688: URL: https://github.com/apache/kafka/pull/12688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] songnon commented on pull request #12543: KAFKA-10149: Allow auto preferred leader election when there are ongoing partition reassignments

2022-10-13 Thread GitBox
songnon commented on PR #12543: URL: https://github.com/apache/kafka/pull/12543#issuecomment-1278458717 > Perhaps we can update this to make it clearer that we can also do the preferred leadership election on partitions undergoing reassignment to update the preferred leader sooner. F

[GitHub] [kafka] songnon commented on pull request #12543: KAFKA-10149: Allow auto preferred leader election when there are ongoing partition reassignments

2022-10-13 Thread GitBox
songnon commented on PR #12543: URL: https://github.com/apache/kafka/pull/12543#issuecomment-1278487313 > I'm also a little confused by shutting down the broker that is not part of the assignment in the beginning. Some comments there could really help me understand the scenario better.

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-13 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278517048 I am not sure why one test case failed : https://github.com/apache/kafka/pull/12739/checks?check_run_id=8869541214 . I have not done any change in any other test file. -- This is