showuon commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r994226194
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -400,12 +412,13 @@ long lowestActiveOffset() {
}
/**
- * Mark a
David Jacot created KAFKA-14296:
---
Summary: Partition leaders are not demoted during kraft controlled
shutdown
Key: KAFKA-14296
URL: https://issues.apache.org/jira/browse/KAFKA-14296
Project: Kafka
calmera opened a new pull request, #12740:
URL: https://github.com/apache/kafka/pull/12740
The papi tests were still using the old PAPI classes. This makes it
cumbersome to write tests for new PAPI functionality.
@mjsax This is the split out of the functionality which was proposed by
dajac opened a new pull request, #12741:
URL: https://github.com/apache/kafka/pull/12741
When the `BrokerServer` starts its shutting down process, it transitions to
`SHUTTING_DOWN` and sets `isShuttingDown` to `true`. With this state change,
the follower state changes are short-cutted. This
[
https://issues.apache.org/jira/browse/KAFKA-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14296:
Description: When the BrokerServer starts its shutting down process, it
transitions to SHUTTING_DO
David Jacot created KAFKA-14297:
---
Summary: Automated protocol should support namespace
Key: KAFKA-14297
URL: https://issues.apache.org/jira/browse/KAFKA-14297
Project: Kafka
Issue Type: Sub-tas
calmera opened a new pull request, #12742:
URL: https://github.com/apache/kafka/pull/12742
This PR implements KIP-813: support for shareable state stores.
Tests were created to validate the structure of the resulting topology.
Certain parts (MockProcessor eg.) have been migrated
calmera commented on PR #12188:
URL: https://github.com/apache/kafka/pull/12188#issuecomment-1277295678
Split this PR into two new ones:
- #12740 updating the PAPI test classes to the latest version
- #12742 handling the Topology changes and read-only statestore introduction
--
T
calmera closed pull request #12188: KAFKA-10892: Shared Readonly State Stores
URL: https://github.com/apache/kafka/pull/12188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-14294:
--
Affects Version/s: 3.2.1
> Kafka Streams should commit transaction when no records are process
Ramakrishna created KAFKA-14298:
---
Summary: Getting null pointer exception
Key: KAFKA-14298
URL: https://issues.apache.org/jira/browse/KAFKA-14298
Project: Kafka
Issue Type: Bug
Compon
shekhar-rajak commented on code in PR #12739:
URL: https://github.com/apache/kafka/pull/12739#discussion_r994446379
##
streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingPersistentWindowStoreTest.java:
##
@@ -124,7 +129,8 @@ public static Collection
tombentley commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r994456452
##
clients/src/test/java/org/apache/kafka/clients/admin/FakeForwardingAdmin.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
shekhar-rajak commented on code in PR #12739:
URL: https://github.com/apache/kafka/pull/12739#discussion_r994465503
##
streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingPersistentWindowStoreTest.java:
##
@@ -138,51 +144,69 @@ public void setUp() {
mimaison commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r994551128
##
clients/src/main/java/org/apache/kafka/clients/admin/ForwardingAdmin.java:
##
@@ -0,0 +1,284 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-14281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617017#comment-17617017
]
Viktor Somogyi-Vass commented on KAFKA-14281:
-
Thanks [~ottomata] for the li
Lucas Brutschy created KAFKA-14299:
--
Summary: Benchmark and stabilize state updater
Key: KAFKA-14299
URL: https://issues.apache.org/jira/browse/KAFKA-14299
Project: Kafka
Issue Type: Task
lucasbru opened a new pull request, #12743:
URL: https://github.com/apache/kafka/pull/12743
The original code path paused the main consumer for all tasks before
entering the restoration section
of the code, and then resumed all after restoration has finished.
In the new state updat
lucasbru commented on PR #12743:
URL: https://github.com/apache/kafka/pull/12743#issuecomment-1277573540
@guozhangwang @cadonna Could you have a look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
vamossagar12 commented on PR #11433:
URL: https://github.com/apache/kafka/pull/11433#issuecomment-1277594018
> Hey @vamossagar12 , sorry for the seriously long silence on this -- it was
important and I shouldn't have let it slip. Anyways I know you pointed me to a
specific question about ch
vamossagar12 commented on PR #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1277595143
Thanks @showuon !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
ijuma commented on code in PR #12741:
URL: https://github.com/apache/kafka/pull/12741#discussion_r994646630
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2142,7 +2142,6 @@ class ReplicaManager(val config: KafkaConfig,
): Unit = {
stateChangeLogger.info
ijuma commented on code in PR #12741:
URL: https://github.com/apache/kafka/pull/12741#discussion_r994648305
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2151,28 +2150,24 @@ class ReplicaManager(val config: KafkaConfig,
try {
followerTopicS
ijuma commented on code in PR #12741:
URL: https://github.com/apache/kafka/pull/12741#discussion_r994648305
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2151,28 +2150,24 @@ class ReplicaManager(val config: KafkaConfig,
try {
followerTopicS
dajac commented on code in PR #12741:
URL: https://github.com/apache/kafka/pull/12741#discussion_r994688472
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2142,7 +2142,6 @@ class ReplicaManager(val config: KafkaConfig,
): Unit = {
stateChangeLogger.info
dajac commented on code in PR #12741:
URL: https://github.com/apache/kafka/pull/12741#discussion_r994698379
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2151,28 +2150,24 @@ class ReplicaManager(val config: KafkaConfig,
try {
followerTopicS
C0urante commented on PR #10528:
URL: https://github.com/apache/kafka/pull/10528#issuecomment-1277683731
Test failures are unrelated; going to merge this as-is. @vvcephei
@tombentley Please let me know if you'd like to follow up on this at any point.
--
This is an automated message from t
C0urante merged PR #10528:
URL: https://github.com/apache/kafka/pull/10528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r994785155
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##
@@ -92,6 +94,9 @@ public class MirrorConnectorConfig extends AbstractConfi
guozhangwang opened a new pull request, #12744:
URL: https://github.com/apache/kafka/pull/12744
0. Address comments from P1.
1. Add the DefaultTaskExecutor implementation class.
2. Related DefaultTaskExecutorTest.
Pending in future PRs: a) exception handling, primarily to send th
cadonna commented on code in PR #12743:
URL: https://github.com/apache/kafka/pull/12743#discussion_r994752848
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1481,6 +1481,36 @@ public void
shouldTryToLockValidTaskDirsAtRebalanc
cadonna commented on PR #12743:
URL: https://github.com/apache/kafka/pull/12743#issuecomment-1277831255
There are a lot of failures in the builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
philipnee commented on PR #12672:
URL: https://github.com/apache/kafka/pull/12672#issuecomment-1277871998
cc John - @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
ahuang98 commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r994871531
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -400,12 +412,13 @@ long lowestActiveOffset() {
}
/**
- * Mark a
hachikuji commented on code in PR #12741:
URL: https://github.com/apache/kafka/pull/12741#discussion_r994891612
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -2210,7 +2210,8 @@ class ReplicaManagerTest {
aliveBrokerIds: Seq[Int] = Seq(0, 1),
jsancio merged PR #12715:
URL: https://github.com/apache/kafka/pull/12715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna opened a new pull request, #12745:
URL: https://github.com/apache/kafka/pull/12745
This reverts commit 07c10024890c0761ba47ccd4d6301e8101d8c8de which broke
trunk.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
philipnee opened a new pull request, #12746:
URL: https://github.com/apache/kafka/pull/12746
[KAFKA-14274](https://issues.apache.org/jira/browse/KAFKA-14274)
We need to break the existing fetcher into three separated classes due to
the async nature of the new implementation. Here we h
cadonna commented on code in PR #12465:
URL: https://github.com/apache/kafka/pull/12465#discussion_r994922754
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1096,7 +1096,7 @@ private Optional removeStreamThread(final long
timeoutMs) throws Timeout
cadonna commented on PR #12743:
URL: https://github.com/apache/kafka/pull/12743#issuecomment-1277943787
Nevermind about the failures. Trunk is currently broken:
https://github.com/apache/kafka/pull/12745
--
This is an automated message from the Apache Git Service.
To respond to the messag
jolshan commented on PR #12543:
URL: https://github.com/apache/kafka/pull/12543#issuecomment-1277960339
> I believe it's valid to perform preferred leader election for topics even
if they're currently undergoing reassignment
Got it. I think the PR description here confused me then.
dajac commented on PR #12741:
URL: https://github.com/apache/kafka/pull/12741#issuecomment-1277982773
Will merge it tomorrow to trunk and 3.3. I am waiting on getting a clean
build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
C0urante commented on PR #5876:
URL: https://github.com/apache/kafka/pull/5876#issuecomment-1277990983
@szalapski Would you be willing to do a round of review on
https://github.com/apache/kafka/pull/11986? It's grown out of date and I have
to do a rebase on it, but the high-level idea shoul
vamossagar12 commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r994977689
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java:
##
@@ -517,13 +517,13 @@ public void testTaskAs
C0urante commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r994980800
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java:
##
@@ -517,13 +517,13 @@ public void testTaskAssign
niket-goel commented on code in PR #12738:
URL: https://github.com/apache/kafka/pull/12738#discussion_r995000296
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -811,20 +811,29 @@ class KRaftClusterTest {
assertTrue(cluster.controllers.asS
niket-goel commented on code in PR #12738:
URL: https://github.com/apache/kafka/pull/12738#discussion_r995002692
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -811,20 +811,29 @@ class KRaftClusterTest {
assertTrue(cluster.controllers.asS
wcarlson5 commented on code in PR #12465:
URL: https://github.com/apache/kafka/pull/12465#discussion_r995013622
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1096,7 +1096,7 @@ private Optional removeStreamThread(final long
timeoutMs) throws Timeout
José Armando García Sancio created KAFKA-14300:
--
Summary: KRaft controller snapshot not trigger after resign
Key: KAFKA-14300
URL: https://issues.apache.org/jira/browse/KAFKA-14300
Project
guozhangwang commented on code in PR #12743:
URL: https://github.com/apache/kafka/pull/12743#discussion_r995080928
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -177,6 +177,14 @@ void handleRebalanceComplete() {
// before
hachikuji merged PR #12745:
URL: https://github.com/apache/kafka/pull/12745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
hachikuji commented on PR #12736:
URL: https://github.com/apache/kafka/pull/12736#issuecomment-127810
Test failures look like they are due to
https://github.com/apache/kafka/pull/12745. I will go ahead and merge to trunk
and 3.3.
--
This is an automated message from the Apache Git Se
hachikuji merged PR #12736:
URL: https://github.com/apache/kafka/pull/12736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
hachikuji closed pull request #12733: KAFKA-14275; KRaft Controllers should
crash after failing to apply any metadata record (#12709)
URL: https://github.com/apache/kafka/pull/12733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-14292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-14292.
-
Fix Version/s: 3.4.0
3.3.2
Resolution: Fixed
> KRaft broker co
szalapski commented on PR #5876:
URL: https://github.com/apache/kafka/pull/5876#issuecomment-1278150689
The changes seem good to me, however I am not familiar with this repo. May
@vashu1 or @rhauch can help or suggest who can?
Also it looks like the failing checks need to be addressed
hachikuji commented on PR #12733:
URL: https://github.com/apache/kafka/pull/12733#issuecomment-1278150243
Closing since it looks like @cmccabe already picked this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
szalapski commented on code in PR #11986:
URL: https://github.com/apache/kafka/pull/11986#discussion_r995105062
##
clients/src/main/java/org/apache/kafka/common/config/internals/RecordingMap.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
hachikuji commented on code in PR #12734:
URL: https://github.com/apache/kafka/pull/12734#discussion_r995118293
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1339,6 +1341,26 @@ class Partition(val topicPartition: TopicPartition,
}
}
+// Fetching
[
https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee reassigned KAFKA-10228:
--
Assignee: Philip Nee
> producer: NETWORK_EXCEPTION is thrown instead of a request timeout
> -
[
https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617326#comment-17617326
]
Philip Nee commented on KAFKA-10228:
I think the current logging level has already b
José Armando García Sancio created KAFKA-14301:
--
Summary: Simulation validation that raft listener see NO_LEADER on
leader
Key: KAFKA-14301
URL: https://issues.apache.org/jira/browse/KAFKA-14301
jsancio opened a new pull request, #12747:
URL: https://github.com/apache/kafka/pull/12747
Setting the `committedBytesSinceLastSnapshot` to 0 when resigning can cause
the controller to not generate a snapshot after `snapshotMaxNewRecordBytes`
committed bytes have been replayed.
This
jsancio commented on code in PR #12747:
URL: https://github.com/apache/kafka/pull/12747#discussion_r995216141
##
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##
@@ -821,6 +821,73 @@ public void testSnapshotOnlyAfterConfiguredMinBytes()
throws Th
hachikuji merged PR #12741:
URL: https://github.com/apache/kafka/pull/12741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
[
https://issues.apache.org/jira/browse/KAFKA-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-14296.
-
Fix Version/s: 3.4.0
3.3.2
Resolution: Fixed
> Partition leade
[
https://issues.apache.org/jira/browse/KAFKA-14286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14286:
---
Fix Version/s: 3.4.0
> Time based cluster metadata snapshots
> -
[
https://issues.apache.org/jira/browse/KAFKA-14301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14301:
---
Fix Version/s: 3.4.0
3.3.2
> Simulation validatio
[
https://issues.apache.org/jira/browse/KAFKA-14286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14286:
---
Fix Version/s: (was: 3.4.0)
> Time based cluster metadata snapsh
[
https://issues.apache.org/jira/browse/KAFKA-14301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14301:
---
Fix Version/s: (was: 3.4.0)
(was: 3.3.2)
[
https://issues.apache.org/jira/browse/KAFKA-14300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14300:
---
Fix Version/s: 3.4.0
3.3.2
> KRaft controller sna
showuon commented on PR #12745:
URL: https://github.com/apache/kafka/pull/12745#issuecomment-1278331438
@cadonna , thanks for help revert the change. Although the jenkins tests
passed in the [PR](https://github.com/apache/kafka/pull/11211), it could be
because the code base is not synced up
jsancio merged PR #12688:
URL: https://github.com/apache/kafka/pull/12688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
songnon commented on PR #12543:
URL: https://github.com/apache/kafka/pull/12543#issuecomment-1278458717
> Perhaps we can update this to make it clearer that we can also do the
preferred leadership election on partitions undergoing reassignment to update
the preferred leader sooner.
F
songnon commented on PR #12543:
URL: https://github.com/apache/kafka/pull/12543#issuecomment-1278487313
> I'm also a little confused by shutting down the broker that is not part of
the assignment in the beginning. Some comments there could really help me
understand the scenario better.
shekhar-rajak commented on PR #12739:
URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278517048
I am not sure why one test case failed :
https://github.com/apache/kafka/pull/12739/checks?check_run_id=8869541214 . I
have not done any change in any other test file.
--
This is
76 matches
Mail list logo