[jira] [Commented] (KAFKA-14366) Kafka consumer rebalance issue, offsets points back to very old committed offset

2022-11-09 Thread Chetan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630855#comment-17630855 ] Chetan commented on KAFKA-14366: Hi [~pnee] I will detail the steps to recreate the scen

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-11-09 Thread GitBox
dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1017672302 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -135,6 +151,13 @@ class ReplicaFetcherThread(name: String, logAppendInfo } + private def

[GitHub] [kafka] cadonna commented on a diff in pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

2022-11-09 Thread GitBox
cadonna commented on code in PR #12835: URL: https://github.com/apache/kafka/pull/12835#discussion_r1017658640 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java: ## @@ -175,14 +175,14 @@ void commitOffsetsOrTransaction(final Map corruptedTas

[GitHub] [kafka] cadonna commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-09 Thread GitBox
cadonna commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1017702122 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -115,6 +117,7 @@ public void run() { private void runOn

[GitHub] [kafka] dajac commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-09 Thread GitBox
dajac commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1017718371 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -1229,4 +1247,23 @@ private boolean in(Set pairs) { r

[GitHub] [kafka] dajac commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-09 Thread GitBox
dajac commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1017743686 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -78,6 +80,26 @@ public void testDecodeGeneration() { assertF

[jira] [Resolved] (KAFKA-14298) Getting null pointer exception

2022-11-09 Thread Ramakrishna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ramakrishna resolved KAFKA-14298. - Resolution: Not A Problem > Getting null pointer exception > -- > >

[GitHub] [kafka] clolov commented on pull request #12809: [KAFKA-14324] Upgrade RocksDB to 7.1.2

2022-11-09 Thread GitBox
clolov commented on PR #12809: URL: https://github.com/apache/kafka/pull/12809#issuecomment-1308588950 Hopefully the newest two commits address your comments @ableegoldman, if not just let me know :) -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-09 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1017943192 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -277,6 +294,9 @@ private void addTask(final Task task) {

[GitHub] [kafka] cadonna commented on a diff in pull request #12809: [KAFKA-14324] Upgrade RocksDB to 7.1.2

2022-11-09 Thread GitBox
cadonna commented on code in PR #12809: URL: https://github.com/apache/kafka/pull/12809#discussion_r1017938045 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java: ## @@ -610,15 +617,21 @@ public Acces

[GitHub] [kafka] clolov commented on a diff in pull request #12836: KAFKA-14282: stop tracking Produced sensors by processor node id

2022-11-09 Thread GitBox
clolov commented on code in PR #12836: URL: https://github.com/apache/kafka/pull/12836#discussion_r1018025744 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -219,26 +219,20 @@ public void send(final String topic,

[GitHub] [kafka] clolov commented on a diff in pull request #12836: KAFKA-14282: stop tracking Produced sensors by processor node id

2022-11-09 Thread GitBox
clolov commented on code in PR #12836: URL: https://github.com/apache/kafka/pull/12836#discussion_r1018037337 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -219,26 +219,20 @@ public void send(final String topic,

[GitHub] [kafka] shekhar-rajak commented on a diff in pull request #12735: Replace EasyMock and PowerMock with Mockito in connect/runtime/ErrorHandlingTaskTest | KAFKA-14059

2022-11-09 Thread GitBox
shekhar-rajak commented on code in PR #12735: URL: https://github.com/apache/kafka/pull/12735#discussion_r1018066045 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java: ## @@ -374,30 +350,40 @@ public void testErrorHandlingInSourceTasks(

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-11-09 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1308922420 Hi @divijvaidya Please review once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] nicktelford commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

2022-11-09 Thread GitBox
nicktelford commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r1018125919 ## streams/src/main/java/org/apache/kafka/streams/state/internals/TransactionalKeyValueStore.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Found

[jira] [Created] (KAFKA-14371) quorum-state file contains empty/unused clusterId field

2022-11-09 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-14371: - Summary: quorum-state file contains empty/unused clusterId field Key: KAFKA-14371 URL: https://issues.apache.org/jira/browse/KAFKA-14371 Project: Kafka Iss

[GitHub] [kafka] cmccabe commented on a diff in pull request #12833: KAFKA-14370: Properly close ImageWriter objects

2022-11-09 Thread GitBox
cmccabe commented on code in PR #12833: URL: https://github.com/apache/kafka/pull/12833#discussion_r1018269186 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -398,8 +398,11 @@ class BrokerMetadataListener( build() try {

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-11-09 Thread GitBox
jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1018280351 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -135,6 +151,13 @@ class ReplicaFetcherThread(name: String, logAppendInfo } + private

[GitHub] [kafka] cmccabe commented on pull request #12833: KAFKA-14370: Simplify the ImageWriter API by adding freeze

2022-11-09 Thread GitBox
cmccabe commented on PR #12833: URL: https://github.com/apache/kafka/pull/12833#issuecomment-1309197714 It's a bit confusing to have two variations of close(), so let's just have freeze() and then close(). -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] pprovenzano opened a new pull request, #12838: [DO NOT MERGE] SaslPlainSslEndToEndAuthorizationTest

2022-11-09 Thread GitBox
pprovenzano opened a new pull request, #12838: URL: https://github.com/apache/kafka/pull/12838 Changes needed to get SaslPlainSslEndToEndAuthorizationTest to pass in KRAFT Removed direct calls in EndToEndAuthorizationTest to zookeeper and instead use the superuser prin

[GitHub] [kafka] cmccabe commented on a diff in pull request #12838: [DO NOT MERGE] SaslPlainSslEndToEndAuthorizationTest

2022-11-09 Thread GitBox
cmccabe commented on code in PR #12838: URL: https://github.com/apache/kafka/pull/12838#discussion_r1018304863 ## core/src/test/scala/integration/kafka/api/SaslPlainSslEndToEndAuthorizationTest.scala: ## @@ -147,10 +157,11 @@ class SaslPlainSslEndToEndAuthorizationTest extends

[GitHub] [kafka] cmccabe commented on pull request #12838: [DO NOT MERGE] SaslPlainSslEndToEndAuthorizationTest

2022-11-09 Thread GitBox
cmccabe commented on PR #12838: URL: https://github.com/apache/kafka/pull/12838#issuecomment-1309232726 Hi @pprovenzano . Thanks for the PR. Before I can review this I'd like to understand the strategy here. Do you want to leave the `CONTROLLER` endpoint as `PLAINTEXT`? Or will it als

[GitHub] [kafka] pprovenzano commented on a diff in pull request #12838: [DO NOT MERGE] SaslPlainSslEndToEndAuthorizationTest

2022-11-09 Thread GitBox
pprovenzano commented on code in PR #12838: URL: https://github.com/apache/kafka/pull/12838#discussion_r1018372760 ## core/src/test/scala/integration/kafka/api/SaslPlainSslEndToEndAuthorizationTest.scala: ## @@ -147,10 +157,11 @@ class SaslPlainSslEndToEndAuthorizationTest exten

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-09 Thread Mikael (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631265#comment-17631265 ] Mikael commented on KAFKA-14362: I would have thought that an orderly rebalance wouldn't

[GitHub] [kafka] pprovenzano commented on pull request #12838: [DO NOT MERGE] SaslPlainSslEndToEndAuthorizationTest

2022-11-09 Thread GitBox
pprovenzano commented on PR #12838: URL: https://github.com/apache/kafka/pull/12838#issuecomment-1309335998 The main focus of these tests is on brokers doing authorization and validating that the client gets (or does not get) access to the topic for various ACLs. So I think that we should n

[jira] [Updated] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-09 Thread Mikael (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael updated KAFKA-14362: --- Description: Trigger scenario: Two Kafka client application instances on separate EC2 instances with one c

[jira] [Created] (KAFKA-14372) RackAwareReplicaSelector should choose a replica from the isr

2022-11-09 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-14372: Summary: RackAwareReplicaSelector should choose a replica from the isr Key: KAFKA-14372 URL: https://issues.apache.org/jira/browse/KAFKA-14372 Project: Kafka Issue

[jira] [Updated] (KAFKA-14372) RackAwareReplicaSelector should choose a replica from the isr

2022-11-09 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-14372: - Description: The default replica selector chooses a replica solely on whether the broker.rack matches th

[jira] [Created] (KAFKA-14373) provide builders for producer/consumer

2022-11-09 Thread Daniel Scanteianu (Jira)
Daniel Scanteianu created KAFKA-14373: - Summary: provide builders for producer/consumer Key: KAFKA-14373 URL: https://issues.apache.org/jira/browse/KAFKA-14373 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-14373) provide builders for producer/consumer

2022-11-09 Thread Daniel Scanteianu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Scanteianu updated KAFKA-14373: -- Description: creating a producer/consumer involves looking up the consts for kafka co

[jira] [Commented] (KAFKA-14373) provide builders for producer/consumer

2022-11-09 Thread Daniel Scanteianu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631334#comment-17631334 ] Daniel Scanteianu commented on KAFKA-14373: --- i am happy to code this > provid

[jira] [Updated] (KAFKA-14373) provide builders for producer/consumer

2022-11-09 Thread Daniel Scanteianu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Scanteianu updated KAFKA-14373: -- Description: creating a producer/consumer involves looking up the consts for kafka co

[GitHub] [kafka] gharris1727 opened a new pull request, #12839: KAFKA-14346: Replace static mocking of WorkerConfig::lookupKafkaClusterId

2022-11-09 Thread GitBox
gharris1727 opened a new pull request, #12839: URL: https://github.com/apache/kafka/pull/12839 Signed-off-by: Greg Harris The static lookupKafkaClusterId method is mocked out in several tests, when it is now an implementation detail of the WorkerConfig. This change both migrates sta

[GitHub] [kafka] cmccabe commented on pull request #12838: [DO NOT MERGE] SaslPlainSslEndToEndAuthorizationTest

2022-11-09 Thread GitBox
cmccabe commented on PR #12838: URL: https://github.com/apache/kafka/pull/12838#issuecomment-1309560732 Rather than putting the `@Timeout(60)` on each test case, I'd suggest putting it on the test class itself, so that it applies to each test. Actually, can you split out a separate PR

[jira] [Resolved] (KAFKA-13964) kafka-configs.sh end with UnsupportedVersionException when describing TLS user with quotas

2022-11-09 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13964. - Resolution: Duplicate Thanks for reporting the issue. This will be resolved by https://

[jira] [Assigned] (KAFKA-14360) Documentation: Streams Security page has broken links

2022-11-09 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-14360: -- Assignee: Shay Lin (was: A. Sophie Blee-Goldman) > Documentation: St

[GitHub] [kafka] pratimsc opened a new pull request, #12840: Updated Jackson to version 2.13.4 for fixing CVE-2022-42004

2022-11-09 Thread GitBox
pratimsc opened a new pull request, #12840: URL: https://github.com/apache/kafka/pull/12840 Updated the Jackson libraries for mitigating CVEs fixed under release `2.13.4` , ref: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.13.4 -- This is an automated message from the A

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

2022-11-09 Thread GitBox
ableegoldman commented on code in PR #12835: URL: https://github.com/apache/kafka/pull/12835#discussion_r1018583064 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java: ## @@ -175,14 +175,14 @@ void commitOffsetsOrTransaction(final Map corrupt

[jira] [Commented] (KAFKA-13891) sync group failed with rebalanceInProgress error cause rebalance many rounds in coopeartive

2022-11-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631387#comment-17631387 ] Luke Chen commented on KAFKA-13891: --- I'm also very busy these days. [~aiquestion] , if

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

2022-11-09 Thread GitBox
ableegoldman commented on code in PR #12835: URL: https://github.com/apache/kafka/pull/12835#discussion_r1018584439 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java: ## @@ -191,43 +191,49 @@ void commitOffsetsOrTransaction(final Map allOffs

[GitHub] [kafka] showuon commented on pull request #12840: Updated Jackson to version 2.13.4 for fixing CVE-2022-42004

2022-11-09 Thread GitBox
showuon commented on PR #12840: URL: https://github.com/apache/kafka/pull/12840#issuecomment-1309672615 Should we also bump the `jackson-databind` to 2.13.4.2 for CVE-2022-42003? ref: https://github.com/spring-projects/spring-boot/issues/32583 -- This is an automated message from t

[jira] [Commented] (KAFKA-14373) provide builders for producer/consumer

2022-11-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631396#comment-17631396 ] Luke Chen commented on KAFKA-14373: --- [~scanteianu] , please remember to propose a [KI

[jira] [Commented] (KAFKA-14373) provide builders for producer/consumer

2022-11-09 Thread Daniel Scanteianu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631498#comment-17631498 ] Daniel Scanteianu commented on KAFKA-14373: --- Thanks, following the process in