[GitHub] [kafka] yashmayya commented on a diff in pull request #12844: KAFKA-14353: Allow configuring request timeouts for create/update/validate Kafka Connect REST endpoints

yashmayya commented on code in PR #12844: URL: https://github.com/apache/kafka/pull/12844#discussion_r1020910962 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1023,16 +1023,35 @@ private boolean connectorUsesSeparat

[GitHub] [kafka] dajac opened a new pull request, #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

dajac opened a new pull request, #12845: URL: https://github.com/apache/kafka/pull/12845 This patch adds `joinGroup` to the new `GroupCoordinator` interface and updates `KafkaApis` to use it. For the context, I will do the same for all the other interactions with the current group co

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1021205253 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1646,73 +1649,46 @@ class KafkaApis(val requestChannel: RequestChannel, } } + private def makeGroup

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1021205683 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1646,73 +1649,46 @@ class KafkaApis(val requestChannel: RequestChannel, } } + private def makeGroup

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1021206505 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -94,6 +95,7 @@ class KafkaApis(val requestChannel: RequestChannel, val metadataSupport: Metada

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1021207157 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2524,196 +2528,166 @@ class KafkaApisTest { assertEquals(MemoryRecords.EMPTY, FetchResponse.rec

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1021207545 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2524,196 +2528,166 @@ class KafkaApisTest { assertEquals(MemoryRecords.EMPTY, FetchResponse.rec

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1021208132 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2524,196 +2528,166 @@ class KafkaApisTest { assertEquals(MemoryRecords.EMPTY, FetchResponse.rec

[GitHub] [kafka] dajac commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

dajac commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1021208615 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2524,196 +2528,166 @@ class KafkaApisTest { assertEquals(MemoryRecords.EMPTY, FetchResponse.rec

[GitHub] [kafka] cadonna commented on pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

cadonna commented on PR #12835: URL: https://github.com/apache/kafka/pull/12835#issuecomment-1313290404 Build failures are not related: ``` Build / JDK 11 and Scala 2.13 / kafka.api.ProducerIdExpirationTest.testProducerIdExpirationWithNoTransactions(String).quorum=zk Build / JDK

[GitHub] [kafka] cadonna merged pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

cadonna merged PR #12835: URL: https://github.com/apache/kafka/pull/12835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12795: KAFKA-14299: Initialize tasks in state updater

cadonna commented on PR #12795: URL: https://github.com/apache/kafka/pull/12795#issuecomment-1313310601 Build failures are not related: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.security.oauthbearer.internals.secured.RefreshingHttpsJwksTest.testSecondaryRefreshAfterEl

[GitHub] [kafka] cadonna merged pull request #12795: KAFKA-14299: Initialize tasks in state updater

cadonna merged PR #12795: URL: https://github.com/apache/kafka/pull/12795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on a diff in pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

cadonna commented on code in PR #12343: URL: https://github.com/apache/kafka/pull/12343#discussion_r1021245518 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -2263,7 +2263,10 @@ public void configure(Map configs) { private Sende

[GitHub] [kafka] patrik-marton opened a new pull request, #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

patrik-marton opened a new pull request, #12846: URL: https://github.com/apache/kafka/pull/12846 … successful login - Added the AUTHENTICATION Priority to the JaasBasicAuthFilter. This way if multiple filters are present, they will be processed in the right order. Without th

[GitHub] [kafka] dajac opened a new pull request, #12847: KAFKA-14367; Add `SyncGroup` to the new `GroupCoordinator` interface

dajac opened a new pull request, #12847: URL: https://github.com/apache/kafka/pull/12847 This patch adds `syncGroup` to the new `GroupCoordinator` interface and updates `KafkaApis` to use it. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementat

[GitHub] [kafka] egyedt commented on pull request #12675: KAFKA-14256: Upgrade from Scala 2.13.8 to 2.13.10

egyedt commented on PR #12675: URL: https://github.com/apache/kafka/pull/12675#issuecomment-1313533851 The following dependency should also be checked: scoverage: "1.4.11" The 2.0.7 version of it, is the first one where Scala 2.13.10 is supported. https://mvnrepository.com/ar

[GitHub] [kafka] dajac opened a new pull request, #12848: KAFKA-14367; Add `Heartbeat` to the new `GroupCoordinator` interface

dajac opened a new pull request, #12848: URL: https://github.com/apache/kafka/pull/12848 This patch adds `heartbeat` to the new `GroupCoordinator` interface and updates `KafkaApis` to use it. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementat

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633763#comment-17633763 ] Mikael commented on KAFKA-14362: We are using KafkaMessageListenerContainer from spring-

[jira] [Assigned] (KAFKA-14260) InMemoryKeyValueStore iterator still throws ConcurrentModificationException

[ https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucia Cerchie reassigned KAFKA-14260: - Assignee: Lucia Cerchie (was: A. Sophie Blee-Goldman) > InMemoryKeyValueStore iterator

[jira] [Updated] (KAFKA-14386) Change ReplicaPlacer place method to return a class instead of list of list of integers

[ https://issues.apache.org/jira/browse/KAFKA-14386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-14386: - Summary: Change ReplicaPlacer place method to return a class instead of list of list of integers

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1313754279 Thanks for the input @ableegoldman . I have made the changes based on my understanding. TBH, the code has changed a bit from what it was when I had last worked on it and I am not ver

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1021579198 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2470,7 +2474,7 @@ public void markChangelogAsCorrupted(final Co

[jira] [Commented] (KAFKA-14260) InMemoryKeyValueStore iterator still throws ConcurrentModificationException

[ https://issues.apache.org/jira/browse/KAFKA-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633855#comment-17633855 ] Lucia Cerchie commented on KAFKA-14260: --- Getting to work adding the missing `sychr

[GitHub] [kafka] JK-Wang opened a new pull request, #12849: MINOR: Fix commitId maybe null

JK-Wang opened a new pull request, #12849: URL: https://github.com/apache/kafka/pull/12849 Reproduce step: 1. get src.zip 2. unzip and execute `git init` 3. execute `./gradlew jar` gradle error is: `Property 'commitId' doesn't have a configured value.` This is because `.

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1021676801 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java: ## @@ -16,23 +16,37 @@ */ package org.apache.kafka.connect.mirror; +import org.a

[GitHub] [kafka] C0urante commented on a diff in pull request #12828: KAFKA-14346: Remove hard-to-mock RestClient calls

C0urante commented on code in PR #12828: URL: https://github.com/apache/kafka/pull/12828#discussion_r1021729259 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -138,7 +141,7 @@ public Connect startConnect(Map workerProps) {

[GitHub] [kafka] dajac opened a new pull request, #12850: KAFKA-14367; Add `LeaveGroup` to the new `GroupCoordinator` interface

dajac opened a new pull request, #12850: URL: https://github.com/apache/kafka/pull/12850 This patch adds `leaveGroup` to the new `GroupCoordinator` interface and updates `KafkaApis` to use it. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementa

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1021800352 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1021801503 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java: ## @@ -16,23 +16,37 @@ */ package org.apache.kafka.connect.mirror; +import org.ap

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1021801927 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {

[GitHub] [kafka] soarez commented on a diff in pull request #12843: Remove use of "authorizer-properties" from EndToEndAuthorizerTest

soarez commented on code in PR #12843: URL: https://github.com/apache/kafka/pull/12843#discussion_r1020949539 ## core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala: ## @@ -96,96 +90,53 @@ abstract class EndToEndAuthorizationTest extends IntegrationTestHar

[jira] [Created] (KAFKA-14387) kafka.common.KafkaException | kafka_2.12-3.3.1.jar

masood created KAFKA-14387: -- Summary: kafka.common.KafkaException | kafka_2.12-3.3.1.jar Key: KAFKA-14387 URL: https://issues.apache.org/jira/browse/KAFKA-14387 Project: Kafka Issue Type: Bug

[GitHub] [kafka] vjanelle commented on pull request #12675: KAFKA-14256: Upgrade from Scala 2.13.8 to 2.13.10

vjanelle commented on PR #12675: URL: https://github.com/apache/kafka/pull/12675#issuecomment-1314271071 @mdedetrich looks like confluent has something in their branch linked to here that would work for the arg matching issue. -- This is an automated message from the Apache Git Service. T

[GitHub] [kafka] cmccabe commented on a diff in pull request #12837: MINOR: extract jointly owned parts of BrokerServer and ControllerServer

cmccabe commented on code in PR #12837: URL: https://github.com/apache/kafka/pull/12837#discussion_r1022006801 ## core/src/main/scala/kafka/server/KafkaRaftServer.scala: ## @@ -69,95 +64,56 @@ class KafkaRaftServer( private val controllerQuorumVotersFuture = CompletableFuture

[GitHub] [kafka] cmccabe commented on a diff in pull request #12837: MINOR: extract jointly owned parts of BrokerServer and ControllerServer

cmccabe commented on code in PR #12837: URL: https://github.com/apache/kafka/pull/12837#discussion_r1022011553 ## core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala: ## @@ -99,25 +94,28 @@ class KRaftQuorumImplementation( startup: Boolean, threadNameP

[GitHub] [kafka] cmccabe commented on a diff in pull request #12837: MINOR: extract jointly owned parts of BrokerServer and ControllerServer

cmccabe commented on code in PR #12837: URL: https://github.com/apache/kafka/pull/12837#discussion_r1022013591 ## core/src/main/scala/kafka/server/JointServer.scala: ## @@ -0,0 +1,237 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [kafka] cmccabe commented on a diff in pull request #12837: MINOR: extract jointly owned parts of BrokerServer and ControllerServer

cmccabe commented on code in PR #12837: URL: https://github.com/apache/kafka/pull/12837#discussion_r1022016615 ## core/src/main/scala/kafka/server/KafkaRaftServer.scala: ## @@ -69,95 +64,56 @@ class KafkaRaftServer( private val controllerQuorumVotersFuture = CompletableFuture

[GitHub] [kafka] cmccabe commented on a diff in pull request #12837: MINOR: extract jointly owned parts of BrokerServer and ControllerServer

cmccabe commented on code in PR #12837: URL: https://github.com/apache/kafka/pull/12837#discussion_r1022017395 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -130,18 +151,56 @@ public Builder setConfigProp(String key, String value) { return this

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1022018101 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {

[jira] [Created] (KAFKA-14388) NPE When Retrieving StateStore with new Processor API

Bill Bejeck created KAFKA-14388: --- Summary: NPE When Retrieving StateStore with new Processor API Key: KAFKA-14388 URL: https://issues.apache.org/jira/browse/KAFKA-14388 Project: Kafka Issue Typ

[GitHub] [kafka] cmccabe commented on a diff in pull request #12837: MINOR: extract jointly owned parts of BrokerServer and ControllerServer

cmccabe commented on code in PR #12837: URL: https://github.com/apache/kafka/pull/12837#discussion_r1022030312 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -159,53 +218,30 @@ public KafkaClusterTestKit build() throws Exception { executorSe

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1022049731 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1022049731 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1021800352 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {

[GitHub] [kafka] cmccabe commented on a diff in pull request #12837: MINOR: extract jointly owned parts of BrokerServer and ControllerServer

cmccabe commented on code in PR #12837: URL: https://github.com/apache/kafka/pull/12837#discussion_r1022030312 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -159,53 +218,30 @@ public KafkaClusterTestKit build() throws Exception { executorSe

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1022162537 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {

[GitHub] [kafka] showuon commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

showuon commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r1022364377 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java: ## @@ -270,7 +270,6 @@ public void testRemovingWork

[jira] [Created] (KAFKA-14389) CVE-2022-34917 | Fixed in 3.3.1

masood created KAFKA-14389: -- Summary: CVE-2022-34917 | Fixed in 3.3.1 Key: KAFKA-14389 URL: https://issues.apache.org/jira/browse/KAFKA-14389 Project: Kafka Issue Type: Bug Components: doc

[GitHub] [kafka] JK-Wang opened a new pull request, #12851: MINOR: Fix docs in security.html

JK-Wang opened a new pull request, #12851: URL: https://github.com/apache/kafka/pull/12851 incorrect value for param `--allow-principal` error is: zsh: no matches found: User:* -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] ableegoldman commented on pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

ableegoldman commented on PR #12835: URL: https://github.com/apache/kafka/pull/12835#issuecomment-1314909856 Sorry Bruno! I did miss those two comments it seems, apologies for that. I'll go back over your feedback and open a quick followup PR to make sure everything is addressed. Thanks!

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

ableegoldman commented on code in PR #12835: URL: https://github.com/apache/kafka/pull/12835#discussion_r1022441487 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskExecutorTest.java: ## @@ -35,4 +45,47 @@ public void testPunctuateWithPause() {

[GitHub] [kafka] ableegoldman commented on a diff in pull request #12835: KAFKA-14294: check whether a transaction is in flight before skipping a commit

ableegoldman commented on code in PR #12835: URL: https://github.com/apache/kafka/pull/12835#discussion_r1022442137 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java: ## @@ -191,43 +191,49 @@ void commitOffsetsOrTransaction(final Map allOffs