lmr3796 opened a new pull request, #13187:
URL: https://github.com/apache/kafka/pull/13187
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
This is for better obse
lmr3796 commented on PR #13187:
URL: https://github.com/apache/kafka/pull/13187#issuecomment-1413356998
Hi @jsancio wondering if you can take a look at this change.
We found it helpful for us to understand such URP issues.
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683291#comment-17683291
]
Nikolay Izhikov commented on KAFKA-14595:
-
Hello [~omnia_h_ibrahim]
Can I assi
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1094209610
##
checkstyle/import-control.xml:
##
@@ -351,6 +351,7 @@
+
Review Comment:
Is this related to the above comment? If not please move it above right
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1094301822
##
server-common/src/main/java/org/apache/kafka/server/util/TopicPartitionFilter.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
clolov commented on code in PR #13177:
URL: https://github.com/apache/kafka/pull/13177#discussion_r1094319881
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java:
##
@@ -0,0 +1,145 @@
+package org.apache.kafka.jmh.common.metrics;
+
+import or
mimaison merged PR #13136:
URL: https://github.com/apache/kafka/pull/13136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
clolov commented on code in PR #13180:
URL: https://github.com/apache/kafka/pull/13180#discussion_r1094398310
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -415,7 +416,7 @@ public void run() throws Exception {
Hangleton commented on code in PR #13176:
URL: https://github.com/apache/kafka/pull/13176#discussion_r1094408921
##
core/src/main/scala/kafka/migration/MigrationPropagator.scala:
##
@@ -79,6 +81,18 @@ class MigrationPropagator(
_image = image
}
+ /**
+ * A very expe
clolov commented on PR #13184:
URL: https://github.com/apache/kafka/pull/13184#issuecomment-1413610633
To be honest, when I read this code a class which is "kind of" like a
Transformation but throws because some methods are not implemented made more
sense than wrapping Transformations in a
[
https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683377#comment-17683377
]
Omnia Ibrahim commented on KAFKA-14595:
---
[~nizhikov] sure
> Move ReassignPartitio
[
https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Izhikov reassigned KAFKA-14595:
---
Assignee: Nikolay Izhikov (was: Omnia Ibrahim)
> Move ReassignPartitionsCommand to
Hangleton commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094454976
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -474,6 +472,7 @@ class MetadataChangeEvent extends MigrationEvent {
beardt commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1093403718
##
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java:
##
@@ -54,6 +58,12 @@ public void testConfiguredInstances() {
testInvalidInput
clolov commented on PR #12607:
URL: https://github.com/apache/kafka/pull/12607#issuecomment-1413735823
@cadonna I have rebased this on the latest trunk. Is it possible to get a
review? This pull requests is one of the last remaining ones for completing the
Mockito migration for streams.
-
Hangleton commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1094474509
##
storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpointFile.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Fou
clolov commented on PR #12777:
URL: https://github.com/apache/kafka/pull/12777#issuecomment-1413738931
@cadonna is it possible get a review here as well? @shekhar-rajak, if there
are any comments is it possible for you to address them. I will circle back in
a week's time and if there are st
clolov commented on PR #12739:
URL: https://github.com/apache/kafka/pull/12739#issuecomment-1413740025
@shekhar-rajak, I would quite like to complete the migration for streams, so
I will wait for a response for another week. Afterwards I will open a separate
pull request based on this one i
clolov commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1413742398
Hello @mdedetrich and @cadonna! Is there something still remaining for this
pull request or are we ready to merge it? There are around 4 pull requests
remaining of this migration and I wou
[
https://issues.apache.org/jira/browse/KAFKA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass reassigned KAFKA-14667:
---
Assignee: Viktor Somogyi-Vass
> Delayed leader election operation gets stuc
clolov commented on PR #12449:
URL: https://github.com/apache/kafka/pull/12449#issuecomment-1413745195
Hello @dplavcic and @cadonna, how is this pull request fairing? Is there
something outstanding as a review or comments to be addressed?
--
This is an automated message from the Apache Gi
beardt commented on PR #13168:
URL: https://github.com/apache/kafka/pull/13168#issuecomment-1413758244
I went ahead and reintroduced the InterceptorTestConfig as I do not think
it adds anymore complexity than `TestConfig` and `ClassTestConfig` while also
making `testConfiguredInstancesClo
[
https://issues.apache.org/jira/browse/KAFKA-14060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683418#comment-17683418
]
Hector Geraldino commented on KAFKA-14060:
--
Hey [~ChrisEgerton],
I wrote a pa
Hangleton commented on code in PR #13177:
URL: https://github.com/apache/kafka/pull/13177#discussion_r1094530705
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java:
##
@@ -0,0 +1,145 @@
+package org.apache.kafka.jmh.common.metrics;
+
+import
ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1080718765
##
storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochFileCache.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
David Jacot created KAFKA-14673:
---
Summary: High watermark listener
Key: KAFKA-14673
URL: https://issues.apache.org/jira/browse/KAFKA-14673
Project: Kafka
Issue Type: Sub-task
Report
ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1094564674
##
storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpoint.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation
ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1094564674
##
storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpoint.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation
mumrah commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094614887
##
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##
@@ -250,7 +250,7 @@ private void handleEvents() throws InterruptedException {
mumrah commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094617299
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -474,6 +472,7 @@ class MetadataChangeEvent extends MigrationEvent {
clolov commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1094628589
##
build.gradle:
##
@@ -1763,6 +1763,7 @@ project(':tools') {
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
implementation libs.lo
mimaison commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1094636765
##
build.gradle:
##
@@ -1763,6 +1763,7 @@ project(':tools') {
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
implementation libs.
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094656127
##
build.gradle:
##
@@ -1763,6 +1763,7 @@ project(':tools') {
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
implementation libs.lo
[
https://issues.apache.org/jira/browse/KAFKA-14059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-14059:
-
Assignee: (was: Chris Egerton)
> Replace EasyMock and PowerMock with Mockito in Wor
[
https://issues.apache.org/jira/browse/KAFKA-14060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683465#comment-17683465
]
Chris Egerton commented on KAFKA-14060:
---
[~hgeraldino] that's fine, thanks for the
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094680573
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094680573
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094680573
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
mumrah commented on code in PR #13180:
URL: https://github.com/apache/kafka/pull/13180#discussion_r1094683166
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -415,7 +416,7 @@ public void run() throws Exception {
mumrah commented on code in PR #13180:
URL: https://github.com/apache/kafka/pull/13180#discussion_r1094684342
##
metadata/src/main/java/org/apache/kafka/metadata/migration/MigrationSummary.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094685504
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094686108
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
C0urante commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1094686354
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -711,9 +768,35 @@ KafkaBasedLog
setupAndCreateKafkaBasedLog(Stri
fvaleri commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094601295
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
mumrah commented on PR #13183:
URL: https://github.com/apache/kafka/pull/13183#issuecomment-1413948935
Updates:
* Factored out the CompletableFuture from the MetadataChangeEvent so it's
only used in the unit test
* Removed QueueClosingException, replaced with RejectedExecutionException
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094714174
##
tools/src/test/java/org/apache/kafka/tools/DelegationTokenCommandTest.java:
##
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094720518
##
tools/src/test/java/org/apache/kafka/tools/DelegationTokenCommandTest.java:
##
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
fvaleri commented on PR #13171:
URL: https://github.com/apache/kafka/pull/13171#issuecomment-1413963412
Rebased. Thanks @clolov and @mimaison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Chris Egerton created KAFKA-14674:
-
Summary: Backport fix for KAFKA-14455 to 3.3 and 3.4 branches
Key: KAFKA-14674
URL: https://issues.apache.org/jira/browse/KAFKA-14674
Project: Kafka
Issue
C0urante merged PR #12984:
URL: https://github.com/apache/kafka/pull/12984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
gharris1727 commented on PR #13184:
URL: https://github.com/apache/kafka/pull/13184#issuecomment-1414001178
@clolov Perhaps that's where a name change would help. If this was named
`TransformationStage`, with a `TransformationChain` made up of multiple
`TransformationStage`s and a `Transfor
yashmayya commented on PR #12984:
URL: https://github.com/apache/kafka/pull/12984#issuecomment-1414002141
Thanks Greg and Chris for the great reviews on this one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094780253
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094781664
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094781236
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094783703
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -596,22 +604,89 @@ synchronized public DeleteRecordsResult
deleteRecords(Map future
[
https://issues.apache.org/jira/browse/KAFKA-14671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-14671:
Description:
The PredicatedTransformation
[https://github.com/apache/kafka/blob/trunk/connect/run
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094783958
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -596,22 +604,89 @@ synchronized public DeleteRecordsResult
deleteRecords(Map future
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094784273
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -94,6 +100,8 @@ public class MockAdminClient extends AdminClient {
private Map
[
https://issues.apache.org/jira/browse/KAFKA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682641#comment-17682641
]
Federico Valeri edited comment on KAFKA-14582 at 2/2/23 4:37 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682643#comment-17682643
]
Federico Valeri edited comment on KAFKA-14584 at 2/2/23 4:37 PM:
-
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094788715
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
mumrah commented on PR #13180:
URL: https://github.com/apache/kafka/pull/13180#issuecomment-1414048688
@cmccabe, here's the new metadata summary format:
> [2023-02-02 11:21:52,175] TRACE Sending RPCs to broker before moving to
dual-write mode. Metadata at offset 122 and epoch 1 in
clolov commented on code in PR #13180:
URL: https://github.com/apache/kafka/pull/13180#discussion_r1094798424
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -415,7 +416,7 @@ public void run() throws Exception {
shekhar-rajak commented on PR #12777:
URL: https://github.com/apache/kafka/pull/12777#issuecomment-1414050155
Hi,
This PR already have one approval and ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
AndrefcBarber commented on PR #6329:
URL: https://github.com/apache/kafka/pull/6329#issuecomment-1414061654
Hi, trying to sell this great product to our company to resolve streaming. I
followed the comments and proposed solutions from Kafka-1194(2016) to present.
@robertbraeutigam & @kobihi
shekhar-rajak commented on PR #12739:
URL: https://github.com/apache/kafka/pull/12739#issuecomment-1414078362
Ack. Let me update the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
[
https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683497#comment-17683497
]
Calvin Liu commented on KAFKA-14139:
Hi Alex, I am not aware of such simulation fram
OneCricketeer commented on code in PR #12992:
URL: https://github.com/apache/kafka/pull/12992#discussion_r1094853715
##
clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation
OneCricketeer commented on code in PR #12992:
URL: https://github.com/apache/kafka/pull/12992#discussion_r1094853715
##
clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation
mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1414149629
Sorry I have just been busy with other things, will look into it next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
cmccabe commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094915210
##
metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java:
##
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
cmccabe commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094918202
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -538,12 +553,23 @@ public void run() throws Exception {
cmccabe commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094922008
##
metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java:
##
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
cmccabe commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094928271
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -474,6 +472,7 @@ class MetadataChangeEvent extends MigrationEvent {
cmccabe commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094930020
##
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##
@@ -250,7 +250,7 @@ private void handleEvents() throws InterruptedException {
[
https://issues.apache.org/jira/browse/KAFKA-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683545#comment-17683545
]
Philip Nee commented on KAFKA-12639:
Hey [~matiss.gutmanis] - I'm arriving at the sa
[
https://issues.apache.org/jira/browse/KAFKA-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683545#comment-17683545
]
Philip Nee edited comment on KAFKA-12639 at 2/2/23 7:16 PM:
vcrfxia opened a new pull request, #13188:
URL: https://github.com/apache/kafka/pull/13188
(This PR is stacked on https://github.com/apache/kafka/pull/13143; the first
commit does not need to be reviewed separately.)
Introduces the VersionedKeyValueStore interface proposed in KIP-889,
vcrfxia opened a new pull request, #13189:
URL: https://github.com/apache/kafka/pull/13189
(This PR is stacked on https://github.com/apache/kafka/pull/13188, which in
turn is stacked on https://github.com/apache/kafka/pull/13143. Only the last
commit (`add restore`) needs to be reviewed as
Hangleton commented on PR #13078:
URL: https://github.com/apache/kafka/pull/13078#issuecomment-1414321689
Thanks @anatasiavela for the PR. Apologies for any repeat, just wanted to
ask if you would plan to have this merged before or after
[PR-13040](https://github.com/apache/kafka/pull/13040
philipnee opened a new pull request, #13190:
URL: https://github.com/apache/kafka/pull/13190
In AbstractCoordinator#joinGroupIfNeeded - joinGroup request will be retried
without proper backoff, due to the expired timer. This is an uncommon scenario
and possibly only appears during the testi
[
https://issues.apache.org/jira/browse/KAFKA-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-14490:
--
Summary: Consider using UncheckedIOException instead of IOException in the
log layer
Hangleton commented on PR #12399:
URL: https://github.com/apache/kafka/pull/12399#issuecomment-1414383920
The vulnerability has been addressed by the following commits.
- [Apache Kafka
2.8](https://github.com/apache/kafka/commit/14951a83e3fdead212156e5532359500d72f68bc)
- [Apache K
Hangleton commented on code in PR #13040:
URL: https://github.com/apache/kafka/pull/13040#discussion_r1095052846
##
storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateManager.java:
##
@@ -0,0 +1,671 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
guozhangwang merged PR #12777:
URL: https://github.com/apache/kafka/pull/12777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
guozhangwang commented on PR #12739:
URL: https://github.com/apache/kafka/pull/12739#issuecomment-1414532246
@shekhar-rajak please let me know after you've updated the PR incorporating
previous comments.
--
This is an automated message from the Apache Git Service.
To respond to the messag
[
https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Coates reopened KAFKA-14660:
-
The issue here is more the SonaType security vulnerability report than any
impossible to reach divi
[
https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683597#comment-17683597
]
Andy Coates commented on KAFKA-14660:
-
[~mjsax] can you provide a link to the PR tha
Kirk True created KAFKA-14675:
-
Summary: Extract metadata-related tasks from Fetcher into
MetadataFetcher
Key: KAFKA-14675
URL: https://issues.apache.org/jira/browse/KAFKA-14675
Project: Kafka
I
hgeraldino opened a new pull request, #13191:
URL: https://github.com/apache/kafka/pull/13191
This PR is part of the larger initiative of migrating tests from
EasyMock/PowerMock to
Mockito](https://issues.apache.org/jira/browse/KAFKA-7438), and is a "blocker"
of https://issues.apache.org/j
ijuma commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1095220913
##
server-common/src/main/java/org/apache/kafka/server/util/FutureUtils.java:
##
@@ -66,4 +67,27 @@ public static T waitWithLogging(
throw new RuntimeExcept
[
https://issues.apache.org/jira/browse/KAFKA-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683598#comment-17683598
]
Guozhang Wang commented on KAFKA-12639:
---
Yeah that would work better I think.
> A
philipnee commented on PR #13190:
URL: https://github.com/apache/kafka/pull/13190#issuecomment-1414556430
@guozhangwang - would you have time to review this 🥺 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
kirktrue opened a new pull request, #13192:
URL: https://github.com/apache/kafka/pull/13192
Extract from `Fetcher` the APIs that are related to metadata operations into
a new class named `MetadataFetcher`. This will allow the refactoring of
`Fetcher` and `MetadataFetcher` for the new consum
kirktrue commented on PR #13192:
URL: https://github.com/apache/kafka/pull/13192#issuecomment-1414573568
cc @hachikuji @rajinisivaram @philipnee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jolshan commented on PR #13078:
URL: https://github.com/apache/kafka/pull/13078#issuecomment-1414580619
@Hangleton We can try to get this merged before
https://github.com/apache/kafka/pull/13040 if that helps.
--
This is an automated message from the Apache Git Service.
To respond to the
jolshan commented on PR #13078:
URL: https://github.com/apache/kafka/pull/13078#issuecomment-1414584410
@ijuma Do you have any concerns with switching to ConcurrentHashMap here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hgeraldino opened a new pull request, #13193:
URL: https://github.com/apache/kafka/pull/13193
This PR aligns the description for `source-record-write-rate` and
`source-record-write-total` metrics, and excludes the filtered records from the
metrics being published.
Today, the `source-
[
https://issues.apache.org/jira/browse/KAFKA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino reassigned KAFKA-14659:
Assignee: Hector Geraldino
> source-record-write-[rate|total] metrics include fil
1 - 100 of 108 matches
Mail list logo
