[jira] [Assigned] (KAFKA-14938) Flaky test org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest#testConnectorBoundary

2023-04-26 Thread Sambhav Jain (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sambhav Jain reassigned KAFKA-14938: Assignee: Sambhav Jain > Flaky test >

[GitHub] [kafka] atu-sharm commented on pull request #13633: KAFKA-14839: Exclude protected variable from JavaDocs

2023-04-26 Thread via GitHub
atu-sharm commented on PR #13633: URL: https://github.com/apache/kafka/pull/13633#issuecomment-1524697998 @mjsax @machi1990 can you review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-14944) Reduce CompletedFetch#parseRecord() memory copy

2023-04-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14944. --- Fix Version/s: 3.6.0 Resolution: Fixed > Reduce CompletedFetch#parseRecord() memory copy >

[jira] [Updated] (KAFKA-14945) Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-04-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14945: -- Fix Version/s: (was: 3.6.0) > Add Serializer#serializeToByteBuffer() to reduce memory copying >

[GitHub] [kafka] showuon commented on pull request #12545: KAFKA-14944: Reduce CompletedFetch#parseRecord() memory copy

2023-04-26 Thread via GitHub
showuon commented on PR #12545: URL: https://github.com/apache/kafka/pull/12545#issuecomment-1524581695 Thanks for the reminder! Updated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Reopened] (KAFKA-14945) Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-04-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reopened KAFKA-14945: --- > Add Serializer#serializeToByteBuffer() to reduce memory copying >

[GitHub] [kafka] LinShunKang commented on pull request #12545: KAFKA-14944: Reduce CompletedFetch#parseRecord() memory copy

2023-04-26 Thread via GitHub
LinShunKang commented on PR #12545: URL: https://github.com/apache/kafka/pull/12545#issuecomment-1524573080 @showuon Thanks for your help! But, it seems like you've confused JIRA KAFKA-14944 with KAFKA-14945. -- This is an automated message from the Apache Git Service. To respond

[jira] [Resolved] (KAFKA-14945) Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-04-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14945. --- Fix Version/s: 3.6.0 Resolution: Fixed > Add Serializer#serializeToByteBuffer() to reduce

[GitHub] [kafka] showuon commented on pull request #12545: KAFKA-14944: Reduce CompletedFetch#parseRecord() memory copy

2023-04-26 Thread via GitHub
showuon commented on PR #12545: URL: https://github.com/apache/kafka/pull/12545#issuecomment-1524523279 Thanks for the improvement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] showuon merged pull request #12545: KAFKA-14944: Reduce CompletedFetch#parseRecord() memory copy

2023-04-26 Thread via GitHub
showuon merged PR #12545: URL: https://github.com/apache/kafka/pull/12545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14945) Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-04-26 Thread LinShunkang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LinShunkang updated KAFKA-14945: Component/s: clients > Add Serializer#serializeToByteBuffer() to reduce memory copying >

[jira] [Assigned] (KAFKA-14945) Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-04-26 Thread LinShunkang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LinShunkang reassigned KAFKA-14945: --- Assignee: LinShunkang > Add Serializer#serializeToByteBuffer() to reduce memory copying >

[jira] [Assigned] (KAFKA-14944) Reduce CompletedFetch#parseRecord() memory copy

2023-04-26 Thread LinShunkang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LinShunkang reassigned KAFKA-14944: --- Assignee: LinShunkang > Reduce CompletedFetch#parseRecord() memory copy >

[jira] [Created] (KAFKA-14945) Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-04-26 Thread LinShunkang (Jira)
LinShunkang created KAFKA-14945: --- Summary: Add Serializer#serializeToByteBuffer() to reduce memory copying Key: KAFKA-14945 URL: https://issues.apache.org/jira/browse/KAFKA-14945 Project: Kafka

[GitHub] [kafka] LinShunKang commented on pull request #12545: KAFKA-14944: Reduce CompletedFetch#parseRecord() memory copy

2023-04-26 Thread via GitHub
LinShunKang commented on PR #12545: URL: https://github.com/apache/kafka/pull/12545#issuecomment-1524475111 > @LinShunKang , could you create a JIRA issue related to this KIP, and make the PR title started with `KAFKA-: Reduce...` instead of `KIP-xxx: Reduce...`. Also, the KIP needs to

[jira] [Updated] (KAFKA-14944) Reduce CompletedFetch#parseRecord() memory copy

2023-04-26 Thread LinShunkang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LinShunkang updated KAFKA-14944: External issue URL: (was: https://github.com/apache/kafka/pull/12545) > Reduce

[jira] [Created] (KAFKA-14944) Reduce CompletedFetch#parseRecord() memory copy

2023-04-26 Thread LinShunkang (Jira)
LinShunkang created KAFKA-14944: --- Summary: Reduce CompletedFetch#parseRecord() memory copy Key: KAFKA-14944 URL: https://issues.apache.org/jira/browse/KAFKA-14944 Project: Kafka Issue Type:

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-04-26 Thread via GitHub
jeffkbkim commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1178516453 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-04-26 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1178509941 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -424,6 +477,11 @@ ProducerIdAndEpoch producerIdAndEpoch() { }

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-04-26 Thread via GitHub
kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1524272599 @urbandan I've made a bit of an overhaul to add more context via a dedicated `enum` that is only used internally. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-04-26 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1178509019 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -968,13 +968,31 @@ private void transitionTo(State target) {

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

2023-04-26 Thread via GitHub
jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1177161037 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] cmccabe opened a new pull request, #13645: KAFKA-14943: Fix ClientQuotaControlManager validation

2023-04-26 Thread via GitHub
cmccabe opened a new pull request, #13645: URL: https://github.com/apache/kafka/pull/13645 Don't allow setting negative or zero values for quotas. Don't allow SCRAM mechanism names to be used as client quota names. SCRAM mechanisms are not client quotas. (The confusion arose because of

[jira] [Created] (KAFKA-14943) Fix ClientQuotaControlManager validation

2023-04-26 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-14943: Summary: Fix ClientQuotaControlManager validation Key: KAFKA-14943 URL: https://issues.apache.org/jira/browse/KAFKA-14943 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-14942) CopyOnWriteMap implements ConcurrentMap but does not implement required default methods

2023-04-26 Thread Steven Schlansker (Jira)
Steven Schlansker created KAFKA-14942: - Summary: CopyOnWriteMap implements ConcurrentMap but does not implement required default methods Key: KAFKA-14942 URL: https://issues.apache.org/jira/browse/KAFKA-14942

[GitHub] [kafka] jeffkbkim opened a new pull request, #13644: KAFKA-14500; [1/N] Rewrite MemberMetadata

2023-04-26 Thread via GitHub
jeffkbkim opened a new pull request, #13644: URL: https://github.com/apache/kafka/pull/13644 Rewrites MemberMetadata as GenericGroupMember that will be used with the new group coordinator. Written on top of https://github.com/apache/kafka/pull/13639, will rebase once it's merged.

[jira] [Created] (KAFKA-14941) Document which configuration options are applicable only to processes with broker role or controller role

2023-04-26 Thread Jakub Scholz (Jira)
Jakub Scholz created KAFKA-14941: Summary: Document which configuration options are applicable only to processes with broker role or controller role Key: KAFKA-14941 URL:

[GitHub] [kafka] bmscomp commented on a diff in pull request #13627: MINOR: simplify if else conditions in Uuid.compareTo method

2023-04-26 Thread via GitHub
bmscomp commented on code in PR #13627: URL: https://github.com/apache/kafka/pull/13627#discussion_r1178371488 ## clients/src/main/java/org/apache/kafka/common/Uuid.java: ## @@ -143,12 +143,6 @@ public int compareTo(Uuid other) { return 1; Review Comment: Still

[jira] [Updated] (KAFKA-14633) Compression optimization: Use BufferSupplier to allocate the intermediate decompressed buffer

2023-04-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14633: - Attachment: decompression-opt-cpu-after.html decompression-opt-cpu-before.html

[jira] [Updated] (KAFKA-14935) Wire Protocol Documentation Does Not Explain Header Versioning

2023-04-26 Thread Andrew Thaddeus Martin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Thaddeus Martin updated KAFKA-14935: --- Description: The documentation for Kafka's wire protocol does not explain

[jira] [Assigned] (KAFKA-14500) Implement JoinGroup/SyncGroup APIs

2023-04-26 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim reassigned KAFKA-14500: Assignee: Jeff Kim > Implement JoinGroup/SyncGroup APIs > -- > >

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-04-26 Thread via GitHub
philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1178260025 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -328,6 +333,21 @@ void runOnce() { client.poll(pollTimeout,

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-04-26 Thread via GitHub
philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1178259026 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -328,6 +333,21 @@ void runOnce() { client.poll(pollTimeout,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-04-26 Thread via GitHub
divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1178242551 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (KAFKA-14633) Compression optimization: Use BufferSupplier to allocate the intermediate decompressed buffer

2023-04-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14633: - Attachment: benchmark-jira (5).xlsx > Compression optimization: Use BufferSupplier to allocate

[GitHub] [kafka] jolshan commented on pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-04-26 Thread via GitHub
jolshan commented on PR #12149: URL: https://github.com/apache/kafka/pull/12149#issuecomment-1523826079 Left a few more questions -- I think we are in the final stretch here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-04-26 Thread via GitHub
jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1178215576 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -328,6 +333,21 @@ void runOnce() { client.poll(pollTimeout,

[GitHub] [kafka] jolshan commented on pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-04-26 Thread via GitHub
jolshan commented on PR #12149: URL: https://github.com/apache/kafka/pull/12149#issuecomment-1523820442 Going to rerun the build one more time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1178132374 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1178131103 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Created] (KAFKA-14940) Refactor ApiMessageAndVersion/Record

2023-04-26 Thread David Jacot (Jira)
David Jacot created KAFKA-14940: --- Summary: Refactor ApiMessageAndVersion/Record Key: KAFKA-14940 URL: https://issues.apache.org/jira/browse/KAFKA-14940 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1178128312 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1178121430 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -149,47 +148,51 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1178092855 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1178092765 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1178091373 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1178090280 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1178085471 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1178084392 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1178083579 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1178059673 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1178034681 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -1038,6 +1038,96 @@ public void

[GitHub] [kafka] mumrah merged pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-04-26 Thread via GitHub
mumrah merged PR #13407: URL: https://github.com/apache/kafka/pull/13407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-04-26 Thread via GitHub
mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1177944732 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsPublisher.java: ## @@ -115,6 +115,9 @@ private void publishDelta(MetadataDelta

[jira] [Created] (KAFKA-14939) Only expose ZkMigrationState metric if metadata.version supports it

2023-04-26 Thread David Arthur (Jira)
David Arthur created KAFKA-14939: Summary: Only expose ZkMigrationState metric if metadata.version supports it Key: KAFKA-14939 URL: https://issues.apache.org/jira/browse/KAFKA-14939 Project: Kafka

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177937393 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -42,10 +30,22 @@ import

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177936654 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -1038,6 +1038,96 @@ public void

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177934535 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -1038,6 +1038,96 @@ public void

[GitHub] [kafka] emissionnebula commented on a diff in pull request #13437: KAFKA-14828: Remove R/W locks using persistent data structures

2023-04-26 Thread via GitHub
emissionnebula commented on code in PR #13437: URL: https://github.com/apache/kafka/pull/13437#discussion_r1177916880 ## metadata/src/main/java/org/apache/kafka/metadata/authorizer/AclCache.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177895473 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -149,47 +148,51 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177893519 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -149,47 +148,51 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] showuon commented on a diff in pull request #13631: KAFKA-14909: check zkMigrationReady tag before migration

2023-04-26 Thread via GitHub
showuon commented on code in PR #13631: URL: https://github.com/apache/kafka/pull/13631#discussion_r1177832658 ## metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java: ## @@ -128,4 +128,27 @@ VersionRange localSupportedFeature(String featureName) {

[GitHub] [kafka] dajac commented on a diff in pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
dajac commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1177783905 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -137,7 +136,7 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] viktorsomogyi merged pull request #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure

2023-04-26 Thread via GitHub
viktorsomogyi merged PR #13634: URL: https://github.com/apache/kafka/pull/13634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14929) Flaky KafkaStatusBackingStoreFormatTest#putTopicStateRetriableFailure

2023-04-26 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716686#comment-17716686 ] Sagar Rao commented on KAFKA-14929: --- hey [~viktorsomogyi] i assigned this one to myself. > Flaky

[jira] [Assigned] (KAFKA-14929) Flaky KafkaStatusBackingStoreFormatTest#putTopicStateRetriableFailure

2023-04-26 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14929: - Assignee: Sagar Rao (was: Viktor Somogyi-Vass) > Flaky

[jira] [Created] (KAFKA-14938) Flaky test org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest#testConnectorBoundary

2023-04-26 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-14938: - Summary: Flaky test org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest#testConnectorBoundary Key: KAFKA-14938 URL: https://issues.apache.org/jira/browse/KAFKA-14938

Consumer offset value -Apache kafka 3.2.3

2023-04-26 Thread Kafka Life
Dear Kafka Experts How can we check for a particular offset number in Apache kafka 3.2.3 version.Could you please share some light. The kafka_console_consumer tool is throwing class not found error. ./kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --topic your-topic --group

Re: Consumer Lag Metrics/ Topic level metrics

2023-04-26 Thread Kafka Life
Many thanks Samuel. Will go thru this. On Tue, Apr 25, 2023 at 9:03 PM Samuel Delepiere < samuel.delepi...@celer-tech.com> wrote: > Hi, > > I use a combination of the Prometheus JMX exporter ( > https://github.com/prometheus/jmx_exporter) and the Prometheus Kafka > exporter

[GitHub] [kafka] divijvaidya commented on pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

2023-04-26 Thread via GitHub
divijvaidya commented on PR #13312: URL: https://github.com/apache/kafka/pull/13312#issuecomment-1523106081 @ijuma this is ready for your review. All failing tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1177582252 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1177577692 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

2023-04-26 Thread via GitHub
dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1177576930 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mdedetrich commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2023-04-26 Thread via GitHub
mdedetrich commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1523012501 @yashmayya I am currently on a company offside, will get back to you on this at the end of the week -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mimaison commented on pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

2023-04-26 Thread via GitHub
mimaison commented on PR #13550: URL: https://github.com/apache/kafka/pull/13550#issuecomment-1522983087 @philipnee Yes, we can backport this to 3.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] divijvaidya commented on pull request #13569: MINOR: Upgrade to Gradle 8.1

2023-04-26 Thread via GitHub
divijvaidya commented on PR #13569: URL: https://github.com/apache/kafka/pull/13569#issuecomment-1522978758 Thank you for making this is a teaching moment @ijuma. I will try to do better reviews, keeping in mind your suggestion in future. -- This is an automated message from the Apache

[GitHub] [kafka] fvaleri commented on a diff in pull request #13514: KAFKA-14752: Kafka examples improvements - consumer changes

2023-04-26 Thread via GitHub
fvaleri commented on code in PR #13514: URL: https://github.com/apache/kafka/pull/13514#discussion_r1177496559 ## examples/src/main/java/kafka/examples/Consumer.java: ## @@ -76,12 +79,17 @@ public Consumer(String threadName, public void run() { // the consumer

[GitHub] [kafka] machi1990 commented on a diff in pull request #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure

2023-04-26 Thread via GitHub
machi1990 commented on code in PR #13634: URL: https://github.com/apache/kafka/pull/13634#discussion_r1177474423 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java: ## @@ -216,7 +216,7 @@ public void

[jira] [Commented] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-04-26 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716579#comment-17716579 ] Chris Egerton commented on KAFKA-14666: --- Merged to trunk and backported to 3.5. I'll backport

[jira] [Updated] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-04-26 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14666: -- Priority: Blocker (was: Major) > MM2 should translate consumer group offsets behind

[GitHub] [kafka] C0urante merged pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-26 Thread via GitHub
C0urante merged PR #13429: URL: https://github.com/apache/kafka/pull/13429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante commented on pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-26 Thread via GitHub
C0urante commented on PR #13429: URL: https://github.com/apache/kafka/pull/13429#issuecomment-1522920608 Test failures appear unrelated (any MM2 tests failing here are also failing non-deterministically on trunk). Merging... -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1177447512 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1177445627 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1177444507 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1177444040 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1177426778 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMemberTest.java: ## @@ -0,0 +1,307 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1177423293 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1177415325 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1177415325 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1177415325 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -0,0 +1,611 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-04-26 Thread via GitHub
rreddy-22 commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1177412216 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache