[GitHub] [kafka] jeqo commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-02 Thread via GitHub
jeqo commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1183258537 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo

[GitHub] [kafka] jeqo commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-02 Thread via GitHub
jeqo commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1183258439 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1118,9 +1122,13 @@ class ReplicaManager(val config: KafkaConfig, responseCallback:

[GitHub] [kafka] vamossagar12 commented on pull request #13453: KAFKA-12525: Ignoring Stale status statuses when reading from Status …

2023-05-02 Thread via GitHub
vamossagar12 commented on PR #13453: URL: https://github.com/apache/kafka/pull/13453#issuecomment-1532463904 There are some tests for which i am not sure if they are related to this change like `testGetActiveTopics – org.apache.kafka.connect.integration.ConnectorTopicsIntegrationTest`.

[GitHub] [kafka] showuon commented on a diff in pull request #13660: KAFKA-14662: Update the ACL list in the doc

2023-05-02 Thread via GitHub
showuon commented on code in PR #13660: URL: https://github.com/apache/kafka/pull/13660#discussion_r1183193194 ## docs/security.html: ## @@ -2089,6 +2089,144 @@

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1183188070 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -744,6 +751,8 @@ class ReplicaManager(val config: KafkaConfig, } // map not yet

[GitHub] [kafka] showuon commented on pull request #13653: KAFKA-14946: fix NPE when merging the deltatable

2023-05-02 Thread via GitHub
showuon commented on PR #13653: URL: https://github.com/apache/kafka/pull/13653#issuecomment-1532350519 @cmccabe , PR updated and add tests. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] hachikuji commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

2023-05-02 Thread via GitHub
hachikuji commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1183173661 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -744,6 +751,8 @@ class ReplicaManager(val config: KafkaConfig, } // map not yet

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183163284 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183162775 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183161313 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183160178 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183155377 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] splett2 commented on pull request #13655: MINOR: Reduce number of threads created for integration test brokers

2023-05-02 Thread via GitHub
splett2 commented on PR #13655: URL: https://github.com/apache/kafka/pull/13655#issuecomment-1532309913 @jolshan I am investigating ```

[jira] [Updated] (KAFKA-14957) Default value for state.dir is confusing

2023-05-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14957: Component/s: docs > Default value for state.dir is confusing >

[jira] [Updated] (KAFKA-14957) Default value for state.dir is confusing

2023-05-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14957: Labels: beginner newbie (was: ) > Default value for state.dir is confusing >

[jira] [Updated] (KAFKA-14957) Default value for state.dir is confusing

2023-05-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14957: Priority: Minor (was: Major) > Default value for state.dir is confusing >

[jira] [Commented] (KAFKA-14957) Default value for state.dir is confusing

2023-05-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718759#comment-17718759 ] Matthias J. Sax commented on KAFKA-14957: - [~mimaison] – Thanks. What part of the docs are you

[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-05-02 Thread via GitHub
mjsax commented on PR #13654: URL: https://github.com/apache/kafka/pull/13654#issuecomment-1532305605 System test failed due to incorrect dev-version. Pushed a fix. Retriggered system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5656/ -- This is an

[GitHub] [kafka] philipnee commented on pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-05-02 Thread via GitHub
philipnee commented on PR #12149: URL: https://github.com/apache/kafka/pull/12149#issuecomment-1532302560 thank you~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] jeffkbkim commented on pull request #13644: KAFKA-14500; [1/N] Rewrite MemberMetadata in Java

2023-05-02 Thread via GitHub
jeffkbkim commented on PR #13644: URL: https://github.com/apache/kafka/pull/13644#issuecomment-1532302254 > @jeffkbkim I left a few comments. It seems that the PR does not depend on #13443. You may want to rebase it on trunk and we could merge it when ready. I don't believe this was

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-02 Thread via GitHub
CalvinConfluent commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183136736 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13644: KAFKA-14500; [1/N] Rewrite MemberMetadata in Java

2023-05-02 Thread via GitHub
jeffkbkim commented on code in PR #13644: URL: https://github.com/apache/kafka/pull/13644#discussion_r1183141858 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupMember.java: ## @@ -0,0 +1,560 @@ +/** + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-05-02 Thread via GitHub
jolshan commented on PR #12149: URL: https://github.com/apache/kafka/pull/12149#issuecomment-1532288964 Still an issue -- rebuilding again  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13644: KAFKA-14500; [1/N] Rewrite MemberMetadata in Java

2023-05-02 Thread via GitHub
jeffkbkim commented on code in PR #13644: URL: https://github.com/apache/kafka/pull/13644#discussion_r1183141858 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupMember.java: ## @@ -0,0 +1,560 @@ +/** + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
jolshan commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1532288164 Some small comments, but I think we are very close to merging :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1183141070 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3405,6 +3406,52 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1183140536 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3405,6 +3406,54 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,

[GitHub] [kafka] jeffkbkim opened a new pull request, #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

2023-05-02 Thread via GitHub
jeffkbkim opened a new pull request, #13663: URL: https://github.com/apache/kafka/pull/13663 Rewrites GroupMetadata as GenericGroup that will be used with the new group coordinator. Written on top of https://github.com/apache/kafka/pull/13644, will rebase once it's merged. these

[GitHub] [kafka] cmccabe commented on a diff in pull request #13540: MINOR: improve QuorumController logging

2023-05-02 Thread via GitHub
cmccabe commented on code in PR #13540: URL: https://github.com/apache/kafka/pull/13540#discussion_r1183132783 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -977,16 +969,8 @@ public void handleSnapshot(SnapshotReader reader) {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13540: MINOR: improve QuorumController logging

2023-05-02 Thread via GitHub
cmccabe commented on code in PR #13540: URL: https://github.com/apache/kafka/pull/13540#discussion_r1183132532 ## metadata/src/main/java/org/apache/kafka/controller/ControllerPurgatory.java: ## @@ -65,6 +81,7 @@ void failAll(Exception exception) { while

[GitHub] [kafka] bmscomp opened a new pull request, #13662: MINOR: Upgrade Jackson dependencies to version to 2.15.0

2023-05-02 Thread via GitHub
bmscomp opened a new pull request, #13662: URL: https://github.com/apache/kafka/pull/13662 Upgrade Jackson dependencies to version `2.15.0` - Unify the Jackson and Jackson Data bind dependencies to the latest stable version 2.15.0 - Remove deprecation call of

[GitHub] [kafka] splett2 commented on a diff in pull request #13655: MINOR: Reduce number of threads created for integration test brokers

2023-05-02 Thread via GitHub
splett2 commented on code in PR #13655: URL: https://github.com/apache/kafka/pull/13655#discussion_r1183105854 ## core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala: ## @@ -609,7 +609,10 @@ class DynamicBrokerConfigTest { val zkClient: KafkaZkClient =

[GitHub] [kafka] showuon commented on a diff in pull request #13653: KAFKA-14946: fix NPE when merging the deltatable

2023-05-02 Thread via GitHub
showuon commented on code in PR #13653: URL: https://github.com/apache/kafka/pull/13653#discussion_r1183102365 ## server-common/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java: ## @@ -113,7 +113,7 @@ public void mergeFrom(long epoch, Delta source) {

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1532197761 > @kirktrue do we have a list of transitions we consider internal vs external? It would be nice to review that list as well as the code. I've added that list to the comments for

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1183080878 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -384,14 +436,19 @@ synchronized boolean isAborting() { }

[jira] [Assigned] (KAFKA-10337) Wait for pending async commits in commitSync() even if no offsets are specified

2023-05-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-10337: - Assignee: Kirk True > Wait for pending async commits in commitSync() even if no offsets are >

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

2023-05-02 Thread via GitHub
vcrfxia commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1183072852 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -41,6 +41,7 @@ metadata_2_versions = [str(LATEST_0_10_1), str(LATEST_0_10_2), str(LATEST_0_11_0),

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

2023-05-02 Thread via GitHub
vcrfxia commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1183071555 ## streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java: ## @@ -143,6 +173,94 @@ private static void buildFKTable(final KStream primaryTable,

[jira] [Created] (KAFKA-14960) Metadata Request Manager and listTopics/partitionsFor API

2023-05-02 Thread Philip Nee (Jira)
Philip Nee created KAFKA-14960: -- Summary: Metadata Request Manager and listTopics/partitionsFor API Key: KAFKA-14960 URL: https://issues.apache.org/jira/browse/KAFKA-14960 Project: Kafka Issue

[GitHub] [kafka] cherylws opened a new pull request, #13661: Fix format and other small errors in config documentation

2023-05-02 Thread via GitHub
cherylws opened a new pull request, #13661: URL: https://github.com/apache/kafka/pull/13661 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] mjsax commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

2023-05-02 Thread via GitHub
mjsax commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1183045333 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -41,6 +41,7 @@ metadata_2_versions = [str(LATEST_0_10_1), str(LATEST_0_10_2), str(LATEST_0_11_0),

[GitHub] [kafka] mjsax commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

2023-05-02 Thread via GitHub
mjsax commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1183043768 ## streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestUtil.java: ## @@ -34,10 +34,34 @@ public class SmokeTestUtil { final static int END =

[GitHub] [kafka] mjsax commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

2023-05-02 Thread via GitHub
mjsax commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1183042758 ## streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java: ## @@ -143,6 +173,94 @@ private static void buildFKTable(final KStream primaryTable,

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

2023-05-02 Thread via GitHub
vcrfxia commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1183023137 ## streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestUtil.java: ## @@ -34,10 +34,34 @@ public class SmokeTestUtil { final static int END =

[GitHub] [kafka] jolshan commented on a diff in pull request #13655: MINOR: Reduce number of threads created for integration test brokers

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13655: URL: https://github.com/apache/kafka/pull/13655#discussion_r1183001927 ## core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala: ## @@ -609,7 +609,10 @@ class DynamicBrokerConfigTest { val zkClient: KafkaZkClient =

[GitHub] [kafka] splett2 commented on pull request #13655: MINOR: Reduce number of threads created for integration test brokers

2023-05-02 Thread via GitHub
splett2 commented on PR #13655: URL: https://github.com/apache/kafka/pull/13655#issuecomment-1532073691 Test failures were: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] dajac commented on a diff in pull request #13659: MINOR: add docs to remind reader that impl of ConsumerPartitionAssign…

2023-05-02 Thread via GitHub
dajac commented on code in PR #13659: URL: https://github.com/apache/kafka/pull/13659#discussion_r1182960724 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignor.java: ## @@ -39,11 +39,13 @@ * as the group coordinator. The coordinator selects

[jira] [Assigned] (KAFKA-14662) ACL listings in documentation are out of date

2023-05-02 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-14662: - Assignee: Gantigmaa Selenge > ACL listings in documentation are out of date >

[GitHub] [kafka] tinaselenge opened a new pull request, #13660: KAFKA-14662: Update the ACL list in the doc

2023-05-02 Thread via GitHub
tinaselenge opened a new pull request, #13660: URL: https://github.com/apache/kafka/pull/13660 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] chia7712 opened a new pull request, #13659: MINOR: add docs to remind reader that impl of ConsumerPartitionAssign…

2023-05-02 Thread via GitHub
chia7712 opened a new pull request, #13659: URL: https://github.com/apache/kafka/pull/13659 https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignor.java#L306 The impl of `ConsumerPartitionAssignor` can get configs

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182910018 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -384,14 +436,19 @@ synchronized boolean isAborting() { }

[GitHub] [kafka] C0urante commented on pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
C0urante commented on PR #13657: URL: https://github.com/apache/kafka/pull/13657#issuecomment-1531892045 Backported to 3.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] C0urante merged pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
C0urante merged PR #13657: URL: https://github.com/apache/kafka/pull/13657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14842) MirrorCheckpointTask can reduce the rpc calls of "listConsumerGroupOffsets(group)" of irrelevant groups at each poll

2023-05-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14842: -- Fix Version/s: 3.4.1 3.3.3 > MirrorCheckpointTask can reduce the rpc calls

[jira] [Updated] (KAFKA-14837) The MirrorCheckPointConnector of MM2 will rebalance frequently, when the source cluster group is many more and changes frequently (but the list of configured synchronous

2023-05-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14837: -- Fix Version/s: 3.4.1 3.3.3 > The MirrorCheckPointConnector of MM2 will

[jira] [Updated] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-05-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14666: -- Fix Version/s: 3.4.1 3.3.3 > MM2 should translate consumer group offsets

[jira] [Commented] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-05-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718669#comment-17718669 ] Chris Egerton commented on KAFKA-14666: --- Backported to 3.4 and 3.3. > MM2 should translate

[jira] [Assigned] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

2023-05-02 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo reassigned KAFKA-14959: - Assignee: Manyanda Chitimbo > Remove metrics on ClientQuota Managers shutdown

[GitHub] [kafka] machi1990 commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
machi1990 commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182849704 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = {

[jira] [Updated] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

2023-05-02 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo updated KAFKA-14959: -- Fix Version/s: (was: 3.6.0) > Remove metrics on ClientQuota Managers shutdown >

[jira] [Assigned] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

2023-05-02 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo reassigned KAFKA-14959: - Assignee: (was: Divij Vaidya) > Remove metrics on ClientQuota Managers

[jira] [Updated] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

2023-05-02 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo updated KAFKA-14959: -- Description: We register metrics in ClientQuotaManager.scala and its child classes

[jira] [Created] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

2023-05-02 Thread Manyanda Chitimbo (Jira)
Manyanda Chitimbo created KAFKA-14959: - Summary: Remove metrics on ClientQuota Managers shutdown Key: KAFKA-14959 URL: https://issues.apache.org/jira/browse/KAFKA-14959 Project: Kafka

[jira] [Updated] (KAFKA-14916) Fix code that assumes transactional ID implies all records are transactional

2023-05-02 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14916: --- Description: KAFKA-14561 wrote code that assumed that if a transactional ID was included,

[jira] [Created] (KAFKA-14958) Investigate enforcing all batches have the same producer ID

2023-05-02 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-14958: -- Summary: Investigate enforcing all batches have the same producer ID Key: KAFKA-14958 URL: https://issues.apache.org/jira/browse/KAFKA-14958 Project: Kafka

[jira] [Updated] (KAFKA-14916) Fix code that assumes transactional ID implies all records are transactional

2023-05-02 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14916: --- Description: KAFKA-14561 wrote code that assumed that if a transactional ID was included,

[GitHub] [kafka] cmccabe commented on pull request #13653: KAFKA-14946: fix NPE when merging the deltatable

2023-05-02 Thread via GitHub
cmccabe commented on PR #13653: URL: https://github.com/apache/kafka/pull/13653#issuecomment-1531861352 Thanks, this is a very good find, @showuon ! We've been seeing this NPE occassionally but never found out where it was coming from. I left a correction, take a look -- This is

[GitHub] [kafka] cmccabe commented on a diff in pull request #13653: KAFKA-14946: fix NPE when merging the deltatable

2023-05-02 Thread via GitHub
cmccabe commented on code in PR #13653: URL: https://github.com/apache/kafka/pull/13653#discussion_r1182836931 ## server-common/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java: ## @@ -113,7 +113,7 @@ public void mergeFrom(long epoch, Delta source) {

[jira] [Created] (KAFKA-14957) Default value for state.dir is confusing

2023-05-02 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14957: -- Summary: Default value for state.dir is confusing Key: KAFKA-14957 URL: https://issues.apache.org/jira/browse/KAFKA-14957 Project: Kafka Issue Type: Bug

[GitHub] [kafka] C0urante commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
C0urante commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182806166 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET

[GitHub] [kafka] C0urante commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
C0urante commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182806166 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182805477 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -968,13 +1035,23 @@ private void transitionTo(State target) {

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182805033 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -263,7 +263,14 @@ public void run() { while (!forceClose &&

[GitHub] [kafka] mimaison commented on pull request #13640: KAFKA-14937: Refactoring for client code to reduce boilerplate

2023-05-02 Thread via GitHub
mimaison commented on PR #13640: URL: https://github.com/apache/kafka/pull/13640#issuecomment-1531813505 @kirktrue I'm looking at it now. With this PR I consistently get failures with the following tests: ``` SslAdminIntegrationTest.testAclUpdatesUsingAsynchronousAuthorizer()

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182801453 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3405,6 +3406,52 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182800998 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -263,7 +263,14 @@ public void run() { while (!forceClose &&

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182800168 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -968,13 +1035,23 @@ private void transitionTo(State target) {

[GitHub] [kafka] kirktrue commented on pull request #13640: KAFKA-14937: Refactoring for client code to reduce boilerplate

2023-05-02 Thread via GitHub
kirktrue commented on PR #13640: URL: https://github.com/apache/kafka/pull/13640#issuecomment-1531804943 @mimaison Would you be willing to merge this change? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mjsax commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

2023-05-02 Thread via GitHub
mjsax commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1182064875 ## streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java: ## @@ -126,7 +130,7 @@ static void generatePerpetually(final String kafka,

[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-05-02 Thread via GitHub
mjsax commented on PR #13654: URL: https://github.com/apache/kafka/pull/13654#issuecomment-1531777179 Same issue. Trying again: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5655/ -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-14661) Upgrade Zookeeper to 3.8.1

2023-05-02 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718640#comment-17718640 ] Divij Vaidya commented on KAFKA-14661: -- Adding targeted fix version to 3.6.0. The KIP is accepted

[jira] [Updated] (KAFKA-14661) Upgrade Zookeeper to 3.8.1

2023-05-02 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14661: - Fix Version/s: 3.6.0 > Upgrade Zookeeper to 3.8.1 > --- > >

[jira] [Assigned] (KAFKA-14956) Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest#testGetSinkConnectorOffsetsDifferentKafkaClusterTargeted

2023-05-02 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya reassigned KAFKA-14956: -- Assignee: Yash Mayya > Flaky test >

[GitHub] [kafka] yashmayya commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
yashmayya commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182756093 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET

[GitHub] [kafka] yashmayya commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
yashmayya commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182756093 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET

[GitHub] [kafka] dajac merged pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac merged PR #13637: URL: https://github.com/apache/kafka/pull/13637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
C0urante commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182739254 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET

[GitHub] [kafka] mimaison commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-05-02 Thread via GitHub
mimaison commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1182729223 ## tools/src/test/java/org/apache/kafka/tools/LogDirsCommandTest.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] C0urante commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
C0urante commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182730958 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET

[GitHub] [kafka] mimaison merged pull request #13259: MINOR: Remove accidental unnecessary code in src

2023-05-02 Thread via GitHub
mimaison merged PR #13259: URL: https://github.com/apache/kafka/pull/13259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-14956) Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest#testGetSinkConnectorOffsetsDifferentKafkaClusterTargeted

2023-05-02 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-14956: - Summary: Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest#testGetSinkConnectorOffsetsDifferentKafkaClusterTargeted Key: KAFKA-14956 URL:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182721302 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = {

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Range Assignor on the Server (KIP-848)

2023-05-02 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1182715705 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,574 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182715489 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -124,29 +124,37 @@ class LogCleaner(initialConfig: CleanerConfig, private def maxOverCleanerThreads(f:

[jira] [Created] (KAFKA-14955) Validate that all partitions are assigned in TargetAssignmentBuilder

2023-05-02 Thread David Jacot (Jira)
David Jacot created KAFKA-14955: --- Summary: Validate that all partitions are assigned in TargetAssignmentBuilder Key: KAFKA-14955 URL: https://issues.apache.org/jira/browse/KAFKA-14955 Project: Kafka

[GitHub] [kafka] mumrah commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

2023-05-02 Thread via GitHub
mumrah commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1182705187 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -534,5 +421,157 @@ public void testSkipWaitForBrokersInDualWrite()

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182598786 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182599075 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182598786 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] fvaleri closed pull request #13492: KAFKA-14752: Kafka examples improvements

2023-05-02 Thread via GitHub
fvaleri closed pull request #13492: KAFKA-14752: Kafka examples improvements URL: https://github.com/apache/kafka/pull/13492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

  1   2   >