[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203578132 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203601651 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203610206 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203610761 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203611994 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203615232 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203623275 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-12384) Flaky Test ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

[ https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725672#comment-17725672 ] Viktor Somogyi-Vass commented on KAFKA-12384: - Found another one in https:/

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203625806 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203627084 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -0,0 +1,2017 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] showuon commented on a diff in pull request #13747: MINOR: Fix ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

showuon commented on code in PR #13747: URL: https://github.com/apache/kafka/pull/13747#discussion_r1203646848 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -192,7 +192,7 @@ class ListOffsetsRequestTest extends BaseRequestTest { killBroker(fir

[GitHub] [kafka] showuon commented on a diff in pull request #13747: MINOR: Fix ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

showuon commented on code in PR #13747: URL: https://github.com/apache/kafka/pull/13747#discussion_r1203646848 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -192,7 +192,7 @@ class ListOffsetsRequestTest extends BaseRequestTest { killBroker(fir

[GitHub] [kafka] dajac commented on a diff in pull request #13747: MINOR: Fix ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

dajac commented on code in PR #13747: URL: https://github.com/apache/kafka/pull/13747#discussion_r1203652500 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -192,7 +192,7 @@ class ListOffsetsRequestTest extends BaseRequestTest { killBroker(first

[GitHub] [kafka] dajac commented on pull request #13747: MINOR: Fix ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

dajac commented on PR #13747: URL: https://github.com/apache/kafka/pull/13747#issuecomment-1560644863 @showuon Thanks for your review. Yes, your understanding is correct. This check never worked in fact. The part which is not clear is that this test fails all the time since we merged https:

[GitHub] [kafka] dajac commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

dajac commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1203664360 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1121,21 +1154,69 @@ class ReplicaManager(val config: KafkaConfig, partition.legacyFetchOffsetsForTim

[GitHub] [kafka] dajac commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

dajac commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1203666314 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1335,6 +1433,50 @@ class ReplicaManager(val config: KafkaConfig, result } + private def handle

[GitHub] [kafka] dajac commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

dajac commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1203673361 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1335,6 +1433,50 @@ class ReplicaManager(val config: KafkaConfig, result } + private def handle

[GitHub] [kafka] mimaison commented on pull request #13749: KAFKA-15016: Update LICENSE-binary file

mimaison commented on PR #13749: URL: https://github.com/apache/kafka/pull/13749#issuecomment-1560670729 @divijvaidya My understanding is that we only have to include licenses for packages included in the binary distribution. bcpkix is only used for test and not part of the Kafka distributi

[GitHub] [kafka] dajac merged pull request #13747: MINOR: Fix ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

dajac merged PR #13747: URL: https://github.com/apache/kafka/pull/13747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] divijvaidya commented on pull request #13749: KAFKA-15016: Update LICENSE-binary file

divijvaidya commented on PR #13749: URL: https://github.com/apache/kafka/pull/13749#issuecomment-1560672306 > @divijvaidya My understanding is that we only have to include licenses for packages included in the binary distribution. bcpkix is only used for test and not part of the Kafka distr

[GitHub] [kafka] divijvaidya commented on pull request #13746: removed recreation of partition to fix partitions having uneven data disctribution

divijvaidya commented on PR #13746: URL: https://github.com/apache/kafka/pull/13746#issuecomment-1560684188 Hey @sanjanagoyal Thank you for your first contribution to the project. 1. Would you please add a unit test that fails prior to this change and succeeds afterwards? Apart f

[jira] [Commented] (KAFKA-12384) Flaky Test ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

[ https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725703#comment-17725703 ] Viktor Somogyi-Vass commented on KAFKA-12384: - [~satish.duggana] I checked o

[GitHub] [kafka] dengziming commented on pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse

dengziming commented on PR #13679: URL: https://github.com/apache/kafka/pull/13679#issuecomment-1560714746 @KarboniteKream Thank you for reporting this, I'm trying to reproduce your case locally but failed, do you mean that this problem only occur after the leader is shut down and restarted

[GitHub] [kafka] yashmayya commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

yashmayya commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1203576413 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1528,6 +1539,80 @@ public void connectorOffsets(String co

[GitHub] [kafka] viktorsomogyi merged pull request #11565: KAFKA-13504: Retry connect internal topics' creation in case of InvalidReplicationFactorException

viktorsomogyi merged PR #11565: URL: https://github.com/apache/kafka/pull/11565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.a

[GitHub] [kafka] viktorsomogyi commented on pull request #11565: KAFKA-13504: Retry connect internal topics' creation in case of InvalidReplicationFactorException

viktorsomogyi commented on PR #11565: URL: https://github.com/apache/kafka/pull/11565#issuecomment-1560730693 Thank you @akatona84 for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] KarboniteKream commented on pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse

KarboniteKream commented on PR #13679: URL: https://github.com/apache/kafka/pull/13679#issuecomment-1560737054 Correct, the issue happens after shutting down and restarting the leader. Here's the example configuration: - [`1.properties`](https://gist.github.com/KarboniteKream/6ec03

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13742: KAFKA-14996: Handle overly large user operations on the kcontroller

divijvaidya commented on code in PR #13742: URL: https://github.com/apache/kafka/pull/13742#discussion_r1203739372 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -160,6 +161,14 @@ * the controller can fully initialize. */ public final cla

[jira] [Updated] (KAFKA-13504) Retry connect internal topics' creation in case of InvalidReplicationFactorException

[ https://issues.apache.org/jira/browse/KAFKA-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-13504: Description: In case the Kafka Broker cluster and the Kafka Connect cluster is sta

[GitHub] [kafka] divijvaidya commented on pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

divijvaidya commented on PR #13676: URL: https://github.com/apache/kafka/pull/13676#issuecomment-1560747003 The next step here is to get attention of a committer to look into this PR. Usually @ijuma is interested in reviewing build related improvements. Or perhaps @mimaison may be intereste

[GitHub] [kafka] akatona84 commented on a diff in pull request #13733: KAFKA-13337: Plugin loader error handling is done separately, per plugin

akatona84 commented on code in PR #13733: URL: https://github.com/apache/kafka/pull/13733#discussion_r1203763926 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java: ## @@ -22,6 +22,7 @@ import org.junit.rules.TemporaryFold

[jira] [Commented] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725712#comment-17725712 ] Klemen Košir commented on KAFKA-14996: -- The {{getFinalizedFeatures}} regression (an

[jira] [Commented] (KAFKA-15018) Potential tombstone offsets corruption for exactly-once source connectors

[ https://issues.apache.org/jira/browse/KAFKA-15018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725713#comment-17725713 ] Yash Mayya commented on KAFKA-15018: Thanks for filing this bug ticket [~ChrisEgerto

[GitHub] [kafka] HurSungYun opened a new pull request, #13752: MINOR: fix typo in Connect Config documentation

HurSungYun opened a new pull request, #13752: URL: https://github.com/apache/kafka/pull/13752 https://github.com/apache/kafka/assets/8033896/40d112b0-6d6f-4441-b82c-72909be6c157";> Fix typo in ConnectorConfig.java documentation adding a whitespace. ### Committer Checklist (e

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13703: MINOR: Standardize controller log4j output for replaying records

divijvaidya commented on code in PR #13703: URL: https://github.com/apache/kafka/pull/13703#discussion_r1203778428 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -473,8 +488,8 @@ public void replay(PartitionChangeRecord record) {

[jira] [Updated] (KAFKA-14952) Publish metrics when source connector fails to poll data

[ https://issues.apache.org/jira/browse/KAFKA-14952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-14952: --- Labels: connect connect-api kip-required (was: connect connect-api) > Publish metrics when source c

[GitHub] [kafka] divijvaidya commented on pull request #13680: MINOR: Add "versions" tag to recently added ReplicaState field on Fetch Request

divijvaidya commented on PR #13680: URL: https://github.com/apache/kafka/pull/13680#issuecomment-1560795936 @CalvinConfluent thoughts on this one? I am not very much familiar with difference between taggedVersions and versions field and am looking forward to understand the difference. --

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725722#comment-17725722 ] Yash Mayya commented on KAFKA-14995: [~dajac] that GitHub team isn't publicly access

[GitHub] [kafka] divijvaidya commented on pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

divijvaidya commented on PR #13421: URL: https://github.com/apache/kafka/pull/13421#issuecomment-1560847517 Apologies about the delay in reviewing this. I need another week to look into this part of the code base. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] divijvaidya commented on pull request #9256: Fix some Gradle deprecation warnings

divijvaidya commented on PR #9256: URL: https://github.com/apache/kafka/pull/9256#issuecomment-1560889897 We are currently running gradle v8 and these warning have been fixed since this PR was opened. I am closing this PR. Please feel free to re-open if you still observe these deprecation w

[GitHub] [kafka] divijvaidya closed pull request #9256: Fix some Gradle deprecation warnings

divijvaidya closed pull request #9256: Fix some Gradle deprecation warnings URL: https://github.com/apache/kafka/pull/9256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[jira] [Commented] (KAFKA-12384) Flaky Test ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

[ https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725761#comment-17725761 ] Viktor Somogyi-Vass commented on KAFKA-12384: - Ok, [~dajac] got to it sooner

[jira] [Resolved] (KAFKA-12384) Flaky Test ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

[ https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass resolved KAFKA-12384. - Fix Version/s: 3.6.0 Resolution: Fixed > Flaky Test ListOffsetsRequestTes

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1203965540 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -129,16 +150,19 @@ import static org.junit.jupiter.api.Asser

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1203992806 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1204028973 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -626,12 +704,14 @@ public synchronized void maybeTransitionToError

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13703: MINOR: Standardize controller log4j output for replaying records

divijvaidya commented on code in PR #13703: URL: https://github.com/apache/kafka/pull/13703#discussion_r1204039964 ## metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java: ## @@ -64,12 +66,44 @@ * completed, which is another reason the prepare / complete c

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204079800 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204087015 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -489,24 +489,23 @@ class AuthorizerIntegrationTest extends BaseRequestTest { }

[GitHub] [kafka] dajac opened a new pull request, #13753: MINOR: Log previous leader when replica transitions from leader to follower or vice versa

dajac opened a new pull request, #13753: URL: https://github.com/apache/kafka/pull/13753 I just had a case where this would have been useful so adding it. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

[GitHub] [kafka] clayburn commented on pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

clayburn commented on PR #13676: URL: https://github.com/apache/kafka/pull/13676#issuecomment-1561117359 The test failures appear to come from these two test cases across the following JDKs: * JDK 8: https://ge.apache.org/s/7zk5qyab6i54u/tests/overview?outcome=failed * JDK 11: https://

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204151150 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204162396 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13753: MINOR: Log previous leader when replica transitions from leader to follower or vice versa

divijvaidya commented on code in PR #13753: URL: https://github.com/apache/kafka/pull/13753#discussion_r1204246878 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -726,7 +726,7 @@ class Partition(val topicPartition: TopicPartition, s"with partition epoch $

[GitHub] [kafka] dajac commented on a diff in pull request #13753: MINOR: Log previous leader when replica transitions from leader to follower or vice versa

dajac commented on code in PR #13753: URL: https://github.com/apache/kafka/pull/13753#discussion_r1204298139 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -726,7 +726,7 @@ class Partition(val topicPartition: TopicPartition, s"with partition epoch ${parti

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13753: MINOR: Log previous leader when replica transitions from leader to follower or vice versa

divijvaidya commented on code in PR #13753: URL: https://github.com/apache/kafka/pull/13753#discussion_r1204309801 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -726,7 +726,7 @@ class Partition(val topicPartition: TopicPartition, s"with partition epoch $

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204312762 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] C0urante commented on a diff in pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

C0urante commented on code in PR #13165: URL: https://github.com/apache/kafka/pull/13165#discussion_r1204336495 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/LoaderSwap.java: ## @@ -24,13 +24,32 @@ public class LoaderSwap implements AutoCloseable {

[GitHub] [kafka] C0urante commented on a diff in pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

C0urante commented on code in PR #13165: URL: https://github.com/apache/kafka/pull/13165#discussion_r1204337446 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/AbstractConnectCli.java: ## @@ -119,36 +120,37 @@ public Connect startConnect(Map workerProps, String...

[GitHub] [kafka] C0urante commented on pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

C0urante commented on PR #13165: URL: https://github.com/apache/kafka/pull/13165#issuecomment-1561331016 That's a good point about the static initialization taking place directly before the constructor right now, but it's possible that other logic either directly from the Connect framework

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204356253 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204361177 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204376110 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] dajac opened a new pull request, #13754: MINOR: Hopefully fix flaky FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor

dajac opened a new pull request, #13754: URL: https://github.com/apache/kafka/pull/13754 This test fails regularly in CI ([example](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13753/1/tests)). This is an attempt to stabilize it. ### Committer Ch

[jira] [Commented] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725858#comment-17725858 ] Edoardo Comar commented on KAFKA-14996: --- I found another way to get into the error

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204403475 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] mimaison merged pull request #13749: KAFKA-15016: Update LICENSE-binary file

mimaison merged PR #13749: URL: https://github.com/apache/kafka/pull/13749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-15016) LICENSE-binary file contains dependencies not included anymore

[ https://issues.apache.org/jira/browse/KAFKA-15016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-15016. Fix Version/s: 3.6.0 Resolution: Fixed > LICENSE-binary file contains dependencies

[GitHub] [kafka] divijvaidya commented on pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on PR #13135: URL: https://github.com/apache/kafka/pull/13135#issuecomment-1561407539 Failing tests are unrelated: ``` Build / JDK 11 and Scala 2.13 / [1] quorum=kraft, isIdempotenceEnabled=true – kafka.api.SaslPlainSslEndToEndAuthorizationTest 14s Build / J

[GitHub] [kafka] vamossagar12 opened a new pull request, #13755: [MINOR] Fixing typo in ExactlyOnceWorkerSourceTask#commitableRecords

vamossagar12 opened a new pull request, #13755: URL: https://github.com/apache/kafka/pull/13755 Renaming filed commitableRecords to committableRecords in ExactlyOnceWorkerSourceTask. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] ijuma commented on a diff in pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

ijuma commented on code in PR #13676: URL: https://github.com/apache/kafka/pull/13676#discussion_r120291 ## build.gradle: ## @@ -39,7 +39,6 @@ plugins { id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.8" id "com.github.spotbugs" version '5.0.13' apply fals

[GitHub] [kafka] yashmayya commented on a diff in pull request #13750: MINOR: Handle the config topic read timeout edge case in DistributedHerder's stopConnector method

yashmayya commented on code in PR #13750: URL: https://github.com/apache/kafka/pull/13750#discussion_r1204446383 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1104,7 +1104,9 @@ public void stopConnector(final String

[GitHub] [kafka] yashmayya commented on a diff in pull request #13750: MINOR: Handle the config topic read timeout edge case in DistributedHerder's stopConnector method

yashmayya commented on code in PR #13750: URL: https://github.com/apache/kafka/pull/13750#discussion_r1204446383 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1104,7 +1104,9 @@ public void stopConnector(final String

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

gharris1727 commented on code in PR #13165: URL: https://github.com/apache/kafka/pull/13165#discussion_r1204482479 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/LoaderSwap.java: ## @@ -24,13 +24,32 @@ public class LoaderSwap implements AutoCloseable

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204079800 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb

[GitHub] [kafka] clayburn commented on a diff in pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

clayburn commented on code in PR #13676: URL: https://github.com/apache/kafka/pull/13676#discussion_r1204490523 ## build.gradle: ## @@ -39,7 +39,6 @@ plugins { id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.8" id "com.github.spotbugs" version '5.0.13' apply f

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204492401 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204493167 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204494016 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] gharris1727 commented on pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

gharris1727 commented on PR #13165: URL: https://github.com/apache/kafka/pull/13165#issuecomment-1561615543 @C0urante I added a static list to all of the Sampling plugins that allow us to inspect the classloader used for all method calls to all instances of each plugin type. This should now

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204522037 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204523103 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204523524 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Commented] (KAFKA-13679) Superfluous node disconnected log messages

[ https://issues.apache.org/jira/browse/KAFKA-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725882#comment-17725882 ] Ondrej Cervinka commented on KAFKA-13679: - Just adding some observations as I am

[jira] [Updated] (KAFKA-15010) KRaft Controller doesn't reconcile with Zookeeper metadata upon becoming new controller while in dual write mode.

[ https://issues.apache.org/jira/browse/KAFKA-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15010: - Affects Version/s: 3.5.0 > KRaft Controller doesn't reconcile with Zookeeper metadata upon becom

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204535515 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -0,0 +1,2017 @@ +/* + * Licensed to the Apache Software Found

[jira] [Updated] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-14996: - Affects Version/s: 3.5.0 Priority: Blocker (was: Critical) > CreateTopic falis wit

[jira] [Updated] (KAFKA-14996) The KRaft controller should properly handle overly large user operations

[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-14996: - Summary: The KRaft controller should properly handle overly large user operations (was: CreateT

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204538473 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -0,0 +1,2017 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] gharris1727 commented on pull request #13748: [BUGFIX] Bugfixed in KAFKA-8713, but it doesn't work properly.

gharris1727 commented on PR #13748: URL: https://github.com/apache/kafka/pull/13748#issuecomment-1561666475 @krespo It looks like the `replace.null.with.default` feature of the JsonConverter is [due to be released in 3.5.0](https://cwiki.apache.org/confluence/display/KAFKA/KIP-581%3A+Value+

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204556978 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -0,0 +1,2017 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204564082 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -0,0 +1,500 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204579244 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -0,0 +1,500 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204582235 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -0,0 +1,500 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jeffkbkim commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204467377 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,633 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204591900 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -0,0 +1,500 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204594741 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -0,0 +1,500 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204594741 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -0,0 +1,500 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204597635 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -0,0 +1,500 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1204599222 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -0,0 +1,500 @@ +/* + * Licensed to the Apache Software Foun

  1   2   >