dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1203578132
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation (
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1203601651
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation (
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1203610206
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation (
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1203610761
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation (
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1203611994
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation (
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1203615232
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation (
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1203623275
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,635 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725672#comment-17725672
]
Viktor Somogyi-Vass commented on KAFKA-12384:
-
Found another one in
https:/
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1203625806
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,635 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1203627084
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -0,0 +1,2017 @@
+/*
+ * Licensed to the Apache Software Foundat
showuon commented on code in PR #13747:
URL: https://github.com/apache/kafka/pull/13747#discussion_r1203646848
##
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##
@@ -192,7 +192,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
killBroker(fir
showuon commented on code in PR #13747:
URL: https://github.com/apache/kafka/pull/13747#discussion_r1203646848
##
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##
@@ -192,7 +192,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
killBroker(fir
dajac commented on code in PR #13747:
URL: https://github.com/apache/kafka/pull/13747#discussion_r1203652500
##
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##
@@ -192,7 +192,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
killBroker(first
dajac commented on PR #13747:
URL: https://github.com/apache/kafka/pull/13747#issuecomment-1560644863
@showuon Thanks for your review. Yes, your understanding is correct. This
check never worked in fact. The part which is not clear is that this test fails
all the time since we merged https:
dajac commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1203664360
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1121,21 +1154,69 @@ class ReplicaManager(val config: KafkaConfig,
partition.legacyFetchOffsetsForTim
dajac commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1203666314
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1335,6 +1433,50 @@ class ReplicaManager(val config: KafkaConfig,
result
}
+ private def handle
dajac commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1203673361
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1335,6 +1433,50 @@ class ReplicaManager(val config: KafkaConfig,
result
}
+ private def handle
mimaison commented on PR #13749:
URL: https://github.com/apache/kafka/pull/13749#issuecomment-1560670729
@divijvaidya My understanding is that we only have to include licenses for
packages included in the binary distribution. bcpkix is only used for test and
not part of the Kafka distributi
dajac merged PR #13747:
URL: https://github.com/apache/kafka/pull/13747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
divijvaidya commented on PR #13749:
URL: https://github.com/apache/kafka/pull/13749#issuecomment-1560672306
> @divijvaidya My understanding is that we only have to include licenses for
packages included in the binary distribution. bcpkix is only used for test and
not part of the Kafka distr
divijvaidya commented on PR #13746:
URL: https://github.com/apache/kafka/pull/13746#issuecomment-1560684188
Hey @sanjanagoyal
Thank you for your first contribution to the project.
1. Would you please add a unit test that fails prior to this change and
succeeds afterwards? Apart f
[
https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725703#comment-17725703
]
Viktor Somogyi-Vass commented on KAFKA-12384:
-
[~satish.duggana] I checked o
dengziming commented on PR #13679:
URL: https://github.com/apache/kafka/pull/13679#issuecomment-1560714746
@KarboniteKream Thank you for reporting this, I'm trying to reproduce your
case locally but failed, do you mean that this problem only occur after the
leader is shut down and restarted
yashmayya commented on code in PR #13465:
URL: https://github.com/apache/kafka/pull/13465#discussion_r1203576413
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1528,6 +1539,80 @@ public void connectorOffsets(String co
viktorsomogyi merged PR #11565:
URL: https://github.com/apache/kafka/pull/11565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
viktorsomogyi commented on PR #11565:
URL: https://github.com/apache/kafka/pull/11565#issuecomment-1560730693
Thank you @akatona84 for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
KarboniteKream commented on PR #13679:
URL: https://github.com/apache/kafka/pull/13679#issuecomment-1560737054
Correct, the issue happens after shutting down and restarting the leader.
Here's the example configuration:
-
[`1.properties`](https://gist.github.com/KarboniteKream/6ec03
divijvaidya commented on code in PR #13742:
URL: https://github.com/apache/kafka/pull/13742#discussion_r1203739372
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -160,6 +161,14 @@
* the controller can fully initialize.
*/
public final cla
[
https://issues.apache.org/jira/browse/KAFKA-13504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass updated KAFKA-13504:
Description:
In case the Kafka Broker cluster and the Kafka Connect cluster is sta
divijvaidya commented on PR #13676:
URL: https://github.com/apache/kafka/pull/13676#issuecomment-1560747003
The next step here is to get attention of a committer to look into this PR.
Usually @ijuma is interested in reviewing build related improvements. Or
perhaps @mimaison may be intereste
akatona84 commented on code in PR #13733:
URL: https://github.com/apache/kafka/pull/13733#discussion_r1203763926
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java:
##
@@ -22,6 +22,7 @@
import org.junit.rules.TemporaryFold
[
https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725712#comment-17725712
]
Klemen Košir commented on KAFKA-14996:
--
The {{getFinalizedFeatures}} regression (an
[
https://issues.apache.org/jira/browse/KAFKA-15018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725713#comment-17725713
]
Yash Mayya commented on KAFKA-15018:
Thanks for filing this bug ticket [~ChrisEgerto
HurSungYun opened a new pull request, #13752:
URL: https://github.com/apache/kafka/pull/13752
https://github.com/apache/kafka/assets/8033896/40d112b0-6d6f-4441-b82c-72909be6c157";>
Fix typo in ConnectorConfig.java documentation adding a whitespace.
### Committer Checklist (e
divijvaidya commented on code in PR #13703:
URL: https://github.com/apache/kafka/pull/13703#discussion_r1203778428
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -473,8 +488,8 @@ public void replay(PartitionChangeRecord record) {
[
https://issues.apache.org/jira/browse/KAFKA-14952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-14952:
---
Labels: connect connect-api kip-required (was: connect connect-api)
> Publish metrics when source c
divijvaidya commented on PR #13680:
URL: https://github.com/apache/kafka/pull/13680#issuecomment-1560795936
@CalvinConfluent thoughts on this one? I am not very much familiar with
difference between taggedVersions and versions field and am looking forward to
understand the difference.
--
[
https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725722#comment-17725722
]
Yash Mayya commented on KAFKA-14995:
[~dajac] that GitHub team isn't publicly access
divijvaidya commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1560847517
Apologies about the delay in reviewing this. I need another week to look
into this part of the code base.
--
This is an automated message from the Apache Git Service.
To respond to
divijvaidya commented on PR #9256:
URL: https://github.com/apache/kafka/pull/9256#issuecomment-1560889897
We are currently running gradle v8 and these warning have been fixed since
this PR was opened. I am closing this PR. Please feel free to re-open if you
still observe these deprecation w
divijvaidya closed pull request #9256: Fix some Gradle deprecation warnings
URL: https://github.com/apache/kafka/pull/9256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
[
https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725761#comment-17725761
]
Viktor Somogyi-Vass commented on KAFKA-12384:
-
Ok, [~dajac] got to it sooner
[
https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass resolved KAFKA-12384.
-
Fix Version/s: 3.6.0
Resolution: Fixed
> Flaky Test ListOffsetsRequestTes
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1203965540
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -129,16 +150,19 @@
import static org.junit.jupiter.api.Asser
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1203992806
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb
urbandan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1204028973
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -626,12 +704,14 @@ public synchronized void
maybeTransitionToError
divijvaidya commented on code in PR #13703:
URL: https://github.com/apache/kafka/pull/13703#discussion_r1204039964
##
metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java:
##
@@ -64,12 +66,44 @@
* completed, which is another reason the prepare / complete c
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204079800
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204087015
##
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##
@@ -489,24 +489,23 @@ class AuthorizerIntegrationTest extends BaseRequestTest {
}
dajac opened a new pull request, #13753:
URL: https://github.com/apache/kafka/pull/13753
I just had a case where this would have been useful so adding it.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
clayburn commented on PR #13676:
URL: https://github.com/apache/kafka/pull/13676#issuecomment-1561117359
The test failures appear to come from these two test cases across the
following JDKs:
* JDK 8: https://ge.apache.org/s/7zk5qyab6i54u/tests/overview?outcome=failed
* JDK 11: https://
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204151150
##
core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala:
##
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204162396
##
core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala:
##
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
divijvaidya commented on code in PR #13753:
URL: https://github.com/apache/kafka/pull/13753#discussion_r1204246878
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -726,7 +726,7 @@ class Partition(val topicPartition: TopicPartition,
s"with partition epoch $
dajac commented on code in PR #13753:
URL: https://github.com/apache/kafka/pull/13753#discussion_r1204298139
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -726,7 +726,7 @@ class Partition(val topicPartition: TopicPartition,
s"with partition epoch ${parti
divijvaidya commented on code in PR #13753:
URL: https://github.com/apache/kafka/pull/13753#discussion_r1204309801
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -726,7 +726,7 @@ class Partition(val topicPartition: TopicPartition,
s"with partition epoch $
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204312762
##
core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala:
##
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
C0urante commented on code in PR #13165:
URL: https://github.com/apache/kafka/pull/13165#discussion_r1204336495
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/LoaderSwap.java:
##
@@ -24,13 +24,32 @@ public class LoaderSwap implements AutoCloseable {
C0urante commented on code in PR #13165:
URL: https://github.com/apache/kafka/pull/13165#discussion_r1204337446
##
connect/runtime/src/main/java/org/apache/kafka/connect/cli/AbstractConnectCli.java:
##
@@ -119,36 +120,37 @@ public Connect startConnect(Map
workerProps, String...
C0urante commented on PR #13165:
URL: https://github.com/apache/kafka/pull/13165#issuecomment-1561331016
That's a good point about the static initialization taking place directly
before the constructor right now, but it's possible that other logic either
directly from the Connect framework
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204356253
##
core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala:
##
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204361177
##
core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala:
##
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204376110
##
core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala:
##
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
dajac opened a new pull request, #13754:
URL: https://github.com/apache/kafka/pull/13754
This test fails regularly in CI
([example](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13753/1/tests)).
This is an attempt to stabilize it.
### Committer Ch
[
https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725858#comment-17725858
]
Edoardo Comar commented on KAFKA-14996:
---
I found another way to get into the error
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204403475
##
core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala:
##
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
mimaison merged PR #13749:
URL: https://github.com/apache/kafka/pull/13749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-15016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-15016.
Fix Version/s: 3.6.0
Resolution: Fixed
> LICENSE-binary file contains dependencies
divijvaidya commented on PR #13135:
URL: https://github.com/apache/kafka/pull/13135#issuecomment-1561407539
Failing tests are unrelated:
```
Build / JDK 11 and Scala 2.13 / [1] quorum=kraft, isIdempotenceEnabled=true
– kafka.api.SaslPlainSslEndToEndAuthorizationTest
14s
Build / J
vamossagar12 opened a new pull request, #13755:
URL: https://github.com/apache/kafka/pull/13755
Renaming filed commitableRecords to committableRecords in
ExactlyOnceWorkerSourceTask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
ijuma commented on code in PR #13676:
URL: https://github.com/apache/kafka/pull/13676#discussion_r120291
##
build.gradle:
##
@@ -39,7 +39,6 @@ plugins {
id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.8"
id "com.github.spotbugs" version '5.0.13' apply fals
yashmayya commented on code in PR #13750:
URL: https://github.com/apache/kafka/pull/13750#discussion_r1204446383
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1104,7 +1104,9 @@ public void stopConnector(final String
yashmayya commented on code in PR #13750:
URL: https://github.com/apache/kafka/pull/13750#discussion_r1204446383
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1104,7 +1104,9 @@ public void stopConnector(final String
gharris1727 commented on code in PR #13165:
URL: https://github.com/apache/kafka/pull/13165#discussion_r1204482479
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/LoaderSwap.java:
##
@@ -24,13 +24,32 @@ public class LoaderSwap implements AutoCloseable
Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1204079800
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb
clayburn commented on code in PR #13676:
URL: https://github.com/apache/kafka/pull/13676#discussion_r1204490523
##
build.gradle:
##
@@ -39,7 +39,6 @@ plugins {
id "io.swagger.core.v3.swagger-gradle-plugin" version "2.2.8"
id "com.github.spotbugs" version '5.0.13' apply f
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204492401
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204493167
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204494016
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation
gharris1727 commented on PR #13165:
URL: https://github.com/apache/kafka/pull/13165#issuecomment-1561615543
@C0urante I added a static list to all of the Sampling plugins that allow us
to inspect the classloader used for all method calls to all instances of each
plugin type. This should now
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204522037
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation (
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204523103
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation (
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204523524
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,859 @@
+/*
+ * Licensed to the Apache Software Foundation (
[
https://issues.apache.org/jira/browse/KAFKA-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725882#comment-17725882
]
Ondrej Cervinka commented on KAFKA-13679:
-
Just adding some observations as I am
[
https://issues.apache.org/jira/browse/KAFKA-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-15010:
-
Affects Version/s: 3.5.0
> KRaft Controller doesn't reconcile with Zookeeper metadata upon becom
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204535515
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -0,0 +1,2017 @@
+/*
+ * Licensed to the Apache Software Found
[
https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-14996:
-
Affects Version/s: 3.5.0
Priority: Blocker (was: Critical)
> CreateTopic falis wit
[
https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-14996:
-
Summary: The KRaft controller should properly handle overly large user
operations (was: CreateT
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204538473
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -0,0 +1,2017 @@
+/*
+ * Licensed to the Apache Software Found
gharris1727 commented on PR #13748:
URL: https://github.com/apache/kafka/pull/13748#issuecomment-1561666475
@krespo It looks like the `replace.null.with.default` feature of the
JsonConverter is [due to be released in
3.5.0](https://cwiki.apache.org/confluence/display/KAFKA/KIP-581%3A+Value+
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204556978
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -0,0 +1,2017 @@
+/*
+ * Licensed to the Apache Software Found
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204564082
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -0,0 +1,500 @@
+/*
+ * Licensed to the Apache Software Foun
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204579244
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -0,0 +1,500 @@
+/*
+ * Licensed to the Apache Software Foun
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204582235
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -0,0 +1,500 @@
+/*
+ * Licensed to the Apache Software Foun
jeffkbkim commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204467377
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,633 @@
+/*
+ * Licensed to the Apache Software Founda
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204591900
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -0,0 +1,500 @@
+/*
+ * Licensed to the Apache Software Foun
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204594741
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -0,0 +1,500 @@
+/*
+ * Licensed to the Apache Software Foun
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204594741
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -0,0 +1,500 @@
+/*
+ * Licensed to the Apache Software Foun
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204597635
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -0,0 +1,500 @@
+/*
+ * Licensed to the Apache Software Foun
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1204599222
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -0,0 +1,500 @@
+/*
+ * Licensed to the Apache Software Foun
1 - 100 of 141 matches
Mail list logo