[jira] [Commented] (KAFKA-13508) Introduction of "-head" flag for describe tool for broker

[ https://issues.apache.org/jira/browse/KAFKA-13508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741243#comment-17741243 ] Yi-Sheng Lien commented on KAFKA-13508: --- Hi [~suyashtava] , do you mind if I do this Jira? If ok,

[GitHub] [kafka] dajac commented on a diff in pull request #13976: MINOR: Check for thread leak at the end of @AfterEach, not at beginning

dajac commented on code in PR #13976: URL: https://github.com/apache/kafka/pull/13976#discussion_r1256903064 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -113,10 +113,11 @@ class ReplicaManagerTest { @AfterEach def tearDown(): Unit = { //

[GitHub] [kafka] junrao commented on pull request #1864: KAFKA-4177: Remove ThrottledReplicationRateLimit from Server Config

junrao commented on PR #1864: URL: https://github.com/apache/kafka/pull/1864#issuecomment-1626345380 @nkostoulas : My vague recollection is that for ThrottledReplicationRateLimit to take effect, we need to set

[GitHub] [kafka] junrao commented on pull request #13797: KAFKA-14950: implement assign() and assignment()

junrao commented on PR #13797: URL: https://github.com/apache/kafka/pull/13797#issuecomment-1626335594 @philipnee Was the following comment addressed? Kirk mentioned to take a closer look. https://github.com/apache/kafka/pull/13797#discussion_r1222086968 -- This is an automated

[GitHub] [kafka] jolshan commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

jolshan commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1256502612 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -578,7 +578,7 @@ class Partition(val topicPartition: TopicPartition, // Returns a verification guard

[GitHub] [kafka] cmccabe merged pull request #13940: MINOR: some minor shell fixes and improvements

cmccabe merged PR #13940: URL: https://github.com/apache/kafka/pull/13940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13945: KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector

gharris1727 commented on code in PR #13945: URL: https://github.com/apache/kafka/pull/13945#discussion_r1256448988 ## connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java: ## @@ -101,4 +105,40 @@ public ExactlyOnceSupport

[jira] [Created] (KAFKA-15164) Extract reusable logic from OffsetsForLeaderEpochClient

Lianet Magrans created KAFKA-15164: -- Summary: Extract reusable logic from OffsetsForLeaderEpochClient Key: KAFKA-15164 URL: https://issues.apache.org/jira/browse/KAFKA-15164 Project: Kafka

[jira] [Assigned] (KAFKA-15164) Extract reusable logic from OffsetsForLeaderEpochClient

[ https://issues.apache.org/jira/browse/KAFKA-15164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-15164: -- Assignee: Lianet Magrans > Extract reusable logic from OffsetsForLeaderEpochClient >

[GitHub] [kafka] mumrah opened a new pull request, #13978: MINOR Move some things around in KRaftMigrationDriver

mumrah opened a new pull request, #13978: URL: https://github.com/apache/kafka/pull/13978 Reorder some of the methods and events in this class to match the expected flow of the migration. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] dajac commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

dajac commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1256431266 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,133 @@ boolean

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jeffkbkim commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1256409668 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,133 @@ boolean

[GitHub] [kafka] dajac merged pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

dajac merged PR #13961: URL: https://github.com/apache/kafka/pull/13961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14966) Extract reusable logic from OffsetFetcher

[ https://issues.apache.org/jira/browse/KAFKA-14966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-14966: --- Summary: Extract reusable logic from OffsetFetcher (was: Extract reusable common logic

[jira] [Updated] (KAFKA-15163) Implement validatePositions functionality for new KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15163: --- Description: Introduce support for validating positions in the new OffsetsRequestManager.

[jira] [Updated] (KAFKA-15163) Implement validatePositions functionality for new KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-15163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15163: --- Description: Introduce support for validating positions in the new OffsetsRequestManager.

[GitHub] [kafka] gharris1727 opened a new pull request, #13977: KAFKA-15162: Reflectively find plugins in parent ClassLoaders that arent on the classpath

gharris1727 opened a new pull request, #13977: URL: https://github.com/apache/kafka/pull/13977 The ClasspathHelper.forJavaClassPath disregards all intermediate classloaders between the AppClassLoader and the DelegatingClassLoader, when those classloaders may contain plugins.

[jira] [Created] (KAFKA-15163) Implement validatePositions functionality for new KafkaConsumer

Lianet Magrans created KAFKA-15163: -- Summary: Implement validatePositions functionality for new KafkaConsumer Key: KAFKA-15163 URL: https://issues.apache.org/jira/browse/KAFKA-15163 Project: Kafka

[GitHub] [kafka] junrao commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

junrao commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1256287178 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -16,6 +16,9 @@ */ package org.apache.kafka.storage.internals.log;

[GitHub] [kafka] junrao commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

junrao commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1255005974 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -0,0 +1,582 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Created] (KAFKA-15162) Reflective plugin scanning misses plugins which are in parent classloaders but not classpath

Greg Harris created KAFKA-15162: --- Summary: Reflective plugin scanning misses plugins which are in parent classloaders but not classpath Key: KAFKA-15162 URL: https://issues.apache.org/jira/browse/KAFKA-15162

[GitHub] [kafka] eziosudo commented on pull request #13973: KAFKA-15148: Some integration tests are running as unit tests

eziosudo commented on PR #13973: URL: https://github.com/apache/kafka/pull/13973#issuecomment-1625780465 @divijvaidya Hi, can you help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] jeffkbkim commented on pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on PR #13870: URL: https://github.com/apache/kafka/pull/13870#issuecomment-1625762579 @dajac @CalvinConfluent thanks for the review, i have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

artemlivshits commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1256175697 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -578,7 +578,7 @@ class Partition(val topicPartition: TopicPartition, // Returns a verification

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1256163265 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1043,4 +1230,1358 @@ public void

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1256157423 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1043,4 +1230,1358 @@ public void

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741140#comment-17741140 ] ASF GitHub Bot commented on KAFKA-14995: stevenbooke commented on PR #521: URL:

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1256152143 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1043,4 +1230,1358 @@ public void

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13927: KAFKA-10199: Enable state updater by default

wcarlson5 commented on code in PR #13927: URL: https://github.com/apache/kafka/pull/13927#discussion_r1256076934 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1619,7 +1639,14 @@ private List standbyTaskIterable() { }

[GitHub] [kafka] jolshan commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

jolshan commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1256141517 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -578,7 +578,7 @@ class Partition(val topicPartition: TopicPartition, // Returns a verification guard

[GitHub] [kafka] jolshan commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

jolshan commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1256140857 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -793,19 +793,18 @@ private void failBatch( Function recordExceptions,

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1256131904 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,127 @@ boolean

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13936: MINOR: Refactor & cleanup for RemoteIndexCache

divijvaidya commented on code in PR #13936: URL: https://github.com/apache/kafka/pull/13936#discussion_r1256126637 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -100,7 +100,16 @@ public

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1256110776 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1043,4 +1230,1358 @@ public void

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13936: MINOR: Refactor & cleanup for RemoteIndexCache

divijvaidya commented on code in PR #13936: URL: https://github.com/apache/kafka/pull/13936#discussion_r1256109183 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -100,7 +100,16 @@ public

[GitHub] [kafka] dajac commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

dajac commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1256105702 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,127 @@ boolean

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1256096167 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,127 @@ boolean

[GitHub] [kafka] dajac commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

dajac commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1256092728 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,127 @@ boolean

[jira] [Commented] (KAFKA-15137) Don't log the entire request in KRaftControllerChannelManager

[ https://issues.apache.org/jira/browse/KAFKA-15137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741123#comment-17741123 ] Alyssa Huang commented on KAFKA-15137: -- I'll do this in the next few days! > Don't log the entire

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1256084088 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -893,4 +1041,250 @@ public void

[GitHub] [kafka] satishd commented on a diff in pull request #13936: MINOR: Refactor & cleanup for RemoteIndexCache

satishd commented on code in PR #13936: URL: https://github.com/apache/kafka/pull/13936#discussion_r1256079424 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -100,7 +100,16 @@ public

[GitHub] [kafka] jolshan commented on a diff in pull request #13961: KAFKA-14462; [21/N] Add CoordinatorTimer implementation in CoordinatorRuntime

jolshan commented on code in PR #13961: URL: https://github.com/apache/kafka/pull/13961#discussion_r1256075348 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -190,6 +216,127 @@ boolean

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1256069184 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -150,19 +215,39 @@ GroupMetadataManager build() {

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1256056130 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -266,9 +285,31 @@ public CompletableFuture joinGroup(

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1256037213 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1087,1362 @@ public void replay(

[GitHub] [kafka] DL1231 commented on a diff in pull request #13970: KAFKA-15157: Print startup time for RemoteIndexCache

DL1231 commented on code in PR #13970: URL: https://github.com/apache/kafka/pull/13970#discussion_r1256028383 ## core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala: ## @@ -178,6 +178,7 @@ class RemoteIndexCache(maxSize: Int = 1024, remoteStorageManager: RemoteStorageM

[GitHub] [kafka] divijvaidya commented on pull request #13976: MINOR: Check for thread leak at the end of @AfterEach, not at beginning

divijvaidya commented on PR #13976: URL: https://github.com/apache/kafka/pull/13976#issuecomment-1625584575 @jolshan since you reviewed #13868, would you also kindle review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] divijvaidya commented on pull request #13956: MINOR: Remove thread leak from ConsumerBounceTest

divijvaidya commented on PR #13956: URL: https://github.com/apache/kafka/pull/13956#issuecomment-1625580951 @jolshan would you like to take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-15137) Don't log the entire request in KRaftControllerChannelManager

[ https://issues.apache.org/jira/browse/KAFKA-15137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741086#comment-17741086 ] Divij Vaidya commented on KAFKA-15137: -- Hey [~alyssahuang]  We are planning a release for 3.5.1

[jira] [Updated] (KAFKA-14705) Tools cleanup for the next major release

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Description: We can use this task to track tools cleanup for the next major release

[jira] [Updated] (KAFKA-14705) Tools cleanup for the next major release

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Summary: Tools cleanup for the next major release (was: Remove tools redirections and

[jira] [Updated] (KAFKA-14705) Remove tools redirections and deprecations

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Description: We can use this task to track cleanup actions for the next major release

[jira] [Updated] (KAFKA-14705) Remove tools redirections and deprecations

[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14705: Description: We can use this task to track cleanup actions for the next major release

[GitHub] [kafka] fvaleri commented on a diff in pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

fvaleri commented on code in PR #13417: URL: https://github.com/apache/kafka/pull/13417#discussion_r1255759422 ## tools/src/main/java/org/apache/kafka/tools/StorageTool.java: ## @@ -0,0 +1,309 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] viktorsomogyi commented on pull request #13975: KAFKA-15161: Fix InvalidReplicationFactorException at connect startup

viktorsomogyi commented on PR #13975: URL: https://github.com/apache/kafka/pull/13975#issuecomment-1625537914 @cmccabe @mumrah would you please review it too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13970: KAFKA-15157: Print startup time for RemoteIndexCache

divijvaidya commented on code in PR #13970: URL: https://github.com/apache/kafka/pull/13970#discussion_r1254621897 ## core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala: ## @@ -178,6 +178,7 @@ class RemoteIndexCache(maxSize: Int = 1024, remoteStorageManager:

[GitHub] [kafka] divijvaidya commented on pull request #13970: KAFKA-15157: Print startup time for RemoteIndexCache

divijvaidya commented on PR #13970: URL: https://github.com/apache/kafka/pull/13970#issuecomment-1625531583 @satishd FYI, this is also a candidate to be incorporated into https://github.com/apache/kafka/pull/13275 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] divijvaidya merged pull request #13972: MINOR: Fix one typo in StreamsBuilder javadoc

divijvaidya merged PR #13972: URL: https://github.com/apache/kafka/pull/13972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] viktorsomogyi commented on pull request #13975: KAFKA-15161: Fix InvalidReplicationFactorException at connect startup

viktorsomogyi commented on PR #13975: URL: https://github.com/apache/kafka/pull/13975#issuecomment-1625509630 @urbandan would you please review it as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] viktorsomogyi opened a new pull request, #13975: KAFKA-15161: Fix InvalidReplicationFactorException at connect startup

viktorsomogyi opened a new pull request, #13975: URL: https://github.com/apache/kafka/pull/13975 In certain very specific cases a constellation can occur when Connect isn't able to get topic metadata when the brokers are being in a rolling restart. To make both the broker and the

[jira] [Resolved] (KAFKA-15149) Fix not sending UMR and LISR RPCs in dual-write mode when there are new partitions

[ https://issues.apache.org/jira/browse/KAFKA-15149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant resolved KAFKA-15149. -- Resolution: Fixed > Fix not sending UMR and LISR RPCs in dual-write mode when there are new

[GitHub] [kafka] dajac commented on pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on PR #13870: URL: https://github.com/apache/kafka/pull/13870#issuecomment-1625488949 There are issues with the build as well. Could you look into this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mumrah merged pull request #13968: KAFKA-15149: Fix not sending UMR and LISR RPCs in dual-write mode when there are new partitions

mumrah merged PR #13968: URL: https://github.com/apache/kafka/pull/13968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15161) InvalidReplicationFactorException at connect startup

[ https://issues.apache.org/jira/browse/KAFKA-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-15161: Description: h2. Problem description In our system test environment in certain

[jira] [Commented] (KAFKA-14995) Automate asf.yaml collaborators refresh

[ https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741039#comment-17741039 ] ASF GitHub Bot commented on KAFKA-14995: mimaison commented on PR #521: URL:

[GitHub] [kafka] Purely-Jonas commented on pull request #13865: KAFKA-15096: Update snappy-java to 1.1.10.1

Purely-Jonas commented on PR #13865: URL: https://github.com/apache/kafka/pull/13865#issuecomment-1625415319 Just voicing our want - at Dixa - for a 3.4.x version release. Thank you for all the great work you put into this! -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1255784243 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -578,7 +578,7 @@ class Partition(val topicPartition: TopicPartition, // Returns a verification guard

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1255783931 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -578,7 +578,7 @@ class Partition(val topicPartition: TopicPartition, // Returns a verification guard

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1255779604 ## server-common/src/main/java/org/apache/kafka/server/util/InterBrokerSendThread.java: ## @@ -118,6 +118,11 @@ protected void pollOnce(long maxTimeoutMs) {

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1255778900 ## server-common/src/main/java/org/apache/kafka/server/util/InterBrokerSendThread.java: ## @@ -118,6 +118,11 @@ protected void pollOnce(long maxTimeoutMs) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13936: MINOR: Refactor & cleanup for RemoteIndexCache

divijvaidya commented on code in PR #13936: URL: https://github.com/apache/kafka/pull/13936#discussion_r1255777691 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -100,7 +100,16 @@ public

[jira] [Updated] (KAFKA-15161) InvalidReplicationFactorException at connect startup

[ https://issues.apache.org/jira/browse/KAFKA-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-15161: Description: h2. Problem description In our system test environment in certain

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1255775822 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -793,19 +793,18 @@ private void failBatch( Function recordExceptions,

[GitHub] [kafka] aneelkkhatri commented on pull request #13972: MINOR: Fix one typo in StreamsBuilder javadoc

aneelkkhatri commented on PR #13972: URL: https://github.com/apache/kafka/pull/13972#issuecomment-1625358965 > Hey @aneelkkhatri Thank you for your first contribution to Apache Kafka! Since this is the first time, I would take this opportunity to suggest you to read the contributing

[jira] [Updated] (KAFKA-15161) InvalidReplicationFactorException at connect startup

[ https://issues.apache.org/jira/browse/KAFKA-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-15161: Description: h2. Problem description In our system test environment in certain

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

divijvaidya commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1255757382 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -16,6 +16,9 @@ */ package org.apache.kafka.storage.internals.log;

[GitHub] [kafka] jeqo commented on a diff in pull request #13936: MINOR: Refactor & cleanup for RemoteIndexCache

jeqo commented on code in PR #13936: URL: https://github.com/apache/kafka/pull/13936#discussion_r1255748772 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -100,7 +100,16 @@ public

[jira] [Assigned] (KAFKA-14581) Move GetOffsetShell to tools

[ https://issues.apache.org/jira/browse/KAFKA-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-14581: - Assignee: Ruslan Krivoshein > Move GetOffsetShell to tools > > >

[jira] [Commented] (KAFKA-15094) Add RemoteIndexCache metrics like misses/evictions/load-failures.

[ https://issues.apache.org/jira/browse/KAFKA-15094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740997#comment-17740997 ] Divij Vaidya commented on KAFKA-15094: -- [https://github.com/ben-manes/caffeine/wiki/Statistics]

[jira] [Updated] (KAFKA-15161) InvalidReplicationFactorException at connect startup

[ https://issues.apache.org/jira/browse/KAFKA-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-15161: Attachment: empty_metadata.patch > InvalidReplicationFactorException at connect

[jira] [Updated] (KAFKA-15161) InvalidReplicationFactorException at connect startup

[ https://issues.apache.org/jira/browse/KAFKA-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-15161: Issue Type: Bug (was: Improvement) > InvalidReplicationFactorException at

[jira] [Updated] (KAFKA-15161) InvalidReplicationFactorException at connect startup

[ https://issues.apache.org/jira/browse/KAFKA-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-15161: Description: h2. Problem description In our system test environment in certain

[jira] [Assigned] (KAFKA-15161) InvalidReplicationFactorException at connect startup

[ https://issues.apache.org/jira/browse/KAFKA-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass reassigned KAFKA-15161: --- Assignee: Viktor Somogyi-Vass > InvalidReplicationFactorException at

[jira] [Created] (KAFKA-15161) InvalidReplicationFactorException at connect startup

Viktor Somogyi-Vass created KAFKA-15161: --- Summary: InvalidReplicationFactorException at connect startup Key: KAFKA-15161 URL: https://issues.apache.org/jira/browse/KAFKA-15161 Project: Kafka

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13936: MINOR: Refactor & cleanup for RemoteIndexCache

divijvaidya commented on code in PR #13936: URL: https://github.com/apache/kafka/pull/13936#discussion_r1255713117 ## core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala: ## @@ -38,7 +38,60 @@ import java.util.concurrent.locks.ReentrantReadWriteLock object

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13955: KAFKA-15145: Don't re-process records filtered out by SMTs on Kafka client retriable exceptions in AbstractWorkerSourceTask

vamossagar12 commented on code in PR #13955: URL: https://github.com/apache/kafka/pull/13955#discussion_r1255698936 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java: ## @@ -651,6 +652,40 @@ public void

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1255692148 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,8 +284,60 @@ public Future set(Map values,

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1255690496 ## checkstyle/suppressions.xml: ## @@ -154,7 +154,7 @@ files="(KafkaConfigBackingStore|Values|ConnectMetricsRegistry).java"/> +

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1255687711 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,8 +284,60 @@ public Future set(Map values,

[GitHub] [kafka] cxorm commented on pull request #13974: KAFKA-15155: Follow PEP 8 best practice in Python to check if a container is empty

cxorm commented on PR #13974: URL: https://github.com/apache/kafka/pull/13974#issuecomment-1625237314 > Please feel to fix it in this PR. Fixed all places related to this Jira, Would you be so kind as to take a look at this PR if you have time? -- This is an automated message

[GitHub] [kafka] satishd commented on a diff in pull request #13936: MINOR: Refactor & cleanup for RemoteIndexCache

satishd commented on code in PR #13936: URL: https://github.com/apache/kafka/pull/13936#discussion_r1255603306 ## core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala: ## @@ -38,7 +38,60 @@ import java.util.concurrent.locks.ReentrantReadWriteLock object RemoteIndexCache

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1255510339 ## tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java: ## @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] hudeqi commented on pull request #13946: KAFKA-15139:Optimize the performance of `Set.removeAll(List)` in `MirrorCheckpointConnector`

hudeqi commented on PR #13946: URL: https://github.com/apache/kafka/pull/13946#issuecomment-1625191011 and this, thanks. @C0urante -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] hudeqi commented on pull request #13913: KAFKA-15119:Support incremental syncTopicAcls in MirrorSourceConnector

hudeqi commented on PR #13913: URL: https://github.com/apache/kafka/pull/13913#issuecomment-1625189960 pin again @C0urante -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] fvaleri commented on pull request #13214: KAFKA-14577: Move the scala ConsoleProducer from core to tools module

fvaleri commented on PR #13214: URL: https://github.com/apache/kafka/pull/13214#issuecomment-1625147370 Hi @Hangleton, what's the state of this PR? Let me know if you need some help/review. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-14576) Move ConsoleConsumer to tools

[ https://issues.apache.org/jira/browse/KAFKA-14576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740959#comment-17740959 ] Federico Valeri commented on KAFKA-14576: - [~christo_lolov] I see this is in progress. Do you

[GitHub] [kafka] yashmayya commented on a diff in pull request #13955: KAFKA-15145: Don't re-process records filtered out by SMTs on Kafka client retriable exceptions in AbstractWorkerSourceTask

yashmayya commented on code in PR #13955: URL: https://github.com/apache/kafka/pull/13955#discussion_r1255540020 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java: ## @@ -651,6 +652,40 @@ public void

[jira] [Updated] (KAFKA-14647) Move TopicFilter shared class

[ https://issues.apache.org/jira/browse/KAFKA-14647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14647: Fix Version/s: 3.6.0 > Move TopicFilter shared class > - > >

[jira] [Updated] (KAFKA-14581) Move GetOffsetShell to tools

[ https://issues.apache.org/jira/browse/KAFKA-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14581: Fix Version/s: 3.6.0 > Move GetOffsetShell to tools > > >

[GitHub] [kafka] yashmayya commented on a diff in pull request #13955: KAFKA-15145: Don't re-process records filtered out by SMTs on Kafka client retriable exceptions in AbstractWorkerSourceTask

yashmayya commented on code in PR #13955: URL: https://github.com/apache/kafka/pull/13955#discussion_r1255540020 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTaskTest.java: ## @@ -651,6 +652,40 @@ public void

  1   2   >