[GitHub] [kafka] yashmayya commented on a diff in pull request #14153: KAFKA-14132: Replace Easymock & Powermock with Mockito in KafkaBasedLogTest

yashmayya commented on code in PR #14153: URL: https://github.com/apache/kafka/pull/14153#discussion_r1288307819 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -114,29 +113,49 @@ public class KafkaBasedLogTest { private static

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1288298071 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC

[jira] [Commented] (KAFKA-15309) Add custom error handler to Producer

[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752369#comment-17752369 ] Tomonari Yamashita commented on KAFKA-15309: FYI, I've created a simple reproducer. The

[GitHub] [kafka] prestona opened a new pull request, #14173: KAFKA-15042: Improve TAGGED_FIELDS protocol documentation

prestona opened a new pull request, #14173: URL: https://github.com/apache/kafka/pull/14173 - Rename TAG_BUFFER -> TAGGED_FIELDS (for better consistency with KIP-482 and the implementation) - Add TAGGED_FIELDS into "protocol primitive types" section, and improve description - Exclude

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

divijvaidya commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1288285456 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -154,6 +155,92 @@ class KafkaServerTest extends QuorumTestHarness { server.shutdown()

[GitHub] [kafka] yashmayya commented on a diff in pull request #14102: KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest

yashmayya commented on code in PR #14102: URL: https://github.com/apache/kafka/pull/14102#discussion_r1288249581 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3872,7 +2952,7 @@ public void

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

divijvaidya commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1288249161 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1862,7 +1884,35 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1288265653 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC

[GitHub] [kafka] msn-tldr commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

msn-tldr commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1288249340 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -144,13 +159,25 @@ public long metadataExpireMs() { */ public synchronized int

[jira] [Updated] (KAFKA-15309) Add custom error handler to Producer

[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomonari Yamashita updated KAFKA-15309: --- Attachment: app.log KafkaProducerReproducer.java > Add custom error

[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 Move ReassignPartitionsCommand to java

nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1670967558 @mimaison Thanks for review and merge of #14096. I create PR that contains java version of ReassignPartitionsCommand POJOs. Please, take a look - #14172 -- This is an

[GitHub] [kafka] nizhikov opened a new pull request, #14172: KAFKA-14595 Java version of ReassignPartitionsCommand POJOs

nizhikov opened a new pull request, #14172: URL: https://github.com/apache/kafka/pull/14172 This PR part of #13247 and introduces Java version of ReassignPartitionsCommand POJOs ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

[GitHub] [kafka] yashmayya commented on pull request #14166: MINOR: Use Mockito's strict stubs functionality for Connect tests and cleanup unused stubs

yashmayya commented on PR #14166: URL: https://github.com/apache/kafka/pull/14166#issuecomment-1670963634 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] mimaison merged pull request #14166: MINOR: Use Mockito's strict stubs functionality for Connect tests and cleanup unused stubs

mimaison merged PR #14166: URL: https://github.com/apache/kafka/pull/14166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] lucasbru commented on a diff in pull request #14001: Kafka Streams Threading: Punctuation (5/N)

lucasbru commented on code in PR #14001: URL: https://github.com/apache/kafka/pull/14001#discussion_r1288175911 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java: ## @@ -86,12 +87,29 @@ private void runOnce(final long nowMs) {

[GitHub] [kafka] lucasbru commented on a diff in pull request #14001: Kafka Streams Threading: Punctuation (5/N)

lucasbru commented on code in PR #14001: URL: https://github.com/apache/kafka/pull/14001#discussion_r1288175911 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java: ## @@ -86,12 +87,29 @@ private void runOnce(final long nowMs) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

divijvaidya commented on code in PR #14151: URL: https://github.com/apache/kafka/pull/14151#discussion_r1288158470 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -913,6 +969,12 @@ private RemoteLogManagerConfig createRLMConfig(Properties props) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

divijvaidya commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1288145597 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -343,21 +345,78 @@ public void onLeadershipChange(Set partitionsBecomeLeader, /** *

[jira] [Reopened] (KAFKA-14595) Move ReassignPartitionsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reopened KAFKA-14595: > Move ReassignPartitionsCommand to tools > --- > >

[GitHub] [kafka] mimaison merged pull request #14096: KAFKA-14595 AdminUtils rewritten in java

mimaison merged PR #14096: URL: https://github.com/apache/kafka/pull/14096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] lucasbru opened a new pull request, #14171: Kafka Streams Threading: Timeout behavior

lucasbru opened a new pull request, #14171: URL: https://github.com/apache/kafka/pull/14171 Implement setting and clearing task timeouts, as well as changing the output on exceptions to make it similar to the existing code path. This is a stacked PR, only the last commit needs to be

[GitHub] [kafka] aindriu-aiven commented on pull request #14159: Kafka 15291 connect plugins implement versioned

aindriu-aiven commented on PR #14159: URL: https://github.com/apache/kafka/pull/14159#issuecomment-1670825228 Thanks @gharris1727 I think I covered all the points you mentioned there any issues at all though please let me know! -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] ex172000 commented on a diff in pull request #14110: MINOR: Add test for describe topic with ID

ex172000 commented on code in PR #14110: URL: https://github.com/apache/kafka/pull/14110#discussion_r1288017392 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -2354,6 +2354,75 @@ public void testDeleteRecords() throws Exception {

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1287993847 ## core/src/main/scala/kafka/tools/GetOffsetShell.scala: ## Review Comment: > We should still keep this file can forward all args to new GetOffsetShell, see

<    1   2