[GitHub] [kafka] github-actions[bot] commented on pull request #13814: KAFKA-15057: Use new interface from zstd-jni

github-actions[bot] commented on PR #13814: URL: https://github.com/apache/kafka/pull/13814#issuecomment-1712401510 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[GitHub] [kafka] kirktrue commented on pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager

kirktrue commented on PR #14359: URL: https://github.com/apache/kafka/pull/14359#issuecomment-1712393353 Test failures are unrelated: - `kafka.api.ConsumerBounceTest.testClose()` -

[jira] [Updated] (KAFKA-13121) Flaky Test TopicBasedRemoteLogMetadataManagerTest.testNewPartitionUpdates()

[ https://issues.apache.org/jira/browse/KAFKA-13121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13121: -- Labels: flaky-test (was: ) > Flaky Test

[GitHub] [kafka] junrao commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

junrao commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320422049 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ResetPositionsApplicationEvent.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] kirktrue commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

kirktrue commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1320398056 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] kirktrue commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

kirktrue commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320395498 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ResetPositionsApplicationEvent.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] kirktrue closed pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager

kirktrue closed pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager URL: https://github.com/apache/kafka/pull/14359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (KAFKA-15441) Broker sessions can time out during ZK migration

[ https://issues.apache.org/jira/browse/KAFKA-15441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-15441. -- Resolution: Fixed > Broker sessions can time out during ZK migration >

[GitHub] [kafka] junrao commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

junrao commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320355597 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -154,6 +170,52 @@ public CompletableFuture> fetchOffsets(

[GitHub] [kafka] lianetm commented on pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

lianetm commented on PR #14346: URL: https://github.com/apache/kafka/pull/14346#issuecomment-1712218811 Thanks for review @junrao ! All comments addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320338879 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcherUtils.java: ## @@ -315,6 +319,57 @@ void onFailedRequestForResettingPositions(

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320325790 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ResetPositionsApplicationEvent.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320315305 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -209,6 +215,34 @@ public ConsumerRecords poll(final Duration

[GitHub] [kafka] mumrah merged pull request #14351: KAFKA-15441 Allow broker heartbeats to complete in metadata transaction

mumrah merged PR #14351: URL: https://github.com/apache/kafka/pull/14351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] philipnee opened a new pull request, #14362: KAFKA-14960: TopicMetadata request manager

philipnee opened a new pull request, #14362: URL: https://github.com/apache/kafka/pull/14362 This PR implements the request manager that send topic metadata request to the server as a standalone module. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320309330 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcherUtils.java: ## @@ -315,6 +319,57 @@ void onFailedRequestForResettingPositions(

[GitHub] [kafka] mumrah commented on pull request #14351: KAFKA-15441 Allow broker heartbeats to complete in metadata transaction

mumrah commented on PR #14351: URL: https://github.com/apache/kafka/pull/14351#issuecomment-1712172050 Only three flaky tests https://github.com/apache/kafka/assets/55116/72d120ab-5f70-4141-8901-185481c7edee;> -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320289960 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -154,6 +170,48 @@ public CompletableFuture> fetchOffsets(

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320281717 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -154,6 +170,48 @@ public CompletableFuture> fetchOffsets(

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320260135 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -298,6 +356,154 @@ private CompletableFuture

[GitHub] [kafka] kirktrue closed pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager

kirktrue closed pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager URL: https://github.com/apache/kafka/pull/14359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14147: KAFKA-14502; Implement LeaveGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #14147: URL: https://github.com/apache/kafka/pull/14147#discussion_r1320243788 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2930,72 +2930,86 @@ public CoordinatorResult

[GitHub] [kafka] philipnee commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

philipnee commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320241577 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -209,6 +215,34 @@ public ConsumerRecords poll(final Duration

[GitHub] [kafka] junrao commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

junrao commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1320173913 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -68,17 +75,22 @@ public class OffsetsRequestManager implements

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1320220933 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1320220040 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1320217221 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] [kafka] kirktrue commented on pull request #5733: KAFKA-7462: Make token optional for OAuthBearerLoginModule

kirktrue commented on PR #5733: URL: https://github.com/apache/kafka/pull/5733#issuecomment-1712076743 @AntonSmolkov would you mind filing a new Jira to track? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] yashmayya opened a new pull request, #14361: KAFKA-15387: Deprecate Connect's redundant task configurations endpoint

yashmayya opened a new pull request, #14361: URL: https://github.com/apache/kafka/pull/14361 - https://issues.apache.org/jira/browse/KAFKA-15387 - https://cwiki.apache.org/confluence/display/KAFKA/KIP-970%3A+Deprecate+and+remove+Connect%27s+redundant+task+configurations+endpoint -

[GitHub] [kafka] Cerchie opened a new pull request, #14360: KAFKA-15307: update/note deprecated configs

Cerchie opened a new pull request, #14360: URL: https://github.com/apache/kafka/pull/14360 First pass at identifying deprecated configs listed in https://kafka.apache.org/21/documentation/streams/developer-guide/config-streams There might be some discussion to be had regarding what

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1320184381 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] lianetm commented on pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on PR #14323: URL: https://github.com/apache/kafka/pull/14323#issuecomment-171267 Thanks for the feedback @dajac, all comments addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1320145450 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1320085005 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] kirktrue opened a new pull request, #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager

kirktrue opened a new pull request, #14359: URL: https://github.com/apache/kafka/pull/14359 This continues the work of providing the groundwork for the fetch refactoring work by introducing some new classes and refactoring the existing code to use the new classes where applicable.

[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 Move ReassignPartitionsCommand to java

nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1711917145 I created a #14355 to rewrite ReassignPartitionsUnitTest separately. This will reduce changed even move. Please, review. -- This is an automated message from the Apache Git

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1320065640 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1508,16 +1511,153 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1320049614 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1320046439 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1320040698 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] philipnee commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

philipnee commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1320021633 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1320013571 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319972998 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319972998 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319972998 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319944582 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319927882 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Closed] (KAFKA-15418) Update statement on decompression location

[ https://issues.apache.org/jira/browse/KAFKA-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucia Cerchie closed KAFKA-15418. - PR merged https://github.com/apache/kafka/pull/14322 > Update statement on decompression location

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319899063 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] clolov commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

clolov commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1319894215 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1508,16 +1511,153 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] clolov commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

clolov commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1319891533 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1508,16 +1511,153 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1319880229 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1508,16 +1511,153 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1319880229 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1508,16 +1511,153 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319876418 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kamalcph commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

kamalcph commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1319873450 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -179,6 +180,8 @@ public List read() { private final UnifiedLog mockLog =

[jira] [Resolved] (KAFKA-15435) KRaft migration record counts in log message are incorrect

[ https://issues.apache.org/jira/browse/KAFKA-15435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-15435. -- Resolution: Fixed > KRaft migration record counts in log message are incorrect >

[GitHub] [kafka] kamalcph commented on a diff in pull request #14347: KAFKA-15439: Transactions test with tiered storage

kamalcph commented on code in PR #14347: URL: https://github.com/apache/kafka/pull/14347#discussion_r1319865546 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -218,6 +224,8 @@ class TransactionsTest extends IntegrationTestHarness {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14347: KAFKA-15439: Transactions test with tiered storage

kamalcph commented on code in PR #14347: URL: https://github.com/apache/kafka/pull/14347#discussion_r1319863532 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/TransactionsWithTieredStoreTest.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] kamalcph commented on a diff in pull request #14347: KAFKA-15439: Transactions test with tiered storage

kamalcph commented on code in PR #14347: URL: https://github.com/apache/kafka/pull/14347#discussion_r1319864400 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/TransactionsWithTieredStoreTest.java: ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] kamalcph opened a new pull request, #14358: MINOR: Removed the RSM and RLMM classpath config validator

kamalcph opened a new pull request, #14358: URL: https://github.com/apache/kafka/pull/14358 - RSM and RLMM classpath can be empty since it's optional so removed the non-empty string validator - Fix getting the `localTieredStorage` by brokerId after stopping a broker. ###

[GitHub] [kafka] lianetm commented on pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

lianetm commented on PR #14346: URL: https://github.com/apache/kafka/pull/14346#issuecomment-1711652623 Thanks @philipnee! I had missed the reset func when renaming, done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-15411) DelegationTokenEndToEndAuthorizationWithOwnerTest is Flaky

[ https://issues.apache.org/jira/browse/KAFKA-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763086#comment-17763086 ] David Arthur commented on KAFKA-15411: -- The error {code:java} [2023-09-08 11:11:28,426] ERROR

[GitHub] [kafka] satishd commented on a diff in pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

satishd commented on code in PR #14349: URL: https://github.com/apache/kafka/pull/14349#discussion_r1319375686 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -818,56 +818,51 @@ public RemoteLogRetentionHandler(Optional retentionSizeData,

[GitHub] [kafka] hudeqi commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

hudeqi commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319841547 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -594,4 +575,16 @@ class RemoteIndexCacheTest { timeIndex.flush() } } + +

[GitHub] [kafka] dajac commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

dajac commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1319775413 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the

[GitHub] [kafka] mumrah commented on pull request #14351: KAFKA-15441 Allow broker heartbeats to complete in metadata transaction

mumrah commented on PR #14351: URL: https://github.com/apache/kafka/pull/14351#issuecomment-1711608525 I think that's reasonable, @cmccabe. I was looking through usages of `RUNS_IN_PREMIGRATION` and noticed we have it on `rescheduleMaybeFenceStaleBrokers`. I think we should probably remove

[GitHub] [kafka] kevin0x90 commented on pull request #11430: KAFKA-13352: Kafka Client does not support passwords starting with number in jaas config

kevin0x90 commented on PR #11430: URL: https://github.com/apache/kafka/pull/11430#issuecomment-1711570546 Is there any particular reason why this PR is not getting merged or "just" the conflicts that needs to be resolved? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] showuon merged pull request #14350: MINOR: Log when remote fetch execution is rejected

showuon merged PR #14350: URL: https://github.com/apache/kafka/pull/14350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #14350: MINOR: Log when remote fetch execution is rejected

showuon commented on PR #14350: URL: https://github.com/apache/kafka/pull/14350#issuecomment-1711547692 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dajac commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

dajac commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1319725841 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -48,6 +49,16 @@ public String toString() { */ String stateAsString();

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

divijvaidya commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319733428 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -1125,3 +1128,48 @@ class DynamicProducerStateManagerConfig(val producerStateManagerConfig:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14347: KAFKA-15439: Transactions test with tiered storage

divijvaidya commented on code in PR #14347: URL: https://github.com/apache/kafka/pull/14347#discussion_r1319720071 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -218,6 +224,8 @@ class TransactionsTest extends IntegrationTestHarness {

[GitHub] [kafka] dajac commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

dajac commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319705247 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ruslankrivoshein commented on pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

ruslankrivoshein commented on PR #13562: URL: https://github.com/apache/kafka/pull/13562#issuecomment-1711477537 @dengziming, done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] showuon commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

showuon commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319699447 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -594,4 +575,16 @@ class RemoteIndexCacheTest { timeIndex.flush() } } + +

[GitHub] [kafka] hudeqi commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

hudeqi commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319696030 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -171,21 +178,24 @@ class RemoteIndexCacheTest { // Calling getIndex on the same

[GitHub] [kafka] hudeqi commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

hudeqi commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319695234 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -159,9 +159,16 @@ class RemoteIndexCacheTest { @Test def testCacheEntryExpiry():

[jira] [Updated] (KAFKA-15418) Update statement on decompression location

[ https://issues.apache.org/jira/browse/KAFKA-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15418: - Fix Version/s: 3.7.0 (was: 3.5.1) > Update statement on decompression

[GitHub] [kafka] divijvaidya merged pull request #14322: KAFKA-15418: update statement on decompression

divijvaidya merged PR #14322: URL: https://github.com/apache/kafka/pull/14322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] divijvaidya commented on pull request #14322: KAFKA-15418: update statement on decompression

divijvaidya commented on PR #14322: URL: https://github.com/apache/kafka/pull/14322#issuecomment-1711401620 Thank you for reviewing @mjsax. @Cerchie the current state looks good to me, thank you again for improving the docs. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] eaugene commented on pull request #14287: [Minor] Check the existence of AppInfo for the given ID before creating a new mbean of the same name

eaugene commented on PR #14287: URL: https://github.com/apache/kafka/pull/14287#issuecomment-1711400368 > @eaugene , thanks for the fix. Left a comment, also, please add a test for this change. Thanks. @showuon I have added a test case for this . The

[GitHub] [kafka] hudeqi commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

hudeqi commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319642559 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -494,6 +518,19 @@ public boolean isMarkedForCleanup() { return

[GitHub] [kafka] showuon commented on a diff in pull request #14287: [Minor] Check the existence of AppInfo for the given ID before creating a new mbean of the same name

showuon commented on code in PR #14287: URL: https://github.com/apache/kafka/pull/14287#discussion_r1319632459 ## clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java: ## @@ -60,8 +60,13 @@ public static String getCommitId() { public static synchronized

[GitHub] [kafka] showuon commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

showuon commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319631509 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -171,21 +178,24 @@ class RemoteIndexCacheTest { // Calling getIndex on the same

[GitHub] [kafka] showuon commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

showuon commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319625829 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -171,21 +178,24 @@ class RemoteIndexCacheTest { // Calling getIndex on the same

[GitHub] [kafka] hudeqi commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

hudeqi commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319608604 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -125,12 +126,39 @@ public RemoteIndexCache(RemoteStorageManager

[GitHub] [kafka] showuon commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

showuon commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319305787 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -171,21 +178,24 @@ class RemoteIndexCacheTest { // Calling getIndex on the same

[jira] [Commented] (KAFKA-14912) Introduce a configuration for remote index cache size, preferably a dynamic config.

[ https://issues.apache.org/jira/browse/KAFKA-14912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763002#comment-17763002 ] hudeqi commented on KAFKA-14912: Thanks, [~showuon] . The PR corresponding to this issue is currently

[GitHub] [kafka] hudeqi commented on pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

hudeqi commented on PR #14243: URL: https://github.com/apache/kafka/pull/14243#issuecomment-1711358661 > I am yet to look into the part about why we need `@volatile var remoteLogManagerOpt` and why we need to modify tests but leaving some intermediate comments meanwhile. Thanks for

[GitHub] [kafka] eaugene commented on a diff in pull request #14287: [Minor] Check the existence of AppInfo for the given ID before creating a new mbean of the same name

eaugene commented on code in PR #14287: URL: https://github.com/apache/kafka/pull/14287#discussion_r1319598294 ## clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java: ## @@ -60,8 +60,13 @@ public static String getCommitId() { public static synchronized

[jira] [Commented] (KAFKA-15446) Upgrading from 2.0 to 2.8, with replica out of sync exceeding 12 hours

[ https://issues.apache.org/jira/browse/KAFKA-15446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762999#comment-17762999 ] 许胜斌 commented on KAFKA-15446: - now when I restarted node 0, the error is: [2023-09-08 17:04:55,812] ERROR

[GitHub] [kafka] hudeqi commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

hudeqi commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1319582065 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -77,6 +77,7 @@ public class RemoteIndexCache implements Closeable {

[GitHub] [kafka] lucasbru commented on a diff in pull request #14180: KAFKA-15326: [7/N] Processing thread non-busy waiting

lucasbru commented on code in PR #14180: URL: https://github.com/apache/kafka/pull/14180#discussion_r1319560316 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutorTest.java: ## @@ -85,6 +85,16 @@ public void

[GitHub] [kafka] dajac commented on pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

dajac commented on PR #14353: URL: https://github.com/apache/kafka/pull/14353#issuecomment-1711319016 @jolshan @rreddy-22 Thanks for your comments. I have addressed all of them if not mistaken. I have also fixed a few tests and extracted common code into the base class. Please have a

[jira] [Commented] (KAFKA-15446) Upgrading from 2.0 to 2.8, with replica out of sync exceeding 12 hours

[ https://issues.apache.org/jira/browse/KAFKA-15446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762997#comment-17762997 ] 许胜斌 commented on KAFKA-15446: - What should we do now? I have restarted Node1 and Node2, but the problem has

[GitHub] [kafka] dengziming commented on pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

dengziming commented on PR #13562: URL: https://github.com/apache/kafka/pull/13562#issuecomment-1711304414 @ruslankrivoshein Maybe you didn't get my idea, I mean the `WIP` here:  do you

[jira] [Created] (KAFKA-15446) Upgrading from 2.0 to 2.8, with replica out of sync exceeding 12 hours

许胜斌 created KAFKA-15446: --- Summary: Upgrading from 2.0 to 2.8, with replica out of sync exceeding 12 hours Key: KAFKA-15446 URL: https://issues.apache.org/jira/browse/KAFKA-15446 Project: Kafka Issue

[GitHub] [kafka] ruslankrivoshein commented on pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

ruslankrivoshein commented on PR #13562: URL: https://github.com/apache/kafka/pull/13562#issuecomment-1711300123 @dengziming is there any template for this or an example? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dajac commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

dajac commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319554937 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -14,233 +14,532 @@ * See the License for the specific language governing permissions and

[GitHub] [kafka] dengziming commented on pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

dengziming commented on PR #13562: URL: https://github.com/apache/kafka/pull/13562#issuecomment-1711292569 @ruslankrivoshein I mean that you should update the description of this PR, and clarify what you have changed in this PR, then we can merge this if CI pass. -- This is an automated

  1   2   >