[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-25 Thread via GitHub
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1734930832 The failed tests should be this one: `testCleanerWithMessageFormatV0`, which sets the maxMessageSize to 202, and matches the error messages: `Message batch size is 203 bytes in append t

[GitHub] [kafka] showuon opened a new pull request, #14452: [WIP]MINOR: Find test

2023-09-25 Thread via GitHub
showuon opened a new pull request, #14452: URL: https://github.com/apache/kafka/pull/14452 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] omkreddy merged pull request #14445: KAFKA-15502: Update SslEngineValidator to handle large stores

2023-09-25 Thread via GitHub
omkreddy merged PR #14445: URL: https://github.com/apache/kafka/pull/14445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] omkreddy commented on pull request #14445: KAFKA-15502: Update SslEngineValidator to handle large stores

2023-09-25 Thread via GitHub
omkreddy commented on PR #14445: URL: https://github.com/apache/kafka/pull/14445#issuecomment-1734866919 Test failures are not related. Merging trunk and older branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Commented] (KAFKA-15169) Add tests for RemoteIndexCache

2023-09-25 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769006#comment-17769006 ] Arpit Goyal commented on KAFKA-15169: - [~divijvaidya] [~satish.duggana] In the test

[GitHub] [kafka] tombentley commented on a diff in pull request #13862: KAFKA-15050: format the prompts in the quickstart

2023-09-25 Thread via GitHub
tombentley commented on code in PR #13862: URL: https://github.com/apache/kafka/pull/13862#discussion_r1336627061 ## docs/quickstart.html: ## @@ -154,9 +154,9 @@ By default, each line you enter will result in a separate event being written to the topic.

[GitHub] [kafka] ijuma opened a new pull request, #14451: MINOR: Replace Java 20 with Java 21 in `README.md`

2023-09-25 Thread via GitHub
ijuma opened a new pull request, #14451: URL: https://github.com/apache/kafka/pull/14451 I intended to include this in 99e6f12dd099, but somehow missed it. I will wait for KAFKA-15943 before updating the site docs with Java 21 (we never added Java 20 there). ### Committer Check

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2023-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768985#comment-17768985 ] ASF GitHub Bot commented on KAFKA-13882: tombentley commented on PR #410: URL: h

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2023-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768982#comment-17768982 ] ASF GitHub Bot commented on KAFKA-13882: tombentley commented on code in PR #410

[GitHub] [kafka] github-actions[bot] commented on pull request #13852: KAFKA-15086:Set a reasonable segment size upper limit for MM2 internal topics

2023-09-25 Thread via GitHub
github-actions[bot] commented on PR #13852: URL: https://github.com/apache/kafka/pull/13852#issuecomment-1734772707 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[jira] [Updated] (KAFKA-15505) MM2 consumer group subscription different on target cluster

2023-09-25 Thread Srinivas Boga (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srinivas Boga updated KAFKA-15505: -- Description: I am running mirrormaker2 in distributed mode with 3 nodes and 10 tasks each , k

[jira] [Created] (KAFKA-15505) MM2 consumer group subscription different on target cluster

2023-09-25 Thread Srinivas Boga (Jira)
Srinivas Boga created KAFKA-15505: - Summary: MM2 consumer group subscription different on target cluster Key: KAFKA-15505 URL: https://issues.apache.org/jira/browse/KAFKA-15505 Project: Kafka

[GitHub] [kafka] hgeraldino commented on pull request #14093: KAFKA-15248 Add BooleanConverter

2023-09-25 Thread via GitHub
hgeraldino commented on PR #14093: URL: https://github.com/apache/kafka/pull/14093#issuecomment-1734640996 > Thanks for the updates @hgeraldino, the build looks good now. My apologies for not noticing these earlier, but I just had a couple more minor comments. This should be good to be merg

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

2023-09-25 Thread via GitHub
jeffkbkim commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1336348269 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -90,4 +92,29 @@ void validateOffsetFetch( int memberEpoch, l

[GitHub] [kafka] jolshan commented on a diff in pull request #14370: KAFKA-15449: Verify transactional offset commits (KIP-890 part 1)

2023-09-25 Thread via GitHub
jolshan commented on code in PR #14370: URL: https://github.com/apache/kafka/pull/14370#discussion_r1336455099 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -449,6 +452,10 @@ class GroupMetadataManager(brokerId: Int, | E

[GitHub] [kafka] dajac commented on a diff in pull request #14370: KAFKA-15449: Verify transactional offset commits (KIP-890 part 1)

2023-09-25 Thread via GitHub
dajac commented on code in PR #14370: URL: https://github.com/apache/kafka/pull/14370#discussion_r1336429881 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -958,7 +959,8 @@ private[group] class GroupCoordinator( pro

[GitHub] [kafka] philipnee commented on pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-25 Thread via GitHub
philipnee commented on PR #14364: URL: https://github.com/apache/kafka/pull/14364#issuecomment-1734529330 Hey @lianetm - I made some updates based on your last comments. Let me know your thoughts! -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-25 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1336429379 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] zhengyd2014 commented on a diff in pull request #14444: KIP-951: Server side and protocol changes for KIP-951

2023-09-25 Thread via GitHub
zhengyd2014 commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1336412576 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -276,11 +289,16 @@ private static FetchResponseData toMessage(Errors error,

[GitHub] [kafka] nizhikov commented on pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-09-25 Thread via GitHub
nizhikov commented on PR #14064: URL: https://github.com/apache/kafka/pull/14064#issuecomment-1734469315 Hello, @gharris1727 , @C0urante I'm working on #13247 and this commit somehow interfere with my change :) `ReassignPartitionsIntegrationTest` that I rewrite in java works before thi

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-25 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1336390801 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-25 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1336389075 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -115,25 +115,37 @@ public int memberEpoch() { @Override

[GitHub] [kafka] bmscomp opened a new pull request, #14450: KAFKA-15504: Upgrade snappy java to version 1.1.10.4

2023-09-25 Thread via GitHub
bmscomp opened a new pull request, #14450: URL: https://github.com/apache/kafka/pull/14450 The version 1.1.10.4 contains a Fix of [CVE-2023-43642](https://github.com/xerial/snappy-java/security/advisories/GHSA-55g7-9cwv-5qfv) and As mentioned on the release notes of the library http

[jira] [Created] (KAFKA-15504) Upgrade snappy java to version 1.1.10.4

2023-09-25 Thread Said BOUDJELDA (Jira)
Said BOUDJELDA created KAFKA-15504: -- Summary: Upgrade snappy java to version 1.1.10.4 Key: KAFKA-15504 URL: https://issues.apache.org/jira/browse/KAFKA-15504 Project: Kafka Issue Type: Impro

[jira] [Commented] (KAFKA-15493) Ensure system tests work with Java 21

2023-09-25 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768902#comment-17768902 ] Said BOUDJELDA commented on KAFKA-15493: [~ijuma]  I took your comment as a desc

[jira] [Updated] (KAFKA-15493) Ensure system tests work with Java 21

2023-09-25 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Said BOUDJELDA updated KAFKA-15493: --- Description: Run the system tests as described below with Java 21: [https://github.com/apac

[GitHub] [kafka] bmscomp opened a new pull request, #14449: MINOR: Upgrade version of zstd-jni to the latest stable version 1.5.5-5

2023-09-25 Thread via GitHub
bmscomp opened a new pull request, #14449: URL: https://github.com/apache/kafka/pull/14449 Upgrading zstd-jni library to the version 1.5.5-5 can bring much bug fixes, there is no clear release notes on the official repository we can see the changed that are made since the current stable ver

[GitHub] [kafka] Cerchie commented on pull request #14448: KAFKA-15307: Update/errors for deprecated config

2023-09-25 Thread via GitHub
Cerchie commented on PR #14448: URL: https://github.com/apache/kafka/pull/14448#issuecomment-1734371164 tagging @mjsax for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] Cerchie opened a new pull request, #14448: KAFKA-15307: Update/errors for deprecated config

2023-09-25 Thread via GitHub
Cerchie opened a new pull request, #14448: URL: https://github.com/apache/kafka/pull/14448 This PR is a follow-up on https://github.com/apache/kafka/pull/14360. It ensures that warnings are shown if the dep'd configs outlined in that PR are used (note topology.optimization's variable has

[GitHub] [kafka] dajac commented on pull request #14418: MINOR: Move TopicIdPartition class to server-common

2023-09-25 Thread via GitHub
dajac commented on PR #14418: URL: https://github.com/apache/kafka/pull/14418#issuecomment-1734321777 Re-triggered jenkins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] antonagestam commented on a diff in pull request #14124: KAFKA-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

2023-09-25 Thread via GitHub
antonagestam commented on code in PR #14124: URL: https://github.com/apache/kafka/pull/14124#discussion_r1336283242 ## clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json: ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] antonagestam opened a new pull request, #14447: MINOR: Fix incorrect versions in ConsumerGroupDescribeResponse schema

2023-09-25 Thread via GitHub
antonagestam opened a new pull request, #14447: URL: https://github.com/apache/kafka/pull/14447 See discussion in https://github.com/apache/kafka/pull/14124#discussion_r1320822476 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] dajac commented on a diff in pull request #14124: KAFKA-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

2023-09-25 Thread via GitHub
dajac commented on code in PR #14124: URL: https://github.com/apache/kafka/pull/14124#discussion_r1336257819 ## clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json: ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #14445: KAFKA-15502: Update SslEngineValidator to handle large stores

2023-09-25 Thread via GitHub
rajinisivaram commented on code in PR #14445: URL: https://github.com/apache/kafka/pull/14445#discussion_r1336233705 ## clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java: ## @@ -419,15 +419,15 @@ void handshake(SslEngineValidator peerValidator) throws S

[GitHub] [kafka] lqxshay opened a new pull request, #14446: Initial commit: new DSL operation on KStreams interface

2023-09-25 Thread via GitHub
lqxshay opened a new pull request, #14446: URL: https://github.com/apache/kafka/pull/14446 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[jira] [Updated] (KAFKA-15001) CVE vulnerabilities in Jetty

2023-09-25 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15001: --- Fix Version/s: (was: 3.6.0) > CVE vulnerabilities in Jetty > --

[jira] [Commented] (KAFKA-15503) CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52, 10.0.16, 11.0.16, 12.0.1

2023-09-25 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768810#comment-17768810 ] Satish Duggana commented on KAFKA-15503: https://github.com/apache/kafka/pull/10

[jira] [Updated] (KAFKA-15503) CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52, 10.0.16, 11.0.16, 12.0.1

2023-09-25 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15503: --- Fix Version/s: 3.6.0 (was: 3.0.0) (was: 2.8.0)

[jira] [Updated] (KAFKA-15503) CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52, 10.0.16, 11.0.16, 12.0.1

2023-09-25 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15503: --- Affects Version/s: (was: 2.7.0) (was: 2.6.1)

[jira] [Created] (KAFKA-15503) CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52, 10.0.16, 11.0.16, 12.0.1

2023-09-25 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-15503: -- Summary: CVE-2023-40167, CVE-2023-36479 - Upgrade jetty to 9.4.52, 10.0.16, 11.0.16, 12.0.1 Key: KAFKA-15503 URL: https://issues.apache.org/jira/browse/KAFKA-15503

[jira] [Commented] (KAFKA-15495) KRaft partition truncated when the only ISR member restarts with an empty disk

2023-09-25 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768787#comment-17768787 ] Ron Dagostino commented on KAFKA-15495: --- Yes. The Disk UUID from JBOD is not need

[GitHub] [kafka] satishd merged pull request #14438: KAFKA-15487: Upgrade Jetty to 9.4.52.v20230823

2023-09-25 Thread via GitHub
satishd merged PR #14438: URL: https://github.com/apache/kafka/pull/14438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14438: KAFKA-15487: Upgrade Jetty to 9.4.52.v20230823

2023-09-25 Thread via GitHub
satishd commented on PR #14438: URL: https://github.com/apache/kafka/pull/14438#issuecomment-1734142844 Merging it to trunk and 3.6 as the failed tests are unrelated to the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

2023-09-25 Thread via GitHub
rreddy-22 commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1336165006 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java: ## @@ -936,4 +939,204 @@ public void testLeaveGroupThrowsUnkn

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

2023-09-25 Thread via GitHub
rreddy-22 commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1336168777 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java: ## @@ -936,4 +939,204 @@ public void testLeaveGroupThrowsUnkn

[GitHub] [kafka] omkreddy commented on pull request #14445: KAFKA-15502: Update SslEngineValidator to handle large stores

2023-09-25 Thread via GitHub
omkreddy commented on PR #14445: URL: https://github.com/apache/kafka/pull/14445#issuecomment-1734140374 > @omkreddy Thanks for the PR, looks good. This doesn't include the change to process data for WRAP when there is already data in the buffer? @rajinisivaram missed the change. upd

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

2023-09-25 Thread via GitHub
rreddy-22 commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1336165306 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java: ## @@ -936,4 +939,204 @@ public void testLeaveGroupThrowsUnkn

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

2023-09-25 Thread via GitHub
rreddy-22 commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1336165006 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java: ## @@ -936,4 +939,204 @@ public void testLeaveGroupThrowsUnkn

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

2023-09-25 Thread via GitHub
rreddy-22 commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1336162536 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -90,4 +90,29 @@ void validateOffsetFetch( int memberEpoch, l

[GitHub] [kafka] jlprat commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-25 Thread via GitHub
jlprat commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1734119638 To add an extra data point, it seems I can reproduce this failure consistently on my machine. I'll try to allocate some time tomorrow to find the root cause. But if somebody on other timez

[jira] [Resolved] (KAFKA-15117) SslTransportLayerTest.testValidEndpointIdentificationCN fails with Java 20 & 21

2023-09-25 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-15117. Reviewer: Rajini Sivaram Resolution: Fixed > SslTransportLayerTest.testValidEndpoint

[GitHub] [kafka] rajinisivaram merged pull request #14440: [KAFKA-15117] In TestSslUtils set SubjectAlternativeNames to null if there are no hostnames

2023-09-25 Thread via GitHub
rajinisivaram merged PR #14440: URL: https://github.com/apache/kafka/pull/14440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.a

[jira] [Updated] (KAFKA-15502) Handle large keystores in SslEngineValidator

2023-09-25 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-15502: -- Description: We have observed an issue where inter broker SSL listener is not coming up for large key

[GitHub] [kafka] dajac closed pull request #14429: ignore

2023-09-25 Thread via GitHub
dajac closed pull request #14429: ignore URL: https://github.com/apache/kafka/pull/14429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] dajac merged pull request #14402: MINOR: Push logic to resolve the transaction coordinator into the AddPartitionsToTxnManager

2023-09-25 Thread via GitHub
dajac merged PR #14402: URL: https://github.com/apache/kafka/pull/14402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dajac commented on pull request #14402: MINOR: Push logic to resolve the transaction coordinator into the AddPartitionsToTxnManager

2023-09-25 Thread via GitHub
dajac commented on PR #14402: URL: https://github.com/apache/kafka/pull/14402#issuecomment-1734049140 I've got two good builds for this PR: * https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14402/17/tests * https://ci-builds.apache.org/blue/organizat

[GitHub] [kafka] omkreddy opened a new pull request, #14445: KAFKA-15502: Update SslEngineValidator to handle large stores

2023-09-25 Thread via GitHub
omkreddy opened a new pull request, #14445: URL: https://github.com/apache/kafka/pull/14445 We have observed an issue where inter broker SSL listener is not coming up when running with TLSv3/JDK 17 . SSL debug logs shows that TLSv3 post handshake messages >16K are not getting read and c

[jira] [Updated] (KAFKA-15498) Upgrade Snappy-Java to 1.1.10.4

2023-09-25 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15498: --- Priority: Blocker (was: Major) > Upgrade Snappy-Java to 1.1.10.4 >

[jira] [Created] (KAFKA-15502) Handle large keystores in SslEngineValidator

2023-09-25 Thread Manikumar (Jira)
Manikumar created KAFKA-15502: - Summary: Handle large keystores in SslEngineValidator Key: KAFKA-15502 URL: https://issues.apache.org/jira/browse/KAFKA-15502 Project: Kafka Issue Type: Bug Af

[jira] [Updated] (KAFKA-15001) CVE vulnerabilities in Jetty

2023-09-25 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15001: --- Fix Version/s: 3.6.0 > CVE vulnerabilities in Jetty > - > >

[jira] [Commented] (KAFKA-15497) Refactor build.gradle and split each module configuration on the module itself

2023-09-25 Thread Bertalan Kondrat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768753#comment-17768753 ] Bertalan Kondrat commented on KAFKA-15497: -- Hi [~bmscomp]  I am not able to ass

[GitHub] [kafka] chb2ab opened a new pull request, #14444: KIP-951: Server side and protocol changes for KIP-951

2023-09-25 Thread via GitHub
chb2ab opened a new pull request, #1: URL: https://github.com/apache/kafka/pull/1 This is the protocol and server changes to populate the fields in KIP-951. On NOT_LEADER_OR_FOLLOWER errors in both FETCH and PRODUCE the new leader ID and epoch are retrieved from the local cache thro

[GitHub] [kafka] k0b3rIT opened a new pull request, #14443: KAFKA-15497 Refactor build.gradle and split each module configuration…

2023-09-25 Thread via GitHub
k0b3rIT opened a new pull request, #14443: URL: https://github.com/apache/kafka/pull/14443 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[jira] [Commented] (KAFKA-15491) RackId doesn't exist error while running WordCountDemo

2023-09-25 Thread Hao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768739#comment-17768739 ] Hao Li commented on KAFKA-15491: Fixing it in https://github.com/apache/kafka/pull/14415

[GitHub] [kafka] lihaosky commented on pull request #14415: MINOR: only log error when rack aware assignment is enabled

2023-09-25 Thread via GitHub
lihaosky commented on PR #14415: URL: https://github.com/apache/kafka/pull/14415#issuecomment-1733908720 cc @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[jira] [Comment Edited] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

2023-09-25 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768550#comment-17768550 ] Victor van den Hoven edited comment on KAFKA-15417 at 9/25/23 2:22 PM: ---

[jira] [Resolved] (KAFKA-15485) Support building with Java 21 (LTS release)

2023-09-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-15485. - Resolution: Fixed > Support building with Java 21 (LTS release) > --

[jira] [Updated] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

2023-09-25 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor van den Hoven updated KAFKA-15417: - Attachment: Afbeelding 1-1.png > JoinWindow does not seem to work properly with

[GitHub] [kafka] lianetm commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-25 Thread via GitHub
lianetm commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1335942472 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -636,42 +857,148 @@ public void assign(Collection partitions) {

[GitHub] [kafka] jlprat commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-25 Thread via GitHub
jlprat commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1733780756 @ijuma I agree that it is extremely suspicious that is starting to fail now, I just wanted to point out, that it seems the failure is not 100% reproducible if I look at the CI test results

[GitHub] [kafka] ijuma commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-25 Thread via GitHub
ijuma commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1733772288 @jlprat The fact that the snappy variant is failing is suspicious though - I suspect we're running into the newly introduced limit in that test. Perhaps during compaction? I haven't checked

[jira] [Created] (KAFKA-15501) Kafka to KRaft combined mode migration v3.5

2023-09-25 Thread Ritvik Gupta (Jira)
Ritvik Gupta created KAFKA-15501: Summary: Kafka to KRaft combined mode migration v3.5 Key: KAFKA-15501 URL: https://issues.apache.org/jira/browse/KAFKA-15501 Project: Kafka Issue Type: Impro

[jira] [Comment Edited] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

2023-09-25 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768550#comment-17768550 ] Victor van den Hoven edited comment on KAFKA-15417 at 9/25/23 1:22 PM: ---

[jira] [Updated] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

2023-09-25 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor van den Hoven updated KAFKA-15417: - Attachment: Afbeelding 1.png > JoinWindow does not seem to work properly with a

[jira] [Commented] (KAFKA-15492) Enable spotbugs when building with Java 21

2023-09-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768681#comment-17768681 ] Ismael Juma commented on KAFKA-15492: - Relevant issue upstream: https://github.com/s

[jira] [Updated] (KAFKA-15492) Enable spotbugs when building with Java 21

2023-09-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-15492: Fix Version/s: 3.7.0 > Enable spotbugs when building with Java 21 > --

[jira] [Commented] (KAFKA-15495) KRaft partition truncated when the only ISR member restarts with an empty disk

2023-09-25 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768674#comment-17768674 ] Ron Dagostino commented on KAFKA-15495: --- Thanks, Ismael. Yes, I read [the KIP|ht

[GitHub] [kafka] jlprat commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-25 Thread via GitHub
jlprat commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1733618819 If it read the tests right, it seems it is now flaky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Comment Edited] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

2023-09-25 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768550#comment-17768550 ] Victor van den Hoven edited comment on KAFKA-15417 at 9/25/23 12:26 PM: --

[GitHub] [kafka] tinaselenge closed pull request #14184: KAFKA-15201: When git fails, the script goes into a loop

2023-09-25 Thread via GitHub
tinaselenge closed pull request #14184: KAFKA-15201: When git fails, the script goes into a loop URL: https://github.com/apache/kafka/pull/14184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [kafka] ijuma commented on pull request #14440: [KAFKA-15117] In TestSslUtils set SubjectAlternativeNames to null if there are no hostnames

2023-09-25 Thread via GitHub
ijuma commented on PR #14440: URL: https://github.com/apache/kafka/pull/14440#issuecomment-1733599894 I merged a PR that introduced a conflict - I resolved it since it was trivial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Assigned] (KAFKA-15201) When git fails, script goes into a loop

2023-09-25 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-15201: - Assignee: (was: Gantigmaa Selenge) > When git fails, script goes into a loo

[GitHub] [kafka] ijuma commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-25 Thread via GitHub
ijuma commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1733595038 Looks like this regressed? So we'll have to work with upstream to figure out what happened. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma merged pull request #14433: KAFKA-15485: Support building with Java 21 (3/3)

2023-09-25 Thread via GitHub
ijuma merged PR #14433: URL: https://github.com/apache/kafka/pull/14433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma commented on a diff in pull request #14433: KAFKA-15485: Support building with Java 21 (3/3)

2023-09-25 Thread via GitHub
ijuma commented on code in PR #14433: URL: https://github.com/apache/kafka/pull/14433#discussion_r1335774192 ## build.gradle: ## @@ -232,7 +232,10 @@ subprojects { apply plugin: 'java-library' apply plugin: 'checkstyle' - apply plugin: "com.github.spotbugs" + + // spot

[GitHub] [kafka] satishd merged pull request #14407: KAFKA-15479: Remote log segments should be considered once for retention breach

2023-09-25 Thread via GitHub
satishd merged PR #14407: URL: https://github.com/apache/kafka/pull/14407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14407: KAFKA-15479: Remote log segments should be considered once for retention breach

2023-09-25 Thread via GitHub
satishd commented on PR #14407: URL: https://github.com/apache/kafka/pull/14407#issuecomment-1733562853 Merging it to trunk as the failed tests are not related to the changes introduced in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Created] (KAFKA-15500) Code bug in SslPrincipalMapper.java

2023-09-25 Thread Svyatoslav (Jira)
Svyatoslav created KAFKA-15500: -- Summary: Code bug in SslPrincipalMapper.java Key: KAFKA-15500 URL: https://issues.apache.org/jira/browse/KAFKA-15500 Project: Kafka Issue Type: Bug Com

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14433: KAFKA-15485: Support building with Java 21 (3/3)

2023-09-25 Thread via GitHub
divijvaidya commented on code in PR #14433: URL: https://github.com/apache/kafka/pull/14433#discussion_r1335783017 ## build.gradle: ## @@ -232,7 +232,10 @@ subprojects { apply plugin: 'java-library' apply plugin: 'checkstyle' - apply plugin: "com.github.spotbugs" + + /

[GitHub] [kafka] cadonna opened a new pull request, #14442: KAFKA-10199: Do not unlock state directories of tasks in state updater

2023-09-25 Thread via GitHub
cadonna opened a new pull request, #14442: URL: https://github.com/apache/kafka/pull/14442 When Streams completes a rebalance, it unlocks state directories all unassigned tasks. Unfortunately, when the state updater is enabled, Streams does not look into the state updater to determine the u

[GitHub] [kafka] rykovsi opened a new pull request, #14441: Correct SslPrincipalMapper.java

2023-09-25 Thread via GitHub
rykovsi opened a new pull request, #14441: URL: https://github.com/apache/kafka/pull/14441 Correct this "&" to "&&" *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping review

[GitHub] [kafka] ijuma commented on a diff in pull request #14433: KAFKA-15485: Support building with Java 21 (3/3)

2023-09-25 Thread via GitHub
ijuma commented on code in PR #14433: URL: https://github.com/apache/kafka/pull/14433#discussion_r1335774192 ## build.gradle: ## @@ -232,7 +232,10 @@ subprojects { apply plugin: 'java-library' apply plugin: 'checkstyle' - apply plugin: "com.github.spotbugs" + + // spot

[GitHub] [kafka] jlprat commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-25 Thread via GitHub
jlprat commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1733502161 This one seems to be a failing one: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14434/1/testReport/junit/kafka.log/LogCleanerParameterizedIntegrationTest/Build___JDK_11_and_S

[GitHub] [kafka] jlprat commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-25 Thread via GitHub
jlprat commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1733500635 @divijvaidya the link you pasted states "Passed", maybe it was on one of the other runs that failed? -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] emissionnebula commented on a diff in pull request #14440: [KAFKA-15117] In TestSslUtils set SubjectAlternativeNames to null if there are no hostnames

2023-09-25 Thread via GitHub
emissionnebula commented on code in PR #14440: URL: https://github.com/apache/kafka/pull/14440#discussion_r1335745349 ## clients/src/test/java/org/apache/kafka/test/TestSslUtils.java: ## @@ -399,10 +399,12 @@ public CertificateBuilder(int days, String algorithm) { }

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #14440: [KAFKA-15117] In TestSslUtils set SubjectAlternativeNames to null if there are no hostnames

2023-09-25 Thread via GitHub
rajinisivaram commented on code in PR #14440: URL: https://github.com/apache/kafka/pull/14440#discussion_r1335740613 ## clients/src/test/java/org/apache/kafka/test/TestSslUtils.java: ## @@ -399,10 +399,12 @@ public CertificateBuilder(int days, String algorithm) { }

[GitHub] [kafka] emissionnebula opened a new pull request, #14440: [KAFKA-15117] In TestSslUtils set SubjectAlternativeNames to null if there are no hostnames

2023-09-25 Thread via GitHub
emissionnebula opened a new pull request, #14440: URL: https://github.com/apache/kafka/pull/14440 We are currently encoding an empty hostNames array to `subjectAltName` in the keystore. While parsing the certificates in the test this causes an issue. Up to Java 17, this parsing error was ig

[GitHub] [kafka] divijvaidya commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-25 Thread via GitHub
divijvaidya commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1733446288 Some snappy related tests are failing: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14434/1/testReport/junit/kafka.log/LogCleanerParameterizedIntegrationTest/Build___JDK_

[jira] [Updated] (KAFKA-15498) Upgrade Snappy-Java to 1.1.10.4

2023-09-25 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15498: - Summary: Upgrade Snappy-Java to 1.1.10.4 (was: [CVE fix] Upgrade Snappy-Java to 1.1.10.4) > Up

[GitHub] [kafka] kamalcph commented on pull request #14330: KAFKA-15410: Delete records with tiered storage integration test (4/4)

2023-09-25 Thread via GitHub
kamalcph commented on PR #14330: URL: https://github.com/apache/kafka/pull/14330#issuecomment-1733441920 > > Folks the test introduced in this PR has been flaky lately - https://ge.apache.org/scans/tests?search.rootProjectNames=kafka&search.timeZoneId=Europe/Berlin&tests.container=org.apache

  1   2   >