[GitHub] [kafka] chernyih commented on pull request #14457: KAFKA-15510: Fix follower's lastFetchedEpoch when fetch response has …

2023-09-27 Thread via GitHub
chernyih commented on PR #14457: URL: https://github.com/apache/kafka/pull/14457#issuecomment-1738421193 The test failures do not look related. I compared with a few recent merged commit tests. For the failed tests that are not found in the recent commit tests, i ran those tests locally

[jira] [Comment Edited] (KAFKA-15493) Ensure system tests work with Java 21

2023-09-27 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769856#comment-17769856 ] Said BOUDJELDA edited comment on KAFKA-15493 at 9/28/23 12:20 AM: --

[jira] [Commented] (KAFKA-15493) Ensure system tests work with Java 21

2023-09-27 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769856#comment-17769856 ] Said BOUDJELDA commented on KAFKA-15493: {code:java} ➜  kafka git:(trunk) java -version openjdk

[jira] [Updated] (KAFKA-15493) Ensure system tests work with Java 21

2023-09-27 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Said BOUDJELDA updated KAFKA-15493: --- Attachment: image-2023-09-28-02-12-33-807.png > Ensure system tests work with Java 21 >

[jira] [Updated] (KAFKA-15493) Ensure system tests work with Java 21

2023-09-27 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Said BOUDJELDA updated KAFKA-15493: --- Attachment: image-2023-09-28-02-11-49-196.png > Ensure system tests work with Java 21 >

[jira] [Created] (KAFKA-15516) Provide kafka-client library as a proper java Jigsaw module

2023-09-27 Thread Chad Preisler (Jira)
Chad Preisler created KAFKA-15516: - Summary: Provide kafka-client library as a proper java Jigsaw module Key: KAFKA-15516 URL: https://issues.apache.org/jira/browse/KAFKA-15516 Project: Kafka

[GitHub] [kafka] CalvinConfluent opened a new pull request, #14465: [DO NOT REVIEW]Add broker epoch to the clean shutdown file

2023-09-27 Thread via GitHub
CalvinConfluent opened a new pull request, #14465: URL: https://github.com/apache/kafka/pull/14465 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14408: KAFKA-14506: Implement DeleteGroups API and OffsetDelete API

2023-09-27 Thread via GitHub
jeffkbkim commented on code in PR #14408: URL: https://github.com/apache/kafka/pull/14408#discussion_r1339019021 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -90,4 +92,29 @@ void validateOffsetFetch( int memberEpoch,

[GitHub] [kafka] ahuang98 commented on a diff in pull request #14206: [MINOR] More image replay test cases

2023-09-27 Thread via GitHub
ahuang98 commented on code in PR #14206: URL: https://github.com/apache/kafka/pull/14206#discussion_r1339228692 ## metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java: ## @@ -176,22 +200,30 @@ private PartitionRegistration newPartition(int[] replicas) {

[GitHub] [kafka] ahuang98 commented on a diff in pull request #14206: [MINOR] More image replay test cases

2023-09-27 Thread via GitHub
ahuang98 commented on code in PR #14206: URL: https://github.com/apache/kafka/pull/14206#discussion_r1339229757 ## metadata/src/test/java/org/apache/kafka/image/ProducerIdsImageTest.java: ## @@ -54,11 +54,24 @@ public class ProducerIdsImageTest { setBrokerId(3).

[GitHub] [kafka] ahuang98 commented on a diff in pull request #14206: [MINOR] More image replay test cases

2023-09-27 Thread via GitHub
ahuang98 commented on code in PR #14206: URL: https://github.com/apache/kafka/pull/14206#discussion_r1339224472 ## metadata/src/test/java/org/apache/kafka/image/FeaturesImageTest.java: ## @@ -96,6 +121,20 @@ public void testImage2RoundTrip() { testToImage(IMAGE2);

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
divijvaidya commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1339202068 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -310,7 +310,7 @@ private T loadIndexFile(File file,

[GitHub] [kafka] rondagostino commented on a diff in pull request #14206: [MINOR] More image replay test cases

2023-09-27 Thread via GitHub
rondagostino commented on code in PR #14206: URL: https://github.com/apache/kafka/pull/14206#discussion_r1338985779 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -102,14 +115,18 @@ public class ClusterImageTest { IMAGE1 = new

[jira] [Updated] (KAFKA-15327) Async consumer should commit offsets on close

2023-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15327: --- Description: In the current implementation of the KafkaConsumer, the ConsumerCoordinator

[jira] [Updated] (KAFKA-15327) Async consumer should commit offsets on close

2023-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15327: --- Description: In the current implementation of the KafkaConsumer, the ConsumerCoordinator

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769780#comment-17769780 ] ASF GitHub Bot commented on KAFKA-13882: tombentley commented on PR #410: URL:

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-27 Thread via GitHub
philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1339158811 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventHandler.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-27 Thread via GitHub
philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1339158103 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -17,146 +17,195 @@ package

[jira] [Created] (KAFKA-15515) Remove duplicated integration tests for new consumer

2023-09-27 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-15515: -- Summary: Remove duplicated integration tests for new consumer Key: KAFKA-15515 URL: https://issues.apache.org/jira/browse/KAFKA-15515 Project: Kafka

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-27 Thread via GitHub
philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1339157715 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventHandler.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769769#comment-17769769 ] ASF GitHub Bot commented on KAFKA-13882: tombentley merged PR #410: URL:

[GitHub] [kafka] antonagestam commented on pull request #14447: MINOR: Fix incorrect versions in ConsumerGroupDescribeResponse schema

2023-09-27 Thread via GitHub
antonagestam commented on PR #14447: URL: https://github.com/apache/kafka/pull/14447#issuecomment-1737955955 @kirktrue Related to that, I think it'd make sense to enforce this as well: https://github.com/apache/kafka/pull/13680, as it allows slightly less parser complexity. Since we're

[GitHub] [kafka] antonagestam commented on pull request #14447: MINOR: Fix incorrect versions in ConsumerGroupDescribeResponse schema

2023-09-27 Thread via GitHub
antonagestam commented on PR #14447: URL: https://github.com/apache/kafka/pull/14447#issuecomment-1737946051 @kirktrue [I was pondering that as well](https://github.com/apache/kafka/pull/14124#discussion_r1336283242). It seems attractive because it's certainly possible to automate, however

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769732#comment-17769732 ] ASF GitHub Bot commented on KAFKA-13882: qingwei91 commented on PR #410: URL:

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-27 Thread via GitHub
philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1338973379 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -330,7 +343,7 @@ private Map prepareCloseFetchSession

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

2023-09-27 Thread via GitHub
philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1338972414 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -92,6 +88,23 @@ public AbstractFetch(final LogContext logContext,

[GitHub] [kafka] nizhikov commented on pull request #14456: KAFKA-14595 ReassignPartitionsIntegrationTest rewritten in java

2023-09-27 Thread via GitHub
nizhikov commented on PR #14456: URL: https://github.com/apache/kafka/pull/14456#issuecomment-1737779240 Hello, @showuon This PR is part of #13247 This is last test of `ReassignPartitionCommand` in scala. If you have some time, please, join the review. -- This is an automated

[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 Move ReassignPartitionsCommand to java

2023-09-27 Thread via GitHub
nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-173703 @mimaison Tests in #14456 are OK. If you have some time, please, join the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-15467) On reconnect mm2 cannot find offset that exists in remote cluster and re-syncs the entire topic

2023-09-27 Thread Steve Jacobs (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769707#comment-17769707 ] Steve Jacobs commented on KAFKA-15467: -- Rolling back to MirrorMaker2 3.4.1 to see if that fixes the

[GitHub] [kafka] chernyih commented on pull request #14457: KAFKA-15510: Fix follower's lastFetchedEpoch when fetch response has …

2023-09-27 Thread via GitHub
chernyih commented on PR #14457: URL: https://github.com/apache/kafka/pull/14457#issuecomment-1737747214 @rajinisivaram @divijvaidya @viktorsomogyi Thank you for the review. After reading the comments and thinking more about it, it won't impact truncation of fetch since if a leader has

[GitHub] [kafka] chernyih commented on a diff in pull request #14457: KAFKA-15510: Fix follower's lastFetchedEpoch when fetch response has …

2023-09-27 Thread via GitHub
chernyih commented on code in PR #14457: URL: https://github.com/apache/kafka/pull/14457#discussion_r1338903942 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -364,10 +364,11 @@ abstract class AbstractFetcherThread(name: String,

[jira] [Comment Edited] (KAFKA-9774) Create official Docker image for Kafka Connect

2023-09-27 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068519#comment-17068519 ] Jordan Moore edited comment on KAFKA-9774 at 9/27/23 4:36 PM: -- Happy to take

[jira] (KAFKA-9774) Create official Docker image for Kafka Connect

2023-09-27 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9774 ] Jordan Moore deleted comment on KAFKA-9774: - was (Author: cricket007): Done here https://github.com/OneCricketeer/apache-kafka-connect-docker#containerized-apache-kafka-connect > Create

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #14432: KAFKA-14516: [1/N] Static Member leave request handling

2023-09-27 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1338900198 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -593,6 +609,9 @@ private void

[GitHub] [kafka] mimaison opened a new pull request, #14464: MINOR: Fix build failure in genConnectOpenAPIDocs

2023-09-27 Thread via GitHub
mimaison opened a new pull request, #14464: URL: https://github.com/apache/kafka/pull/14464 We bumped the `swagger-gradle-plugin` version in https://github.com/apache/kafka/commit/d1ad1d7b7013ea2c24a3f71c485a2a914adf1348 This breaks the `genConnectOpenAPIDocs` task: ``` > Task

[GitHub] [kafka] vamossagar12 commented on pull request #14432: KAFKA-14516: [1/N] Static Member leave request handling

2023-09-27 Thread via GitHub
vamossagar12 commented on PR #14432: URL: https://github.com/apache/kafka/pull/14432#issuecomment-1737732772 Thanks for the review @kirktrue ! I have addressed the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-15445) KIP-975: Docker Image for Apache Kafka

2023-09-27 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769698#comment-17769698 ] Jordan Moore commented on KAFKA-15445: -- Adding backlink to KAFKA-9774 > KIP-975: Docker Image for

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #14432: KAFKA-14516: [1/N] Static Member leave request handling

2023-09-27 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1338895795 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -593,6 +609,9 @@ private void

[GitHub] [kafka] kirktrue opened a new pull request, #14463: [MINOR] Add LEAVE_GROUP_EPOCH to GroupMetadataManager

2023-09-27 Thread via GitHub
kirktrue opened a new pull request, #14463: URL: https://github.com/apache/kafka/pull/14463 Replacing the use a hardcoded -1 with a constant (`LEAVE_GROUP_EPOCH`) that provides more clarity. Since static members also have a magic number (-2), this will motivate future commits to use

[GitHub] [kafka] kirktrue commented on a diff in pull request #14432: KAFKA-14516: [1/N] Static Member leave request handling

2023-09-27 Thread via GitHub
kirktrue commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1338844884 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -593,6 +609,9 @@ private void

[GitHub] [kafka] kirktrue commented on a diff in pull request #14444: KIP-951: Server side and protocol changes for KIP-951

2023-09-27 Thread via GitHub
kirktrue commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1338814653 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -254,8 +265,10 @@ private static boolean

[GitHub] [kafka] cadonna merged pull request #14442: KAFKA-10199: Do not unlock state directories of tasks in state updater

2023-09-27 Thread via GitHub
cadonna merged PR #14442: URL: https://github.com/apache/kafka/pull/14442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna commented on pull request #14442: KAFKA-10199: Do not unlock state directories of tasks in state updater

2023-09-27 Thread via GitHub
cadonna commented on PR #14442: URL: https://github.com/apache/kafka/pull/14442#issuecomment-1737665889 Build failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] kirktrue commented on pull request #14447: MINOR: Fix incorrect versions in ConsumerGroupDescribeResponse schema

2023-09-27 Thread via GitHub
kirktrue commented on PR #14447: URL: https://github.com/apache/kafka/pull/14447#issuecomment-1737649876 Thanks for the PR @antonagestam! Does it make sense (or is it even possible) to write a test case that verifies the correctness of this change? Thanks! -- This is an

[GitHub] [kafka] kirktrue commented on a diff in pull request #14455: KAFKA-15507: Make AdminClient throw non-retriable exception for a new call while closing

2023-09-27 Thread via GitHub
kirktrue commented on code in PR #14455: URL: https://github.com/apache/kafka/pull/14455#discussion_r1338802690 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -1546,9 +1546,9 @@ void enqueue(Call call, long now) { */ void

[jira] [Commented] (KAFKA-15448) Streams StandbyTaskUpdateListener

2023-09-27 Thread Colt McNealy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769667#comment-17769667 ] Colt McNealy commented on KAFKA-15448: -- We have a draft implementation internally, and we will

[jira] [Commented] (KAFKA-15513) KRaft cluster fails with SCRAM authentication enabled for control-plane

2023-09-27 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769662#comment-17769662 ] Proven Provenzano commented on KAFKA-15513: --- Thank you for the detailed bug report. I can

[GitHub] [kafka] dongnuo123 opened a new pull request, #14462: KAFKA-14504: Implement DescribeGroups API

2023-09-27 Thread via GitHub
dongnuo123 opened a new pull request, #14462: URL: https://github.com/apache/kafka/pull/14462 This PR implements DescribeGroups API according to the implementation in the old GroupCoordinator with the new model. ### JIRA https://issues.apache.org/jira/browse/KAFKA-14504 ###

[GitHub] [kafka] vamossagar12 opened a new pull request, #14461: [MINOR] Fixing typo with CoordinatorRuntime Javadoc

2023-09-27 Thread via GitHub
vamossagar12 opened a new pull request, #14461: URL: https://github.com/apache/kafka/pull/14461 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (KAFKA-15514) Controller-side replica management changes

2023-09-27 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-15514: --- Summary: Controller-side replica management changes Key: KAFKA-15514 URL: https://issues.apache.org/jira/browse/KAFKA-15514 Project: Kafka Issue Type:

[GitHub] [kafka] viktorsomogyi commented on pull request #14457: KAFKA-15510: Fix follower's lastFetchedEpoch when fetch response has …

2023-09-27 Thread via GitHub
viktorsomogyi commented on PR #14457: URL: https://github.com/apache/kafka/pull/14457#issuecomment-1737371455 I also looked at how this `lastFetchedEpoch` is used in the next fetch but I don't think either it'd trigger truncation. Let's wait for @chernyih 's response. Since this is a small

[jira] [Updated] (KAFKA-15365) Broker replica management changes

2023-09-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-15365: Description: On the broker side,  * Replica placement (i.e. selection of a log dir) generates

[jira] [Updated] (KAFKA-15365) Broker-side replica management changes

2023-09-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-15365: Summary: Broker-side replica management changes (was: Broker replica management changes) >

[jira] [Updated] (KAFKA-15365) Broker replica management changes

2023-09-27 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-15365: Summary: Broker replica management changes (was: Replica management changes) > Broker replica

[jira] [Updated] (KAFKA-15489) split brain in KRaft cluster

2023-09-27 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-15489: -- Fix Version/s: (was: 3.6.0) > split brain in KRaft cluster > - > >

[jira] [Reopened] (KAFKA-15489) split brain in KRaft cluster

2023-09-27 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reopened KAFKA-15489: --- > split brain in KRaft cluster > - > > Key: KAFKA-15489 >

[GitHub] [kafka] satishd commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
satishd commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338553597 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -598,4 +615,11 @@ class RemoteIndexCacheTest { timeIndex.flush() } } + +

[GitHub] [kafka] satishd commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
satishd commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338550163 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -598,4 +615,11 @@ class RemoteIndexCacheTest { timeIndex.flush() } } + +

[GitHub] [kafka] satishd commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
satishd commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338550163 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -598,4 +615,11 @@ class RemoteIndexCacheTest { timeIndex.flush() } } + +

[GitHub] [kafka] cadonna commented on a diff in pull request #14442: KAFKA-10199: Do not unlock state directories of tasks in state updater

2023-09-27 Thread via GitHub
cadonna commented on code in PR #14442: URL: https://github.com/apache/kafka/pull/14442#discussion_r1338525255 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1226,7 +1226,9 @@ private void releaseLockedUnassignedTaskDirectories()

[GitHub] [kafka] Hangleton commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
Hangleton commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338522387 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -310,7 +310,7 @@ private T loadIndexFile(File file,

[GitHub] [kafka] Hangleton commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
Hangleton commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338522387 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -310,7 +310,7 @@ private T loadIndexFile(File file,

[GitHub] [kafka] iit2009060 commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
iit2009060 commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338517254 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -598,4 +615,11 @@ class RemoteIndexCacheTest { timeIndex.flush() } } +

[GitHub] [kafka] iit2009060 commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
iit2009060 commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338513994 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -310,7 +310,7 @@ private T loadIndexFile(File file,

[GitHub] [kafka] divijvaidya commented on pull request #14457: KAFKA-15510: Fix follower's lastFetchedEpoch when fetch response has …

2023-09-27 Thread via GitHub
divijvaidya commented on PR #14457: URL: https://github.com/apache/kafka/pull/14457#issuecomment-1737266545 > In any case, I think it makes sense to maintain the correct value for lastFetchedEpoch to avoid relying on timing assumptions that may not hold in future. Totally agree. The

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
divijvaidya commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338502969 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -598,4 +615,11 @@ class RemoteIndexCacheTest { timeIndex.flush() } }

[GitHub] [kafka] iit2009060 commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
iit2009060 commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338498452 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -598,4 +615,11 @@ class RemoteIndexCacheTest { timeIndex.flush() } } +

[GitHub] [kafka] lucasbru commented on a diff in pull request #14442: KAFKA-10199: Do not unlock state directories of tasks in state updater

2023-09-27 Thread via GitHub
lucasbru commented on code in PR #14442: URL: https://github.com/apache/kafka/pull/14442#discussion_r1338490846 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1226,7 +1226,9 @@ private void releaseLockedUnassignedTaskDirectories()

[GitHub] [kafka] rajinisivaram commented on pull request #14457: KAFKA-15510: Fix follower's lastFetchedEpoch when fetch response has …

2023-09-27 Thread via GitHub
rajinisivaram commented on PR #14457: URL: https://github.com/apache/kafka/pull/14457#issuecomment-1737243300 I couldn't think of a case where we might hit an actual truncation issue since divergence should have been detected in the first request after leader change, so will wait for

[GitHub] [kafka] tinaselenge commented on a diff in pull request #14453: MINOR: Close UnifiedLog created in tests to avoid resource leak

2023-09-27 Thread via GitHub
tinaselenge commented on code in PR #14453: URL: https://github.com/apache/kafka/pull/14453#discussion_r1338486017 ## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ## @@ -71,6 +72,13 @@ class UnifiedLogTest { @AfterEach def tearDown(): Unit = {

[GitHub] [kafka] tinaselenge commented on a diff in pull request #14453: MINOR: Close UnifiedLog created in tests to avoid resource leak

2023-09-27 Thread via GitHub
tinaselenge commented on code in PR #14453: URL: https://github.com/apache/kafka/pull/14453#discussion_r1338486393 ## core/src/test/scala/unit/kafka/log/LogLoaderTest.scala: ## @@ -1800,5 +1822,6 @@ class LogLoaderTest { isRemoteLogEnabled = isRemoteLogEnabled

[GitHub] [kafka] tinaselenge commented on a diff in pull request #14453: MINOR: Close UnifiedLog created in tests to avoid resource leak

2023-09-27 Thread via GitHub
tinaselenge commented on code in PR #14453: URL: https://github.com/apache/kafka/pull/14453#discussion_r1338486017 ## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ## @@ -71,6 +72,13 @@ class UnifiedLogTest { @AfterEach def tearDown(): Unit = {

[GitHub] [kafka] Hangleton commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
Hangleton commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338467462 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -310,7 +310,7 @@ private T loadIndexFile(File file,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
divijvaidya commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338463195 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -598,4 +615,11 @@ class RemoteIndexCacheTest { timeIndex.flush() } }

[GitHub] [kafka] iit2009060 commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
iit2009060 commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338421535 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -598,4 +615,11 @@ class RemoteIndexCacheTest { timeIndex.flush() } } +

[GitHub] [kafka] raboof opened a new pull request, #14460: MINOR: suppress dependencycheck warning for CVE-2023-35116

2023-09-27 Thread via GitHub
raboof opened a new pull request, #14460: URL: https://github.com/apache/kafka/pull/14460 Like in most projects, this attack cannot be achieved by an external attacker in Kafka. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[jira] [Resolved] (KAFKA-15177) MirrorMaker 2 should implement the alterOffsets KIP-875 API

2023-09-27 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya resolved KAFKA-15177. Fix Version/s: 3.6.0 Resolution: Fixed > MirrorMaker 2 should implement the alterOffsets

[GitHub] [kafka] cadonna commented on a diff in pull request #14442: KAFKA-10199: Do not unlock state directories of tasks in state updater

2023-09-27 Thread via GitHub
cadonna commented on code in PR #14442: URL: https://github.com/apache/kafka/pull/14442#discussion_r1338448792 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1226,7 +1226,9 @@ private void releaseLockedUnassignedTaskDirectories()

[GitHub] [kafka] cadonna commented on a diff in pull request #14442: KAFKA-10199: Do not unlock state directories of tasks in state updater

2023-09-27 Thread via GitHub
cadonna commented on code in PR #14442: URL: https://github.com/apache/kafka/pull/14442#discussion_r1338448490 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1226,7 +1226,9 @@ private void releaseLockedUnassignedTaskDirectories()

[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-27 Thread via GitHub
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1737176802 Backported to 3.6 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] showuon merged pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-27 Thread via GitHub
showuon merged PR #14434: URL: https://github.com/apache/kafka/pull/14434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-27 Thread via GitHub
showuon commented on PR #14434: URL: https://github.com/apache/kafka/pull/14434#issuecomment-1737170863 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] showuon commented on a diff in pull request #14434: KAFKA-15498: bump snappy-java version to 1.1.10.4

2023-09-27 Thread via GitHub
showuon commented on code in PR #14434: URL: https://github.com/apache/kafka/pull/14434#discussion_r1338431502 ## core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala: ## @@ -103,12 +123,37 @@ class ProducerCompressionTest extends QuorumTestHarness {

[jira] [Commented] (KAFKA-15512) EOL zookeeper component in kafka

2023-09-27 Thread Aleksandra Drobnjak (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769537#comment-17769537 ] Aleksandra Drobnjak commented on KAFKA-15512: - Thanks [~divijvaidya] ! > EOL zookeeper

[GitHub] [kafka] iit2009060 commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
iit2009060 commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338421761 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -598,4 +615,11 @@ class RemoteIndexCacheTest { timeIndex.flush() } } +

[jira] [Updated] (KAFKA-15513) KRaft cluster fails with SCRAM authentication enabled for control-plane

2023-09-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15513: - Affects Version/s: 3.6.0 > KRaft cluster fails with SCRAM authentication enabled for

[jira] [Updated] (KAFKA-15513) KRaft cluster fails with SCRAM authentication enabled for control-plane

2023-09-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15513: - Affects Version/s: 3.5.1 > KRaft cluster fails with SCRAM authentication enabled for

[jira] [Updated] (KAFKA-15513) KRaft cluster fails with SCRAM authentication enabled for control-plane

2023-09-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15513: - Component/s: kraft > KRaft cluster fails with SCRAM authentication enabled for control-plane >

[jira] [Commented] (KAFKA-15512) EOL zookeeper component in kafka

2023-09-27 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769529#comment-17769529 ] Divij Vaidya commented on KAFKA-15512: -- Zk has been upgraded to 3.8.2 in upcoming Kafka release

[jira] [Created] (KAFKA-15513) KRaft cluster fails with SCRAM authentication enabled for control-plane

2023-09-27 Thread migruiz4 (Jira)
migruiz4 created KAFKA-15513: Summary: KRaft cluster fails with SCRAM authentication enabled for control-plane Key: KAFKA-15513 URL: https://issues.apache.org/jira/browse/KAFKA-15513 Project: Kafka

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
divijvaidya commented on code in PR #14459: URL: https://github.com/apache/kafka/pull/14459#discussion_r1338397666 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -598,4 +615,11 @@ class RemoteIndexCacheTest { timeIndex.flush() } }

[jira] [Commented] (KAFKA-15511) Exception not handled correctly if indexFile is corrupted.

2023-09-27 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769525#comment-17769525 ] Arpit Goyal commented on KAFKA-15511: - [~divijvaidya] Can you review this

[GitHub] [kafka] iit2009060 opened a new pull request, #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

2023-09-27 Thread via GitHub
iit2009060 opened a new pull request, #14459: URL: https://github.com/apache/kafka/pull/14459 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[GitHub] [kafka] lucasbru commented on a diff in pull request #14442: KAFKA-10199: Do not unlock state directories of tasks in state updater

2023-09-27 Thread via GitHub
lucasbru commented on code in PR #14442: URL: https://github.com/apache/kafka/pull/14442#discussion_r1338367481 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1226,7 +1226,9 @@ private void releaseLockedUnassignedTaskDirectories()

[jira] [Created] (KAFKA-15512) EOL zookeeper component in kafka

2023-09-27 Thread Aleksandra Drobnjak (Jira)
Aleksandra Drobnjak created KAFKA-15512: --- Summary: EOL zookeeper component in kafka Key: KAFKA-15512 URL: https://issues.apache.org/jira/browse/KAFKA-15512 Project: Kafka Issue Type:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14457: KAFKA-15510: Fix follower's lastFetchedEpoch when fetch response has …

2023-09-27 Thread via GitHub
divijvaidya commented on code in PR #14457: URL: https://github.com/apache/kafka/pull/14457#discussion_r1338310531 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -364,10 +364,11 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #14455: KAFKA-15507: Make AdminClient throw non-retriable exception for a new call while closing

2023-09-27 Thread via GitHub
vamossagar12 commented on code in PR #14455: URL: https://github.com/apache/kafka/pull/14455#discussion_r1338305899 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -1546,9 +1546,9 @@ void enqueue(Call call, long now) { */

[GitHub] [kafka] hudeqi commented on pull request #13930: KAFKA-15134:Enrich the prompt reason in CommitFailedException

2023-09-27 Thread via GitHub
hudeqi commented on PR #13930: URL: https://github.com/apache/kafka/pull/13930#issuecomment-1737000786 @showuon Hi, Could you help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769491#comment-17769491 ] ASF GitHub Bot commented on KAFKA-13882: mimaison commented on PR #410: URL:

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #14432: KAFKA-14516: [1/N] Static Member leave request handling

2023-09-27 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1338285360 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -593,6 +609,9 @@ private void

  1   2   >