[
https://issues.apache.org/jira/browse/KAFKA-15639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15639:
--
Parent: (was: KAFKA-14246)
Issue Type: Task (was: Sub-task)
> Investigate ConsumerNetwork
[
https://issues.apache.org/jira/browse/KAFKA-15639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15639:
--
Description:
The {{testResetPositionsProcessFailureIsIgnored}} test looks like this:
{code:java}
[
https://issues.apache.org/jira/browse/KAFKA-15639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15639:
--
Description:
The {{testResetPositionsProcessFailureIsIgnored}} test looks like this:
{code:java}
[
https://issues.apache.org/jira/browse/KAFKA-15639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15639:
--
Description:
The testResetPositionsProcessFailureIsIgnored test looks like this:
{code:java}
@T
Kirk True created KAFKA-15639:
-
Summary: Investigate ConsumerNetworkThread's
testResetPositionsProcessFailureIsIgnored
Key: KAFKA-15639
URL: https://issues.apache.org/jira/browse/KAFKA-15639
Project: Kafk
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1364700996
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Found
[
https://issues.apache.org/jira/browse/KAFKA-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15638:
--
Description:
Regarding this comment in {{{}testPollResultTimer{}}}...
{code:java}
// purposely setting
[
https://issues.apache.org/jira/browse/KAFKA-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15638:
-
Assignee: Philip Nee (was: Kirk True)
> Investigate ConsumerNetworkThread's testPollResultTime
Kirk True created KAFKA-15638:
-
Summary: Investigate ConsumerNetworkThread's testPollResultTimer
Key: KAFKA-15638
URL: https://issues.apache.org/jira/browse/KAFKA-15638
Project: Kafka
Issue Type:
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1364699488
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java:
##
@@ -0,0 +1,3573 @@
+/*
+ * Licensed to the Apache Software Founda
[
https://issues.apache.org/jira/browse/KAFKA-15637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15637:
--
Summary: Investigate FetcherTest's/FetchRequestManager's
testFetchCompletedBeforeHandlerAdded (was: C
[
https://issues.apache.org/jira/browse/KAFKA-15637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15637:
--
Description:
Thanks for the reply. I still don't quite understand the test. Why do we
duplicate the f
Kirk True created KAFKA-15637:
-
Summary: CLONE - Investigate FetcherTest's/FetchRequestManager's
testFetchCompletedBeforeHandlerAdded
Key: KAFKA-15637
URL: https://issues.apache.org/jira/browse/KAFKA-15637
[
https://issues.apache.org/jira/browse/KAFKA-15637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15637:
--
Description:
Thanks for the reply. I still don't quite understand the test. Why do we
duplicate the f
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1364698472
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java:
##
@@ -0,0 +1,3573 @@
+/*
+ * Licensed to the Apache Software Founda
[
https://issues.apache.org/jira/browse/KAFKA-15606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15606:
--
Labels: consumer-threading-refactor (was: )
> Investigate FetcherTest's/FetchRequestManager's testCom
[
https://issues.apache.org/jira/browse/KAFKA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15557:
--
Component/s: consumer
> Investigate FetcherTest's/FetchRequestManager's duplicate metadata update in
[
https://issues.apache.org/jira/browse/KAFKA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15557:
--
Labels: consumer-threading-refactor (was: )
> Investigate FetcherTest's/FetchRequestManager's duplica
[
https://issues.apache.org/jira/browse/KAFKA-15606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15606:
--
Summary: Investigate FetcherTest's/FetchRequestManager's
testCompletedFetchRemoval (was: Verify & ref
[
https://issues.apache.org/jira/browse/KAFKA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15557:
--
Summary: Investigate FetcherTest's/FetchRequestManager's duplicate metadata
update in assignFromUserNo
[
https://issues.apache.org/jira/browse/KAFKA-15617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15617:
--
Summary: Investigate FetcherTest's/FetchRequestManager's
testFetchingPendingPartitions and testInfligh
Kirk True created KAFKA-15636:
-
Summary: Investigate FetcherTest's/FetchRequestManager's
testFetchResponseMetrics
Key: KAFKA-15636
URL: https://issues.apache.org/jira/browse/KAFKA-15636
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15636:
--
Description: {{expectedBytes}} is calculated as total, instead of avg. Is
this correct? (was: Why is
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1364696003
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java:
##
@@ -0,0 +1,3573 @@
+/*
+ * Licensed to the Apache Software Founda
[
https://issues.apache.org/jira/browse/KAFKA-15617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15617:
--
Component/s: clients
consumer
> Determine if testFetchingPendingPartitions and
> tes
[
https://issues.apache.org/jira/browse/KAFKA-15617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15617:
--
Labels: consumer-threading-refactor (was: )
> Determine if testFetchingPendingPartitions and
> testI
[
https://issues.apache.org/jira/browse/KAFKA-15617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15617:
-
Assignee: Kirk True
> Determine if testFetchingPendingPartitions and
> testInflightFetchOnPend
[
https://issues.apache.org/jira/browse/KAFKA-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15635:
--
Labels: consumer-threading-refactor (was: )
> Investigate FetcherTest's/FetchRequestManager's testFet
Kirk True created KAFKA-15635:
-
Summary: Investigate FetcherTest's/FetchRequestManager's
testFetcherLeadMetric
Key: KAFKA-15635
URL: https://issues.apache.org/jira/browse/KAFKA-15635
Project: Kafka
pprovenzano opened a new pull request, #14578:
URL: https://github.com/apache/kafka/pull/14578
Fix startup to write back the updated meta.properties file with the new
directory.id.
Fix reading of the meta.properties file to ignore the directory.id when
validating that all the meta.proper
[
https://issues.apache.org/jira/browse/KAFKA-15617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15617:
--
Priority: Minor (was: Major)
> Determine if testFetchingPendingPartitions and
> testInflightFetchOnP
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1364694361
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java:
##
@@ -0,0 +1,3573 @@
+/*
+ * Licensed to the Apache Software Founda
[
https://issues.apache.org/jira/browse/KAFKA-15634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15634:
--
Labels: consumer-threading-refactor (was: )
> Investigate FetcherTest's/FetchRequestManager's testQuo
Kirk True created KAFKA-15634:
-
Summary: Investigate FetcherTest's/FetchRequestManager's
testQuotaMetrics
Key: KAFKA-15634
URL: https://issues.apache.org/jira/browse/KAFKA-15634
Project: Kafka
I
[
https://issues.apache.org/jira/browse/KAFKA-15634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15634:
--
Priority: Minor (was: Major)
> Investigate FetcherTest's/FetchRequestManager's testQuotaMetrics
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15634:
--
Description: What is the point of the code in the initial {{while}} loop
since the receive is delayed
CalvinConfluent commented on PR #14312:
URL: https://github.com/apache/kafka/pull/14312#issuecomment-1769582360
No relevant UT failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
Proven Provenzano created KAFKA-15633:
-
Summary: Bug: Generated Persistent Directory IDs are overwritten
on startup.
Key: KAFKA-15633
URL: https://issues.apache.org/jira/browse/KAFKA-15633
Project
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1364662165
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetry.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1364661778
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetryReceiver.java:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1364661183
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetrySender.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1364653249
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetry.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1364651878
##
clients/src/main/java/org/apache/kafka/common/telemetry/collector/MetricsCollector.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundatio
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1364649053
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetrySender.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1364649332
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetrySender.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1364645649
##
clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java:
##
@@ -24,13 +24,14 @@
import org.apache.kafka.common.Reconfigurable;
import org
apoorvmittal10 commented on PR #14554:
URL: https://github.com/apache/kafka/pull/14554#issuecomment-1769500072
@wcarlson5 Thanks for approving. I have check the build and seems it's
broken due to 2 reasons. Can I fix them or else what do you suggest regarding
merge?
```
The recomm
apoorvmittal10 commented on PR #14554:
URL: https://github.com/apache/kafka/pull/14554#issuecomment-1769497837
> Looks good, @apoorvmittal10!
>
> Some minor comments, mostly for my edification.
>
> The tests are a bit anemic. Will they become more "interesting" over time?
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364625811
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsResponse.json:
##
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364622903
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsResponse.json:
##
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364622523
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json:
##
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF) unde
apoorvmittal10 commented on PR #14566:
URL: https://github.com/apache/kafka/pull/14566#issuecomment-1769489693
Thanks @wcarlson5 and @kirktrue for approving.
I see build fails because of below error which I see on other PRs as well,
can I fix that or else how we can merge the PR?
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364615810
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetryState.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
apoorvmittal10 commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364609421
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
yyu1993 commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1364594703
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -265,6 +265,96 @@ class ZkMigrationIntegrationTest {
migrationState =
migratio
gharris1727 commented on PR #14562:
URL: https://github.com/apache/kafka/pull/14562#issuecomment-1769350486
Hey @C0urante thanks for taking this on!
This is certainly an interesting first pass at the problem, and I share your
concerns about the maintenance burden and SNR.
One o
mjsax commented on code in PR #14477:
URL: https://github.com/apache/kafka/pull/14477#discussion_r1364552242
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -1586,12 +1593,15 @@ public void shouldHandleKeyQuery(
public vo
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1364507968
##
tests/kafkatest/tests/connect/connect_distributed_test.py:
##
@@ -375,6 +381,159 @@ def test_pause_state_persistent(self,
exactly_once_source, connect_protocol, me
C0urante commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1364507968
##
tests/kafkatest/tests/connect/connect_distributed_test.py:
##
@@ -375,6 +381,159 @@ def test_pause_state_persistent(self,
exactly_once_source, connect_protocol, me
kirktrue commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1364448430
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -350,6 +353,92 @@ public synchronized void update(int requestVersion,
MetadataResponse response
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1364498866
##
core/src/test/scala/other/kafka/ReplicationQuotasTestRig.scala:
##
@@ -1,340 +0,0 @@
-/**
Review Comment:
ok -- if you want to make a quick jira, that would be h
gharris1727 commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1364474243
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jeel2420 commented on code in PR #14483:
URL: https://github.com/apache/kafka/pull/14483#discussion_r1364477109
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -672,16 +673,84 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count =
mumrah commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1364475308
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1215,15 +1227,22 @@ class LogManager(logDirs: Seq[File],
cleaner.updateCheckpoints(removedLog.pare
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1364473251
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1215,15 +1227,22 @@ class LogManager(logDirs: Seq[File],
cleaner.updateCheckpoints(removedLog.par
gharris1727 commented on code in PR #14538:
URL: https://github.com/apache/kafka/pull/14538#discussion_r1364457214
##
tests/kafkatest/tests/connect/connect_distributed_test.py:
##
@@ -375,6 +381,159 @@ def test_pause_state_persistent(self,
exactly_once_source, connect_protocol,
rreddy-22 commented on PR #14524:
URL: https://github.com/apache/kafka/pull/14524#issuecomment-1769219146
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5894/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rreddy-22 commented on PR #14524:
URL: https://github.com/apache/kafka/pull/14524#issuecomment-1769217647
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5882/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
C0urante commented on PR #14562:
URL: https://github.com/apache/kafka/pull/14562#issuecomment-1769215371
I've run into some issues with integration tests on Jenkins. I'm
experimenting now with some potential fixes, and the rest of the PR should
still be ready for review in the meantime.
-
kirktrue commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1364438419
##
clients/src/main/java/org/apache/kafka/clients/MetadataCache.java:
##
@@ -150,7 +150,7 @@ MetadataCache mergeWith(String newClusterId,
// We want the most
C0urante commented on code in PR #14567:
URL: https://github.com/apache/kafka/pull/14567#discussion_r1364417579
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java:
##
@@ -302,6 +320,10 @@ private static int byteSize(byte[] bytes) {
}
mumrah commented on PR #14545:
URL: https://github.com/apache/kafka/pull/14545#issuecomment-1769176287
Thanks @cmccabe, I do vaguely remember that decision :). I've updated the PR
based on the original design.
--
This is an automated message from the Apache Git Service.
To respond to the
C0urante commented on code in PR #14567:
URL: https://github.com/apache/kafka/pull/14567#discussion_r1364407385
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java:
##
@@ -266,7 +262,29 @@ private Map
loadOffsets(Set topicPartition
private
C0urante commented on code in PR #14567:
URL: https://github.com/apache/kafka/pull/14567#discussion_r1364405086
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java:
##
@@ -266,7 +262,29 @@ private Map
loadOffsets(Set topicPartition
private
kirktrue commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364364114
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
kirktrue commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364360520
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
kirktrue commented on code in PR #14566:
URL: https://github.com/apache/kafka/pull/14566#discussion_r1364347784
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetryState.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
[
https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776850#comment-17776850
]
Greg Harris commented on KAFKA-10339:
-
[~funkerman] Hello!
In your example, no, bec
[
https://issues.apache.org/jira/browse/KAFKA-15575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776849#comment-17776849
]
Chris Egerton commented on KAFKA-15575:
---
I hate to say it, but I think this may ne
ijuma commented on code in PR #14568:
URL: https://github.com/apache/kafka/pull/14568#discussion_r1364343631
##
storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ijuma commented on code in PR #14568:
URL: https://github.com/apache/kafka/pull/14568#discussion_r1364343631
##
storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationGuard.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
kirktrue commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1364315852
##
clients/src/main/java/org/apache/kafka/common/telemetry/ClientTelemetry.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
mannoopj commented on code in PR #14389:
URL: https://github.com/apache/kafka/pull/14389#discussion_r1364322430
##
tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java:
##
@@ -0,0 +1,347 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
[
https://issues.apache.org/jira/browse/KAFKA-15620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776822#comment-17776822
]
Kamal Chandraprakash edited comment on KAFKA-15620 at 10/18/23 6:09 PM:
--
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1364319312
##
core/src/test/scala/other/kafka/ReplicationQuotasTestRig.scala:
##
@@ -1,340 +0,0 @@
-/**
Review Comment:
OK. Let's migrate those class too. Will prepare PR in
kamalcph commented on code in PR #14576:
URL: https://github.com/apache/kafka/pull/14576#discussion_r1364317572
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -302,22 +307,26 @@ public void
addCopyInProgressSegmen
kamalcph opened a new pull request, #14576:
URL: https://github.com/apache/kafka/pull/14576
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
kirktrue commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364309258
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsResponse.json:
##
@@ -0,0 +1,60 @@
+// Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/KAFKA-15632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash updated KAFKA-15632:
-
Description:
{{__remote_log_metadata}} topic cleanup policy is set to {{DELETE}}
Kamal Chandraprakash created KAFKA-15632:
Summary: Drop the invalid remote log metadata events
Key: KAFKA-15632
URL: https://issues.apache.org/jira/browse/KAFKA-15632
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776831#comment-17776831
]
Henry Cai commented on KAFKA-15620:
---
[~ckamal] Thanks, can the fix for KAFKA-15479 be
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1364292970
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -16,7 +16,7 @@
*/
Review Comment:
You can create a JIRA ticke
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1364289934
##
core/src/test/scala/other/kafka/ReplicationQuotasTestRig.scala:
##
@@ -1,340 +0,0 @@
-/**
Review Comment:
This looks like a tool that would be run externally. Yo
[
https://issues.apache.org/jira/browse/KAFKA-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776825#comment-17776825
]
Philip Nee commented on KAFKA-15631:
Currently, we have tested again the following c
[
https://issues.apache.org/jira/browse/KAFKA-15620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776822#comment-17776822
]
Kamal Chandraprakash commented on KAFKA-15620:
--
[~h...@pinterest.com]
Thi
[
https://issues.apache.org/jira/browse/KAFKA-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee reassigned KAFKA-15631:
--
Assignee: Philip Nee
> Do not send new heartbeat request while another one in-flight
> --
[
https://issues.apache.org/jira/browse/KAFKA-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776821#comment-17776821
]
Philip Nee commented on KAFKA-15631:
I believe this is already implemented as
public
apoorvmittal10 commented on PR #14560:
URL: https://github.com/apache/kafka/pull/14560#issuecomment-1768991359
> I don't have any questions to add. LGTM
Thanks @wcarlson5. I have checked the build it passes but gives below
warning which marks the build as failed. Is there something I
apoorvmittal10 commented on code in PR #14554:
URL: https://github.com/apache/kafka/pull/14554#discussion_r1364245593
##
clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json:
##
@@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF) unde
junrao commented on code in PR #14465:
URL: https://github.com/apache/kafka/pull/14465#discussion_r1364207786
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -327,6 +328,10 @@ public ControllerResult
registerBroker(
}
in
101 - 200 of 287 matches
Mail list logo
