hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1367663858
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -288,6 +298,48 @@ protected QueryResult runRangeQuery(final Quer
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1367663818
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -99,9 +101,17 @@ public class MeteredKeyValueStore
showuon commented on PR #14563:
URL: https://github.com/apache/kafka/pull/14563#issuecomment-1773668936
cc @dengziming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
hanyuzheng7 commented on code in PR #14600:
URL: https://github.com/apache/kafka/pull/14600#discussion_r1367661864
##
docs/streams/upgrade-guide.html:
##
@@ -133,6 +133,15 @@ <
More details about the new config
StreamsConfig#TOPOLOGY_OPTIMIZATION can be found in https:
hanyuzheng7 commented on code in PR #14600:
URL: https://github.com/apache/kafka/pull/14600#discussion_r1367619716
##
streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyKeyValueStore.java:
##
@@ -48,13 +48,13 @@ public interface ReadOnlyKeyValueStore {
* Get an i
hanyuzheng7 commented on PR #14600:
URL: https://github.com/apache/kafka/pull/14600#issuecomment-1773625949
> I think we should also improve `RangeQuery` JavaDocs in addition, to be
clear about ordering guarantees there, too.
ok
--
This is an automated message from the Apache Git S
mjsax commented on code in PR #14600:
URL: https://github.com/apache/kafka/pull/14600#discussion_r1367568404
##
docs/streams/upgrade-guide.html:
##
@@ -133,6 +133,15 @@ <
More details about the new config
StreamsConfig#TOPOLOGY_OPTIMIZATION can be found in https://cwik
mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1367565174
##
streams/src/main/java/org/apache/kafka/streams/query/TimestampedKeyQuery.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367565477
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -639,56 +835,175 @@ public void assign(Collection
partitions)
mjsax commented on PR #13860:
URL: https://github.com/apache/kafka/pull/13860#issuecomment-1773536152
Merged the other PR. Btw: should we split this PR into two, one to add 3.4
and one to add 3.5? So it's easier to cherry-pick? (Adding 3.5 should only go
into `3.6` branch, but adding 3.4 sh
mjsax commented on PR #14539:
URL: https://github.com/apache/kafka/pull/14539#issuecomment-1773534318
Just looked into the branch builder results for
`test_compatible_brokers_eos_v2_enabled` 2.6.3 in more details.
Broker log shows:
```
bash: /opt/kafka-2.6.3/bin/kafka-server-sta
junrao commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367562895
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -639,56 +835,175 @@ public void assign(Collection
partitions) {
[
https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15378.
-
Fix Version/s: 3.4.2
3.5.2
3.7.0
mjsax commented on PR #14539:
URL: https://github.com/apache/kafka/pull/14539#issuecomment-1773526503
Merged to `trunk` and cherry-picked to `3.6`, `3.5`, and `3.4` branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367559124
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -639,56 +835,175 @@ public void assign(Collection
partitions)
mjsax commented on PR #14539:
URL: https://github.com/apache/kafka/pull/14539#issuecomment-1773521845
For example, just re-run:
```
$
TC_PATHS="tests/kafkatest/tests/streams/streams_broker_compatibility_test.py::StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled"
bash t
junrao commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367557772
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -639,56 +835,175 @@ public void assign(Collection
partitions) {
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367556045
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -639,56 +835,175 @@ public void assign(Collection
partitions)
mjsax merged PR #14539:
URL: https://github.com/apache/kafka/pull/14539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on PR #14539:
URL: https://github.com/apache/kafka/pull/14539#issuecomment-1773506747
I did not run all of them locally yet... the upgrade tests, and cooperative
rebalancing ones only.
I am running them on my Mac, macOS Monterey (12.7), 2.3GHz 8-Core Intel i9
-- 32GB
junrao commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367537583
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -639,56 +835,175 @@ public void assign(Collection
partitions) {
kirktrue commented on PR #14406:
URL: https://github.com/apache/kafka/pull/14406#issuecomment-1773483995
FYI: I rebased against `trunk` to remove the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367536108
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -633,56 +829,178 @@ public void assign(Collection
partitions)
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367535648
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##
@@ -188,7 +194,14 @@ public CompletableFuture> fetchOffsets(
lqxshay commented on PR #14446:
URL: https://github.com/apache/kafka/pull/14446#issuecomment-1773472492
Ran a couple of failed tests in my local - they look good, like @mjsax
suggested it might be a set of flakey tests.
--
This is an automated message from the Apache Git Service.
To resp
junrao commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367516322
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventHandler.java:
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Fo
jeel2420 commented on PR #14483:
URL: https://github.com/apache/kafka/pull/14483#issuecomment-1773469285
> @jeel2420
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14483/16/testReport/junit/kafka.log.remote/RemoteIndexCacheTest/Build___JDK_8_and_Scala_2_12___testClearCacheAndInde
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367517181
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##
@@ -188,7 +194,14 @@ public CompletableFuture> fetchOffsets(
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367510616
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##
@@ -227,6 +282,13 @@ public UnsentRequest(final AbstractRequest.Bui
divijvaidya commented on PR #14483:
URL: https://github.com/apache/kafka/pull/14483#issuecomment-1773437487
@jeel2420
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14483/16/testReport/junit/kafka.log.remote/RemoteIndexCacheTest/Build___JDK_8_and_Scala_2_12___testClearCacheAndInd
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367508628
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -633,56 +832,159 @@ public void assign(Collection
partitions)
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367508455
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -872,19 +876,16 @@ public byte[] deserialize(String topic, byte[] data) {
[
https://issues.apache.org/jira/browse/KAFKA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-15651.
-
Resolution: Not A Problem
> Investigate auto commit guarantees during Consumer.assign()
> --
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1367498133
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -621,56 +824,177 @@ public void assign(Collection
partitions)
jolshan merged PR #14568:
URL: https://github.com/apache/kafka/pull/14568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-15626.
Resolution: Fixed
> Replace verification guard object with an specific type
>
mjsax commented on code in PR #14596:
URL: https://github.com/apache/kafka/pull/14596#discussion_r1367475515
##
streams/src/main/java/org/apache/kafka/streams/query/VersionedKeyQuery.java:
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
jolshan commented on PR #14568:
URL: https://github.com/apache/kafka/pull/14568#issuecomment-1773413391
Test failures look unrelated. Will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Apoorv Mittal created KAFKA-15663:
-
Summary: Implement ClientTelemetryReporter which manages telemetry
lifecyclye
Key: KAFKA-15663
URL: https://issues.apache.org/jira/browse/KAFKA-15663
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal updated KAFKA-15662:
--
Description:
The KIP requires Kafka Stream to support below method to give access to the
clie
Apoorv Mittal created KAFKA-15662:
-
Summary: Implement support for clientInstanceIds in Kafka Stream
Key: KAFKA-15662
URL: https://issues.apache.org/jira/browse/KAFKA-15662
Project: Kafka
Iss
hanyuzheng7 opened a new pull request, #14600:
URL: https://github.com/apache/kafka/pull/14600
Update Javadoc for range and reverseRange in ReadOnlyKeyValueStore.
Update upgrade-guide.html for kafka streams webpage.
### Committer Checklist (excluded from commit message)
- [ ] Ver
riedelmax commented on code in PR #14544:
URL: https://github.com/apache/kafka/pull/14544#discussion_r1367479438
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -6206,12 +6206,40 @@ class KafkaApisTest {
assertEquals(Errors.GROUP_AUTHORIZATION_FAILED.cod
[
https://issues.apache.org/jira/browse/KAFKA-15534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1966#comment-1966
]
Philip Nee commented on KAFKA-15534:
Hi - one more follow up: https://github.com/apa
[
https://issues.apache.org/jira/browse/KAFKA-15534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1963#comment-1963
]
Kirk True commented on KAFKA-15534:
---
[~pnee] can this be marked as resolved since the
[
https://issues.apache.org/jira/browse/KAFKA-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1962#comment-1962
]
Kirk True commented on KAFKA-15550:
---
[~lianetm] can this be marked as resolved since t
[
https://issues.apache.org/jira/browse/KAFKA-15658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1937#comment-1937
]
masood commented on KAFKA-15658:
What would be the tentative date of v3.6.1 or v3.7.
>
[
https://issues.apache.org/jira/browse/KAFKA-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-15357:
Description:
A new AssignmentsManager accumulates, batches, and sends assignment events to
the Co
[
https://issues.apache.org/jira/browse/KAFKA-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-15357:
Summary: Aggregate and propagate assignments (was: Aggregate and propagate
assignments and logdir
jlprat merged PR #14572:
URL: https://github.com/apache/kafka/pull/14572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
jlprat commented on PR #14572:
URL: https://github.com/apache/kafka/pull/14572#issuecomment-1773257357
All tests seem to be unrelated to the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
junrao commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1361357104
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -872,19 +876,16 @@ public byte[] deserialize(String topic, byte[] data) {
riedelmax commented on code in PR #14544:
URL: https://github.com/apache/kafka/pull/14544#discussion_r1367392319
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -444,6 +445,43 @@ public List
listGroups(List statesFi
[
https://issues.apache.org/jira/browse/KAFKA-15373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Edgar updated KAFKA-15373:
--
External issue URL: https://github.com/apache/kafka/pull/14599
> AdminClient#describeTopics sh
MikeEdgar opened a new pull request, #14599:
URL: https://github.com/apache/kafka/pull/14599
Throw `UnknownTopicIdException` instead of `InvalidTopicException` when no
name is found for the topic ID.
Similar to #6124 for `describeTopics` using a topic name. `MockAdminClient`
already
gharris1727 commented on PR #14562:
URL: https://github.com/apache/kafka/pull/14562#issuecomment-1773197588
> it's the first published one :)
This is a much better way to put it, and captures what I was going for :)
> I suppose we could do something similar where we decompose ti
philipnee commented on PR #14575:
URL: https://github.com/apache/kafka/pull/14575#issuecomment-1773183542
Thanks for taking time to address and answer my question. I think the PR
looks good. Here is the list of failing test, also jdk8 didn't finish. But I
think it is most likely irrelevan
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1773121877
`throttling_test.py` OK too:
```
[INFO:2023-10-20 10:03:55,974]: starting test run with session id
2023-10-20--002...
[INFO:2023-10-20 10:03:55,974]: running 2 tests...
[I
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1773088158
`reassign_partitions_test.py` is OK. Will check second in a minute.
```
$ git rev-parse HEAD
53e767a75f2d48c4e5419fdf83033f881f21771e
docker exec ducker01 bash -c "cd /
apoorvmittal10 commented on PR #14575:
URL: https://github.com/apache/kafka/pull/14575#issuecomment-1773065993
@kirktrue @mjsax @wcarlson5 Please let me know if I need to address
something else as well. Thanks @AndrewJSchofield and @philipnee for reviews.
--
This is an automated message f
apoorvmittal10 commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1367242148
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetrySender.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foun
philipnee closed pull request #14581: MINOR: Simplify UnsentRequest constructor
URL: https://github.com/apache/kafka/pull/14581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-15657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1859#comment-1859
]
Justine Olshan commented on KAFKA-15657:
Thanks [~twmb] and [~ijuma]. I will fol
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1773039378
> @mdedetrich Sorry I just notice now that I was "can _we_ rebase", I meant
"can _you_ rebase". If you're not able to complete this PR, let me know.
I'll have it done by Monday
C0urante merged PR #14587:
URL: https://github.com/apache/kafka/pull/14587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
C0urante commented on PR #14587:
URL: https://github.com/apache/kafka/pull/14587#issuecomment-1773026960
Makes sense, thanks for the explanation @hudeqi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tinaselenge commented on PR #14375:
URL: https://github.com/apache/kafka/pull/14375#issuecomment-1772998045
thank you @clolov!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
mjsax commented on PR #14592:
URL: https://github.com/apache/kafka/pull/14592#issuecomment-1772992359
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
[
https://issues.apache.org/jira/browse/KAFKA-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13973:
Fix Version/s: 3.5.2
> block-cache-capacity metrics worth twice as much as normal
> --
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1846#comment-1846
]
Travis Bischel commented on KAFKA-15653:
Sorry, one more note: I'm also occasion
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Travis Bischel updated KAFKA-15653:
---
Attachment: repro.sh
> NPE in ChunkedByteStream
>
>
>
mimaison commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1772979943
@mdedetrich Sorry I just notice now that I was "can _we_ rebase", I meant
"can _you_ rebase". If you're not able to complete this PR, let me know.
--
This is an automated message from
philipnee commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1367156113
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetrySender.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundatio
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1835#comment-1835
]
Travis Bischel commented on KAFKA-15653:
Maybe related?
{noformat}
org.apache.ka
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1367101090
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -125,7 +125,6 @@ class ReplicaFetcherThreadTest {
val replicaManager: ReplicaManager
chb2ab commented on PR #1:
URL: https://github.com/apache/kafka/pull/1#issuecomment-1772933027
> @chb2ab is there a JIRA for this work? If not, can we create one and
format the title as the jira title?
done, lmk if anything's missing, it's my first AK JIRA.
https://issues.apa
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1367126017
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {
pu
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1367119960
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##
@@ -98,13 +116,20 @@ private static ProduceResponseData
toData(Map
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1367118129
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##
@@ -156,7 +182,11 @@ public PartitionResponse(Errors error, long baseOffset,
long log
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1367116597
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -102,6 +104,15 @@
"about": "The preferred read replica for the consumer to use on its
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1367112293
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -619,6 +641,21 @@ class KafkaApis(val requestChannel: RequestChannel,
request.header.clientId,
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1367101090
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -125,7 +125,6 @@ class ReplicaFetcherThreadTest {
val replicaManager: ReplicaManager
nizhikov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1367075805
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,482 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
tledkov commented on code in PR #14588:
URL: https://github.com/apache/kafka/pull/14588#discussion_r1367069575
##
tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java:
##
@@ -0,0 +1,482 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
jlprat commented on PR #14572:
URL: https://github.com/apache/kafka/pull/14572#issuecomment-1772862994
I mistakenly added 2 imports in the last commit (added when writing the
example code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
Crispin Bernier created KAFKA-15661:
---
Summary: KIP-951: Server side and protocol changes
Key: KAFKA-15661
URL: https://issues.apache.org/jira/browse/KAFKA-15661
Project: Kafka
Issue Type: T
divijvaidya commented on code in PR #14583:
URL: https://github.com/apache/kafka/pull/14583#discussion_r1367044096
##
core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala:
##
@@ -43,6 +43,18 @@ class CoreUtilsTest extends Logging {
CoreUtils.swallow(throw new KafkaExcep
mumrah commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1367032618
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -265,6 +265,96 @@ class ZkMigrationIntegrationTest {
migrationState =
migration
divijvaidya merged PR #14586:
URL: https://github.com/apache/kafka/pull/14586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1772796727
@mimaison
> If so can you attach them?
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
nizhikov commented on PR #14588:
URL: https://github.com/apache/kafka/pull/14588#issuecomment-1772795864
Results from java version:
html - https://gist.github.com/nizhikov/bbfd325b2483a6cd688bcca458c36061
