[
https://issues.apache.org/jira/browse/KAFKA-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15867:
---
Parent: KAFKA-14246
Issue Type: Sub-task (was: Bug)
> Should ConsumerNetworkThread wrap the
Philip Nee created KAFKA-15867:
--
Summary: Should ConsumerNetworkThread wrap the exception and
notify the polling thread?
Key: KAFKA-15867
URL: https://issues.apache.org/jira/browse/KAFKA-15867
Project: K
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400134639
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -353,7 +380,8 @@ private void testRetriable(final CommitRequ
philipnee commented on PR #14710:
URL: https://github.com/apache/kafka/pull/14710#issuecomment-1820383565
Hey @lucasbru - Thanks again for taking the time reviewing the PR. I've
made some cleanup and changes according to your comments. Let me know if you
have further questions.
I've
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400134639
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -353,7 +380,8 @@ private void testRetriable(final CommitRequ
Philip Nee created KAFKA-15866:
--
Summary: Refactor OffsetFetchRequestState Error handling to be
more consistent with OffsetCommitRequestState
Key: KAFKA-15866
URL: https://issues.apache.org/jira/browse/KAFKA-15866
[
https://issues.apache.org/jira/browse/KAFKA-15866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15866:
---
Parent: KAFKA-14246
Issue Type: Sub-task (was: Improvement)
> Refactor OffsetFetchRequestSt
[
https://issues.apache.org/jira/browse/KAFKA-15865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788298#comment-17788298
]
Philip Nee commented on KAFKA-15865:
[~lucasbru] [~cadonna] - Would either of you be
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400074015
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -257,10 +257,77 @@ private void closeInternal(final Duration ti
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400115792
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -454,6 +491,17 @@ public OffsetFetchRequestState(final Set
part
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400064245
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##
@@ -219,4 +219,14 @@ private void onResponse(
public Opti
[
https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788233#comment-17788233
]
Phuc Hong Tran edited comment on KAFKA-15556 at 11/21/23 6:23 AM:
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400074015
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -257,10 +257,77 @@ private void closeInternal(final Duration ti
[
https://issues.apache.org/jira/browse/KAFKA-15865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15865:
---
Labels: consumer-threading-refactor kip-848-preview (was: )
> Ensure consumer.poll() execute autoco
[
https://issues.apache.org/jira/browse/KAFKA-15865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15865:
---
Parent: KAFKA-14246
Issue Type: Sub-task (was: Bug)
> Ensure consumer.poll() execute autoco
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400070106
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/AutoCommitCompletionBackgroundEvent.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apac
Philip Nee created KAFKA-15865:
--
Summary: Ensure consumer.poll() execute autocommit callback
Key: KAFKA-15865
URL: https://issues.apache.org/jira/browse/KAFKA-15865
Project: Kafka
Issue Type: Bu
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400064652
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -180,12 +188,47 @@ public void maybeAutoCommit(final Map offsets
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400064245
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##
@@ -219,4 +219,14 @@ private void onResponse(
public Opti
satishd commented on code in PR #14766:
URL: https://github.com/apache/kafka/pull/14766#discussion_r1399008945
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1424,25 +1425,71 @@ class UnifiedLog(@volatile var logStartOffset: Long,
*/
private def deleteOldSegmen
[
https://issues.apache.org/jira/browse/KAFKA-15864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-15864:
---
Description: Followup on the
[comment|https://github.com/apache/kafka/pull/14766/files#r1395
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400055966
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -90,14 +93,13 @@ public void run() {
while (runnin
apoorvmittal10 commented on PR #14699:
URL: https://github.com/apache/kafka/pull/14699#issuecomment-1820280356
Thanks @junrao for explaining the details. I have updated the PR and removed
throttleMs from ClientMetricsManager. I have added a Jira to add respective
throttling changes in Quota
Satish Duggana created KAFKA-15864:
--
Summary: Add more tests asserting the log-start-offset,
local-log-start-offset, and HW/LSO/LEO in rolling over segments with tiered
storage.
Key: KAFKA-15864
URL: https://iss
jolshan merged PR #14387:
URL: https://github.com/apache/kafka/pull/14387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on PR #14387:
URL: https://github.com/apache/kafka/pull/14387#issuecomment-1820273369
Build looks good now. I will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1400049044
##
core/src/main/scala/kafka/server/metadata/DynamicConfigPublisher.scala:
##
@@ -103,9 +103,16 @@ class DynamicConfigPublisher(
)
ca
apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1400048884
##
core/src/main/java/kafka/server/ClientMetricsManager.java:
##
@@ -16,31 +16,421 @@
*/
package kafka.server;
+import kafka.metrics.ClientMetricsConfigs;
+
Apoorv Mittal created KAFKA-15863:
-
Summary: Handle push telemetry throttling with quota manager
Key: KAFKA-15863
URL: https://issues.apache.org/jira/browse/KAFKA-15863
Project: Kafka
Issue T
jeffkbkim commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1400044251
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1400045702
##
core/src/main/java/kafka/server/ClientMetricsManager.java:
##
@@ -16,31 +16,420 @@
*/
package kafka.server;
+import kafka.metrics.ClientMetricsConfigs;
jeffkbkim commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1400045359
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
jeffkbkim commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1400044251
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1400042116
##
metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1400041537
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -327,10 +333,12 @@ public ControllerResult
registerBroker(
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1400041854
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1772,7 +1814,8 @@ void generateLeaderAndIsrUpdates(String context,
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1400041780
##
metadata/src/main/java/org/apache/kafka/controller/BrokersToElrs.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
cmccabe opened a new pull request, #14807:
URL: https://github.com/apache/kafka/pull/14807
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1400036881
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -466,6 +466,10 @@ private void
maybeUpdateLastKnownLeader(PartitionCha
apoorvmittal10 commented on PR #14632:
URL: https://github.com/apache/kafka/pull/14632#issuecomment-1820231138
> Seems there is a compilation error on the last run:
>
> ```
>
> [Error]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-14632/core/src/main/scala/kafka/serve
CalvinConfluent commented on code in PR #14612:
URL: https://github.com/apache/kafka/pull/14612#discussion_r1400016403
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1356,6 +1373,78 @@ class KafkaApis(val requestChannel: RequestChannel,
))
}
+ def handl
CalvinConfluent commented on code in PR #14612:
URL: https://github.com/apache/kafka/pull/14612#discussion_r1400016403
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1356,6 +1373,78 @@ class KafkaApis(val requestChannel: RequestChannel,
))
}
+ def handl
CalvinConfluent commented on code in PR #14612:
URL: https://github.com/apache/kafka/pull/14612#discussion_r1400015238
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1356,6 +1373,78 @@ class KafkaApis(val requestChannel: RequestChannel,
))
}
+ def handl
CalvinConfluent commented on code in PR #14612:
URL: https://github.com/apache/kafka/pull/14612#discussion_r1400011898
##
clients/src/main/resources/common/message/DescribeTopicPartitionsResponse.json:
##
@@ -0,0 +1,66 @@
+// Licensed to the Apache Software Foundation (ASF) unde
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1399989044
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1399988448
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399973308
##
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilder.java:
##
@@ -91,11 +91,13 @@ private KeyValueStore maybeWrapLoggi
[
https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788233#comment-17788233
]
Phuc Hong Tran commented on KAFKA-15556:
Hi [~kirktrue], just to clarify, with t
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399939069
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedInternal.java:
##
@@ -18,16 +18,30 @@
package org.apache.kafka.streams.kstream.internals
artemlivshits commented on code in PR #14612:
URL: https://github.com/apache/kafka/pull/14612#discussion_r1399872558
##
clients/src/main/resources/common/message/DescribeTopicPartitionsResponse.json:
##
@@ -0,0 +1,66 @@
+// Licensed to the Apache Software Foundation (ASF) under
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399930568
##
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilder.java:
##
@@ -91,11 +91,13 @@ private KeyValueStore maybeWrapLogging(fin
mjsax commented on PR #14632:
URL: https://github.com/apache/kafka/pull/14632#issuecomment-1820056764
Seems there is a compilation error on the last run:
```ask :core:compileScala
[Error]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-14632/core/src/main/scala/kafka/server
Greg Harris created KAFKA-15862:
---
Summary: Remove SecurityManager Support
Key: KAFKA-15862
URL: https://issues.apache.org/jira/browse/KAFKA-15862
Project: Kafka
Issue Type: New Feature
cmccabe commented on PR #14737:
URL: https://github.com/apache/kafka/pull/14737#issuecomment-1820033474
@soarez : This PR is causing failures in
`KRaftClusterTest.testCreateClusterAndPerformReassignment`
```
Gradle Test Run :core:test > Gradle Test Executor 2 > KRaftClusterTest >
Jesús Cea created KAFKA-15861:
-
Summary: In Kraft mode, "ssl.keystore.key" private keys are
accesible to all the controllers and brokers
Key: KAFKA-15861
URL: https://issues.apache.org/jira/browse/KAFKA-15861
cmccabe merged PR #14770:
URL: https://github.com/apache/kafka/pull/14770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
Colin McCabe created KAFKA-15860:
Summary: ControllerRegistration must be written out to the
metadata image
Key: KAFKA-15860
URL: https://issues.apache.org/jira/browse/KAFKA-15860
Project: Kafka
junrao commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1399714279
##
core/src/main/java/kafka/server/ClientMetricsManager.java:
##
@@ -16,31 +16,421 @@
*/
package kafka.server;
+import kafka.metrics.ClientMetricsConfigs;
+import k
jolshan commented on PR #14801:
URL: https://github.com/apache/kafka/pull/14801#issuecomment-1819987867
https://github.com/apache/kafka/assets/25566826/3f0c8239-2002-4d66-8455-41f299419738";>
Somehow the tests are fixed and existing failures for java 21🤔 (Again, don't
think it is your cha
jolshan commented on PR #14801:
URL: https://github.com/apache/kafka/pull/14801#issuecomment-1819985912
The failures here are out of control. I don't think it is related to your
change. I will rebuild.
--
This is an automated message from the Apache Git Service.
To respond to the message,
artemlivshits commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1399798771
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -466,6 +466,10 @@ private void
maybeUpdateLastKnownLeader(PartitionChang
anatasiavela closed pull request #7267: [WIP] KAFKA-8677: Flaky test
testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl
URL: https://github.com/apache/kafka/pull/7267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399822846
##
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyValueStoreBuilder.java:
##
@@ -91,11 +91,13 @@ private KeyValueStore maybeWrapLoggi
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399821160
##
streams/src/main/java/org/apache/kafka/streams/state/DslStoreSuppliers.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
harinirajendran opened a new pull request, #14806:
URL: https://github.com/apache/kafka/pull/14806
Flaky test failing with assertion error just outside the defined threshold.
So, bumping up the delta for quota by 1.
java.util.concurrent.ExecutionException:
org.opentest4j.AssertionFai
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399820405
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamJoinedInternal.java:
##
@@ -18,16 +18,30 @@
package org.apache.kafka.streams.kstream.int
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1399812871
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/OuterStreamJoinStoreFactory.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software
harinirajendran opened a new pull request, #14805:
URL: https://github.com/apache/kafka/pull/14805
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
ableegoldman commented on PR #14648:
URL: https://github.com/apache/kafka/pull/14648#issuecomment-1819878453
Haha yeah it's certainly grown quite a lot over the past few updates -- but
for that reason I'm actually fine with keeping it in one PR. The first time I
reviewed it there was signif
mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1399779288
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -1632,10 +1729,65 @@ public void shouldHandleRangeQuery(
mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1399777340
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -1584,7 +1646,43 @@ public void shouldHandleKeyQuery(
);
GianlucaPrincipini commented on PR #14804:
URL: https://github.com/apache/kafka/pull/14804#issuecomment-1819828622
Any suggestions to retrieve port in the best possible way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
GianlucaPrincipini opened a new pull request, #14804:
URL: https://github.com/apache/kafka/pull/14804
## Description
When a component of the Kafka broker tries to reach another broker within
the cluster the logging should be more elaborate and include the IP/hostname
and port it tries to
lihaosky commented on code in PR #14605:
URL: https://github.com/apache/kafka/pull/14605#discussion_r1399755568
##
streams/test-utils/src/test/java/org/apache/kafka/streams/test/MockFixedKeyProcessorContextTest.java:
##
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software F
JimGalasyn opened a new pull request, #14803:
URL: https://github.com/apache/kafka/pull/14803
Update the table for v3.6. Also needs to be cherry-picked to the 3.6 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1399702579
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache Software Foundation (A
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1399670915
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -76,13 +82,49 @@ class ReplicaAlterLogDirsThread(name: String,
futureLog.updateHighWater
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1399669761
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -76,13 +82,49 @@ class ReplicaAlterLogDirsThread(name: String,
futureLog.updateHighWater
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1399667766
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -76,13 +82,49 @@ class ReplicaAlterLogDirsThread(name: String,
futureLog.updateHighWater
gharris1727 commented on code in PR #14769:
URL: https://github.com/apache/kafka/pull/14769#discussion_r1399656534
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2IntegrationTest.java:
##
@@ -418,6 +418,8 @@ public String metricsScope() {
})
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1399656268
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -1632,10 +1729,65 @@ public void shouldHandleRangeQuery(
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1399652671
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -1584,7 +1646,43 @@ public void shouldHandleKeyQuery(
)
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1399632055
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -1584,7 +1646,43 @@ public void shouldHandleKeyQuery(
)
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1399632055
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -1584,7 +1646,43 @@ public void shouldHandleKeyQuery(
)
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1399627999
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -76,13 +82,49 @@ class ReplicaAlterLogDirsThread(name: String,
futureLog.updateHighWater
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1399627137
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -76,13 +82,49 @@ class ReplicaAlterLogDirsThread(name: String,
futureLog.updateHighWater
mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1399617212
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -1584,7 +1646,43 @@ public void shouldHandleKeyQuery(
);
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1399605671
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -76,13 +82,49 @@ class ReplicaAlterLogDirsThread(name: String,
futureLog.updateHighWater
hachikuji merged PR #14697:
URL: https://github.com/apache/kafka/pull/14697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
hachikuji commented on PR #14697:
URL: https://github.com/apache/kafka/pull/14697#issuecomment-1819609057
@junrao I triggered a few builds and didn't see much consistency in the test
failures. I tried some of the tests locally and they passed. I will go ahead
and merge to trunk.
--
This
lihaosky commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1397782005
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java:
##
@@ -609,17 +842,18 @@ public void testOrdering() {
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1399579994
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -327,10 +333,12 @@ public ControllerResult
registerBroker(
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1399575912
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1294,8 +1315,11 @@ void handleBrokerFenced(int brokerId,
List reco
lihaosky commented on code in PR #14696:
URL: https://github.com/apache/kafka/pull/14696#discussion_r1399571144
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/Graph.java:
##
@@ -117,6 +131,8 @@ private Graph(final boolean isResidualGraph) {
dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1399570354
##
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##
@@ -0,0 +1,199 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1399564930
##
core/src/main/java/kafka/server/AssignmentsManager.java:
##
@@ -210,6 +220,9 @@ public void run() throws Exception {
channelManager.sendRequest(new Assi
lihaosky commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1399561823
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java:
##
@@ -791,7 +791,7 @@ public void
shouldNotEmitLeftJoinResultFo
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1399559787
##
core/src/main/java/kafka/server/AssignmentsManager.java:
##
@@ -146,6 +153,9 @@ public void run() throws Exception {
log.debug("Received new assignm
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1399558750
##
core/src/main/java/kafka/server/AssignmentsManager.java:
##
@@ -146,6 +153,9 @@ public void run() throws Exception {
log.debug("Received new assignm
junrao commented on PR #14632:
URL: https://github.com/apache/kafka/pull/14632#issuecomment-1819538489
@apoorvmittal10 : Thanks for triaging the failed tests. There is still no
green build though.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
1 - 100 of 171 matches
Mail list logo
