AndrewJSchofield commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1401554867
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache Software F
[
https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788627#comment-17788627
]
Phuc Hong Tran commented on KAFKA-15556:
what seems weird to me is that
# {{is
[
https://issues.apache.org/jira/browse/KAFKA-14508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788624#comment-17788624
]
Alexander Aghili commented on KAFKA-14508:
--
Hey there, I would like to be assig
[
https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788618#comment-17788618
]
Phuc Hong Tran commented on KAFKA-15556:
btw, why did you called those 3 methods
github-actions[bot] commented on PR #14160:
URL: https://github.com/apache/kafka/pull/14160#issuecomment-1822035606
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
artemlivshits commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1401454282
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -528,6 +536,10 @@ private void maybePopulateTargetElr() {
.c
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401429874
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401429553
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401429251
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401429114
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401419710
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java:
##
@@ -223,22 +223,13 @@ protected boolean racks
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401419710
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java:
##
@@ -223,22 +223,13 @@ protected boolean racks
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401413975
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
[
https://issues.apache.org/jira/browse/KAFKA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-14552:
Description:
Kafka 4.0 will remove support for zk mode and kraft mode became production
ready in
[
https://issues.apache.org/jira/browse/KAFKA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788593#comment-17788593
]
Ismael Juma commented on KAFKA-14552:
-
[~cmccabe] I noticed your work on
[KIP-1001|
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401404458
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401404039
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
Ismael Juma created KAFKA-15874:
---
Summary: Add metric and request log attribute for deprecated
request api versions
Key: KAFKA-15874
URL: https://issues.apache.org/jira/browse/KAFKA-15874
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-15874:
Summary: Add metric and request log attribute for deprecated request api
versions (KIP-896) (was:
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401401639
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401400649
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401397868
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401392351
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
ex172000 opened a new pull request, #14814:
URL: https://github.com/apache/kafka/pull/14814
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
ex172000 commented on PR #14698:
URL: https://github.com/apache/kafka/pull/14698#issuecomment-1821902047
> Note that this PR in it's current form leads to a large number of test
failures. Please ensure that we fix the tests before marking it ready for
review.
Thank you Divij for the
ex172000 commented on code in PR #14808:
URL: https://github.com/apache/kafka/pull/14808#discussion_r1401350219
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/CredentialCache.java:
##
@@ -16,53 +16,59 @@
*/
package org.apache.kafka.common.security.aut
junrao commented on code in PR #14242:
URL: https://github.com/apache/kafka/pull/14242#discussion_r1401341215
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -421,16 +430,12 @@ public NavigableMap epochWithOffsets() {
}
junrao commented on code in PR #14811:
URL: https://github.com/apache/kafka/pull/14811#discussion_r1401339000
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -7090,6 +7093,51 @@ private static MemberDescription
convertToMemberDescription
CalvinConfluent commented on PR #14612:
URL: https://github.com/apache/kafka/pull/14612#issuecomment-1821848023
As discussed offline, we will focus on the pagination behavior.
The performance optimization is tracked in
https://issues.apache.org/jira/browse/KAFKA-15873
--
This is an aut
Calvin Liu created KAFKA-15873:
--
Summary: Improve the performance of the DescribeTopicPartitions API
Key: KAFKA-15873
URL: https://issues.apache.org/jira/browse/KAFKA-15873
Project: Kafka
Issue
bob-barrett opened a new pull request, #14813:
URL: https://github.com/apache/kafka/pull/14813
…dresses are available
This change is a follow-up to https://github.com/apache/kafka/pull/9902.
When re-resolving DNS after disconnecting, it is possible (likely, even) that
we will resolve
ocadaruma commented on code in PR #14242:
URL: https://github.com/apache/kafka/pull/14242#discussion_r1401316698
##
storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java:
##
@@ -308,7 +308,14 @@ public void truncateFromEnd(long endOffset) {
ableegoldman merged PR #14648:
URL: https://github.com/apache/kafka/pull/14648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
[ https://issues.apache.org/jira/browse/KAFKA-15215 ]
Almog Gavra deleted comment on KAFKA-15215:
-
was (Author: agavra):
Note that we decided not to have default.dsl.store work if you only pass it in
to the main KafkaStreams constructor for bac
[
https://issues.apache.org/jira/browse/KAFKA-15774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Almog Gavra resolved KAFKA-15774.
-
Fix Version/s: 3.7.0
Resolution: Fixed
Note that we decided not to have default.dsl.store
[
https://issues.apache.org/jira/browse/KAFKA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788559#comment-17788559
]
Almog Gavra commented on KAFKA-15215:
-
Note that we decided not to have default.dsl.
[
https://issues.apache.org/jira/browse/KAFKA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Almog Gavra resolved KAFKA-15215.
-
Fix Version/s: 3.7.0
Resolution: Fixed
> The default.dsl.store config is not compatible w
ableegoldman commented on PR #14648:
URL: https://github.com/apache/kafka/pull/14648#issuecomment-1821731448
Looks like all the builds are compiling, but we have 18 flaky tests. I
checked all of them and none seem to be related to this PR. I also haven't seen
any concerns about any of the u
junrao commented on code in PR #14242:
URL: https://github.com/apache/kafka/pull/14242#discussion_r1401104692
##
storage/src/main/java/org/apache/kafka/storage/internals/log/SnapshotFile.java:
##
@@ -60,10 +60,10 @@ public File file() {
return file;
}
-public
ijuma commented on code in PR #14808:
URL: https://github.com/apache/kafka/pull/14808#discussion_r1401209924
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/CredentialCache.java:
##
@@ -16,53 +16,59 @@
*/
package org.apache.kafka.common.security.authen
[
https://issues.apache.org/jira/browse/KAFKA-15869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788552#comment-17788552
]
Anton Agestam commented on KAFKA-15869:
---
[~dajac] Ah, thanks for pointing me in th
lucasbru merged PR #14710:
URL: https://github.com/apache/kafka/pull/14710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on PR #14710:
URL: https://github.com/apache/kafka/pull/14710#issuecomment-1821647788
Test failures are unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
junrao commented on PR #14632:
URL: https://github.com/apache/kafka/pull/14632#issuecomment-1821564843
@apoorvmittal10 :
1. Do you know why JDK 11 and Scala 2.13 didn't build?
2. For getting green build, it would be useful to help triage the new test
failures. If we could identify the
ijuma closed pull request #14809: MINOR: Remove deprecated methods from
DescribeLogDirsResults
URL: https://github.com/apache/kafka/pull/14809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
ijuma commented on PR #14809:
URL: https://github.com/apache/kafka/pull/14809#issuecomment-1821542230
Thanks for the PR. We can't remove deprecated methods until a major release
(for example Apache Kafka 4.0). So, closing this for now.
--
This is an automated message from the Apache Git S
cmccabe commented on code in PR #14807:
URL: https://github.com/apache/kafka/pull/14807#discussion_r1401042371
##
metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java:
##
@@ -205,4 +207,22 @@ private static List
getImageRecords(ClusterImage image) {
imag
jsancio commented on code in PR #14807:
URL: https://github.com/apache/kafka/pull/14807#discussion_r1400991206
##
metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java:
##
@@ -205,4 +207,22 @@ private static List
getImageRecords(ClusterImage image) {
imag
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1401001513
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r140155
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1400998694
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java:
##
@@ -96,7 +96,7 @@ public GroupAssignment assign(
private
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1400990586
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
dajac commented on code in PR #14800:
URL: https://github.com/apache/kafka/pull/14800#discussion_r1400988059
##
core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala:
##
@@ -0,0 +1,402 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dongnuo123 commented on code in PR #14800:
URL: https://github.com/apache/kafka/pull/14800#discussion_r1400986806
##
core/src/test/scala/unit/kafka/server/SyncGroupRequestTest.scala:
##
@@ -0,0 +1,283 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
dajac commented on code in PR #14800:
URL: https://github.com/apache/kafka/pull/14800#discussion_r1400987513
##
core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala:
##
@@ -0,0 +1,402 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dongnuo123 commented on code in PR #14800:
URL: https://github.com/apache/kafka/pull/14800#discussion_r1400981634
##
core/src/test/scala/unit/kafka/server/SyncGroupRequestTest.scala:
##
@@ -0,0 +1,283 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788496#comment-17788496
]
Arpit Goyal commented on KAFKA-15388:
-
[~divijvaidya] [~satish.duggana] [~showuon] A
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1400980116
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,903 @@
* See the License for t
dongnuo123 commented on code in PR #14800:
URL: https://github.com/apache/kafka/pull/14800#discussion_r1400981634
##
core/src/test/scala/unit/kafka/server/SyncGroupRequestTest.scala:
##
@@ -0,0 +1,283 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
dongnuo123 commented on code in PR #14800:
URL: https://github.com/apache/kafka/pull/14800#discussion_r1400973546
##
core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala:
##
@@ -0,0 +1,402 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1400975524
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
kirktrue commented on PR #14773:
URL: https://github.com/apache/kafka/pull/14773#issuecomment-1821397271
> Done! I think this PR can be closed, because it was superseded by #14810
Yes, I will close it with this very comment 😉
--
This is an automated message from the Apache Git Serv
kirktrue closed pull request #14773: KAFKA-15837: Throw error on use of
Consumer.poll(long timeout)
URL: https://github.com/apache/kafka/pull/14773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
cadonna commented on PR #14773:
URL: https://github.com/apache/kafka/pull/14773#issuecomment-1821394688
Done!
I think this PR can be closed, because it was superseded by
https://github.com/apache/kafka/pull/14810
--
This is an automated message from the Apache Git Service.
To respond t
nikramakrishnan commented on code in PR #14649:
URL: https://github.com/apache/kafka/pull/14649#discussion_r1400962913
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1754,6 +1754,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
leaderEpochCache.forea
cadonna commented on PR #14758:
URL: https://github.com/apache/kafka/pull/14758#issuecomment-1821395496
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
kirktrue commented on PR #14773:
URL: https://github.com/apache/kafka/pull/14773#issuecomment-1821391050
@lucasbru / @cadonna—can we add the `ctr` label for posterity? Then I'll
close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nikramakrishnan commented on code in PR #14649:
URL: https://github.com/apache/kafka/pull/14649#discussion_r1400962913
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1754,6 +1754,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
leaderEpochCache.forea
kirktrue commented on PR #14758:
URL: https://github.com/apache/kafka/pull/14758#issuecomment-1821388129
@cadonna / @lucasbru—can we add the `ctr` label to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
kirktrue commented on PR #14789:
URL: https://github.com/apache/kafka/pull/14789#issuecomment-1821385512
@jolshan would you mind adding the `ctr` label on this for posterity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kirktrue commented on PR #14768:
URL: https://github.com/apache/kafka/pull/14768#issuecomment-1821382525
FYI: there are some failing integration tests that need to be updated to
reflect this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
cmccabe merged PR #14737:
URL: https://github.com/apache/kafka/pull/14737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
Lucent-Wong commented on code in PR #14666:
URL: https://github.com/apache/kafka/pull/14666#discussion_r1400935789
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##
@@ -3782,6 +3784,33 @@ class GroupCoordinatorTest {
assertTrue(groupCoordina
mimaison commented on PR #14812:
URL: https://github.com/apache/kafka/pull/14812#issuecomment-1821341297
@ijuma @dajac Please take a look if you have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
mimaison opened a new pull request, #14812:
URL: https://github.com/apache/kafka/pull/14812
- `audience-annotations` seems to come from ZooKeeper. I was surprised I had
to downgrade it but I confirmed that [ZK
3.8.3](https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.8.3/apache-zoo
rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1400884026
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java:
##
@@ -14,17 +14,891 @@
* See the License for t
vamossagar12 commented on code in PR #14666:
URL: https://github.com/apache/kafka/pull/14666#discussion_r1400864801
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##
@@ -3782,6 +3784,33 @@ class GroupCoordinatorTest {
assertTrue(groupCoordin
Hongten commented on code in PR #3874:
URL: https://github.com/apache/kafka/pull/3874#discussion_r1400867677
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -234,13 +250,22 @@ class LogManager(logDirs: Seq[File],
logDirFailureChannel = logDirFailureChannel)
lucasbru commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400862984
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -202,6 +210,40 @@ public CompletableFuture
maybeAutoCommitAllCon
philipnee commented on PR #14710:
URL: https://github.com/apache/kafka/pull/14710#issuecomment-1821258981
I filed a ticket for investigation. I think we should always try to send an
autocommit during close otherwise we are risking to lose progress. In fact, I
need to look into the code to
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400860157
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -202,6 +210,40 @@ public CompletableFuture
maybeAutoCommitAllCo
Philip Nee created KAFKA-15872:
--
Summary: Investigate autocommit retry logic
Key: KAFKA-15872
URL: https://issues.apache.org/jira/browse/KAFKA-15872
Project: Kafka
Issue Type: Sub-task
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400850677
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -202,6 +210,40 @@ public CompletableFuture
maybeAutoCommitAllCo
dajac commented on PR #14544:
URL: https://github.com/apache/kafka/pull/14544#issuecomment-1821237941
I have also noted that the code does not compile. Could you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
lucasbru commented on PR #14710:
URL: https://github.com/apache/kafka/pull/14710#issuecomment-1821203326
LGTM, thanks!
There is one minor point open (about checking `inflightAutocommit` during
close) that should block the merge though
--
This is an automated message from the Apach
lucasbru commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400818478
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -202,6 +210,40 @@ public CompletableFuture
maybeAutoCommitAllCon
dajac commented on code in PR #14800:
URL: https://github.com/apache/kafka/pull/14800#discussion_r1400798929
##
core/src/test/scala/unit/kafka/server/SyncGroupRequestTest.scala:
##
@@ -0,0 +1,283 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
harinirajendran closed pull request #14805: MINOR: Increase the delta for a
flaky quota test
URL: https://github.com/apache/kafka/pull/14805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
harinirajendran closed pull request #14806: MINOR: Increase the delta for a
flaky quota test
URL: https://github.com/apache/kafka/pull/14806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
harinirajendran commented on PR #14805:
URL: https://github.com/apache/kafka/pull/14805#issuecomment-1821167150
We decided to fix this flaky test in our fork for now. So, closing the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
Andrew Schofield created KAFKA-15871:
Summary: Implement kafka-client-metrics.sh tool
Key: KAFKA-15871
URL: https://issues.apache.org/jira/browse/KAFKA-15871
Project: Kafka
Issue Type: Su
[
https://issues.apache.org/jira/browse/KAFKA-15837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-15837.
--
Resolution: Fixed
> Throw error on use of Consumer.poll(long timeout)
> --
AndrewJSchofield commented on PR #14773:
URL: https://github.com/apache/kafka/pull/14773#issuecomment-1821132824
This PR has been superseded and can be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
philipnee commented on PR #14710:
URL: https://github.com/apache/kafka/pull/14710#issuecomment-1821126057
Hi @lucasbru - Thanks for the feedback, I updated the
`BackgroundEventProcessor` to handle `AutoCommitCompletionBackgroundEvent`.
Though, I left a TODO, would this be alright?
h
philipnee commented on code in PR #14710:
URL: https://github.com/apache/kafka/pull/14710#discussion_r1400754491
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -202,6 +210,40 @@ public CompletableFuture
maybeAutoCommitAllCo
dajac commented on code in PR #14544:
URL: https://github.com/apache/kafka/pull/14544#discussion_r1400669970
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3693,8 +3693,49 @@ class KafkaApis(val requestChannel: RequestChannel,
}
def handleConsumerGroupDescri
soarez commented on PR #14737:
URL: https://github.com/apache/kafka/pull/14737#issuecomment-1821057902
@cmccabe thanks for checking. tests are passing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/KAFKA-15803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-15803:
--
Assignee: Lucas Brutschy (was: Philip Nee)
> Update last seen epoch during commit
>
cadonna merged PR #14810:
URL: https://github.com/apache/kafka/pull/14810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
OmniaGM commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1400641749
##
core/src/main/java/kafka/server/AssignmentsManager.java:
##
@@ -336,6 +356,27 @@ private static boolean responseIsError(ClientResponse
response) {
return f
1 - 100 of 137 matches
Mail list logo
