Re: [PR] KAFKA-15887: Ensure FindCoordinatorRequest is sent before closing [kafka]

2023-11-26 Thread via GitHub
philipnee commented on code in PR #14842: URL: https://github.com/apache/kafka/pull/14842#discussion_r1405771339 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -254,8 +255,9 @@ private void closeInternal(final Duration

[jira] [Commented] (KAFKA-15658) Zookeeper.jar | CVE-2023-44981

2023-11-26 Thread David Dufour (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789949#comment-17789949 ] David Dufour commented on KAFKA-15658: -- Is there any plan to fix 3.5.x as well? > Zookeeper.jar |

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-26 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1405739030 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -691,6 +735,91 @@ public void

[PR] KAFKA-15887: Ensure FindCoordinatorRequest is sent before closing [kafka]

2023-11-26 Thread via GitHub
philipnee opened a new pull request, #14842: URL: https://github.com/apache/kafka/pull/14842 A few bugs was created from the previous issues. These are: 1. During testing or some edge cases, the coordinator request manager might hold on to an inflight request forever. Therefore, when

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-26 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1405739030 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -691,6 +735,91 @@ public void

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-26 Thread via GitHub
vamossagar12 commented on PR #14432: URL: https://github.com/apache/kafka/pull/14432#issuecomment-1827266684 @dajac , thank you for another round of review. I have handled all review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-26 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1405738152 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -691,6 +735,91 @@ public void

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-26 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1405737404 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -849,21 +922,53 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-26 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1405737202 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -223,20 +238,30 @@ public

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-26 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1405733434 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1004,27 +1118,102 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-26 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1405732647 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1004,27 +1118,102 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-26 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1405732004 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -766,6 +834,11 @@ private void throwIfMemberEpochIsInvalid(

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-26 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1405732141 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -849,21 +922,53 @@ private CoordinatorResult consumerGr

[jira] [Created] (KAFKA-15902) Topic partitions cannot be automatically cleaned up, leading to disk space occupation

2023-11-26 Thread Gao Fei (Jira)
Gao Fei created KAFKA-15902: --- Summary: Topic partitions cannot be automatically cleaned up, leading to disk space occupation Key: KAFKA-15902 URL: https://issues.apache.org/jira/browse/KAFKA-15902 Project:

Re: [PR] MINOR: Correcting Javadoc for ConnectAssertions [kafka]

2023-11-26 Thread via GitHub
yashmayya commented on code in PR #14827: URL: https://github.com/apache/kafka/pull/14827#discussion_r1405642306 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/ConnectAssertions.java: ## @@ -524,7 +524,7 @@ public void assertConnectorIsStopped(String

[jira] [Updated] (KAFKA-15857) Introduce LocalLogStartOffset and TieredOffset in OffsetSpec.

2023-11-26 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15857: --- Fix Version/s: 3.7.0 > Introduce LocalLogStartOffset and TieredOffset in OffsetSpec. >

[jira] [Commented] (KAFKA-15798) Flaky Test NamedTopologyIntegrationTest.shouldAddAndRemoveNamedTopologiesBeforeStartingAndRouteQueriesToCorrectTopology()

2023-11-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789901#comment-17789901 ] A. Sophie Blee-Goldman commented on KAFKA-15798: cc [~mjsax] [~wcarlson5] – maybe some

[jira] [Commented] (KAFKA-15798) Flaky Test NamedTopologyIntegrationTest.shouldAddAndRemoveNamedTopologiesBeforeStartingAndRouteQueriesToCorrectTopology()

2023-11-26 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789898#comment-17789898 ] A. Sophie Blee-Goldman commented on KAFKA-15798: Took a quick look at this in the name

Re: [PR] KAFKA-15047: Roll active segment when it breaches the retention policy [kafka]

2023-11-26 Thread via GitHub
satishd commented on PR #14766: URL: https://github.com/apache/kafka/pull/14766#issuecomment-1827083641 @clolov: The queries that you had in your earlier comments were addressed by @kamalcph, please take a look. I plan to merge these changes if you have no further comments. Thanks. --

Re: [PR] KAFKA-15241: Compute tiered copied offset by keeping the respective epochs in scope [kafka]

2023-11-26 Thread via GitHub
satishd merged PR #14787: URL: https://github.com/apache/kafka/pull/14787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15241: Compute tiered copied offset by keeping the respective epochs in scope [kafka]

2023-11-26 Thread via GitHub
satishd commented on PR #14787: URL: https://github.com/apache/kafka/pull/14787#issuecomment-1827078547 Test failures in jenkins jobs are unrelated to this change, merging it to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-9693: Kafka latency spikes caused by log segment flush on roll [kafka]

2023-11-26 Thread via GitHub
github-actions[bot] commented on PR #13782: URL: https://github.com/apache/kafka/pull/13782#issuecomment-1827074604 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15372: Reconfigure dedicated MM2 connectors after leadership change [kafka]

2023-11-26 Thread via GitHub
github-actions[bot] commented on PR #14293: URL: https://github.com/apache/kafka/pull/14293#issuecomment-1827074429 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] MINOR: Add retry for CI [kafka]

2023-11-26 Thread via GitHub
ex172000 commented on PR #14828: URL: https://github.com/apache/kafka/pull/14828#issuecomment-1827030588 > Thanks for the PR. The Jenkins file already sets those settings to retry failed tests in cradle. See here: > >

Re: [PR] KAFKA-15361: Process and persist dir info with broker registration [kafka]

2023-11-26 Thread via GitHub
pprovenzano commented on code in PR #14838: URL: https://github.com/apache/kafka/pull/14838#discussion_r1405538961 ## server-common/src/main/java/org/apache/kafka/common/DirectoryId.java: ## @@ -121,8 +122,38 @@ public static Map createAssignmentMap(int[] replicas, Uuid[] dire

Re: [PR] KAFKA-15817: Avoid reconnecting to the same IP address if multiple ad… [kafka]

2023-11-26 Thread via GitHub
ijuma commented on PR #14813: URL: https://github.com/apache/kafka/pull/14813#issuecomment-1826881644 Thanks for the PR. Let's cherry pick this to 3.6 after this is merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-26 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1405422751 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -445,6 +446,42 @@ public List listGroups(List statesFi

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-26 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1405412781 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,32 @@ public String

[jira] [Created] (KAFKA-15901) Implement client changes to support telemetry APIs

2023-11-26 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15901: - Summary: Implement client changes to support telemetry APIs Key: KAFKA-15901 URL: https://issues.apache.org/jira/browse/KAFKA-15901 Project: Kafka Issue

[PR] KAFKA-15894: Fix KafkaApis.updateRecordConversionStats to ensure MessageConversionsTimeMs and TemporaryMemoryBytes are recorded correctly [kafka]

2023-11-26 Thread via GitHub
runom opened a new pull request, #14841: URL: https://github.com/apache/kafka/pull/14841 `KafkaApis.updateRecordConversionStats` may be called multiple times for a request, and `request.messageConversionsTimeNanos` and `request.temporaryMemoryBytes` are overwritten in this method.