soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1416235526
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,26 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def
mjsax merged PR #14908:
URL: https://github.com/apache/kafka/pull/14908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apoorvmittal10 commented on PR #14928:
URL: https://github.com/apache/kafka/pull/14928#issuecomment-1841553248
@mjsax @wcarlson5 Build passed with unrelated flaky tests. Please if you
could take a look.
--
This is an automated message from the Apache Git Service.
To respond to the
mjsax commented on PR #14908:
URL: https://github.com/apache/kafka/pull/14908#issuecomment-1841550699
Build issues:
- Second run: `JDK 8 and Scala 2.12`
- Third run: `JDK 17 and Scala 2.13`
Failing KS tests pass locally (so they seems to be flaky only). Others are
flaky/not
apoorvmittal10 commented on PR #14933:
URL: https://github.com/apache/kafka/pull/14933#issuecomment-1841542850
@junrao @AndrewJSchofield Please if I can get the review on the Minor PR for
the improvement of KIP-714 by using functionality exposed by KIP-1000. Also
added support for listing
apoorvmittal10 opened a new pull request, #14933:
URL: https://github.com/apache/kafka/pull/14933
PR includes:
- Improvement for KIP-1000 to list client metrics resources in
KafkaApis.scala.
- Using functionality exposed by KIP-1000 to support describe all metrics
operations for
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1416220626
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -653,12 +653,15 @@ public DeadlineAndEpoch
mjsax commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1416208410
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java:
##
@@ -153,14 +192,189 @@ private void
aliehsaeedii commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1416206067
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java:
##
@@ -153,14 +192,189 @@ private void
mjsax commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1414568376
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation
mjsax commented on code in PR #14898:
URL: https://github.com/apache/kafka/pull/14898#discussion_r1416203067
##
docs/streams/upgrade-guide.html:
##
@@ -136,7 +136,12 @@ <
Streams API changes in 3.7.0
IQv2 supports RangeQuery that allows to specify
aliehsaeedii commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1416196786
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreTest.java:
##
@@ -471,15 +475,195 @@ public void
cmccabe commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1416166357
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -121,8 +122,38 @@ public static Map createAssignmentMap(int[]
replicas, Uuid[] dire
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1416158929
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
jolshan commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1416142507
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -187,8 +190,6 @@ public CoordinatorResult
commitOffset(
hanyuzheng7 commented on code in PR #14898:
URL: https://github.com/apache/kafka/pull/14898#discussion_r1416130187
##
docs/streams/upgrade-guide.html:
##
@@ -136,9 +136,16 @@ <
Streams API changes in 3.7.0
IQv2 supports RangeQuery that allows to specify
[
https://issues.apache.org/jira/browse/KAFKA-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793393#comment-17793393
]
Kirk True commented on KAFKA-15974:
---
cc [~schofielaj] [~pnee] [~lianetm]
> Enforce that
[
https://issues.apache.org/jira/browse/KAFKA-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15974:
--
Description:
The intention of the {{CompletableApplicationEvent}} is for a {{Consumer}} to
block
[
https://issues.apache.org/jira/browse/KAFKA-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15974:
--
Labels: consumer-threading-refactor kip-848-client-support (was: )
> Enforce that
[
https://issues.apache.org/jira/browse/KAFKA-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15974:
--
Description:
The intention of the {{CompletableApplicationEvent}} is for a {{Consumer}} to
block
[
https://issues.apache.org/jira/browse/KAFKA-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15974:
--
Summary: Enforce that CompletableApplicationEvent has a timeout that is
respected (was: Enforce that
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1416124293
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
Kirk True created KAFKA-15974:
-
Summary: Enforce that CompletableApplicationEvent has a timeout
Key: KAFKA-15974
URL: https://issues.apache.org/jira/browse/KAFKA-15974
Project: Kafka
Issue Type:
msn-tldr commented on PR #14916:
URL: https://github.com/apache/kafka/pull/14916#issuecomment-1841370385
So JDK 17 build failed with following and its unrelated.
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14916/5/pipeline/11/
```
hanyuzheng7 commented on code in PR #14898:
URL: https://github.com/apache/kafka/pull/14898#discussion_r1416115869
##
docs/streams/upgrade-guide.html:
##
@@ -136,9 +136,16 @@ <
Streams API changes in 3.7.0
IQv2 supports RangeQuery that allows to specify
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1416090404
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
*/
private var registered = false
+
[
https://issues.apache.org/jira/browse/KAFKA-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur reassigned KAFKA-15968:
Assignee: David Arthur
> QuorumController does not treat CorruptRecordException as fatal
C0urante commented on code in PR #14562:
URL: https://github.com/apache/kafka/pull/14562#discussion_r1416090471
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/Stage.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
wcarlson5 merged PR #14843:
URL: https://github.com/apache/kafka/pull/14843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #14235:
URL: https://github.com/apache/kafka/pull/14235#issuecomment-1841275546
Thanks Mickael!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
C0urante merged PR #14235:
URL: https://github.com/apache/kafka/pull/14235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wcarlson5 commented on PR #14908:
URL: https://github.com/apache/kafka/pull/14908#issuecomment-1841271853
Looks like there is still a build issue :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wcarlson5 merged PR #14910:
URL: https://github.com/apache/kafka/pull/14910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on code in PR #14293:
URL: https://github.com/apache/kafka/pull/14293#discussion_r1416019825
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##
@@ -314,6 +356,23 @@ private void
wcarlson5 commented on PR #14910:
URL: https://github.com/apache/kafka/pull/14910#issuecomment-1841261270
Yeah was just waiting for the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison commented on PR #14932:
URL: https://github.com/apache/kafka/pull/14932#issuecomment-1841256405
@mjsax @dajac @vvcephei Can you upload the 3.6.1 artifacts to the
kafka-packages S3 bucket?
Steps are described in
mimaison opened a new pull request, #14932:
URL: https://github.com/apache/kafka/pull/14932
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
C0urante commented on PR #14235:
URL: https://github.com/apache/kafka/pull/14235#issuecomment-1841246801
@gharris1727 @mimaison would either of you have time to take a quick look at
this docs backport? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1415971670
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ConsumerRebalanceListenerCallbackNeededEvent.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1415963877
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -979,12 +1026,124 @@ private CompletableFuture
AndrewJSchofield commented on code in PR #14912:
URL: https://github.com/apache/kafka/pull/14912#discussion_r1415963329
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1169,34 +1169,48 @@ private Fetch collectFetch() {
C0urante commented on code in PR #14893:
URL: https://github.com/apache/kafka/pull/14893#discussion_r1415960042
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##
@@ -770,6 +771,9 @@ public void
kirktrue commented on code in PR #14879:
URL: https://github.com/apache/kafka/pull/14879#discussion_r1415960044
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -292,6 +297,90 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793355#comment-17793355
]
Igor Soarez commented on KAFKA-15366:
-
[~viktorsomogyi] thanks for helping with this! Yes, thats
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1415957086
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -650,7 +693,7 @@ boolean reconcile() {
C0urante commented on code in PR #14893:
URL: https://github.com/apache/kafka/pull/14893#discussion_r1415954634
##
connect/mirror/src/test/resources/log4j.properties:
##
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations
kirktrue commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1841154914
Closing and reopening to force a new build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kirktrue opened a new pull request, #14640:
URL: https://github.com/apache/kafka/pull/14640
Added logic for coordinating the invocation of the
`ConsumerRebalanceListener` callback invocations between the background thread
(in `MembershipManagerImpl`) and the application thread
kirktrue closed pull request #14640: KAFKA-15276: Implement event plumbing for
ConsumerRebalanceListener callbacks
URL: https://github.com/apache/kafka/pull/14640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1415930727
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerRebalanceListenerInvoker.java:
##
@@ -66,15 +66,15 @@ Exception
kirktrue commented on PR #14931:
URL: https://github.com/apache/kafka/pull/14931#issuecomment-1841152541
@philipnee can you add the `ctr` and `KIP-848` tags, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
philipnee commented on PR #14920:
URL: https://github.com/apache/kafka/pull/14920#issuecomment-1841153219
Hi @lucasbru - Thanks for the response. unfortunately, the way the mock is
setup and how other tests are written, close will have dependencies to the
network thread, which means we are
kirktrue commented on PR #14931:
URL: https://github.com/apache/kafka/pull/14931#issuecomment-1841151662
@dajac This is the shared bit pulled out from #14640 as you'd requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kirktrue opened a new pull request, #14931:
URL: https://github.com/apache/kafka/pull/14931
For forthcoming changes, make this class and its methods public for use
outside the package. Also fix a minor logging issue to include the object in
the log, not its `Optional` wrapper.
--
This
Mickael Maison created KAFKA-15973:
--
Summary: quota_test.py system tests are flaky
Key: KAFKA-15973
URL: https://issues.apache.org/jira/browse/KAFKA-15973
Project: Kafka
Issue Type: Bug
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415898460
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,26 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415898460
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,26 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def
dajac commented on code in PR #14911:
URL: https://github.com/apache/kafka/pull/14911#discussion_r1415886265
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -251,6 +251,114 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
vamossagar12 commented on code in PR #14911:
URL: https://github.com/apache/kafka/pull/14911#discussion_r1415870715
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -251,6 +251,112 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
lucasbru opened a new pull request, #14930:
URL: https://github.com/apache/kafka/pull/14930
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
soarez commented on code in PR #14863:
URL: https://github.com/apache/kafka/pull/14863#discussion_r1415836932
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -2016,6 +2021,70 @@ ListPartitionReassignmentsResponseData
dajac commented on code in PR #14911:
URL: https://github.com/apache/kafka/pull/14911#discussion_r1415823136
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -251,6 +251,112 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
soarez commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1415818541
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -354,6 +356,25 @@ public ControllerResult
registerBroker(
throw
soarez commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1415817804
##
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##
@@ -284,7 +286,7 @@ ReplicaPlacer replicaPlacer() {
public void activate() {
vamossagar12 commented on code in PR #14911:
URL: https://github.com/apache/kafka/pull/14911#discussion_r1415815684
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -137,6 +137,99 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
soarez commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1415813979
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -61,6 +67,11 @@ static class BrokerHeartbeatState {
*/
AndrewJSchofield closed pull request #14894: KAFKA-15831: KIP-1000 protocol and
admin client
URL: https://github.com/apache/kafka/pull/14894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield commented on PR #14894:
URL: https://github.com/apache/kafka/pull/14894#issuecomment-1841016273
Closed followed merge of https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793324#comment-17793324
]
Viktor Somogyi-Vass edited comment on KAFKA-15366 at 12/5/23 3:20 PM:
[
https://issues.apache.org/jira/browse/KAFKA-15705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-15705.
-
Fix Version/s: 3.7.0
Resolution: Fixed
> Add integration tests for Heartbeat API and
clolov commented on code in PR #14929:
URL: https://github.com/apache/kafka/pull/14929#discussion_r1415790106
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java:
##
@@ -194,19 +206,19 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793324#comment-17793324
]
Viktor Somogyi-Vass commented on KAFKA-15366:
-
[~soarez] did you have anything in mind other
clolov commented on PR #14929:
URL: https://github.com/apache/kafka/pull/14929#issuecomment-1840995487
Heya @cadonna! This pull request is aiming to move one of the three
remaining classes to Mockito mock by mock. I would be very grateful for a
review when you have the time
--
This
clolov opened a new pull request, #14929:
URL: https://github.com/apache/kafka/pull/14929
This pull request takes a similar approach to how TaskManagerTest is being
migrated to Mockito mock by mock for easier reviews.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-15831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-15831.
-
Fix Version/s: 3.7.0
Resolution: Fixed
merged the PR to trunk.
> List Client Metrics
[
https://issues.apache.org/jira/browse/KAFKA-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793321#comment-17793321
]
Viktor Somogyi-Vass commented on KAFKA-14127:
-
I'll try one of the tests and perhaps review
junrao merged PR #14811:
URL: https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415748253
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,26 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def
[
https://issues.apache.org/jira/browse/KAFKA-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass reassigned KAFKA-15366:
---
Assignee: Viktor Somogyi-Vass
> Log directory failure integration test
>
aiven-anton commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1415703531
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -14,14 +14,16 @@
// limitations under the License.
// Version 1 adds Zk
soarez commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415655849
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def
lucasbru commented on PR #14920:
URL: https://github.com/apache/kafka/pull/14920#issuecomment-1840841524
@philipnee I don't see `AsyncKafkaConsumer` failing in CI, so not sure. Have
you fixed it already?
I'd suggest to get this PR in shape and test the close functionality
nizhikov commented on PR #14856:
URL: https://github.com/apache/kafka/pull/14856#issuecomment-1840840108
@mimaison Will you be able to take a look?
This is first PR to transfer `ConsumerGroupCommand` to java.
--
This is an automated message from the Apache Git Service.
To respond
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415618371
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2643,6 +2645,17 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ private def
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415612624
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2741,6 +2755,18 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ private def
dajac commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1415612525
##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -239,10 +240,14 @@ public static String safeUniqueTestName(final
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415612007
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2741,6 +2755,18 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ private def
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415611267
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -123,14 +123,19 @@ class LogManager(logDirs: Seq[File],
}
private val dirLocks =
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415609251
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415609251
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1415604987
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def
[
https://issues.apache.org/jira/browse/KAFKA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-15893:
Description: MetadataVersion.LATEST_PRODUCTION needs to be set to
IBP_3_7_IV2 or higher to enable
aliehsaeedii commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r1415599211
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java:
##
@@ -153,14 +192,189 @@ private void
dajac commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1415597424
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -1659,4 +1685,117 @@ public void
clolov commented on code in PR #14788:
URL: https://github.com/apache/kafka/pull/14788#discussion_r1415577294
##
clients/src/main/java/org/apache/kafka/clients/admin/OffsetSpec.java:
##
@@ -70,4 +71,8 @@ public static OffsetSpec maxTimestamp() {
return new
clolov commented on code in PR #14788:
URL: https://github.com/apache/kafka/pull/14788#discussion_r1415575816
##
tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java:
##
@@ -132,7 +132,7 @@ public GetOffsetShellOptions(String[] args) throws
TerseException {
apoorvmittal10 commented on PR #14928:
URL: https://github.com/apache/kafka/pull/14928#issuecomment-1840734909
@AndrewJSchofield @mjsax @wcarlson5 @philipnee Minor PR to enable telemetry,
please review.
--
This is an automated message from the Apache Git Service.
To respond to the
apoorvmittal10 opened a new pull request, #14928:
URL: https://github.com/apache/kafka/pull/14928
- PR removes tag to mark API unstable in request json.
- Suppresses couple of failed telemetry API logs as those unnecessary appear
when telemetry is not supported on broker.
###
dajac commented on code in PR #14862:
URL: https://github.com/apache/kafka/pull/14862#discussion_r1415539960
##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -239,10 +240,14 @@ public static String safeUniqueTestName(final
dajac merged PR #14882:
URL: https://github.com/apache/kafka/pull/14882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
101 - 200 of 253 matches
Mail list logo
