soarez commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1415818541


##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -354,6 +356,25 @@ public ControllerResult<BrokerRegistrationReply> 
registerBroker(
             throw new BrokerIdNotRegisteredException("Controller is in 
pre-migration mode and cannot register KRaft " +
                 "brokers until the metadata migration is complete.");
         }
+
+        if (featureControl.metadataVersion().isDirectoryAssignmentSupported()) 
{
+            Set<Uuid> set = new HashSet<>(request.logDirs());
+            if (set.stream().anyMatch(DirectoryId::reserved)) {
+                throw new DuplicateBrokerRegistrationException("Reserved 
directory ID in request");

Review Comment:
   Updated all three cases to throw `InvalidRequestException` instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to