soarez commented on code in PR #14838:
URL: https://github.com/apache/kafka/pull/14838#discussion_r1415817804
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -284,7 +286,7 @@ ReplicaPlacer replicaPlacer() {
public void activate() {
heartbeatManager = new BrokerHeartbeatManager(logContext, time,
sessionTimeoutNs);
for (BrokerRegistration registration : brokerRegistrations.values()) {
- heartbeatManager.touch(registration.id(), registration.fenced(),
-1);
+ heartbeatManager.register(registration.id(),
registration.fenced(), registration.directories());
Review Comment:
> And we need to issue a new BrokerRegistrationRecord when they change.
We do that in #14902 which builds on this.
I have removed directory state from the heartbeat manager, we now rely only
on `ClusterControlManager`, and any persisted metadata state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
