github-actions[bot] commented on PR #14146:
URL: https://github.com/apache/kafka/pull/14146#issuecomment-1848846779
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
vamossagar12 commented on code in PR #14966:
URL: https://github.com/apache/kafka/pull/14966#discussion_r1421385777
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##
@@ -324,127 +363,151 @@ public void
testAlterSinkConnecto
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1421567480
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -123,7 +123,9 @@ class LogManager(logDirs: Seq[File],
}
private val dirLocks = lockLogDirs(liveLogDirs)
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421561676
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -169,7 +169,7 @@ class PlaintextConsumerTest extends BaseConsumerTest {
startingT
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421557841
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -180,12 +179,12 @@ private void process(final ListOffs
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1421508998
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
testOnSubscriptionUpdatedTran
lianetm commented on PR #14873:
URL: https://github.com/apache/kafka/pull/14873#issuecomment-1848609666
Thanks for the changes @philipnee , LGTM.
I would only +1 on @lucasbru suggestion of locally running the existing
`PlainTextConsumer` integration test on this PR, as it is currentl
Lalolokos1 commented on PR #14843:
URL: https://github.com/apache/kafka/pull/14843#issuecomment-1848585115
https://hraccess.att.com/hraccess/#/dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
pprovenzano commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1421489097
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -123,7 +123,9 @@ class LogManager(logDirs: Seq[File],
}
private val dirLocks = lockLogDirs(liveLogD
Phuc-Hong-Tran commented on PR #14979:
URL: https://github.com/apache/kafka/pull/14979#issuecomment-1848422315
@kirktrue, Can I have a review for this PR? Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Phuc-Hong-Tran opened a new pull request, #14979:
URL: https://github.com/apache/kafka/pull/14979
Change:
*Refactored `AbstractFetch` so only `Fetcher` will check for node status
when creating fetch requests.
### Committer Checklist (excluded from commit message)
- [ ] Verif
Phuc-Hong-Tran commented on PR #14978:
URL: https://github.com/apache/kafka/pull/14978#issuecomment-1848399183
nvm I discarded those changes, this pr need some more work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Phuc-Hong-Tran closed pull request #14978: KAFKA-15556 [WIP]: Remove
NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and
tryConnect
URL: https://github.com/apache/kafka/pull/14978
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
Phuc-Hong-Tran commented on PR #14978:
URL: https://github.com/apache/kafka/pull/14978#issuecomment-1848396488
@kirktrue, Can I have a review for this PR? Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Phuc-Hong-Tran opened a new pull request, #14978:
URL: https://github.com/apache/kafka/pull/14978
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary
msn-tldr commented on PR #14916:
URL: https://github.com/apache/kafka/pull/14916#issuecomment-1848384342
@wcarlson5 thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sudeshwasnik commented on code in PR #14966:
URL: https://github.com/apache/kafka/pull/14966#discussion_r1421394339
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##
@@ -70,74 +80,115 @@ public class OffsetsApiIntegrationTes
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florin Akermann resolved KAFKA-12317.
-
Resolution: Fixed
> Relax non-null key requirement for left/outer KStream joins
> --
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1848322802
> Thanks @vamossagar12, I've given the functional changes another pass.
Unless I'm mistaken about the semantics for `CompletableFuture::thenAccept`,
there's a pretty serious bug in t
[
https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florin Akermann resolved KAFKA-14748.
-
Resolution: Fixed
> Relax non-null FK left-join requirement
> --
20 matches
Mail list logo
