Phuc-Hong-Tran opened a new pull request, #15188:
URL: https://github.com/apache/kafka/pull/15188
Change:
1. Implement methods in AsyncKafkaConsumer that accept SubscriptionPattern
to subscribe to topic(s).
2. Pass on the subscriptionPattern to SubscriptionState to use once server
sup
Phuc-Hong-Tran commented on PR #15188:
URL: https://github.com/apache/kafka/pull/15188#issuecomment-1890427403
@lianetm, PTAL, thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806275#comment-17806275
]
Phuc Hong Tran commented on KAFKA-15561:
thanks for confirming [~schofielaj]
>
[
https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806274#comment-17806274
]
Phuc Hong Tran commented on KAFKA-15561:
[~lianetm], I have created a pull reque
Florin Akermann created KAFKA-16123:
---
Summary: KStreamKStreamJoinProcessor forwards null records for
left/outer joins unconditionally of the join window.
Key: KAFKA-16123
URL: https://issues.apache.org/jira/brow
florin-akermann opened a new pull request, #15189:
URL: https://github.com/apache/kafka/pull/15189
KStreamKStreamJoinProcessor forwards null records for left/outer joins
unconditionally of the join window.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florin Akermann updated KAFKA-16123:
Description:
As part of KIP-962 the non-null key requirements have been relaxed for left a
apoorvmittal10 commented on code in PR #15148:
URL: https://github.com/apache/kafka/pull/15148#discussion_r1451062702
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -715,15 +716,22 @@ private Optional>
createPushRequest(
apoorvmittal10 opened a new pull request, #15190:
URL: https://github.com/apache/kafka/pull/15190
PR adds support to capture client socket port information in Request
Context. The port from request context is used as matching criteria in
filtering clients and shall be used by metrics plugin
apoorvmittal10 commented on PR #15190:
URL: https://github.com/apache/kafka/pull/15190#issuecomment-1890806724
@junrao @AndrewJSchofield Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
apoorvmittal10 commented on code in PR #15190:
URL: https://github.com/apache/kafka/pull/15190#discussion_r1451631637
##
clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java:
##
@@ -37,6 +37,7 @@ public class RequestContext implements
AuthorizableRequestCo
[
https://issues.apache.org/jira/browse/KAFKA-16088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-16088:
---
Description:
This issue is about covering local log segments also while finding the segment
[
https://issues.apache.org/jira/browse/KAFKA-15958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-15958.
---
Resolution: Won't Do
> Add tests to validate telemetry requests with different version
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806412#comment-17806412
]
Apoorv Mittal commented on KAFKA-15958:
---
[~pnee] I have looked into the suggestion
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806413#comment-17806413
]
Satish Duggana commented on KAFKA-15388:
[PR-15060|https://github.com/apache/kaf
[
https://issues.apache.org/jira/browse/KAFKA-15952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806414#comment-17806414
]
Apoorv Mittal commented on KAFKA-15952:
---
[~pnee] I think I misunderstood the feedb
satishd commented on PR #15060:
URL: https://github.com/apache/kafka/pull/15060#issuecomment-1890811313
@iit2009060 As we discussed earlier in the
[comment](https://github.com/apache/kafka/pull/15060#issuecomment-1882487316),
this issue is only applicable to compact policy and the behaviour
[
https://issues.apache.org/jira/browse/KAFKA-15952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-15952.
---
Resolution: Won't Do
> Create public doc for telemetry state transition
> --
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1451645649
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -4112,11 +4112,18 @@ public void testIncrementalAlterConfigs() throws
Exceptio
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1451645779
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -265,3 +266,12 @@ class ClientMetricsConfigHandler(private val
clientMetricsManager: ClientMetrics
c
DL1231 commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-1890832758
Thanks @AndrewJSchofield for the feedback, I have addressed comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
Owen-CH-Leung commented on code in PR #13909:
URL: https://github.com/apache/kafka/pull/13909#discussion_r1451645916
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -1263,6 +1327,8 @@ protected String getConfigValue(ConfigKey key, String
headerName
Owen-CH-Leung commented on code in PR #13909:
URL: https://github.com/apache/kafka/pull/13909#discussion_r1451645916
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -1263,6 +1327,8 @@ protected String getConfigValue(ConfigKey key, String
headerName
Owen-CH-Leung commented on code in PR #14891:
URL: https://github.com/apache/kafka/pull/14891#discussion_r1451666065
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -159,100 +166,117 @@ public void close() throws Exception {
@Parameteri
showuon commented on code in PR #14891:
URL: https://github.com/apache/kafka/pull/14891#discussion_r1451667979
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -159,100 +166,117 @@ public void close() throws Exception {
@ParameterizedTes
25 matches
Mail list logo
