[jira] [Resolved] (KAFKA-16157) Topic recreation with offline disk doesn't update leadership/shrink ISR correctly

2024-02-02 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-16157. --- Resolution: Fixed > Topic recreation with offline disk doesn't update leadership/shrink ISR > corre

Re: [PR] KAFKA-16157: fix topic recreation handling with offline disks [kafka]

2024-02-02 Thread via GitHub
showuon merged PR #15263: URL: https://github.com/apache/kafka/pull/15263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16157: fix topic recreation handling with offline disks [kafka]

2024-02-02 Thread via GitHub
showuon commented on PR #15263: URL: https://github.com/apache/kafka/pull/15263#issuecomment-1925168574 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-02 Thread via GitHub
appchemist commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1476948608 ## core/src/test/scala/unit/kafka/server/epoch/LeaderEpochIntegrationTest.scala: ## @@ -142,17 +143,20 @@ class LeaderEpochIntegrationTest extends QuorumTestHarness

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-02 Thread via GitHub
appchemist commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1476948401 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -559,6 +559,31 @@ object TestUtils extends Logging { controllers.foreach(controller => ensureCons

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

2024-02-02 Thread via GitHub
artemlivshits commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1476922434 ## tools/src/main/java/org/apache/kafka/tools/TopicCommand.java: ## @@ -799,6 +814,13 @@ public TopicCommandOptions(String[] args) { "if set when

[jira] [Updated] (KAFKA-15970) KIP-951, port newly added tests in FetcherTest.java to FetchRequestManagerTest.ajva

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15970: -- Labels: kip-951 (was: ) > KIP-951, port newly added tests in FetcherTest.java to > FetchRequestManag

Re: [PR] KAFKA-16180: Fix UMR and LAIR handling during ZK migration [kafka]

2024-02-02 Thread via GitHub
cmccabe merged PR #15293: URL: https://github.com/apache/kafka/pull/15293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-15283) Client support for OffsetFetch and OffsetCommit with topic ID

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15283: -- Fix Version/s: 4.0.0 (was: 3.8.0) > Client support for OffsetFetch and OffsetCo

[jira] [Updated] (KAFKA-15846) Review consumer leave group request best effort and response handling

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15846: -- Priority: Critical (was: Major) > Review consumer leave group request best effort and response handli

[jira] [Updated] (KAFKA-15325) Integrate topicId in OffsetFetch and OffsetCommit async consumer calls

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15325: -- Priority: Critical (was: Major) > Integrate topicId in OffsetFetch and OffsetCommit async consumer ca

[jira] [Updated] (KAFKA-16011) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnClose

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16011: -- Priority: Critical (was: Major) > Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnClose >

[jira] [Updated] (KAFKA-15832) Trigger client reconciliation based on manager poll

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15832: -- Priority: Critical (was: Major) > Trigger client reconciliation based on manager poll > -

[jira] [Updated] (KAFKA-15948) Refactor AsyncKafkaConsumer shutdown

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15948: -- Priority: Critical (was: Major) > Refactor AsyncKafkaConsumer shutdown >

[jira] [Updated] (KAFKA-16032) Review client errors thrown on OffsetFetch and OffsetCommit failures

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16032: -- Priority: Critical (was: Major) > Review client errors thrown on OffsetFetch and OffsetCommit failure

[jira] [Updated] (KAFKA-16203) AutoCommit of empty offsets blocks following requests due to inflight flag

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16203: -- Priority: Critical (was: Major) > AutoCommit of empty offsets blocks following requests due to inflig

[jira] [Updated] (KAFKA-16033) Review client retry logic of OffsetFetch and OffsetCommit responses

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16033: -- Priority: Critical (was: Major) > Review client retry logic of OffsetFetch and OffsetCommit responses

[jira] [Updated] (KAFKA-16107) Ensure consumer does not start fetching from added partitions until onPartitionsAssigned completes

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16107: -- Priority: Critical (was: Major) > Ensure consumer does not start fetching from added partitions until

[jira] [Updated] (KAFKA-16194) KafkaConsumer.groupMetadata() should be correct when first records are returned

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16194: -- Priority: Critical (was: Major) > KafkaConsumer.groupMetadata() should be correct when first records

[jira] [Updated] (KAFKA-16215) Consumer does not rejoin after fenced on delayed revocation

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16215: -- Priority: Critical (was: Major) > Consumer does not rejoin after fenced on delayed revocation > -

[jira] [Updated] (KAFKA-16111) Implement tests for tricky rebalance callback scenarios

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16111: -- Labels: callback consumer-threading-refactor integration-tests (was: callback consumer-threading-refa

[jira] [Updated] (KAFKA-15270) Integration tests for AsyncConsumer simple consume case

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15270: -- Labels: consumer-threading-refactor integration-tests (was: consumer-threading-refactor kip-848-previ

[jira] [Updated] (KAFKA-15942) Implement ConsumerInterceptor

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15942: -- Priority: Blocker (was: Major) > Implement ConsumerInterceptor > - > >

[jira] [Updated] (KAFKA-16151) Fix PlaintextConsumerTest.testPerPartitionLeadMetricsCleanUpWithSubscribe

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16151: -- Priority: Critical (was: Major) > Fix PlaintextConsumerTest.testPerPartitionLeadMetricsCleanUpWithSub

[jira] [Updated] (KAFKA-16104) Enable additional PlaintextConsumerTest tests for new consumer

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16104: -- Priority: Critical (was: Minor) > Enable additional PlaintextConsumerTest tests for new consumer > --

[jira] [Updated] (KAFKA-16150) Fix PlaintextConsumerTest.testPerPartitionLagMetricsCleanUpWithSubscribe

2024-02-02 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16150: -- Priority: Critical (was: Major) > Fix PlaintextConsumerTest.testPerPartitionLagMetricsCleanUpWithSubs

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-02 Thread via GitHub
kirktrue commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1476752511 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-02 Thread via GitHub
lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1476728141 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-02 Thread via GitHub
lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1476728141 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-02-02 Thread via GitHub
infantlikesprogramming commented on PR #15296: URL: https://github.com/apache/kafka/pull/15296#issuecomment-1924617830 @mimaison Would you mind reviewing my PR? Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-02 Thread via GitHub
kirktrue commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1476536785 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-02 Thread via GitHub
kirktrue commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1476532820 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-15761: KRaft support in EpochDrivenReplicationProtocolAcceptanceTest [kafka]

2024-02-02 Thread via GitHub
highluck commented on PR #15295: URL: https://github.com/apache/kafka/pull/15295#issuecomment-1924430067 @mimaison thanks I've edited the part you mentioned! Please review! thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Version downgrade for shadow jar plugin [kafka]

2024-02-02 Thread via GitHub
ijuma commented on PR #15308: URL: https://github.com/apache/kafka/pull/15308#issuecomment-1924421951 @apoorvmittal10 Thanks for getting to the bottom of this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-02-02 Thread via GitHub
cmccabe merged PR #15262: URL: https://github.com/apache/kafka/pull/15262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] Ctr rebalance metrics [kafka]

2024-02-02 Thread via GitHub
philipnee closed pull request #15310: Ctr rebalance metrics URL: https://github.com/apache/kafka/pull/15310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Version downgrade for shadow jar plugin [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #15308: URL: https://github.com/apache/kafka/pull/15308#issuecomment-1924370139 @stanislavkozlovski I let you backport to 3.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Version downgrade for shadow jar plugin [kafka]

2024-02-02 Thread via GitHub
mimaison merged PR #15308: URL: https://github.com/apache/kafka/pull/15308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-16178) AsyncKafkaConsumer doesn't retry joining the group after rediscovering group coordinator

2024-02-02 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813771#comment-17813771 ] Lianet Magrans commented on KAFKA-16178: You're right [~pnee]! I found out while

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-02 Thread via GitHub
lianetm commented on PR #15311: URL: https://github.com/apache/kafka/pull/15311#issuecomment-1924313236 Hey @dajac , this fixes the issue we were discussing about the 2 console consumers fenced but never rejoining. This same bug was surely behind the other issue, of consumer not rejoining a

[PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-02 Thread via GitHub
lianetm opened a new pull request, #15311: URL: https://github.com/apache/kafka/pull/15311 This fixes a bug that was causing that members wouldn't rejoin the group after receiving an error in the heartbeat response (ex. fenced, not coordinator, as reported in KAFKA-16215 and KAFKA-16178). T

Re: [PR] KAFKA-15761: KRaft support in EpochDrivenReplicationProtocolAcceptanceTest [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #15295: URL: https://github.com/apache/kafka/pull/15295#issuecomment-1924267094 Thanks for the PR. The code does not seem to compile. See the errors in https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15295/2/pipeline -- This i

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-02 Thread via GitHub
mimaison commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1476307322 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -559,6 +559,31 @@ object TestUtils extends Logging { controllers.foreach(controller => ensureConsis

[PR] Ctr rebalance metrics [kafka]

2024-02-02 Thread via GitHub
philipnee opened a new pull request, #15310: URL: https://github.com/apache/kafka/pull/15310 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testi

[jira] [Resolved] (KAFKA-16115) AsyncKafkaConsumer: Add missing heartbeat metrics

2024-02-02 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-16115. Resolution: Fixed > AsyncKafkaConsumer: Add missing heartbeat metrics > --

Re: [PR] KAFKA-14412: Add statestore.uncommitted.max.bytes [kafka]

2024-02-02 Thread via GitHub
nicktelford commented on code in PR #15264: URL: https://github.com/apache/kafka/pull/15264#discussion_r1476237948 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java: ## @@ -152,6 +153,13 @@ public List allSegments(final boolean forward) {

Re: [PR] KAFKA-14412: Add statestore.uncommitted.max.bytes [kafka]

2024-02-02 Thread via GitHub
nicktelford commented on code in PR #15264: URL: https://github.com/apache/kafka/pull/15264#discussion_r1476236204 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -404,4 +404,11 @@ public synchronized Map allTasksPerId() { public bool

Re: [PR] KAFKA-14412: Add statestore.uncommitted.max.bytes [kafka]

2024-02-02 Thread via GitHub
nicktelford commented on code in PR #15264: URL: https://github.com/apache/kafka/pull/15264#discussion_r1476235869 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java: ## @@ -1073,6 +1078,35 @@ int commit(final Collection tasksToCommit) {

Re: [PR] Upgrade/maven artifact version [kafka]

2024-02-02 Thread via GitHub
bmscomp commented on PR #15309: URL: https://github.com/apache/kafka/pull/15309#issuecomment-1924081440 @mimaison This is a replacement for the this closed request (was by mistake ) https://github.com/apache/kafka/pull/14146 -- This is an automated message from the Apache Git Servic

[PR] Upgrade/maven artifact version [kafka]

2024-02-02 Thread via GitHub
bmscomp opened a new pull request, #15309: URL: https://github.com/apache/kafka/pull/15309 The main motivation behind this change is to keep dependencies updated to the latest stable version of tools used to build and publish kafka, and one of the most of important tools is maven artifac

Re: [PR] MINOR: Upgrade maven Artifact version to 3.9.4 [kafka]

2024-02-02 Thread via GitHub
bmscomp commented on PR #14146: URL: https://github.com/apache/kafka/pull/14146#issuecomment-1924078746 @mimaison Cannot find a trick to re-open this pull request, waiting to find one, I will create another one that will replace it and update the maven artifact to 3.9.6 instead of 3.9.4

Re: [PR] KAFKA-14412: Add statestore.uncommitted.max.bytes [kafka]

2024-02-02 Thread via GitHub
nicktelford commented on code in PR #15264: URL: https://github.com/apache/kafka/pull/15264#discussion_r1476175960 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1343,6 +1348,17 @@ private long getCacheSizePerThread(final int numStreamThreads) {

Re: [PR] KAFKA-14412: Add statestore.uncommitted.max.bytes [kafka]

2024-02-02 Thread via GitHub
nicktelford commented on code in PR #15264: URL: https://github.com/apache/kafka/pull/15264#discussion_r1476172950 ## streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java: ## @@ -1320,6 +1320,19 @@ public void shouldUseDefaultStateStoreCacheMaxBytesConfigWhenNo

Re: [PR] MINOR: Few cleanups to JaasContext/Utils classes [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #14994: URL: https://github.com/apache/kafka/pull/14994#issuecomment-1924055963 We don't support the 2.8 branch anymore. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] MINOR: Few cleanups to JaasContext/Utils classes [kafka]

2024-02-02 Thread via GitHub
mimaison closed pull request #14994: MINOR: Few cleanups to JaasContext/Utils classes URL: https://github.com/apache/kafka/pull/14994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] MINOR: Upgrade jqwik to version 1.8.2 [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #14365: URL: https://github.com/apache/kafka/pull/14365#issuecomment-1924054180 @yashmayya @divijvaidya I'll let you finish the review. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-02-02 Thread via GitHub
mimaison commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1476129852 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See

Re: [PR] KAFKA-15723: KRaft support in ListOffsetsRequestTest [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #15047: URL: https://github.com/apache/kafka/pull/15047#issuecomment-1923995552 It looks like this breaks `ListOffsetsRequestWithRemoteStoreTest`. See the test results: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15047/2/testReport/ -- This is an a

Re: [PR] MINOR: New year code clean up - misc [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #15071: URL: https://github.com/apache/kafka/pull/15071#issuecomment-1923992830 This needs another rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Resolved] (KAFKA-15728) KRaft support in DescribeUserScramCredentialsRequestNotAuthorizedTest

2024-02-02 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-15728. Fix Version/s: 3.8.0 Resolution: Fixed > KRaft support in DescribeUserScramCredenti

Re: [PR] KAFKA-15728: KRaft support in DescribeUserScramCredentialsRequestNotAuthorizedTest [kafka]

2024-02-02 Thread via GitHub
mimaison merged PR #14736: URL: https://github.com/apache/kafka/pull/14736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Upgrade jqwik to version 1.8.2 [kafka]

2024-02-02 Thread via GitHub
bmscomp commented on PR #14365: URL: https://github.com/apache/kafka/pull/14365#issuecomment-1923976723 @mimaison Rebase done and conflicts are resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] MINOR: Upgrade maven Artifact version to 3.9.4 [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #14146: URL: https://github.com/apache/kafka/pull/14146#issuecomment-1923974229 You should be able to reopen it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] MINOR: Upgrade maven Artifact version to 3.9.4 [kafka]

2024-02-02 Thread via GitHub
bmscomp commented on PR #14146: URL: https://github.com/apache/kafka/pull/14146#issuecomment-1923961082 @mimaison I wanted to rebase this pull request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Updated] (KAFKA-9693) Kafka latency spikes caused by log segment flush on roll

2024-02-02 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-9693: Fix Version/s: 3.7.0 (was: 3.8.0) > Kafka latency spikes caused by log segme

Re: [PR] MINOR: Fix toString method of IsolationLevel [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #14782: URL: https://github.com/apache/kafka/pull/14782#issuecomment-1923931680 Re-kicked a build: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14782/9/ -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Suggest for performance fix: KAFKA-9693 Kafka latency spikes caused by log segment flush on roll [kafka]

2024-02-02 Thread via GitHub
divijvaidya closed pull request #13768: Suggest for performance fix: KAFKA-9693 Kafka latency spikes caused by log segment flush on roll URL: https://github.com/apache/kafka/pull/13768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] KAFKA-16115: Adding missing heartbeat metrics [kafka]

2024-02-02 Thread via GitHub
lucasbru merged PR #15216: URL: https://github.com/apache/kafka/pull/15216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16220: Increase timeout in KTableKTableForeignKeyInnerJoinCustomPartitionerIntegrationTest [kafka]

2024-02-02 Thread via GitHub
lucasbru merged PR #15307: URL: https://github.com/apache/kafka/pull/15307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] Suggest for performance fix: KAFKA-9693 Kafka latency spikes caused by log segment flush on roll [kafka]

2024-02-02 Thread via GitHub
divijvaidya commented on PR #13768: URL: https://github.com/apache/kafka/pull/13768#issuecomment-1923926345 This PR is fixed in trunk (scheduled for release in 3.7.0). Currently there are no plans of backporting this to earlier versions since this is a performance optimization and not a cri

[jira] [Resolved] (KAFKA-9693) Kafka latency spikes caused by log segment flush on roll

2024-02-02 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-9693. - Resolution: Fixed This performance regression where producer snapshot fsync leads to high P99 la

Re: [PR] KAFKA-9693: Kafka latency spikes caused by log segment flush on roll [kafka]

2024-02-02 Thread via GitHub
divijvaidya commented on PR #13782: URL: https://github.com/apache/kafka/pull/13782#issuecomment-1923906249 Thanks for checking @ocadaruma . I am going to close this PR, please feel free to re-open if you think that this is still not fixed. -- This is an automated message from the Apache

Re: [PR] KAFKA-9693: Kafka latency spikes caused by log segment flush on roll [kafka]

2024-02-02 Thread via GitHub
divijvaidya closed pull request #13782: KAFKA-9693: Kafka latency spikes caused by log segment flush on roll URL: https://github.com/apache/kafka/pull/13782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: Log the ZK dual-write time [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #14792: URL: https://github.com/apache/kafka/pull/14792#issuecomment-1923904974 @mumrah @cmccabe Can we merge this now? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] KAFKA-15739: KRaft support in ResetConsumerGroupOffsetTest [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #14686: URL: https://github.com/apache/kafka/pull/14686#issuecomment-1923889429 Thanks for the PR! We're half way through moving `ConsumerGroupCommand` ([KAFKA-14589](https://issues.apache.org/jira/browse/KAFKA-14589)). It's probably best to finish the move before u

[jira] [Assigned] (KAFKA-15625) Do not flush global state store at each commit

2024-02-02 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari reassigned KAFKA-15625: --- Assignee: Ayoub Omari > Do not flush global state store at each commit > --

[jira] [Commented] (KAFKA-15625) Do not flush global state store at each commit

2024-02-02 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813682#comment-17813682 ] Ayoub Omari commented on KAFKA-15625: - [~cadonna] I am assigning myself to the ticke

Re: [PR] MINOR: Upgrade maven Artifact version to 3.9.4 [kafka]

2024-02-02 Thread via GitHub
bmscomp closed pull request #14146: MINOR: Upgrade maven Artifact version to 3.9.4 URL: https://github.com/apache/kafka/pull/14146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-15560: Upgrade argparse4j to 0.9.0 [kafka]

2024-02-02 Thread via GitHub
mimaison closed pull request #14507: KAFKA-15560: Upgrade argparse4j to 0.9.0 URL: https://github.com/apache/kafka/pull/14507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15560: Upgrade argparse4j to 0.9.0 [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #14507: URL: https://github.com/apache/kafka/pull/14507#issuecomment-1923851472 We can't upgrade to 0.9.0 since it requires Java 9. We will take another look at this once Kafka removes support for Java 8. Closing this PR for now. -- This is an automated message fr

Re: [PR] MINOR: Upgrade maven Artifact version to 3.9.4 [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #14146: URL: https://github.com/apache/kafka/pull/14146#issuecomment-1923838154 @bmscomp Can you rebase this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] MINOR: Upgrade jqwik to version 1.8.0 [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #14365: URL: https://github.com/apache/kafka/pull/14365#issuecomment-1923814777 @bmscomp Can you rebase to resolve the conflict? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-14945: Add Serializer#serializeToByteBuffer() to reduce memory copying [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #12685: URL: https://github.com/apache/kafka/pull/12685#issuecomment-1923787527 @LinShunKang It looks like you need to rebase this PR to resolve conflicts. Ping @divijvaidya @showuon @dengziming, can you help get this merged? Thanks -- This is an automated mess

Re: [PR] MINOR: Fix plugin.path link in quickstart [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #12303: URL: https://github.com/apache/kafka/pull/12303#issuecomment-1923782176 Thanks for the PR! It looks like this has been fixed in the meantime by https://github.com/apache/kafka/commit/ae3f48b699f8e101dc9bf53aaa8e341c581f37af, so closing this PR. -- This is

Re: [PR] MINOR: Fix plugin.path link in quickstart [kafka]

2024-02-02 Thread via GitHub
mimaison closed pull request #12303: MINOR: Fix plugin.path link in quickstart URL: https://github.com/apache/kafka/pull/12303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] MINOR: Remove unnecessary log4j-appender dependency and tweak explicit log4j dependency [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #12148: URL: https://github.com/apache/kafka/pull/12148#issuecomment-1923774328 @ijuma can you rebase this PR? I think removing the unnecessary log4j-appender dependencies is still a good to have cleanup. -- This is an automated message from the Apache Git Servic

Re: [PR] KAFKA-8713 KIP-581: Add new conf serialize.accept.optional.null in connect-json [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #12126: URL: https://github.com/apache/kafka/pull/12126#issuecomment-1923768711 This has been implemented in https://github.com/apache/kafka/pull/13419. Closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-8713 KIP-581: Add new conf serialize.accept.optional.null in connect-json [kafka]

2024-02-02 Thread via GitHub
mimaison closed pull request #12126: KAFKA-8713 KIP-581: Add new conf serialize.accept.optional.null in connect-json URL: https://github.com/apache/kafka/pull/12126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-15697) Add local assignor and ensure it cannot be used with server side assignor

2024-02-02 Thread appchemist (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813664#comment-17813664 ] appchemist commented on KAFKA-15697: Could you clarify if `group.local.assignors` ca

Re: [PR] KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.17 [kafka]

2024-02-02 Thread via GitHub
mimaison closed pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.17 URL: https://github.com/apache/kafka/pull/12284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.17 [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #12284: URL: https://github.com/apache/kafka/pull/12284#issuecomment-1923750020 We upgrade to Scala 2.12.18 in https://github.com/apache/kafka/commit/dfaae317b82035323ba9c693b3ad7f02a6a58395. Closing this PR. -- This is an automated message from the Apache Git Se

Re: [PR] MINOR: Reuse hasDefault instead of comparing with NO_DEFAULT_VALUE directly [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #10977: URL: https://github.com/apache/kafka/pull/10977#issuecomment-1923741450 This is a nice cleanup. @wuYin if you rebase to resolve the conflict, we should accept and merge this PR. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MINOR: remove un used exception [kafka]

2024-02-02 Thread via GitHub
mimaison closed pull request #11684: MINOR: remove un used exception URL: https://github.com/apache/kafka/pull/11684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] MINOR: remove un used exception [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #11684: URL: https://github.com/apache/kafka/pull/11684#issuecomment-1923739919 Yes these exceptions are part of [Streams public API](https://kafka.apache.org/36/javadoc/org/apache/kafka/streams/errors/package-summary.html), so we can't just delete them. Closing thi

[jira] [Commented] (KAFKA-15697) Add local assignor and ensure it cannot be used with server side assignor

2024-02-02 Thread appchemist (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813658#comment-17813658 ] appchemist commented on KAFKA-15697: [~pnee] I would be happy to take care of this i

Re: [PR] Fix to include runtime dependencies in clients [kafka]

2024-02-02 Thread via GitHub
apoorvmittal10 commented on PR #15281: URL: https://github.com/apache/kafka/pull/15281#issuecomment-1923737044 Closing the PR as placed the proper fix here: https://github.com/apache/kafka/pull/15308 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Fix to include runtime dependencies in clients [kafka]

2024-02-02 Thread via GitHub
apoorvmittal10 closed pull request #15281: Fix to include runtime dependencies in clients URL: https://github.com/apache/kafka/pull/15281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Version downgrade for shadow jar plugin [kafka]

2024-02-02 Thread via GitHub
apoorvmittal10 opened a new pull request, #15308: URL: https://github.com/apache/kafka/pull/15308 Shadow jar plugin version `8.1.1` causes issue when shadowed artifacts are `signed` and `published`. The issue occurs because `archiveBaseName` and `archiveClassifier` are not honoured correctl

Re: [PR] KAFKA-10047: Unnecessary widening of (int to long) scope in FloatSerializer [kafka]

2024-02-02 Thread via GitHub
mimaison commented on PR #9351: URL: https://github.com/apache/kafka/pull/9351#issuecomment-1923732576 Thanks for the contribution! I couldn't find your account in [Jira](https://issues.apache.org/jira/browse/KAFKA), let me know if you have one and I'll assign https://issues.apache.org/

[jira] [Resolved] (KAFKA-10047) Unnecessary widening of (int to long) scope in FloatSerializer

2024-02-02 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10047. Fix Version/s: 3.8.0 Resolution: Fixed > Unnecessary widening of (int to long) scop

  1   2   >