dajac commented on PR #15447:
URL: https://github.com/apache/kafka/pull/15447#issuecomment-1972748553
I am not sure about this one. `org.apache.kafka.common.metrics.stats` is
part of public API so moving `TimeRatio` there would effectively make it part
of our public API. We would need a KIP
hni61223 opened a new pull request, #15450:
URL: https://github.com/apache/kafka/pull/15450
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
[
https://issues.apache.org/jira/browse/KAFKA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dominik updated KAFKA-16222:
Priority: Blocker (was: Major)
> Incorrect default user-principal quota after migration
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dominik updated KAFKA-16222:
Affects Version/s: 3.7.0
> Incorrect default user-principal quota after migration
> --
altrack commented on PR #15338:
URL: https://github.com/apache/kafka/pull/15338#issuecomment-1972858044
@mberndt123 one of the possible solutions may be to attach the Scala 3
related step as a piggyback to Scala 2.13, it will be skipped when
`scalaVersion=2.12`. This until we have a full Sc
dajac commented on code in PR #15442:
URL: https://github.com/apache/kafka/pull/15442#discussion_r1508759431
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3500,6 +3501,42 @@ public void maybeDeleteGroup(String groupId,
L
dajac commented on code in PR #15442:
URL: https://github.com/apache/kafka/pull/15442#discussion_r1508759431
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3500,6 +3501,42 @@ public void maybeDeleteGroup(String groupId,
L
dajac commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1508764392
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1830,6 +1832,63 @@ public void onLoaded() {
});
}
lucasbru merged PR #15445:
URL: https://github.com/apache/kafka/pull/15445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Mickael Maison created KAFKA-16318:
--
Summary: Add javadoc to KafkaMetric
Key: KAFKA-16318
URL: https://issues.apache.org/jira/browse/KAFKA-16318
Project: Kafka
Issue Type: Bug
Comp
[
https://issues.apache.org/jira/browse/KAFKA-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822524#comment-17822524
]
Luke Chen commented on KAFKA-16071:
---
Closing it now since it could have been fixed by
[
https://issues.apache.org/jira/browse/KAFKA-16071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16071.
---
Resolution: Fixed
> NPE in testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress
> -
[
https://issues.apache.org/jira/browse/KAFKA-16031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822525#comment-17822525
]
PoAn Yang commented on KAFKA-16031:
---
Hi [~showuon], may I take this? Thank you.
> Ena
[
https://issues.apache.org/jira/browse/KAFKA-16031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16031:
--
Assignee: PoAn Yang
> Enabling testApplyDeltaShouldHandleReplicaAssignedToOnlineDirec
[
https://issues.apache.org/jira/browse/KAFKA-16232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822532#comment-17822532
]
Kuan-Po Tseng commented on KAFKA-16232:
---
gentle ping [~showuon] ~ I'm willing to t
[
https://issues.apache.org/jira/browse/KAFKA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dominik updated KAFKA-16222:
Summary: KRaft Migration: Incorrect default user-principal quota after
migration (was: Incorrect default
[
https://issues.apache.org/jira/browse/KAFKA-16031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822541#comment-17822541
]
Luke Chen commented on KAFKA-16031:
---
Go ahead. Thanks.
> Enabling testApplyDeltaShoul
[
https://issues.apache.org/jira/browse/KAFKA-16031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822553#comment-17822553
]
Luke Chen commented on KAFKA-16031:
---
Sorry [~yangpoan], had another look, this feature
gaurav-narula commented on PR #15451:
URL: https://github.com/apache/kafka/pull/15451#issuecomment-1973222033
CC: @soarez @pprovenzano @showuon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
gaurav-narula opened a new pull request, #15451:
URL: https://github.com/apache/kafka/pull/15451
Updates kraft_upgrade_test to create a new topic after upgrading metadata
version and tries to produce/consume to/from it.
This may act as a regression test for scenarios like KAFKA-16162
[
https://issues.apache.org/jira/browse/KAFKA-16031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822577#comment-17822577
]
PoAn Yang commented on KAFKA-16031:
---
It's ok. I just tried to enable it and run the te
soarez commented on code in PR #15451:
URL: https://github.com/apache/kafka/pull/15451#discussion_r1509037381
##
tests/kafkatest/tests/core/kraft_upgrade_test.py:
##
@@ -108,6 +108,27 @@ def run_upgrade(self, from_kafka_version):
assert len(cluster_id) == 22
as
stanislavkozlovski opened a new pull request, #15452:
URL: https://github.com/apache/kafka/pull/15452
Since Kafka 3.7.0 was just released, this patch extends its upgrade and
compatibility tests to test that version as well
--
This is an automated message from the Apache Git Service.
To re
soarez commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1509052378
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2859,10 +2867,10 @@ class ReplicaManager(val config: KafkaConfig,
"local leaders.")
replicaF
gaurav-narula commented on code in PR #15451:
URL: https://github.com/apache/kafka/pull/15451#discussion_r1509056087
##
tests/kafkatest/tests/core/kraft_upgrade_test.py:
##
@@ -108,6 +108,27 @@ def run_upgrade(self, from_kafka_version):
assert len(cluster_id) == 22
stanislavkozlovski opened a new pull request, #15453:
URL: https://github.com/apache/kafka/pull/15453
This patch adds the 3.7 version to the Kafka Streams system tests as per the
release wiki and past examples
--
This is an automated message from the Apache Git Service.
To respond to the
stanislavkozlovski commented on PR #15453:
URL: https://github.com/apache/kafka/pull/15453#issuecomment-1973267141
- system test run is at
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6082/
- i simply copy-pasted the files from the 36 folder and re-named the 3 log
oc
stanislavkozlovski commented on PR #15452:
URL: https://github.com/apache/kafka/pull/15452#issuecomment-1973269982
tests are run at:
- https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6084/
- https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6085/
--
gaurav-narula commented on PR #15453:
URL: https://github.com/apache/kafka/pull/15453#issuecomment-1973286061
Seems like a duplicate of https://github.com/apache/kafka/pull/15443 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
nikramakrishnan commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1509082067
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -522,6 +522,18 @@ public TimeIndex timeIndex() {
// Visi
nikramakrishnan commented on code in PR #15241:
URL: https://github.com/apache/kafka/pull/15241#discussion_r1509082067
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -522,6 +522,18 @@ public TimeIndex timeIndex() {
// Visi
[
https://issues.apache.org/jira/browse/KAFKA-15878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822617#comment-17822617
]
Anuj Sharma commented on KAFKA-15878:
-
[~kirktrue] - thanks so much for assigning th
CharlyRien commented on PR #14157:
URL: https://github.com/apache/kafka/pull/14157#issuecomment-1973401741
I know that I probably sound pushy, but I’m curious if there’s anything we
can do to continue the work you initiated, @mjsax.
I understand you don't have a lot of time and other prio
lucasbru merged PR #15440:
URL: https://github.com/apache/kafka/pull/15440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AlexeyASF created KAFKA-16319:
-
Summary: Wrong broker destinations for DeleteRecords requests when
more than one topic is involved and the topics/partitions are led by different
brokers
Key: KAFKA-16319
URL: https://
splett2 opened a new pull request, #15454:
URL: https://github.com/apache/kafka/pull/15454
A few minor optimizations:
1. Cache the interbroker listener name instead of computing it each time.
The value of the interbroker listener name cannot change without a process
restart.
2. we're
philipnee commented on PR #15437:
URL: https://github.com/apache/kafka/pull/15437#issuecomment-1973537076
Hey thanks for the PR - I notice a subtle thing here: Seems like we never
null check interceptors in the async consumer. Can `interceptors` ever be
null?
```
try {
dajac commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1509278562
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRe
philipnee commented on code in PR #15437:
URL: https://github.com/apache/kafka/pull/15437#discussion_r1509285840
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -567,6 +568,28 @@ public void testCommitAsyncLeaderEpochUpdate
jsancio commented on code in PR #15450:
URL: https://github.com/apache/kafka/pull/15450#discussion_r1509262172
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -179,7 +180,7 @@ final class KafkaMetadataLog private (
(false, mutable.TreeMap.empty[OffsetAnd
Emanuele Sabellico created KAFKA-16320:
--
Summary: CreateTopics, DeleteTopics and CreatePartitions
differences between Zookeeper and KRaft
Key: KAFKA-16320
URL: https://issues.apache.org/jira/browse/KAFKA-1632
mjsax commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1509341591
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRe
philomathanuj commented on PR #14818:
URL: https://github.com/apache/kafka/pull/14818#issuecomment-1973769981
Thanks very much @kirktrue, @omkreddy for reviewing the PR. Could you help
with merging the PR please?
--
This is an automated message from the Apache Git Service.
To respond to t
omkreddy merged PR #14818:
URL: https://github.com/apache/kafka/pull/14818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-15878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar reassigned KAFKA-15878:
-
Assignee: Anuj Sharma
> KIP-768: Extend support for opaque (i.e. non-JWT) tokens in SASL/OAUTHB
jeffkbkim commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1509452557
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1830,6 +1832,63 @@ public void onLoaded() {
});
jeffkbkim commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1509457561
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1830,6 +1832,63 @@ public void onLoaded() {
});
[
https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-15490:
--
Affects Version/s: 3.4.0
> Invalid path provided to the log failure channel upon I/O e
[
https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-15490:
--
Affects Version/s: 3.4.1
> Invalid path provided to the log failure channel upon I/O e
phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1509566281
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -545,6 +545,15 @@ public ConsumerGroupHeartbeatRequestData
phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1509566835
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -524,10 +524,10 @@ public void testHeartbeatState() {
mjsax commented on PR #15443:
URL: https://github.com/apache/kafka/pull/15443#issuecomment-1973983318
Different set of system test (or same but different parameters) fails on
second run. Seems it's flaky test that we will need to stabilize.
--
This is an automated message from the Apache
kirktrue opened a new pull request, #15455:
URL: https://github.com/apache/kafka/pull/15455
This is part of the larger task of enforcing the timeouts for application
events, per KAFKA-15974.
This takes a first step by adding a `Timer` to all of the
`CompletableApplicationEvent` subcl
kirktrue commented on PR #15455:
URL: https://github.com/apache/kafka/pull/15455#issuecomment-1974030036
@cadonna—can you review this PR as part of the larger timeout handling
refactoring? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
mjsax commented on PR #14426:
URL: https://github.com/apache/kafka/pull/14426#issuecomment-1974072824
@VictorvandenHoven -- it seems
`KStreamKStreamIntegrationTest.shouldOuterJoin` fails consistently. Can you
take a look?
--
This is an automated message from the Apache Git Service.
To re
mjsax commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1509672158
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1140,6 +1145,7 @@ public class StreamsConfig extends AbstractConfig {
static {
mjsax commented on code in PR #14157:
URL: https://github.com/apache/kafka/pull/14157#discussion_r1509687465
##
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueRawStoreWrapper.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (A
mjsax commented on code in PR #14157:
URL: https://github.com/apache/kafka/pull/14157#discussion_r1509692788
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/ResponseJoinProcessorSupplier.java:
##
@@ -44,72 +45,98 @@
* @param Type of foreign
mjsax commented on PR #14157:
URL: https://github.com/apache/kafka/pull/14157#issuecomment-1974097523
Thanks for the ping -- yes, it's a struggle to keep up with all the
different parallel things... It's good that you keep pushing on this; it helps
to keep it's priority high...
If yo
mjsax commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1509703745
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -203,13 +202,27 @@ public void registerStore(final StateStore sto
kirktrue commented on PR #15426:
URL: https://github.com/apache/kafka/pull/15426#issuecomment-1974135452
> @kirktrue are you fine with merging this PR and coming back to this after
3.8?
Yes. I think this is an area that we need a more holistic design review,
unfortunately.
--
This
Colin McCabe created KAFKA-16321:
Summary: Default directory ids to MIGRATING, not UNASSIGNED
Key: KAFKA-16321
URL: https://issues.apache.org/jira/browse/KAFKA-16321
Project: Kafka
Issue Type
[
https://issues.apache.org/jira/browse/KAFKA-16232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822736#comment-17822736
]
Luke Chen commented on KAFKA-16232:
---
Yes, please. Thanks for picking it up [~brandboat
[
https://issues.apache.org/jira/browse/KAFKA-16232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822739#comment-17822739
]
Kuan-Po Tseng commented on KAFKA-16232:
---
Thank you [~showuon] , but I can't assign
pedoc opened a new pull request, #15456:
URL: https://github.com/apache/kafka/pull/15456
Currently, when using ``kafka-connect`` configuration files (such as
``connect-standalone.properties``) in non-English regions, if they contain
non-ASCII characters, the program will not recognize them.
[
https://issues.apache.org/jira/browse/KAFKA-16232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16232:
-
Assignee: Kuan-Po Tseng
> kafka hangs forever in the starting process if the authorizer future
66 matches
Mail list logo
