vamossagar12 commented on PR #15677:
URL: https://github.com/apache/kafka/pull/15677#issuecomment-2041849012
Thanks for the review @showuon and thanks for the input. I agree to your
proposal, we can first merge this and then I will look at the adding more
resilience on the test for this
github-actions[bot] commented on PR #15038:
URL: https://github.com/apache/kafka/pull/15038#issuecomment-2041800868
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
gaoran10 commented on PR #15561:
URL: https://github.com/apache/kafka/pull/15561#issuecomment-2041793310
Sorry for the late response, great work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vamossagar12 opened a new pull request, #15677:
URL: https://github.com/apache/kafka/pull/15677
Noticed in the build:
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15621/32/tests/
There are a lot of NPEs of the form:
```
[2024-04-05
KevinZTW opened a new pull request, #15676:
URL: https://github.com/apache/kafka/pull/15676
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary
[
https://issues.apache.org/jira/browse/KAFKA-16049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kelvin Lui reassigned KAFKA-16049:
--
Assignee: (was: Kelvin Lui)
> Can you please share tutorial how to run Latest Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kelvin Lui reassigned KAFKA-16049:
--
Assignee: Kelvin Lui
> Can you please share tutorial how to run Latest Kafka (3.6.0) with
chia7712 merged PR #15674:
URL: https://github.com/apache/kafka/pull/15674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16482:
---
Summary: Eliminate the IDE warnings of accepting ClusterConfig in
BeforeEach (was: Avoid
[
https://issues.apache.org/jira/browse/KAFKA-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834745#comment-17834745
]
Chia-Ping Tsai commented on KAFKA-16482:
BTW, we can eliminate the IDE error by updating configs
chia7712 commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2041650425
> There are quite a few test failures on
junrao commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2041649750
@chia7712 : There are quite a few test failures on
chia7712 commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1555109656
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -112,7 +113,7 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin
florin-akermann commented on PR #15189:
URL: https://github.com/apache/kafka/pull/15189#issuecomment-2041579829
Hi @mjsax
It's now rebased.
Plus, I addressed your reply below.
> If find this test a little bit hard to follow...
>
> We start to open a window `[5;15]` with
dongnuo123 commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1555022535
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java:
##
@@ -1300,6 +1341,68 @@ public Map groupAssignment() {
dongnuo123 commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1555022109
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java:
##
@@ -1300,6 +1341,68 @@ public Map groupAssignment() {
dongnuo123 commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1555021412
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java:
##
@@ -1244,6 +1267,24 @@ public boolean completeSyncFuture(
dongnuo123 commented on code in PR #15587:
URL: https://github.com/apache/kafka/pull/15587#discussion_r1555019741
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2415,6 +2415,20 @@ private CoordinatorResult
soarez commented on PR #15557:
URL: https://github.com/apache/kafka/pull/15557#issuecomment-2041535672
I think I've addressed the issues. The failing tests on the most recent
build are unrelated. PTAL @showuon
--
This is an automated message from the Apache Git Service.
To respond to
brandboat commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554997766
##
server-common/src/test/java/org/apache/kafka/server/util/timer/TimerTest.java:
##
@@ -77,7 +77,7 @@ public void setup() {
@AfterEach
public void
chia7712 commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554997443
##
server-common/src/test/java/org/apache/kafka/server/util/timer/TimerTest.java:
##
@@ -77,7 +77,7 @@ public void setup() {
@AfterEach
public void
[
https://issues.apache.org/jira/browse/KAFKA-16484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16484:
--
Assignee: Kuan Po Tseng (was: Chia-Ping Tsai)
> Support to define per
[
https://issues.apache.org/jira/browse/KAFKA-16484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834692#comment-17834692
]
Chia-Ping Tsai commented on KAFKA-16484:
[~brandboat] I'm not working on this, so please feel
[
https://issues.apache.org/jira/browse/KAFKA-16484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834690#comment-17834690
]
Kuan Po Tseng edited comment on KAFKA-16484 at 4/7/24 3:14 PM:
---
Hello
[
https://issues.apache.org/jira/browse/KAFKA-16484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834690#comment-17834690
]
Kuan Po Tseng commented on KAFKA-16484:
---
Hello [~chia7712], I'm willing to take over this issue,
Chia-Ping Tsai created KAFKA-16484:
--
Summary: Support to define per broker property by
ClusterConfigProperty
Key: KAFKA-16484
URL: https://issues.apache.org/jira/browse/KAFKA-16484
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16484:
---
Summary: Support to define per broker/controller property by
ClusterConfigProperty (was:
FrankYang0529 commented on PR #15675:
URL: https://github.com/apache/kafka/pull/15675#issuecomment-2041482907
> @FrankYang0529 Could we use `ClusterTestExtensions` to enable `kraft`? It
seems to me that using the new test framework is the better way. Otherwise, we
may rewrite it again in
chia7712 commented on PR #15675:
URL: https://github.com/apache/kafka/pull/15675#issuecomment-2041482458
@FrankYang0529 Could we use `ClusterTestExtensions` to enable `kraft`? It
seems to me that using the new test framework is the better way. Otherwise, we
may rewrite it again in the
FrankYang0529 opened a new pull request, #15675:
URL: https://github.com/apache/kafka/pull/15675
Enable Kraft test for `ReassignPartitionsIntegrationTest`.
All test cases can pass on my laptop.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
chia7712 commented on PR #12174:
URL: https://github.com/apache/kafka/pull/12174#issuecomment-2041478299
@soarez Could you please fix the conflicts? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 merged PR #15667:
URL: https://github.com/apache/kafka/pull/15667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 merged PR #15666:
URL: https://github.com/apache/kafka/pull/15666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #15672:
URL: https://github.com/apache/kafka/pull/15672#discussion_r1554976395
##
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##
@@ -281,13 +278,12 @@ public static void main(String[] args) throws Exception {
}
}
chia7712 commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554964050
##
server-common/src/test/java/org/apache/kafka/server/util/timer/TimerTest.java:
##
@@ -76,6 +77,7 @@ public void setup() {
@AfterEach
public void
[
https://issues.apache.org/jira/browse/KAFKA-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834675#comment-17834675
]
Chia-Ping Tsai commented on KAFKA-16483:
sure. I have assigned this to you [~yangpoan]
> Apply
[
https://issues.apache.org/jira/browse/KAFKA-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16483:
--
Assignee: PoAn Yang (was: Chia-Ping Tsai)
> Apply `ClusterTestExtensions` to
>
[
https://issues.apache.org/jira/browse/KAFKA-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834674#comment-17834674
]
PoAn Yang commented on KAFKA-16483:
---
Hi [~chia7712], I'm interested in this. May I assign to myself?
Chia-Ping Tsai created KAFKA-16483:
--
Summary: Apply `ClusterTestExtensions` to
DeleteOffsetsConsumerGroupCommandIntegrationTest
Key: KAFKA-16483
URL: https://issues.apache.org/jira/browse/KAFKA-16483
brandboat commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1554955481
##
server-common/src/test/java/org/apache/kafka/server/util/timer/SystemTimerReaperTest.java:
##
@@ -59,4 +59,11 @@ public void testReaper() throws Exception {
[
https://issues.apache.org/jira/browse/KAFKA-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16482:
---
Description:
IDE does not like the code style, and we can leverage `ClusterConfigProperty`
[
https://issues.apache.org/jira/browse/KAFKA-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834663#comment-17834663
]
Chia-Ping Tsai commented on KAFKA-16482:
sure. go ahead
> Avoid changing ClusterConfig in
[
https://issues.apache.org/jira/browse/KAFKA-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16482:
--
Assignee: Cheng-Kai, Zhang (was: Chia-Ping Tsai)
> Avoid changing ClusterConfig in
[
https://issues.apache.org/jira/browse/KAFKA-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834662#comment-17834662
]
Cheng-Kai, Zhang commented on KAFKA-16482:
--
I am interested to this issue, could you assign it
Chia-Ping Tsai created KAFKA-16482:
--
Summary: Avoid changing ClusterConfig in `BeforeEach` phase
Key: KAFKA-16482
URL: https://issues.apache.org/jira/browse/KAFKA-16482
Project: Kafka
Issue
erikvanoosten opened a new pull request, #15674:
URL: https://github.com/apache/kafka/pull/15674
- Use `Empty` instead of 'none' when referring to `Optional` values.
- `Headers.lastHeader` returns `null` when no header is found.
- Fix minor spelling mistakes.
### Committer
erikvanoosten commented on PR #15674:
URL: https://github.com/apache/kafka/pull/15674#issuecomment-2041343908
I am a big fan of scala, but 'some' and 'none' are not the terminology used
in the java world.
This PR does not change any code, only javadoc.
--
This is an automated message
47 matches
Mail list logo
