C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1556834149
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/MultiFieldPaths.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software Founda
C0urante commented on PR #15379:
URL: https://github.com/apache/kafka/pull/15379#issuecomment-2044091861
I'm also wondering if it's necessary to have the `SingleFieldPath` class at
all. Would it be significantly more expensive to just use the `MultiFieldPaths`
class for everything for now?
C0urante commented on PR #15379:
URL: https://github.com/apache/kafka/pull/15379#issuecomment-2044089149
@jeqo This is difficult to review without seeing how this code is actually
used. Maybe we could move incrementally and introduce a commit that only
touches on 1-3 SMTs, and only introduc
showuon commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1556799227
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,47 @@ public void testSkippingAssignmentFail
showuon commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1556799227
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,47 @@ public void testSkippingAssignmentFail
showuon commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1556799227
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,47 @@ public void testSkippingAssignmentFail
[
https://issues.apache.org/jira/browse/KAFKA-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16455.
---
Fix Version/s: 3.8.0
Resolution: Fixed
> Check partition exists before send reassignments to
showuon merged PR #15659:
URL: https://github.com/apache/kafka/pull/15659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15659:
URL: https://github.com/apache/kafka/pull/15659#issuecomment-2043887866
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1556614475
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -109,7 +109,7 @@ class AddPartitionsToTxnManager(
.setTransactionalId(transactionalI
junrao commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1556593959
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Update high watermark wit
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1556609642
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -979,6 +1013,13 @@ void handleCoordinatorReady() {
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1556603619
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2715,6 +2721,10 @@ class KafkaApis(val requestChannel: RequestChannel,
} else if (!authHelper.authorize
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1556603619
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2715,6 +2721,10 @@ class KafkaApis(val requestChannel: RequestChannel,
} else if (!authHelper.authorize
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1556603619
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2715,6 +2721,10 @@ class KafkaApis(val requestChannel: RequestChannel,
} else if (!authHelper.authorize
pasharik commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2043855618
> any updates here? gradle 8.7 has been released. we can update gradle to
8.7 if the issue is nonexistent
Update to 8.7 is ok with me. For now, I'm compiling my test with `scalac`
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1556584820
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -979,6 +1013,13 @@ void handleCoordinatorReady() {
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1556576980
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -402,6 +412,30 @@ public synchronized void maybeAddPartition(TopicPa
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1556556192
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -202,7 +202,9 @@ public enum MetadataVersion {
IBP_3_7_IV4(19, "3.7", "IV
jolshan opened a new pull request, #15685:
URL: https://github.com/apache/kafka/pull/15685
As part of KIP-1022, I have created an interface for all the new features to
be used when parsing the command line arguments, doing validations, getting
default versions, etc.
I've also added
junrao commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2043792883
@chia7712 : Thanks for the updated PR. The code looks good to me. There were
50 failed tests. Is any of them related to the PR? If not, have they all been
tracked?
--
This is an automat
junrao commented on PR #15680:
URL: https://github.com/apache/kafka/pull/15680#issuecomment-2043781090
@apoorvmittal10 : Thanks for the PR. The code looks good to me. Have all the
test failures been tracked?
--
This is an automated message from the Apache Git Service.
To respond to the me
OmniaGM commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1556505842
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##
@@ -16,11 +16,43 @@
*/
package org.apache.kafka.coord
chia7712 commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1556496340
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##
@@ -16,11 +16,43 @@
*/
package org.apache.kafka.coor
apoorvmittal10 commented on PR #15680:
URL: https://github.com/apache/kafka/pull/15680#issuecomment-2043749614
> @apoorvmittal10 Haven’t we already released those metrics in 3.7?
@dajac There were some work items left for completion for 3.8. These broker
metrics were not part of 3.7 r
chia7712 commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1556491908
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##
@@ -16,11 +16,43 @@
*/
package org.apache.kafka.coor
OmniaGM commented on code in PR #15684:
URL: https://github.com/apache/kafka/pull/15684#discussion_r1556491449
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java:
##
@@ -88,10 +125,10 @@ public OffsetConfig(int maxMetadataSize,
}
OmniaGM commented on code in PR #15684:
URL: https://github.com/apache/kafka/pull/15684#discussion_r1556490595
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java:
##
@@ -20,16 +20,53 @@
import org.apache.kafka.common.record.CompressionType;
OmniaGM commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1556482611
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##
@@ -16,11 +16,43 @@
*/
package org.apache.kafka.coord
OmniaGM commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1556478763
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##
@@ -16,11 +16,43 @@
*/
package org.apache.kafka.coord
OmniaGM commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1556481647
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##
@@ -16,11 +16,43 @@
*/
package org.apache.kafka.coord
OmniaGM commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1556478763
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##
@@ -16,11 +16,43 @@
*/
package org.apache.kafka.coord
junrao commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2043718730
@clolov : Thanks for the PR. When we last bumped up metadata.version
(https://github.com/apache/kafka/pull/14984), we changed a bunch of tests such
as MetadataVersionTest, ZkMigrationInteg
OmniaGM commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1556466418
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##
@@ -16,11 +16,43 @@
*/
package org.apache.kafka.coord
chia7712 commented on code in PR #15684:
URL: https://github.com/apache/kafka/pull/15684#discussion_r1556449383
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -17,13 +17,84 @@
package org.apache.kafka.coordinator.group;
chia7712 commented on PR #15553:
URL: https://github.com/apache/kafka/pull/15553#issuecomment-2043666756
any updates here? gradle 8.7 has been released. we can update gradle to 8.7
if the issue is nonexistent
--
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/KAFKA-16477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16477.
Fix Version/s: 3.8.0
Resolution: Fixed
> Detect thread leaked client-metrics-reaper
chia7712 merged PR #15668:
URL: https://github.com/apache/kafka/pull/15668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1556404908
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##
@@ -16,11 +16,43 @@
*/
package org.apache.kafka.coor
OmniaGM opened a new pull request, #15684:
URL: https://github.com/apache/kafka/pull/15684
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgra
chia7712 commented on code in PR #15678:
URL: https://github.com/apache/kafka/pull/15678#discussion_r1556390789
##
server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java:
##
@@ -172,10 +172,11 @@ public void testAssignmentAggregation() throws
InterruptedExcept
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1556382498
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,19 +48,40 @@
import static org.junit.jup
chia7712 commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1556371500
##
server/src/main/java/org/apache/kafka/server/config/KafkaSecurityConfigs.java:
##
@@ -0,0 +1,239 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
chia7712 commented on PR #15645:
URL: https://github.com/apache/kafka/pull/15645#issuecomment-2043536012
@nizhikov thanks for updated PR. I have a major question: Does
`ConfigCommandIntegrationTest` have only zk-related tests? If so, we don't need
to rewrite it by java as it will be removed
OmniaGM commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1556357170
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
junrao commented on code in PR #15631:
URL: https://github.com/apache/kafka/pull/15631#discussion_r1556331481
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -952,8 +952,9 @@ class UnifiedLogTest {
assertEquals(0, lastSeq)
}
- @Test
- def testRetent
kirktrue opened a new pull request, #15683:
URL: https://github.com/apache/kafka/pull/15683
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
chia7712 commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1556226896
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
dajac commented on PR #15680:
URL: https://github.com/apache/kafka/pull/15680#issuecomment-2043344035
@apoorvmittal10 Haven’t we already released those metrics in 3.7?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
[
https://issues.apache.org/jira/browse/KAFKA-16482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835005#comment-17835005
]
Chia-Ping Tsai commented on KAFKA-16482:
I'm a big confused that should we encou
chia7712 commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2043274125
@junrao thanks for reviews. both comments get addressed in
https://github.com/apache/kafka/pull/15621/commits/581242c1fa6c005bf91a7ced96932774c2c02cd9
--
This is an automated message f
junrao commented on code in PR #14242:
URL: https://github.com/apache/kafka/pull/14242#discussion_r1556161125
##
server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java:
##
@@ -72,18 +72,20 @@ public CheckpointFile(File file,
tempPath = Paths.get(
Phuc-Hong-Tran commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1556146632
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1750,8 +1750,8 @@ private void subscribeInternal(Pattern pat
lianetm commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1556142547
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1750,8 +1750,8 @@ private void subscribeInternal(Pattern pattern,
kirktrue commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1556133511
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1750,8 +1750,8 @@ private void subscribeInternal(Pattern pattern,
lianetm commented on PR #15585:
URL: https://github.com/apache/kafka/pull/15585#issuecomment-2043179367
@cadonna could you take a look at this one when you have a chance? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
junrao commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1556068446
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -56,11 +60,33 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarness
lianetm commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1556104853
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pattern,
lianetm commented on PR #15669:
URL: https://github.com/apache/kafka/pull/15669#issuecomment-2043121631
Hey @cadonna, could you take a look if you have some time too? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-16474:
--
Assignee: Lianet Magrans (was: Philip Nee)
> AsyncKafkaConsumer might send out heart
brandboat commented on code in PR #15659:
URL: https://github.com/apache/kafka/pull/15659#discussion_r1556052135
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -300,6 +301,15 @@ public void testGetReplicaAssignments() throws Excepti
brandboat commented on code in PR #15668:
URL: https://github.com/apache/kafka/pull/15668#discussion_r1556044180
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -112,7 +113,7 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin
receiverPlu
[
https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-16478.
Resolution: Fixed
> Links for Kafka 3.5.2 release are broken
> ---
lianetm commented on PR #15585:
URL: https://github.com/apache/kafka/pull/15585#issuecomment-2042958530
Hey @Phuc-Hong-Tran, thanks for the update, left some more comments. Almost
there! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lianetm commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1555969469
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1751,16 +1753,7 @@ private void subscribeInternal(Pattern pattern,
apoorvmittal10 commented on PR #15681:
URL: https://github.com/apache/kafka/pull/15681#issuecomment-2042866833
> Tiny nit. It's KIP-1019 I think, not KIP-109.
Corrected the description. Thanks @AndrewJSchofield.
--
This is an automated message from the Apache Git Service.
To respond
AndrewJSchofield commented on PR #15681:
URL: https://github.com/apache/kafka/pull/15681#issuecomment-2042864722
Tiny nit. It's KIP-1019 I think, not KIP-109.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
lianetm commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1555915666
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1667,6 +1669,7 @@ private void updateLastSeenEpochIfNewer(TopicPart
apoorvmittal10 commented on PR #15682:
URL: https://github.com/apache/kafka/pull/15682#issuecomment-2042864619
The build is dependent on merge of PR:
https://github.com/apache/kafka/pull/15681
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
apoorvmittal10 opened a new pull request, #15682:
URL: https://github.com/apache/kafka/pull/15682
The PR implements the changes defined in KIP-1019. Does the cleanup for
accessing KafkaMetric field by reflection and uses method exposed by KIP-1019
for metric measurability.
### Commit
apoorvmittal10 opened a new pull request, #15681:
URL: https://github.com/apache/kafka/pull/15681
The PR implements the changes defined in
[KIP-109](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1019%3A+Expose+method+to+determine+Metric+Measurability)
which exposes method to check i
lianetm commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1555909363
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerSubscriptionTest.scala:
##
@@ -39,9 +39,8 @@ class PlaintextConsumerSubscriptionTest extends
AbstractCons
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1555905789
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +520,124 @@ public void run() {
}
}
}
+
+/
apoorvmittal10 opened a new pull request, #15680:
URL: https://github.com/apache/kafka/pull/15680
The PR updates the broker metrics name to kebab/hyphen case as pointed out
by @junrao in below comment:
https://github.com/apache/kafka/pull/15251#discussion_r1498439741
I have also remo
FrankYang0529 opened a new pull request, #15679:
URL: https://github.com/apache/kafka/pull/15679
By using ClusterTestExtensions,
`DeleteOffsetsConsumerGroupCommandIntegrationTest` get away from
`KafkaServerTestHarness` dependency.
### Committer Checklist (excluded from commit message
OmniaGM commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1555878104
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
OmniaGM commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1555878104
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
OmniaGM commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1555878104
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
OmniaGM commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1555869666
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
OmniaGM commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1555869666
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
OmniaGM commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1555869666
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Apoorv Mittal created KAFKA-16486:
-
Summary: Integrate metric measurability changes in metrics
collector
Key: KAFKA-16486
URL: https://issues.apache.org/jira/browse/KAFKA-16486
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal updated KAFKA-16485:
--
Parent: KAFKA-15601
Issue Type: Sub-task (was: Improvement)
> Fix broker metrics to f
Apoorv Mittal created KAFKA-16485:
-
Summary: Fix broker metrics to follow kebab/hyphen case
Key: KAFKA-16485
URL: https://issues.apache.org/jira/browse/KAFKA-16485
Project: Kafka
Issue Type:
chiacyu opened a new pull request, #15678:
URL: https://github.com/apache/kafka/pull/15678
We should replace the while loop in some test cases with waitForCondition to
prevent infinite looping conditions.
--
This is an automated message from the Apache Git Service.
To respond
showuon merged PR #15677:
URL: https://github.com/apache/kafka/pull/15677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15677:
URL: https://github.com/apache/kafka/pull/15677#issuecomment-2042592569
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
showuon commented on PR #15305:
URL: https://github.com/apache/kafka/pull/15305#issuecomment-2042586830
Will check it this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
chia7712 commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2042555906
> Look like the build still contains failed test :(
yep, I have filed another #15654 to dig in that :_
--
This is an automated message from the Apache Git Service.
To respond to
Owen-CH-Leung commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2042547986
> rebase to trigger QA again
Look like the build still contains failed test :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please
cadonna commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1555453187
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -293,17 +288,12 @@ public void cleanup() throws IOException {
OmniaGM commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1555661766
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1062,21 +1027,21 @@ object KafkaConfig {
.define(CompressionTypeProp, STRING, LogConfig.DEFAULT_COM
lucasbru merged PR #15525:
URL: https://github.com/apache/kafka/pull/15525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
clolov commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2042214344
Yup, I need to change the kafka-get-offsets tool to easily access said
functionality, but I am in the process of raising that PR
--
This is an automated message from the Apache Git Servi
nizhikov commented on PR #15645:
URL: https://github.com/apache/kafka/pull/15645#issuecomment-2042116296
Hello @chia7712
> we can complete it in another PR before this PR.
`junit-platform.properties` added for core and tools modules.
Can you, please, review this test refacto
[
https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834821#comment-17834821
]
Philipp Trulson commented on KAFKA-16478:
-
Thanks for the PR! Unfortunately it w
showuon commented on code in PR #15659:
URL: https://github.com/apache/kafka/pull/15659#discussion_r1555327569
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -300,6 +301,15 @@ public void testGetReplicaAssignments() throws Exception
showuon commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1555305760
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def removeP
98 matches
Mail list logo