mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567694543
##
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##
@@ -192,6 +192,66 @@ Found problem:
} finally Utils.delete(tempDir)
}
+ private def
mwesterby commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2059543825
> Also, is my previous comment
(https://github.com/apache/kafka/pull/15733#discussion_r1567431572) valid? the
following test case is based on my comment, and it seems to me that should
gaurav-narula commented on code in PR #15730:
URL: https://github.com/apache/kafka/pull/15730#discussion_r1567676845
##
core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
chia7712 commented on PR #15735:
URL: https://github.com/apache/kafka/pull/15735#issuecomment-2059524210
@mannoopj thanks for this patch. There is already a patch (#15720) to fix
the same issue. It would be great if you can be a reviewer there.
--
This is an automated message from the
chia7712 commented on code in PR #15730:
URL: https://github.com/apache/kafka/pull/15730#discussion_r1567674070
##
core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
mannoopj opened a new pull request, #15735:
URL: https://github.com/apache/kafka/pull/15735
add unit tests for add TopicImageNode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567642200
##
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##
@@ -192,6 +192,66 @@ Found problem:
} finally Utils.delete(tempDir)
}
+ private def
gaurav-narula commented on code in PR #15730:
URL: https://github.com/apache/kafka/pull/15730#discussion_r1567645489
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -90,9 +100,17 @@ public Builder setNumBrokerNodes(int numBrokerNodes) {
if
mwesterby commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2059463882
> It seems the three new tests have a lot in common:
>
> the setup of MetaProperties, ByteArrayOutputStream and BootstrapMetadata
the invocation of command formatCommand
Is
mimaison merged PR #15643:
URL: https://github.com/apache/kafka/pull/15643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on PR #13283:
URL: https://github.com/apache/kafka/pull/13283#issuecomment-2059442356
Hey @vamossagar12 sorry the second half of this KIP has dragged on for so
long. Are you still interested in getting this done? I think we can target it
for 3.8 if you have time on
mimaison merged PR #15725:
URL: https://github.com/apache/kafka/pull/15725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837762#comment-17837762
]
Walter Hernandez edited comment on KAFKA-16263 at 4/16/24 3:25 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johnny Hsu reassigned KAFKA-13105:
--
Assignee: Johnny Hsu
> Expose a method in KafkaConfig to write the configs to a logger
>
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1567555940
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete,
[
https://issues.apache.org/jira/browse/KAFKA-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837762#comment-17837762
]
Walter Hernandez commented on KAFKA-16263:
--
Are you referring to:
*
[ https://issues.apache.org/jira/browse/KAFKA-16263 ]
Walter Hernandez deleted comment on KAFKA-16263:
--
was (Author: JIRAUSER305029):
Are you referring to:
{{void}}
[
https://issues.apache.org/jira/browse/KAFKA-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837760#comment-17837760
]
Walter Hernandez commented on KAFKA-16263:
--
Are you referring to:
{{void}}
[
https://issues.apache.org/jira/browse/KAFKA-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837760#comment-17837760
]
Walter Hernandez edited comment on KAFKA-16263 at 4/16/24 3:22 PM:
---
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1567544147
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete,
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1567531204
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete,
[
https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837750#comment-17837750
]
Walter Hernandez commented on KAFKA-15341:
--
[~ckamal] Great work on your merged PR! With it
dongnuo123 commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1567506931
##
group-coordinator/src/main/resources/common/message/ConsumerGroupMemberMetadataValue.json:
##
@@ -35,6 +35,20 @@
{ "name": "RebalanceTimeoutMs", "type":
dongnuo123 commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1567506439
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -998,4 +1088,133 @@ public
chia7712 commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2059291065
> LogManager can accept failed directories in startup. That method is a bit
confusing, but if you look a bit below the line you pointed to, the exception
is caught, the fact the
brandboat commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567499221
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1524,7 +1524,8 @@ object TestUtils extends Logging {
logDirFailureChannel = new
soarez commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567497368
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1524,7 +1524,8 @@ object TestUtils extends Logging {
logDirFailureChannel = new
soarez commented on PR #15718:
URL: https://github.com/apache/kafka/pull/15718#issuecomment-2059275719
Thank you @mimaison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
soarez commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2059274214
@chia7712 Thanks for reviewing this.
> It seems LogManager can't accept failed directories in startup, right?
LogManager can accept failed directories in startup. That method
mimaison commented on PR #15718:
URL: https://github.com/apache/kafka/pull/15718#issuecomment-2059263155
Backported to 3.7 too:
https://github.com/apache/kafka/commit/5d132256d3d8650f16ea3fa83b12b2676b30eed7
--
This is an automated message from the Apache Git Service.
To respond to the
lucasbru commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1567484668
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/RequestStateTest.java:
##
@@ -48,4 +50,51 @@ public void testRequestStateSimple() {
mimaison opened a new pull request, #15734:
URL: https://github.com/apache/kafka/pull/15734
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
soarez commented on code in PR #15732:
URL: https://github.com/apache/kafka/pull/15732#discussion_r1567464913
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -391,13 +391,20 @@ void enqueueMetadataChangeEvent(
// Events
brandboat commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567464576
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1524,7 +1524,8 @@ object TestUtils extends Logging {
logDirFailureChannel = new
brandboat commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567464576
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1524,7 +1524,8 @@ object TestUtils extends Logging {
logDirFailureChannel = new
emitskevich-blp commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2059230580
This is potentially related to [KIP-773
changes](https://github.com/apache/kafka/pull/11302)
@jlprat
--
This is an automated message from the Apache Git Service.
To respond
chia7712 commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567431572
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this
emitskevich-blp commented on PR #15722:
URL: https://github.com/apache/kafka/pull/15722#issuecomment-2059223960
Tests failure is unrelated to PR changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mimaison merged PR #15718:
URL: https://github.com/apache/kafka/pull/15718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
brandboat commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567447761
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -413,7 +413,7 @@ class LogManagerTest {
assertEquals(numMessages * setSize / segmentBytes,
soarez commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567422789
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1524,7 +1524,8 @@ object TestUtils extends Logging {
logDirFailureChannel = new
[
https://issues.apache.org/jira/browse/KAFKA-16417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16417:
Assignee: zhaobo
> When initializeResources throws an exception in
>
soarez commented on code in PR #15718:
URL: https://github.com/apache/kafka/pull/15718#discussion_r1567417492
##
docs/ops.html:
##
@@ -2113,6 +2113,22 @@
chia7712 commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1567414802
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1223,6 +1223,12 @@ class UnifiedLog(@volatile var logStartOffset: Long,
s"but we only have log
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1567414173
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete,
mimaison commented on code in PR #15718:
URL: https://github.com/apache/kafka/pull/15718#discussion_r1567410332
##
docs/ops.html:
##
@@ -2113,6 +2113,22 @@
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1567406313
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +118,57 @@ class AlterReplicaLogDirsRequestTest extends
soarez commented on code in PR #15718:
URL: https://github.com/apache/kafka/pull/15718#discussion_r1567397892
##
docs/ops.html:
##
@@ -2113,6 +2113,22 @@ https://github.com/apache/kafka/assets/1357510/f5ac55bc-2262-40fd-8913-9a83deb4e543;>
--
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-15615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-15615:
Assignee: appchemist
> Improve handling of fetching during metadata updates
>
[
https://issues.apache.org/jira/browse/KAFKA-16554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16554:
Assignee: Dongnuo Lyu
> Online downgrade triggering and group type conversion
>
lianetm commented on PR #15723:
URL: https://github.com/apache/kafka/pull/15723#issuecomment-2059130202
Thanks for the changes @kirktrue , LGTM.
Just thinking out loud to share a concern and reasoning about it. The flag
based approach always makes me think if we would break managers
[
https://issues.apache.org/jira/browse/KAFKA-16561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16561:
Assignee: Yangkun Ai
> Disable `allow.auto.create.topics` in MirrorMaker2
[
https://issues.apache.org/jira/browse/KAFKA-16262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16262:
Assignee: Suprem Vanam
> Add IQv2 to Kafka Streams documentation
>
[
https://issues.apache.org/jira/browse/KAFKA-16262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16262:
Assignee: (was: Walter Hernandez)
> Add IQv2 to Kafka Streams documentation
dajac commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1567372730
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -998,4 +1088,133 @@ public
lianetm commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1567368858
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/RequestStateTest.java:
##
@@ -48,4 +50,51 @@ public void testRequestStateSimple() {
nizhikov commented on code in PR #15729:
URL: https://github.com/apache/kafka/pull/15729#discussion_r1567359782
##
build.gradle:
##
@@ -1239,6 +1239,9 @@ project(':core') {
}
}
}
+ // -parameters generates arguments with parameter names in
mwesterby opened a new pull request, #15733:
URL: https://github.com/apache/kafka/pull/15733
Prevents the storage tool from crashing when some of the directories are
unavailable, but others are still available and have not yet been formatted.
Should all directories be unavailable
mimaison commented on PR #15569:
URL: https://github.com/apache/kafka/pull/15569#issuecomment-2059050678
Let's just let Omnia decides which PR she prefers doing first. Then we can
all review that PR, and once merged move onto the next one. This would avoid
unnecessary churn as I expect
mimaison merged PR #15705:
URL: https://github.com/apache/kafka/pull/15705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #15705:
URL: https://github.com/apache/kafka/pull/15705#issuecomment-2059036435
None of the test failures seem related, merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chia7712 commented on PR #15569:
URL: https://github.com/apache/kafka/pull/15569#issuecomment-2059036032
> hopefully for the last time :)
I feel #15684 will cause many conflicts to this PR, and vice versa :_
--
This is an automated message from the Apache Git Service.
To respond to
dajac commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1567316600
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software
chia7712 commented on code in PR #15729:
URL: https://github.com/apache/kafka/pull/15729#discussion_r1567314494
##
build.gradle:
##
@@ -1239,6 +1239,9 @@ project(':core') {
}
}
}
+ // -parameters generates arguments with parameter names in
chia7712 commented on code in PR #15730:
URL: https://github.com/apache/kafka/pull/15730#discussion_r1567313085
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -90,9 +100,17 @@ public Builder setNumBrokerNodes(int numBrokerNodes) {
if
nizhikov commented on code in PR #15729:
URL: https://github.com/apache/kafka/pull/15729#discussion_r1567309609
##
build.gradle:
##
@@ -1239,6 +1239,9 @@ project(':core') {
}
}
}
+ // -parameters generates arguments with parameter names in
[
https://issues.apache.org/jira/browse/KAFKA-16564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837699#comment-17837699
]
Chia-Ping Tsai commented on KAFKA-16564:
[~ijuma] Could you please take a look at this jira as
[
https://issues.apache.org/jira/browse/KAFKA-16564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16564:
---
Description:
the java code in core module is in scala block, so the jvm compiler arguments
soarez commented on code in PR #15730:
URL: https://github.com/apache/kafka/pull/15730#discussion_r1567303386
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -90,9 +100,17 @@ public Builder setNumBrokerNodes(int numBrokerNodes) {
if
Chia-Ping Tsai created KAFKA-16564:
--
Summary: Apply `Xlint` to java code in core module
Key: KAFKA-16564
URL: https://issues.apache.org/jira/browse/KAFKA-16564
Project: Kafka
Issue Type:
lucasbru merged PR #15724:
URL: https://github.com/apache/kafka/pull/15724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16564:
--
Assignee: Chia-Ping Tsai
> Apply `Xlint` to java code in core module
>
chia7712 commented on code in PR #15729:
URL: https://github.com/apache/kafka/pull/15729#discussion_r1567300055
##
build.gradle:
##
@@ -1239,6 +1239,9 @@ project(':core') {
}
}
}
+ // -parameters generates arguments with parameter names in
gaurav-narula commented on code in PR #15730:
URL: https://github.com/apache/kafka/pull/15730#discussion_r1567295806
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -74,7 +74,7 @@ class KRaftClusterTest {
def testCreateClusterAndClose(): Unit =
chia7712 commented on code in PR #15730:
URL: https://github.com/apache/kafka/pull/15730#discussion_r1567289057
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -74,7 +74,7 @@ class KRaftClusterTest {
def testCreateClusterAndClose(): Unit = {
dajac commented on PR #15717:
URL: https://github.com/apache/kafka/pull/15717#issuecomment-2058988823
@rreddy-22 Thanks for the update. Could you please create a jira for this
task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1567241790
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ClientSideAssignorBenchmark.java:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache Software
showuon commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567254740
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -835,6 +836,7 @@ object KafkaConfig {
.define(CreateTopicPolicyClassNameProp, CLASS, null, LOW,
[
https://issues.apache.org/jira/browse/KAFKA-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16563:
--
Summary: migration to KRaft hanging after MigrationClientException (was:
migration to KRaft hanging
[
https://issues.apache.org/jira/browse/KAFKA-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16563:
--
Description:
When running ZK migrating to KRaft process, we encountered an issue that the
migrating
showuon opened a new pull request, #15732:
URL: https://github.com/apache/kafka/pull/15732
When running ZK migrating to KRaft process, we encountered an issue that the
migrating is hanging and the `ZkMigrationState` cannot move to `MIGRATION`
state. And it is because the pollEvent didn't
dajac commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1567240139
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/AssignPartitionsMicroBenchmark.java:
##
@@ -0,0 +1,153 @@
+package
showuon commented on PR #15732:
URL: https://github.com/apache/kafka/pull/15732#issuecomment-2058930123
@cmccabe @mumrah , call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-16111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-16111:
--
Assignee: (was: Lucas Brutschy)
> Implement tests for tricky rebalance callback
aliehsaeedii opened a new pull request, #15731:
URL: https://github.com/apache/kafka/pull/15731
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
nizhikov commented on PR #15729:
URL: https://github.com/apache/kafka/pull/15729#issuecomment-2058836659
@FrankYang0529 Can you, please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gaurav-narula commented on PR #15730:
URL: https://github.com/apache/kafka/pull/15730#issuecomment-2058820310
CC: @chia7712 @soarez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gaurav-narula opened a new pull request, #15730:
URL: https://github.com/apache/kafka/pull/15730
Overloads `TestKitNodes.Builder::setNumBrokerNodes` to accept a
`disksPerBroker` argument. We keep the existing semantics for the case when
`disksPerBroker == 1`.
### Committer Checklist
nizhikov commented on PR #15729:
URL: https://github.com/apache/kafka/pull/15729#issuecomment-2058801469
Hello @chia7712
I found small bug in #15667
Currently, we don't add '-parameters' compiler option therefore test names
created wrong.
--
This is an automated message from
nizhikov opened a new pull request, #15729:
URL: https://github.com/apache/kafka/pull/15729
All `core` module tests compiled as scala tests, but `-parameters` compiler
option required for junit added only to javatest compiler option. This PR fixes
it.
Before fix:
```
❯
fvaleri commented on PR #15569:
URL: https://github.com/apache/kafka/pull/15569#issuecomment-2058739860
@OmniaGM please rebase, hopefully for the last time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mimaison merged PR #15558:
URL: https://github.com/apache/kafka/pull/15558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on code in PR #15718:
URL: https://github.com/apache/kafka/pull/15718#discussion_r1567073072
##
docs/ops.html:
##
@@ -2113,6 +2113,22 @@ https://github.com/apache/kafka-site)
- extract `core/build/distribution/kafka*-site-docs.tgz` and copy its
content to
Luke Chen created KAFKA-16563:
-
Summary: migration to KRaft hanging after KeeperException
Key: KAFKA-16563
URL: https://issues.apache.org/jira/browse/KAFKA-16563
Project: Kafka
Issue Type: Bug
soarez commented on code in PR #15718:
URL: https://github.com/apache/kafka/pull/15718#discussion_r1567042897
##
docs/ops.html:
##
@@ -2113,6 +2113,22 @@
lucasbru commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1567025166
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##
@@ -66,6 +67,7 @@ public RequestState(final LogContext logContext,
*
[
https://issues.apache.org/jira/browse/KAFKA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837617#comment-17837617
]
ASF GitHub Bot commented on KAFKA-16467:
FrankYang0529 commented on PR #596:
URL:
dajac commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1566918622
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -775,6 +778,72 @@ public ClassicGroup classicGroup(
}
mimaison commented on PR #13321:
URL: https://github.com/apache/kafka/pull/13321#issuecomment-2058597443
To run the `GetOffsetShell` tool you should use the dedicated script
`bin/kafka-get-offsets.sh`.
The error you get is because the class was moved, it's now
chia7712 commented on PR #15684:
URL: https://github.com/apache/kafka/pull/15684#issuecomment-2058593968
@OmniaGM Could you please fix those conflicts? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
101 - 200 of 232 matches
Mail list logo
