Re: [PR] KAFKA-16531: calculate check-quorum when leader is not in voter set [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on PR #16211: URL: https://github.com/apache/kafka/pull/16211#issuecomment-2167362750 @showuon could you please fix the build error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] KAFKA-16918: TestUtils#assertFutureThrows should use future.get with timeout [kafka]

2024-06-13 Thread via GitHub
showuon commented on code in PR #16264: URL: https://github.com/apache/kafka/pull/16264#discussion_r1639358954 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -556,10 +558,22 @@ public static Set generateRandomTopicPartitions(int numTopic, in * @retur

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on code in PR #16310: URL: https://github.com/apache/kafka/pull/16310#discussion_r1639296989 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1666,23 +1668,68 @@ private boolean initWithCommittedOffsetsIfNeed

Re: [PR] KAFKA-16918: TestUtils#assertFutureThrows should use future.get with timeout [kafka]

2024-06-13 Thread via GitHub
showuon commented on code in PR #16264: URL: https://github.com/apache/kafka/pull/16264#discussion_r1639351349 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -556,10 +558,20 @@ public static Set generateRandomTopicPartitions(int numTopic, in * @retur

Re: [PR] KAFKA-16955: fix synchronization of streams threadState [kafka]

2024-06-13 Thread via GitHub
rodesai commented on code in PR #16337: URL: https://github.com/apache/kafka/pull/16337#discussion_r1639348243 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -635,14 +634,10 @@ public void setStandbyUpdateListener(final StandbyUpdateListener standbyL

Re: [PR] KAFKA-16946: Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port [kafka]

2024-06-13 Thread via GitHub
showuon commented on PR #16319: URL: https://github.com/apache/kafka/pull/16319#issuecomment-2167331023 Retriggering CI build: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-16319/6/ -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] MINOR: migrate DescribeConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-06-13 Thread via GitHub
TaiJuWu commented on code in PR #15908: URL: https://github.com/apache/kafka/pull/15908#discussion_r1639336398 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ## @@ -16,834 +16,986 @@ */ package org.apache.kafka.tools.consumer.grou

Re: [PR] KAFKA-16933: New consumer unsubscribe close commit fixes [kafka]

2024-06-13 Thread via GitHub
philipnee commented on code in PR #16272: URL: https://github.com/apache/kafka/pull/16272#discussion_r1639205859 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1512,7 +1513,9 @@ public void unsubscribe() { }

Re: [PR] KAFKA-16921: migrate connect module to junit 5 (Part 2) [kafka]

2024-06-13 Thread via GitHub
m1a2st commented on PR #16330: URL: https://github.com/apache/kafka/pull/16330#issuecomment-2167253065 @chia7712, Thanks for your comment, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16921: migrate connect module to junit 5 (Part 2) [kafka]

2024-06-13 Thread via GitHub
m1a2st commented on code in PR #16330: URL: https://github.com/apache/kafka/pull/16330#discussion_r1639283310 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectIntegrationTestUtils.java: ## @@ -16,28 +16,26 @@ */ package org.apache.kafka.connect.int

Re: [PR] KAFKA-16939: Revisit ConfigCommandIntegrationTest [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on code in PR #16317: URL: https://github.com/apache/kafka/pull/16317#discussion_r1639281603 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -515,14 +524,19 @@ private void deleteAndVerifyConfig(Admin client, Optional brokerId, Set<

Re: [PR] KAFKA-15259: Processing must continue with flush + commitTnx [kafka]

2024-06-13 Thread via GitHub
aliehsaeedii commented on code in PR #16332: URL: https://github.com/apache/kafka/pull/16332#discussion_r1639280799 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -792,6 +792,9 @@ public void sendOffsetsToTransaction(Map offs *

Re: [PR] KAFKA-16862: Refactor ConsumerTaskTest to be deterministic and avoid tight loops [kafka]

2024-06-13 Thread via GitHub
xiaoqingwanga commented on PR #16303: URL: https://github.com/apache/kafka/pull/16303#issuecomment-2167234187 @gharris1727 Hey, I have made all the changes. Please feel free to review the code again. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] KAFKA-16921: migrate connect module to junit 5 (Part 2) [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on code in PR #16330: URL: https://github.com/apache/kafka/pull/16330#discussion_r1639268606 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectIntegrationTestUtils.java: ## @@ -16,28 +16,26 @@ */ package org.apache.kafka.connect.i

Re: [PR] KAFKA-16921: migrate connect module to junit 5 [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on code in PR #16328: URL: https://github.com/apache/kafka/pull/16328#discussion_r1639258794 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/SharedTopicAdminTest.java: ## @@ -46,14 +48,10 @@ public class SharedTopicAdminTest { @Mock private

Re: [PR] KAFKA-16917: Align the returned Map type of KafkaAdminClient [kafka]

2024-06-13 Thread via GitHub
frankvicky commented on PR #16250: URL: https://github.com/apache/kafka/pull/16250#issuecomment-2167221151 Hi @chia7712 , I have fixed the build error, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16752: Implemented acquire functionality for Fetch (KIP-932) [kafka]

2024-06-13 Thread via GitHub
omkreddy merged PR #16274: URL: https://github.com/apache/kafka/pull/16274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15623: Migrate streams tests (part 1) module to JUnit 5 [kafka]

2024-06-13 Thread via GitHub
chia7712 merged PR #16254: URL: https://github.com/apache/kafka/pull/16254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16917: Align the returned Map type of KafkaAdminClient [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on PR #16250: URL: https://github.com/apache/kafka/pull/16250#issuecomment-2167204001 @frankvicky please fix the build error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-10787: Apply spotless to `metadata` and `server` and `storage` module [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on PR #16297: URL: https://github.com/apache/kafka/pull/16297#issuecomment-2167203133 @gongxuanzhang please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-10787: Apply spotless to `group-coordinator` and `group-coordinator-api` [kafka]

2024-06-13 Thread via GitHub
chia7712 merged PR #16298: URL: https://github.com/apache/kafka/pull/16298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] Add documentation for the native docker image [kafka]

2024-06-13 Thread via GitHub
kagarwal06 opened a new pull request, #16338: URL: https://github.com/apache/kafka/pull/16338 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of test

Re: [PR] KAFKA-16895: fix off-by-one bug in RemoteCopyLagSegments [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on PR #16210: URL: https://github.com/apache/kafka/pull/16210#issuecomment-2167190716 @dopuskh3 could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16933: New consumer unsubscribe close commit fixes [kafka]

2024-06-13 Thread via GitHub
philipnee commented on code in PR #16272: URL: https://github.com/apache/kafka/pull/16272#discussion_r1639205859 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1512,7 +1513,9 @@ public void unsubscribe() { }

Re: [PR] KAFKA-16933: New consumer unsubscribe close commit fixes [kafka]

2024-06-13 Thread via GitHub
philipnee commented on code in PR #16272: URL: https://github.com/apache/kafka/pull/16272#discussion_r1639205859 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1512,7 +1513,9 @@ public void unsubscribe() { }

Re: [PR] KAFKA-16933: New consumer unsubscribe close commit fixes [kafka]

2024-06-13 Thread via GitHub
philipnee commented on code in PR #16272: URL: https://github.com/apache/kafka/pull/16272#discussion_r1639205859 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1512,7 +1513,9 @@ public void unsubscribe() { }

Re: [PR] KAFKA-16933: New consumer unsubscribe close commit fixes [kafka]

2024-06-13 Thread via GitHub
philipnee commented on code in PR #16272: URL: https://github.com/apache/kafka/pull/16272#discussion_r1639205859 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1512,7 +1513,9 @@ public void unsubscribe() { }

Re: [PR] KAFKA-16933: New consumer unsubscribe close commit fixes [kafka]

2024-06-13 Thread via GitHub
philipnee commented on code in PR #16272: URL: https://github.com/apache/kafka/pull/16272#discussion_r1639205859 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1512,7 +1513,9 @@ public void unsubscribe() { }

Re: [PR] KAFKA-16948: Reset tier lag metrics on becoming follower [kafka]

2024-06-13 Thread via GitHub
satishd commented on PR #16321: URL: https://github.com/apache/kafka/pull/16321#issuecomment-2167183730 @jlprat This is a bug fix that addresses having a wrong metric in edge case scenarios. It is good to have it merged in 3.8 too. Let me know if you are fine with adding it as part of 3.8

Re: [PR] KAFKA-16933: New consumer unsubscribe close commit fixes [kafka]

2024-06-13 Thread via GitHub
philipnee commented on code in PR #16272: URL: https://github.com/apache/kafka/pull/16272#discussion_r1639205859 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1512,7 +1513,9 @@ public void unsubscribe() { }

Re: [PR] KAFKA-16948: Reset tier lag metrics on becoming follower [kafka]

2024-06-13 Thread via GitHub
satishd merged PR #16321: URL: https://github.com/apache/kafka/pull/16321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15853: Move configDef out of core [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on code in PR #16116: URL: https://github.com/apache/kafka/pull/16116#discussion_r1639198546 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfigs.java: ## @@ -51,4 +60,16 @@ public final class TransactionLogCo

Re: [PR] KAFKA-16531: calculate check-quorum when leader is not in voter set [kafka]

2024-06-13 Thread via GitHub
showuon commented on PR #16211: URL: https://github.com/apache/kafka/pull/16211#issuecomment-2167155537 > @showuon can you update the description? PR description updated. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Fix wrong highWatermark assert equals condition in HighwatermarkPersistenceTest [kafka]

2024-06-13 Thread via GitHub
github-actions[bot] commented on PR #15544: URL: https://github.com/apache/kafka/pull/15544#issuecomment-2167147382 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] MINOR: Refine javadoc in TopicsDelta TopicDelta LocalReplicaChanges [kafka]

2024-06-13 Thread via GitHub
showuon merged PR #16195: URL: https://github.com/apache/kafka/pull/16195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16895: fix off-by-one bug in RemoteCopyLagSegments [kafka]

2024-06-13 Thread via GitHub
kamalcph commented on PR #16210: URL: https://github.com/apache/kafka/pull/16210#issuecomment-2167137194 Test failures are unrelated. The failed test is an existing flaky one: ``` testCorrectnessForCacheAndIndexFilesWhenResizeCache() – kafka.log.remote.RemoteIndexCacheTest ```

Re: [PR] KAFKA-16948: Reset tier lag metrics on becoming follower [kafka]

2024-06-13 Thread via GitHub
kamalcph commented on PR #16321: URL: https://github.com/apache/kafka/pull/16321#issuecomment-2167136261 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15853: Move configDef out of core [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on PR #16116: URL: https://github.com/apache/kafka/pull/16116#issuecomment-2167090246 wait a minute. it seems there are failed tests related to this PR https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-16116/19/tests -- This is

Re: [PR] MINOR: Change KStreamKstreamOuterJoinTest to use distinct left and right types [kafka]

2024-06-13 Thread via GitHub
mjsax commented on PR #15513: URL: https://github.com/apache/kafka/pull/15513#issuecomment-2167050910 Thanks @gharris1727 -- merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Change KStreamKstreamOuterJoinTest to use distinct left and right types [kafka]

2024-06-13 Thread via GitHub
mjsax merged PR #15513: URL: https://github.com/apache/kafka/pull/15513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Add interface for aliveBroker and isShutDwon for Brokers. [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on code in PR #16323: URL: https://github.com/apache/kafka/pull/16323#discussion_r1639102144 ## core/src/test/java/kafka/test/ClusterTestExtensionsTest.java: ## @@ -232,4 +232,17 @@ public void testNotSupportedNewGroupProtocols(ClusterInstance clusterInstance

Re: [PR] KAFKA-16936 : Upgrade slf4j, sys property for provider [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on code in PR #16324: URL: https://github.com/apache/kafka/pull/16324#discussion_r1639091686 ## gradle/dependencies.gradle: ## @@ -237,14 +237,14 @@ libs += [ pcollections: "org.pcollections:pcollections:$versions.pcollections", opentelemetryProto: "io.

Re: [PR] KAFKA-16955: fix synchronization of streams threadState [kafka]

2024-06-13 Thread via GitHub
mjsax commented on code in PR #16337: URL: https://github.com/apache/kafka/pull/16337#discussion_r1639096220 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -635,14 +634,10 @@ public void setStandbyUpdateListener(final StandbyUpdateListener standbyLis

Re: [PR] KAFKA-16933: New consumer unsubscribe close commit fixes [kafka]

2024-06-13 Thread via GitHub
lianetm commented on PR #16272: URL: https://github.com/apache/kafka/pull/16272#issuecomment-2167024740 Build completed with 5 unrelates failures: > Build / JDK 21 and Scala 2.13 / testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest > Build / JDK 21 and Sc

[jira] [Resolved] (KAFKA-16879) SystemTime should use singleton mode

2024-06-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16879. Fix Version/s: 3.9.0 Resolution: Fixed > SystemTime should use singleton mode > ---

Re: [PR] KAFKA-16879 SystemTime should use singleton mode [kafka]

2024-06-13 Thread via GitHub
chia7712 merged PR #16266: URL: https://github.com/apache/kafka/pull/16266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
kirktrue commented on PR #16310: URL: https://github.com/apache/kafka/pull/16310#issuecomment-2167013423 @jlprat—This Jira/PR is a blocker for the KIP-848 Java client work. It sounds like we're really close to merging this within the next day or two. Thanks! -- This is an automated messa

Re: [PR] KAFKA-16862: Refactor ConsumerTaskTest to be deterministic and avoid tight loops [kafka]

2024-06-13 Thread via GitHub
xiaoqingwanga commented on code in PR #16303: URL: https://github.com/apache/kafka/pull/16303#discussion_r1639075718 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -115,40 +118,54 @@ public ConsumerTask(RemotePartitionMetada

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-13 Thread via GitHub
jolshan commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2166998275 Hey Omnia. Thanks for your work (and patience) so far. I will make another deep pass tomorrow or early next week. Things are looking good though. -- This is an automated message fro

Re: [PR] KAFKA-16862: Refactor ConsumerTaskTest to be deterministic and avoid tight loops [kafka]

2024-06-13 Thread via GitHub
xiaoqingwanga commented on code in PR #16303: URL: https://github.com/apache/kafka/pull/16303#discussion_r1639071233 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java: ## @@ -136,46 +128,46 @@ public void testUserTopicIdPartitionE

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-13 Thread via GitHub
jolshan commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1639071024 ## clients/src/main/java/org/apache/kafka/clients/ApiVersions.java: ## @@ -34,10 +34,21 @@ public class ApiVersions { private final Map nodeApiVersions = new Ha

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-13 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1639052751 ## clients/src/main/java/org/apache/kafka/clients/ApiVersions.java: ## @@ -34,10 +34,21 @@ public class ApiVersions { private final Map nodeApiVersions = new Ha

Re: [PR] KAFKA-15853: Move configDef out of core [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on PR #16116: URL: https://github.com/apache/kafka/pull/16116#issuecomment-2166989084 > I think we can squeeze part of this vision in as it will reduce conflict with this work going forward specially with the ongoing work for shared groups and new coordinator which I want

[jira] [Resolved] (KAFKA-16076) RestClient Interrupting the thread in case of InterruptedException

2024-06-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16076. Fix Version/s: 3.9.0 Resolution: Fixed > RestClient Interrupting the thread in case

Re: [PR] KAFKA-16076: Interrupting the currentThread fix [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on PR #15110: URL: https://github.com/apache/kafka/pull/15110#issuecomment-2166983767 this is fixed by #16282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-16076: Interrupting the currentThread fix [kafka]

2024-06-13 Thread via GitHub
chia7712 closed pull request #15110: KAFKA-16076: Interrupting the currentThread fix URL: https://github.com/apache/kafka/pull/15110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] KAFKA-16076: Fix Missing thread interrupt call in RestClient class [kafka]

2024-06-13 Thread via GitHub
chia7712 merged PR #16282: URL: https://github.com/apache/kafka/pull/16282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16076: Fix Missing thread interrupt call in RestClient class [kafka]

2024-06-13 Thread via GitHub
chia7712 commented on PR #16282: URL: https://github.com/apache/kafka/pull/16282#issuecomment-2166982488 all failed tests pass on my local. will merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-13 Thread via GitHub
OmniaGM commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2166980169 @dengziming I noticed that you had a look into this JIRA before and you worked with Justine on the implementations of this KIP before. Would you be able to provide some feedback on this P

[jira] [Updated] (KAFKA-16954) Move consumer leave operations on close to background thread

2024-06-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16954: -- Component/s: clients consumer > Move consumer leave operations on close to background

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-13 Thread via GitHub
OmniaGM commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2166973758 @chia7712 I noticed that you have reviewed parts of KIP-516 before, and I was hoping you have some free time to review this one as well! Thanks in advance -- This is an automated mess

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-13 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1639052751 ## clients/src/main/java/org/apache/kafka/clients/ApiVersions.java: ## @@ -34,10 +34,21 @@ public class ApiVersions { private final Map nodeApiVersions = new Ha

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-13 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1639052751 ## clients/src/main/java/org/apache/kafka/clients/ApiVersions.java: ## @@ -34,10 +34,21 @@ public class ApiVersions { private final Map nodeApiVersions = new Ha

Re: [PR] KAFKA-15853: Move ZKConfigs related static method out of core and into ZKConfigs [kafka]

2024-06-13 Thread via GitHub
OmniaGM closed pull request #16109: KAFKA-15853: Move ZKConfigs related static method out of core and into ZKConfigs URL: https://github.com/apache/kafka/pull/16109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16254: Allow MM2 to fully disable offset sync feature [kafka]

2024-06-13 Thread via GitHub
OmniaGM commented on code in PR #15999: URL: https://github.com/apache/kafka/pull/15999#discussion_r1639050807 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnectorTest.java: ## @@ -50,6 +50,40 @@ public class MirrorCheckpointConnectorTest {

Re: [PR] KAFKA-16254: Allow MM2 to fully disable offset sync feature [kafka]

2024-06-13 Thread via GitHub
OmniaGM commented on code in PR #15999: URL: https://github.com/apache/kafka/pull/15999#discussion_r1639046733 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java: ## @@ -437,6 +437,55 @@ public void testSendSyncEvent() { verify(pro

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
kirktrue commented on PR #16241: URL: https://github.com/apache/kafka/pull/16241#issuecomment-2166953380 Closing this PR as we have achieved consensus around the simpler solution in #16310. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
kirktrue closed pull request #16241: KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively URL: https://github.com/apache/kafka/pull/16241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Assigned] (KAFKA-16955) ConcurrentModification exception thrown by KafkaStream threadState access

2024-06-13 Thread Rohan Desai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohan Desai reassigned KAFKA-16955: --- Assignee: Rohan Desai > ConcurrentModification exception thrown by KafkaStream threadState

[PR] KAFKA-16955: fix synchronization of streams threadState [kafka]

2024-06-13 Thread via GitHub
rodesai opened a new pull request, #16337: URL: https://github.com/apache/kafka/pull/16337 Each KafkaStreams instance maintains a map from threadId to state to use to aggregate to a KafkaStreams app state. The map is updated on every state change, and when a new thread is created. State cha

[jira] [Updated] (KAFKA-16955) ConcurrentModification exception thrown by KafkaStream threadState access

2024-06-13 Thread Rohan Desai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohan Desai updated KAFKA-16955: Affects Version/s: 3.7.0 > ConcurrentModification exception thrown by KafkaStream threadState acce

[jira] [Updated] (KAFKA-16955) ConcurrentModification exception thrown by KafkaStream threadState access

2024-06-13 Thread Rohan Desai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohan Desai updated KAFKA-16955: Component/s: streams > ConcurrentModification exception thrown by KafkaStream threadState access >

[jira] [Created] (KAFKA-16955) ConcurrentModification exception thrown by KafkaStream threadState access

2024-06-13 Thread Rohan Desai (Jira)
Rohan Desai created KAFKA-16955: --- Summary: ConcurrentModification exception thrown by KafkaStream threadState access Key: KAFKA-16955 URL: https://issues.apache.org/jira/browse/KAFKA-16955 Project: Kafk

Re: [PR] KAFKA-16254: Allow MM2 to fully disable offset sync feature [kafka]

2024-06-13 Thread via GitHub
OmniaGM commented on code in PR #15999: URL: https://github.com/apache/kafka/pull/15999#discussion_r1639020762 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConfig.java: ## @@ -252,7 +252,13 @@ private static ConfigDef defineCheckpointConfig(Con

Re: [PR] MINOR: update Kafka Streams docs with 3.3 KIP information [kafka]

2024-06-13 Thread via GitHub
mjsax commented on PR #16316: URL: https://github.com/apache/kafka/pull/16316#issuecomment-2166888575 Merged to `trunk` and cherry-picked to `3.8` and all the way back to `3.3`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
kirktrue commented on code in PR #16310: URL: https://github.com/apache/kafka/pull/16310#discussion_r1639005027 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -574,6 +581,148 @@ public void testPollLongThrowsException() {

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
kirktrue commented on code in PR #16310: URL: https://github.com/apache/kafka/pull/16310#discussion_r1639004424 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -574,6 +575,93 @@ public void testPollLongThrowsException() {

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
kirktrue commented on code in PR #16310: URL: https://github.com/apache/kafka/pull/16310#discussion_r1639004097 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -574,6 +575,93 @@ public void testPollLongThrowsException() {

Re: [PR] MINOR: update Kafka Streams docs with 3.3 KIP information [kafka]

2024-06-13 Thread via GitHub
mjsax merged PR #16316: URL: https://github.com/apache/kafka/pull/16316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: update Kafka Streams docs with 3.3 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16316: URL: https://github.com/apache/kafka/pull/16316#discussion_r1638978091 ## docs/ops.html: ## @@ -3100,7 +3100,8 @@ Processor Node Metrics The following metrics are only available on certain types of nodes, i.e., the process-* metrics

Re: [PR] MINOR: update Kafka Streams docs with 3.2 KIP information [kafka]

2024-06-13 Thread via GitHub
mjsax commented on PR #16313: URL: https://github.com/apache/kafka/pull/16313#issuecomment-2166877068 Merged to `trunk` and cherry-picked to `3.8` and all the way back to `3.2`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
kirktrue commented on PR #16310: URL: https://github.com/apache/kafka/pull/16310#issuecomment-2166875819 @AndrewJSchofield @cadonna @lianetm @philipnee: this PR is ready to be re-reviewed. Thanks all for your input 😄 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
kirktrue commented on code in PR #16310: URL: https://github.com/apache/kafka/pull/16310#discussion_r1638998663 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -574,6 +581,148 @@ public void testPollLongThrowsException() {

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
kirktrue commented on code in PR #16310: URL: https://github.com/apache/kafka/pull/16310#discussion_r1638996787 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1666,13 +1668,28 @@ private boolean initWithCommittedOffsetsIfNeed

Re: [PR] MINOR: update Kafka Streams docs with 3.4 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16336: URL: https://github.com/apache/kafka/pull/16336#discussion_r1638992064 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,35 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupp

Re: [PR] MINOR: update Kafka Streams docs with 3.2 KIP information [kafka]

2024-06-13 Thread via GitHub
mjsax merged PR #16313: URL: https://github.com/apache/kafka/pull/16313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: update Kafka Streams docs with 3.4 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16336: URL: https://github.com/apache/kafka/pull/16336#discussion_r1638991305 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,35 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupp

[PR] MINOR: update Kafka Streams docs with 3.4 KIP information [kafka]

2024-06-13 Thread via GitHub
mjsax opened a new pull request, #16336: URL: https://github.com/apache/kafka/pull/16336 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-13 Thread via GitHub
kirktrue commented on code in PR #16310: URL: https://github.com/apache/kafka/pull/16310#discussion_r1638982381 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -574,6 +581,148 @@ public void testPollLongThrowsException() {

Re: [PR] MINOR: update Kafka Streams docs with 3.2 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16313: URL: https://github.com/apache/kafka/pull/16313#discussion_r1638981849 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,61 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupp

Re: [PR] MINOR: update Kafka Streams docs with 3.2 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16313: URL: https://github.com/apache/kafka/pull/16313#discussion_r1638981412 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,61 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupp

Re: [PR] MINOR: update Kafka Streams docs with 3.2 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16313: URL: https://github.com/apache/kafka/pull/16313#discussion_r1638981274 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,61 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupp

Re: [PR] MINOR: update Kafka Streams docs with 3.2 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16313: URL: https://github.com/apache/kafka/pull/16313#discussion_r1638980584 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,61 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupp

Re: [PR] MINOR: update Kafka Streams docs with 3.2 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16313: URL: https://github.com/apache/kafka/pull/16313#discussion_r1638980302 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,61 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupp

Re: [PR] MINOR: update Kafka Streams docs with 3.2 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16313: URL: https://github.com/apache/kafka/pull/16313#discussion_r1638980033 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,61 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupp

Re: [PR] MINOR: update Kafka Streams docs with 3.2 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16313: URL: https://github.com/apache/kafka/pull/16313#discussion_r1638979649 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,61 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupp

Re: [PR] MINOR: update Kafka Streams docs with 3.3 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16316: URL: https://github.com/apache/kafka/pull/16316#discussion_r1638978368 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,62 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupp

Re: [PR] MINOR: update Kafka Streams docs with 3.3 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16316: URL: https://github.com/apache/kafka/pull/16316#discussion_r1638978091 ## docs/ops.html: ## @@ -3100,7 +3100,8 @@ Processor Node Metrics The following metrics are only available on certain types of nodes, i.e., the process-* metrics

Re: [PR] MINOR: update Kafka Streams docs with 3.3 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16316: URL: https://github.com/apache/kafka/pull/16316#discussion_r1638977635 ## docs/ops.html: ## @@ -3100,7 +3100,8 @@ Processor Node Metrics The following metrics are only available on certain types of nodes, i.e., the process-* metrics

Re: [PR] MINOR: update Kafka Streams docs with 3.3 KIP information [kafka]

2024-06-13 Thread via GitHub
JimGalasyn commented on code in PR #16316: URL: https://github.com/apache/kafka/pull/16316#discussion_r1638977463 ## docs/ops.html: ## @@ -3100,7 +3100,8 @@ Processor Node Metrics The following metrics are only available on certain types of nodes, i.e., the process-* metrics

  1   2   3   >