Re: [PR] KAFKA-16954: fix consumer close to release assignment in background [kafka]

2024-06-18 Thread via GitHub
jlprat commented on PR #16376: URL: https://github.com/apache/kafka/pull/16376#issuecomment-2175307992 Thanks @lucasbru , closed the Jira issue as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] MINOR: update documentation link to 3.8 [kafka]

2024-06-18 Thread via GitHub
jlprat opened a new pull request, #16382: URL: https://github.com/apache/kafka/pull/16382 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[jira] [Updated] (KAFKA-16983) Generate and merge/release the PR for Docker Official Images repo

2024-06-18 Thread Krish Vora (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krish Vora updated KAFKA-16983: --- Summary: Generate and merge/release the PR for Docker Official Images repo (was: Generate the PR fo

[jira] [Reopened] (KAFKA-16983) Generate the PR for Docker Official Images repo

2024-06-18 Thread Krish Vora (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krish Vora reopened KAFKA-16983: > Generate the PR for Docker Official Images repo > --- >

[jira] [Updated] (KAFKA-16978) Apache Kafka 3.7.0 Docker Official Image release

2024-06-18 Thread Krish Vora (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krish Vora updated KAFKA-16978: --- Description: Steps to release Docker Official Image as post-release process: # {*}Prepare Docker Of

[jira] [Updated] (KAFKA-16978) Apache Kafka 3.7.0 Docker Official Image release

2024-06-18 Thread Krish Vora (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krish Vora updated KAFKA-16978: --- Description: Steps to release Docker Official Image as post-release process: # {*}Prepare Docker

[jira] [Updated] (KAFKA-16978) Apache Kafka 3.7.0 Docker Official Image release

2024-06-18 Thread Krish Vora (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krish Vora updated KAFKA-16978: --- Description: Steps to release Docker Official Image as post-release process: # {*}Prepare Docker Of

Re: [PR] KAFKA-16749: Implemented share fetch messages (KIP-932) [kafka]

2024-06-18 Thread via GitHub
AndrewJSchofield commented on code in PR #16377: URL: https://github.com/apache/kafka/pull/16377#discussion_r164433 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -317,6 +364,197 @@ public void close() throws Exception { // TODO: Provide

Re: [PR] MINOR: update documentation link to 3.8 [kafka]

2024-06-18 Thread via GitHub
jlprat commented on PR #16382: URL: https://github.com/apache/kafka/pull/16382#issuecomment-2175509041 I'm merging this as this doesn't affect CI. Also backporting to 3.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-18 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1644074097 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala: ## @@ -92,6 +92,7 @@ class GroupCoordinatorTest { private val protocolSuperset = List

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-18 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1644080966 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -608,40 +608,55 @@ class KafkaApis(val requestChannel: RequestChannel, } } -val unauthorize

Re: [PR] MINOR: update documentation link to 3.8 [kafka]

2024-06-18 Thread via GitHub
jlprat merged PR #16382: URL: https://github.com/apache/kafka/pull/16382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-18 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1644094646 ## clients/src/test/java/org/apache/kafka/common/requests/ProduceRequestTest.java: ## @@ -120,15 +121,38 @@ public void testBuildWithCurrentMessageFormat() { P

Re: [PR] MINOR: Don't swallow validateReconfiguration exceptions [kafka]

2024-06-18 Thread via GitHub
rajinisivaram commented on code in PR #16346: URL: https://github.com/apache/kafka/pull/16346#discussion_r1644085534 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -640,8 +640,8 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Log

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-18 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1644119109 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java: ## @@ -51,13 +52,20 @@ public static Builder forMagic(byte magic, ProduceRequestData dat

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

2024-06-18 Thread via GitHub
dajac commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644109817 ## server-common/src/main/java/org/apache/kafka/server/common/GroupVersion.java: ## @@ -22,7 +22,7 @@ public enum GroupVersion implements FeatureVersion { // Vers

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-18 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1644115910 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java: ## @@ -126,15 +134,15 @@ public ProduceRequest(ProduceRequestData produceRequestData, sh

Re: [PR] MINOR: Fix doc for zookeeper.ssl.client.enable [kafka]

2024-06-18 Thread via GitHub
mimaison commented on PR #16374: URL: https://github.com/apache/kafka/pull/16374#issuecomment-2175725193 With the fix: https://github.com/apache/kafka/assets/903615/875e7c4a-fb60-4ea0-ba4c-8e4f5827655c";> -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-16921: Migrate test of connect module to Junit5 (Runtime direct) [kafka]

2024-06-18 Thread via GitHub
chia7712 merged PR #16351: URL: https://github.com/apache/kafka/pull/16351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Refresh of the docs [kafka]

2024-06-18 Thread via GitHub
mimaison commented on PR #16375: URL: https://github.com/apache/kafka/pull/16375#issuecomment-2175737130 It's not easy since this includes changes all over the website. Like for code changes, reviewers should test this change locally. -- This is an automated message from the Apache Git S

Re: [PR] MINOR: Fix doc for zookeeper.ssl.client.enable [kafka]

2024-06-18 Thread via GitHub
showuon commented on PR #16374: URL: https://github.com/apache/kafka/pull/16374#issuecomment-2175737419 Looks great! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-16921: Migrate test of Stream module to Junit5 (Stream state) [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on PR #16356: URL: https://github.com/apache/kafka/pull/16356#issuecomment-2175742237 @m1a2st Could you please update the jira number? It should be KAFKA-15623, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16921: Migrate test of connect module to Junit5 (Runtime subpackage) [kafka]

2024-06-18 Thread via GitHub
chia7712 merged PR #16350: URL: https://github.com/apache/kafka/pull/16350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-16976) Improve the dynamic config handling for RemoteLogManagerConfig when a broker is restarted.

2024-06-18 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash reassigned KAFKA-16976: Assignee: (was: Kamal Chandraprakash) > Improve the dynamic config ha

[jira] [Updated] (KAFKA-16948) Reset tier lag metrics on becoming follower

2024-06-18 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-16948: - Issue Type: Bug (was: Task) > Reset tier lag metrics on becoming follower > ---

Re: [PR] KAFKA-16921: Migrate test of Stream module to Junit5 (Stream state) [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on code in PR #16356: URL: https://github.com/apache/kafka/pull/16356#discussion_r1644229011 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatterTest.java: ## @@ -18,61 +18,49 @@ import static org.hamc

Re: [PR] KAFKA-16969: Log error if config conficts with MV [kafka]

2024-06-18 Thread via GitHub
soarez commented on PR #16366: URL: https://github.com/apache/kafka/pull/16366#issuecomment-2175775274 Thanks @showuon ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15623 Migrate remaining tests in streams module to JUnit 5 (integration & internals) [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on PR #16360: URL: https://github.com/apache/kafka/pull/16360#issuecomment-217532 @brandboat please take a look at failed tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16936 : Upgrade slf4j, sys property for provider [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on code in PR #16324: URL: https://github.com/apache/kafka/pull/16324#discussion_r1644239189 ## build.gradle: ## @@ -928,14 +928,15 @@ project(':server') { implementation libs.jacksonDatabind implementation libs.slf4jApi +implementation libs.sl

Re: [PR] KAFKA-16957: Enable KafkaConsumerTest#configurableObjectsShouldSeeGeneratedClientId to work with CLASSIC and CONSUMER [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on PR #16370: URL: https://github.com/apache/kafka/pull/16370#issuecomment-2175788472 @chiacyu could you please rebase code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-16976) Improve the dynamic config handling for RemoteLogManagerConfig when a broker is restarted.

2024-06-18 Thread Chia Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855873#comment-17855873 ] Chia Chuan Yu commented on KAFKA-16976: --- Hi,[~satish.duggana]  Can I have this on

Re: [PR] KAFKA-16547: Add test for DescribeConfigsOptions#includeDocumentation [kafka]

2024-06-18 Thread via GitHub
chia7712 merged PR #16355: URL: https://github.com/apache/kafka/pull/16355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-16547) add test for DescribeConfigsOptions#includeDocumentation

2024-06-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16547. Fix Version/s: 3.9.0 Resolution: Fixed > add test for DescribeConfigsOptions#includ

Re: [PR] MINOR: use 2 logdirs in ZK migration system tests [kafka]

2024-06-18 Thread via GitHub
soarez merged PR #15394: URL: https://github.com/apache/kafka/pull/15394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-16958 add STRICT_STUBS to EndToEndLatencyTest, OffsetCommitCallbackInvokerTest, ProducerPerformanceTest, and TopologyTest [kafka]

2024-06-18 Thread via GitHub
chia7712 merged PR #16348: URL: https://github.com/apache/kafka/pull/16348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-16958) add `STRICT_STUBS` to `EndToEndLatencyTest`, `OffsetCommitCallbackInvokerTest`, `ProducerPerformanceTest`, and `TopologyTest`

2024-06-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16958. Fix Version/s: 3.9.0 Resolution: Fixed > add `STRICT_STUBS` to `EndToEndLatencyTest

Re: [PR] KAFKA-10787: Apply spotless to `streams:examples` and `streams-scala` [kafka]

2024-06-18 Thread via GitHub
chia7712 merged PR #16378: URL: https://github.com/apache/kafka/pull/16378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Refresh of the docs [kafka]

2024-06-18 Thread via GitHub
mimaison commented on PR #16375: URL: https://github.com/apache/kafka/pull/16375#issuecomment-2175856402 If it's a pain to review, I can split the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] MINOR: Fix doc for zookeeper.ssl.client.enable [kafka]

2024-06-18 Thread via GitHub
mimaison commented on PR #16374: URL: https://github.com/apache/kafka/pull/16374#issuecomment-2175857110 None of the test failures are related, merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] MINOR: Fix doc for zookeeper.ssl.client.enable [kafka]

2024-06-18 Thread via GitHub
mimaison merged PR #16374: URL: https://github.com/apache/kafka/pull/16374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Fix doc for zookeeper.ssl.client.enable [kafka]

2024-06-18 Thread via GitHub
jlprat commented on PR #16374: URL: https://github.com/apache/kafka/pull/16374#issuecomment-2175862809 @mimaison will you cherry-pick it to `3.8` or shall I do it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-16725: Adjust share group configs to match KIP [kafka]

2024-06-18 Thread via GitHub
omkreddy commented on code in PR #16368: URL: https://github.com/apache/kafka/pull/16368#discussion_r1644289936 ## server/src/main/java/org/apache/kafka/server/config/ShareGroupConfigs.java: ## @@ -88,9 +88,9 @@ public class ShareGroupConfigs { public static final ConfigDef

Re: [PR] MINOR: Fix doc for zookeeper.ssl.client.enable [kafka]

2024-06-18 Thread via GitHub
mimaison commented on PR #16374: URL: https://github.com/apache/kafka/pull/16374#issuecomment-2175866186 I cherry-picked it to 3.8: https://github.com/apache/kafka/commit/6669c3050ed6f1b4fab63742994ff00ee958c0c9 -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] MINOR: Fix doc for zookeeper.ssl.client.enable [kafka]

2024-06-18 Thread via GitHub
jlprat commented on PR #16374: URL: https://github.com/apache/kafka/pull/16374#issuecomment-2175867344 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] KAFKA-16936 : Upgrade slf4j, sys property for provider [kafka]

2024-06-18 Thread via GitHub
mimaison commented on code in PR #16324: URL: https://github.com/apache/kafka/pull/16324#discussion_r1644295632 ## build.gradle: ## @@ -928,14 +928,15 @@ project(':server') { implementation libs.jacksonDatabind implementation libs.slf4jApi +implementation libs.sl

Re: [PR] KAFKA-14511: extend AlterIncrementalConfigs API to support group config [kafka]

2024-06-18 Thread via GitHub
AndrewJSchofield commented on code in PR #15067: URL: https://github.com/apache/kafka/pull/15067#discussion_r1644173569 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3054,6 +3054,8 @@ class KafkaApis(val requestChannel: RequestChannel, authHelper.authori

Re: [PR] KAFKA-15623, Migrate test of Stream module to Junit5 (Stream state) [kafka]

2024-06-18 Thread via GitHub
m1a2st commented on PR #16356: URL: https://github.com/apache/kafka/pull/16356#issuecomment-2175916646 @chia7712, Thanks for your comments, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Assigned] (KAFKA-13898) metrics.recording.level is underdocumented

2024-06-18 Thread Ksolves (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ksolves reassigned KAFKA-13898: --- Assignee: Ksolves (was: Richard Joerger) > metrics.recording.level is underdocumented > --

[jira] [Commented] (KAFKA-13898) metrics.recording.level is underdocumented

2024-06-18 Thread Ksolves (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855901#comment-17855901 ] Ksolves commented on KAFKA-13898: - I can pick this up and update the document. > metric

[jira] [Comment Edited] (KAFKA-16986) After upgrading to Kafka 3.4.1, the producer constantly produces logs related to topicId changes

2024-06-18 Thread Vinicius Vieira dos Santos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855773#comment-17855773 ] Vinicius Vieira dos Santos edited comment on KAFKA-16986 at 6/18/24 11:54 AM:

Re: [PR] KAFKA-16988: add 1 more node for test_exactly_once_source system test [kafka]

2024-06-18 Thread via GitHub
soarez merged PR #16379: URL: https://github.com/apache/kafka/pull/16379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] MINOR: Refresh of the docs [kafka]

2024-06-18 Thread via GitHub
showuon commented on PR #16375: URL: https://github.com/apache/kafka/pull/16375#issuecomment-2175941712 > If it's a pain to review, I can split the PR. It's fine. It looks good. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[PR] KAFKA-16921: Migrate test of connect module to Junit5 (Remove junit 4 dependency) [kafka]

2024-06-18 Thread via GitHub
m1a2st opened a new pull request, #16383: URL: https://github.com/apache/kafka/pull/16383 remove junit 4 dependency from connect module, and fix some class which miss ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

Re: [PR] KAFKA-16988: add 1 more node for test_exactly_once_source system test [kafka]

2024-06-18 Thread via GitHub
soarez commented on PR #16379: URL: https://github.com/apache/kafka/pull/16379#issuecomment-2175953794 Backported to branches 3.8 and 3.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Resolved] (KAFKA-16988) InsufficientResourcesError in ConnectDistributedTest system test

2024-06-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat resolved KAFKA-16988. Resolution: Fixed > InsufficientResourcesError in ConnectDistributedTest system test > ---

[jira] [Updated] (KAFKA-16988) InsufficientResourcesError in ConnectDistributedTest system test

2024-06-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-16988: --- Fix Version/s: 3.8.0 3.7.1 > InsufficientResourcesError in ConnectDistributedTest

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-06-18 Thread via GitHub
showuon commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1644362575 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -47,7 +47,7 @@ // Version 15 is the same as version 14 (KIP-903). // // Version 16 adds

[jira] [Commented] (KAFKA-14080) too many node disconnected message in kafka-clients

2024-06-18 Thread Nicolas Guyomar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855927#comment-17855927 ] Nicolas Guyomar commented on KAFKA-14080: - I'm only now noticing some bugs were

[jira] [Commented] (KAFKA-13679) Superfluous node disconnected log messages

2024-06-18 Thread Nicolas Guyomar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855926#comment-17855926 ] Nicolas Guyomar commented on KAFKA-13679: - I'm only now noticing some bugs were

Re: [PR] KAFKA-16725: Adjust share group configs to match KIP [kafka]

2024-06-18 Thread via GitHub
AndrewJSchofield commented on code in PR #16368: URL: https://github.com/apache/kafka/pull/16368#discussion_r1644402003 ## server/src/main/java/org/apache/kafka/server/config/ShareGroupConfigs.java: ## @@ -88,9 +88,9 @@ public class ShareGroupConfigs { public static final C

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

2024-06-18 Thread via GitHub
cmccabe commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2176042112 > @cmccabe : https://github.com/apache/kafka/pull/15673 is fixing a mistake that shouldn't be in 3.8.0. We should have bumped up the API version for ListOffset, but we didn't. To me, that

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

2024-06-18 Thread via GitHub
cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644425919 ## server-common/src/main/java/org/apache/kafka/server/common/GroupVersion.java: ## @@ -22,7 +22,7 @@ public enum GroupVersion implements FeatureVersion { // Ve

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

2024-06-18 Thread via GitHub
cmccabe commented on code in PR #16347: URL: https://github.com/apache/kafka/pull/16347#discussion_r1644427304 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -202,11 +202,20 @@ public enum MetadataVersion { // Add new fetch request

Re: [PR] KAFKA-16725: Adjust share group configs to match KIP [kafka]

2024-06-18 Thread via GitHub
omkreddy commented on code in PR #16368: URL: https://github.com/apache/kafka/pull/16368#discussion_r1644474270 ## server/src/main/java/org/apache/kafka/server/config/ShareGroupConfigs.java: ## @@ -88,9 +88,9 @@ public class ShareGroupConfigs { public static final ConfigDef

Re: [PR] KAFKA-16936 : Upgrade slf4j, sys property for provider [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on code in PR #16324: URL: https://github.com/apache/kafka/pull/16324#discussion_r1644499138 ## build.gradle: ## @@ -928,14 +928,15 @@ project(':server') { implementation libs.jacksonDatabind implementation libs.slf4jApi +implementation libs.sl

Re: [PR] KAFKA-16952: Do not bump broker epoch when re-registering the same incarnation [kafka]

2024-06-18 Thread via GitHub
cmccabe merged PR #16333: URL: https://github.com/apache/kafka/pull/16333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-16989) Use StringBuilder instead of string concatenation

2024-06-18 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16989: -- Summary: Use StringBuilder instead of string concatenation Key: KAFKA-16989 URL: https://issues.apache.org/jira/browse/KAFKA-16989 Project: Kafka Issue T

[jira] [Commented] (KAFKA-16989) Use StringBuilder instead of string concatenation

2024-06-18 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855954#comment-17855954 ] TengYao Chi commented on KAFKA-16989: - Gentle ping [~chia7712]  If you are not start

[jira] [Updated] (KAFKA-16986) After upgrading to Kafka 3.4.1, the producer constantly produces logs related to topicId changes

2024-06-18 Thread Vinicius Vieira dos Santos (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinicius Vieira dos Santos updated KAFKA-16986: --- Affects Version/s: 3.6.1 > After upgrading to Kafka 3.4.1, the produ

[jira] [Assigned] (KAFKA-16989) Use StringBuilder instead of string concatenation

2024-06-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16989: -- Assignee: TengYao Chi (was: Chia-Ping Tsai) > Use StringBuilder instead of string co

[PR] KAFKA-16967: NioEchoServer fails to register connection and causes flaky failure. [kafka]

2024-06-18 Thread via GitHub
frankvicky opened a new pull request, #16384: URL: https://github.com/apache/kafka/pull/16384 The issue involves the `NioEchoServer` crashing when attempting to register new connections due to a connection already being registered. This problem is specifically in the test methods(`testUngr

Re: [PR] MINOR: Refresh of the docs [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on code in PR #16375: URL: https://github.com/apache/kafka/pull/16375#discussion_r1644574034 ## docs/streams/developer-guide/app-reset-tool.html: ## @@ -78,9 +78,9 @@ Step 1: Run the application reset tool Invoke the application reset

Re: [PR] KAFKA-16921: Remove junit 4 dependency from connect:runtime module [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on PR #16383: URL: https://github.com/apache/kafka/pull/16383#issuecomment-2176280860 @m1a2st could you please remove 'org.apache.kafka.test.IntegrationTest' from `build.gradle`? https://github.com/apache/kafka/blob/trunk/build.gradle#L527 https://github.com/apac

[jira] [Resolved] (KAFKA-16941) Flaky test - testDynamicBrokerConfigUpdateUsingKraft [1] Type=Raft-Combined, MetadataVersion=4.0-IV0,Security=PLAINTEXT – kafka.admin.ConfigCommandIntegrationTest

2024-06-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16941. Resolution: Duplicate the flaky will get fixed by KAFKA-16939 > Flaky test - testDynamicB

Re: [PR] MINOR: Refresh of the docs [kafka]

2024-06-18 Thread via GitHub
mimaison commented on code in PR #16375: URL: https://github.com/apache/kafka/pull/16375#discussion_r1644600311 ## docs/streams/developer-guide/app-reset-tool.html: ## @@ -78,9 +78,9 @@ Step 1: Run the application reset tool Invoke the application reset

[PR] KAFKA-16989: Use StringBuilder instead of String concatenation [kafka]

2024-06-18 Thread via GitHub
frankvicky opened a new pull request, #16385: URL: https://github.com/apache/kafka/pull/16385 Currently, the String concatenation in `ClientQuotasImageNode` might be a heavy cost, so it should be replace with `StringBuilder` ### Committer Checklist (excluded from commit message) -

Re: [PR] KAFKA-16989: Use StringBuilder instead of String concatenation [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on code in PR #16385: URL: https://github.com/apache/kafka/pull/16385#discussion_r1644605641 ## metadata/src/main/java/org/apache/kafka/image/node/ClientQuotasImageNode.java: ## @@ -127,20 +127,20 @@ static ClientQuotaEntity decodeEntity(String input) {

Re: [PR] MINOR: consumer log fixes [kafka]

2024-06-18 Thread via GitHub
chia7712 merged PR #16345: URL: https://github.com/apache/kafka/pull/16345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Refresh of the docs [kafka]

2024-06-18 Thread via GitHub
mimaison commented on PR #16375: URL: https://github.com/apache/kafka/pull/16375#issuecomment-2176341868 Since all changes are to `.html` files, I'll not wait for tests to complete. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] KAFKA-16989: Use StringBuilder instead of String concatenation [kafka]

2024-06-18 Thread via GitHub
frankvicky commented on PR #16385: URL: https://github.com/apache/kafka/pull/16385#issuecomment-2176349274 Hi @chia7712 , I have make a small change based on feedback, PTAL 😺 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

2024-06-18 Thread via GitHub
dajac commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2176354721 @cmccabe I don't see the last changes. Did you push? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] MINOR: Refresh of the docs [kafka]

2024-06-18 Thread via GitHub
mimaison merged PR #16375: URL: https://github.com/apache/kafka/pull/16375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

2024-06-18 Thread via GitHub
cmccabe commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2176365238 @dajac Just pushed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Commented] (KAFKA-16986) After upgrading to Kafka 3.4.1, the producer constantly produces logs related to topicId changes

2024-06-18 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855973#comment-17855973 ] Justine Olshan commented on KAFKA-16986: To be clear, this will be a thing that

Re: [PR] KAFKA-16772: Introduce kraft.version to support KIP-853 [kafka]

2024-06-18 Thread via GitHub
jsancio commented on PR #16230: URL: https://github.com/apache/kafka/pull/16230#issuecomment-2176402435 > We also currently don't propagate control records to the metadata layer, so that is something we'd have to consider changing. We actually do, I changed this in this PR https://gi

Re: [PR] KAFKA-16936 : Upgrade slf4j, sys property for provider [kafka]

2024-06-18 Thread via GitHub
gharris1727 commented on code in PR #16324: URL: https://github.com/apache/kafka/pull/16324#discussion_r1644671854 ## build.gradle: ## @@ -928,14 +928,15 @@ project(':server') { implementation libs.jacksonDatabind implementation libs.slf4jApi +implementation libs

[PR] MINOR: Add docs for replica.alter.log.dirs.io.max.bytes.per.second co… [kafka]

2024-06-18 Thread via GitHub
mimaison opened a new pull request, #16386: URL: https://github.com/apache/kafka/pull/16386 …nfig ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (i

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2024-06-18 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r1644705014 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -891,11 +900,20 @@ private void sendProduceRequest(long now, int destination, s

[PR] KAFKA-16972: Move BrokerTopicMetrics and AggregatedMetric to org.apache.kafka.storage.log.metrics [kafka]

2024-06-18 Thread via GitHub
FrankYang0529 opened a new pull request, #16387: URL: https://github.com/apache/kafka/pull/16387 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-06-18 Thread via GitHub
jsancio commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1644714171 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -47,7 +47,7 @@ // Version 15 is the same as version 14 (KIP-903). // // Version 16 adds

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-06-18 Thread via GitHub
jsancio commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1644723447 ## clients/src/main/resources/common/message/BeginQuorumEpochRequest.json: ## @@ -18,24 +18,37 @@ "type": "request", "listeners": ["controller"], "name": "Begi

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-06-18 Thread via GitHub
jsancio commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1644728890 ## clients/src/main/resources/common/message/BeginQuorumEpochResponse.json: ## @@ -17,25 +17,35 @@ "apiKey": 53, "type": "response", "name": "BeginQuorumEpochR

[jira] [Assigned] (KAFKA-16961) TestKRaftUpgrade system tests fail in v3.7.1 RC1

2024-06-18 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-16961: --- Assignee: Igor Soarez > TestKRaftUpgrade system tests fail in v3.7.1 RC1 >

Re: [PR] KAFKA-16936 : Upgrade slf4j, sys property for provider [kafka]

2024-06-18 Thread via GitHub
chia7712 commented on code in PR #16324: URL: https://github.com/apache/kafka/pull/16324#discussion_r1644732202 ## build.gradle: ## @@ -928,14 +928,15 @@ project(':server') { implementation libs.jacksonDatabind implementation libs.slf4jApi +implementation libs.sl

Re: [PR] KAFKA-16753: Implement share acknowledge API in partition (KIP-932) [kafka]

2024-06-18 Thread via GitHub
apoorvmittal10 commented on PR #16339: URL: https://github.com/apache/kafka/pull/16339#issuecomment-2176483247 @omkreddy Build completed with unrelated tests failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-16968: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0 [kafka]

2024-06-18 Thread via GitHub
junrao commented on PR #16347: URL: https://github.com/apache/kafka/pull/16347#issuecomment-2176493383 > Maybe someone can explain more about what https://github.com/apache/kafka/pull/15673 does exactly. @cmccabe : The main issue that https://github.com/apache/kafka/pull/15673 fixes

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-06-18 Thread via GitHub
jsancio commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1644744458 ## clients/src/main/resources/common/message/EndQuorumEpochRequest.json: ## @@ -18,26 +18,41 @@ "type": "request", "listeners": ["controller"], "name": "EndQuo

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-06-18 Thread via GitHub
jsancio commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1644744740 ## clients/src/main/resources/common/message/EndQuorumEpochResponse.json: ## @@ -17,25 +17,35 @@ "apiKey": 54, "type": "response", "name": "EndQuorumEpochRespo

Re: [PR] KAFKA-16527; Implement request handling for updated KRaft RPCs [kafka]

2024-06-18 Thread via GitHub
jsancio commented on code in PR #16235: URL: https://github.com/apache/kafka/pull/16235#discussion_r1644747026 ## clients/src/main/resources/common/message/FetchSnapshotRequest.json: ## @@ -18,7 +18,7 @@ "type": "request", "listeners": ["controller"], "name": "FetchSnap

[jira] [Assigned] (KAFKA-16990) Unrecognised flag passed to kafka-storage.sh in system test

2024-06-18 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Narula reassigned KAFKA-16990: - Assignee: Gaurav Narula > Unrecognised flag passed to kafka-storage.sh in system test >

  1   2   >